21066490217

Committed 16 Jan 2026 12:22PM UTC coverage: 60.507%. Remained the same

Build # 21066490217

Build Type

push

github

Committed by

web-flow

Commit Message

misc clang-tidy (#853)

* trigger tidy

* Automated clang-tidy change: modernize-use-equals-delete,modernize-make-shared,modernize-make-unique,modernize-use-constraints,readability-container-size-empty,modernize-redundant-void-arg,modernize-use-emplace

* removed non needed macros

* missed to disable tidy build

---------

Co-authored-by: Clang Tidy <clang-tidy@users.noreply.github.com>

Run Details

174 of 248 new or added lines in 74 files covered. (70.16%)

2 existing lines in 2 files now uncovered.

44459 of 73477 relevant lines covered (60.51%)

515895.79 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.42

/pol-core/pol/network/clienttransmit.cpp

#include "clienttransmit.h"

#include <memory>

#include "../../clib/esignal.h"
#include "../../clib/rawtypes.h"
#include "../globals/network.h"
#include "../polsem.h"
#include "client.h"

namespace Pol
{
namespace Network
{
ClientTransmit::ClientTransmit() : _transmitqueue() {}

ClientTransmit::~ClientTransmit() = default;

void ClientTransmit::Cancel()
{
  _transmitqueue.cancel();
}
void ClientTransmit::AddToQueue( Client* client, const void* data, int len )
{
  const u8* message = static_cast<const u8*>( data );
  auto transmitdata = std::make_unique<TransmitData>();
  transmitdata->client = client->getWeakPtr();
  transmitdata->len = len;
  transmitdata->data.assign( message, message + len );
  transmitdata->disconnects = false;
  _transmitqueue.push_move( std::move( transmitdata ) );
}

void ClientTransmit::QueueDisconnection( Client* client )
{
  auto transmitdata = std::make_unique<TransmitData>();
  transmitdata->disconnects = true;
  transmitdata->client = client->getWeakPtr();
  _transmitqueue.push_move( std::move( transmitdata ) );
}

void ClientTransmit::QueueDelete( Client* client )
{
  auto transmitdata = std::make_unique<TransmitData>();
  transmitdata->remove = true;
  transmitdata->client = client->getWeakPtr();
  _transmitqueue.push_move( std::move( transmitdata ) );
}

TransmitDataSPtr ClientTransmit::NextQueueEntry()
{
  auto transmitdata = TransmitDataSPtr();
  _transmitqueue.pop_wait( &transmitdata );
  return transmitdata;
}

void ClientTransmitThread()
{
  ClientTransmit* transmit_instance = Core::networkManager.clientTransmit.get();
  while ( !Clib::exit_signalled )
  {
    try
    {
      auto data = transmit_instance->NextQueueEntry();
      if ( data->client.exists() )
      {
        if ( data->remove )
        {
          Core::PolLock lock;
          delete data->client.get_weakptr();
        }
        else if ( data->disconnects )
        {
          data->client->forceDisconnect();
        }
        else if ( data->client->isReallyConnected() )
        {
          data->client->transmit( static_cast<void*>( &data->data[0] ), data->len );
        }
      }
    }
    catch ( ClientTransmitQueue::Canceled& )
    {
      return;
    }
  }
}
}  // namespace Network
}  // namespace Pol

1	#include "clienttransmit.h"
2
3	#include <memory>
4
5	#include "../../clib/esignal.h"
6	#include "../../clib/rawtypes.h"
7	#include "../globals/network.h"
8	#include "../polsem.h"
9	#include "client.h"
10
11	namespace Pol
12	{
13	namespace Network
14	{
15	ClientTransmit::ClientTransmit() : _transmitqueue() {}	3✔
16
17	ClientTransmit::~ClientTransmit() = default;	3✔
18
19	void ClientTransmit::Cancel()	2✔
20	{
21	_transmitqueue.cancel();	2✔
22	}	2✔
23	void ClientTransmit::AddToQueue( Client* client, const void* data, int len )	19,626✔
24	{
25	const u8* message = static_cast<const u8*>( data );	19,626✔
26	auto transmitdata = std::make_unique<TransmitData>();	19,626✔
27	transmitdata->client = client->getWeakPtr();	19,626✔
28	transmitdata->len = len;	19,626✔
29	transmitdata->data.assign( message, message + len );	19,626✔
30	transmitdata->disconnects = false;	19,626✔
31	_transmitqueue.push_move( std::move( transmitdata ) );	19,626✔
32	}	19,626✔
33
34	void ClientTransmit::QueueDisconnection( Client* client )	×
35	{
NEW 36	auto transmitdata = std::make_unique<TransmitData>();	×
37	transmitdata->disconnects = true;	×
38	transmitdata->client = client->getWeakPtr();	×
39	_transmitqueue.push_move( std::move( transmitdata ) );	×
40	}	×
41
42	void ClientTransmit::QueueDelete( Client* client )	4✔
43	{
44	auto transmitdata = std::make_unique<TransmitData>();	4✔
45	transmitdata->remove = true;	4✔
46	transmitdata->client = client->getWeakPtr();	4✔
47	_transmitqueue.push_move( std::move( transmitdata ) );	4✔
48	}	4✔
49
50	TransmitDataSPtr ClientTransmit::NextQueueEntry()	19,632✔
51	{
52	auto transmitdata = TransmitDataSPtr();	19,632✔
53	_transmitqueue.pop_wait( &transmitdata );	19,632✔
54	return transmitdata;	19,630✔
55	}	2✔
56
57	void ClientTransmitThread()	2✔
58	{
59	ClientTransmit* transmit_instance = Core::networkManager.clientTransmit.get();	2✔
60	while ( !Clib::exit_signalled )	19,632✔
61	{
62	try
63	{
64	auto data = transmit_instance->NextQueueEntry();	19,632✔
65	if ( data->client.exists() )	19,630✔
66	{
67	if ( data->remove )	19,630✔
68	{
69	Core::PolLock lock;	4✔
70	delete data->client.get_weakptr();	4✔
71	}	4✔
72	else if ( data->disconnects )	19,626✔
73	{
74	data->client->forceDisconnect();	×
75	}
76	else if ( data->client->isReallyConnected() )	19,626✔
77	{
78	data->client->transmit( static_cast<void*>( &data->data[0] ), data->len );	19,626✔
79	}
80	}
81	}	19,630✔
82	catch ( ClientTransmitQueue::Canceled& )	2✔
83	{
84	return;	2✔
85	}	2✔
86	}
87	}
88	} // namespace Network
89	} // namespace Pol

polserver / polserver / 21066490217

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous