21031170065

Committed 15 Jan 2026 12:23PM UTC coverage: 80.796% (-1.2%) from 82.044%

Build # 21031170065

Build Type

Pull #3732

github

Committed by

web-flow

Commit Message

Merge 6dea7cf60 into 179048b80

Pull Request Pull Request #3732: Volume Calculation enhancement including refactoring and real-valued scoring implementation

Run Details

15979 of 22241 branches covered (71.84%)

Branch coverage included in aggregate %.

230 of 256 new or added lines in 2 files covered. (89.84%)

1019 existing lines in 51 files now uncovered.

53676 of 63970 relevant lines covered (83.91%)

13908816.79 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.85

/src/tallies/filter_cell_instance.cpp

#include "openmc/tallies/filter_cell_instance.h"

#include <cassert>
#include <string>

#include <fmt/core.h>

#include "openmc/capi.h"
#include "openmc/cell.h"
#include "openmc/error.h"
#include "openmc/geometry.h"
#include "openmc/xml_interface.h"

namespace openmc {

CellInstanceFilter::CellInstanceFilter(span<CellInstance> instances)
{
  this->set_cell_instances(instances);
}

void CellInstanceFilter::from_xml(pugi::xml_node node)
{
  // Get cell IDs/instances
  auto cells = get_node_array<int32_t>(node, "bins");
  assert(cells.size() % 2 == 0);

  // Convert into vector of CellInstance
  vector<CellInstance> instances;
  for (int64_t i = 0; i < cells.size() / 2; ++i) {
    int32_t cell_id = cells[2 * i];
    int64_t instance = cells[2 * i + 1];
    auto search = model::cell_map.find(cell_id);
    if (search == model::cell_map.end()) {
      throw std::runtime_error {fmt::format(
        "Could not find cell {} specified on tally filter.", cell_id)};
    }
    int64_t index = search->second;
    instances.push_back({index, instance});
  }

  this->set_cell_instances(instances);
}

void CellInstanceFilter::set_cell_instances(span<CellInstance> instances)
{
  // Clear existing cells
  cell_instances_.clear();
  cell_instances_.reserve(instances.size());
  cells_.clear();
  map_.clear();

  // Update cells and mapping
  for (auto& x : instances) {
    assert(x.index_cell >= 0);
    assert(x.index_cell < model::cells.size());
    cell_instances_.push_back(x);
    cells_.insert(x.index_cell);
    map_[x] = cell_instances_.size() - 1;
  }

  n_bins_ = cell_instances_.size();

  material_cells_only_ = true;
  for (const auto& cell_inst : cell_instances_) {
    const auto& c = *model::cells[cell_inst.index_cell];
    if (c.type_ == Fill::MATERIAL)
      continue;
    material_cells_only_ = false;
    break;
  }
}

void CellInstanceFilter::get_all_bins(
  const Particle& p, TallyEstimator estimator, FilterMatch& match) const
{
  int64_t index_cell = p.lowest_coord().cell();
  int64_t instance = p.cell_instance();

  if (cells_.count(index_cell) > 0) {
    auto search = map_.find({index_cell, instance});
    if (search != map_.end()) {
      int index_bin = search->second;
      match.bins_.push_back(index_bin);
      match.weights_.push_back(1.0);
    }
  }

  if (material_cells_only_)
    return;

  for (int i = 0; i < p.n_coord() - 1; i++) {
    int64_t index_cell = p.coord(i).cell();
    // if this cell isn't used on the filter, move on
    if (cells_.count(index_cell) == 0)
      continue;

    // if this cell is used in the filter, check the instance as well
    int64_t instance = cell_instance_at_level(p, i);
    auto search = map_.find({index_cell, instance});
    if (search != map_.end()) {
      match.bins_.push_back(search->second);
      match.weights_.push_back(1.0);
    }
  }
}

void CellInstanceFilter::to_statepoint(hid_t filter_group) const
{
  Filter::to_statepoint(filter_group);
  size_t n = cell_instances_.size();
  xt::xtensor<size_t, 2> data({n, 2});
  for (int64_t i = 0; i < n; ++i) {
    const auto& x = cell_instances_[i];
    data(i, 0) = model::cells[x.index_cell]->id_;
    data(i, 1) = x.instance;
  }
  write_dataset(filter_group, "bins", data);
}

std::string CellInstanceFilter::text_label(int bin) const
{
  const auto& x = cell_instances_[bin];
  auto cell_id = model::cells[x.index_cell]->id_;
  return "Cell " + std::to_string(cell_id) + ", Instance " +
         std::to_string(x.instance);
}

} // namespace openmc

1	#include "openmc/tallies/filter_cell_instance.h"
2
3	#include <cassert>
4	#include <string>
5
6	#include <fmt/core.h>
7
8	#include "openmc/capi.h"
9	#include "openmc/cell.h"
10	#include "openmc/error.h"
11	#include "openmc/geometry.h"
12	#include "openmc/xml_interface.h"
13
14	namespace openmc {
15
16	CellInstanceFilter::CellInstanceFilter(span<CellInstance> instances)	×
17	{
18	this->set_cell_instances(instances);	×
19	}	×
20
21	void CellInstanceFilter::from_xml(pugi::xml_node node)	4✔
22	{
23	// Get cell IDs/instances
24	auto cells = get_node_array<int32_t>(node, "bins");	4✔
25	assert(cells.size() % 2 == 0);	4!
26
27	// Convert into vector of CellInstance
28	vector<CellInstance> instances;	4✔
29	for (int64_t i = 0; i < cells.size() / 2; ++i) {	84✔
30	int32_t cell_id = cells[2 * i];	80✔
31	int64_t instance = cells[2 * i + 1];	80✔
32	auto search = model::cell_map.find(cell_id);	80✔
33	if (search == model::cell_map.end()) {	80!
34	throw std::runtime_error {fmt::format(	×
35	"Could not find cell {} specified on tally filter.", cell_id)};	×
36	}
37	int64_t index = search->second;	80✔
38	instances.push_back({index, instance});	80✔
39	}
40
41	this->set_cell_instances(instances);	4✔
42	}	4✔
43
44	void CellInstanceFilter::set_cell_instances(span<CellInstance> instances)	4✔
45	{
46	// Clear existing cells
47	cell_instances_.clear();	4✔
48	cell_instances_.reserve(instances.size());	4✔
49	cells_.clear();	4✔
50	map_.clear();	4✔
51
52	// Update cells and mapping
53	for (auto& x : instances) {	84✔
54	assert(x.index_cell >= 0);	80!
55	assert(x.index_cell < model::cells.size());	80!
56	cell_instances_.push_back(x);	80✔
57	cells_.insert(x.index_cell);	80✔
58	map_[x] = cell_instances_.size() - 1;	80✔
59	}
60
61	n_bins_ = cell_instances_.size();	4✔
62
63	material_cells_only_ = true;	4✔
64	for (const auto& cell_inst : cell_instances_) {	36!
65	const auto& c = *model::cells[cell_inst.index_cell];	36✔
66	if (c.type_ == Fill::MATERIAL)	36✔
67	continue;	32✔
68	material_cells_only_ = false;	4✔
69	break;	4✔
70	}
71	}	4✔
72
73	void CellInstanceFilter::get_all_bins(	1,383,816✔
74	const Particle& p, TallyEstimator estimator, FilterMatch& match) const
75	{
76	int64_t index_cell = p.lowest_coord().cell();	1,383,816✔
77	int64_t instance = p.cell_instance();	1,383,816✔
78
79	if (cells_.count(index_cell) > 0) {	1,383,816✔
80	auto search = map_.find({index_cell, instance});	374,452✔
81	if (search != map_.end()) {	374,452!
82	int index_bin = search->second;	374,452✔
83	match.bins_.push_back(index_bin);	374,452✔
84	match.weights_.push_back(1.0);	374,452✔
85	}
86	}
87
88	if (material_cells_only_)	1,383,816!
UNCOV 89	return;	×
90
91	for (int i = 0; i < p.n_coord() - 1; i++) {	3,119,588✔
92	int64_t index_cell = p.coord(i).cell();	1,735,772✔
93	// if this cell isn't used on the filter, move on
94	if (cells_.count(index_cell) == 0)	1,735,772✔
95	continue;	1,383,816✔
96
97	// if this cell is used in the filter, check the instance as well
98	int64_t instance = cell_instance_at_level(p, i);	351,956✔
99	auto search = map_.find({index_cell, instance});	351,956✔
100	if (search != map_.end()) {	351,956!
101	match.bins_.push_back(search->second);	351,956✔
102	match.weights_.push_back(1.0);	351,956✔
103	}
104	}
105	}
106
107	void CellInstanceFilter::to_statepoint(hid_t filter_group) const	4✔
108	{
109	Filter::to_statepoint(filter_group);	4✔
110	size_t n = cell_instances_.size();	4✔
111	xt::xtensor<size_t, 2> data({n, 2});	4✔
112	for (int64_t i = 0; i < n; ++i) {	84✔
113	const auto& x = cell_instances_[i];	80✔
114	data(i, 0) = model::cells[x.index_cell]->id_;	80✔
115	data(i, 1) = x.instance;	80✔
116	}
117	write_dataset(filter_group, "bins", data);	4✔
118	}	4✔
119
120	std::string CellInstanceFilter::text_label(int bin) const	80✔
121	{
122	const auto& x = cell_instances_[bin];	80✔
123	auto cell_id = model::cells[x.index_cell]->id_;	80✔
124	return "Cell " + std::to_string(cell_id) + ", Instance " +	160✔
125	std::to_string(x.instance);	240✔
126	}
127
128	} // namespace openmc

openmc-dev / openmc / 21031170065

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous