#4927

Committed 14 Jan 2026 07:42AM UTC coverage: 66.12% (+0.07%) from 66.053%

Build # #4927

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

fix memleak decimal (#34283)

Run Details

2 of 16 new or added lines in 1 file covered. (12.5%)

476 existing lines in 124 files now uncovered.

200574 of 303348 relevant lines covered (66.12%)

130242324.59 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.55

/source/dnode/xnode/src/xnode.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "libs/txnode/txnode.h"
#include "xndInt.h"

static SXnode xnodeInstance = {0};
SXnode       *xndInstance() { return &xnodeInstance; }

int32_t xndOpen(const SXnodeOpt *pOption, SXnode **pXnode) {
  *pXnode = &xnodeInstance;
  (*pXnode)->protocol = (int8_t)pOption->proto;
  (*pXnode)->dnodeId = pOption->dnodeId;
  (*pXnode)->clusterId = pOption->clusterId;
  (*pXnode)->ep = pOption->ep;

  // if (TSDB_XNODE_OPT_PROTO == (*pXnode)->protocol) {
  //   // if ((code = xnodeMgmtStartXnoded((*pXnode)->dnodeId)) != 0) {
  //   if ((code = xnodeMgmtStartXnoded(*pXnode)) != 0) {
  //     xndError("failed to start xnoded since %s", tstrerror(code));

  //     taosMemoryFree(*pXnode);
  //     TAOS_RETURN(code);
  //   }
  // } else {
  //   xndError("Unknown xnode proto: %hhd.", (*pXnode)->protocol);

  //   taosMemoryFree(*pXnode);
  //   TAOS_RETURN(code);
  // }

  xndInfo("xnode: opened & initialized by dnode");

  return TSDB_CODE_SUCCESS;
}

void xndClose(SXnode *pXnode) {
  xndInfo("xnode: dnode is closing xnoded");
  xnodeMgmtStopXnoded();
}

int32_t mndOpenXnd(const SXnodeOpt *pOption) {
  int32_t code = 0;
  SXnode *pXnode = xndInstance();
  pXnode->dnodeId = pOption->dnodeId;
  pXnode->clusterId = pOption->clusterId;
  pXnode->upLen = pOption->upLen;
  pXnode->ep = pOption->ep;
  memset(pXnode->userPass, 0, XNODE_USER_PASS_LEN);
  memcpy(pXnode->userPass, pOption->userPass, pOption->upLen);

  if ((code = xnodeMgmtStartXnoded(pXnode)) != 0) {
    xndError("failed to start xnoded since %s", tstrerror(code));

    TAOS_RETURN(code);
  }
  return code;
}

void mndCloseXnd() { xnodeMgmtStopXnoded(); }

void getXnodedPipeName(char *pipeName, int32_t size) {
#ifdef _WIN32
  snprintf(pipeName, size, "%s.%x", XNODED_MGMT_LISTEN_PIPE_NAME_PREFIX, MurmurHash3_32(tsDataDir, strlen(tsDataDir)));
#else
  snprintf(pipeName, size, "%s%s", tsDataDir, XNODED_MGMT_LISTEN_PIPE_NAME_PREFIX);
#endif
  xndDebug("xnode get unix socket pipe path:%s", pipeName);
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "libs/txnode/txnode.h"
17	#include "xndInt.h"
18
19	static SXnode xnodeInstance = {0};
20	SXnode *xndInstance() { return &xnodeInstance; }	125✔
21
22	int32_t xndOpen(const SXnodeOpt pOption, SXnode *pXnode) {	555,326✔
23	*pXnode = &xnodeInstance;	555,326✔
24	(*pXnode)->protocol = (int8_t)pOption->proto;	555,326✔
25	(*pXnode)->dnodeId = pOption->dnodeId;	555,326✔
26	(*pXnode)->clusterId = pOption->clusterId;	555,326✔
27	(*pXnode)->ep = pOption->ep;	555,326✔
28
29	// if (TSDB_XNODE_OPT_PROTO == (*pXnode)->protocol) {
30	// // if ((code = xnodeMgmtStartXnoded((*pXnode)->dnodeId)) != 0) {
31	// if ((code = xnodeMgmtStartXnoded(*pXnode)) != 0) {
32	// xndError("failed to start xnoded since %s", tstrerror(code));
33
34	// taosMemoryFree(*pXnode);
35	// TAOS_RETURN(code);
36	// }
37	// } else {
38	// xndError("Unknown xnode proto: %hhd.", (*pXnode)->protocol);
39
40	// taosMemoryFree(*pXnode);
41	// TAOS_RETURN(code);
42	// }
43
44	xndInfo("xnode: opened & initialized by dnode");	555,326✔
45
46	return TSDB_CODE_SUCCESS;	555,326✔
47	}
48
49	void xndClose(SXnode *pXnode) {	555,326✔
50	xndInfo("xnode: dnode is closing xnoded");	555,326✔
51	xnodeMgmtStopXnoded();	555,326✔
52	}	555,326✔
53
54	int32_t mndOpenXnd(const SXnodeOpt *pOption) {	125✔
55	int32_t code = 0;	125✔
56	SXnode *pXnode = xndInstance();	125✔
57	pXnode->dnodeId = pOption->dnodeId;	125✔
58	pXnode->clusterId = pOption->clusterId;	125✔
59	pXnode->upLen = pOption->upLen;	125✔
60	pXnode->ep = pOption->ep;	125✔
61	memset(pXnode->userPass, 0, XNODE_USER_PASS_LEN);	125✔
62	memcpy(pXnode->userPass, pOption->userPass, pOption->upLen);	125✔
63
64	if ((code = xnodeMgmtStartXnoded(pXnode)) != 0) {	125✔
UNCOV 65	xndError("failed to start xnoded since %s", tstrerror(code));	×
66
UNCOV 67	TAOS_RETURN(code);	×
68	}
69	return code;	125✔
70	}
71
72	void mndCloseXnd() { xnodeMgmtStopXnoded(); }	53,979✔
73
74	void getXnodedPipeName(char *pipeName, int32_t size) {	750✔
75	#ifdef _WIN32
76	snprintf(pipeName, size, "%s.%x", XNODED_MGMT_LISTEN_PIPE_NAME_PREFIX, MurmurHash3_32(tsDataDir, strlen(tsDataDir)));
77	#else
78	snprintf(pipeName, size, "%s%s", tsDataDir, XNODED_MGMT_LISTEN_PIPE_NAME_PREFIX);	750✔
79	#endif
80	xndDebug("xnode get unix socket pipe path:%s", pipeName);	750✔
81	}	750✔

taosdata / TDengine / #4927

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous