• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4925

12 Jan 2026 09:34AM UTC coverage: 66.107% (+0.8%) from 65.354%
#4925

push

travis-ci

web-flow
merge: from main to 3.0 branch #34248

103 of 129 new or added lines in 9 files covered. (79.84%)

891 existing lines in 139 files now uncovered.

200488 of 303278 relevant lines covered (66.11%)

129810096.48 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.62
/source/dnode/vnode/src/tsdb/tsdbCommit2.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "tsdbCommit2.h"
17

18
// extern dependencies
19
typedef struct {
20
  int32_t    fid;
21
  STFileSet *fset;
22
} SFileSetCommitInfo;
23

24
typedef struct {
25
  STsdb  *tsdb;
26
  int32_t minutes;
27
  int8_t  precision;
28
  int32_t minRow;
29
  int32_t maxRow;
30
  int8_t  cmprAlg;
31
  int32_t sttTrigger;
32
  int32_t szPage;
33
  int64_t compactVersion;
34
  int64_t cid;
35
  int64_t now;
36

37
  struct {
38
    SFileSetCommitInfo *info;
39

40
    int32_t expLevel;
41
    TSKEY   minKey;
42
    TSKEY   maxKey;
43
    TABLEID tbid[1];
44
    bool    hasTSData;
45

46
    bool      skipTsRow;
47
    SHashObj *pColCmprObj;
48
  } ctx[1];
49

50
  // reader
51
  TSttFileReaderArray sttReaderArray[1];
52
  // iter
53
  TTsdbIterArray dataIterArray[1];
54
  SIterMerger   *dataIterMerger;
55
  TTsdbIterArray tombIterArray[1];
56
  SIterMerger   *tombIterMerger;
57
  // writer
58
  SFSetWriter *writer;
59

60
  TFileOpArray fopArray[1];
61
} SCommitter2;
62

63
static int32_t tsdbCommitOpenWriter(SCommitter2 *committer) {
16,004,168✔
64
  int32_t code = 0;
16,004,168✔
65
  int32_t lino = 0;
16,004,168✔
66

67
  SFSetWriterConfig config = {
16,011,756✔
68
      .tsdb = committer->tsdb,
16,016,488✔
69
      .toSttOnly = true,
70
      .compactVersion = committer->compactVersion,
16,008,650✔
71
      .minRow = committer->minRow,
16,014,581✔
72
      .maxRow = committer->maxRow,
16,012,299✔
73
      .szPage = committer->szPage,
16,000,978✔
74
      .cmprAlg = committer->cmprAlg,
16,001,810✔
75
      .fid = committer->ctx->info->fid,
16,016,185✔
76
      .cid = committer->cid,
15,994,885✔
77
      .expLevel = committer->ctx->expLevel,
16,008,754✔
78
      .level = 0,
79
  };
80

81
  if (committer->sttTrigger == 1) {
16,001,867✔
82
    config.toSttOnly = false;
3,400,280✔
83

84
    if (committer->ctx->info->fset) {
3,400,280✔
85
      for (int32_t ftype = TSDB_FTYPE_MIN; ftype < TSDB_FTYPE_MAX; ftype++) {
850,900✔
86
        if (committer->ctx->info->fset->farr[ftype] != NULL) {
680,720✔
87
          config.files[ftype].exist = true;
502,867✔
88
          config.files[ftype].file = committer->ctx->info->fset->farr[ftype]->f[0];
502,867✔
89
        }
90
      }
91
    }
92
  }
93

94
  TAOS_CHECK_GOTO(tsdbFSetWriterOpen(&config, &committer->writer), &lino, _exit);
16,005,057✔
95

96
_exit:
16,006,863✔
97
  if (code) {
16,008,595✔
98
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
99
              tstrerror(code));
100
  }
101
  return code;
16,008,595✔
102
}
103

104
static int32_t tsdbCommitCloseWriter(SCommitter2 *committer) {
16,031,998✔
105
  return tsdbFSetWriterClose(&committer->writer, 0, committer->fopArray);
16,031,998✔
106
}
107

108
static int32_t tsdbCommitTSData(SCommitter2 *committer) {
16,006,055✔
109
  int32_t   code = 0;
16,006,055✔
110
  int32_t   lino = 0;
16,006,055✔
111
  int64_t   numOfRow = 0;
16,013,300✔
112
  SMetaInfo info;
16,012,979✔
113

114
  committer->ctx->hasTSData = false;
16,013,019✔
115

116
  committer->ctx->tbid->suid = 0;
16,020,663✔
117
  committer->ctx->tbid->uid = 0;
16,011,826✔
118
  for (SRowInfo *row; (row = tsdbIterMergerGetData(committer->dataIterMerger)) != NULL;) {
2,147,483,647✔
119
    if (row->uid != committer->ctx->tbid->uid) {
2,147,483,647✔
120
      committer->ctx->tbid->suid = row->suid;
100,132,288✔
121
      committer->ctx->tbid->uid = row->uid;
100,108,236✔
122

123
      if (metaGetInfo(committer->tsdb->pVnode->pMeta, row->uid, &info, NULL) != 0) {
100,127,922✔
124
        TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(committer->dataIterMerger, committer->ctx->tbid), &lino, _exit);
1,322,805✔
125
        continue;
1,322,805✔
126
      }
127
    }
128

129
    int64_t ts = TSDBROW_TS(&row->row);
2,147,483,647✔
130
    if (ts > committer->ctx->maxKey) {
2,147,483,647✔
131
      TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(committer->dataIterMerger, committer->ctx->tbid), &lino, _exit);
41,611,991✔
132
      continue;
41,610,051✔
133
    }
134

135
    committer->ctx->hasTSData = true;
2,147,483,647✔
136
    numOfRow++;
2,147,483,647✔
137

138
    TAOS_CHECK_GOTO(tsdbFSetWriteRow(committer->writer, row), &lino, _exit);
2,147,483,647✔
139
    TAOS_CHECK_GOTO(tsdbIterMergerNext(committer->dataIterMerger), &lino, _exit);
2,147,483,647✔
140
  }
141

142
_exit:
16,031,671✔
143
  if (code) {
16,031,688✔
144
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
145
              tstrerror(code));
146
  } else {
147
    tsdbDebug("vgId:%d fid:%d commit %" PRId64 " rows", TD_VID(committer->tsdb->pVnode), committer->ctx->info->fid,
16,031,688✔
148
              numOfRow);
149
  }
150
  return code;
16,031,688✔
151
}
152

153
static int32_t tsdbCommitTombData(SCommitter2 *committer) {
16,031,789✔
154
  int32_t   code = 0;
16,031,789✔
155
  int32_t   lino = 0;
16,031,789✔
156
  int64_t   numRecord = 0;
16,032,662✔
157
  SMetaInfo info;
16,032,341✔
158

159
  // if no history data and no new timestamp data, skip tomb data
160
  if (committer->ctx->info->fset || committer->ctx->hasTSData) {
16,029,772✔
161
    committer->ctx->tbid->suid = 0;
16,016,509✔
162
    committer->ctx->tbid->uid = 0;
16,017,087✔
163
    for (STombRecord *record; (record = tsdbIterMergerGetTombRecord(committer->tombIterMerger));) {
17,783,360✔
164
      if (record->uid != committer->ctx->tbid->uid) {
1,766,783✔
165
        committer->ctx->tbid->suid = record->suid;
1,732,949✔
166
        committer->ctx->tbid->uid = record->uid;
1,732,949✔
167

168
        if (metaGetInfo(committer->tsdb->pVnode->pMeta, record->uid, &info, NULL) != 0) {
1,732,949✔
169
          TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(committer->tombIterMerger, committer->ctx->tbid), &lino, _exit);
16,302✔
170
          continue;
16,302✔
171
        }
172
      }
173

174
      if (record->ekey < committer->ctx->minKey) {
1,750,481✔
175
        // do nothing
176
      } else if (record->skey > committer->ctx->maxKey) {
1,740,041✔
177
        // committer->ctx->nextKey = TMIN(record->skey, committer->ctx->nextKey);
178
      } else {
179
        record->skey = TMAX(record->skey, committer->ctx->minKey);
1,732,250✔
180
        record->ekey = TMIN(record->ekey, committer->ctx->maxKey);
1,732,250✔
181

182
        numRecord++;
1,732,250✔
183
        TAOS_CHECK_GOTO(tsdbFSetWriteTombRecord(committer->writer, record), &lino, _exit);
1,732,250✔
184
      }
185

186
      TAOS_CHECK_GOTO(tsdbIterMergerNext(committer->tombIterMerger), &lino, _exit);
1,750,481✔
187
    }
188
  }
189

190
_exit:
16,033,028✔
191
  if (code) {
16,032,334✔
192
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
193
              tstrerror(code));
194
  } else {
195
    tsdbDebug("vgId:%d fid:%d commit %" PRId64 " tomb records", TD_VID(committer->tsdb->pVnode),
16,032,334✔
196
              committer->ctx->info->fid, numRecord);
197
  }
198
  return code;
16,032,334✔
199
}
200

201
static void tsdbCommitCloseReader(SCommitter2 *committer) {
16,007,193✔
202
  TARRAY2_CLEAR(committer->sttReaderArray, tsdbSttFileReaderClose);
16,013,731✔
203
  return;
16,012,987✔
204
}
205

206
static int32_t tsdbCommitOpenReader(SCommitter2 *committer) {
16,001,968✔
207
  int32_t code = 0;
16,001,968✔
208
  int32_t lino = 0;
16,001,968✔
209

210
  if (committer->ctx->info->fset == NULL                        //
16,011,756✔
211
      || committer->sttTrigger > 1                              //
1,913,183✔
212
      || TARRAY2_SIZE(committer->ctx->info->fset->lvlArr) == 0  //
170,180✔
213
  ) {
214
    return 0;
16,000,061✔
215
  }
216

217
  SSttLvl *lvl;
218
  TARRAY2_FOREACH(committer->ctx->info->fset->lvlArr, lvl) {
13,076✔
219
    STFileObj *fobj = NULL;
6,538✔
220
    TARRAY2_FOREACH(lvl->fobjArr, fobj) {
13,076✔
221
      SSttFileReader *sttReader;
6,538✔
222

223
      SSttFileReaderConfig config = {
13,076✔
224
          .tsdb = committer->tsdb,
6,538✔
225
          .szPage = committer->szPage,
6,538✔
226
          .file = fobj->f[0],
227
      };
228

229
      TAOS_CHECK_GOTO(tsdbSttFileReaderOpen(fobj->fname, &config, &sttReader), &lino, _exit);
6,538✔
230

231
      TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->sttReaderArray, sttReader), &lino, _exit);
13,076✔
232

233
      STFileOp op = {
13,076✔
234
          .optype = TSDB_FOP_REMOVE,
235
          .fid = fobj->f->fid,
6,538✔
236
          .of = fobj->f[0],
237
      };
238

239
      TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->fopArray, op), &lino, _exit);
13,076✔
240
    }
241
  }
242

243
_exit:
6,538✔
244
  if (code) {
6,538✔
245
    tsdbCommitCloseReader(committer);
×
246
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
247
              tstrerror(code));
248
  }
249
  return code;
6,538✔
250
}
251

252
static void tsdbCommitCloseIter(SCommitter2 *committer) {
16,017,606✔
253
  tsdbIterMergerClose(&committer->tombIterMerger);
16,017,606✔
254
  tsdbIterMergerClose(&committer->dataIterMerger);
15,999,519✔
255
  TARRAY2_CLEAR(committer->tombIterArray, tsdbIterClose);
32,022,958✔
256
  TARRAY2_CLEAR(committer->dataIterArray, tsdbIterClose);
32,018,575✔
257
  return;
16,011,311✔
258
}
259

260
static int32_t tsdbCommitOpenIter(SCommitter2 *committer) {
16,006,895✔
261
  int32_t code = 0;
16,006,895✔
262
  int32_t lino = 0;
16,006,895✔
263

264
  STsdbIter      *iter;
16,013,361✔
265
  STsdbIterConfig config = {0};
16,016,219✔
266

267
  // mem data iter
268
  config.type = TSDB_ITER_TYPE_MEMT;
16,012,924✔
269
  config.memt = committer->tsdb->imem;
16,012,924✔
270
  config.from->version = VERSION_MIN;
16,021,089✔
271
  config.from->key = (SRowKey){
16,017,819✔
272
      .ts = committer->ctx->minKey,
16,021,089✔
273
      .numOfPKs = 0,
274
  };
275

276
  TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
16,017,819✔
277
  TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->dataIterArray, iter), &lino, _exit);
32,048,739✔
278

279
  // mem tomb iter
280
  config.type = TSDB_ITER_TYPE_MEMT_TOMB;
16,025,948✔
281
  config.memt = committer->tsdb->imem;
16,025,948✔
282

283
  TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
16,023,951✔
284
  TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->tombIterArray, iter), &lino, _exit);
32,032,378✔
285

286
  // STT
287
  SSttFileReader *sttReader;
288
  TARRAY2_FOREACH(committer->sttReaderArray, sttReader) {
16,023,552✔
289
    // data iter
290
    config.type = TSDB_ITER_TYPE_STT;
6,538✔
291
    config.sttReader = sttReader;
6,538✔
292

293
    TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
6,538✔
294
    TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->dataIterArray, iter), &lino, _exit);
13,076✔
295

296
    // tomb iter
297
    config.type = TSDB_ITER_TYPE_STT_TOMB;
6,538✔
298
    config.sttReader = sttReader;
6,538✔
299

300
    TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
6,538✔
301

302
    TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->tombIterArray, iter), &lino, _exit);
13,076✔
303
  }
304

305
  // open merger
306
  TAOS_CHECK_GOTO(tsdbIterMergerOpen(committer->dataIterArray, &committer->dataIterMerger, false), &lino, _exit);
16,007,259✔
307
  TAOS_CHECK_GOTO(tsdbIterMergerOpen(committer->tombIterArray, &committer->tombIterMerger, true), &lino, _exit);
16,000,386✔
308

309
_exit:
16,028,483✔
310
  if (code) {
16,017,135✔
311
    tsdbCommitCloseIter(committer);
×
312
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
313
              tstrerror(code));
314
  }
315
  return code;
16,017,135✔
316
}
317

318
static int32_t tsdbCommitFileSetBegin(SCommitter2 *committer) {
16,022,219✔
319
  int32_t code = 0;
16,022,219✔
320
  int32_t lino = 0;
16,022,219✔
321
  STsdb  *tsdb = committer->tsdb;
16,024,664✔
322

323
  // check if can commit
324
  tsdbFSCheckCommit(tsdb, committer->ctx->info->fid);
16,026,887✔
325

326
  committer->ctx->expLevel = tsdbFidLevel(committer->ctx->info->fid, &tsdb->keepCfg, committer->now);
16,008,190✔
327
  tsdbFidKeyRange(committer->ctx->info->fid, committer->minutes, committer->precision, &committer->ctx->minKey,
16,002,675✔
328
                  &committer->ctx->maxKey);
329

330
  committer->ctx->tbid->suid = 0;
15,992,849✔
331
  committer->ctx->tbid->uid = 0;
15,993,636✔
332

333
  TAOS_CHECK_GOTO(tsdbCommitOpenReader(committer), &lino, _exit);
16,002,253✔
334
  TAOS_CHECK_GOTO(tsdbCommitOpenIter(committer), &lino, _exit);
16,004,232✔
335
  TAOS_CHECK_GOTO(tsdbCommitOpenWriter(committer), &lino, _exit);
16,015,699✔
336

337
_exit:
16,014,147✔
338
  if (code) {
16,014,304✔
339
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
340
  } else {
341
    tsdbDebug("vgId:%d %s done, fid:%d minKey:%" PRId64 " maxKey:%" PRId64 " expLevel:%d", TD_VID(tsdb->pVnode),
16,014,304✔
342
              __func__, committer->ctx->info->fid, committer->ctx->minKey, committer->ctx->maxKey,
343
              committer->ctx->expLevel);
344
  }
345
  return code;
16,014,304✔
346
}
347

348
static int32_t tsdbCommitFileSetEnd(SCommitter2 *committer) {
16,030,987✔
349
  int32_t code = 0;
16,030,987✔
350
  int32_t lino = 0;
16,030,987✔
351

352
  TAOS_CHECK_GOTO(tsdbCommitCloseWriter(committer), &lino, _exit);
16,031,860✔
353
  tsdbCommitCloseIter(committer);
16,016,193✔
354
  tsdbCommitCloseReader(committer);
16,010,445✔
355

356
_exit:
16,010,881✔
357
  if (code) {
16,014,750✔
358
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
359
              tstrerror(code));
360
  } else {
361
    tsdbDebug("vgId:%d %s done, fid:%d", TD_VID(committer->tsdb->pVnode), __func__, committer->ctx->info->fid);
16,014,750✔
362
  }
363
  return code;
16,014,750✔
364
}
365

366
static int32_t tsdbCommitFileSet(SCommitter2 *committer) {
16,008,350✔
367
  int32_t code = 0;
16,008,350✔
368
  int32_t lino = 0;
16,008,350✔
369

370
  TAOS_CHECK_GOTO(tsdbCommitFileSetBegin(committer), &lino, _exit);
16,009,036✔
371
  TAOS_CHECK_GOTO(tsdbCommitTSData(committer), &lino, _exit);
16,007,750✔
372
  TAOS_CHECK_GOTO(tsdbCommitTombData(committer), &lino, _exit);
16,031,577✔
373
  TAOS_CHECK_GOTO(tsdbCommitFileSetEnd(committer), &lino, _exit);
16,032,468✔
374

375
_exit:
16,010,148✔
376
  if (code) {
16,010,177✔
377
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
378
              tstrerror(code));
379
  } else {
380
    tsdbDebug("vgId:%d %s done, fid:%d", TD_VID(committer->tsdb->pVnode), __func__, committer->ctx->info->fid);
16,010,177✔
381
  }
382
  return code;
16,010,177✔
383
}
384

385
static int32_t tFileSetCommitInfoCompare(const void *arg1, const void *arg2) {
2,147,483,647✔
386
  SFileSetCommitInfo *info1 = (SFileSetCommitInfo *)arg1;
2,147,483,647✔
387
  SFileSetCommitInfo *info2 = (SFileSetCommitInfo *)arg2;
2,147,483,647✔
388

389
  if (info1->fid < info2->fid) {
2,147,483,647✔
390
    return -1;
2,147,483,647✔
391
  } else if (info1->fid > info2->fid) {
104,036,018✔
392
    return 1;
8,480,700✔
393
  } else {
394
    return 0;
95,551,784✔
395
  }
396
}
397

398
static int32_t tFileSetCommitInfoPCompare(const void *arg1, const void *arg2) {
2,147,483,647✔
399
  return tFileSetCommitInfoCompare(*(SFileSetCommitInfo **)arg1, *(SFileSetCommitInfo **)arg2);
2,147,483,647✔
400
}
401

402
static uint32_t tFileSetCommitInfoHash(const void *arg) {
138,590,554✔
403
  SFileSetCommitInfo *info = (SFileSetCommitInfo *)arg;
138,590,554✔
404
  return MurmurHash3_32((const char *)&info->fid, sizeof(info->fid));
138,590,554✔
405
}
406

407
static void tsdbCommitInfoDestroy(STsdb *pTsdb) {
2,561,072✔
408
  if (pTsdb->commitInfo) {
2,561,072✔
409
    for (int32_t i = 0; i < taosArrayGetSize(pTsdb->commitInfo->arr); i++) {
18,596,092✔
410
      SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(pTsdb->commitInfo->arr, i);
16,034,545✔
411
      int32_t             ret = vHashDrop(pTsdb->commitInfo->ht, info);
16,035,020✔
412
      tsdbTFileSetClear(&info->fset);
16,034,545✔
413
      taosMemoryFree(info);
16,034,545✔
414
    }
415

416
    vHashDestroy(&pTsdb->commitInfo->ht);
2,561,072✔
417
    taosArrayDestroy(pTsdb->commitInfo->arr);
2,561,072✔
418
    pTsdb->commitInfo->arr = NULL;
2,561,072✔
419
    taosMemoryFreeClear(pTsdb->commitInfo);
2,560,555✔
420
  }
421
  return;
2,561,072✔
422
}
423

424
static int32_t tsdbCommitInfoInit(STsdb *pTsdb) {
2,560,865✔
425
  int32_t code = 0;
2,560,865✔
426
  int32_t lino = 0;
2,560,865✔
427

428
  pTsdb->commitInfo = taosMemoryCalloc(1, sizeof(*pTsdb->commitInfo));
2,560,865✔
429
  if (pTsdb->commitInfo == NULL) {
2,560,765✔
430
    TAOS_CHECK_GOTO(terrno, &lino, _exit);
×
431
  }
432

433
  TAOS_CHECK_GOTO(vHashInit(&pTsdb->commitInfo->ht, tFileSetCommitInfoHash, tFileSetCommitInfoCompare), &lino, _exit);
2,560,765✔
434

435
  pTsdb->commitInfo->arr = taosArrayInit(0, sizeof(SFileSetCommitInfo *));
2,560,543✔
436
  if (pTsdb->commitInfo->arr == NULL) {
2,561,072✔
437
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
438
  }
439

440
_exit:
2,561,072✔
441
  if (code) {
2,560,227✔
442
    tsdbCommitInfoDestroy(pTsdb);
×
443
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(pTsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
444
  }
445
  return code;
2,560,227✔
446
}
447

448
static int32_t tsdbCommitInfoAdd(STsdb *tsdb, int32_t fid) {
16,033,447✔
449
  int32_t code = 0;
16,033,447✔
450
  int32_t lino = 0;
16,033,447✔
451

452
  SFileSetCommitInfo *tinfo;
16,033,126✔
453

454
  if ((tinfo = taosMemoryMalloc(sizeof(*tinfo))) == NULL) {
16,033,820✔
455
    TAOS_CHECK_GOTO(terrno, &lino, _exit);
×
456
  }
457
  tinfo->fid = fid;
16,033,267✔
458
  tinfo->fset = NULL;
16,031,796✔
459

460
  TAOS_CHECK_GOTO(vHashPut(tsdb->commitInfo->ht, tinfo), &lino, _exit);
16,033,439✔
461

462
  if ((taosArrayPush(tsdb->commitInfo->arr, &tinfo)) == NULL) {
32,060,633✔
463
    TAOS_CHECK_GOTO(terrno, &lino, _exit);
×
464
  }
465
  taosArraySort(tsdb->commitInfo->arr, tFileSetCommitInfoPCompare);
16,029,977✔
466

467
_exit:
16,032,061✔
468
  if (code) {
16,032,505✔
469
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
470
  }
471
  return code;
16,032,505✔
472
}
473

474
static int32_t tsdbCommitInfoBuild(STsdb *tsdb) {
2,560,865✔
475
  int32_t code = 0;
2,560,865✔
476
  int32_t lino = 0;
2,560,865✔
477

478
  STFileSet  *fset = NULL;
2,560,865✔
479
  SRBTreeIter iter;
2,560,648✔
480

481
  TAOS_CHECK_GOTO(tsdbCommitInfoInit(tsdb), &lino, _exit);
2,560,157✔
482

483
  // scan time-series data
484
  iter = tRBTreeIterCreate(tsdb->imem->tbDataTree, 1);
2,560,756✔
485
  for (SRBTreeNode *node = tRBTreeIterNext(&iter); node; node = tRBTreeIterNext(&iter)) {
60,600,374✔
486
    STbData *pTbData = TCONTAINER_OF(node, STbData, rbtn);
58,281,927✔
487

488
    // scan time-series data
489
    STsdbRowKey from = {
58,281,319✔
490
        .key.ts = INT64_MIN,
491
        .key.numOfPKs = 0,
492
        .version = INT64_MIN,
493
    };
494
    for (;;) {
94,464,067✔
495
      int64_t     minKey, maxKey;
152,738,092✔
496
      STbDataIter tbDataIter = {0};
152,656,898✔
497
      TSDBROW    *row;
498
      int32_t     fid;
499

500
      tsdbTbDataIterOpen(pTbData, &from, 0, &tbDataIter);
152,722,595✔
501
      if ((row = tsdbTbDataIterGet(&tbDataIter)) == NULL) {
152,574,623✔
502
        break;
58,038,871✔
503
      }
504

505
      fid = tsdbKeyFid(TSDBROW_TS(row), tsdb->keepCfg.days, tsdb->keepCfg.precision);
94,535,752✔
506
      tsdbFidKeyRange(fid, tsdb->keepCfg.days, tsdb->keepCfg.precision, &minKey, &maxKey);
94,610,924✔
507

508
      SFileSetCommitInfo *info;
94,606,238✔
509
      SFileSetCommitInfo  tinfo = {
94,607,753✔
510
           .fid = fid,
511
      };
512
      int32_t ret = vHashGet(tsdb->commitInfo->ht, &tinfo, (void **)&info);
94,607,872✔
513
      if (info == NULL) {
94,518,842✔
514
        TAOS_CHECK_GOTO(tsdbCommitInfoAdd(tsdb, fid), &lino, _exit);
15,953,890✔
515
      }
516

517
      from.key.ts = maxKey + 1;
94,515,080✔
518
    }
519
  }
520

521
  (void)taosThreadMutexLock(&tsdb->mutex);
2,561,072✔
522

523
  // scan tomb data
524
  if (tsdb->imem->nDel > 0) {
2,561,072✔
525
    TARRAY2_FOREACH(tsdb->pFS->fSetArr, fset) {
2,026,694✔
526
      if (tsdbTFileSetIsEmpty(fset)) {
1,043,073✔
527
        continue;
×
528
      }
529

530
      SFileSetCommitInfo *info;
1,043,073✔
531
      SFileSetCommitInfo  tinfo = {
1,043,073✔
532
           .fid = fset->fid,
1,043,073✔
533
      };
534

535
      // check if the file set already on the commit list
536
      int32_t ret = vHashGet(tsdb->commitInfo->ht, &tinfo, (void **)&info);
1,043,073✔
537
      if (info != NULL) {
1,043,073✔
538
        continue;
923,150✔
539
      }
540

541
      int64_t minKey, maxKey;
119,923✔
542
      bool    hasDataToCommit = false;
119,923✔
543
      tsdbFidKeyRange(fset->fid, tsdb->keepCfg.days, tsdb->keepCfg.precision, &minKey, &maxKey);
119,923✔
544
      iter = tRBTreeIterCreate(tsdb->imem->tbDataTree, 1);
119,923✔
545
      for (SRBTreeNode *node = tRBTreeIterNext(&iter); node; node = tRBTreeIterNext(&iter)) {
216,111✔
546
        STbData *pTbData = TCONTAINER_OF(node, STbData, rbtn);
175,797✔
547
        for (SDelData *pDelData = pTbData->pHead; pDelData; pDelData = pDelData->pNext) {
231,971✔
548
          if (pDelData->sKey > maxKey || pDelData->eKey < minKey) {
135,783✔
549
            continue;
56,174✔
550
          } else {
551
            hasDataToCommit = true;
79,609✔
552
            if ((code = tsdbCommitInfoAdd(tsdb, fset->fid))) {
79,609✔
553
              (void)taosThreadMutexUnlock(&tsdb->mutex);
×
554
              TSDB_CHECK_CODE(code, lino, _exit);
×
555
            }
556
            break;
79,609✔
557
          }
558
        }
559

560
        if (hasDataToCommit) {
175,797✔
561
          break;
79,609✔
562
        }
563
      }
564
    }
565
  }
566

567
  // begin tasks on file set
568
  for (int i = 0; i < taosArrayGetSize(tsdb->commitInfo->arr); i++) {
18,595,268✔
569
    SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(tsdb->commitInfo->arr, i);
16,033,806✔
570
    tsdbBeginTaskOnFileSet(tsdb, info->fid, EVA_TASK_COMMIT, &fset);
16,034,809✔
571
    if (fset) {
16,034,813✔
572
      code = tsdbTFileSetInitCopy(tsdb, fset, &info->fset);
1,913,183✔
573
      if (code) {
1,913,183✔
574
        (void)taosThreadMutexUnlock(&tsdb->mutex);
×
575
        TAOS_CHECK_GOTO(code, &lino, _exit);
207✔
576
      }
577
    }
578
  }
579

580
  (void)taosThreadMutexUnlock(&tsdb->mutex);
2,560,157✔
581

582
_exit:
2,560,865✔
583
  if (code) {
2,561,072✔
584
    tsdbCommitInfoDestroy(tsdb);
×
585
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
586
  }
587
  return code;
2,561,072✔
588
}
589

590
static int32_t tsdbOpenCommitter(STsdb *tsdb, SCommitInfo *info, SCommitter2 *committer) {
2,558,179✔
591
  int32_t code = 0;
2,558,179✔
592
  int32_t lino = 0;
2,558,179✔
593

594
  committer->tsdb = tsdb;
2,561,072✔
595
  committer->minutes = tsdb->keepCfg.days;
2,561,072✔
596
  committer->precision = tsdb->keepCfg.precision;
2,561,072✔
597
  committer->minRow = info->info.config.tsdbCfg.minRows;
2,561,072✔
598
  committer->maxRow = info->info.config.tsdbCfg.maxRows;
2,561,072✔
599
  committer->cmprAlg = info->info.config.tsdbCfg.compression;
2,561,072✔
600
  committer->sttTrigger = info->info.config.sttTrigger;
2,561,072✔
601
  committer->szPage = info->info.config.tsdbPageSize;
2,560,865✔
602
  committer->compactVersion = INT64_MAX;
2,560,396✔
603
  committer->cid = tsdbFSAllocEid(tsdb->pFS);
2,559,659✔
604
  committer->now = taosGetTimestampSec();
2,561,072✔
605

606
  TAOS_CHECK_GOTO(tsdbCommitInfoBuild(tsdb), &lino, _exit);
2,560,603✔
607

608
_exit:
2,560,865✔
609
  if (code) {
2,561,072✔
610
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
611
  } else {
612
    tsdbDebug("vgId:%d %s done", TD_VID(tsdb->pVnode), __func__);
2,561,072✔
613
  }
614
  return code;
2,561,072✔
615
}
616

617
static int32_t tsdbCloseCommitter(SCommitter2 *committer, int32_t eno) {
2,560,597✔
618
  int32_t code = 0;
2,560,597✔
619
  int32_t lino = 0;
2,560,597✔
620

621
  if (eno == 0) {
2,561,072✔
622
    TAOS_CHECK_GOTO(tsdbFSEditBegin(committer->tsdb->pFS, committer->fopArray, TSDB_FEDIT_COMMIT), &lino, _exit);
2,561,072✔
623
  } else {
UNCOV
624
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
625
              tstrerror(eno));
626
  }
627

628
  TARRAY2_DESTROY(committer->dataIterArray, NULL);
2,561,072✔
629
  TARRAY2_DESTROY(committer->tombIterArray, NULL);
2,561,072✔
630
  TARRAY2_DESTROY(committer->sttReaderArray, NULL);
2,561,072✔
631
  TARRAY2_DESTROY(committer->fopArray, NULL);
2,560,597✔
632
  TARRAY2_DESTROY(committer->sttReaderArray, NULL);
2,561,072✔
633

634
_exit:
2,560,597✔
635
  if (code) {
2,560,597✔
636
    tsdbError("vgId:%d %s failed at %s:%d since %s, eid:%" PRId64, TD_VID(committer->tsdb->pVnode), __func__, __FILE__,
×
637
              lino, tstrerror(code), committer->cid);
638
  } else {
639
    tsdbDebug("vgId:%d %s done, eid:%" PRId64, TD_VID(committer->tsdb->pVnode), __func__, committer->cid);
2,560,597✔
640
  }
641
  return code;
2,560,597✔
642
}
643

644
int32_t tsdbPreCommit(STsdb *tsdb) {
4,557,688✔
645
  (void)taosThreadMutexLock(&tsdb->mutex);
4,557,688✔
646
  ASSERT_CORE(tsdb->imem == NULL, "imem should be null to commit mem");
4,564,749✔
647
  tsdb->imem = tsdb->mem;
4,565,804✔
648
  tsdb->mem = NULL;
4,565,804✔
649
  (void)taosThreadMutexUnlock(&tsdb->mutex);
4,565,360✔
650
  return 0;
4,565,804✔
651
}
652

653
int32_t tsdbCommitBegin(STsdb *tsdb, SCommitInfo *info) {
4,565,804✔
654
  if (!tsdb) return 0;
4,565,804✔
655

656
  int32_t code = 0;
4,565,804✔
657
  int32_t lino = 0;
4,565,804✔
658

659
  SMemTable *imem = tsdb->imem;
4,565,804✔
660
  int64_t    nRow = imem->nRow;
4,565,804✔
661
  int64_t    nDel = imem->nDel;
4,565,804✔
662

663
  if ((nRow == 0 && nDel == 0) || (tsBypassFlag & TSDB_BYPASS_RB_TSDB_COMMIT)) {
4,565,804✔
664
    (void)taosThreadMutexLock(&tsdb->mutex);
2,004,732✔
665
    tsdb->imem = NULL;
2,004,732✔
666
    (void)taosThreadMutexUnlock(&tsdb->mutex);
2,004,732✔
667
    tsdbUnrefMemTable(imem, NULL, true);
2,004,732✔
668
  } else {
669
    SCommitter2 committer = {0};
2,561,072✔
670

671
    TAOS_CHECK_GOTO(tsdbOpenCommitter(tsdb, info, &committer), &lino, _exit);
2,561,072✔
672

673
    for (int32_t i = 0; i < taosArrayGetSize(tsdb->commitInfo->arr); i++) {
18,571,997✔
674
      committer.ctx->info = *(SFileSetCommitInfo **)taosArrayGet(tsdb->commitInfo->arr, i);
16,019,903✔
675
      TAOS_CHECK_GOTO(tsdbCommitFileSet(&committer), &lino, _exit);
16,025,844✔
676
    }
677

678
    TAOS_CHECK_GOTO(tsdbCloseCommitter(&committer, code), &lino, _exit);
2,560,538✔
679
  }
680

681
_exit:
4,565,329✔
682
  if (code) {
4,565,329✔
683
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
684
  } else {
685
    tsdbInfo("vgId:%d %s done, nRow:%" PRId64 " nDel:%" PRId64, TD_VID(tsdb->pVnode), __func__, nRow, nDel);
4,565,329✔
686
  }
687
  return code;
4,565,804✔
688
}
689

690
int32_t tsdbCommitCommit(STsdb *tsdb) {
4,565,804✔
691
  int32_t code = 0;
4,565,804✔
692
  int32_t lino = 0;
4,565,804✔
693

694
  if (tsdb->imem) {
4,565,804✔
695
    SMemTable *pMemTable = tsdb->imem;
2,561,072✔
696

697
    (void)taosThreadMutexLock(&tsdb->mutex);
2,561,072✔
698

699
    if ((code = tsdbFSEditCommit(tsdb->pFS))) {
2,561,072✔
700
      (void)taosThreadMutexUnlock(&tsdb->mutex);
×
701
      TSDB_CHECK_CODE(code, lino, _exit);
×
702
    }
703
    tsdb->imem = NULL;
2,561,072✔
704

705
    for (int32_t i = 0; i < taosArrayGetSize(tsdb->commitInfo->arr); i++) {
18,596,092✔
706
      SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(tsdb->commitInfo->arr, i);
16,035,020✔
707
      if (info->fset) {
16,035,020✔
708
        tsdbFinishTaskOnFileSet(tsdb, info->fid, EVA_TASK_COMMIT);
1,913,183✔
709
      }
710
    }
711

712
    (void)taosThreadMutexUnlock(&tsdb->mutex);
2,561,072✔
713

714
    tsdbCommitInfoDestroy(tsdb);
2,561,072✔
715
    tsdbUnrefMemTable(pMemTable, NULL, true);
2,561,072✔
716
  }
717

718
_exit:
2,004,732✔
719
  if (code) {
4,565,287✔
720
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
721
  } else {
722
    tsdbInfo("vgId:%d %s done", TD_VID(tsdb->pVnode), __func__);
4,565,287✔
723
  }
724
  return code;
4,565,804✔
725
}
726

727
int32_t tsdbCommitAbort(STsdb *pTsdb) {
×
728
  int32_t code = 0;
×
729
  int32_t lino = 0;
×
730

731
  if (pTsdb->imem == NULL) goto _exit;
×
732

733
  TAOS_CHECK_GOTO(tsdbFSEditAbort(pTsdb->pFS), &lino, _exit);
×
734

735
  (void)taosThreadMutexLock(&pTsdb->mutex);
×
736
  for (int32_t i = 0; i < taosArrayGetSize(pTsdb->commitInfo->arr); i++) {
×
737
    SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(pTsdb->commitInfo->arr, i);
×
738
    if (info->fset) {
×
739
      tsdbFinishTaskOnFileSet(pTsdb, info->fid, EVA_TASK_COMMIT);
×
740
    }
741
  }
742
  (void)taosThreadMutexUnlock(&pTsdb->mutex);
×
743
  tsdbCommitInfoDestroy(pTsdb);
×
744

745
_exit:
×
746
  if (code) {
×
747
    tsdbError("vgId:%d, %s failed at line %d since %s", TD_VID(pTsdb->pVnode), __func__, lino, tstrerror(code));
×
748
  } else {
749
    tsdbInfo("vgId:%d %s done", TD_VID(pTsdb->pVnode), __func__);
×
750
  }
751
  return code;
×
752
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc