2257671017

Committed 12 Jan 2026 11:17AM UTC coverage: 75.817% (-0.03%) from 75.848%

Build # 2257671017

Build Type

push

gitlab-ci

Committed by

michalkopczan

Commit Message

fix: Return error when artifact payload contains files not present in the manifest

Ticket: MEN-9109
Changelog: Return an error when artifact payload contains files not present in the manifest and don't process any further payload files.

(cherry picked from commit 3367ada23)
Signed-off-by: Michal Kopczan <michal.kopczan@northern.tech>

Run Details

5 of 5 new or added lines in 1 file covered. (100.0%)

5 existing lines in 1 file now uncovered.

7446 of 9821 relevant lines covered (75.82%)

13824.68 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.28

/src/mender-update/update_module/v3/update_module_download.cpp

// Copyright 2023 Northern.tech AS
//
//    Licensed under the Apache License, Version 2.0 (the "License");
//    you may not use this file except in compliance with the License.
//    You may obtain a copy of the License at
//
//        http://www.apache.org/licenses/LICENSE-2.0
//
//    Unless required by applicable law or agreed to in writing, software
//    distributed under the License is distributed on an "AS IS" BASIS,
//    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
//    See the License for the specific language governing permissions and
//    limitations under the License.

#include <mender-update/update_module/v3/update_module.hpp>

#include <mender-update/progress_reader/progress_reader.hpp>

#include <common/events.hpp>
#include <common/events_io.hpp>
#include <common/log.hpp>
#include <common/path.hpp>
#include <common/processes.hpp>

namespace mender {
namespace update {
namespace update_module {
namespace v3 {

namespace log = mender::common::log;
namespace path = mender::common::path;
namespace processes = mender::common::processes;
namespace progress = mender::update::progress;


void UpdateModule::StartDownloadProcess() {
        string download_command = "Download";
        if (download_->downloading_with_sizes_) {
                download_command = "DownloadWithFileSizes";
        }
        log::Debug(
                "Calling Update Module with command `" + update_module_path_ + " " + download_command + " "
                + update_module_workdir_ + "`.");
        download_->proc_ = make_shared<procs::Process>(
                vector<string> {update_module_path_, download_command, update_module_workdir_});

        download_->proc_->SetWorkDir(update_module_workdir_);

        auto err = PrepareStreamNextPipe();
        if (err != error::NoError) {
                DownloadErrorHandler(err);
                return;
        }

        processes::OutputHandler stdout_handler {"Update Module output (stdout): "};
        processes::OutputHandler stderr_handler {"Update Module output (stderr): "};

        err = download_->proc_->Start(stdout_handler, stderr_handler);
        if (err != error::NoError) {
                DownloadErrorHandler(GetProcessError(err));
                return;
        }

        err = download_->proc_->AsyncWait(
                download_->event_loop_,
                [this](error::Error err) {
                        if (err.code == make_error_condition(errc::timed_out)) {
                                DownloadTimeoutHandler();
                        } else {
                                ProcessEndedHandler(err);
                        }
                },
                chrono::seconds(ctx_.GetConfig().module_timeout_seconds));
        if (err != error::NoError) {
                DownloadErrorHandler(err);
                return;
        }

        DownloadErrorHandler(OpenStreamNextPipe(
                [this](io::ExpectedAsyncWriterPtr writer) { StreamNextOpenHandler(writer); }));
}

void UpdateModule::StreamNextOpenHandler(io::ExpectedAsyncWriterPtr writer) {
        if (!writer) {
                DownloadErrorHandler(writer.error());
                return;
        }
        download_->stream_next_writer_ = writer.value();

        download_->module_has_started_download_ = true;

        auto reader = download_->payload_.Next();
        if (!reader) {
                if (reader.error().code
                        == artifact::parser_error::MakeError(
                                   artifact::parser_error::NoMorePayloadFilesError, "")
                                   .code) {
                        download_->module_has_finished_download_ = true;
                        log::Debug("Update Module finished all downloads");
                        EndStreamNext();
                } else {
                        DownloadErrorHandler(reader.error());
                }
                return;
        }
        auto payload_reader = make_shared<artifact::Reader>(std::move(reader.value()));

        auto progress_reader = make_shared<progress::Reader>(payload_reader, payload_reader->Size());

        download_->current_payload_reader_ =
                make_shared<events::io::AsyncReaderFromReader>(download_->event_loop_, progress_reader);
        download_->current_payload_name_ = payload_reader->Name();
        download_->current_payload_size_ = payload_reader->Size();

        auto stream_path =
                path::Join(update_module_workdir_, string("streams"), download_->current_payload_name_);
        auto exp_path_is_safe =
                path::IsWithinOrEqual(stream_path, path::Join(update_module_workdir_, string("streams")));
        if (!exp_path_is_safe.has_value()) {
                DownloadErrorHandler(exp_path_is_safe.error().WithContext(
                        "Error checking if path is equal to or within directory"));
                return;
        }
        if (!exp_path_is_safe.value()) {
                DownloadErrorHandler(error::Error(
                        make_error_condition(errc::invalid_argument),
                        "Error downloading payload: Provided payload file (" + download_->current_payload_name_
                                + ") would point outside work directory when extracted."));
                return;
        }

        auto err = PrepareAndOpenStreamPipe(
                stream_path, [this](io::ExpectedAsyncWriterPtr writer) { StreamOpenHandler(writer); });
        if (err != error::NoError) {
                DownloadErrorHandler(err);
                return;
        }

        string stream_next_string;
        if (download_->downloading_with_sizes_) {
                stream_next_string = path::Join("streams", download_->current_payload_name_) + " "
                                                         + to_string(download_->current_payload_size_);
        } else {
                stream_next_string = path::Join("streams", download_->current_payload_name_);
        }
        size_t entry_size = stream_next_string.size() + 1;
        if (entry_size > download_->buffer_.size()) {
                DownloadErrorHandler(error::Error(
                        make_error_condition(errc::no_buffer_space), "Payload name is too large for buffer"));
                return;
        }
        copy(stream_next_string.begin(), stream_next_string.end(), download_->buffer_.begin());
        download_->buffer_[entry_size - 1] = '\n';
        DownloadErrorHandler(download_->stream_next_writer_->AsyncWrite(
                download_->buffer_.begin(),
                download_->buffer_.begin() + entry_size,
                [this, entry_size](io::ExpectedSize result) {
                        StreamNextWriteHandler(entry_size, result);
                }));
}

void UpdateModule::StreamOpenHandler(io::ExpectedAsyncWriterPtr writer) {
        if (!writer) {
                DownloadErrorHandler(writer.error());
                return;
        }
        download_->current_stream_writer_ = writer.value();

        DownloadErrorHandler(download_->current_payload_reader_->AsyncRead(
                download_->buffer_.begin(), download_->buffer_.end(), [this](io::ExpectedSize result) {
                        PayloadReadHandler(result);
                }));
}

void UpdateModule::StreamNextWriteHandler(size_t expected_n, io::ExpectedSize result) {
        // Close stream-next writer.
        download_->stream_next_writer_.reset();
        if (!result) {
                DownloadErrorHandler(result.error());
        } else if (expected_n != result.value()) {
                DownloadErrorHandler(error::Error(
                        make_error_condition(errc::io_error),
                        "Unexpected number of written bytes to stream-next"));
        }
}

void UpdateModule::PayloadReadHandler(io::ExpectedSize result) {
        if (!result) {
                // Close streams.
                download_->current_stream_writer_.reset();
                download_->current_payload_reader_.reset();
                DownloadErrorHandler(result.error());
        } else if (result.value() > 0) {
                DownloadErrorHandler(download_->current_stream_writer_->AsyncWrite(
                        download_->buffer_.begin(),
                        download_->buffer_.begin() + result.value(),
                        [this, result](io::ExpectedSize write_result) {
                                StreamWriteHandler(0, result.value(), write_result);
                        }));
        } else {
                // Close streams.
                download_->current_stream_writer_.reset();
                download_->current_payload_reader_.reset();

                if (download_->downloading_to_files_) {
                        StartDownloadToFile();
                } else {
                        DownloadErrorHandler(OpenStreamNextPipe(
                                [this](io::ExpectedAsyncWriterPtr writer) { StreamNextOpenHandler(writer); }));
                }
        }
}

void UpdateModule::StreamWriteHandler(size_t offset, size_t expected_n, io::ExpectedSize result) {
        if (!result) {
                DownloadErrorHandler(result.error());
        } else if (result.value() == 0 || result.value() > expected_n) {
                DownloadErrorHandler(error::Error(
                        make_error_condition(errc::io_error),
                        "Unexpected number of written bytes to download stream"));
        } else if (result.value() < expected_n) {
                auto new_offset = offset + result.value();
                auto new_expected = expected_n - result.value();
                DownloadErrorHandler(download_->current_stream_writer_->AsyncWrite(
                        download_->buffer_.begin() + new_offset,
                        download_->buffer_.begin() + new_offset + new_expected,
                        [this, new_offset, new_expected](io::ExpectedSize write_result) {
                                StreamWriteHandler(new_offset, new_expected, write_result);
                        }));
        } else {
                download_->written_ += result.value();
                log::Trace("Wrote " + to_string(download_->written_) + " bytes to Update Module");
                DownloadErrorHandler(download_->current_payload_reader_->AsyncRead(
                        download_->buffer_.begin(), download_->buffer_.end(), [this](io::ExpectedSize result) {
                                PayloadReadHandler(result);
                        }));
        }
}

void UpdateModule::EndStreamNext() {
        // Empty write.
        DownloadErrorHandler(download_->stream_next_writer_->AsyncWrite(
                download_->buffer_.begin(), download_->buffer_.begin(), [this](io::ExpectedSize result) {
                        if (!result) {
                                DownloadErrorHandler(result.error());
                        } else {
                                DownloadErrorHandler(error::NoError);
                        }
                        // Close writer.
                        download_->stream_next_writer_.reset();
                        // No further action necessary. Now we just need to wait for the process to finish.
                }));
}

void UpdateModule::DownloadErrorHandler(const error::Error &err) {
        if (err != error::NoError) {
                EndDownloadLoop(err);
        }
}

void UpdateModule::EndDownloadLoop(const error::Error &err) {
        download_->download_finished_handler_(err);
}

void UpdateModule::DownloadTimeoutHandler() {
        download_->proc_->EnsureTerminated();
        EndDownloadLoop(error::Error(
                make_error_condition(errc::timed_out), "Update Module Download process timed out"));
}

void UpdateModule::ProcessEndedHandler(error::Error err) {
        if (err != error::NoError) {
                err = GetProcessError(err);
                DownloadErrorHandler(error::Error(
                        err.code, "Download: Update Module returned non-zero status: " + err.message));
        } else if (download_->module_has_finished_download_) {
                EndDownloadLoop(error::NoError);
        } else if (download_->module_has_started_download_) {
                DownloadErrorHandler(error::Error(
                        make_error_condition(errc::broken_pipe),
                        "Update Module started downloading, but did not finish"));
        } else {
                download_->downloading_to_files_ = true;
                download_->stream_next_opener_.reset();
                download_->current_stream_opener_.reset();
                err = DeleteStreamsFiles();
                if (err != error::NoError) {
                        DownloadErrorHandler(err);
                } else {
                        StartDownloadToFile();
                }
        }
}

void UpdateModule::StartDownloadToFile() {
        auto reader = download_->payload_.Next();
        if (!reader) {
                if (reader.error().code
                        == artifact::parser_error::MakeError(
                                   artifact::parser_error::NoMorePayloadFilesError, "")
                                   .code) {
                        log::Debug("Downloaded all files to `files` directory.");
                        EndDownloadLoop(error::NoError);
                } else {
                        DownloadErrorHandler(reader.error());
                }
                return;
        }
        auto payload_reader = make_shared<artifact::Reader>(std::move(reader.value()));
        download_->current_payload_reader_ =
                make_shared<events::io::AsyncReaderFromReader>(download_->event_loop_, payload_reader);
        download_->current_payload_name_ = payload_reader->Name();

        auto stream_path = path::Join(update_module_workdir_, string("files"));
        auto err = PrepareDownloadDirectory(stream_path);
        if (err != error::NoError) {
                DownloadErrorHandler(err);
                return;
        }

        stream_path = path::Join(stream_path, download_->current_payload_name_);
        auto exp_path_is_safe =
                path::IsWithinOrEqual(stream_path, path::Join(update_module_workdir_, string("files")));
        if (!exp_path_is_safe.has_value()) {
                DownloadErrorHandler(exp_path_is_safe.error().WithContext(
                        "Error checking if path is equal to or within directory"));
                return;
        }
        if (!exp_path_is_safe.value()) {
                DownloadErrorHandler(error::Error(
                        make_error_condition(errc::invalid_argument),
                        "Error downloading payload: Provided payload file (" + download_->current_payload_name_
                                + ") would point outside work directory when extracted."));
                return;
        }

        auto current_stream_writer =
                make_shared<events::io::AsyncFileDescriptorWriter>(download_->event_loop_);
        err = current_stream_writer->Open(stream_path);
        if (err != error::NoError) {
                DownloadErrorHandler(err);
                return;
        }
        download_->current_stream_writer_ = current_stream_writer;

        DownloadErrorHandler(download_->current_payload_reader_->AsyncRead(
                download_->buffer_.begin(), download_->buffer_.end(), [this](io::ExpectedSize result) {
                        PayloadReadHandler(result);
                }));
}

} // namespace v3
} // namespace update_module
} // namespace update
} // namespace mender

1	// Copyright 2023 Northern.tech AS
2	//
3	// Licensed under the Apache License, Version 2.0 (the "License");
4	// you may not use this file except in compliance with the License.
5	// You may obtain a copy of the License at
6	//
7	// http://www.apache.org/licenses/LICENSE-2.0
8	//
9	// Unless required by applicable law or agreed to in writing, software
10	// distributed under the License is distributed on an "AS IS" BASIS,
11	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12	// See the License for the specific language governing permissions and
13	// limitations under the License.
14
15	#include <mender-update/update_module/v3/update_module.hpp>
16
17	#include <mender-update/progress_reader/progress_reader.hpp>
18
19	#include <common/events.hpp>
20	#include <common/events_io.hpp>
21	#include <common/log.hpp>
22	#include <common/path.hpp>
23	#include <common/processes.hpp>
24
25	namespace mender {
26	namespace update {
27	namespace update_module {
28	namespace v3 {
29
30	namespace log = mender::common::log;
31	namespace path = mender::common::path;
32	namespace processes = mender::common::processes;
33	namespace progress = mender::update::progress;
34
35
36	void UpdateModule::StartDownloadProcess() {	136✔
37	string download_command = "Download";	136✔
38	if (download_->downloading_with_sizes_) {	136✔
39	download_command = "DownloadWithFileSizes";	3✔
40	}
41	log::Debug(	136✔
42	"Calling Update Module with command `" + update_module_path_ + " " + download_command + " "	272✔
43	+ update_module_workdir_ + "`.");	408✔
44	download_->proc_ = make_shared<procs::Process>(	136✔
45	vector<string> {update_module_path_, download_command, update_module_workdir_});	680✔
46
47	download_->proc_->SetWorkDir(update_module_workdir_);
48
49	auto err = PrepareStreamNextPipe();	136✔
50	if (err != error::NoError) {	136✔
51	DownloadErrorHandler(err);	×
52	return;
53	}
54
55	processes::OutputHandler stdout_handler {"Update Module output (stdout): "};	136✔
56	processes::OutputHandler stderr_handler {"Update Module output (stderr): "};	136✔
57
58	err = download_->proc_->Start(stdout_handler, stderr_handler);	408✔
59	if (err != error::NoError) {	136✔
60	DownloadErrorHandler(GetProcessError(err));	×
61	return;	×
62	}
63
64	err = download_->proc_->AsyncWait(	136✔
65	download_->event_loop_,
66	[this](error::Error err) {	268✔
67	if (err.code == make_error_condition(errc::timed_out)) {	134✔
68	DownloadTimeoutHandler();	2✔
69	} else {
70	ProcessEndedHandler(err);	264✔
71	}
72	},	134✔
73	chrono::seconds(ctx_.GetConfig().module_timeout_seconds));	136✔
74	if (err != error::NoError) {	136✔
75	DownloadErrorHandler(err);	×
76	return;
77	}
78
79	DownloadErrorHandler(OpenStreamNextPipe(	272✔
80	[this](io::ExpectedAsyncWriterPtr writer) { StreamNextOpenHandler(writer); }));	290✔
81	}
82
83	void UpdateModule::StreamNextOpenHandler(io::ExpectedAsyncWriterPtr writer) {	13✔
84	if (!writer) {	13✔
85	DownloadErrorHandler(writer.error());	×
86	return;	3✔
87	}
88	download_->stream_next_writer_ = writer.value();	13✔
89
90	download_->module_has_started_download_ = true;	13✔
91
92	auto reader = download_->payload_.Next();	13✔
93	if (!reader) {	13✔
94	if (reader.error().code	3✔
95	== artifact::parser_error::MakeError(	3✔
96	artifact::parser_error::NoMorePayloadFilesError, "")	6✔
97	.code) {
98	download_->module_has_finished_download_ = true;	3✔
99	log::Debug("Update Module finished all downloads");	6✔
100	EndStreamNext();	3✔
101	} else {
102	DownloadErrorHandler(reader.error());	×
103	}
104	return;	3✔
105	}
106	auto payload_reader = make_shared<artifact::Reader>(std::move(reader.value()));	10✔
107
108	auto progress_reader = make_shared<progress::Reader>(payload_reader, payload_reader->Size());	10✔
109
110	download_->current_payload_reader_ =
111	make_shared<events::io::AsyncReaderFromReader>(download_->event_loop_, progress_reader);	20✔
112	download_->current_payload_name_ = payload_reader->Name();	20✔
113	download_->current_payload_size_ = payload_reader->Size();	10✔
114
115	auto stream_path =
116	path::Join(update_module_workdir_, string("streams"), download_->current_payload_name_);	20✔
117	auto exp_path_is_safe =
118	path::IsWithinOrEqual(stream_path, path::Join(update_module_workdir_, string("streams")));	20✔
119	if (!exp_path_is_safe.has_value()) {	10✔
120	DownloadErrorHandler(exp_path_is_safe.error().WithContext(	×
121	"Error checking if path is equal to or within directory"));	×
122	return;	×
123	}
124	if (!exp_path_is_safe.value()) {	10✔
125	DownloadErrorHandler(error::Error(	×
126	make_error_condition(errc::invalid_argument),	×
127	"Error downloading payload: Provided payload file (" + download_->current_payload_name_	×
128	+ ") would point outside work directory when extracted."));	×
129	return;	×
130	}
131
132	auto err = PrepareAndOpenStreamPipe(
133	stream_path, [this](io::ExpectedAsyncWriterPtr writer) { StreamOpenHandler(writer); });	22✔
134	if (err != error::NoError) {	10✔
135	DownloadErrorHandler(err);	×
136	return;
137	}
138
139	string stream_next_string;
140	if (download_->downloading_with_sizes_) {	10✔
141	stream_next_string = path::Join("streams", download_->current_payload_name_) + " "	2✔
142	+ to_string(download_->current_payload_size_);	4✔
143	} else {
144	stream_next_string = path::Join("streams", download_->current_payload_name_);	18✔
145	}
146	size_t entry_size = stream_next_string.size() + 1;	10✔
147	if (entry_size > download_->buffer_.size()) {	10✔
148	DownloadErrorHandler(error::Error(	×
149	make_error_condition(errc::no_buffer_space), "Payload name is too large for buffer"));	×
150	return;
151	}
152	copy(stream_next_string.begin(), stream_next_string.end(), download_->buffer_.begin());	10✔
153	download_->buffer_[entry_size - 1] = '\n';	10✔
154	DownloadErrorHandler(download_->stream_next_writer_->AsyncWrite(	10✔
155	download_->buffer_.begin(),
156	download_->buffer_.begin() + entry_size,
157	[this, entry_size](io::ExpectedSize result) {	10✔
158	StreamNextWriteHandler(entry_size, result);	10✔
159	}));	30✔
160	}
161
162	void UpdateModule::StreamOpenHandler(io::ExpectedAsyncWriterPtr writer) {	6✔
163	if (!writer) {	6✔
164	DownloadErrorHandler(writer.error());	×
165	return;	×
166	}
167	download_->current_stream_writer_ = writer.value();	6✔
168
169	DownloadErrorHandler(download_->current_payload_reader_->AsyncRead(	12✔
170	download_->buffer_.begin(), download_->buffer_.end(), [this](io::ExpectedSize result) {	6✔
171	PayloadReadHandler(result);	6✔
172	}));	18✔
173	}
174
175	void UpdateModule::StreamNextWriteHandler(size_t expected_n, io::ExpectedSize result) {	10✔
176	// Close stream-next writer.
177	download_->stream_next_writer_.reset();	10✔
178	if (!result) {	10✔
179	DownloadErrorHandler(result.error());	1✔
180	} else if (expected_n != result.value()) {	9✔
181	DownloadErrorHandler(error::Error(	×
182	make_error_condition(errc::io_error),	×
183	"Unexpected number of written bytes to stream-next"));	×
184	}
185	}	10✔
186
187	void UpdateModule::PayloadReadHandler(io::ExpectedSize result) {	759✔
188	if (!result) {	759✔
189	// Close streams.
190	download_->current_stream_writer_.reset();	3✔
191	download_->current_payload_reader_.reset();	3✔
192	DownloadErrorHandler(result.error());	3✔
193	} else if (result.value() > 0) {	756✔
194	DownloadErrorHandler(download_->current_stream_writer_->AsyncWrite(	633✔
195	download_->buffer_.begin(),
196	download_->buffer_.begin() + result.value(),	633✔
197	[this, result](io::ExpectedSize write_result) {	1,899✔
198	StreamWriteHandler(0, result.value(), write_result);	633✔
199	}));	2,532✔
200	} else {
201	// Close streams.
202	download_->current_stream_writer_.reset();	123✔
203	download_->current_payload_reader_.reset();	123✔
204
205	if (download_->downloading_to_files_) {	123✔
206	StartDownloadToFile();	118✔
207	} else {
208	DownloadErrorHandler(OpenStreamNextPipe(	10✔
209	[this](io::ExpectedAsyncWriterPtr writer) { StreamNextOpenHandler(writer); }));	18✔
210	}
211	}
212	}	759✔
213
214	void UpdateModule::StreamWriteHandler(size_t offset, size_t expected_n, io::ExpectedSize result) {	633✔
215	if (!result) {	633✔
216	DownloadErrorHandler(result.error());	1✔
217	} else if (result.value() == 0 \|\| result.value() > expected_n) {	632✔
218	DownloadErrorHandler(error::Error(	×
219	make_error_condition(errc::io_error),	×
220	"Unexpected number of written bytes to download stream"));	×
221	} else if (result.value() < expected_n) {	632✔
222	auto new_offset = offset + result.value();	×
223	auto new_expected = expected_n - result.value();	×
224	DownloadErrorHandler(download_->current_stream_writer_->AsyncWrite(	×
225	download_->buffer_.begin() + new_offset,
226	download_->buffer_.begin() + new_offset + new_expected,
227	[this, new_offset, new_expected](io::ExpectedSize write_result) {	×
228	StreamWriteHandler(new_offset, new_expected, write_result);	×
229	}));	×
230	} else {
231	download_->written_ += result.value();	632✔
232	log::Trace("Wrote " + to_string(download_->written_) + " bytes to Update Module");	1,264✔
233	DownloadErrorHandler(download_->current_payload_reader_->AsyncRead(	1,264✔
234	download_->buffer_.begin(), download_->buffer_.end(), [this](io::ExpectedSize result) {	632✔
235	PayloadReadHandler(result);	632✔
236	}));	1,896✔
237	}
238	}	633✔
239
240	void UpdateModule::EndStreamNext() {	3✔
241	// Empty write.
242	DownloadErrorHandler(download_->stream_next_writer_->AsyncWrite(	3✔
243	download_->buffer_.begin(), download_->buffer_.begin(), [this](io::ExpectedSize result) {	6✔
244	if (!result) {	3✔
245	DownloadErrorHandler(result.error());	×
246	} else {
247	DownloadErrorHandler(error::NoError);	3✔
248	}
249	// Close writer.
250	download_->stream_next_writer_.reset();	3✔
251	// No further action necessary. Now we just need to wait for the process to finish.
252	}));	6✔
253	}	3✔
254
255	void UpdateModule::DownloadErrorHandler(const error::Error &err) {	1,566✔
256	if (err != error::NoError) {	1,566✔
257	EndDownloadLoop(err);	17✔
258	}
259	}	1,566✔
260
261	void UpdateModule::EndDownloadLoop(const error::Error &err) {	136✔
262	download_->download_finished_handler_(err);	136✔
263	}	136✔
264
265	void UpdateModule::DownloadTimeoutHandler() {	2✔
266	download_->proc_->EnsureTerminated();	2✔
267	EndDownloadLoop(error::Error(	2✔
268	make_error_condition(errc::timed_out), "Update Module Download process timed out"));	4✔
269	}	2✔
270
271	void UpdateModule::ProcessEndedHandler(error::Error err) {	132✔
272	if (err != error::NoError) {	132✔
273	err = GetProcessError(err);	5✔
274	DownloadErrorHandler(error::Error(	10✔
275	err.code, "Download: Update Module returned non-zero status: " + err.message));	10✔
276	} else if (download_->module_has_finished_download_) {	127✔
277	EndDownloadLoop(error::NoError);	3✔
278	} else if (download_->module_has_started_download_) {	124✔
279	DownloadErrorHandler(error::Error(	2✔
280	make_error_condition(errc::broken_pipe),	4✔
281	"Update Module started downloading, but did not finish"));	4✔
282	} else {
283	download_->downloading_to_files_ = true;	122✔
284	download_->stream_next_opener_.reset();	122✔
285	download_->current_stream_opener_.reset();	122✔
286	err = DeleteStreamsFiles();	122✔
287	if (err != error::NoError) {	122✔
288	DownloadErrorHandler(err);	×
289	} else {
290	StartDownloadToFile();	122✔
291	}
292	}
293	}	132✔
294
295	void UpdateModule::StartDownloadToFile() {	240✔
296	auto reader = download_->payload_.Next();	240✔
297	if (!reader) {	240✔
298	if (reader.error().code	118✔
299	== artifact::parser_error::MakeError(	118✔
300	artifact::parser_error::NoMorePayloadFilesError, "")	236✔
301	.code) {
302	log::Debug("Downloaded all files to `files` directory.");	228✔
303	EndDownloadLoop(error::NoError);	114✔
304	} else {
305	DownloadErrorHandler(reader.error());	4✔
306	}
307	return;	118✔
308	}
309	auto payload_reader = make_shared<artifact::Reader>(std::move(reader.value()));	122✔
310	download_->current_payload_reader_ =
311	make_shared<events::io::AsyncReaderFromReader>(download_->event_loop_, payload_reader);	244✔
312	download_->current_payload_name_ = payload_reader->Name();	122✔
313
314	auto stream_path = path::Join(update_module_workdir_, string("files"));	244✔
315	auto err = PrepareDownloadDirectory(stream_path);	122✔
316	if (err != error::NoError) {	122✔
317	DownloadErrorHandler(err);	×
318	return;
319	}
320
321	stream_path = path::Join(stream_path, download_->current_payload_name_);	122✔
322	auto exp_path_is_safe =
323	path::IsWithinOrEqual(stream_path, path::Join(update_module_workdir_, string("files")));	244✔
324	if (!exp_path_is_safe.has_value()) {	122✔
325	DownloadErrorHandler(exp_path_is_safe.error().WithContext(	×
326	"Error checking if path is equal to or within directory"));	×
327	return;	×
328	}
329	if (!exp_path_is_safe.value()) {	122✔
UNCOV 330	DownloadErrorHandler(error::Error(	×
UNCOV 331	make_error_condition(errc::invalid_argument),	×
UNCOV 332	"Error downloading payload: Provided payload file (" + download_->current_payload_name_	×
UNCOV 333	+ ") would point outside work directory when extracted."));	×
UNCOV 334	return;	×
335	}
336
337	auto current_stream_writer =
338	make_shared<events::io::AsyncFileDescriptorWriter>(download_->event_loop_);	122✔
339	err = current_stream_writer->Open(stream_path);	122✔
340	if (err != error::NoError) {	122✔
341	DownloadErrorHandler(err);	1✔
342	return;
343	}
344	download_->current_stream_writer_ = current_stream_writer;
345
346	DownloadErrorHandler(download_->current_payload_reader_->AsyncRead(	242✔
347	download_->buffer_.begin(), download_->buffer_.end(), [this](io::ExpectedSize result) {	121✔
348	PayloadReadHandler(result);	121✔
349	}));	363✔
350	}
351
352	} // namespace v3
353	} // namespace update_module
354	} // namespace update
355	} // namespace mender

mendersoftware / mender / 2257671017

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous