bassim / super-expressive-php / 20877397467

Pull #13

github

Refactor RegexParser with clean architecture

Major refactoring to improve code quality and maintainability:

New structure:
- Parser/Lexer.php: Tokenization with declarative token matching
- Parser/Token.php: Value object for tokens
- Parser/Node.php: Base class for AST nodes
- Parser/Quantifier.php: Encapsulates quantifier logic
- Parser/Nodes/*: Specific node types (Simple, Literal, CharSet, Container, Flag)

Benefits:
- Single Responsibility: Each class has one job
- Declarative: Mappings in const arrays instead of long switch statements
- Testable: Components can be tested independently
- Extensible: Adding new node types is straightforward

RegexParser reduced from ~900 to 233 lines.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

323 of 349 new or added lines in 11 files covered. (92.55%)

754 of 811 relevant lines covered (92.97%)

15.56 hits per line