20820179538

Committed 08 Jan 2026 02:27PM UTC coverage: 45.002% (-0.04%) from 45.046%

Build # 20820179538

Build Type

push

github

Committed by

rubensworks

Commit Message

Fix part states not being revalidated, Closes #1588

Run Details

2611 of 8588 branches covered (30.4%)

Branch coverage included in aggregate %.

11868 of 23586 relevant lines covered (50.32%)

2.39 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

36.36

/src/main/java/org/cyclops/integrateddynamics/core/network/NetworkElementBase.java

package org.cyclops.integrateddynamics.core.network;

import lombok.Data;
import net.minecraft.core.BlockPos;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.level.BlockGetter;
import net.minecraft.world.level.block.Block;
import org.cyclops.cyclopscore.datastructure.DimPos;
import org.cyclops.integrateddynamics.api.network.INetwork;
import org.cyclops.integrateddynamics.api.network.INetworkElement;
import org.cyclops.integrateddynamics.core.helper.NetworkHelpers;

import javax.annotation.Nullable;
import java.util.List;

/**
 * Base implementation for a network element.
 * @author rubensworks
 */
@Data
public abstract class NetworkElementBase implements INetworkElement {

    @Override
    public int getUpdateInterval() {
        return 0;
    }

    @Override
    public boolean isUpdate() {
        return false;
    }

    @Override
    public void update(INetwork network) {

    }

    @Override
    public void beforeNetworkKill(INetwork network) {

    }

    @Override
    public void afterNetworkAlive(INetwork network) {

    }

    @Override
    public void afterNetworkReAlive(INetwork network) {

    }

    @Override
    public void addDrops(List<ItemStack> itemStacks, boolean dropMainElement, boolean saveState) {

    }

    @Override
    public boolean onNetworkAddition(INetwork network) {
        return true;
    }

    @Override
    public void onNetworkRemoval(INetwork network) {

    }

    @Override
    public void onPreRemoved(INetwork network) {

    }

    @Override
    public void onPostRemoved(INetwork network) {

    }

    @Override
    public void onNeighborBlockChange(@Nullable INetwork network, BlockGetter world, Block neighbourBlock,
                                      BlockPos neighbourBlockPos) {

    }

    @Override
    public void invalidate(INetwork network) {
        network.invalidateElement(this);
    }

    @Override
    public void revalidate(INetwork network) {
        network.revalidateElement(this);
    }

    protected boolean canRevalidatePositioned(INetwork network, DimPos dimPos) {
        return dimPos.isLoaded();
    }

    protected boolean revalidatePositioned(INetwork network, DimPos dimPos) {
        return NetworkHelpers.getNetworkCarrier(dimPos.getLevel(true), dimPos.getBlockPos(), null)
                .map(networkCarrier -> {
                    if (networkCarrier.getNetwork() == null) {
                        networkCarrier.setNetwork(network);
                        return true;
                    }
                    return false;
                })
                .orElse(false);
    }
}

1	package org.cyclops.integrateddynamics.core.network;
2
3	import lombok.Data;
4	import net.minecraft.core.BlockPos;
5	import net.minecraft.world.item.ItemStack;
6	import net.minecraft.world.level.BlockGetter;
7	import net.minecraft.world.level.block.Block;
8	import org.cyclops.cyclopscore.datastructure.DimPos;
9	import org.cyclops.integrateddynamics.api.network.INetwork;
10	import org.cyclops.integrateddynamics.api.network.INetworkElement;
11	import org.cyclops.integrateddynamics.core.helper.NetworkHelpers;
12
13	import javax.annotation.Nullable;
14	import java.util.List;
15
16	/**
17	* Base implementation for a network element.
18	* @author rubensworks
19	*/
20	@Data	3!
21	public abstract class NetworkElementBase implements INetworkElement {
22
23	@Override
24	public int getUpdateInterval() {
25	return 0;	×
26	}
27
28	@Override
29	public boolean isUpdate() {
30	return false;	2✔
31	}
32
33	@Override
34	public void update(INetwork network) {
35
36	}	×
37
38	@Override
39	public void beforeNetworkKill(INetwork network) {
40
41	}	1✔
42
43	@Override
44	public void afterNetworkAlive(INetwork network) {
45
46	}	1✔
47
48	@Override
49	public void afterNetworkReAlive(INetwork network) {
50
51	}	1✔
52
53	@Override
54	public void addDrops(List<ItemStack> itemStacks, boolean dropMainElement, boolean saveState) {
55
56	}	1✔
57
58	@Override
59	public boolean onNetworkAddition(INetwork network) {
60	return true;	2✔
61	}
62
63	@Override
64	public void onNetworkRemoval(INetwork network) {
65
66	}	1✔
67
68	@Override
69	public void onPreRemoved(INetwork network) {
70
71	}	×
72
73	@Override
74	public void onPostRemoved(INetwork network) {
75
76	}	×
77
78	@Override
79	public void onNeighborBlockChange(@Nullable INetwork network, BlockGetter world, Block neighbourBlock,
80	BlockPos neighbourBlockPos) {
81
82	}	1✔
83
84	@Override
85	public void invalidate(INetwork network) {
86	network.invalidateElement(this);	3✔
87	}	1✔
88
89	@Override
90	public void revalidate(INetwork network) {
91	network.revalidateElement(this);	×
92	}	×
93
94	protected boolean canRevalidatePositioned(INetwork network, DimPos dimPos) {
95	return dimPos.isLoaded();	3✔
96	}
97
98	protected boolean revalidatePositioned(INetwork network, DimPos dimPos) {
99	return NetworkHelpers.getNetworkCarrier(dimPos.getLevel(true), dimPos.getBlockPos(), null)	×
100	.map(networkCarrier -> {	×
101	if (networkCarrier.getNetwork() == null) {	×
102	networkCarrier.setNetwork(network);	×
103	return true;	×
104	}
105	return false;	×
106	})
107	.orElse(false);	×
108	}
109	}

CyclopsMC / IntegratedDynamics / 20820179538

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous