#4913

Committed 06 Jan 2026 01:30AM UTC coverage: 64.884% (-0.004%) from 64.888%

Build # #4913

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

merge: from main to 3.0 branch #34167

Run Details

180 of 319 new or added lines in 14 files covered. (56.43%)

571 existing lines in 128 files now uncovered.

195016 of 300563 relevant lines covered (64.88%)

117540852.85 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

77.14

/source/libs/sync/src/syncAppendEntriesReply.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "syncAppendEntriesReply.h"
#include "syncCommit.h"
#include "syncIndexMgr.h"
#include "syncPipeline.h"
#include "syncMessage.h"
#include "syncRaftEntry.h"
#include "syncRaftStore.h"
#include "syncReplication.h"
#include "syncSnapshot.h"
#include "syncUtil.h"

// TLA+ Spec
// HandleAppendEntriesResponse(i, j, m) ==
//    /\ m.mterm = currentTerm[i]
//    /\ \/ /\ m.msuccess \* successful
//          /\ nextIndex'  = [nextIndex  EXCEPT ![i][j] = m.mmatchIndex + 1]
//          /\ matchIndex' = [matchIndex EXCEPT ![i][j] = m.mmatchIndex]
//       \/ /\ \lnot m.msuccess \* not successful
//          /\ nextIndex' = [nextIndex EXCEPT ![i][j] =
//                               Max({nextIndex[i][j] - 1, 1})]
//          /\ UNCHANGED <<matchIndex>>
//    /\ Discard(m)
//    /\ UNCHANGED <<serverVars, candidateVars, logVars, elections>>
//

int32_t syncNodeOnAppendEntriesReply(SSyncNode* ths, const SRpcMsg* pRpcMsg) {
  int32_t                 code = 0;
  SyncAppendEntriesReply* pMsg = (SyncAppendEntriesReply*)pRpcMsg->pCont;
  int32_t                 ret = 0;

  // if already drop replica, do not process
  if (!syncNodeInRaftGroup(ths, &(pMsg->srcId))) {
    syncLogRecvAppendEntriesReply(ths, pMsg, "not in my config", &pRpcMsg->info.traceId);
    return 0;
  }

  // drop stale response
  if (pMsg->term < raftStoreGetTerm(ths)) {
    syncLogRecvAppendEntriesReply(ths, pMsg, "drop stale response", &pRpcMsg->info.traceId);
    return 0;
  }

  if (ths->state == TAOS_SYNC_STATE_LEADER || ths->state == TAOS_SYNC_STATE_ASSIGNED_LEADER) {
    if (pMsg->term != raftStoreGetTerm(ths)) {
      syncLogRecvAppendEntriesReply(ths, pMsg, "error term", &pRpcMsg->info.traceId);
      syncNodeStepDown(ths, pMsg->term, pMsg->srcId, "appendEntryReply");
      return TSDB_CODE_SYN_WRONG_TERM;
    }

    sGDebug(&pRpcMsg->info.traceId, "vgId:%d, received append entries reply, src addr:0x%" PRIx64 ", term:%" PRId64 ", matchIndex:%" PRId64,
            pMsg->vgId, pMsg->srcId.addr, pMsg->term, pMsg->matchIndex);

    if (pMsg->success) {
      SyncIndex oldMatchIndex = syncIndexMgrGetIndex(ths->pMatchIndex, &(pMsg->srcId));
      if (pMsg->matchIndex > oldMatchIndex) {
        syncIndexMgrSetIndex(ths->pMatchIndex, &(pMsg->srcId), pMsg->matchIndex);
      }

      // commit if needed
      SyncIndex indexLikely = TMIN(pMsg->matchIndex, ths->pLogBuf->matchIndex);
      SyncIndex commitIndex = syncNodeCheckCommitIndex(ths, indexLikely, &pRpcMsg->info.traceId);
      if (ths->state == TAOS_SYNC_STATE_ASSIGNED_LEADER) {
        if (commitIndex >= ths->assignedCommitIndex) {
          sInfo("vgId:%d, going to step down from assigned leader by append entries reply, commitIndex:%" PRId64
                ", assignedCommitIndex:%" PRId64,
                ths->vgId, ths->assignedCommitIndex, commitIndex);
          syncNodeStepDown(ths, pMsg->term, pMsg->destId, "appendEntryReply");
        }
      } else {
        TAOS_CHECK_RETURN(syncLogBufferCommit(ths->pLogBuf, ths, commitIndex, &pRpcMsg->info.traceId, "sync-append-entries-reply"));
      }
    }

    // replicate log
    SSyncLogReplMgr* pMgr = syncNodeGetLogReplMgr(ths, &pMsg->srcId);
    if (pMgr == NULL) {
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
      if (terrno != 0) code = terrno;
      sError("vgId:%d, failed to get log repl mgr for src addr:0x%" PRIx64, ths->vgId, pMsg->srcId.addr);
      TAOS_RETURN(code);
    }
    TAOS_CHECK_RETURN(syncLogReplProcessReply(pMgr, ths, pMsg));
  }
  TAOS_RETURN(code);
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "syncAppendEntriesReply.h"
18	#include "syncCommit.h"
19	#include "syncIndexMgr.h"
20	#include "syncPipeline.h"
21	#include "syncMessage.h"
22	#include "syncRaftEntry.h"
23	#include "syncRaftStore.h"
24	#include "syncReplication.h"
25	#include "syncSnapshot.h"
26	#include "syncUtil.h"
27
28	// TLA+ Spec
29	// HandleAppendEntriesResponse(i, j, m) ==
30	// /\ m.mterm = currentTerm[i]
31	// /\ \/ /\ m.msuccess \* successful
32	// /\ nextIndex' = [nextIndex EXCEPT ![i][j] = m.mmatchIndex + 1]
33	// /\ matchIndex' = [matchIndex EXCEPT ![i][j] = m.mmatchIndex]
34	// \/ /\ \lnot m.msuccess \* not successful
35	// /\ nextIndex' = [nextIndex EXCEPT ![i][j] =
36	// Max({nextIndex[i][j] - 1, 1})]
37	// /\ UNCHANGED <<matchIndex>>
38	// /\ Discard(m)
39	// /\ UNCHANGED <<serverVars, candidateVars, logVars, elections>>
40	//
41
42	int32_t syncNodeOnAppendEntriesReply(SSyncNode* ths, const SRpcMsg* pRpcMsg) {	93,811,891✔
43	int32_t code = 0;	93,811,891✔
44	SyncAppendEntriesReply* pMsg = (SyncAppendEntriesReply*)pRpcMsg->pCont;	93,811,891✔
45	int32_t ret = 0;	93,811,891✔
46
47	// if already drop replica, do not process
48	if (!syncNodeInRaftGroup(ths, &(pMsg->srcId))) {	93,811,891✔
49	syncLogRecvAppendEntriesReply(ths, pMsg, "not in my config", &pRpcMsg->info.traceId);	×
50	return 0;	×
51	}
52
53	// drop stale response
54	if (pMsg->term < raftStoreGetTerm(ths)) {	93,811,891✔
55	syncLogRecvAppendEntriesReply(ths, pMsg, "drop stale response", &pRpcMsg->info.traceId);	745✔
56	return 0;	745✔
57	}
58
59	if (ths->state == TAOS_SYNC_STATE_LEADER \|\| ths->state == TAOS_SYNC_STATE_ASSIGNED_LEADER) {	93,811,146✔
60	if (pMsg->term != raftStoreGetTerm(ths)) {	93,810,490✔
UNCOV 61	syncLogRecvAppendEntriesReply(ths, pMsg, "error term", &pRpcMsg->info.traceId);	×
UNCOV 62	syncNodeStepDown(ths, pMsg->term, pMsg->srcId, "appendEntryReply");	×
UNCOV 63	return TSDB_CODE_SYN_WRONG_TERM;	×
64	}
65
66	sGDebug(&pRpcMsg->info.traceId, "vgId:%d, received append entries reply, src addr:0x%" PRIx64 ", term:%" PRId64 ", matchIndex:%" PRId64,	93,810,490✔
67	pMsg->vgId, pMsg->srcId.addr, pMsg->term, pMsg->matchIndex);
68
69	if (pMsg->success) {	93,810,490✔
70	SyncIndex oldMatchIndex = syncIndexMgrGetIndex(ths->pMatchIndex, &(pMsg->srcId));	90,686,187✔
71	if (pMsg->matchIndex > oldMatchIndex) {	90,686,187✔
72	syncIndexMgrSetIndex(ths->pMatchIndex, &(pMsg->srcId), pMsg->matchIndex);	86,958,723✔
73	}
74
75	// commit if needed
76	SyncIndex indexLikely = TMIN(pMsg->matchIndex, ths->pLogBuf->matchIndex);	90,686,187✔
77	SyncIndex commitIndex = syncNodeCheckCommitIndex(ths, indexLikely, &pRpcMsg->info.traceId);	90,686,187✔
78	if (ths->state == TAOS_SYNC_STATE_ASSIGNED_LEADER) {	90,685,509✔
79	if (commitIndex >= ths->assignedCommitIndex) {	×
80	sInfo("vgId:%d, going to step down from assigned leader by append entries reply, commitIndex:%" PRId64	×
81	", assignedCommitIndex:%" PRId64,
82	ths->vgId, ths->assignedCommitIndex, commitIndex);
83	syncNodeStepDown(ths, pMsg->term, pMsg->destId, "appendEntryReply");	×
84	}
85	} else {
86	TAOS_CHECK_RETURN(syncLogBufferCommit(ths->pLogBuf, ths, commitIndex, &pRpcMsg->info.traceId, "sync-append-entries-reply"));	90,685,509✔
87	}
88	}
89
90	// replicate log
91	SSyncLogReplMgr* pMgr = syncNodeGetLogReplMgr(ths, &pMsg->srcId);	93,809,812✔
92	if (pMgr == NULL) {	93,810,490✔
93	code = TSDB_CODE_MND_RETURN_VALUE_NULL;	269✔
94	if (terrno != 0) code = terrno;	269✔
95	sError("vgId:%d, failed to get log repl mgr for src addr:0x%" PRIx64, ths->vgId, pMsg->srcId.addr);	269✔
96	TAOS_RETURN(code);	269✔
97	}
98	TAOS_CHECK_RETURN(syncLogReplProcessReply(pMgr, ths, pMsg));	93,810,221✔
99	}
100	TAOS_RETURN(code);	93,810,593✔
101	}

taosdata / TDengine / #4913

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous