sebnitu / vrembem / 20729106766

push

github

General core refactors and idiomatic improvements  (#2606)

This PR introduces a number of core refactors and idiomatic changes to help improve the API of core modules and helpers. Below are the changes made:

**Module**

- `PluginArray`: Refactored to no longer extend the Array class. Instead, it now uses a private array to better control the exposed methods when mutating the array.
- `PluginArray`: Now calls the `setup` and `teardown` methods when a plugin is added and removed respectively.
- Module: `PluginArray` plugins can now be passed a custom name via options argument. This can be used to register the same plugin multiple times for different purposes and configurations.
- Module: `PluginArray` new `length` property has been added.
- Module: `PluginArray` get will now return the entire plugins array when the `"*"` argument is passed.
- Module: `StackArray` has been refactored to no longer extend the Array class. 
- Module: `StackArray` new `length` property has been added. 
- Module: `StackArray` new `get` method has been added. 

**Plugins**

- `cssConfig`: Added the `updateEvent` option to allow modifying the event name that triggers an update.

**Helpers**

- `cssVar`: No longer returns an error if a property isn't found and fallback not provided. Function will now always return a string.
- `getCustomProps`: Now uses the keys of `entry.parent.config` instead of a `customProps` array of props.
- `getPrefix`: Now takes an optional delimiter argument.

**Sass Modules**

- `css`: Removed the need to manually provide `"-"` delimiter in CSS custom property prefix. Delimiter is now added automatically if a variable prefix has been defined.
- `theme`: Removed the need to manually provide `"-"` delimiter from theme prefix.
- `theme`: Added the `theme.class` function to output a theme class which automatically applies the prefix and delimiter if a prefix is set.

**Components**

- `Modal`, `Drawer`, `Popover`: Deprecated the use of `customProps` confi... (continued)

566 of 617 branches covered (91.73%)

Branch coverage included in aggregate %.

43 of 49 new or added lines in 12 files covered. (87.76%)

925 of 969 relevant lines covered (95.46%)

29.99 hits per line