• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4911

04 Jan 2026 09:05AM UTC coverage: 65.028% (-0.8%) from 65.864%
#4911

push

travis-ci

web-flow
merge: from main to 3.0 branch #34156

1206 of 4524 new or added lines in 22 files covered. (26.66%)

1517 existing lines in 134 files now uncovered.

195276 of 300296 relevant lines covered (65.03%)

116931714.52 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.38
/source/dnode/vnode/src/tsdb/tsdbCommit2.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "tsdbCommit2.h"
17

18
// extern dependencies
19
typedef struct {
20
  int32_t    fid;
21
  STFileSet *fset;
22
} SFileSetCommitInfo;
23

24
typedef struct {
25
  STsdb  *tsdb;
26
  int32_t minutes;
27
  int8_t  precision;
28
  int32_t minRow;
29
  int32_t maxRow;
30
  int8_t  cmprAlg;
31
  int32_t sttTrigger;
32
  int32_t szPage;
33
  int64_t compactVersion;
34
  int64_t cid;
35
  int64_t now;
36

37
  struct {
38
    SFileSetCommitInfo *info;
39

40
    int32_t expLevel;
41
    TSKEY   minKey;
42
    TSKEY   maxKey;
43
    TABLEID tbid[1];
44
    bool    hasTSData;
45

46
    bool      skipTsRow;
47
    SHashObj *pColCmprObj;
48
  } ctx[1];
49

50
  // reader
51
  TSttFileReaderArray sttReaderArray[1];
52
  // iter
53
  TTsdbIterArray dataIterArray[1];
54
  SIterMerger   *dataIterMerger;
55
  TTsdbIterArray tombIterArray[1];
56
  SIterMerger   *tombIterMerger;
57
  // writer
58
  SFSetWriter *writer;
59

60
  TFileOpArray fopArray[1];
61
} SCommitter2;
62

63
static int32_t tsdbCommitOpenWriter(SCommitter2 *committer) {
15,784,570✔
64
  int32_t code = 0;
15,784,570✔
65
  int32_t lino = 0;
15,784,570✔
66

67
  SFSetWriterConfig config = {
15,791,159✔
68
      .tsdb = committer->tsdb,
15,793,380✔
69
      .toSttOnly = true,
70
      .compactVersion = committer->compactVersion,
15,791,846✔
71
      .minRow = committer->minRow,
15,793,060✔
72
      .maxRow = committer->maxRow,
15,796,323✔
73
      .szPage = committer->szPage,
15,795,706✔
74
      .cmprAlg = committer->cmprAlg,
15,789,160✔
75
      .fid = committer->ctx->info->fid,
15,792,917✔
76
      .cid = committer->cid,
15,793,143✔
77
      .expLevel = committer->ctx->expLevel,
15,793,496✔
78
      .level = 0,
79
  };
80

81
  if (committer->sttTrigger == 1) {
15,789,545✔
82
    config.toSttOnly = false;
3,340,940✔
83

84
    if (committer->ctx->info->fset) {
3,340,940✔
85
      for (int32_t ftype = TSDB_FTYPE_MIN; ftype < TSDB_FTYPE_MAX; ftype++) {
840,675✔
86
        if (committer->ctx->info->fset->farr[ftype] != NULL) {
672,540✔
87
          config.files[ftype].exist = true;
496,835✔
88
          config.files[ftype].file = committer->ctx->info->fset->farr[ftype]->f[0];
496,835✔
89
        }
90
      }
91
    }
92
  }
93

94
  TAOS_CHECK_GOTO(tsdbFSetWriterOpen(&config, &committer->writer), &lino, _exit);
15,793,592✔
95

96
_exit:
15,793,236✔
97
  if (code) {
15,793,837✔
98
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
99
              tstrerror(code));
100
  }
101
  return code;
15,793,837✔
102
}
103

104
static int32_t tsdbCommitCloseWriter(SCommitter2 *committer) {
15,795,768✔
105
  return tsdbFSetWriterClose(&committer->writer, 0, committer->fopArray);
15,795,768✔
106
}
107

108
static int32_t tsdbCommitTSData(SCommitter2 *committer) {
15,789,588✔
109
  int32_t   code = 0;
15,789,588✔
110
  int32_t   lino = 0;
15,789,588✔
111
  int64_t   numOfRow = 0;
15,792,134✔
112
  SMetaInfo info;
15,791,806✔
113

114
  committer->ctx->hasTSData = false;
15,791,237✔
115

116
  committer->ctx->tbid->suid = 0;
15,793,223✔
117
  committer->ctx->tbid->uid = 0;
15,792,993✔
118
  for (SRowInfo *row; (row = tsdbIterMergerGetData(committer->dataIterMerger)) != NULL;) {
2,147,483,647✔
119
    if (row->uid != committer->ctx->tbid->uid) {
2,147,483,647✔
120
      committer->ctx->tbid->suid = row->suid;
99,005,233✔
121
      committer->ctx->tbid->uid = row->uid;
98,990,745✔
122

123
      if (metaGetInfo(committer->tsdb->pVnode->pMeta, row->uid, &info, NULL) != 0) {
99,005,253✔
124
        TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(committer->dataIterMerger, committer->ctx->tbid), &lino, _exit);
1,307,943✔
125
        continue;
1,307,943✔
126
      }
127
    }
128

129
    int64_t ts = TSDBROW_TS(&row->row);
2,147,483,647✔
130
    if (ts > committer->ctx->maxKey) {
2,147,483,647✔
131
      TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(committer->dataIterMerger, committer->ctx->tbid), &lino, _exit);
41,086,012✔
132
      continue;
41,086,579✔
133
    }
134

135
    committer->ctx->hasTSData = true;
2,147,483,647✔
136
    numOfRow++;
2,147,483,647✔
137

138
    TAOS_CHECK_GOTO(tsdbFSetWriteRow(committer->writer, row), &lino, _exit);
2,147,483,647✔
139
    TAOS_CHECK_GOTO(tsdbIterMergerNext(committer->dataIterMerger), &lino, _exit);
2,147,483,647✔
140
  }
141

142
_exit:
15,799,534✔
143
  if (code) {
15,796,657✔
144
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
145
              tstrerror(code));
146
  } else {
147
    tsdbDebug("vgId:%d fid:%d commit %" PRId64 " rows", TD_VID(committer->tsdb->pVnode), committer->ctx->info->fid,
15,796,657✔
148
              numOfRow);
149
  }
150
  return code;
15,796,657✔
151
}
152

153
static int32_t tsdbCommitTombData(SCommitter2 *committer) {
15,795,852✔
154
  int32_t   code = 0;
15,795,852✔
155
  int32_t   lino = 0;
15,795,852✔
156
  int64_t   numRecord = 0;
15,797,409✔
157
  SMetaInfo info;
15,797,081✔
158

159
  // if no history data and no new timestamp data, skip tomb data
160
  if (committer->ctx->info->fset || committer->ctx->hasTSData) {
15,797,569✔
161
    committer->ctx->tbid->suid = 0;
15,780,671✔
162
    committer->ctx->tbid->uid = 0;
15,782,335✔
163
    for (STombRecord *record; (record = tsdbIterMergerGetTombRecord(committer->tombIterMerger));) {
17,524,939✔
164
      if (record->uid != committer->ctx->tbid->uid) {
1,742,604✔
165
        committer->ctx->tbid->suid = record->suid;
1,709,610✔
166
        committer->ctx->tbid->uid = record->uid;
1,709,610✔
167

168
        if (metaGetInfo(committer->tsdb->pVnode->pMeta, record->uid, &info, NULL) != 0) {
1,709,610✔
169
          TAOS_CHECK_GOTO(tsdbIterMergerSkipTableData(committer->tombIterMerger, committer->ctx->tbid), &lino, _exit);
16,202✔
170
          continue;
16,202✔
171
        }
172
      }
173

174
      if (record->ekey < committer->ctx->minKey) {
1,726,402✔
175
        // do nothing
176
      } else if (record->skey > committer->ctx->maxKey) {
1,716,056✔
177
        // committer->ctx->nextKey = TMIN(record->skey, committer->ctx->nextKey);
178
      } else {
179
        record->skey = TMAX(record->skey, committer->ctx->minKey);
1,708,400✔
180
        record->ekey = TMIN(record->ekey, committer->ctx->maxKey);
1,708,400✔
181

182
        numRecord++;
1,708,400✔
183
        TAOS_CHECK_GOTO(tsdbFSetWriteTombRecord(committer->writer, record), &lino, _exit);
1,708,400✔
184
      }
185

186
      TAOS_CHECK_GOTO(tsdbIterMergerNext(committer->tombIterMerger), &lino, _exit);
1,726,402✔
187
    }
188
  }
189

190
_exit:
15,799,093✔
191
  if (code) {
15,799,534✔
192
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
193
              tstrerror(code));
194
  } else {
195
    tsdbDebug("vgId:%d fid:%d commit %" PRId64 " tomb records", TD_VID(committer->tsdb->pVnode),
15,799,534✔
196
              committer->ctx->info->fid, numRecord);
197
  }
198
  return code;
15,799,534✔
199
}
200

201
static void tsdbCommitCloseReader(SCommitter2 *committer) {
15,789,612✔
202
  TARRAY2_CLEAR(committer->sttReaderArray, tsdbSttFileReaderClose);
15,795,360✔
203
  return;
15,791,325✔
204
}
205

206
static int32_t tsdbCommitOpenReader(SCommitter2 *committer) {
15,785,633✔
207
  int32_t code = 0;
15,785,633✔
208
  int32_t lino = 0;
15,785,633✔
209

210
  if (committer->ctx->info->fset == NULL                        //
15,792,268✔
211
      || committer->sttTrigger > 1                              //
2,019,191✔
212
      || TARRAY2_SIZE(committer->ctx->info->fset->lvlArr) == 0  //
168,135✔
213
  ) {
214
    return 0;
15,781,980✔
215
  }
216

217
  SSttLvl *lvl;
218
  TARRAY2_FOREACH(committer->ctx->info->fset->lvlArr, lvl) {
11,496✔
219
    STFileObj *fobj = NULL;
5,748✔
220
    TARRAY2_FOREACH(lvl->fobjArr, fobj) {
11,496✔
221
      SSttFileReader *sttReader;
5,748✔
222

223
      SSttFileReaderConfig config = {
11,496✔
224
          .tsdb = committer->tsdb,
5,748✔
225
          .szPage = committer->szPage,
5,748✔
226
          .file = fobj->f[0],
227
      };
228

229
      TAOS_CHECK_GOTO(tsdbSttFileReaderOpen(fobj->fname, &config, &sttReader), &lino, _exit);
5,748✔
230

231
      TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->sttReaderArray, sttReader), &lino, _exit);
11,496✔
232

233
      STFileOp op = {
11,496✔
234
          .optype = TSDB_FOP_REMOVE,
235
          .fid = fobj->f->fid,
5,748✔
236
          .of = fobj->f[0],
237
      };
238

239
      TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->fopArray, op), &lino, _exit);
11,496✔
240
    }
241
  }
242

243
_exit:
5,748✔
244
  if (code) {
5,748✔
245
    tsdbCommitCloseReader(committer);
×
246
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
247
              tstrerror(code));
248
  }
249
  return code;
5,748✔
250
}
251

252
static void tsdbCommitCloseIter(SCommitter2 *committer) {
15,793,698✔
253
  tsdbIterMergerClose(&committer->tombIterMerger);
15,793,698✔
254
  tsdbIterMergerClose(&committer->dataIterMerger);
15,792,228✔
255
  TARRAY2_CLEAR(committer->tombIterArray, tsdbIterClose);
31,592,453✔
256
  TARRAY2_CLEAR(committer->dataIterArray, tsdbIterClose);
31,595,829✔
257
  return;
15,797,895✔
258
}
259

260
static int32_t tsdbCommitOpenIter(SCommitter2 *committer) {
15,786,743✔
261
  int32_t code = 0;
15,786,743✔
262
  int32_t lino = 0;
15,786,743✔
263

264
  STsdbIter      *iter;
15,793,032✔
265
  STsdbIterConfig config = {0};
15,793,176✔
266

267
  // mem data iter
268
  config.type = TSDB_ITER_TYPE_MEMT;
15,794,388✔
269
  config.memt = committer->tsdb->imem;
15,794,388✔
270
  config.from->version = VERSION_MIN;
15,797,235✔
271
  config.from->key = (SRowKey){
15,796,354✔
272
      .ts = committer->ctx->minKey,
15,797,235✔
273
      .numOfPKs = 0,
274
  };
275

276
  TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
15,796,354✔
277
  TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->dataIterArray, iter), &lino, _exit);
31,588,434✔
278

279
  // mem tomb iter
280
  config.type = TSDB_ITER_TYPE_MEMT_TOMB;
15,794,048✔
281
  config.memt = committer->tsdb->imem;
15,794,048✔
282

283
  TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
15,794,933✔
284
  TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->tombIterArray, iter), &lino, _exit);
31,587,994✔
285

286
  // STT
287
  SSttFileReader *sttReader;
288
  TARRAY2_FOREACH(committer->sttReaderArray, sttReader) {
15,798,653✔
289
    // data iter
290
    config.type = TSDB_ITER_TYPE_STT;
5,748✔
291
    config.sttReader = sttReader;
5,748✔
292

293
    TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
5,748✔
294
    TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->dataIterArray, iter), &lino, _exit);
11,496✔
295

296
    // tomb iter
297
    config.type = TSDB_ITER_TYPE_STT_TOMB;
5,748✔
298
    config.sttReader = sttReader;
5,748✔
299

300
    TAOS_CHECK_GOTO(tsdbIterOpen(&config, &iter), &lino, _exit);
5,748✔
301

302
    TAOS_CHECK_GOTO(TARRAY2_APPEND(committer->tombIterArray, iter), &lino, _exit);
11,496✔
303
  }
304

305
  // open merger
306
  TAOS_CHECK_GOTO(tsdbIterMergerOpen(committer->dataIterArray, &committer->dataIterMerger, false), &lino, _exit);
15,792,649✔
307
  TAOS_CHECK_GOTO(tsdbIterMergerOpen(committer->tombIterArray, &committer->tombIterMerger, true), &lino, _exit);
15,791,088✔
308

309
_exit:
15,797,016✔
310
  if (code) {
15,791,937✔
311
    tsdbCommitCloseIter(committer);
×
312
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
313
              tstrerror(code));
314
  }
315
  return code;
15,791,937✔
316
}
317

318
static int32_t tsdbCommitFileSetBegin(SCommitter2 *committer) {
15,793,397✔
319
  int32_t code = 0;
15,793,397✔
320
  int32_t lino = 0;
15,793,397✔
321
  STsdb  *tsdb = committer->tsdb;
15,795,663✔
322

323
  // check if can commit
324
  tsdbFSCheckCommit(tsdb, committer->ctx->info->fid);
15,796,342✔
325

326
  committer->ctx->expLevel = tsdbFidLevel(committer->ctx->info->fid, &tsdb->keepCfg, committer->now);
15,791,389✔
327
  tsdbFidKeyRange(committer->ctx->info->fid, committer->minutes, committer->precision, &committer->ctx->minKey,
15,790,491✔
328
                  &committer->ctx->maxKey);
329

330
  committer->ctx->tbid->suid = 0;
15,790,447✔
331
  committer->ctx->tbid->uid = 0;
15,790,553✔
332

333
  TAOS_CHECK_GOTO(tsdbCommitOpenReader(committer), &lino, _exit);
15,785,374✔
334
  TAOS_CHECK_GOTO(tsdbCommitOpenIter(committer), &lino, _exit);
15,787,198✔
335
  TAOS_CHECK_GOTO(tsdbCommitOpenWriter(committer), &lino, _exit);
15,791,700✔
336

337
_exit:
15,792,703✔
338
  if (code) {
15,793,033✔
339
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
340
  } else {
341
    tsdbDebug("vgId:%d %s done, fid:%d minKey:%" PRId64 " maxKey:%" PRId64 " expLevel:%d", TD_VID(tsdb->pVnode),
15,793,033✔
342
              __func__, committer->ctx->info->fid, committer->ctx->minKey, committer->ctx->maxKey,
343
              committer->ctx->expLevel);
344
  }
345
  return code;
15,793,033✔
346
}
347

348
static int32_t tsdbCommitFileSetEnd(SCommitter2 *committer) {
15,797,123✔
349
  int32_t code = 0;
15,797,123✔
350
  int32_t lino = 0;
15,797,123✔
351

352
  TAOS_CHECK_GOTO(tsdbCommitCloseWriter(committer), &lino, _exit);
15,798,069✔
353
  tsdbCommitCloseIter(committer);
15,793,182✔
354
  tsdbCommitCloseReader(committer);
15,796,052✔
355

356
_exit:
15,789,856✔
357
  if (code) {
15,791,209✔
358
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
359
              tstrerror(code));
360
  } else {
361
    tsdbDebug("vgId:%d %s done, fid:%d", TD_VID(committer->tsdb->pVnode), __func__, committer->ctx->info->fid);
15,791,209✔
362
  }
363
  return code;
15,791,753✔
364
}
365

366
static int32_t tsdbCommitFileSet(SCommitter2 *committer) {
15,795,291✔
367
  int32_t code = 0;
15,795,291✔
368
  int32_t lino = 0;
15,795,291✔
369

370
  TAOS_CHECK_GOTO(tsdbCommitFileSetBegin(committer), &lino, _exit);
15,795,641✔
371
  TAOS_CHECK_GOTO(tsdbCommitTSData(committer), &lino, _exit);
15,789,328✔
372
  TAOS_CHECK_GOTO(tsdbCommitTombData(committer), &lino, _exit);
15,796,293✔
373
  TAOS_CHECK_GOTO(tsdbCommitFileSetEnd(committer), &lino, _exit);
15,799,369✔
374

375
_exit:
15,790,875✔
376
  if (code) {
15,793,268✔
377
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
378
              tstrerror(code));
379
  } else {
380
    tsdbDebug("vgId:%d %s done, fid:%d", TD_VID(committer->tsdb->pVnode), __func__, committer->ctx->info->fid);
15,793,268✔
381
  }
382
  return code;
15,793,268✔
383
}
384

385
static int32_t tFileSetCommitInfoCompare(const void *arg1, const void *arg2) {
2,147,483,647✔
386
  SFileSetCommitInfo *info1 = (SFileSetCommitInfo *)arg1;
2,147,483,647✔
387
  SFileSetCommitInfo *info2 = (SFileSetCommitInfo *)arg2;
2,147,483,647✔
388

389
  if (info1->fid < info2->fid) {
2,147,483,647✔
390
    return -1;
2,147,483,647✔
391
  } else if (info1->fid > info2->fid) {
103,232,567✔
392
    return 1;
8,934,030✔
393
  } else {
394
    return 0;
94,299,609✔
395
  }
396
}
397

398
static int32_t tFileSetCommitInfoPCompare(const void *arg1, const void *arg2) {
2,147,483,647✔
399
  return tFileSetCommitInfoCompare(*(SFileSetCommitInfo **)arg1, *(SFileSetCommitInfo **)arg2);
2,147,483,647✔
400
}
401

402
static uint32_t tFileSetCommitInfoHash(const void *arg) {
136,537,389✔
403
  SFileSetCommitInfo *info = (SFileSetCommitInfo *)arg;
136,537,389✔
404
  return MurmurHash3_32((const char *)&info->fid, sizeof(info->fid));
136,537,389✔
405
}
406

407
static void tsdbCommitInfoDestroy(STsdb *pTsdb) {
2,618,862✔
408
  if (pTsdb->commitInfo) {
2,618,862✔
409
    for (int32_t i = 0; i < taosArrayGetSize(pTsdb->commitInfo->arr); i++) {
18,418,396✔
410
      SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(pTsdb->commitInfo->arr, i);
15,799,534✔
411
      int32_t             ret = vHashDrop(pTsdb->commitInfo->ht, info);
15,799,534✔
412
      tsdbTFileSetClear(&info->fset);
15,799,534✔
413
      taosMemoryFree(info);
15,799,534✔
414
    }
415

416
    vHashDestroy(&pTsdb->commitInfo->ht);
2,618,862✔
417
    taosArrayDestroy(pTsdb->commitInfo->arr);
2,618,862✔
418
    pTsdb->commitInfo->arr = NULL;
2,618,862✔
419
    taosMemoryFreeClear(pTsdb->commitInfo);
2,618,862✔
420
  }
421
  return;
2,618,862✔
422
}
423

424
static int32_t tsdbCommitInfoInit(STsdb *pTsdb) {
2,616,911✔
425
  int32_t code = 0;
2,616,911✔
426
  int32_t lino = 0;
2,616,911✔
427

428
  pTsdb->commitInfo = taosMemoryCalloc(1, sizeof(*pTsdb->commitInfo));
2,618,862✔
429
  if (pTsdb->commitInfo == NULL) {
2,618,862✔
430
    TAOS_CHECK_GOTO(terrno, &lino, _exit);
×
431
  }
432

433
  TAOS_CHECK_GOTO(vHashInit(&pTsdb->commitInfo->ht, tFileSetCommitInfoHash, tFileSetCommitInfoCompare), &lino, _exit);
2,618,013✔
434

435
  pTsdb->commitInfo->arr = taosArrayInit(0, sizeof(SFileSetCommitInfo *));
2,618,862✔
436
  if (pTsdb->commitInfo->arr == NULL) {
2,618,862✔
437
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
438
  }
439

440
_exit:
2,618,862✔
441
  if (code) {
2,618,862✔
442
    tsdbCommitInfoDestroy(pTsdb);
×
443
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(pTsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
444
  }
445
  return code;
2,618,862✔
446
}
447

448
static int32_t tsdbCommitInfoAdd(STsdb *tsdb, int32_t fid) {
15,798,685✔
449
  int32_t code = 0;
15,798,685✔
450
  int32_t lino = 0;
15,798,685✔
451

452
  SFileSetCommitInfo *tinfo;
15,798,542✔
453

454
  if ((tinfo = taosMemoryMalloc(sizeof(*tinfo))) == NULL) {
15,798,118✔
455
    TAOS_CHECK_GOTO(terrno, &lino, _exit);
×
456
  }
457
  tinfo->fid = fid;
15,798,099✔
458
  tinfo->fset = NULL;
15,797,667✔
459

460
  TAOS_CHECK_GOTO(vHashPut(tsdb->commitInfo->ht, tinfo), &lino, _exit);
15,798,249✔
461

462
  if ((taosArrayPush(tsdb->commitInfo->arr, &tinfo)) == NULL) {
31,595,984✔
463
    TAOS_CHECK_GOTO(terrno, &lino, _exit);
×
464
  }
465
  taosArraySort(tsdb->commitInfo->arr, tFileSetCommitInfoPCompare);
15,797,017✔
466

467
_exit:
15,799,120✔
468
  if (code) {
15,799,120✔
469
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
470
  }
471
  return code;
15,799,120✔
472
}
473

474
static int32_t tsdbCommitInfoBuild(STsdb *tsdb) {
2,618,862✔
475
  int32_t code = 0;
2,618,862✔
476
  int32_t lino = 0;
2,618,862✔
477

478
  STFileSet  *fset = NULL;
2,618,862✔
479
  SRBTreeIter iter;
2,618,640✔
480

481
  TAOS_CHECK_GOTO(tsdbCommitInfoInit(tsdb), &lino, _exit);
2,618,862✔
482

483
  // scan time-series data
484
  iter = tRBTreeIterCreate(tsdb->imem->tbDataTree, 1);
2,618,858✔
485
  for (SRBTreeNode *node = tRBTreeIterNext(&iter); node; node = tRBTreeIterNext(&iter)) {
60,399,417✔
486
    STbData *pTbData = TCONTAINER_OF(node, STbData, rbtn);
57,783,951✔
487

488
    // scan time-series data
489
    STsdbRowKey from = {
57,783,899✔
490
        .key.ts = INT64_MIN,
491
        .key.numOfPKs = 0,
492
        .version = INT64_MIN,
493
    };
494
    for (;;) {
93,304,576✔
495
      int64_t     minKey, maxKey;
151,081,902✔
496
      STbDataIter tbDataIter = {0};
150,945,702✔
497
      TSDBROW    *row;
498
      int32_t     fid;
499

500
      tsdbTbDataIterOpen(pTbData, &from, 0, &tbDataIter);
150,960,273✔
501
      if ((row = tsdbTbDataIterGet(&tbDataIter)) == NULL) {
151,138,759✔
502
        break;
57,780,023✔
503
      }
504

505
      fid = tsdbKeyFid(TSDBROW_TS(row), tsdb->keepCfg.days, tsdb->keepCfg.precision);
93,358,736✔
506
      tsdbFidKeyRange(fid, tsdb->keepCfg.days, tsdb->keepCfg.precision, &minKey, &maxKey);
93,361,509✔
507

508
      SFileSetCommitInfo *info;
93,359,811✔
509
      SFileSetCommitInfo  tinfo = {
93,361,427✔
510
           .fid = fid,
511
      };
512
      int32_t ret = vHashGet(tsdb->commitInfo->ht, &tinfo, (void **)&info);
93,362,100✔
513
      if (info == NULL) {
93,188,944✔
514
        TAOS_CHECK_GOTO(tsdbCommitInfoAdd(tsdb, fid), &lino, _exit);
15,720,394✔
515
      }
516

517
      from.key.ts = maxKey + 1;
93,187,242✔
518
    }
519
  }
520

521
  (void)taosThreadMutexLock(&tsdb->mutex);
2,618,862✔
522

523
  // scan tomb data
524
  if (tsdb->imem->nDel > 0) {
2,618,862✔
525
    TARRAY2_FOREACH(tsdb->pFS->fSetArr, fset) {
2,003,780✔
526
      if (tsdbTFileSetIsEmpty(fset)) {
1,031,187✔
527
        continue;
×
528
      }
529

530
      SFileSetCommitInfo *info;
1,031,187✔
531
      SFileSetCommitInfo  tinfo = {
1,031,187✔
532
           .fid = fset->fid,
1,031,187✔
533
      };
534

535
      // check if the file set already on the commit list
536
      int32_t ret = vHashGet(tsdb->commitInfo->ht, &tinfo, (void **)&info);
1,031,187✔
537
      if (info != NULL) {
1,031,187✔
538
        continue;
912,585✔
539
      }
540

541
      int64_t minKey, maxKey;
118,602✔
542
      bool    hasDataToCommit = false;
118,602✔
543
      tsdbFidKeyRange(fset->fid, tsdb->keepCfg.days, tsdb->keepCfg.precision, &minKey, &maxKey);
118,602✔
544
      iter = tRBTreeIterCreate(tsdb->imem->tbDataTree, 1);
118,602✔
545
      for (SRBTreeNode *node = tRBTreeIterNext(&iter); node; node = tRBTreeIterNext(&iter)) {
217,862✔
546
        STbData *pTbData = TCONTAINER_OF(node, STbData, rbtn);
177,779✔
547
        for (SDelData *pDelData = pTbData->pHead; pDelData; pDelData = pDelData->pNext) {
237,145✔
548
          if (pDelData->sKey > maxKey || pDelData->eKey < minKey) {
137,885✔
549
            continue;
59,366✔
550
          } else {
551
            hasDataToCommit = true;
78,519✔
552
            if ((code = tsdbCommitInfoAdd(tsdb, fset->fid))) {
78,519✔
553
              (void)taosThreadMutexUnlock(&tsdb->mutex);
×
554
              TSDB_CHECK_CODE(code, lino, _exit);
×
555
            }
556
            break;
78,519✔
557
          }
558
        }
559

560
        if (hasDataToCommit) {
177,779✔
561
          break;
78,519✔
562
        }
563
      }
564
    }
565
  }
566

567
  // begin tasks on file set
568
  for (int i = 0; i < taosArrayGetSize(tsdb->commitInfo->arr); i++) {
18,418,026✔
569
    SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(tsdb->commitInfo->arr, i);
15,799,534✔
570
    tsdbBeginTaskOnFileSet(tsdb, info->fid, EVA_TASK_COMMIT, &fset);
15,799,534✔
571
    if (fset) {
15,799,349✔
572
      code = tsdbTFileSetInitCopy(tsdb, fset, &info->fset);
2,019,191✔
573
      if (code) {
2,019,191✔
574
        (void)taosThreadMutexUnlock(&tsdb->mutex);
×
UNCOV
575
        TAOS_CHECK_GOTO(code, &lino, _exit);
×
576
      }
577
    }
578
  }
579

580
  (void)taosThreadMutexUnlock(&tsdb->mutex);
2,618,862✔
581

582
_exit:
2,619,197✔
583
  if (code) {
2,618,862✔
584
    tsdbCommitInfoDestroy(tsdb);
×
585
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
586
  }
587
  return code;
2,618,862✔
588
}
589

590
static int32_t tsdbOpenCommitter(STsdb *tsdb, SCommitInfo *info, SCommitter2 *committer) {
2,618,862✔
591
  int32_t code = 0;
2,618,862✔
592
  int32_t lino = 0;
2,618,862✔
593

594
  committer->tsdb = tsdb;
2,618,862✔
595
  committer->minutes = tsdb->keepCfg.days;
2,618,862✔
596
  committer->precision = tsdb->keepCfg.precision;
2,618,862✔
597
  committer->minRow = info->info.config.tsdbCfg.minRows;
2,618,862✔
598
  committer->maxRow = info->info.config.tsdbCfg.maxRows;
2,618,862✔
599
  committer->cmprAlg = info->info.config.tsdbCfg.compression;
2,618,862✔
600
  committer->sttTrigger = info->info.config.sttTrigger;
2,618,862✔
601
  committer->szPage = info->info.config.tsdbPageSize;
2,618,862✔
602
  committer->compactVersion = INT64_MAX;
2,618,862✔
603
  committer->cid = tsdbFSAllocEid(tsdb->pFS);
2,618,862✔
604
  committer->now = taosGetTimestampSec();
2,618,862✔
605

606
  TAOS_CHECK_GOTO(tsdbCommitInfoBuild(tsdb), &lino, _exit);
2,618,677✔
607

608
_exit:
2,618,677✔
609
  if (code) {
2,618,677✔
610
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
611
  } else {
612
    tsdbDebug("vgId:%d %s done", TD_VID(tsdb->pVnode), __func__);
2,618,677✔
613
  }
614
  return code;
2,618,677✔
615
}
616

617
static int32_t tsdbCloseCommitter(SCommitter2 *committer, int32_t eno) {
2,618,677✔
618
  int32_t code = 0;
2,618,677✔
619
  int32_t lino = 0;
2,618,677✔
620

621
  if (eno == 0) {
2,618,677✔
622
    TAOS_CHECK_GOTO(tsdbFSEditBegin(committer->tsdb->pFS, committer->fopArray, TSDB_FEDIT_COMMIT), &lino, _exit);
2,618,677✔
623
  } else {
UNCOV
624
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(committer->tsdb->pVnode), __func__, __FILE__, lino,
×
625
              tstrerror(eno));
626
  }
627

628
  TARRAY2_DESTROY(committer->dataIterArray, NULL);
2,618,862✔
629
  TARRAY2_DESTROY(committer->tombIterArray, NULL);
2,618,862✔
630
  TARRAY2_DESTROY(committer->sttReaderArray, NULL);
2,618,862✔
631
  TARRAY2_DESTROY(committer->fopArray, NULL);
2,618,862✔
632
  TARRAY2_DESTROY(committer->sttReaderArray, NULL);
2,618,862✔
633

634
_exit:
2,618,862✔
635
  if (code) {
2,618,862✔
636
    tsdbError("vgId:%d %s failed at %s:%d since %s, eid:%" PRId64, TD_VID(committer->tsdb->pVnode), __func__, __FILE__,
×
637
              lino, tstrerror(code), committer->cid);
638
  } else {
639
    tsdbDebug("vgId:%d %s done, eid:%" PRId64, TD_VID(committer->tsdb->pVnode), __func__, committer->cid);
2,618,862✔
640
  }
641
  return code;
2,618,862✔
642
}
643

644
int32_t tsdbPreCommit(STsdb *tsdb) {
4,720,743✔
645
  (void)taosThreadMutexLock(&tsdb->mutex);
4,720,743✔
646
  ASSERT_CORE(tsdb->imem == NULL, "imem should be null to commit mem");
4,726,843✔
647
  tsdb->imem = tsdb->mem;
4,726,313✔
648
  tsdb->mem = NULL;
4,726,313✔
649
  (void)taosThreadMutexUnlock(&tsdb->mutex);
4,726,313✔
650
  return 0;
4,726,843✔
651
}
652

653
int32_t tsdbCommitBegin(STsdb *tsdb, SCommitInfo *info) {
4,726,843✔
654
  if (!tsdb) return 0;
4,726,843✔
655

656
  int32_t code = 0;
4,726,843✔
657
  int32_t lino = 0;
4,726,843✔
658

659
  SMemTable *imem = tsdb->imem;
4,726,843✔
660
  int64_t    nRow = imem->nRow;
4,726,843✔
661
  int64_t    nDel = imem->nDel;
4,726,843✔
662

663
  if ((nRow == 0 && nDel == 0) || (tsBypassFlag & TSDB_BYPASS_RB_TSDB_COMMIT)) {
4,726,843✔
664
    (void)taosThreadMutexLock(&tsdb->mutex);
2,107,981✔
665
    tsdb->imem = NULL;
2,107,981✔
666
    (void)taosThreadMutexUnlock(&tsdb->mutex);
2,107,981✔
667
    tsdbUnrefMemTable(imem, NULL, true);
2,107,981✔
668
  } else {
669
    SCommitter2 committer = {0};
2,618,862✔
670

671
    TAOS_CHECK_GOTO(tsdbOpenCommitter(tsdb, info, &committer), &lino, _exit);
2,618,862✔
672

673
    for (int32_t i = 0; i < taosArrayGetSize(tsdb->commitInfo->arr); i++) {
18,409,444✔
674
      committer.ctx->info = *(SFileSetCommitInfo **)taosArrayGet(tsdb->commitInfo->arr, i);
15,796,938✔
675
      TAOS_CHECK_GOTO(tsdbCommitFileSet(&committer), &lino, _exit);
15,796,729✔
676
    }
677

678
    TAOS_CHECK_GOTO(tsdbCloseCommitter(&committer, code), &lino, _exit);
2,618,677✔
679
  }
680

681
_exit:
4,726,357✔
682
  if (code) {
4,726,357✔
683
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
684
  } else {
685
    tsdbInfo("vgId:%d %s done, nRow:%" PRId64 " nDel:%" PRId64, TD_VID(tsdb->pVnode), __func__, nRow, nDel);
4,726,357✔
686
  }
687
  return code;
4,726,843✔
688
}
689

690
int32_t tsdbCommitCommit(STsdb *tsdb) {
4,726,843✔
691
  int32_t code = 0;
4,726,843✔
692
  int32_t lino = 0;
4,726,843✔
693

694
  if (tsdb->imem) {
4,726,843✔
695
    SMemTable *pMemTable = tsdb->imem;
2,618,862✔
696

697
    (void)taosThreadMutexLock(&tsdb->mutex);
2,618,862✔
698

699
    if ((code = tsdbFSEditCommit(tsdb->pFS))) {
2,618,862✔
700
      (void)taosThreadMutexUnlock(&tsdb->mutex);
×
701
      TSDB_CHECK_CODE(code, lino, _exit);
×
702
    }
703
    tsdb->imem = NULL;
2,618,862✔
704

705
    for (int32_t i = 0; i < taosArrayGetSize(tsdb->commitInfo->arr); i++) {
18,418,396✔
706
      SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(tsdb->commitInfo->arr, i);
15,799,534✔
707
      if (info->fset) {
15,799,534✔
708
        tsdbFinishTaskOnFileSet(tsdb, info->fid, EVA_TASK_COMMIT);
2,019,191✔
709
      }
710
    }
711

712
    (void)taosThreadMutexUnlock(&tsdb->mutex);
2,618,862✔
713

714
    tsdbCommitInfoDestroy(tsdb);
2,618,862✔
715
    tsdbUnrefMemTable(pMemTable, NULL, true);
2,618,862✔
716
  }
717

718
_exit:
2,107,981✔
719
  if (code) {
4,726,843✔
720
    tsdbError("vgId:%d %s failed at %s:%d since %s", TD_VID(tsdb->pVnode), __func__, __FILE__, lino, tstrerror(code));
×
721
  } else {
722
    tsdbInfo("vgId:%d %s done", TD_VID(tsdb->pVnode), __func__);
4,726,843✔
723
  }
724
  return code;
4,726,843✔
725
}
726

727
int32_t tsdbCommitAbort(STsdb *pTsdb) {
×
728
  int32_t code = 0;
×
729
  int32_t lino = 0;
×
730

731
  if (pTsdb->imem == NULL) goto _exit;
×
732

733
  TAOS_CHECK_GOTO(tsdbFSEditAbort(pTsdb->pFS), &lino, _exit);
×
734

735
  (void)taosThreadMutexLock(&pTsdb->mutex);
×
736
  for (int32_t i = 0; i < taosArrayGetSize(pTsdb->commitInfo->arr); i++) {
×
737
    SFileSetCommitInfo *info = *(SFileSetCommitInfo **)taosArrayGet(pTsdb->commitInfo->arr, i);
×
738
    if (info->fset) {
×
739
      tsdbFinishTaskOnFileSet(pTsdb, info->fid, EVA_TASK_COMMIT);
×
740
    }
741
  }
742
  (void)taosThreadMutexUnlock(&pTsdb->mutex);
×
743
  tsdbCommitInfoDestroy(pTsdb);
×
744

745
_exit:
×
746
  if (code) {
×
747
    tsdbError("vgId:%d, %s failed at line %d since %s", TD_VID(pTsdb->pVnode), __func__, lino, tstrerror(code));
×
748
  } else {
749
    tsdbInfo("vgId:%d %s done", TD_VID(pTsdb->pVnode), __func__);
×
750
  }
751
  return code;
×
752
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc