20660774589

Committed 02 Jan 2026 03:17PM UTC coverage: 88.816% (+0.8%) from 88.049%

Build # 20660774589

Build Type

push

github

Committed by

tito10047

Commit Message

add transparent HTML caching: implement caching for rendered image components, update services, configuration, tests, and documentation

Run Details

39 of 40 new or added lines in 4 files covered. (97.5%)

63 existing lines in 6 files now uncovered.

540 of 608 relevant lines covered (88.82%)

160.76 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

52.38

/src/Controller/LiipImagineController.php

<?php

declare(strict_types=1);

namespace Tito10047\ProgressiveImageBundle\Controller;

use Tito10047\ProgressiveImageBundle\Service\LiipImagineRuntimeConfigGenerator;
use Liip\ImagineBundle\Config\Controller\ControllerConfig;
use Liip\ImagineBundle\Exception\Binary\Loader\NotLoadableException;
use Liip\ImagineBundle\Exception\Imagine\Filter\NonExistingFilterException;
use Liip\ImagineBundle\Imagine\Cache\Helper\PathHelper;
use Liip\ImagineBundle\Imagine\Data\DataManager;
use Liip\ImagineBundle\Imagine\Filter\FilterConfiguration;
use Liip\ImagineBundle\Service\FilterService;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\UriSigner;
use Symfony\Component\HttpKernel\Attribute\MapQueryParameter;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class LiipImagineController
{
        public function __construct(
                private readonly UriSigner  $signer,
                private readonly FilterService $filterService,
                private readonly DataManager $dataManager,
                private readonly FilterConfiguration $filterConfiguration,
                private readonly ControllerConfig $controllerConfig,
                private readonly LiipImagineRuntimeConfigGenerator $runtimeConfigGenerator,
        ) {
        }

        public function index(
                Request $request,
                #[MapQueryParameter] string $path,
                #[MapQueryParameter] int $width,
                #[MapQueryParameter] int $height,
                #[MapQueryParameter] ?string $filter = null,
        ): Response {
                $path = PathHelper::urlPathToFilePath($path);

                $result = $this->runtimeConfigGenerator->generate($width, $height, $filter);
                $filterName = $result['filterName'];
                $config = $result['config'];

                $this->filterConfiguration->set($filterName, $config);

                if (true !== $this->signer->checkRequest($request)) {
                        throw new BadRequestHttpException(\sprintf('Signed url does not pass the sign check for path "%s" and filter "%s"', $path, $filter));
                }

                return $this->createRedirectResponse(function () use ($path, $filterName, $request) {
                        return $this->filterService->getUrlOfFilteredImage($path, $filterName);
                }, $path, $filterName);
        }

        private function createRedirectResponse(\Closure $url, string $path, string $filter): RedirectResponse
        {
                try {
                        return new RedirectResponse($url(), $this->controllerConfig->getRedirectResponseCode());
                } catch (NotLoadableException $exception) {
                        if (null !== $this->dataManager->getDefaultImageUrl($filter)) {
                                return new RedirectResponse($this->dataManager->getDefaultImageUrl($filter));
                        }

                        throw new NotFoundHttpException(\sprintf('Source image for path "%s" could not be found', $path), $exception);
                } catch (NonExistingFilterException $exception) {
                        throw new NotFoundHttpException(\sprintf('Requested non-existing filter "%s"', $filter), $exception);
                } catch (\RuntimeException $exception) {
                        throw new \RuntimeException(\sprintf('Unable to create image for path "%s" and filter "%s". Message was "%s"', $path, $filter, $exception->getMessage()), 0, $exception);
                }
        }

        private function isWebpSupported(Request $request): bool
        {
                return false !== mb_stripos($request->headers->get('accept', ''), 'image/webp');
        }
}

1	<?php
2
3	declare(strict_types=1);
4
5	namespace Tito10047\ProgressiveImageBundle\Controller;
6
7	use Tito10047\ProgressiveImageBundle\Service\LiipImagineRuntimeConfigGenerator;
8	use Liip\ImagineBundle\Config\Controller\ControllerConfig;
9	use Liip\ImagineBundle\Exception\Binary\Loader\NotLoadableException;
10	use Liip\ImagineBundle\Exception\Imagine\Filter\NonExistingFilterException;
11	use Liip\ImagineBundle\Imagine\Cache\Helper\PathHelper;
12	use Liip\ImagineBundle\Imagine\Data\DataManager;
13	use Liip\ImagineBundle\Imagine\Filter\FilterConfiguration;
14	use Liip\ImagineBundle\Service\FilterService;
15	use Symfony\Component\HttpFoundation\RedirectResponse;
16	use Symfony\Component\HttpFoundation\Request;
17	use Symfony\Component\HttpFoundation\Response;
18	use Symfony\Component\HttpFoundation\UriSigner;
19	use Symfony\Component\HttpKernel\Attribute\MapQueryParameter;
20	use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
21	use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
22
23	class LiipImagineController
24	{
25	public function __construct(
26	private readonly UriSigner $signer,
27	private readonly FilterService $filterService,
28	private readonly DataManager $dataManager,
29	private readonly FilterConfiguration $filterConfiguration,
30	private readonly ControllerConfig $controllerConfig,
31	private readonly LiipImagineRuntimeConfigGenerator $runtimeConfigGenerator,
32	) {
UNCOV 33	}	56✔
34
35	public function index(
36	Request $request,
37	#[MapQueryParameter] string $path,
38	#[MapQueryParameter] int $width,
39	#[MapQueryParameter] int $height,
40	#[MapQueryParameter] ?string $filter = null,
41	): Response {
UNCOV 42	$path = PathHelper::urlPathToFilePath($path);	56✔
43
UNCOV 44	$result = $this->runtimeConfigGenerator->generate($width, $height, $filter);	56✔
UNCOV 45	$filterName = $result['filterName'];	56✔
UNCOV 46	$config = $result['config'];	56✔
47
UNCOV 48	$this->filterConfiguration->set($filterName, $config);	56✔
49
UNCOV 50	if (true !== $this->signer->checkRequest($request)) {	56✔
51	throw new BadRequestHttpException(\sprintf('Signed url does not pass the sign check for path "%s" and filter "%s"', $path, $filter));	×
52	}
53
UNCOV 54	return $this->createRedirectResponse(function () use ($path, $filterName, $request) {	56✔
UNCOV 55	return $this->filterService->getUrlOfFilteredImage($path, $filterName);	56✔
UNCOV 56	}, $path, $filterName);	56✔
57	}
58
59	private function createRedirectResponse(\Closure $url, string $path, string $filter): RedirectResponse
60	{
61	try {
UNCOV 62	return new RedirectResponse($url(), $this->controllerConfig->getRedirectResponseCode());	56✔
63	} catch (NotLoadableException $exception) {	×
64	if (null !== $this->dataManager->getDefaultImageUrl($filter)) {	×
65	return new RedirectResponse($this->dataManager->getDefaultImageUrl($filter));	×
66	}
67
68	throw new NotFoundHttpException(\sprintf('Source image for path "%s" could not be found', $path), $exception);	×
69	} catch (NonExistingFilterException $exception) {	×
70	throw new NotFoundHttpException(\sprintf('Requested non-existing filter "%s"', $filter), $exception);	×
71	} catch (\RuntimeException $exception) {	×
72	throw new \RuntimeException(\sprintf('Unable to create image for path "%s" and filter "%s". Message was "%s"', $path, $filter, $exception->getMessage()), 0, $exception);	×
73	}
74	}
75
76	private function isWebpSupported(Request $request): bool
77	{
78	return false !== mb_stripos($request->headers->get('accept', ''), 'image/webp');	×
79	}
80	}

tito10047 / progressive-image-bundle / 20660774589

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous