• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Return-To-The-Roots / s25client / 20623493911

31 Dec 2025 05:01PM UTC coverage: 50.552% (-0.03%) from 50.58%
20623493911

Pull #1804

github

web-flow
Merge bd724d1d7 into d98c92f3b
Pull Request #1804: Android build

65 of 226 new or added lines in 13 files covered. (28.76%)

5 existing lines in 4 files now uncovered.

22608 of 44722 relevant lines covered (50.55%)

35795.36 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

96.97
/libs/s25main/mapGenerator/Rivers.cpp
1
// Copyright (C) 2005 - 2021 Settlers Freaks (sf-team at siedler25.org)
2
//
3
// SPDX-License-Identifier: GPL-2.0-or-later
4

5
#include "mapGenerator/Rivers.h"
6
#include "mapGenerator/Terrain.h"
7
#include "mapGenerator/TextureHelper.h"
8

9
namespace rttr::mapGenerator {
10

11
River CreateStream(RandomUtility& rnd, Map& map, const MapPoint& source, Direction direction, unsigned length,
35✔
12
                   unsigned splitRate)
13
{
14
    const MapExtent& size = map.size;
35✔
15

16
    River river;
35✔
17
    std::vector<Direction> exlcuded{direction + 2, direction + 3, direction + 4};
70✔
18

19
    auto& textures = map.textureMap;
35✔
20
    const auto water = textures.Find(IsWater);
35✔
21

22
    MapPoint currentNode = source;
35✔
23
    Direction currentDir = direction;
35✔
24

25
    for(unsigned node = 0; node < length; ++node)
408✔
26
    {
27
        const auto& triangles = GetTriangles(currentNode, size, currentDir);
384✔
28

29
        for(const auto& triangle : triangles)
1,152✔
30
        {
31
            textures.Set(triangle, water);
768✔
32

33
            const auto& edges = GetTriangleEdges(triangle, size);
768✔
34
            for(const MapPoint& edge : edges)
3,072✔
35
            {
36
                river.insert(edge);
2,304✔
37
            }
38
        }
39

40
        if(map.z[currentNode] == map.height.minimum)
384✔
41
        {
42
            return river;
11✔
43
        }
44

45
        const auto lastDir = currentDir;
373✔
46

47
        while(currentDir == lastDir || helpers::contains(exlcuded, currentDir))
959✔
48
        {
49
            currentDir = lastDir + (rnd.ByChance(50) ? 5 : 1);
586✔
50
        }
51

52
        currentNode = map.getTextures().GetNeighbour(currentNode, lastDir);
373✔
53

54
        if(rnd.ByChance(splitRate))
373✔
55
        {
56
            auto splitDirection = direction + (rnd.ByChance(50) ? 5 : 1);
4✔
57
            auto anotherRivers = CreateStream(rnd, map, currentNode, splitDirection, length / 2, splitRate / 2);
8✔
58

59
            for(const MapPoint& node : anotherRivers)
102✔
60
            {
61
                river.insert(node);
98✔
62
            }
63
        }
64
    }
65

66
    auto seaLevel = static_cast<unsigned>(map.height.minimum);
24✔
67
    auto& z = map.z;
24✔
68

69
    for(const MapPoint& node : river)
384✔
70
    {
71
        if(z[node] > 0)
360✔
72
        {
73
            z[node] = std::max(static_cast<unsigned>(z[node] - 1), seaLevel);
360✔
74
        } else
75
        {
UNCOV
76
            z[node] = seaLevel;
×
77
        }
78
    }
79

80
    return river;
24✔
81
}
82

83
} // namespace rttr::mapGenerator
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc