wirenboard / wb-mqtt-serial / 2

Committed 29 Dec 2025 12:28PM UTC coverage: 76.817% (+4.0%) from 72.836%

Build # 2

Build Type

Pull #1045

github

Specific Base 54aa0c

Committed by

pgasheev

Commit Message

up changelog

Pull Request Pull Request #1045: Fix firmware version in WB-M1W2 template

Run Details

6873 of 9161 branches covered (75.02%)

12966 of 16879 relevant lines covered (76.82%)

1651.61 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

97.35

/test/modbus_ext_common_test.cpp

#include "crc16.h"
#include "modbus_ext_common.h"
#include "serial_exc.h"
#include "gtest/gtest.h"

#include <cmath>
#include <list>

namespace
{
    void SetCrc(std::vector<uint8_t>& data)
    {
        if (data.size() < 2) {
            return;
        }
        auto crc = CRC16::CalculateCRC16(data.data(), data.size() - 2);
        data[data.size() - 1] = crc & 0xFF;
        data[data.size() - 2] = (crc >> 8) & 0xFF;
    }

    class TPortMock: public TPort
    {
    public:
        std::vector<std::vector<uint8_t>> Requests;
        std::list<std::vector<uint8_t>> Responses;
        bool ThrowTimeout = false;

        TPortMock()
        {}

        void Open() override
        {}
        void Close() override
        {}
        bool IsOpen() const override
        {
            return false;
        }
        void CheckPortOpen() const override
        {}

        void WriteBytes(const uint8_t* buf, int count) override
        {
            std::vector<uint8_t> data(buf, buf + count);
            Requests.emplace_back(std::move(data));
        }

        uint8_t ReadByte(const std::chrono::microseconds& timeout) override
        {
            return 0;
        }

        TReadFrameResult ReadFrame(uint8_t* buf,
                                   size_t count,
                                   const std::chrono::microseconds& responseTimeout,
                                   const std::chrono::microseconds& frameTimeout,
                                   TFrameCompletePred frame_complete = 0) override
        {
            if (ThrowTimeout) {
                throw TResponseTimeoutException();
            }
            if (Responses.empty()) {
                throw TResponseTimeoutException();
            }
            if (Responses.front().size() > count) {
                throw std::runtime_error("Buffer is too small");
            }
            TReadFrameResult res;
            res.Count = Responses.front().size();
            memcpy(buf, Responses.front().data(), Responses.front().size());
            Responses.pop_front();
            return res;
        }

        void SkipNoise() override
        {}

        void SleepSinceLastInteraction(const std::chrono::microseconds& us) override
        {}

        std::string GetDescription(bool verbose) const override
        {
            return std::string();
        }

        std::chrono::microseconds GetSendTimeBytes(double bytesNumber) const override
        {
            // 8-N-2
            auto bits = std::ceil(11 * bytesNumber);
            return GetSendTimeBits(bits);
        }

        std::chrono::microseconds GetSendTimeBits(size_t bitsNumber) const override
        {
            // 115200 bps
            auto us = std::ceil((1000000.0 * bitsNumber) / 115200.0);
            return std::chrono::microseconds(static_cast<std::chrono::microseconds::rep>(us));
        }

        void AddResponse(const std::vector<uint8_t>& data)
        {
            Responses.push_back(data);
            if (Responses.back().size() >= 2 && Responses.back()[Responses.back().size() - 2] == 0 &&
                Responses.back()[Responses.back().size() - 1] == 0)
            {
                SetCrc(Responses.back());
            }
        }
    };

    class TTestEventsVisitor: public ModbusExt::IEventsVisitor
    {
    public:
        std::unordered_map<uint16_t, uint16_t> Events;
        bool Reboot = false;

        virtual void Event(uint8_t slaveId,
                           uint8_t eventType,
                           uint16_t eventId,
                           const uint8_t* data,
                           size_t dataSize) override
        {
            if (eventType == ModbusExt::TEventType::REBOOT) {
                Reboot = true;
                return;
            }
            Events[eventId] = data[0] | (data[1] << 8);
        }
    };

} // namespace

TEST(TModbusExtTest, EventsEnablerOneReg)
{
    TPortMock port;
    port.AddResponse({0x0A, 0x46, 0x18, 0x01, 0x01, 0xE9, 0x1E});

    std::map<uint16_t, bool> response;
    Modbus::TModbusRTUTraits traits;
    ModbusExt::TEventsEnabler ev(10, port, traits, [&response](uint8_t type, uint16_t reg, bool enabled) {
        response[reg] = enabled;
    });
    ev.AddRegister(101, ModbusExt::TEventType::COIL, ModbusExt::TEventPriority::HIGH);

    EXPECT_NO_THROW(ev.SendRequests());

    EXPECT_EQ(port.Requests.size(), 1);

    auto request = port.Requests.front();

    EXPECT_EQ(request.size(), 11);
    EXPECT_EQ(request[0], 0x0A); // slave id
    EXPECT_EQ(request[1], 0x46); // command
    EXPECT_EQ(request[2], 0x18); // subcommand
    EXPECT_EQ(request[3], 0x05); // settings size

    EXPECT_EQ(request[4], 0x01); // event type
    EXPECT_EQ(request[5], 0x00); // address MSB
    EXPECT_EQ(request[6], 0x65); // address LSB
    EXPECT_EQ(request[7], 0x01); // count
    EXPECT_EQ(request[8], 0x02); // priority

    EXPECT_EQ(request[9], 0xC5);  // CRC16 LSB
    EXPECT_EQ(request[10], 0x90); // CRC16 MSB

    EXPECT_EQ(response.size(), 1);
    EXPECT_TRUE(response[101]);
}

TEST(TModbusExtTest, EventsEnablerIllegalFunction)
{
    TPortMock port;
    port.AddResponse({0x0A, 0xC6, 0x01, 0xC3, 0xA2});

    Modbus::TModbusRTUTraits traits;
    ModbusExt::TEventsEnabler ev(10, port, traits, [](uint8_t, uint16_t, bool) {});
    ev.AddRegister(101, ModbusExt::TEventType::COIL, ModbusExt::TEventPriority::HIGH);

    EXPECT_THROW(ev.SendRequests(), Modbus::TModbusExceptionError);
}

TEST(TModbusExtTest, EventsEnablerTwoRanges)
{
    TPortMock port;
    // 0x03 = 0b00000011
    // 0xFB = 0b11111011
    // 0x02 = 0b00000010
    port.AddResponse({0x0A, 0x46, 0x18, 0x03, 0x03, 0xFB, 0x02, 0xAD, 0x11});

    std::map<uint16_t, bool> response;
    Modbus::TModbusRTUTraits traits;
    ModbusExt::TEventsEnabler ev(10, port, traits, [&response](uint8_t type, uint16_t reg, bool enabled) {
        response[reg] = enabled;
    });

    ev.AddRegister(101, ModbusExt::TEventType::COIL, ModbusExt::TEventPriority::HIGH);
    ev.AddRegister(102, ModbusExt::TEventType::COIL, ModbusExt::TEventPriority::HIGH);

    ev.AddRegister(103, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(104, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(105, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(106, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(107, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(108, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(109, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(110, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::HIGH);
    ev.AddRegister(111, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::HIGH);
    ev.AddRegister(112, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::HIGH);

    EXPECT_NO_THROW(ev.SendRequests());

    EXPECT_EQ(port.Requests.size(), 1);

    auto request = port.Requests.front();

    EXPECT_EQ(request.size(), 26);
    EXPECT_EQ(request[0], 0x0A); // slave id
    EXPECT_EQ(request[1], 0x46); // command
    EXPECT_EQ(request[2], 0x18); // subcommand
    EXPECT_EQ(request[3], 0x14); // settings size

    EXPECT_EQ(request[4], 0x01); // event type
    EXPECT_EQ(request[5], 0x00); // address MSB
    EXPECT_EQ(request[6], 0x65); // address LSB
    EXPECT_EQ(request[7], 0x02); // count
    EXPECT_EQ(request[8], 0x02); // priority 101
    EXPECT_EQ(request[9], 0x02); // priority 102

    EXPECT_EQ(request[10], 0x04); // event type
    EXPECT_EQ(request[11], 0x00); // address MSB
    EXPECT_EQ(request[12], 0x67); // address LSB
    EXPECT_EQ(request[13], 0x0A); // count
    EXPECT_EQ(request[14], 0x01); // priority 103
    EXPECT_EQ(request[15], 0x01); // priority 104
    EXPECT_EQ(request[16], 0x01); // priority 105
    EXPECT_EQ(request[17], 0x01); // priority 106
    EXPECT_EQ(request[18], 0x01); // priority 107
    EXPECT_EQ(request[19], 0x01); // priority 108
    EXPECT_EQ(request[20], 0x01); // priority 109
    EXPECT_EQ(request[21], 0x02); // priority 110
    EXPECT_EQ(request[22], 0x02); // priority 111
    EXPECT_EQ(request[23], 0x02); // priority 112

    EXPECT_EQ(request[24], 0x25); // CRC16 LSB
    EXPECT_EQ(request[25], 0xF0); // CRC16 MSB

    EXPECT_EQ(response.size(), 12);
    EXPECT_TRUE(response[101]);
    EXPECT_TRUE(response[102]);
    EXPECT_TRUE(response[103]);
    EXPECT_TRUE(response[104]);
    EXPECT_FALSE(response[105]);
    EXPECT_TRUE(response[106]);
    EXPECT_TRUE(response[107]);
    EXPECT_TRUE(response[108]);
    EXPECT_TRUE(response[109]);
    EXPECT_TRUE(response[110]);
    EXPECT_FALSE(response[111]);
    EXPECT_TRUE(response[112]);
}

TEST(TModbusExtTest, EventsEnablerRangesWithHoles)
{
    TPortMock port;
    // 0x03 = 0b00000011
    // 0xF3 = 0b11110011
    // 0x02 = 0b00000010
    // 0x03 = 0b00000011
    port.AddResponse({0x0A, 0x46, 0x18, 0x04, 0x03, 0xF3, 0x02, 0x03, 0xA4, 0xBE});

    std::map<uint16_t, bool> response;
    Modbus::TModbusRTUTraits traits;
    ModbusExt::TEventsEnabler ev(
        10,
        port,
        traits,
        [&response](uint8_t type, uint16_t reg, bool enabled) { response[reg] = enabled; },
        ModbusExt::TEventsEnabler::DISABLE_EVENTS_IN_HOLES);

    ev.AddRegister(101, ModbusExt::TEventType::COIL, ModbusExt::TEventPriority::HIGH);
    ev.AddRegister(102, ModbusExt::TEventType::COIL, ModbusExt::TEventPriority::HIGH);
    ev.AddRegister(103, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(104, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(107, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(108, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(109, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::LOW);
    ev.AddRegister(110, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::HIGH);
    ev.AddRegister(111, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::HIGH);
    ev.AddRegister(112, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::HIGH);
    ev.AddRegister(118, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::HIGH);
    ev.AddRegister(119, ModbusExt::TEventType::INPUT, ModbusExt::TEventPriority::HIGH);

    EXPECT_NO_THROW(ev.SendRequests());

    EXPECT_EQ(port.Requests.size(), 1);

    auto request = port.Requests.front();

    EXPECT_EQ(request.size(), 32);
    EXPECT_EQ(request[0], 0x0A); // slave id
    EXPECT_EQ(request[1], 0x46); // command
    EXPECT_EQ(request[2], 0x18); // subcommand
    EXPECT_EQ(request[3], 0x1A); // settings size

    EXPECT_EQ(request[4], 0x01); // event type
    EXPECT_EQ(request[5], 0x00); // address MSB
    EXPECT_EQ(request[6], 0x65); // address LSB
    EXPECT_EQ(request[7], 0x02); // count
    EXPECT_EQ(request[8], 0x02); // priority 101
    EXPECT_EQ(request[9], 0x02); // priority 102

    EXPECT_EQ(request[10], 0x04); // event type
    EXPECT_EQ(request[11], 0x00); // address MSB
    EXPECT_EQ(request[12], 0x67); // address LSB
    EXPECT_EQ(request[13], 0x0A); // count
    EXPECT_EQ(request[14], 0x01); // priority 103
    EXPECT_EQ(request[15], 0x01); // priority 104
    EXPECT_EQ(request[16], 0x00); // priority 105
    EXPECT_EQ(request[17], 0x00); // priority 106
    EXPECT_EQ(request[18], 0x01); // priority 107
    EXPECT_EQ(request[19], 0x01); // priority 108
    EXPECT_EQ(request[20], 0x01); // priority 109
    EXPECT_EQ(request[21], 0x02); // priority 110
    EXPECT_EQ(request[22], 0x02); // priority 111
    EXPECT_EQ(request[23], 0x02); // priority 112

    EXPECT_EQ(request[24], 0x04); // event type
    EXPECT_EQ(request[25], 0x00); // address MSB
    EXPECT_EQ(request[26], 0x76); // address LSB
    EXPECT_EQ(request[27], 0x02); // count
    EXPECT_EQ(request[28], 0x02); // priority 118
    EXPECT_EQ(request[29], 0x02); // priority 119

    EXPECT_EQ(request[30], 0x81); // CRC16 LSB
    EXPECT_EQ(request[31], 0x54); // CRC16 MSB

    EXPECT_EQ(response.size(), 14);
    EXPECT_TRUE(response[101]);
    EXPECT_TRUE(response[102]);
    EXPECT_TRUE(response[103]);
    EXPECT_TRUE(response[104]);
    EXPECT_FALSE(response[105]);
    EXPECT_FALSE(response[106]);
    EXPECT_TRUE(response[107]);
    EXPECT_TRUE(response[108]);
    EXPECT_TRUE(response[109]);
    EXPECT_TRUE(response[110]);
    EXPECT_FALSE(response[111]);
    EXPECT_TRUE(response[112]);
    EXPECT_EQ(response.count(113), 0);
    EXPECT_EQ(response.count(114), 0);
    EXPECT_EQ(response.count(115), 0);
    EXPECT_EQ(response.count(116), 0);
    EXPECT_EQ(response.count(117), 0);
    EXPECT_TRUE(response[118]);
    EXPECT_TRUE(response[119]);
}

TEST(TModbusExtTest, ReadEventsNoEventsNoConfirmation)
{
    TPortMock port;
    TTestEventsVisitor visitor;
    ModbusExt::TEventConfirmationState state;
    ModbusExt::TModbusRTUWithArbitrationTraits traits;

    port.AddResponse({0xFF, 0xFF, 0xFF, 0xFD, 0x46, 0x12, 0x52, 0x5D}); // No events
    bool ret = true;
    EXPECT_NO_THROW(ret = ModbusExt::ReadEvents(port, traits, std::chrono::milliseconds(100), 0, state, visitor));
    EXPECT_FALSE(ret);

    EXPECT_EQ(port.Requests.size(), 1);
    auto request = port.Requests.front();

    EXPECT_EQ(request.size(), 9);
    EXPECT_EQ(request[0], 0xFD); // broadcast
    EXPECT_EQ(request[1], 0x46); // command
    EXPECT_EQ(request[2], 0x10); // subcommand
    EXPECT_EQ(request[3], 0x00); // min slave id
    EXPECT_EQ(request[4], 0xF8); // max length
    EXPECT_EQ(request[5], 0x00); // slave id (confirmation)
    EXPECT_EQ(request[6], 0x00); // flag (confirmation)

    EXPECT_EQ(request[7], 0x79); // CRC16 LSB
    EXPECT_EQ(request[8], 0x5B); // CRC16 MSB

    EXPECT_EQ(visitor.Events.size(), 0);
}

TEST(TModbusExtTest, ReadEventsWithConfirmation)
{
    TPortMock port;
    TTestEventsVisitor visitor;
    ModbusExt::TEventConfirmationState state;
    ModbusExt::TModbusRTUWithArbitrationTraits traits;

    port.AddResponse(
        {0xFF, 0xFF, 0xFF, 0x05, 0x46, 0x11, 0x01, 0x01, 0x06, 0x02, 0x04, 0x01, 0xD0, 0x04, 0x00, 0x2B, 0xAC});
    bool ret = false;
    EXPECT_NO_THROW(ret = ModbusExt::ReadEvents(port, traits, std::chrono::milliseconds(100), 0, state, visitor));
    EXPECT_TRUE(ret);

    EXPECT_EQ(port.Requests.size(), 1);
    auto request = port.Requests.front();

    EXPECT_EQ(request.size(), 9);
    EXPECT_EQ(request[0], 0xFD); // slave id
    EXPECT_EQ(request[1], 0x46); // command
    EXPECT_EQ(request[2], 0x10); // subcommand
    EXPECT_EQ(request[3], 0x00); // min slave id
    EXPECT_EQ(request[4], 0xF8); // max length
    EXPECT_EQ(request[5], 0x00); // slave id (confirmation)
    EXPECT_EQ(request[6], 0x00); // flag (confirmation)

    EXPECT_EQ(request[7], 0x79); // CRC16 LSB
    EXPECT_EQ(request[8], 0x5B); // CRC16 MSB

    EXPECT_EQ(visitor.Events.size(), 1);
    EXPECT_EQ(visitor.Events[464], 4);

    port.AddResponse({0xFF, 0xFF, 0xFF, 0xFD, 0x46, 0x12, 0x52, 0x5D}); // No events
    visitor.Events.clear();
    port.Requests.clear();
    EXPECT_NO_THROW(ret = ModbusExt::ReadEvents(port, traits, std::chrono::milliseconds(5), 5, state, visitor));
    EXPECT_FALSE(ret);

    EXPECT_EQ(port.Requests.size(), 1);
    request = port.Requests.front();

    EXPECT_EQ(request.size(), 9);
    EXPECT_EQ(request[0], 0xFD); // slave id
    EXPECT_EQ(request[1], 0x46); // command
    EXPECT_EQ(request[2], 0x10); // subcommand
    EXPECT_EQ(request[3], 0x05); // min slave id
    EXPECT_EQ(request[4], 0x2C); // max length
    EXPECT_EQ(request[5], 0x05); // slave id (confirmation)
    EXPECT_EQ(request[6], 0x01); // flag (confirmation)

    EXPECT_EQ(request[7], 0xFB); // CRC16 LSB
    EXPECT_EQ(request[8], 0x3F); // CRC16 MSB

    EXPECT_EQ(visitor.Events.size(), 0);
}

TEST(TModbusExtTest, ReadEventsReboot)
{
    TPortMock port;
    TTestEventsVisitor visitor;
    ModbusExt::TEventConfirmationState state;
    ModbusExt::TModbusRTUWithArbitrationTraits traits;

    port.AddResponse(
        {0xFF, 0xFF, 0xFF, 0xFD, 0x46, 0x11, 0x00, 0x00, 0x04, 0x00, 0x0F, 0x00, 0x00, 0xFF, 0x5E}); // Reboot event
    bool ret = false;
    EXPECT_NO_THROW(ret = ModbusExt::ReadEvents(port, traits, std::chrono::milliseconds(100), 0, state, visitor));
    EXPECT_TRUE(ret);

    EXPECT_TRUE(visitor.Reboot);
}

TEST(TModbusExtTest, GetRTUPacketStart)
{
    uint8_t goodPacket[] = {0xFF, 0xFF, 0xFF, 0xFD, 0x46, 0x11, 0x00, 0x00, 0x04, 0x00, 0x0F, 0x00, 0x00, 0xFF, 0x5E};
    uint8_t goodPacketWithGlitch[] = {0xFF, 0xFF, 0xFE, 0xFF, 0xFF, 0xFD, 0x46, 0x12, 0x52, 0x5D};
    EXPECT_EQ(ModbusExt::GetRTUPacketStart(goodPacket, sizeof(goodPacket)), goodPacket + 3);
    EXPECT_EQ(ModbusExt::GetRTUPacketStart(goodPacketWithGlitch, sizeof(goodPacketWithGlitch)),
              goodPacketWithGlitch + 5);

    uint8_t notEnoughDataPacket[] = {0xFF, 0xFF, 0xFF, 0xFD, 0x46, 0x11, 0x00, 0x00, 0x04, 0x00, 0x0F, 0x00};
    uint8_t badCrcPacket[] = {0xFF, 0xFF, 0xFF, 0xFD, 0x46, 0x11, 0x00, 0x00, 0x04, 0x00, 0x0F, 0x00, 0x00, 0x11, 0x5E};
    EXPECT_EQ(ModbusExt::GetRTUPacketStart(notEnoughDataPacket, sizeof(notEnoughDataPacket)), nullptr);
    EXPECT_EQ(ModbusExt::GetRTUPacketStart(badCrcPacket, sizeof(badCrcPacket)), nullptr);
}

class TModbusExtTraitsTest: public testing::Test
{
public:
    void TestEqual(const std::vector<uint8_t>& b1, const std::vector<uint8_t>& b2) const
    {
        ASSERT_EQ(b1.size(), b2.size());

        for (size_t i = 0; i < b1.size(); ++i) {
            ASSERT_EQ(b1[i], b2[i]) << i;
        }
    }
};

TEST_F(TModbusExtTraitsTest, ReadFrameGood)
{
    TPortMock port;
    port.AddResponse({0xfd, 0x46, 0x09, 0xfe, 0xca, 0xe7, 0xe5, 0x06, 0x00, 0x80, 0x00, 0x02, 0x1c, 0xef});
    ModbusExt::TModbusTraits traits(std::make_unique<Modbus::TModbusRTUTraits>());
    traits.SetSn(0xfecae7e5);
    std::chrono::milliseconds t(10);

    std::vector<uint8_t> req = {0x06, 0x00, 0x80, 0x00, 0x02};

    auto resp = traits.Transaction(port, 0xfd, req, req.size(), t, t);
    ASSERT_EQ(resp.Pdu.size(), req.size());

    TestEqual(resp.Pdu, req);
}

TEST_F(TModbusExtTraitsTest, ReadFrameTooSmallError)
{
    TPortMock port;
    port.AddResponse({0xfd, 0x46, 0x09, 0xfe, 0xca});
    ModbusExt::TModbusTraits traits(std::make_unique<Modbus::TModbusRTUTraits>());
    traits.SetSn(0xfecae7e5);
    std::chrono::milliseconds t(10);

    std::vector<uint8_t> req = {0x06, 0x00, 0x80, 0x00, 0x02};

    ASSERT_THROW(traits.Transaction(port, 0xfd, req, req.size(), t, t), Modbus::TMalformedResponseError);
}

TEST_F(TModbusExtTraitsTest, ReadFrameInvalidCrc)
{
    TPortMock port;
    port.AddResponse({0xfd, 0x46, 0x09, 0xfe, 0xca, 0xe7, 0xe5, 0x06, 0x00, 0x80, 0x00, 0x02, 0x10, 0xef});
    ModbusExt::TModbusTraits traits(std::make_unique<Modbus::TModbusRTUTraits>());
    traits.SetSn(0xfecae7e5);
    std::chrono::milliseconds t(10);

    std::vector<uint8_t> req = {0x06, 0x00, 0x80, 0x00, 0x02};

    ASSERT_THROW(traits.Transaction(port, 0, req, req.size(), t, t), Modbus::TMalformedResponseError);
}

TEST_F(TModbusExtTraitsTest, ReadFrameInvalidHeader)
{
    TPortMock port;
    std::vector<uint8_t> badHeader =
        {0xfe, 0x46, 0x09, 0xfe, 0xca, 0xe7, 0xe5, 0x06, 0x00, 0x80, 0x00, 0x02, 0x00, 0x00};
    port.AddResponse(badHeader);

    ModbusExt::TModbusTraits traits(std::make_unique<Modbus::TModbusRTUTraits>());
    traits.SetSn(0xfecae7e5);
    std::chrono::milliseconds t(10);

    std::vector<uint8_t> req = {0x06, 0x00, 0x80, 0x00, 0x02};

    ASSERT_THROW(
        {
            try {
                traits.Transaction(port, 0, req, req.size(), t, t);
            } catch (const Modbus::TUnexpectedResponseError& e) {
                EXPECT_STREQ("request and response slave id mismatch", e.what());
                throw;
            }
        },
        Modbus::TUnexpectedResponseError);

    badHeader[0] = 0xfd;
    badHeader[1] = 0x45;
    port.AddResponse(badHeader);
    ASSERT_THROW(
        {
            try {
                traits.Transaction(port, 0xfd, req, req.size(), t, t);
            } catch (const Modbus::TUnexpectedResponseError& e) {
                EXPECT_STREQ("invalid response command", e.what());
                throw;
            }
        },
        Modbus::TUnexpectedResponseError);

    badHeader[1] = 0x46;
    badHeader[2] = 0x10;
    port.AddResponse(badHeader);
    ASSERT_THROW(
        {
            try {
                traits.Transaction(port, 0xfd, req, req.size(), t, t);
            } catch (const Modbus::TUnexpectedResponseError& e) {
                EXPECT_STREQ("invalid response subcommand: 16", e.what());
                throw;
            }
        },
        Modbus::TUnexpectedResponseError);

    badHeader[2] = 0x09;
    badHeader[3] = 0x01;
    port.AddResponse(badHeader);
    ASSERT_THROW(
        {
            try {
                traits.Transaction(port, 0xfd, req, req.size(), t, t);
            } catch (const Modbus::TUnexpectedResponseError& e) {
                EXPECT_STREQ("SN mismatch: got 30074853, wait 4274710501", e.what());
                throw;
            }
        },
        Modbus::TUnexpectedResponseError);
}

TEST(TModbusExtTest, ScanStartDeviceFound)
{
    TPortMock port;
    // DEVICE_FOUND_RESPONSE_SCAN_COMMAND (0x03)
    port.AddResponse({0xFD, 0x46, 0x03, 0x12, 0x34, 0x56, 0x78, 0x05, 0x00, 0x00});
    // NO_MORE_DEVICES_RESPONSE_SCAN_COMMAND
    port.AddResponse({0xFD, 0x46, 0x04, 0x00, 0x00});

    ModbusExt::TModbusRTUWithArbitrationTraits traits;
    std::vector<ModbusExt::TScannedDevice> scannedDevices;
    EXPECT_NO_THROW(ModbusExt::Scan(port, traits, ModbusExt::TModbusExtCommand::ACTUAL, scannedDevices));
    ASSERT_EQ(scannedDevices.size(), 1);
    EXPECT_EQ(scannedDevices[0].SlaveId, 5);
    EXPECT_EQ(scannedDevices[0].Sn, 0x12345678);
}

TEST(TModbusExtTest, ScanStartNoMoreDevices)
{
    TPortMock port;
    // NO_MORE_DEVICES_RESPONSE_SCAN_COMMAND (0x04)
    port.AddResponse({0xFD, 0x46, 0x04, 0x00, 0x00});

    ModbusExt::TModbusRTUWithArbitrationTraits traits;
    std::vector<ModbusExt::TScannedDevice> scannedDevices;
    EXPECT_NO_THROW(ModbusExt::Scan(port, traits, ModbusExt::TModbusExtCommand::ACTUAL, scannedDevices));
    EXPECT_TRUE(scannedDevices.empty());
}

TEST(TModbusExtTest, ScanMultipleDevices)
{
    TPortMock port;
    port.AddResponse(
        {0xFD, 0x46, 0x03, 0x01, 0x02, 0x03, 0x04, 0x10, 0x00, 0x00}); // DEVICE_FOUND_RESPONSE_SCAN_COMMAND
    port.AddResponse(
        {0xFD, 0x46, 0x03, 0x05, 0x06, 0x07, 0x08, 0x20, 0x00, 0x00}); // DEVICE_FOUND_RESPONSE_SCAN_COMMAND
    port.AddResponse({0xFD, 0x46, 0x04, 0x00, 0x00});                  // NO_MORE_DEVICES_RESPONSE_SCAN_COMMAND

    ModbusExt::TModbusRTUWithArbitrationTraits traits;
    std::vector<ModbusExt::TScannedDevice> scannedDevices;
    EXPECT_NO_THROW(ModbusExt::Scan(port, traits, ModbusExt::TModbusExtCommand::ACTUAL, scannedDevices));
    ASSERT_EQ(scannedDevices.size(), 2);
    EXPECT_EQ(scannedDevices[0].SlaveId, 0x10);
    EXPECT_EQ(scannedDevices[0].Sn, 0x01020304);
    EXPECT_EQ(scannedDevices[1].SlaveId, 0x20);
    EXPECT_EQ(scannedDevices[1].Sn, 0x05060708);
}

TEST(TModbusExtTest, ScanStartTimeout)
{
    TPortMock port;
    port.ThrowTimeout = true;

    ModbusExt::TModbusRTUWithArbitrationTraits traits;
    std::vector<ModbusExt::TScannedDevice> scannedDevices;
    EXPECT_NO_THROW(ModbusExt::Scan(port, traits, ModbusExt::TModbusExtCommand::ACTUAL, scannedDevices));
    EXPECT_TRUE(scannedDevices.empty());
}

TEST(TModbusExtTest, ScanInvalidSubCommand)
{
    TPortMock port;
    port.AddResponse({0xFD, 0x46, 0x12, 0x00, 0x00});

    ModbusExt::TModbusRTUWithArbitrationTraits traits;
    std::vector<ModbusExt::TScannedDevice> scannedDevices;
    EXPECT_THROW(ModbusExt::Scan(port, traits, ModbusExt::TModbusExtCommand::ACTUAL, scannedDevices),
                 Modbus::TMalformedResponseError);
}

wirenboard / wb-mqtt-serial / 2

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous