20561496515

Committed 28 Dec 2025 11:55AM UTC coverage: 72.478% (-0.2%) from 72.692%

Build # 20561496515

Build Type

push

github

Committed by

web-flow

Commit Message

core: several follow-ups for BindNetworkInterface= (#40202)

Run Details

13 of 54 new or added lines in 5 files covered. (24.07%)

1051 existing lines in 43 files now uncovered.

309149 of 426542 relevant lines covered (72.48%)

1254687.42 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.3

/src/basic/pidref.c

/* SPDX-License-Identifier: LGPL-2.1-or-later */

#include <poll.h>
#include <sys/wait.h>
#include <unistd.h>

#include "alloc-util.h"
#include "errno-util.h"
#include "fd-util.h"
#include "format-util.h"
#include "hash-funcs.h"
#include "io-util.h"
#include "log.h"
#include "parse-util.h"
#include "pidfd-util.h"
#include "pidref.h"
#include "process-util.h"
#include "siphash24.h"
#include "time-util.h"

int pidref_acquire_pidfd_id(PidRef *pidref) {
        int r;

        assert(pidref);

        if (!pidref_is_set(pidref))
                return -ESRCH;

        if (pidref_is_remote(pidref))
                return -EREMOTE;

        if (pidref->fd < 0)
                return -ENOMEDIUM;

        if (pidref->fd_id > 0)
                return 0;

        r = pidfd_get_inode_id(pidref->fd, &pidref->fd_id);
        if (r < 0) {
                if (!ERRNO_IS_NEG_NOT_SUPPORTED(r))
                        log_debug_errno(r, "Failed to get inode number of pidfd for pid " PID_FMT ": %m",
                                        pidref->pid);
                return r;
        }

        return 0;
}

bool pidref_equal(PidRef *a, PidRef *b) {

        /* If this is the very same structure, it definitely refers to the same process */
        if (a == b)
                return true;

        if (!pidref_is_set(a))
                return !pidref_is_set(b);

        if (!pidref_is_set(b))
                return false;

        if (a->pid != b->pid)
                return false;

        if (pidref_is_remote(a)) {
                /* If one is remote and the other isn't, they are not the same */
                if (!pidref_is_remote(b))
                        return false;

                /* If both are remote, compare fd IDs if we have both, otherwise don't bother, and cut things short */
                if (a->fd_id == 0 || b->fd_id == 0)
                        return true;
        } else {
                /* If the other side is remote, then this is not the same */
                if (pidref_is_remote(b))
                        return false;

                /* PID1 cannot exit, hence it cannot change pidfs ids, hence no point in comparing them, we
                 * can shortcut things */
                if (a->pid == 1)
                        return true;

                /* Try to compare pidfds using their inode numbers. This way we can ensure that we
                 * don't spuriously consider two PidRefs equal if the pid has been reused once. Note
                 * that we ignore all errors here, not only EOPNOTSUPP, as fstat() might fail due to
                 * many reasons. */
                if (pidref_acquire_pidfd_id(a) < 0 || pidref_acquire_pidfd_id(b) < 0)
                        return true;
        }

        return a->fd_id == b->fd_id;
}

int pidref_set_pid(PidRef *pidref, pid_t pid) {
        uint64_t pidfdid = 0;
        int fd;

        assert(pidref);

        if (pid < 0)
                return -ESRCH;
        if (pid == 0) {
                pid = getpid_cached();
                (void) pidfd_get_inode_id_self_cached(&pidfdid);
        }

        fd = pidfd_open(pid, 0);
        if (fd < 0) {
                /* Graceful fallback in case the kernel is out of fds */
                if (!ERRNO_IS_RESOURCE(errno))
                        return log_debug_errno(errno, "Failed to open pidfd for pid " PID_FMT ": %m", pid);

                fd = -EBADF;
        }

        *pidref = (PidRef) {
                .fd = fd,
                .pid = pid,
                .fd_id = pidfdid,
        };

        return 0;
}

int pidref_set_pid_and_pidfd_id(
                PidRef *pidref,
                pid_t pid,
                uint64_t pidfd_id) {

        int r;

        assert(pidref);

        _cleanup_(pidref_done) PidRef n = PIDREF_NULL;
        r = pidref_set_pid(&n, pid);
        if (r < 0)
                return r;

        if (pidfd_id > 0) {
                r = pidref_acquire_pidfd_id(&n);
                if (r < 0 && !ERRNO_IS_NEG_NOT_SUPPORTED(r))
                        return r;

                if (n.fd_id != pidfd_id)
                        return -ESRCH;
        }

        *pidref = TAKE_PIDREF(n);
        return 0;
}

int pidref_set_pidstr(PidRef *pidref, const char *pid) {
        pid_t nr;
        int r;

        assert(pidref);

        r = parse_pid(pid, &nr);
        if (r < 0)
                return r;

        return pidref_set_pid(pidref, nr);
}

int pidref_set_pidfd(PidRef *pidref, int fd) {
        int r;

        assert(pidref);

        if (fd < 0)
                return -EBADF;

        int fd_copy = fcntl(fd, F_DUPFD_CLOEXEC, 3);
        if (fd_copy < 0) {
                pid_t pid;

                if (!ERRNO_IS_RESOURCE(errno))
                        return -errno;

                /* Graceful fallback if we are out of fds */
                r = pidfd_get_pid(fd, &pid);
                if (r < 0)
                        return r;

                *pidref = PIDREF_MAKE_FROM_PID(pid);
                return 0;
        }

        return pidref_set_pidfd_consume(pidref, fd_copy);
}

int pidref_set_pidfd_take(PidRef *pidref, int fd) {
        pid_t pid;
        int r;

        assert(pidref);

        if (fd < 0)
                return -EBADF;

        r = pidfd_get_pid(fd, &pid);
        if (r < 0)
                return r;

        *pidref = (PidRef) {
                .fd = fd,
                .pid = pid,
        };

        return 0;
}

int pidref_set_pidfd_consume(PidRef *pidref, int fd) {
        int r;

        r = pidref_set_pidfd_take(pidref, fd);
        if (r < 0)
                safe_close(fd);

        return r;
}

int pidref_set_parent(PidRef *ret) {
        _cleanup_(pidref_done) PidRef parent = PIDREF_NULL;
        pid_t ppid;
        int r;

        assert(ret);

        /* Acquires a pidref to our parent process. Deals with the fact that parent processes might exit, and
         * we get reparented to other processes, with our old parent's PID already being recycled. */

        ppid = getppid();
        for (;;) {
                r = pidref_set_pid(&parent, ppid);
                if (r < 0)
                        return r;

                if (parent.fd < 0) /* If pidfds are not available, then we are done */
                        break;

                pid_t now_ppid = getppid();
                if (now_ppid == ppid) /* If our ppid is still the same, then we are done */
                        break;

                /* Otherwise let's try again with the new ppid */
                ppid = now_ppid;
                pidref_done(&parent);
        }

        *ret = TAKE_PIDREF(parent);
        return 0;
}

void pidref_done(PidRef *pidref) {
        assert(pidref);

        *pidref = (PidRef) {
                .fd = safe_close(pidref->fd),
        };
}

PidRef* pidref_free(PidRef *pidref) {
        /* Regularly, this is an embedded structure. But sometimes we want it on the heap too */
        if (!pidref)
                return NULL;

        pidref_done(pidref);
        return mfree(pidref);
}

int pidref_copy(const PidRef *pidref, PidRef *ret) {
        _cleanup_(pidref_done) PidRef copy = PIDREF_NULL;

        /* If NULL is passed we'll generate a PidRef that refers to no process. This makes it easy to
         * copy pidref fields that might or might not reference a process yet. */

        assert(ret);

        if (pidref) {
                if (pidref_is_remote(pidref)) /* Propagate remote flag */
                        copy.fd = -EREMOTE;
                else if (pidref->fd >= 0) {
                        copy.fd = fcntl(pidref->fd, F_DUPFD_CLOEXEC, 3);
                        if (copy.fd < 0) {
                                if (!ERRNO_IS_RESOURCE(errno))
                                        return -errno;

                                copy.fd = -EBADF;
                        }
                }

                copy.pid = pidref->pid;
                copy.fd_id = pidref->fd_id;
        }

        *ret = TAKE_PIDREF(copy);
        return 0;
}

int pidref_dup(const PidRef *pidref, PidRef **ret) {
        _cleanup_(pidref_freep) PidRef *dup_pidref = NULL;
        int r;

        /* Allocates a new PidRef on the heap, making it a copy of the specified pidref. This does not try to
         * acquire a pidfd if we don't have one yet! */

        assert(ret);

        dup_pidref = newdup(PidRef, &PIDREF_NULL, 1);
        if (!dup_pidref)
                return -ENOMEM;

        r = pidref_copy(pidref, dup_pidref);
        if (r < 0)
                return r;

        *ret = TAKE_PTR(dup_pidref);
        return 0;
}

int pidref_new_from_pid(pid_t pid, PidRef **ret) {
        _cleanup_(pidref_freep) PidRef *n = NULL;
        int r;

        assert(ret);

        if (pid < 0)
                return -ESRCH;

        n = new(PidRef, 1);
        if (!n)
                return -ENOMEM;

        *n = PIDREF_NULL;

        r = pidref_set_pid(n, pid);
        if (r < 0)
                return r;

        *ret = TAKE_PTR(n);
        return 0;
}

int pidref_kill(const PidRef *pidref, int sig) {

        if (!pidref)
                return -ESRCH;

        if (pidref_is_remote(pidref))
                return -EREMOTE;

        if (pidref->fd >= 0)
                return RET_NERRNO(pidfd_send_signal(pidref->fd, sig, NULL, 0));

        if (pidref->pid > 0)
                return RET_NERRNO(kill(pidref->pid, sig));

        return -ESRCH;
}

int pidref_kill_and_sigcont(const PidRef *pidref, int sig) {
        int r;

        r = pidref_kill(pidref, sig);
        if (r < 0)
                return r;

        if (!IN_SET(sig, SIGCONT, SIGKILL))
                (void) pidref_kill(pidref, SIGCONT);

        return 0;
}

int pidref_sigqueue(const PidRef *pidref, int sig, int value) {

        if (!pidref)
                return -ESRCH;

        if (pidref_is_remote(pidref))
                return -EREMOTE;

        if (pidref->fd >= 0) {
                siginfo_t si;

                /* We can't use structured initialization here, since the structure contains various unions
                 * and these fields lie in overlapping (carefully aligned) unions that LLVM is allergic to
                 * allow assignments to */
                zero(si);
                si.si_signo = sig;
                si.si_code = SI_QUEUE;
                si.si_pid = getpid_cached();
                si.si_uid = getuid();
                si.si_value.sival_int = value;

                return RET_NERRNO(pidfd_send_signal(pidref->fd, sig, &si, 0));
        }

        if (pidref->pid > 0)
                return RET_NERRNO(sigqueue(pidref->pid, sig, (const union sigval) { .sival_int = value }));

        return -ESRCH;
}

int pidref_verify(const PidRef *pidref) {
        int r;

        /* This is a helper that is supposed to be called after reading information from procfs via a
         * PidRef. It ensures that the PID we track still matches the PIDFD we pin. If this value differs
         * after a procfs read, we might have read the data from a recycled PID. */

        if (!pidref_is_set(pidref))
                return -ESRCH;

        if (pidref_is_remote(pidref))
                return -EREMOTE;

        if (pidref->pid == 1)
                return 1; /* PID 1 can never go away, hence never be recycled to a different process → return 1 */

        if (pidref->fd < 0)
                return 0; /* If we don't have a pidfd we cannot validate it, hence we assume it's all OK → return 0 */

        r = pidfd_verify_pid(pidref->fd, pidref->pid);
        if (r < 0)
                return r;

        return 1; /* We have a pidfd and it still points to the PID we have, hence all is *really* OK → return 1 */
}

bool pidref_is_self(PidRef *pidref) {
        if (!pidref_is_set(pidref))
                return false;

        if (pidref_is_remote(pidref))
                return false;

        if (pidref->pid != getpid_cached())
                return false;

        /* PID1 cannot exit, hence no point in comparing pidfd IDs, they can never change */
        if (pidref->pid == 1)
                return true;

        /* Also compare pidfd ID if we can get it */
        if (pidref_acquire_pidfd_id(pidref) < 0)
                return true;

        uint64_t self_id;
        if (pidfd_get_inode_id_self_cached(&self_id) < 0)
                return true;

        return pidref->fd_id == self_id;
}

int pidref_wait_for_terminate_full(PidRef *pidref, usec_t timeout, siginfo_t *ret_si) {
        int r;

        assert(timeout > 0);

        if (!pidref_is_set(pidref))
                return -ESRCH;

        if (pidref_is_remote(pidref))
                return -EREMOTE;

        if (pidref->pid == 1 || pidref_is_self(pidref))
                return -ECHILD;

        if (timeout != USEC_INFINITY && pidref->fd < 0)
                return -ENOMEDIUM;

        usec_t ts = timeout == USEC_INFINITY ? USEC_INFINITY : usec_add(now(CLOCK_MONOTONIC), timeout);

        for (;;) {
                if (ts != USEC_INFINITY) {
                        usec_t left = usec_sub_unsigned(ts, now(CLOCK_MONOTONIC));
                        if (left == 0)
                                return -ETIMEDOUT;

                        r = fd_wait_for_event(pidref->fd, POLLIN, left);
                        if (r == 0)
                                return -ETIMEDOUT;
                        if (r == -EINTR)
                                continue;
                        if (r < 0)
                                return r;
                }

                siginfo_t si = {};

                if (pidref->fd >= 0)
                        r = RET_NERRNO(waitid(P_PIDFD, pidref->fd, &si, WEXITED));
                else
                        r = RET_NERRNO(waitid(P_PID, pidref->pid, &si, WEXITED));
                if (r >= 0) {
                        if (ret_si)
                                *ret_si = si;
                        return 0;
                }
                if (r != -EINTR)
                        return r;
        }
}

bool pidref_is_automatic(const PidRef *pidref) {
        return pidref && pid_is_automatic(pidref->pid);
}

void pidref_hash_func(const PidRef *pidref, struct siphash *state) {
        siphash24_compress_typesafe(pidref->pid, state);
}

int pidref_compare_func(const PidRef *a, const PidRef *b) {
        int r;

        assert(a);
        assert(b);

        r = CMP(pidref_is_set(a), pidref_is_set(b));
        if (r != 0)
                return r;

        r = CMP(pidref_is_automatic(a), pidref_is_automatic(b));
        if (r != 0)
                return r;

        r = CMP(pidref_is_remote(a), pidref_is_remote(b));
        if (r != 0)
                return r;

        r = CMP(a->pid, b->pid);
        if (r != 0)
                return r;

        if (a->fd_id != 0 && b->fd_id != 0)
                return CMP(a->fd_id, b->fd_id);

        return 0;
}

DEFINE_HASH_OPS(pidref_hash_ops, PidRef, pidref_hash_func, pidref_compare_func);

DEFINE_HASH_OPS_WITH_KEY_DESTRUCTOR(pidref_hash_ops_free,
                                    PidRef, pidref_hash_func, pidref_compare_func,
                                    pidref_free);

1	/* SPDX-License-Identifier: LGPL-2.1-or-later */
2
3	#include <poll.h>
4	#include <sys/wait.h>
5	#include <unistd.h>
6
7	#include "alloc-util.h"
8	#include "errno-util.h"
9	#include "fd-util.h"
10	#include "format-util.h"
11	#include "hash-funcs.h"
12	#include "io-util.h"
13	#include "log.h"
14	#include "parse-util.h"
15	#include "pidfd-util.h"
16	#include "pidref.h"
17	#include "process-util.h"
18	#include "siphash24.h"
19	#include "time-util.h"
20
21	int pidref_acquire_pidfd_id(PidRef *pidref) {	12,596✔
22	int r;	12,596✔
23
24	assert(pidref);	12,596✔
25
26	if (!pidref_is_set(pidref))	12,596✔
27	return -ESRCH;
28
29	if (pidref_is_remote(pidref))	12,596✔
30	return -EREMOTE;
31
32	if (pidref->fd < 0)	12,596✔
33	return -ENOMEDIUM;
34
35	if (pidref->fd_id > 0)	12,589✔
36	return 0;
37
38	r = pidfd_get_inode_id(pidref->fd, &pidref->fd_id);	6,035✔
39	if (r < 0) {	6,035✔
40	if (!ERRNO_IS_NEG_NOT_SUPPORTED(r))	×
41	log_debug_errno(r, "Failed to get inode number of pidfd for pid " PID_FMT ": %m",	×
42	pidref->pid);
43	return r;	×
44	}
45
46	return 0;
47	}
48
49	bool pidref_equal(PidRef a, PidRef b) {	7,318✔
50
51	/* If this is the very same structure, it definitely refers to the same process */
52	if (a == b)	7,318✔
53	return true;
54
55	if (!pidref_is_set(a))	7,315✔
56	return !pidref_is_set(b);	6,268✔
57
58	if (!pidref_is_set(b))	4,181✔
59	return false;
60
61	if (a->pid != b->pid)	4,171✔
62	return false;
63
64	if (pidref_is_remote(a)) {	4,037✔
65	/* If one is remote and the other isn't, they are not the same */
66	if (!pidref_is_remote(b))	×
67	return false;
68
69	/* If both are remote, compare fd IDs if we have both, otherwise don't bother, and cut things short */
70	if (a->fd_id == 0 \|\| b->fd_id == 0)	×
71	return true;
72	} else {
73	/* If the other side is remote, then this is not the same */
74	if (pidref_is_remote(b))	4,037✔
75	return false;
76
77	/* PID1 cannot exit, hence it cannot change pidfs ids, hence no point in comparing them, we
78	* can shortcut things */
79	if (a->pid == 1)	4,036✔
80	return true;
81
82	/* Try to compare pidfds using their inode numbers. This way we can ensure that we
83	* don't spuriously consider two PidRefs equal if the pid has been reused once. Note
84	* that we ignore all errors here, not only EOPNOTSUPP, as fstat() might fail due to
85	* many reasons. */
86	if (pidref_acquire_pidfd_id(a) < 0 \|\| pidref_acquire_pidfd_id(b) < 0)	4,030✔
87	return true;	2✔
88	}
89
90	return a->fd_id == b->fd_id;	4,028✔
91	}
92
93	int pidref_set_pid(PidRef *pidref, pid_t pid) {	61,356✔
94	uint64_t pidfdid = 0;	61,356✔
95	int fd;	61,356✔
96
97	assert(pidref);	61,356✔
98
99	if (pid < 0)	61,356✔
100	return -ESRCH;	61,356✔
101	if (pid == 0) {	61,356✔
102	pid = getpid_cached();	31,552✔
103	(void) pidfd_get_inode_id_self_cached(&pidfdid);	31,552✔
104	}
105
106	fd = pidfd_open(pid, 0);	61,356✔
107	if (fd < 0) {	61,356✔
108	/* Graceful fallback in case the kernel is out of fds */
UNCOV 109	if (!ERRNO_IS_RESOURCE(errno))	×
UNCOV 110	return log_debug_errno(errno, "Failed to open pidfd for pid " PID_FMT ": %m", pid);	×
111
112	fd = -EBADF;
113	}
114
115	*pidref = (PidRef) {	61,356✔
116	.fd = fd,
117	.pid = pid,
118	.fd_id = pidfdid,
119	};
120
121	return 0;	61,356✔
122	}
123
124	int pidref_set_pid_and_pidfd_id(	56✔
125	PidRef *pidref,
126	pid_t pid,
127	uint64_t pidfd_id) {
128
129	int r;	56✔
130
131	assert(pidref);	56✔
132
133	_cleanup_(pidref_done) PidRef n = PIDREF_NULL;	×
134	r = pidref_set_pid(&n, pid);	56✔
135	if (r < 0)	56✔
136	return r;
137
138	if (pidfd_id > 0) {	56✔
139	r = pidref_acquire_pidfd_id(&n);	56✔
140	if (r < 0 && !ERRNO_IS_NEG_NOT_SUPPORTED(r))	112✔
141	return r;
142
143	if (n.fd_id != pidfd_id)	56✔
144	return -ESRCH;
145	}
146
147	*pidref = TAKE_PIDREF(n);	56✔
148	return 0;	56✔
149	}
150
151	int pidref_set_pidstr(PidRef pidref, const char pid) {	39✔
152	pid_t nr;	39✔
153	int r;	39✔
154
155	assert(pidref);	39✔
156
157	r = parse_pid(pid, &nr);	39✔
158	if (r < 0)	39✔
159	return r;	39✔
160
161	return pidref_set_pid(pidref, nr);	39✔
162	}
163
164	int pidref_set_pidfd(PidRef *pidref, int fd) {	1,082✔
165	int r;	1,082✔
166
167	assert(pidref);	1,082✔
168
169	if (fd < 0)	1,082✔
170	return -EBADF;
171
172	int fd_copy = fcntl(fd, F_DUPFD_CLOEXEC, 3);	1,082✔
173	if (fd_copy < 0) {	1,082✔
174	pid_t pid;	×
175
176	if (!ERRNO_IS_RESOURCE(errno))	×
177	return -errno;	×
178
179	/* Graceful fallback if we are out of fds */
180	r = pidfd_get_pid(fd, &pid);	×
181	if (r < 0)	×
182	return r;
183
184	*pidref = PIDREF_MAKE_FROM_PID(pid);	×
185	return 0;	×
186	}
187
188	return pidref_set_pidfd_consume(pidref, fd_copy);	1,082✔
189	}
190
191	int pidref_set_pidfd_take(PidRef *pidref, int fd) {	3,549✔
192	pid_t pid;	3,549✔
193	int r;	3,549✔
194
195	assert(pidref);	3,549✔
196
197	if (fd < 0)	3,549✔
198	return -EBADF;	3,549✔
199
200	r = pidfd_get_pid(fd, &pid);	3,549✔
201	if (r < 0)	3,549✔
202	return r;
203
204	*pidref = (PidRef) {	3,549✔
205	.fd = fd,
206	.pid = pid,
207	};
208
209	return 0;	3,549✔
210	}
211
212	int pidref_set_pidfd_consume(PidRef *pidref, int fd) {	3,547✔
213	int r;	3,547✔
214
215	r = pidref_set_pidfd_take(pidref, fd);	3,547✔
216	if (r < 0)	3,547✔
217	safe_close(fd);	×
218
219	return r;	3,547✔
220	}
221
222	int pidref_set_parent(PidRef *ret) {	1,282✔
223	_cleanup_(pidref_done) PidRef parent = PIDREF_NULL;	1,282✔
224	pid_t ppid;	1,282✔
225	int r;	1,282✔
226
227	assert(ret);	1,282✔
228
229	/* Acquires a pidref to our parent process. Deals with the fact that parent processes might exit, and
230	* we get reparented to other processes, with our old parent's PID already being recycled. */
231
232	ppid = getppid();	1,282✔
233	for (;;) {	1,282✔
234	r = pidref_set_pid(&parent, ppid);	1,282✔
235	if (r < 0)	1,282✔
236	return r;
237
238	if (parent.fd < 0) /* If pidfds are not available, then we are done */	1,282✔
239	break;
240
241	pid_t now_ppid = getppid();	1,282✔
242	if (now_ppid == ppid) /* If our ppid is still the same, then we are done */	1,282✔
243	break;
244
245	/* Otherwise let's try again with the new ppid */
246	ppid = now_ppid;	×
247	pidref_done(&parent);	×
248	}
249
250	*ret = TAKE_PIDREF(parent);	1,282✔
251	return 0;	1,282✔
252	}
253
254	void pidref_done(PidRef *pidref) {	201,464✔
255	assert(pidref);	201,464✔
256
257	*pidref = (PidRef) {	402,928✔
258	.fd = safe_close(pidref->fd),	201,464✔
259	};
260	}	201,464✔
261
262	PidRef* pidref_free(PidRef *pidref) {	3,342✔
263	/* Regularly, this is an embedded structure. But sometimes we want it on the heap too */
264	if (!pidref)	3,342✔
265	return NULL;
266
267	pidref_done(pidref);	3,342✔
268	return mfree(pidref);	3,342✔
269	}
270
271	int pidref_copy(const PidRef pidref, PidRef ret) {	3,343✔
272	_cleanup_(pidref_done) PidRef copy = PIDREF_NULL;	3,343✔
273
274	/* If NULL is passed we'll generate a PidRef that refers to no process. This makes it easy to
275	* copy pidref fields that might or might not reference a process yet. */
276
277	assert(ret);	3,343✔
278
279	if (pidref) {	3,343✔
280	if (pidref_is_remote(pidref)) /* Propagate remote flag */	3,341✔
281	copy.fd = -EREMOTE;	×
282	else if (pidref->fd >= 0) {	3,341✔
283	copy.fd = fcntl(pidref->fd, F_DUPFD_CLOEXEC, 3);	3,335✔
284	if (copy.fd < 0) {	3,335✔
285	if (!ERRNO_IS_RESOURCE(errno))	×
286	return -errno;	×
287
288	copy.fd = -EBADF;	×
289	}
290	}
291
292	copy.pid = pidref->pid;	3,341✔
293	copy.fd_id = pidref->fd_id;	3,341✔
294	}
295
296	*ret = TAKE_PIDREF(copy);	3,343✔
297	return 0;	3,343✔
298	}
299
300	int pidref_dup(const PidRef pidref, PidRef *ret) {	3,339✔
301	_cleanup_(pidref_freep) PidRef *dup_pidref = NULL;	3,339✔
302	int r;	3,339✔
303
304	/* Allocates a new PidRef on the heap, making it a copy of the specified pidref. This does not try to
305	* acquire a pidfd if we don't have one yet! */
306
307	assert(ret);	3,339✔
308
309	dup_pidref = newdup(PidRef, &PIDREF_NULL, 1);	3,339✔
310	if (!dup_pidref)	3,339✔
311	return -ENOMEM;
312
313	r = pidref_copy(pidref, dup_pidref);	3,339✔
314	if (r < 0)	3,339✔
315	return r;
316
317	*ret = TAKE_PTR(dup_pidref);	3,339✔
318	return 0;	3,339✔
319	}
320
321	int pidref_new_from_pid(pid_t pid, PidRef **ret) {	4✔
322	_cleanup_(pidref_freep) PidRef *n = NULL;	4✔
323	int r;	4✔
324
325	assert(ret);	4✔
326
327	if (pid < 0)	4✔
328	return -ESRCH;
329
330	n = new(PidRef, 1);	3✔
331	if (!n)	3✔
332	return -ENOMEM;
333
334	*n = PIDREF_NULL;	3✔
335
336	r = pidref_set_pid(n, pid);	3✔
337	if (r < 0)	3✔
338	return r;
339
340	*ret = TAKE_PTR(n);	3✔
341	return 0;	3✔
342	}
343
344	int pidref_kill(const PidRef *pidref, int sig) {	15,045✔
345
346	if (!pidref)	15,045✔
347	return -ESRCH;
348
349	if (pidref_is_remote(pidref))	15,045✔
350	return -EREMOTE;
351
352	if (pidref->fd >= 0)	15,043✔
353	return RET_NERRNO(pidfd_send_signal(pidref->fd, sig, NULL, 0));	7,068✔
354
355	if (pidref->pid > 0)	7,975✔
356	return RET_NERRNO(kill(pidref->pid, sig));	14,518✔
357
358	return -ESRCH;
359	}
360
361	int pidref_kill_and_sigcont(const PidRef *pidref, int sig) {	423✔
362	int r;	423✔
363
364	r = pidref_kill(pidref, sig);	423✔
365	if (r < 0)	423✔
366	return r;
367
368	if (!IN_SET(sig, SIGCONT, SIGKILL))	422✔
369	(void) pidref_kill(pidref, SIGCONT);	422✔
370
371	return 0;
372	}
373
374	int pidref_sigqueue(const PidRef *pidref, int sig, int value) {	9,404✔
375
376	if (!pidref)	9,404✔
377	return -ESRCH;
378
379	if (pidref_is_remote(pidref))	9,404✔
380	return -EREMOTE;
381
382	if (pidref->fd >= 0) {	9,404✔
383	siginfo_t si;	9,404✔
384
385	/* We can't use structured initialization here, since the structure contains various unions
386	* and these fields lie in overlapping (carefully aligned) unions that LLVM is allergic to
387	* allow assignments to */
388	zero(si);	9,404✔
389	si.si_signo = sig;	9,404✔
390	si.si_code = SI_QUEUE;	9,404✔
391	si.si_pid = getpid_cached();	9,404✔
392	si.si_uid = getuid();	9,404✔
393	si.si_value.sival_int = value;	9,404✔
394
395	return RET_NERRNO(pidfd_send_signal(pidref->fd, sig, &si, 0));	9,404✔
396	}
397
398	if (pidref->pid > 0)	×
399	return RET_NERRNO(sigqueue(pidref->pid, sig, (const union sigval) { .sival_int = value }));	×
400
401	return -ESRCH;
402	}
403
404	int pidref_verify(const PidRef *pidref) {	44,069✔
405	int r;	44,069✔
406
407	/* This is a helper that is supposed to be called after reading information from procfs via a
408	* PidRef. It ensures that the PID we track still matches the PIDFD we pin. If this value differs
409	* after a procfs read, we might have read the data from a recycled PID. */
410
411	if (!pidref_is_set(pidref))	44,069✔
412	return -ESRCH;
413
414	if (pidref_is_remote(pidref))	44,067✔
415	return -EREMOTE;
416
417	if (pidref->pid == 1)	44,066✔
418	return 1; /* PID 1 can never go away, hence never be recycled to a different process → return 1 */
419
420	if (pidref->fd < 0)	42,684✔
421	return 0; /* If we don't have a pidfd we cannot validate it, hence we assume it's all OK → return 0 */
422
423	r = pidfd_verify_pid(pidref->fd, pidref->pid);	23,180✔
424	if (r < 0)	23,180✔
425	return r;	2,841✔
426
427	return 1; /* We have a pidfd and it still points to the PID we have, hence all is really OK → return 1 */
428	}
429
430	bool pidref_is_self(PidRef *pidref) {	33,091✔
431	if (!pidref_is_set(pidref))	33,091✔
432	return false;	33,091✔
433
434	if (pidref_is_remote(pidref))	33,089✔
435	return false;
436
437	if (pidref->pid != getpid_cached())	33,089✔
438	return false;
439
440	/* PID1 cannot exit, hence no point in comparing pidfd IDs, they can never change */
441	if (pidref->pid == 1)	687✔
442	return true;
443
444	/* Also compare pidfd ID if we can get it */
445	if (pidref_acquire_pidfd_id(pidref) < 0)	687✔
446	return true;
447
448	uint64_t self_id;	682✔
449	if (pidfd_get_inode_id_self_cached(&self_id) < 0)	682✔
450	return true;
451
452	return pidref->fd_id == self_id;	682✔
453	}
454
455	int pidref_wait_for_terminate_full(PidRef pidref, usec_t timeout, siginfo_t ret_si) {	10,882✔
456	int r;	10,882✔
457
458	assert(timeout > 0);	10,882✔
459
460	if (!pidref_is_set(pidref))	10,882✔
461	return -ESRCH;
462
463	if (pidref_is_remote(pidref))	10,882✔
464	return -EREMOTE;
465
466	if (pidref->pid == 1 \|\| pidref_is_self(pidref))	10,881✔
467	return -ECHILD;	×
468
469	if (timeout != USEC_INFINITY && pidref->fd < 0)	10,881✔
470	return -ENOMEDIUM;
471
472	usec_t ts = timeout == USEC_INFINITY ? USEC_INFINITY : usec_add(now(CLOCK_MONOTONIC), timeout);	10,883✔
473
474	for (;;) {	10,881✔
475	if (ts != USEC_INFINITY) {	10,881✔
476	usec_t left = usec_sub_unsigned(ts, now(CLOCK_MONOTONIC));	2✔
477	if (left == 0)	2✔
478	return -ETIMEDOUT;	10,881✔
479
480	r = fd_wait_for_event(pidref->fd, POLLIN, left);	2✔
481	if (r == 0)	2✔
482	return -ETIMEDOUT;
483	if (r == -EINTR)	1✔
484	continue;	×
485	if (r < 0)	1✔
486	return r;
487	}
488
489	siginfo_t si = {};	10,880✔
490
491	if (pidref->fd >= 0)	10,880✔
492	r = RET_NERRNO(waitid(P_PIDFD, pidref->fd, &si, WEXITED));	10,036✔
493	else
494	r = RET_NERRNO(waitid(P_PID, pidref->pid, &si, WEXITED));	844✔
495	if (r >= 0) {	×
496	if (ret_si)	10,880✔
497	*ret_si = si;	7,480✔
498	return 0;	10,880✔
499	}
500	if (r != -EINTR)	×
501	return r;
502	}
503	}
504
505	bool pidref_is_automatic(const PidRef *pidref) {	171,394✔
506	return pidref && pid_is_automatic(pidref->pid);	171,394✔
507	}
508
509	void pidref_hash_func(const PidRef pidref, struct siphash state) {	86,799✔
510	siphash24_compress_typesafe(pidref->pid, state);	86,799✔
511	}	86,799✔
512
513	int pidref_compare_func(const PidRef a, const PidRef b) {	85,671✔
514	int r;	85,671✔
515
516	assert(a);	85,671✔
517	assert(b);	85,671✔
518
519	r = CMP(pidref_is_set(a), pidref_is_set(b));	257,013✔
520	if (r != 0)	85,671✔
521	return r;	×
522
523	r = CMP(pidref_is_automatic(a), pidref_is_automatic(b));	85,671✔
524	if (r != 0)	85,671✔
525	return r;	×
526
527	r = CMP(pidref_is_remote(a), pidref_is_remote(b));	171,342✔
528	if (r != 0)	85,671✔
529	return r;	×
530
531	r = CMP(a->pid, b->pid);	85,671✔
532	if (r != 0)	69,410✔
533	return r;	19,526✔
534
535	if (a->fd_id != 0 && b->fd_id != 0)	66,145✔
536	return CMP(a->fd_id, b->fd_id);	661✔
537
538	return 0;
539	}
540
541	DEFINE_HASH_OPS(pidref_hash_ops, PidRef, pidref_hash_func, pidref_compare_func);
542
543	DEFINE_HASH_OPS_WITH_KEY_DESTRUCTOR(pidref_hash_ops_free,	×
544	PidRef, pidref_hash_func, pidref_compare_func,
545	pidref_free);

systemd / systemd / 20561496515

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous