20527476519

Committed 26 Dec 2025 06:39PM UTC coverage: 42.491%. Remained the same

Build # 20527476519

Build Type

push

github

Committed by

web-flow

Commit Message

fix: remove validation (#67)

Signed-off-by: Eric Fortmeyer <e.fortmeyer01@gmail.com>

Run Details

0 of 10 new or added lines in 2 files covered. (0.0%)

348 of 819 relevant lines covered (42.49%)

1.31 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/Http/NotifyReleaseEventMiddleware.php

<?php

declare(strict_types=1);

namespace EricFortmeyer\ActivityLog\Http;

use EricFortmeyer\ActivityLog\AppReleaseEvent;
use EricFortmeyer\ActivityLog\Services\AppConfigService;
use EricFortmeyer\ActivityLog\Utils\Hasher;
use PhpCommonEnums\HttpMethod\Enumeration\HttpMethodEnum;
use PhpCommonEnums\HttpResponseCode\Enumeration\HttpResponseCodeEnum;
use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;

final class NotifyReleaseEventMiddleware implements MiddlewareInterface
{
    private const SIGNATURE_HEADER_KEY = "X-Hub-Signature-256";
    private const SUPPORTED_METHODS = [HttpMethodEnum::Post];

    public function __construct(
        private string $releaseEventDestination,
        private string $releaseEventHookPath,
        private ResponseFactoryInterface $responseFactory,
        private AppConfigService $appVersionUpdater,
        private Hasher $verifier,
    ) {}

    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $requestBody = $request->getBody()->getContents();
        return match (false) {
            in_array($request->getUri()->getPath(), [$this->releaseEventHookPath]) => $handler->handle($request),
            in_array(HttpMethodEnum::from($request->getMethod()), self::SUPPORTED_METHODS) =>
            $this->responseFactory->createResponse(
                (int) HttpResponseCodeEnum::MethodNotAllowed->value,
                HttpResponseCodeEnum::MethodNotAllowed->name
            ),
            str_starts_with(
                $request->getHeader("User-Agent")[0] ?? "invalid!!!",
                "GitHub-Hookshot",
            ) => $this->responseFactory->createResponse(
                (int) HttpResponseCodeEnum::Unauthorized->value,
                HttpResponseCodeEnum::Unauthorized->name
            ),
            $this->verifier->verify(
                data: $requestBody,
                signature: ltrim($request->getHeader(self::SIGNATURE_HEADER_KEY)[0] ?? "ignore", "sha256="),
            ) => $this->responseFactory->createResponse(
                (int) HttpResponseCodeEnum::Unauthorized->value,
                HttpResponseCodeEnum::Unauthorized->name
            ),
            AppReleaseEvent::isReleaseEventRequest($request) => $this->responseFactory->createResponse(
                (int) HttpResponseCodeEnum::NotImplemented->value,
                HttpResponseCodeEnum::NotImplemented->name
            ),
            AppReleaseEvent::fromRequest($requestBody, $request)->isValid() => $this->responseFactory->createResponse(
                (int) HttpResponseCodeEnum::BadRequest->value,
                HttpResponseCodeEnum::BadRequest->name
            ),
            AppReleaseEvent::isCreatedRelease($requestBody) => $this->responseFactory->createResponse(
                (int) HttpResponseCodeEnum::Accepted->value,
                HttpResponseCodeEnum::Accepted->name
            ),
            $this->handleReleaseEvent(
                AppReleaseEvent::fromRequest($requestBody, $request),
                $requestBody,
            ) =>
            $this->responseFactory->createResponse(
                (int) HttpResponseCodeEnum::InternalServerError->value,
                HttpResponseCodeEnum::InternalServerError->name
            ),
            default => $this->responseFactory->createResponse(
                (int) HttpResponseCodeEnum::Accepted->value,
                HttpResponseCodeEnum::Accepted->name
            ),
        };
    }

    private function handleReleaseEvent(
        AppReleaseEvent $event,
        string $requestBody,
    ): bool {
        return file_put_contents(
            sprintf(
                "%s/%d.json",
                $this->releaseEventDestination,
                $event->release->id,
            ),
            $requestBody,
        ) !== false
            && $this->appVersionUpdater->updateVersion($event->release->tagName);
    }
}

1	<?php
2
3	declare(strict_types=1);
4
5	namespace EricFortmeyer\ActivityLog\Http;
6
7	use EricFortmeyer\ActivityLog\AppReleaseEvent;
8	use EricFortmeyer\ActivityLog\Services\AppConfigService;
9	use EricFortmeyer\ActivityLog\Utils\Hasher;
10	use PhpCommonEnums\HttpMethod\Enumeration\HttpMethodEnum;
11	use PhpCommonEnums\HttpResponseCode\Enumeration\HttpResponseCodeEnum;
12	use Psr\Http\Message\ResponseFactoryInterface;
13	use Psr\Http\Message\ServerRequestInterface;
14	use Psr\Http\Message\ResponseInterface;
15	use Psr\Http\Server\MiddlewareInterface;
16	use Psr\Http\Server\RequestHandlerInterface;
17
18	final class NotifyReleaseEventMiddleware implements MiddlewareInterface
19	{
20	private const SIGNATURE_HEADER_KEY = "X-Hub-Signature-256";
21	private const SUPPORTED_METHODS = [HttpMethodEnum::Post];
22
23	public function __construct(
24	private string $releaseEventDestination,
25	private string $releaseEventHookPath,
26	private ResponseFactoryInterface $responseFactory,
27	private AppConfigService $appVersionUpdater,
28	private Hasher $verifier,
29	) {}	×
30
31	public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
32	{
NEW 33	$requestBody = $request->getBody()->getContents();	×
34	return match (false) {	×
35	in_array($request->getUri()->getPath(), [$this->releaseEventHookPath]) => $handler->handle($request),	×
36	in_array(HttpMethodEnum::from($request->getMethod()), self::SUPPORTED_METHODS) =>	×
37	$this->responseFactory->createResponse(	×
38	(int) HttpResponseCodeEnum::MethodNotAllowed->value,	×
39	HttpResponseCodeEnum::MethodNotAllowed->name	×
40	),	×
41	str_starts_with(	×
42	$request->getHeader("User-Agent")[0] ?? "invalid!!!",	×
43	"GitHub-Hookshot",	×
44	) => $this->responseFactory->createResponse(	×
45	(int) HttpResponseCodeEnum::Unauthorized->value,	×
46	HttpResponseCodeEnum::Unauthorized->name	×
47	),	×
48	$this->verifier->verify(	×
NEW 49	data: $requestBody,	×
50	signature: ltrim($request->getHeader(self::SIGNATURE_HEADER_KEY)[0] ?? "ignore", "sha256="),	×
51	) => $this->responseFactory->createResponse(	×
52	(int) HttpResponseCodeEnum::Unauthorized->value,	×
53	HttpResponseCodeEnum::Unauthorized->name	×
54	),	×
55	AppReleaseEvent::isReleaseEventRequest($request) => $this->responseFactory->createResponse(	×
56	(int) HttpResponseCodeEnum::NotImplemented->value,	×
57	HttpResponseCodeEnum::NotImplemented->name	×
58	),	×
NEW 59	AppReleaseEvent::fromRequest($requestBody, $request)->isValid() => $this->responseFactory->createResponse(	×
60	(int) HttpResponseCodeEnum::BadRequest->value,	×
61	HttpResponseCodeEnum::BadRequest->name	×
62	),	×
NEW 63	AppReleaseEvent::isCreatedRelease($requestBody) => $this->responseFactory->createResponse(	×
64	(int) HttpResponseCodeEnum::Accepted->value,	×
65	HttpResponseCodeEnum::Accepted->name	×
66	),	×
67	$this->handleReleaseEvent(	×
NEW 68	AppReleaseEvent::fromRequest($requestBody, $request),	×
NEW 69	$requestBody,	×
70	) =>	×
71	$this->responseFactory->createResponse(	×
72	(int) HttpResponseCodeEnum::InternalServerError->value,	×
73	HttpResponseCodeEnum::InternalServerError->name	×
74	),	×
75	default => $this->responseFactory->createResponse(	×
76	(int) HttpResponseCodeEnum::Accepted->value,	×
77	HttpResponseCodeEnum::Accepted->name	×
78	),	×
79	};	×
80	}
81
82	private function handleReleaseEvent(
83	AppReleaseEvent $event,
84	string $requestBody,
85	): bool {
86	return file_put_contents(	×
87	sprintf(	×
88	"%s/%d.json",	×
89	$this->releaseEventDestination,	×
NEW 90	$event->release->id,	×
91	),	×
NEW 92	$requestBody,	×
93	) !== false	×
94	&& $this->appVersionUpdater->updateVersion($event->release->tagName);	×
95	}
96	}

ericfortmeyer / activity-log / 20527476519

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous