• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4897

25 Dec 2025 10:17AM UTC coverage: 65.717% (-0.2%) from 65.929%
#4897

push

travis-ci

web-flow
fix: [6622889291] Fix invalid rowSize. (#34043)

186011 of 283047 relevant lines covered (65.72%)

113853896.64 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

74.86
/source/dnode/mnode/impl/src/mndTopic.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *f
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "mndTopic.h"
17
#include "audit.h"
18
#include "mndConsumer.h"
19
#include "mndDb.h"
20
#include "mndDnode.h"
21
#include "mndMnode.h"
22
#include "mndPrivilege.h"
23
#include "mndShow.h"
24
#include "mndStb.h"
25
#include "mndSubscribe.h"
26
#include "mndTrans.h"
27
#include "mndUser.h"
28
#include "mndVgroup.h"
29
#include "osMemPool.h"
30
#include "parser.h"
31
#include "tlockfree.h"
32
#include "tname.h"
33

34
#define MND_TOPIC_VER_NUMBER   4
35
#define MND_TOPIC_RESERVE_SIZE 64
36

37
SHashObj *topicsToReload = NULL;
38

39
SSdbRaw *mndTopicActionEncode(SMqTopicObj *pTopic);
40
SSdbRow *mndTopicActionDecode(SSdbRaw *pRaw);
41

42
static int32_t mndTopicActionInsert(SSdb *pSdb, SMqTopicObj *pTopic);
43
static int32_t mndTopicActionDelete(SSdb *pSdb, SMqTopicObj *pTopic);
44
static int32_t mndTopicActionUpdate(SSdb *pSdb, SMqTopicObj *pOldTopic, SMqTopicObj *pNewTopic);
45
static int32_t mndProcessCreateTopicReq(SRpcMsg *pReq);
46
static int32_t mndProcessDropTopicReq(SRpcMsg *pReq);
47

48
static int32_t mndRetrieveTopic(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows);
49
static void    mndCancelGetNextTopic(SMnode *pMnode, void *pIter);
50
static int32_t processAst(SMqTopicObj *topicObj, const char *ast);
51

52
int32_t mndInitTopic(SMnode *pMnode) {
513,439✔
53
  SSdbTable table = {
513,439✔
54
      .sdbType = SDB_TOPIC,
55
      .keyType = SDB_KEY_BINARY,
56
      .encodeFp = (SdbEncodeFp)mndTopicActionEncode,
57
      .decodeFp = (SdbDecodeFp)mndTopicActionDecode,
58
      .insertFp = (SdbInsertFp)mndTopicActionInsert,
59
      .updateFp = (SdbUpdateFp)mndTopicActionUpdate,
60
      .deleteFp = (SdbDeleteFp)mndTopicActionDelete,
61
  };
62

63
  if (pMnode == NULL) {
513,439✔
64
    return TSDB_CODE_INVALID_PARA;
×
65
  }
66
  mndSetMsgHandle(pMnode, TDMT_MND_TMQ_CREATE_TOPIC, mndProcessCreateTopicReq);
513,439✔
67
  mndSetMsgHandle(pMnode, TDMT_MND_TMQ_DROP_TOPIC, mndProcessDropTopicReq);
513,439✔
68

69
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_TOPICS, mndRetrieveTopic);
513,439✔
70
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_TOPICS, mndCancelGetNextTopic);
513,439✔
71

72
  return sdbSetTable(pMnode->pSdb, table);
513,439✔
73
}
74

75
void mndCleanupTopic(SMnode *pMnode) {}
513,318✔
76

77
void mndTopicGetShowName(const char *fullTopic, char *topic) {
20,761✔
78
  if (fullTopic == NULL) {
20,761✔
79
    return;
×
80
  }
81
  char *tmp = strchr(fullTopic, '.');
20,761✔
82
  if (tmp == NULL) {
20,761✔
83
    tstrncpy(topic, fullTopic, TSDB_TOPIC_FNAME_LEN);
×
84
  } else {
85
    tstrncpy(topic, tmp + 1, TSDB_TOPIC_FNAME_LEN);
20,761✔
86
  }
87
}
88

89
SSdbRaw *mndTopicActionEncode(SMqTopicObj *pTopic) {
101,051✔
90
  if (pTopic == NULL) {
101,051✔
91
    return NULL;
×
92
  }
93
  int32_t code = 0;
101,051✔
94
  int32_t lino = 0;
101,051✔
95
  terrno = TSDB_CODE_OUT_OF_MEMORY;
101,051✔
96

97
  void *  swBuf = NULL;
101,051✔
98
  int32_t physicalPlanLen = 0;
101,051✔
99
  if (pTopic->physicalPlan) {
101,051✔
100
    physicalPlanLen = strlen(pTopic->physicalPlan) + 1;
101,051✔
101
  }
102

103
  int32_t schemaLen = 0;
101,051✔
104
  if (pTopic->schema.nCols) {
101,051✔
105
    schemaLen = taosEncodeSSchemaWrapper(NULL, &pTopic->schema);
175,650✔
106
  }
107

108
  int32_t  size = sizeof(SMqTopicObj) + physicalPlanLen + pTopic->sqlLen + schemaLen + MND_TOPIC_RESERVE_SIZE;
101,051✔
109
  SSdbRaw *pRaw = sdbAllocRaw(SDB_TOPIC, MND_TOPIC_VER_NUMBER, size);
101,051✔
110
  if (pRaw == NULL) {
101,051✔
111
    goto TOPIC_ENCODE_OVER;
×
112
  }
113

114
  int32_t dataPos = 0;
101,051✔
115
  SDB_SET_BINARY(pRaw, dataPos, pTopic->name, TSDB_TOPIC_FNAME_LEN, TOPIC_ENCODE_OVER);
101,051✔
116
  SDB_SET_BINARY(pRaw, dataPos, pTopic->db, TSDB_DB_FNAME_LEN, TOPIC_ENCODE_OVER);
101,051✔
117
  SDB_SET_BINARY(pRaw, dataPos, pTopic->createUser, TSDB_USER_LEN, TOPIC_ENCODE_OVER);
101,051✔
118
  SDB_SET_INT64(pRaw, dataPos, pTopic->createTime, TOPIC_ENCODE_OVER);
101,051✔
119
  SDB_SET_INT64(pRaw, dataPos, pTopic->updateTime, TOPIC_ENCODE_OVER);
101,051✔
120
  SDB_SET_INT64(pRaw, dataPos, pTopic->uid, TOPIC_ENCODE_OVER);
101,051✔
121
  SDB_SET_INT64(pRaw, dataPos, pTopic->dbUid, TOPIC_ENCODE_OVER);
101,051✔
122
  SDB_SET_INT32(pRaw, dataPos, pTopic->version, TOPIC_ENCODE_OVER);
101,051✔
123
  SDB_SET_INT8(pRaw, dataPos, pTopic->subType, TOPIC_ENCODE_OVER);
101,051✔
124
  SDB_SET_INT8(pRaw, dataPos, pTopic->withMeta, TOPIC_ENCODE_OVER);
101,051✔
125

126
  SDB_SET_INT64(pRaw, dataPos, pTopic->stbUid, TOPIC_ENCODE_OVER);
101,051✔
127
  SDB_SET_BINARY(pRaw, dataPos, pTopic->stbName, TSDB_TABLE_FNAME_LEN, TOPIC_ENCODE_OVER);
101,051✔
128
  SDB_SET_INT32(pRaw, dataPos, pTopic->sqlLen, TOPIC_ENCODE_OVER);
101,051✔
129
  SDB_SET_BINARY(pRaw, dataPos, pTopic->sql, pTopic->sqlLen, TOPIC_ENCODE_OVER);
101,051✔
130
  SDB_SET_INT32(pRaw, dataPos, physicalPlanLen, TOPIC_ENCODE_OVER);
101,051✔
131
  if (physicalPlanLen) {
101,051✔
132
    SDB_SET_BINARY(pRaw, dataPos, pTopic->physicalPlan, physicalPlanLen, TOPIC_ENCODE_OVER);
101,051✔
133
  }
134
  SDB_SET_INT32(pRaw, dataPos, schemaLen, TOPIC_ENCODE_OVER);
101,051✔
135
  if (schemaLen) {
101,051✔
136
    swBuf = taosMemoryMalloc(schemaLen);
87,825✔
137
    if (swBuf == NULL) {
87,825✔
138
      goto TOPIC_ENCODE_OVER;
×
139
    }
140
    void *aswBuf = swBuf;
87,825✔
141
    if (taosEncodeSSchemaWrapper(&aswBuf, &pTopic->schema) < 0) {
175,650✔
142
      goto TOPIC_ENCODE_OVER;
×
143
    }
144
    SDB_SET_BINARY(pRaw, dataPos, swBuf, schemaLen, TOPIC_ENCODE_OVER);
87,825✔
145
  }
146

147
  SDB_SET_RESERVE(pRaw, dataPos, MND_TOPIC_RESERVE_SIZE, TOPIC_ENCODE_OVER);
101,051✔
148
  SDB_SET_DATALEN(pRaw, dataPos, TOPIC_ENCODE_OVER);
101,051✔
149

150
  terrno = TSDB_CODE_SUCCESS;
101,051✔
151

152
TOPIC_ENCODE_OVER:
101,051✔
153
  if (swBuf) taosMemoryFree(swBuf);
101,051✔
154
  if (terrno != TSDB_CODE_SUCCESS) {
101,051✔
155
    mError("topic:%s, failed to encode to raw:%p since %s", pTopic->name, pRaw, terrstr());
×
156
    sdbFreeRaw(pRaw);
×
157
    return NULL;
×
158
  }
159

160
  mDebug("topic:%s, encode to raw:%p, row:%p", pTopic->name, pRaw, pTopic);
101,051✔
161
  return pRaw;
101,051✔
162
}
163

164
SSdbRow *mndTopicActionDecode(SSdbRaw *pRaw) {
85,784✔
165
  if (pRaw == NULL) return NULL;
85,784✔
166
  int32_t code = 0;
85,784✔
167
  int32_t lino = 0;
85,784✔
168
  terrno = TSDB_CODE_OUT_OF_MEMORY;
85,784✔
169
  SSdbRow *    pRow = NULL;
85,784✔
170
  SMqTopicObj *pTopic = NULL;
85,784✔
171
  void *       buf = NULL;
85,784✔
172
  char*        ast = NULL;
85,784✔
173

174
  int8_t sver = 0;
85,784✔
175
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto TOPIC_DECODE_OVER;
85,784✔
176

177
  if (sver < 1 || sver > MND_TOPIC_VER_NUMBER) {
85,784✔
178
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
179
    goto TOPIC_DECODE_OVER;
×
180
  }
181

182
  pRow = sdbAllocRow(sizeof(SMqTopicObj));
85,784✔
183
  if (pRow == NULL) goto TOPIC_DECODE_OVER;
85,784✔
184

185
  pTopic = sdbGetRowObj(pRow);
85,784✔
186
  if (pTopic == NULL) goto TOPIC_DECODE_OVER;
85,784✔
187

188
  int32_t len = 0;
85,784✔
189
  int32_t dataPos = 0;
85,784✔
190
  SDB_GET_BINARY(pRaw, dataPos, pTopic->name, TSDB_TOPIC_FNAME_LEN, TOPIC_DECODE_OVER);
85,784✔
191
  SDB_GET_BINARY(pRaw, dataPos, pTopic->db, TSDB_DB_FNAME_LEN, TOPIC_DECODE_OVER);
85,784✔
192
  if (sver >= 2) {
85,784✔
193
    SDB_GET_BINARY(pRaw, dataPos, pTopic->createUser, TSDB_USER_LEN, TOPIC_DECODE_OVER);
85,784✔
194
  }
195
  SDB_GET_INT64(pRaw, dataPos, &pTopic->createTime, TOPIC_DECODE_OVER);
85,784✔
196
  SDB_GET_INT64(pRaw, dataPos, &pTopic->updateTime, TOPIC_DECODE_OVER);
85,784✔
197
  SDB_GET_INT64(pRaw, dataPos, &pTopic->uid, TOPIC_DECODE_OVER);
85,784✔
198
  SDB_GET_INT64(pRaw, dataPos, &pTopic->dbUid, TOPIC_DECODE_OVER);
85,784✔
199
  SDB_GET_INT32(pRaw, dataPos, &pTopic->version, TOPIC_DECODE_OVER);
85,784✔
200
  SDB_GET_INT8(pRaw, dataPos, &pTopic->subType, TOPIC_DECODE_OVER);
85,784✔
201
  SDB_GET_INT8(pRaw, dataPos, &pTopic->withMeta, TOPIC_DECODE_OVER);
85,784✔
202

203
  SDB_GET_INT64(pRaw, dataPos, &pTopic->stbUid, TOPIC_DECODE_OVER);
85,784✔
204
  if (sver >= 3) {
85,784✔
205
    SDB_GET_BINARY(pRaw, dataPos, pTopic->stbName, TSDB_TABLE_FNAME_LEN, TOPIC_DECODE_OVER);
85,784✔
206
  }
207
  SDB_GET_INT32(pRaw, dataPos, &pTopic->sqlLen, TOPIC_DECODE_OVER);
85,784✔
208
  pTopic->sql = taosMemoryCalloc(pTopic->sqlLen, sizeof(char));
85,784✔
209
  if (pTopic->sql == NULL) {
85,784✔
210
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
211
    goto TOPIC_DECODE_OVER;
×
212
  }
213
  SDB_GET_BINARY(pRaw, dataPos, pTopic->sql, pTopic->sqlLen, TOPIC_DECODE_OVER);
85,784✔
214

215
  if (sver < 4) {
85,784✔
216
    int32_t astLen = 0;
×
217
    SDB_GET_INT32(pRaw, dataPos, &astLen, TOPIC_DECODE_OVER);
×
218
    if (astLen) {
×
219
      ast = taosMemoryCalloc(astLen, sizeof(char));
×
220
      if (ast == NULL) {
×
221
        terrno = TSDB_CODE_OUT_OF_MEMORY;
×
222
        goto TOPIC_DECODE_OVER;
×
223
      }
224
      SDB_GET_BINARY(pRaw, dataPos, ast, astLen, TOPIC_DECODE_OVER);
×
225
      terrno = processAst(pTopic, ast);
×
226
      if (terrno != TSDB_CODE_SUCCESS) {
×
227
        goto TOPIC_DECODE_OVER;
×
228
      }
229
    }
230
  } else {
231
    SDB_GET_INT32(pRaw, dataPos, &len, TOPIC_DECODE_OVER);
85,784✔
232
    if (len) {
85,784✔
233
      pTopic->physicalPlan = taosMemoryCalloc(len, sizeof(char));
85,784✔
234
      if (pTopic->physicalPlan == NULL) {
85,784✔
235
        terrno = TSDB_CODE_OUT_OF_MEMORY;
×
236
        goto TOPIC_DECODE_OVER;
×
237
      }
238
      SDB_GET_BINARY(pRaw, dataPos, pTopic->physicalPlan, len, TOPIC_DECODE_OVER);
85,784✔
239
    } else {
240
      pTopic->physicalPlan = NULL;
×
241
    }
242

243
    SDB_GET_INT32(pRaw, dataPos, &len, TOPIC_DECODE_OVER);
85,784✔
244
    if (len) {
85,784✔
245
      buf = taosMemoryMalloc(len);
74,418✔
246
      if (buf == NULL) {
74,418✔
247
        terrno = TSDB_CODE_OUT_OF_MEMORY;
×
248
        goto TOPIC_DECODE_OVER;
×
249
      }
250
      SDB_GET_BINARY(pRaw, dataPos, buf, len, TOPIC_DECODE_OVER);
74,418✔
251
      if (taosDecodeSSchemaWrapper(buf, &pTopic->schema) == NULL) {
148,836✔
252
        goto TOPIC_DECODE_OVER;
×
253
      }
254
    } else {
255
      pTopic->schema.nCols = 0;
11,366✔
256
      pTopic->schema.version = 0;
11,366✔
257
      pTopic->schema.pSchema = NULL;
11,366✔
258
    }
259
  }
260

261
  SDB_GET_RESERVE(pRaw, dataPos, MND_TOPIC_RESERVE_SIZE, TOPIC_DECODE_OVER);
85,784✔
262
  terrno = TSDB_CODE_SUCCESS;
85,784✔
263

264
TOPIC_DECODE_OVER:
85,784✔
265
  taosMemoryFreeClear(buf);
85,784✔
266
  taosMemoryFreeClear(ast);
85,784✔
267

268
  if (terrno != TSDB_CODE_SUCCESS) {
85,784✔
269
    mError("topic:%s, failed to decode from raw:%p since %s", pTopic == NULL ? "null" : pTopic->name, pRaw, terrstr());
×
270
    taosMemoryFreeClear(pRow);
×
271
    return NULL;
×
272
  }
273

274
  mDebug("topic:%s, decode from raw:%p, row:%p", pTopic->name, pRaw, pTopic);
85,784✔
275
  return pRow;
85,784✔
276
}
277

278
static int32_t mndTopicActionInsert(SSdb *pSdb, SMqTopicObj *pTopic) {
54,316✔
279
  mDebug("topic:%s perform insert action", pTopic != NULL ? pTopic->name : "null");
54,316✔
280
  return 0;
54,316✔
281
}
282

283
static int32_t mndTopicActionDelete(SSdb *pSdb, SMqTopicObj *pTopic) {
85,784✔
284
  if (pTopic == NULL) return 0;
85,784✔
285
  mDebug("%p topic:%s perform delete action", pTopic, pTopic->name);
85,784✔
286
  taosMemoryFreeClear(pTopic->sql);
85,784✔
287
  taosMemoryFreeClear(pTopic->physicalPlan);
85,784✔
288
  if (pTopic->schema.nCols) taosMemoryFreeClear(pTopic->schema.pSchema);
85,784✔
289
  return 0;
85,784✔
290
}
291

292
static int32_t mndTopicActionUpdate(SSdb *pSdb, SMqTopicObj *pOldTopic, SMqTopicObj *pNewTopic) {
×
293
  if (pOldTopic == NULL || pNewTopic == NULL) return 0;
×
294
  mDebug("topic:%s perform update action", pOldTopic->name);
×
295
  taosWLockLatch(&pOldTopic->lock);
×
296
  SMqTopicObj tmpTopic = *pOldTopic;
×
297
  (void)memcpy(pOldTopic, pNewTopic, offsetof(SMqTopicObj, lock));
×
298
  *pNewTopic = tmpTopic;
×
299
  taosWUnLockLatch(&pOldTopic->lock);
×
300
  return 0;
×
301
}
302

303
int32_t mndAcquireTopic(SMnode *pMnode, const char *topicName, SMqTopicObj **pTopic) {
791,198✔
304
  if (pMnode == NULL || topicName == NULL || pTopic == NULL) {
791,198✔
305
    return TSDB_CODE_INVALID_PARA;
×
306
  }
307
  SSdb *pSdb = pMnode->pSdb;
791,198✔
308
  *pTopic = sdbAcquire(pSdb, SDB_TOPIC, topicName);
791,198✔
309
  if (*pTopic == NULL) {
791,198✔
310
    return TSDB_CODE_MND_TOPIC_NOT_EXIST;
52,542✔
311
  }
312
  return TSDB_CODE_SUCCESS;
738,656✔
313
}
314

315
void mndReleaseTopic(SMnode *pMnode, SMqTopicObj *pTopic) {
801,378✔
316
  if (pMnode == NULL) return;
801,378✔
317
  SSdb *pSdb = pMnode->pSdb;
801,378✔
318
  sdbRelease(pSdb, pTopic);
801,378✔
319
}
320

321
static int32_t mndCheckCreateTopicReq(SCMCreateTopicReq *pCreate) {
50,017✔
322
  if (pCreate == NULL) return TSDB_CODE_INVALID_PARA;
50,017✔
323
  if (pCreate->sql == NULL) return TSDB_CODE_MND_INVALID_TOPIC;
50,017✔
324

325
  if (pCreate->subType == TOPIC_SUB_TYPE__COLUMN) {
50,017✔
326
    if (pCreate->ast == NULL || pCreate->ast[0] == 0) return TSDB_CODE_MND_INVALID_TOPIC;
38,418✔
327
  } else if (pCreate->subType == TOPIC_SUB_TYPE__TABLE) {
11,599✔
328
    if (pCreate->subStbName[0] == 0) return TSDB_CODE_MND_INVALID_TOPIC;
4,992✔
329
  } else if (pCreate->subType == TOPIC_SUB_TYPE__DB) {
6,607✔
330
    if (pCreate->subDbName[0] == 0) return TSDB_CODE_MND_INVALID_TOPIC;
6,607✔
331
  }
332

333
  return 0;
50,017✔
334
}
335

336
static int32_t processAst(SMqTopicObj *topicObj, const char *ast) {
46,724✔
337
  SNode *     pAst = NULL;
46,724✔
338
  SQueryPlan *pPlan = NULL;
46,724✔
339
  int32_t     code = TSDB_CODE_SUCCESS;
46,724✔
340
  int32_t     lino = 0;
46,724✔
341

342
  PRINT_LOG_START
46,724✔
343
  if (ast == NULL) {
46,724✔
344
    topicObj->physicalPlan = taosStrdup("");
7,295✔
345
    goto END;
7,295✔
346
  }
347
  qDebugL("%s topic:%s ast %s", __func__, topicObj->name, ast);
39,429✔
348
  MND_TMQ_RETURN_CHECK(nodesStringToNode(ast, &pAst));
39,429✔
349
  MND_TMQ_RETURN_CHECK(qExtractResultSchema(pAst, &topicObj->schema.nCols, &topicObj->schema.pSchema));
39,429✔
350

351
  SPlanContext cxt = {.pAstRoot = pAst, .topicQuery = true};
39,429✔
352
  MND_TMQ_RETURN_CHECK(qCreateQueryPlan(&cxt, &pPlan, NULL));
39,429✔
353
  if (pPlan == NULL) {
39,429✔
354
    code = TSDB_CODE_MND_INVALID_TOPIC_QUERY;
×
355
    goto END;
×
356
  }
357
  int32_t levelNum = LIST_LENGTH(pPlan->pSubplans);
39,429✔
358
  if (levelNum != 1) {
39,429✔
359
    code = TSDB_CODE_MND_INVALID_TOPIC_QUERY;
×
360
    goto END;
×
361
  }
362

363
  SNodeListNode *pNodeListNode = (SNodeListNode *)nodesListGetNode(pPlan->pSubplans, 0);
39,429✔
364
  MND_TMQ_NULL_CHECK(pNodeListNode);
39,429✔
365
  int32_t opNum = LIST_LENGTH(pNodeListNode->pNodeList);
39,429✔
366
  if (opNum != 1) {
39,429✔
367
    code = TSDB_CODE_MND_INVALID_TOPIC_QUERY;
×
368
    goto END;
×
369
  }
370

371
  code = nodesNodeToString(nodesListGetNode(pNodeListNode->pNodeList, 0), false, &topicObj->physicalPlan, NULL);
39,429✔
372

373
END:
46,724✔
374
  nodesDestroyNode(pAst);
46,724✔
375
  qDestroyQueryPlan(pPlan);
46,724✔
376
  PRINT_LOG_END
46,724✔
377
  return code;
46,724✔
378
}
379

380
static int32_t mndCreateTopic(SMnode *pMnode, SRpcMsg *pReq, SCMCreateTopicReq *pCreate, SDbObj *pDb,
48,459✔
381
                              const char *userName) {
382
  if (pMnode == NULL || pReq == NULL || pCreate == NULL || pDb == NULL || userName == NULL)
48,459✔
383
    return TSDB_CODE_INVALID_PARA;
×
384
  STrans *    pTrans = NULL;
48,459✔
385
  int32_t     code = 0;
48,459✔
386
  int32_t     lino = 0;
48,459✔
387
  SMqTopicObj topicObj = {0};
48,459✔
388

389
  PRINT_LOG_START
48,459✔
390
  mInfo("start to create topic:%s", pCreate->name);
48,459✔
391
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB, pReq, "create-topic");
48,459✔
392
  MND_TMQ_NULL_CHECK(pTrans);
48,459✔
393
  mndTransSetDbName(pTrans, pDb->name, NULL);
48,459✔
394
  MND_TMQ_RETURN_CHECK(mndTransCheckConflict(pMnode, pTrans));
48,459✔
395

396
  tstrncpy(topicObj.name, pCreate->name, TSDB_TOPIC_FNAME_LEN);
48,459✔
397
  tstrncpy(topicObj.db, pDb->name, TSDB_DB_FNAME_LEN);
48,459✔
398
  tstrncpy(topicObj.createUser, userName, TSDB_USER_LEN);
48,459✔
399

400
  MND_TMQ_RETURN_CHECK(mndCheckTopicPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_CREATE_TOPIC, &topicObj));
48,459✔
401

402
  topicObj.createTime = taosGetTimestampMs();
46,724✔
403
  topicObj.updateTime = topicObj.createTime;
46,724✔
404
  topicObj.uid = mndGenerateUid(pCreate->name, strlen(pCreate->name));
46,724✔
405
  topicObj.dbUid = pDb->uid;
46,724✔
406
  topicObj.version = 1;
46,724✔
407
  topicObj.sql = taosStrdup(pCreate->sql);
46,724✔
408
  MND_TMQ_NULL_CHECK(topicObj.sql);
46,724✔
409
  topicObj.sqlLen = strlen(pCreate->sql) + 1;
46,724✔
410
  topicObj.subType = pCreate->subType;
46,724✔
411
  topicObj.withMeta = pCreate->withMeta;
46,724✔
412
  taosInitRWLatch(&topicObj.lock);
46,724✔
413

414
  MND_TMQ_RETURN_CHECK(processAst(&topicObj, pCreate->ast));
46,724✔
415

416
  if (pCreate->subStbName[0] != 0) {
46,724✔
417
    tstrncpy(topicObj.stbName, pCreate->subStbName, TSDB_TABLE_FNAME_LEN);
35,603✔
418
    SStbObj *pStb = mndAcquireStb(pMnode, topicObj.stbName);
35,603✔
419
    MND_TMQ_NULL_CHECK(pStb);
35,603✔
420
    topicObj.stbUid = pStb->uid;
34,629✔
421
    mndReleaseStb(pMnode, pStb);
34,629✔
422
  }
423

424
  SSdbRaw *pCommitRaw = mndTopicActionEncode(&topicObj);
45,750✔
425
  MND_TMQ_NULL_CHECK(pCommitRaw);
45,750✔
426
  code = mndTransAppendCommitlog(pTrans, pCommitRaw);
45,750✔
427
  if (code != 0) {
45,750✔
428
    sdbFreeRaw(pCommitRaw);
×
429
    goto END;
×
430
  }
431

432
  MND_TMQ_RETURN_CHECK(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
45,750✔
433
  MND_TMQ_RETURN_CHECK(mndTransPrepare(pMnode, pTrans));
45,750✔
434

435
END:
48,459✔
436
  PRINT_LOG_END
48,459✔
437
  taosMemoryFreeClear(topicObj.sql);
48,459✔
438
  taosMemoryFreeClear(topicObj.physicalPlan);
48,459✔
439
  if (topicObj.schema.nCols) {
48,459✔
440
    taosMemoryFreeClear(topicObj.schema.pSchema);
39,429✔
441
  }
442
  mndTransDrop(pTrans);
48,459✔
443
  return code;
48,459✔
444
}
445

446
static int32_t mndReloadTopic(SMnode *pMnode, SRpcMsg *pReq, SCMCreateTopicReq *pCreate, SDbObj *pDb,
×
447
                              const char *userName, SMqTopicObj *topicObjOri) {
448
  if (pMnode == NULL || pReq == NULL || pCreate == NULL || pDb == NULL || userName == NULL)
×
449
    return TSDB_CODE_INVALID_PARA;
×
450
  STrans *    pTrans = NULL;
×
451
  int32_t     code = 0;
×
452
  int32_t     lino = 0;
×
453
  SMqTopicObj topicObj = {0};
×
454

455
  PRINT_LOG_START
×
456
  mInfo("start to reload topic:%s", pCreate->name);
×
457
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB, pReq, "reload-topic");
×
458
  MND_TMQ_NULL_CHECK(pTrans);
×
459
  mndTransSetDbName(pTrans, pDb->name, NULL);
×
460
  MND_TMQ_RETURN_CHECK(mndTransCheckConflict(pMnode, pTrans));
×
461

462
  tstrncpy(topicObj.name, pCreate->name, TSDB_TOPIC_FNAME_LEN);
×
463
  tstrncpy(topicObj.db, pDb->name, TSDB_DB_FNAME_LEN);
×
464
  tstrncpy(topicObj.createUser, userName, TSDB_USER_LEN);
×
465

466
  MND_TMQ_RETURN_CHECK(mndCheckTopicPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_CREATE_TOPIC, &topicObj));
×
467

468
  taosRLockLatch(&topicObjOri->lock);
×
469
  topicObj.createTime = topicObjOri->createTime;
×
470
  topicObj.updateTime = taosGetTimestampMs();
×
471
  topicObj.uid = topicObjOri->uid;
×
472
  topicObj.dbUid = pDb->uid;
×
473
  topicObj.version = topicObjOri->version + 1;
×
474
  topicObj.sql = taosStrdup(pCreate->sql);
×
475
  topicObj.sqlLen = strlen(pCreate->sql) + 1;
×
476
  topicObj.subType = pCreate->subType;
×
477
  topicObj.withMeta = pCreate->withMeta;
×
478
  taosInitRWLatch(&topicObj.lock);
×
479
  taosRUnLockLatch(&topicObjOri->lock);
×
480

481
  MND_TMQ_RETURN_CHECK(processAst(&topicObj, pCreate->ast));
×
482

483
  if (pCreate->subStbName[0] != 0) {
×
484
    tstrncpy(topicObj.stbName, pCreate->subStbName, TSDB_TABLE_FNAME_LEN);
×
485
    SStbObj *pStb = mndAcquireStb(pMnode, topicObj.stbName);
×
486
    MND_TMQ_NULL_CHECK(pStb);
×
487
    topicObj.stbUid = pStb->uid;
×
488
    mndReleaseStb(pMnode, pStb);
×
489
  }
490

491
  SSdbRaw *pCommitRaw = mndTopicActionEncode(&topicObj);
×
492
  MND_TMQ_NULL_CHECK(pCommitRaw);
×
493
  code = mndTransAppendCommitlog(pTrans, pCommitRaw);
×
494
  if (code != 0) {
×
495
    sdbFreeRaw(pCommitRaw);
×
496
    goto END;
×
497
  }
498

499
  MND_TMQ_RETURN_CHECK(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
×
500
  MND_TMQ_RETURN_CHECK(mndTransPrepare(pMnode, pTrans));
×
501

502
END:
×
503
  PRINT_LOG_END
×
504
  taosMemoryFreeClear(topicObj.sql);
×
505
  taosMemoryFreeClear(topicObj.physicalPlan);
×
506
  if (topicObj.schema.nCols) {
×
507
    taosMemoryFreeClear(topicObj.schema.pSchema);
×
508
  }
509
  mndTransDrop(pTrans);
×
510
  return code;
×
511
}
512

513
static int32_t creatTopic(SRpcMsg *pReq, SCMCreateTopicReq *createTopicReq) {
50,017✔
514
  SMqTopicObj *pTopic = NULL;
50,017✔
515
  SDbObj *     pDb = NULL;
50,017✔
516
  int32_t      code = TSDB_CODE_SUCCESS;
50,017✔
517
  int32_t      lino = 0;
50,017✔
518
  SMnode *     pMnode = pReq->info.node;
50,017✔
519
  int64_t      tss = taosGetTimestampMs();
50,017✔
520

521
  PRINT_LOG_START
50,017✔
522
  mInfo("topic:%s start to create, sql:%s", createTopicReq->name, createTopicReq->sql);
50,017✔
523
  code = mndAcquireTopic(pMnode, createTopicReq->name, &pTopic);
50,017✔
524
  if (code == TSDB_CODE_SUCCESS) {
50,017✔
525
    mndReleaseTopic(pMnode, pTopic);
214✔
526
    if (createTopicReq->igExists) {
214✔
527
      mInfo("topic:%s already exist, ignore exist is set", createTopicReq->name);
214✔
528
    } else {
529
      code = TSDB_CODE_MND_TOPIC_ALREADY_EXIST;
×
530
    }
531
    goto END;
214✔
532
  } else if (code != TSDB_CODE_MND_TOPIC_NOT_EXIST) {
49,803✔
533
    goto END;
×
534
  }
535

536
  pDb = mndAcquireDb(pMnode, createTopicReq->subDbName);
49,803✔
537
  MND_TMQ_NULL_CHECK(pDb);
49,803✔
538

539
  if (pDb->cfg.walRetentionPeriod == 0) {
48,895✔
540
    code = TSDB_CODE_MND_DB_RETENTION_PERIOD_ZERO;
×
541
    goto END;
×
542
  }
543

544
  if (sdbGetSize(pMnode->pSdb, SDB_TOPIC) >= tmqMaxTopicNum) {
48,895✔
545
    code = TSDB_CODE_TMQ_TOPIC_OUT_OF_RANGE;
436✔
546
    goto END;
436✔
547
  }
548

549
  MND_TMQ_RETURN_CHECK(grantCheck(TSDB_GRANT_SUBSCRIPTION));
48,459✔
550
  MND_TMQ_RETURN_CHECK(mndCreateTopic(pMnode, pReq, createTopicReq, pDb, RPC_MSG_USER(pReq)));
48,459✔
551
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
45,750✔
552
    int64_t tse = taosGetTimestampMs();
45,750✔
553
    double  duration = (double)(tse - tss);
45,750✔
554
    duration = duration / 1000;
45,750✔
555
    auditRecord(pReq, pMnode->clusterId, "createTopic", createTopicReq->subDbName, createTopicReq->name,
45,750✔
556
                createTopicReq->sql, strlen(createTopicReq->sql), duration, 0);
45,750✔
557
  }
558
  code = TSDB_CODE_ACTION_IN_PROGRESS;
45,750✔
559

560
END:
50,017✔
561
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
50,017✔
562
    mError("%s failed, topic:%s since %s", __func__, createTopicReq->name, tstrerror(code));
4,053✔
563
  } else {
564
    mInfo("topic:%s create successfully", createTopicReq->name);
45,964✔
565
  }
566
  mndReleaseDb(pMnode, pDb);
50,017✔
567
  return code;
50,017✔
568
}
569

570
static int32_t reloadTopic(SRpcMsg *pReq, SCMCreateTopicReq *createTopicReq) {
×
571
  SMnode *     pMnode = pReq->info.node;
×
572
  int32_t      code = TSDB_CODE_SUCCESS;
×
573
  int32_t      lino = 0;
×
574
  SDbObj *     pDb = NULL;
×
575
  SMqTopicObj *pTopic = NULL;
×
576
  int64_t      tss = taosGetTimestampMs();
×
577

578
  PRINT_LOG_START
×
579
  code = mndAcquireTopic(pMnode, createTopicReq->name, &pTopic);
×
580
  if (code != 0) {
×
581
    if (createTopicReq->igExists) {
×
582
      mInfo("topic:%s, not exist, ignore not exist is set", createTopicReq->name);
×
583
      code = 0;
×
584
      goto END;
×
585
    } else {
586
      mError("topic:%s, failed to reload since %s", createTopicReq->name, tstrerror(code));
×
587
      goto END;
×
588
    }
589
  }
590

591
  pDb = mndAcquireDb(pMnode, createTopicReq->subDbName);
×
592
  MND_TMQ_NULL_CHECK(pDb);
×
593

594
  MND_TMQ_RETURN_CHECK(grantCheck(TSDB_GRANT_SUBSCRIPTION));
×
595
  MND_TMQ_RETURN_CHECK(mndReloadTopic(pMnode, pReq, createTopicReq, pDb, RPC_MSG_USER(pReq), pTopic));
×
596

597
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
×
598
    int64_t tse = taosGetTimestampMs();
×
599
    double  duration = (double)(tse - tss);
×
600
    duration = duration / 1000;
×
601
    auditRecord(pReq, pMnode->clusterId, "reloadTopic", createTopicReq->subDbName, createTopicReq->name,
×
602
                createTopicReq->sql, strlen(createTopicReq->sql), duration, 0);
×
603
  }
604

605
  code = TSDB_CODE_ACTION_IN_PROGRESS;
×
606

607
  if (topicsToReload == NULL) {
×
608
    topicsToReload = taosHashInit(4, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY), true, HASH_NO_LOCK);
×
609
    MND_TMQ_NULL_CHECK(topicsToReload);
×
610
  }
611
  MND_TMQ_RETURN_CHECK(
×
612
      taosHashPut(topicsToReload, createTopicReq->name, strlen(createTopicReq->name), createTopicReq->name, 1));
613
  mInfo("topic:%s, marked to reload", createTopicReq->name);
×
614

615
END:
×
616
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
×
617
    mError("%s failed, topic:%s since %s", __func__, createTopicReq->name, tstrerror(code));
×
618
  } else {
619
    mInfo("topic:%s create successfully", createTopicReq->name);
×
620
  }
621
  mndReleaseTopic(pMnode, pTopic);
×
622
  mndReleaseDb(pMnode, pDb);
×
623

624
  return code;
×
625
}
626

627
static int32_t mndProcessCreateTopicReq(SRpcMsg *pReq) {
50,017✔
628
  if (pReq == NULL || pReq->contLen <= 0) {
50,017✔
629
    return TSDB_CODE_INVALID_MSG;
×
630
  }
631
  SMnode *pMnode = pReq->info.node;
50,017✔
632
  int32_t code = TSDB_CODE_SUCCESS;
50,017✔
633
  int32_t lino = 0;
50,017✔
634

635
  SCMCreateTopicReq createTopicReq = {0};
50,017✔
636

637
  PRINT_LOG_START
50,017✔
638
  MND_TMQ_RETURN_CHECK(tDeserializeSCMCreateTopicReq(pReq->pCont, pReq->contLen, &createTopicReq));
50,017✔
639

640
  mInfo("topic:%s start to create, sql:%s", createTopicReq.name, createTopicReq.sql);
50,017✔
641

642
  MND_TMQ_RETURN_CHECK(mndCheckCreateTopicReq(&createTopicReq));
50,017✔
643

644
  if (createTopicReq.reload) {
50,017✔
645
    MND_TMQ_RETURN_CHECK(reloadTopic(pReq, &createTopicReq));
×
646
  } else {
647
    MND_TMQ_RETURN_CHECK(creatTopic(pReq, &createTopicReq));
50,017✔
648
  }
649

650
END:
50,014✔
651
  tFreeSCMCreateTopicReq(&createTopicReq);
50,017✔
652
  return code;
50,017✔
653
}
654

655
static int32_t mndDropTopic(SMnode *pMnode, STrans *pTrans, SRpcMsg *pReq, SMqTopicObj *pTopic) {
31,468✔
656
  if (pMnode == NULL || pTrans == NULL || pReq == NULL || pTopic == NULL) {
31,468✔
657
    return TSDB_CODE_INVALID_MSG;
×
658
  }
659
  int32_t  code = 0;
31,468✔
660
  int32_t  lino = 0;
31,468✔
661
  SSdbRaw *pCommitRaw = NULL;
31,468✔
662
  PRINT_LOG_START
31,468✔
663
  MND_TMQ_RETURN_CHECK(mndUserRemoveTopic(pMnode, pTrans, pTopic->name));
31,468✔
664
  pCommitRaw = mndTopicActionEncode(pTopic);
31,468✔
665
  MND_TMQ_NULL_CHECK(pCommitRaw);
31,468✔
666
  code = mndTransAppendCommitlog(pTrans, pCommitRaw);
31,468✔
667
  if (code != 0) {
31,468✔
668
    sdbFreeRaw(pCommitRaw);
×
669
    goto END;
×
670
  }
671
  MND_TMQ_RETURN_CHECK(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
31,468✔
672
  MND_TMQ_RETURN_CHECK(mndTransPrepare(pMnode, pTrans));
31,468✔
673

674
END:
31,468✔
675
  PRINT_LOG_END
31,468✔
676
  return code;
31,468✔
677
}
678

679
bool checkTopic(SArray *topics, char *topicName) {
29,631✔
680
  if (topics == NULL || topicName == NULL) {
29,631✔
681
    return false;
×
682
  }
683
  int32_t sz = taosArrayGetSize(topics);
29,631✔
684
  for (int32_t i = 0; i < sz; i++) {
30,103✔
685
    char *name = taosArrayGetP(topics, i);
978✔
686
    if (name && strcmp(name, topicName) == 0) {
978✔
687
      return true;
506✔
688
    }
689
  }
690
  return false;
29,125✔
691
}
692

693
static int32_t checkConsumer(STrans *pTrans, SMqConsumerObj *pConsumer, bool deleteConsumer, char *topicName) {
9,827✔
694
  int32_t         code = 0;
9,827✔
695
  int32_t         lino = 0;
9,827✔
696
  SMqConsumerObj *pConsumerNew = NULL;
9,827✔
697

698
  taosRLockLatch(&pConsumer->lock);
9,827✔
699
  bool found1 = checkTopic(pConsumer->assignedTopics, topicName);
9,827✔
700
  bool found2 = checkTopic(pConsumer->rebRemovedTopics, topicName);
9,827✔
701
  bool found3 = checkTopic(pConsumer->rebNewTopics, topicName);
9,827✔
702
  if (found1 || found2 || found3) {
9,827✔
703
    if (deleteConsumer) {
478✔
704
      MND_TMQ_RETURN_CHECK(tNewSMqConsumerObj(pConsumer->consumerId, pConsumer->cgroup, CONSUMER_CLEAR, NULL, NULL, &pConsumerNew));
478✔
705
      MND_TMQ_RETURN_CHECK(mndSetConsumerDropLogs(pTrans, pConsumerNew));
478✔
706
      tDeleteSMqConsumerObj(pConsumerNew);
478✔
707
      pConsumerNew = NULL;
478✔
708
    } else {
709
      mError("topic:%s, failed to drop since subscribed by consumer:0x%" PRIx64 ", in consumer group %s", topicName,
×
710
             pConsumer->consumerId, pConsumer->cgroup);
711
      code = TSDB_CODE_MND_TOPIC_SUBSCRIBED;
×
712
      goto END;
×
713
    }
714
  }
715
END:
9,827✔
716
  taosRUnLockLatch(&pConsumer->lock);
9,827✔
717
  tDeleteSMqConsumerObj(pConsumerNew);
9,827✔
718
  return code;
9,827✔
719
}
720

721
static int32_t mndCheckConsumerByTopic(SMnode *pMnode, STrans *pTrans, char *topicName, bool deleteConsumer) {
31,468✔
722
  if (pMnode == NULL || pTrans == NULL || topicName == NULL) {
31,468✔
723
    return TSDB_CODE_INVALID_MSG;
×
724
  }
725
  int32_t         code = 0;
31,468✔
726
  int32_t         lino = 0;
31,468✔
727
  SSdb *          pSdb = pMnode->pSdb;
31,468✔
728
  void *          pIter = NULL;
31,468✔
729
  SMqConsumerObj *pConsumer = NULL;
31,468✔
730

731
  PRINT_LOG_START
31,468✔
732
  while (1) {
733
    pIter = sdbFetch(pSdb, SDB_CONSUMER, pIter, (void **)&pConsumer);
41,295✔
734
    if (pIter == NULL) {
41,295✔
735
      break;
31,468✔
736
    }
737

738
    MND_TMQ_RETURN_CHECK(checkConsumer(pTrans, pConsumer, deleteConsumer, topicName));
9,827✔
739
    sdbRelease(pSdb, pConsumer);
9,827✔
740
  }
741

742
END:
31,468✔
743
  PRINT_LOG_END
31,468✔
744
  sdbRelease(pSdb, pConsumer);
31,468✔
745
  sdbCancelFetch(pSdb, pIter);
31,468✔
746
  return code;
31,468✔
747
}
748

749
static int32_t mndProcessDropTopicReq(SRpcMsg *pReq) {
36,889✔
750
  if (pReq == NULL) {
36,889✔
751
    return TSDB_CODE_INVALID_MSG;
×
752
  }
753
  SMnode *       pMnode = pReq->info.node;
36,889✔
754
  SMDropTopicReq dropReq = {0};
36,889✔
755
  int32_t        code = 0;
36,889✔
756
  int32_t        lino = 0;
36,889✔
757
  SMqTopicObj *  pTopic = NULL;
36,889✔
758
  STrans *       pTrans = NULL;
36,889✔
759
  int64_t        tss = taosGetTimestampMs();
36,889✔
760

761
  PRINT_LOG_START
36,889✔
762
  MND_TMQ_RETURN_CHECK(tDeserializeSMDropTopicReq(pReq->pCont, pReq->contLen, &dropReq));
36,889✔
763

764
  code = mndAcquireTopic(pMnode, dropReq.name, &pTopic);
36,889✔
765
  if (code != 0) {
36,889✔
766
    if (dropReq.igNotExists) {
2,314✔
767
      mInfo("topic:%s, not exist, ignore not exist is set", dropReq.name);
2,314✔
768
      code = 0;
2,314✔
769
    }
770
    goto END;
2,314✔
771
  }
772
  taosRLockLatch(&pTopic->lock);
34,575✔
773

774
  pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_DB, pReq, "drop-topic");
34,575✔
775
  MND_TMQ_NULL_CHECK(pTrans);
34,575✔
776

777
  mndTransSetDbName(pTrans, pTopic->db, NULL);
34,575✔
778
  MND_TMQ_RETURN_CHECK(mndTransCheckConflict(pMnode, pTrans));
34,575✔
779
  mInfo("trans:%d, used to drop topic:%s, force:%d", pTrans->id, pTopic->name, dropReq.force);
34,575✔
780

781
  MND_TMQ_RETURN_CHECK(mndCheckTopicPrivilege(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_DROP_TOPIC, pTopic));
34,575✔
782
  MND_TMQ_RETURN_CHECK(mndCheckDbPrivilegeByName(pMnode, RPC_MSG_USER(pReq), RPC_MSG_TOKEN(pReq), MND_OPER_READ_DB, pTopic->db));
31,468✔
783
  MND_TMQ_RETURN_CHECK(mndCheckConsumerByTopic(pMnode, pTrans, dropReq.name, dropReq.force));
31,468✔
784
  MND_TMQ_RETURN_CHECK(mndDropSubByTopic(pMnode, pTrans, dropReq.name, dropReq.force));
31,468✔
785
  MND_TMQ_RETURN_CHECK(mndDropTopic(pMnode, pTrans, pReq, pTopic));
31,468✔
786
  if (tsAuditLevel >= AUDIT_LEVEL_DATABASE) {
31,468✔
787
    int64_t tse = taosGetTimestampMs();
31,468✔
788
    double  duration = (double)(tse - tss);
31,468✔
789
    duration = duration / 1000;
31,468✔
790
    auditRecord(pReq, pMnode->clusterId, "dropTopic", pTopic->db, dropReq.name, dropReq.sql, dropReq.sqlLen, duration,
31,468✔
791
                0);
792
  }
793

794
  code = TSDB_CODE_ACTION_IN_PROGRESS;
31,468✔
795

796
END:
36,889✔
797
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
36,889✔
798
    mError("%s failed, topic:%s since %s", __func__, dropReq.name, tstrerror(code));
3,107✔
799
  } else {
800
    mInfo("topic:%s dropped successfully", dropReq.name);
33,782✔
801
  }
802
  if (pTopic != NULL) {
36,889✔
803
    taosRUnLockLatch(&pTopic->lock);
34,575✔
804
  }
805
  mndReleaseTopic(pMnode, pTopic);
36,889✔
806
  mndTransDrop(pTrans);
36,889✔
807
  tFreeSMDropTopicReq(&dropReq);
36,889✔
808
  return code;
36,889✔
809
}
810

811
int32_t mndGetNumOfTopics(SMnode *pMnode, char *dbName, int32_t *pNumOfTopics) {
108,818✔
812
  if (pMnode == NULL || dbName == NULL || pNumOfTopics == NULL) {
108,818✔
813
    return TSDB_CODE_INVALID_MSG;
×
814
  }
815
  *pNumOfTopics = 0;
108,818✔
816

817
  SSdb *  pSdb = pMnode->pSdb;
108,818✔
818
  SDbObj *pDb = mndAcquireDb(pMnode, dbName);
108,818✔
819
  if (pDb == NULL) {
108,818✔
820
    return TSDB_CODE_MND_DB_NOT_SELECTED;
×
821
  }
822

823
  int32_t numOfTopics = 0;
108,818✔
824
  void *  pIter = NULL;
108,818✔
825
  while (1) {
×
826
    SMqTopicObj *pTopic = NULL;
108,818✔
827
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
108,818✔
828
    if (pIter == NULL) {
108,818✔
829
      break;
108,818✔
830
    }
831
    taosRLockLatch(&pTopic->lock);
×
832
    if (pTopic->dbUid == pDb->uid) {
×
833
      numOfTopics++;
×
834
    }
835
    taosRUnLockLatch(&pTopic->lock);
×
836

837
    sdbRelease(pSdb, pTopic);
×
838
  }
839

840
  *pNumOfTopics = numOfTopics;
108,818✔
841
  mndReleaseDb(pMnode, pDb);
108,818✔
842
  return 0;
108,818✔
843
}
844

845
static void schemaToJson(SSchema *schema, int32_t nCols, char *schemaJson) {
33,401✔
846
  if (schema == NULL || schemaJson == NULL) {
33,401✔
847
    return;
×
848
  }
849
  char *  string = NULL;
33,401✔
850
  int32_t code = 0;
33,401✔
851
  int32_t lino = 0;
33,401✔
852

853
  cJSON *cbytes = NULL;
33,401✔
854
  cJSON *ctype = NULL;
33,401✔
855
  cJSON *cname = NULL;
33,401✔
856
  cJSON *column = NULL;
33,401✔
857
  cJSON *columns = cJSON_CreateArray();
33,401✔
858
  MND_TMQ_NULL_CHECK(columns);
33,401✔
859
  for (int i = 0; i < nCols; i++) {
365,891✔
860
    column = cJSON_CreateObject();
332,490✔
861
    MND_TMQ_NULL_CHECK(column);
332,490✔
862
    SSchema *s = schema + i;
332,490✔
863
    cname = cJSON_CreateString(s->name);
332,490✔
864
    MND_TMQ_NULL_CHECK(cname);
332,490✔
865
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToObject(column, "name", cname), 0);
332,490✔
866
    cname = NULL;  // ownership transferred to column object
332,490✔
867

868
    ctype = cJSON_CreateString(tDataTypes[s->type].name);
332,490✔
869
    MND_TMQ_NULL_CHECK(ctype);
332,490✔
870
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToObject(column, "type", ctype), 0);
332,490✔
871
    ctype = NULL;  // ownership transferred to column object
332,490✔
872

873
    int32_t length = 0;
332,490✔
874
    if (s->type == TSDB_DATA_TYPE_BINARY || s->type == TSDB_DATA_TYPE_VARBINARY || s->type == TSDB_DATA_TYPE_GEOMETRY) {
332,490✔
875
      length = s->bytes - VARSTR_HEADER_SIZE;
70,295✔
876
    } else if (s->type == TSDB_DATA_TYPE_NCHAR || s->type == TSDB_DATA_TYPE_JSON) {
262,195✔
877
      length = (s->bytes - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE;
26,630✔
878
    } else {
879
      length = s->bytes;
235,565✔
880
    }
881
    cbytes = cJSON_CreateNumber(length);
332,490✔
882
    MND_TMQ_NULL_CHECK(cbytes);
332,490✔
883
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToObject(column, "length", cbytes), 0);
332,490✔
884
    cbytes = NULL;  // ownership transferred to column object
332,490✔
885

886
    MND_TMQ_CONDITION_CHECK(cJSON_AddItemToArray(columns, column), 0);
332,490✔
887
    column = NULL;  // ownership transferred to columns array
332,490✔
888
  }
889

890
END:
33,401✔
891
  string = cJSON_PrintUnformatted(columns);
33,401✔
892
  cJSON_Delete(columns);
33,401✔
893
  cJSON_Delete(column);
33,401✔
894
  cJSON_Delete(cname);
33,401✔
895
  cJSON_Delete(ctype);
33,401✔
896
  cJSON_Delete(cbytes);
33,401✔
897

898
  size_t len = strlen(string);
33,401✔
899
  if (string && len <= TSDB_SHOW_SCHEMA_JSON_LEN) {
33,401✔
900
    STR_TO_VARSTR(schemaJson, string);
33,401✔
901
  } else {
902
    mError("mndRetrieveTopic build schema error json:%p, json len:%zu", string, len);
×
903
    STR_TO_VARSTR(schemaJson, "NULL");
×
904
  }
905
  taosMemoryFree(string);
33,401✔
906
}
907

908
static int32_t buildResult(SMqTopicObj *pTopic, int32_t *numOfRows, SMnode *pMnode, SSDataBlock *pBlock) {
34,841✔
909
  SColumnInfoData *pColInfo = NULL;
34,841✔
910
  SName            n = {0};
34,841✔
911
  int32_t          cols = 0;
34,841✔
912
  char *           schemaJson = NULL;
34,841✔
913
  char *           sql = NULL;
34,841✔
914
  int32_t          code = 0;
34,841✔
915
  int32_t          lino = 0;
34,841✔
916

917
  taosRLockLatch(&pTopic->lock);
34,841✔
918

919
  char        topicName[TSDB_TOPIC_NAME_LEN + VARSTR_HEADER_SIZE + 5] = {0};
34,841✔
920
  const char *pName = mndGetDbStr(pTopic->name);
34,841✔
921
  STR_TO_VARSTR(topicName, pName);
34,841✔
922

923
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,841✔
924
  MND_TMQ_NULL_CHECK(pColInfo);
34,841✔
925
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)topicName, false));
34,841✔
926

927
  char dbName[TSDB_DB_NAME_LEN + VARSTR_HEADER_SIZE] = {0};
34,841✔
928
  MND_TMQ_RETURN_CHECK(tNameFromString(&n, pTopic->db, T_NAME_ACCT | T_NAME_DB));
34,841✔
929
  MND_TMQ_RETURN_CHECK(tNameGetDbName(&n, varDataVal(dbName)));
34,841✔
930
  varDataSetLen(dbName, strlen(varDataVal(dbName)));
34,841✔
931

932
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,841✔
933
  MND_TMQ_NULL_CHECK(pColInfo);
34,841✔
934
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)dbName, false));
34,841✔
935

936
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,841✔
937
  MND_TMQ_NULL_CHECK(pColInfo);
34,841✔
938
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)&pTopic->createTime, false));
34,841✔
939

940
  sql = taosMemoryMalloc(strlen(pTopic->sql) + VARSTR_HEADER_SIZE);
34,841✔
941
  MND_TMQ_NULL_CHECK(sql);
34,841✔
942
  STR_TO_VARSTR(sql, pTopic->sql);
34,841✔
943

944
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,841✔
945
  MND_TMQ_NULL_CHECK(pColInfo);
34,841✔
946
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)sql, false));
34,841✔
947

948
  taosMemoryFreeClear(sql);
34,841✔
949

950
  schemaJson = taosMemoryMalloc(TSDB_SHOW_SCHEMA_JSON_LEN + VARSTR_HEADER_SIZE);
34,841✔
951
  MND_TMQ_NULL_CHECK(schemaJson);
34,841✔
952
  if (pTopic->subType == TOPIC_SUB_TYPE__COLUMN) {
34,841✔
953
    schemaToJson(pTopic->schema.pSchema, pTopic->schema.nCols, schemaJson);
33,311✔
954
  } else if (pTopic->subType == TOPIC_SUB_TYPE__TABLE) {
1,530✔
955
    SStbObj *pStb = mndAcquireStb(pMnode, pTopic->stbName);
90✔
956
    if (pStb == NULL) {
90✔
957
      STR_TO_VARSTR(schemaJson, "NULL");
×
958
      mError("mndRetrieveTopic mndAcquireStb null stbName:%s", pTopic->stbName);
×
959
    } else {
960
      schemaToJson(pStb->pColumns, pStb->numOfColumns, schemaJson);
90✔
961
      mndReleaseStb(pMnode, pStb);
90✔
962
    }
963
  } else {
964
    STR_TO_VARSTR(schemaJson, "NULL");
1,440✔
965
  }
966

967
  pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,841✔
968
  MND_TMQ_NULL_CHECK(pColInfo);
34,841✔
969
  MND_TMQ_RETURN_CHECK(colDataSetVal(pColInfo, *numOfRows, (const char *)schemaJson, false));
34,841✔
970
  taosMemoryFreeClear(schemaJson);
34,841✔
971

972
  (*numOfRows)++;
34,841✔
973

974
END:
34,841✔
975
  taosRUnLockLatch(&pTopic->lock);
34,841✔
976

977
  taosMemoryFreeClear(sql);
34,841✔
978
  taosMemoryFreeClear(schemaJson);
34,841✔
979
  return code;
34,841✔
980
}
981

982
static int32_t mndRetrieveTopic(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rowsCapacity) {
26,044✔
983
  if (pReq == NULL || pShow == NULL || pBlock == NULL) {
26,044✔
984
    return TSDB_CODE_INVALID_MSG;
×
985
  }
986
  SMnode *     pMnode = pReq->info.node;
26,044✔
987
  SSdb *       pSdb = pMnode->pSdb;
26,044✔
988
  int32_t      numOfRows = 0;
26,044✔
989
  SMqTopicObj *pTopic = NULL;
26,044✔
990
  int32_t      code = 0;
26,044✔
991
  int32_t      lino = 0;
26,044✔
992
  PRINT_LOG_START
26,044✔
993

994
  while (numOfRows < rowsCapacity) {
60,885✔
995
    pShow->pIter = sdbFetch(pSdb, SDB_TOPIC, pShow->pIter, (void **)&pTopic);
60,885✔
996
    if (pShow->pIter == NULL) break;
60,885✔
997

998
    MND_TMQ_RETURN_CHECK(buildResult(pTopic, &numOfRows, pMnode, pBlock));
34,841✔
999
    sdbRelease(pSdb, pTopic);
34,841✔
1000
    pTopic = NULL;
34,841✔
1001
  }
1002

1003
  pShow->numOfRows += numOfRows;
26,044✔
1004

1005
END:
26,044✔
1006
  sdbCancelFetch(pSdb, pShow->pIter);
26,044✔
1007
  sdbRelease(pSdb, pTopic);
26,044✔
1008
  if (code != TSDB_CODE_SUCCESS) {
26,044✔
1009
    mError("%s failed since %s", __func__, tstrerror(code));
×
1010
    return code;
×
1011
  } else {
1012
    mDebug("%s retrieved %d rows successfully", __func__, numOfRows);
26,044✔
1013
    return numOfRows;
26,044✔
1014
  }
1015
}
1016

1017
static void mndCancelGetNextTopic(SMnode *pMnode, void *pIter) {
×
1018
  if (pMnode == NULL) return;
×
1019
  SSdb *pSdb = pMnode->pSdb;
×
1020
  sdbCancelFetchByType(pSdb, pIter, SDB_TOPIC);
×
1021
}
1022

1023
bool mndTopicExistsForDb(SMnode *pMnode, SDbObj *pDb) {
715,815✔
1024
  if (pMnode == NULL || pDb == NULL) {
715,815✔
1025
    return false;
×
1026
  }
1027
  SSdb *       pSdb = pMnode->pSdb;
715,815✔
1028
  void *       pIter = NULL;
715,815✔
1029
  SMqTopicObj *pTopic = NULL;
715,815✔
1030

1031
  while (1) {
3,602✔
1032
    pIter = sdbFetch(pSdb, SDB_TOPIC, pIter, (void **)&pTopic);
719,417✔
1033
    if (pIter == NULL) {
719,417✔
1034
      break;
715,706✔
1035
    }
1036

1037
    taosRLockLatch(&pTopic->lock);
3,711✔
1038
    bool found = pTopic->dbUid == pDb->uid;
3,711✔
1039
    taosRUnLockLatch(&pTopic->lock);
3,711✔
1040

1041
    if (found) {
3,711✔
1042
      sdbRelease(pSdb, pTopic);
109✔
1043
      sdbCancelFetch(pSdb, pIter);
109✔
1044
      return true;
109✔
1045
    }
1046

1047
    sdbRelease(pSdb, pTopic);
3,602✔
1048
  }
1049

1050
  return false;
715,706✔
1051
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc