• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4896

24 Dec 2025 07:36AM UTC coverage: 65.929% (+0.4%) from 65.513%
#4896

push

travis-ci

web-flow
enh: [TS-7591] Some code refactor and add more log. (#34022)

326 of 537 new or added lines in 4 files covered. (60.71%)

370 existing lines in 111 files now uncovered.

185828 of 281861 relevant lines covered (65.93%)

116309824.55 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

74.49
/source/util/src/tjson.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17

18
#include "tjson.h"
19
#include "cJSON.h"
20
#include "taoserror.h"
21

22
SJson* tjsonCreateObject() {
2,147,483,647✔
23
  SJson* pJson = cJSON_CreateObject();
2,147,483,647✔
24
  if (pJson == NULL) {
2,147,483,647✔
25
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
26
  }
27
  return pJson;
2,147,483,647✔
28
}
29

30
SJson* tjsonCreateArray() {
31,895,916✔
31
  SJson* pJson = cJSON_CreateArray();
31,895,916✔
32
  if (pJson == NULL) {
31,899,842✔
33
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
34
  }
35
  return pJson;
31,903,589✔
36
}
37

38
void tjsonDelete(SJson* pJson) {
628,759,419✔
39
  if (pJson != NULL) {
628,759,419✔
40
    cJSON_Delete((cJSON*)pJson);
628,759,975✔
41
  }
42
}
628,756,270✔
43

44
int32_t tjsonAddIntegerToObject(SJson* pJson, const char* pName, const uint64_t number) {
2,147,483,647✔
45
  char tmp[40] = {0};
2,147,483,647✔
46
  snprintf(tmp, sizeof(tmp), "%" PRId64, number);
2,147,483,647✔
47
  return tjsonAddStringToObject(pJson, pName, tmp);
2,147,483,647✔
48
}
49

50
int32_t tjsonAddDoubleToObject(SJson* pJson, const char* pName, const double number) {
339,962,274✔
51
  if (NULL == cJSON_AddNumberToObject((cJSON*)pJson, pName, number)) {
339,962,274✔
52
    return terrno = TSDB_CODE_OUT_OF_MEMORY;
108✔
53
  }
54

55
  return TSDB_CODE_SUCCESS;
339,963,164✔
56
}
57

58
int32_t tjsonAddBoolToObject(SJson* pJson, const char* pName, const bool boolean) {
2,147,483,647✔
59
  if (NULL == cJSON_AddBoolToObject((cJSON*)pJson, pName, boolean)) {
2,147,483,647✔
60
    return terrno = TSDB_CODE_OUT_OF_MEMORY;
837✔
61
  }
62

63
  return TSDB_CODE_SUCCESS;
2,147,483,647✔
64
}
65

66
int32_t tjsonAddStringToObject(SJson* pJson, const char* pName, const char* pVal) {
2,147,483,647✔
67
  if (NULL == cJSON_AddStringToObject((cJSON*)pJson, pName, pVal)) {
2,147,483,647✔
UNCOV
68
    return terrno = TSDB_CODE_OUT_OF_MEMORY;
×
69
  }
70

71
  return TSDB_CODE_SUCCESS;
2,147,483,647✔
72
}
73

74
SJson* tjsonAddArrayToObject(SJson* pJson, const char* pName) {
2,147,483,647✔
75
  SJson* ret = (SJson*)cJSON_AddArrayToObject((cJSON*)pJson, pName);
2,147,483,647✔
76
  if (ret == NULL) {
2,147,483,647✔
77
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
78
  }
79
  return ret;
2,147,483,647✔
80
}
81

82
int32_t tjsonAddItemToObject(SJson* pJson, const char* pName, SJson* pItem) {
2,147,483,647✔
83
  if (cJSON_AddItemToObject((cJSON*)pJson, pName, pItem)) {
2,147,483,647✔
84
    return TSDB_CODE_SUCCESS;
2,147,483,647✔
85
  }
86

87
  return terrno = TSDB_CODE_OUT_OF_MEMORY;
×
88
}
89

90
int32_t tjsonAddItemToArray(SJson* pJson, SJson* pItem) {
2,147,483,647✔
91
  if (cJSON_AddItemToArray((cJSON*)pJson, pItem)) {
2,147,483,647✔
92
    return TSDB_CODE_SUCCESS;
2,147,483,647✔
93
  }
94

95
  return terrno = TSDB_CODE_OUT_OF_MEMORY;
×
96
}
97

98
int32_t tjsonAddObject(SJson* pJson, const char* pName, FToJson func, const void* pObj) {
2,147,483,647✔
99
  if (NULL == pObj) {
2,147,483,647✔
100
    return TSDB_CODE_SUCCESS;
2,147,483,647✔
101
  }
102

103
  SJson* pJobj = tjsonCreateObject();
2,147,483,647✔
104
  if (NULL == pJobj) {
2,147,483,647✔
105
    return terrno;
×
106
  }
107
  int32_t rc = func(pObj, pJobj);
2,147,483,647✔
108
  if (rc != TSDB_CODE_SUCCESS) {
2,147,483,647✔
109
    tjsonDelete(pJobj);
×
110
    return rc;
×
111
  }
112
  return tjsonAddItemToObject(pJson, pName, pJobj);
2,147,483,647✔
113
}
114

115
int32_t tjsonAddItem(SJson* pJson, FToJson func, const void* pObj) {
2,147,483,647✔
116
  SJson* pJobj = tjsonCreateObject();
2,147,483,647✔
117
  if (pJobj == NULL) {
2,147,483,647✔
118
    return terrno;
×
119
  }
120

121
  int32_t rc = func(pObj, pJobj);
2,147,483,647✔
122
  if (rc != TSDB_CODE_SUCCESS) {
2,147,483,647✔
123
    tjsonDelete(pJobj);
×
124
    return rc;
×
125
  }
126
  return tjsonAddItemToArray(pJson, pJobj);
2,147,483,647✔
127
}
128

129
int32_t tjsonAddArray(SJson* pJson, const char* pName, FToJson func, const void* pArray, int32_t itemSize,
743,763,996✔
130
                      int32_t num) {
131
  if (num > 0) {
743,763,996✔
132
    SJson* pJsonArray = tjsonAddArrayToObject(pJson, pName);
705,962,290✔
133
    if (NULL == pJsonArray) {
705,961,077✔
134
      return terrno;
319✔
135
    }
136
    for (size_t i = 0; i < num; ++i) {
1,460,482,986✔
137
      int32_t code = tjsonAddItem(pJsonArray, func, (const char*)pArray + itemSize * i);
754,521,341✔
138
      if (TSDB_CODE_SUCCESS != code) {
754,522,157✔
139
        return code;
×
140
      }
141
    }
142
  }
143
  return TSDB_CODE_SUCCESS;
743,763,351✔
144
}
145

146
int32_t tjsonAddTArray(SJson* pJson, const char* pName, FToJson func, const SArray* pArray) {
761,607✔
147
  int32_t num = taosArrayGetSize(pArray);
761,607✔
148
  if (num > 0) {
761,607✔
149
    SJson* pJsonArray = tjsonAddArrayToObject(pJson, pName);
×
150
    if (NULL == pJsonArray) {
×
151
      return terrno;
×
152
    }
153
    for (int32_t i = 0; i < num; ++i) {
×
154
      int32_t code = tjsonAddItem(pJsonArray, func, taosArrayGet(pArray, i));
×
155
      if (TSDB_CODE_SUCCESS != code) {
×
156
        return code;
×
157
      }
158
    }
159
  }
160
  return TSDB_CODE_SUCCESS;
761,607✔
161
}
162

163
char* tjsonToString(const SJson* pJson) {
38,136,142✔
164
  char* p = cJSON_Print((cJSON*)pJson);
38,136,142✔
165
  if (!p) {
38,136,931✔
166
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
167
  }
168
  return p;
38,136,931✔
169
}
170

171
char* tjsonToUnformattedString(const SJson* pJson) {
579,416,501✔
172
  char* p = cJSON_PrintUnformatted((cJSON*)pJson);
579,416,501✔
173
  if (!p) {
579,416,594✔
174
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
175
  }
176
  return p;
579,416,501✔
177
}
178

179
SJson* tjsonGetObjectItem(const SJson* pJson, const char* pName) { return cJSON_GetObjectItem(pJson, pName); }
2,147,483,647✔
180

181
int32_t tjsonGetObjectName(const SJson* pJson, char** pName) {
200✔
182
  *pName = ((cJSON*)pJson)->string;
200✔
183
  if (NULL == *pName) {
200✔
184
    return TSDB_CODE_FAILED;
×
185
  }
186
  return TSDB_CODE_SUCCESS;
200✔
187
}
188

189
int32_t tjsonGetObjectValueString(const SJson* pJson, char** pValueString) {
200✔
190
  *pValueString = ((cJSON*)pJson)->valuestring;
200✔
191
  if (NULL == *pValueString) {
200✔
192
    return TSDB_CODE_FAILED;
×
193
  }
194
  return TSDB_CODE_SUCCESS;
200✔
195
}
196

197
void tjsonGetObjectValueBigInt(const SJson* pJson, int64_t* pVal) { *pVal = (int64_t)((cJSON*)pJson)->valuedouble; }
×
198

199
void tjsonGetObjectValueDouble(const SJson* pJson, double* pVal) { *pVal = ((cJSON*)pJson)->valuedouble; }
×
200

201
int32_t tjsonGetStringValue(const SJson* pJson, const char* pName, char* pVal) {
413,140,942✔
202
  char* p = cJSON_GetStringValue(tjsonGetObjectItem((cJSON*)pJson, pName));
413,140,942✔
203
  if (NULL == p) {
413,162,188✔
204
    return TSDB_CODE_SUCCESS;
×
205
  }
206
  strcpy(pVal, p);
413,162,188✔
207
  return TSDB_CODE_SUCCESS;
413,162,188✔
208
}
209

210
int32_t tjsonGetStringValue2(const SJson* pJson, const char* pName, char* pVal, int32_t maxLen) {
1,290✔
211
  char* p = cJSON_GetStringValue(tjsonGetObjectItem((cJSON*)pJson, pName));
1,290✔
212
  if (NULL == p) {
1,290✔
213
    return TSDB_CODE_SUCCESS;
×
214
  }
215
  int32_t len = strlen(p);
1,290✔
216
  if (len >= maxLen - 1) {
1,290✔
217
    return TSDB_CODE_OUT_OF_MEMORY;
×
218
  }
219
  strcpy(pVal, p);
1,290✔
220
  return TSDB_CODE_SUCCESS;
1,290✔
221
}
222

223
int32_t tjsonDupStringValue(const SJson* pJson, const char* pName, char** pVal) {
10,818,189✔
224
  char* p = cJSON_GetStringValue(tjsonGetObjectItem((cJSON*)pJson, pName));
10,818,189✔
225
  if (NULL == p) {
10,818,189✔
226
    return TSDB_CODE_SUCCESS;
1,816,001✔
227
  }
228
  *pVal = taosStrdup(p);
9,002,188✔
229
  return TSDB_CODE_SUCCESS;
9,002,188✔
230
}
231

232
int32_t tjsonGetBigIntValue(const SJson* pJson, const char* pName, int64_t* pVal) {
1,357,686,832✔
233
  char* p = cJSON_GetStringValue(tjsonGetObjectItem((cJSON*)pJson, pName));
1,357,686,832✔
234
  if (NULL == p) {
1,358,001,227✔
235
    return TSDB_CODE_SUCCESS;
11,133,649✔
236
  }
237
#ifdef WINDOWS
238
  sscanf(p, "%" PRId64, pVal);
239
#else
240
  *pVal = taosStr2Int64(p, NULL, 10);
1,346,867,578✔
241
#endif
242
  return TSDB_CODE_SUCCESS;
1,346,725,430✔
243
}
244

245
int32_t tjsonGetIntValue(const SJson* pJson, const char* pName, int32_t* pVal) {
479,566,159✔
246
  int64_t val = 0;
479,566,159✔
247
  int32_t code = tjsonGetBigIntValue(pJson, pName, &val);
479,567,864✔
248
  *pVal = val;
479,553,804✔
249
  return code;
479,556,047✔
250
}
251

252
int32_t tjsonGetSmallIntValue(const SJson* pJson, const char* pName, int16_t* pVal) {
245,433,269✔
253
  int64_t val = 0;
245,433,269✔
254
  int32_t code = tjsonGetBigIntValue(pJson, pName, &val);
245,272,805✔
255
  *pVal = val;
245,436,298✔
256
  return code;
245,437,835✔
257
}
258

259
int32_t tjsonGetTinyIntValue(const SJson* pJson, const char* pName, int8_t* pVal) {
71,027,780✔
260
  int64_t val = 0;
71,027,780✔
261
  int32_t code = tjsonGetBigIntValue(pJson, pName, &val);
71,027,924✔
262
  *pVal = val;
71,028,016✔
263
  return code;
71,028,016✔
264
}
265

266
int32_t tjsonGetUBigIntValue(const SJson* pJson, const char* pName, uint64_t* pVal) {
377,232,096✔
267
  char* p = cJSON_GetStringValue(tjsonGetObjectItem((cJSON*)pJson, pName));
377,232,096✔
268
  if (NULL == p) {
377,235,861✔
269
    return TSDB_CODE_SUCCESS;
×
270
  }
271
#ifdef WINDOWS
272
  sscanf(p, "%" PRIu64, pVal);
273
#else
274
  *pVal = taosStr2UInt64(p, NULL, 10);
377,235,861✔
275
#endif
276
  return TSDB_CODE_SUCCESS;
377,232,896✔
277
}
278

279
int32_t tjsonGetUIntValue(const SJson* pJson, const char* pName, uint32_t* pVal) {
2,030,048✔
280
  uint64_t val = 0;
2,030,048✔
281
  int32_t  code = tjsonGetUBigIntValue(pJson, pName, &val);
2,030,048✔
282
  *pVal = val;
2,030,048✔
283
  return code;
2,030,048✔
284
}
285

286
int32_t tjsonGetUTinyIntValue(const SJson* pJson, const char* pName, uint8_t* pVal) {
334,921,473✔
287
  uint64_t val = 0;
334,921,473✔
288
  int32_t  code = tjsonGetUBigIntValue(pJson, pName, &val);
334,925,458✔
289
  *pVal = val;
334,936,099✔
290
  return code;
334,936,171✔
291
}
292

293
int32_t tjsonGetBoolValue(const SJson* pJson, const char* pName, bool* pVal) {
384,676,064✔
294
  const SJson* pObject = tjsonGetObjectItem(pJson, pName);
384,676,064✔
295
  if (NULL == pObject) {
384,686,397✔
296
    return TSDB_CODE_SUCCESS;
×
297
  }
298
  if (!cJSON_IsBool(pObject)) {
384,686,397✔
299
    return TSDB_CODE_FAILED;
×
300
  }
301
  *pVal = cJSON_IsTrue(pObject) ? true : false;
384,683,898✔
302
  return TSDB_CODE_SUCCESS;
384,688,857✔
303
}
304

305
int32_t tjsonGetDoubleValue(const SJson* pJson, const char* pName, double* pVal) {
24,446,356✔
306
  const SJson* pObject = tjsonGetObjectItem(pJson, pName);
24,446,356✔
307
  if (NULL == pObject) {
24,450,242✔
308
    return TSDB_CODE_SUCCESS;
1,197,096✔
309
  }
310
  if (!cJSON_IsNumber(pObject)) {
23,253,146✔
311
    return TSDB_CODE_FAILED;
×
312
  }
313
  *pVal = cJSON_GetNumberValue(pObject);
23,253,962✔
314
  return TSDB_CODE_SUCCESS;
23,256,972✔
315
}
316

317
int32_t tjsonGetArraySize(const SJson* pJson) { return cJSON_GetArraySize(pJson); }
55,201,070✔
318

319
SJson* tjsonGetArrayItem(const SJson* pJson, int32_t index) { return cJSON_GetArrayItem(pJson, index); }
115,608,923✔
320

321
int32_t tjsonToObject(const SJson* pJson, const char* pName, FJsonToObject func, void* pObj) {
279,548,848✔
322
  SJson* pJsonObj = tjsonGetObjectItem(pJson, pName);
279,548,848✔
323
  if (NULL == pJsonObj) {
279,557,859✔
324
    return TSDB_CODE_SUCCESS;
3,569,209✔
325
  }
326
  return func(pJsonObj, pObj);
275,988,650✔
327
}
328

329
int32_t tjsonMakeObject(const SJson* pJson, const char* pName, FJsonToObject func, void** pObj, int32_t objSize) {
79,828✔
330
  if (objSize <= 0) {
79,828✔
331
    return TSDB_CODE_SUCCESS;
39,914✔
332
  }
333

334
  SJson* pJsonObj = tjsonGetObjectItem(pJson, pName);
39,914✔
335
  if (NULL == pJsonObj) {
39,914✔
336
    return TSDB_CODE_SUCCESS;
×
337
  }
338
  *pObj = taosMemoryCalloc(1, objSize);
39,914✔
339
  if (NULL == *pObj) {
39,914✔
340
    return terrno;
×
341
  }
342
  return func(pJsonObj, *pObj);
39,914✔
343
}
344

345
int32_t tjsonToArray(const SJson* pJson, const char* pName, FJsonToObject func, void* pArray, int32_t itemSize) {
5,134,868✔
346
  const cJSON* jArray = tjsonGetObjectItem(pJson, pName);
5,134,868✔
347
  int32_t      size = (NULL == jArray ? 0 : tjsonGetArraySize(jArray));
5,134,563✔
348
  for (int32_t i = 0; i < size; ++i) {
9,463,714✔
349
    int32_t code = func(tjsonGetArrayItem(jArray, i), (char*)pArray + itemSize * i);
4,328,742✔
350
    if (TSDB_CODE_SUCCESS != code) {
4,328,742✔
351
      return code;
×
352
    }
353
  }
354
  return TSDB_CODE_SUCCESS;
5,134,972✔
355
}
356

357
int32_t tjsonToTArray(const SJson* pJson, const char* pName, FJsonToObject func, SArray** pArray, int32_t itemSize) {
3,740,900✔
358
  const cJSON* jArray = tjsonGetObjectItem(pJson, pName);
3,740,900✔
359
  int32_t      size = tjsonGetArraySize(jArray);
3,740,900✔
360
  if (size > 0) {
3,740,900✔
361
    *pArray = taosArrayInit_s(itemSize, size);
2,619,236✔
362
    if (NULL == *pArray) {
2,619,236✔
363
      return terrno;
×
364
    }
365
    for (int32_t i = 0; i < size; ++i) {
7,358,365✔
366
      int32_t code = func(tjsonGetArrayItem(jArray, i), taosArrayGet(*pArray, i));
4,739,129✔
367
      if (TSDB_CODE_SUCCESS != code) {
4,739,129✔
368
        return code;
×
369
      }
370
    }
371
  }
372
  return TSDB_CODE_SUCCESS;
3,740,900✔
373
}
374

375
SJson* tjsonParse(const char* pStr) { return cJSON_Parse(pStr); }
14,382,063✔
376

377
bool tjsonValidateJson(const char* jIn) {
×
378
  if (!jIn) {
×
379
    return false;
×
380
  }
381

382
  // set json real data
383
  cJSON* root = cJSON_Parse(jIn);
×
384
  if (root == NULL) {
×
385
    return false;
×
386
  }
387

388
  if (!cJSON_IsObject(root)) {
×
389
    return false;
×
390
  }
391
  int size = cJSON_GetArraySize(root);
×
392
  for (int i = 0; i < size; i++) {
×
393
    cJSON* item = cJSON_GetArrayItem(root, i);
×
394
    if (!item) {
×
395
      return false;
×
396
    }
397

398
    char* jsonKey = item->string;
×
399
    if (!jsonKey) return false;
×
400
    for (size_t j = 0; j < strlen(jsonKey); ++j) {
×
401
      if (isprint(jsonKey[j]) == 0) return false;
×
402
    }
403

404
    if (item->type == cJSON_Object || item->type == cJSON_Array) {
×
405
      return false;
×
406
    }
407
  }
408
  return true;
×
409
}
410

411
const char* tjsonGetError() { return cJSON_GetErrorPtr(); }
×
412

413
void tjsonDeleteItemFromObject(const SJson* pJson, const char* pName) {
×
414
  cJSON_DeleteItemFromObject((cJSON*)pJson, pName);
×
415
}
×
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc