Alan-Jowett / CoPilot-For-Consensus / 20474651113

push

github

Make static analysis checks fail CI on hallucinated methods and undefined variables (#530)

* Initial plan

* Add CI checks to catch hallucinated methods and variables

- Enable E0602 (undefined-variable) in Pylint configuration
- Make Pylint, MyPy, and Pyright checks fail the build on errors
- Add error counting and detailed summaries for all checks
- Update CONTRIBUTING.md with comprehensive tool documentation and examples
- Add common error patterns and fixes to contributor guidelines

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add demonstration test file for static analysis validation

- Create test_static_analysis_demo.py with examples of valid code patterns
- Include commented examples of errors that would be caught
- All tests pass and pass Ruff, Pylint, MyPy, and Pyright checks
- Demonstrates proper type hints, attribute access, and variable usage

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Address code review feedback: use modern Python 3.10+ type syntax

- Replace Optional[T] with T | None for consistency
- Replace Dict[K, V] with dict[k, v] using built-in generic types
- Update both CONTRIBUTING.md examples and test file comments
- All tests and static analysis checks still pass

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix code review issues: remove redundant set -e, continue-on-error, fix docs

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix Pylint E1101 error in copilot_metrics adapter

Add pylint disable comment for dynamic method call that's guarded by hasattr check.
The self.push() method is conditionally called only when it exists at runtime,
but Pylint can't detect this pattern. This fixes the CI failure.

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Get rid of trailing whitespace

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Static type check ... (continued)

536 of 570 new or added lines in 109 files covered. (94.04%)

5782 of 7709 relevant lines covered (75.0%)

0.84 hits per line