• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

uc-cdis / fence / 20469216614

23 Dec 2025 07:01PM UTC coverage: 75.002% (+0.02%) from 74.987%
20469216614

Pull #1312

github

nss10
Respond to PR comments
Pull Request #1312: Update Fence to Python 3.13 + Run as gen3 user

8440 of 11253 relevant lines covered (75.0%)

0.75 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

81.83
fence/sync/sync_users.py
1
import paramiko.ssh_exception
1✔
2
import backoff
1✔
3
import glob
1✔
4

5
import httpx
1✔
6
import jwt
1✔
7
import os
1✔
8
import re
1✔
9
import subprocess as sp
1✔
10
import yaml
1✔
11
import copy
1✔
12
import datetime
1✔
13
import uuid
1✔
14
import collections
1✔
15
import hashlib
1✔
16

17
from contextlib import contextmanager
1✔
18
from collections import defaultdict
1✔
19
from csv import DictReader
1✔
20
from io import StringIO
1✔
21
from stat import S_ISDIR
1✔
22

23
import paramiko
1✔
24
from cdislogging import get_logger
1✔
25
from email_validator import validate_email, EmailNotValidError
1✔
26
from gen3authz.client.arborist.errors import ArboristError, ArboristTimeoutError
1✔
27
from gen3users.validation import validate_user_yaml
1✔
28
from paramiko.proxy import ProxyCommand
1✔
29
from sqlalchemy.exc import IntegrityError
1✔
30
from sqlalchemy import func
1✔
31

32
from fence.config import config
1✔
33
from fence.models import (
1✔
34
    AccessPrivilege,
35
    AuthorizationProvider,
36
    Project,
37
    Tag,
38
    User,
39
    query_for_user,
40
    Client,
41
    IdentityProvider,
42
    get_project_to_authz_mapping,
43
)
44
from fence.resources.google.utils import get_or_create_proxy_group_id
1✔
45
from fence.resources.storage import StorageManager
1✔
46
from fence.resources.google.access_utils import update_google_groups_for_users
1✔
47
from fence.resources.google.access_utils import GoogleUpdateException
1✔
48
from fence.sync import utils
1✔
49
from fence.sync.passport_sync.ras_sync import RASVisa
1✔
50
from fence.utils import get_SQLAlchemyDriver, DEFAULT_BACKOFF_SETTINGS
1✔
51

52

53
def _format_policy_id(path, privilege):
1✔
54
    resource = ".".join(name for name in path.split("/") if name)
1✔
55
    return "{}-{}".format(resource, privilege)
1✔
56

57

58
def download_dir(sftp, remote_dir, local_dir):
1✔
59
    """
60
    Recursively download file from remote_dir to local_dir
61
    Args:
62
        remote_dir(str)
63
        local_dir(str)
64
    Returns: None
65
    """
66
    dir_items = sftp.listdir_attr(remote_dir)
×
67

68
    for item in dir_items:
×
69
        remote_path = remote_dir + "/" + item.filename
×
70
        local_path = os.path.join(local_dir, item.filename)
×
71
        if S_ISDIR(item.st_mode):
×
72
            download_dir(sftp, remote_path, local_path)
×
73
        else:
74
            sftp.get(remote_path, local_path)
×
75

76

77
def arborist_role_for_permission(permission):
1✔
78
    """
79
    For the programs/projects in the existing fence access control model, in order to
80
    use arborist for checking permissions we generate a policy for each combination of
81
    program/project and privilege. The roles involved all contain only one permission,
82
    for one privilege from the project access model.
83
    """
84
    return {
1✔
85
        "id": permission,
86
        "permissions": [
87
            {"id": permission, "action": {"service": "*", "method": permission}}
88
        ],
89
    }
90

91

92
@contextmanager
1✔
93
def _read_file(filepath, encrypted=True, key=None, logger=None):
1✔
94
    """
95
    Context manager for reading and optionally decrypting file it only
96
    decrypts files encrypted by unix 'crypt' tool which is used by dbGaP.
97

98
    Args:
99
        filepath (str): path to the file
100
        encrypted (bool): whether the file is encrypted
101

102
    Returns:
103
        Generator[file-like class]: file like object for the file
104
    """
105
    if encrypted:
1✔
106
        p = sp.Popen(
×
107
            [
108
                "ccdecrypt",
109
                "-u",
110
                "-K",
111
                key,
112
                filepath,
113
            ],
114
            stdout=sp.PIPE,
115
            stderr=open(os.devnull, "w"),
116
            universal_newlines=True,
117
        )
118
        try:
×
119
            yield StringIO(p.communicate()[0])
×
120
        except UnicodeDecodeError:
×
121
            logger.error("Could not decode file. Check the decryption key.")
×
122
    else:
123
        f = open(filepath, "r")
1✔
124
        yield f
1✔
125
        f.close()
1✔
126

127

128
class UserYAML(object):
1✔
129
    """
130
    Representation of the information in a YAML file describing user, project, and ABAC
131
    information for access control.
132
    """
133

134
    def __init__(
1✔
135
        self,
136
        projects=None,
137
        user_info=None,
138
        policies=None,
139
        clients=None,
140
        authz=None,
141
        project_to_resource=None,
142
        logger=None,
143
        user_abac=None,
144
    ):
145
        self.projects = projects or {}
1✔
146
        self.user_info = user_info or {}
1✔
147
        self.user_abac = user_abac or {}
1✔
148
        self.policies = policies or {}
1✔
149
        self.clients = clients or {}
1✔
150
        self.authz = authz or {}
1✔
151
        self.project_to_resource = project_to_resource or {}
1✔
152
        self.logger = logger
1✔
153

154
    @classmethod
1✔
155
    def from_file(cls, filepath, encrypted=True, key=None, logger=None):
1✔
156
        """
157
        Add access by "auth_id" to "self.projects" to update the Fence DB.
158
        Add access by "resource" to "self.user_abac" to update Arborist.
159
        """
160
        data = {}
1✔
161
        if filepath:
1✔
162
            with _read_file(filepath, encrypted=encrypted, key=key, logger=logger) as f:
1✔
163
                file_contents = f.read()
1✔
164
                validate_user_yaml(file_contents)  # run user.yaml validation tests
1✔
165
                data = yaml.safe_load(file_contents)
1✔
166
        else:
167
            if logger:
1✔
168
                logger.info("Did not sync a user.yaml, no file path provided.")
1✔
169

170
        projects = dict()
1✔
171
        user_info = dict()
1✔
172
        policies = dict()
1✔
173

174
        # resources should be the resource tree to construct in arborist
175
        user_abac = dict()
1✔
176

177
        # Fall back on rbac block if no authz. Remove when rbac in useryaml fully deprecated.
178
        if not data.get("authz") and data.get("rbac"):
1✔
179
            if logger:
×
180
                logger.info(
×
181
                    "No authz block found but rbac block present. Using rbac block"
182
                )
183
            data["authz"] = data["rbac"]
×
184

185
        # get user project mapping to arborist resources if it exists
186
        project_to_resource = data.get("authz", dict()).get(
1✔
187
            "user_project_to_resource", dict()
188
        )
189

190
        # read projects and privileges for each user
191
        users = data.get("users", {})
1✔
192
        for username, details in users.items():
1✔
193
            # users should occur only once each; skip if already processed
194
            if username in projects:
1✔
195
                msg = "invalid yaml file: user `{}` occurs multiple times".format(
×
196
                    username
197
                )
198
                if logger:
×
199
                    logger.error(msg)
×
200
                raise EnvironmentError(msg)
×
201

202
            privileges = {}
1✔
203
            resource_permissions = dict()
1✔
204
            for project in details.get("projects", {}):
1✔
205
                try:
1✔
206
                    privileges[project["auth_id"]] = set(project["privilege"])
1✔
207
                except KeyError as e:
×
208
                    if logger:
×
209
                        logger.error("project {} missing field: {}".format(project, e))
×
210
                    continue
×
211

212
                # project may not have `resource` field.
213
                # prefer resource field;
214
                # if no resource or mapping, assume auth_id is resource.
215
                resource = project.get("resource", project["auth_id"])
1✔
216

217
                if project["auth_id"] not in project_to_resource:
1✔
218
                    project_to_resource[project["auth_id"]] = resource
1✔
219
                resource_permissions[resource] = set(project["privilege"])
1✔
220

221
            user_info[username] = {
1✔
222
                "email": details.get("email", ""),
223
                "display_name": details.get("display_name", ""),
224
                "phone_number": details.get("phone_number", ""),
225
                "tags": details.get("tags", {}),
226
                "admin": details.get("admin", False),
227
            }
228
            if not details.get("email"):
1✔
229
                try:
1✔
230
                    valid = validate_email(
1✔
231
                        username, allow_smtputf8=False, check_deliverability=False
232
                    )
233
                    user_info[username]["email"] = valid.email
1✔
234
                except EmailNotValidError:
1✔
235
                    pass
1✔
236
            projects[username] = privileges
1✔
237
            user_abac[username] = resource_permissions
1✔
238

239
            # list of policies we want to grant to this user, which get sent to arborist
240
            # to check if they're allowed to do certain things
241
            policies[username] = details.get("policies", [])
1✔
242

243
        if logger:
1✔
244
            logger.info(
1✔
245
                "Got user project to arborist resource mapping:\n{}".format(
246
                    str(project_to_resource)
247
                )
248
            )
249

250
        authz = data.get("authz", dict())
1✔
251
        if not authz:
1✔
252
            # older version: resources in root, no `authz` section or `rbac` section
253
            if logger:
1✔
254
                logger.warning(
1✔
255
                    "access control YAML file is using old format (missing `authz`/`rbac`"
256
                    " section in the root); assuming that if it exists `resources` will"
257
                    " be on the root level, and continuing"
258
                )
259
            # we're going to throw it into the `authz` dictionary anyways, so the rest of
260
            # the code can pretend it's in the normal place that we expect
261
            resources = data.get("resources", [])
1✔
262
            # keep authz empty dict if resources is not specified
263
            if resources:
1✔
264
                authz["resources"] = data.get("resources", [])
×
265

266
        clients = data.get("clients", {})
1✔
267

268
        return cls(
1✔
269
            projects=projects,
270
            user_info=user_info,
271
            user_abac=user_abac,
272
            policies=policies,
273
            clients=clients,
274
            authz=authz,
275
            project_to_resource=project_to_resource,
276
            logger=logger,
277
        )
278

279
    def persist_project_to_resource(self, db_session):
1✔
280
        """
281
        Store the mappings from Project.auth_id to authorization resource (Project.authz)
282

283
        The mapping comes from an external source, this function persists what was parsed
284
        into memory into the database for future use.
285
        """
286
        for auth_id, authz_resource in self.project_to_resource.items():
1✔
287
            project = (
1✔
288
                db_session.query(Project).filter(Project.auth_id == auth_id).first()
289
            )
290
            if project:
1✔
291
                project.authz = authz_resource
1✔
292
            else:
293
                project = Project(name=auth_id, auth_id=auth_id, authz=authz_resource)
×
294
                db_session.add(project)
×
295
        db_session.commit()
1✔
296

297

298
class UserSyncer(object):
1✔
299
    def __init__(
1✔
300
        self,
301
        dbGaP,
302
        DB,
303
        project_mapping,
304
        storage_credentials=None,
305
        db_session=None,
306
        is_sync_from_dbgap_server=False,
307
        sync_from_local_csv_dir=None,
308
        sync_from_local_yaml_file=None,
309
        arborist=None,
310
        folder=None,
311
    ):
312
        """
313
        Syncs ACL files from dbGap to auth database and storage backends
314
        Args:
315
            dbGaP: a list of dict containing creds to access dbgap sftp
316
            DB: database connection string
317
            project_mapping: a dict containing how dbgap ids map to projects
318
            storage_credentials: a dict containing creds for storage backends
319
            sync_from_dir: path to an alternative dir to sync from instead of
320
                           dbGaP
321
            arborist:
322
                ArboristClient instance if the syncer should also create
323
                resources in arborist
324
            folder: a local folder where dbgap telemetry files will sync to
325
        """
326
        self.sync_from_local_csv_dir = sync_from_local_csv_dir
1✔
327
        self.sync_from_local_yaml_file = sync_from_local_yaml_file
1✔
328
        self.is_sync_from_dbgap_server = is_sync_from_dbgap_server
1✔
329
        self.dbGaP = dbGaP
1✔
330
        self.session = db_session
1✔
331
        self.driver = get_SQLAlchemyDriver(DB)
1✔
332
        self.project_mapping = project_mapping or {}
1✔
333
        self._projects = dict()
1✔
334
        self._created_roles = set()
1✔
335
        self._created_policies = set()
1✔
336
        self._dbgap_study_to_resources = dict()
1✔
337
        self.logger = get_logger(
1✔
338
            "user_syncer", log_level="debug" if config["DEBUG"] is True else "info"
339
        )
340
        self.arborist_client = arborist
1✔
341
        self.folder = folder
1✔
342

343
        self.auth_source = defaultdict(set)
1✔
344
        # auth_source used for logging. username : [source1, source2]
345
        self.visa_types = config.get("USERSYNC", {}).get("visa_types", {})
1✔
346
        self.parent_to_child_studies_mapping = {}
1✔
347
        for dbgap_config in dbGaP:
1✔
348
            self.parent_to_child_studies_mapping.update(
1✔
349
                dbgap_config.get("parent_to_child_studies_mapping", {})
350
            )
351
        if storage_credentials:
1✔
352
            self.storage_manager = StorageManager(
1✔
353
                storage_credentials, logger=self.logger
354
            )
355
        self.id_patterns = []
1✔
356

357
    @staticmethod
1✔
358
    def _match_pattern(filepath, id_patterns, encrypted=True):
1✔
359
        """
360
        Check if the filename matches dbgap access control file pattern
361

362
        Args:
363
            filepath (str): path to file
364
            encrypted (bool): whether the file is encrypted
365

366
        Returns:
367
            bool: whether the pattern matches
368
        """
369
        id_patterns.append(r"authentication_file_phs(\d{6}).(csv|txt)")
1✔
370
        for pattern in id_patterns:
1✔
371
            if encrypted:
1✔
372
                pattern += r".enc"
×
373
            pattern += r"$"
1✔
374
            # when converting the YAML from fence-config,
375
            # python reads it as Python string literal. So "\" turns into "\\"
376
            # which messes with the regex match
377
            pattern.replace("\\\\", "\\")
1✔
378
            if re.match(pattern, os.path.basename(filepath)):
1✔
379
                return True
1✔
380
        return False
1✔
381

382
    def _get_from_sftp_with_proxy(self, server, path):
1✔
383
        """
384
        Download all data from sftp sever to a local dir
385

386
        Args:
387
            server (dict) : dictionary containing info to access sftp server
388
            path (str): path to local directory
389

390
        Returns:
391
            None
392
        """
393
        proxy = None
1✔
394
        if server.get("proxy", "") != "":
1✔
395
            command = "ssh -oHostKeyAlgorithms=+ssh-rsa -i ~/.ssh/id_rsa {user}@{proxy} nc {host} {port}".format(
×
396
                user=server.get("proxy_user", ""),
397
                proxy=server.get("proxy", ""),
398
                host=server.get("host", ""),
399
                port=server.get("port", 22),
400
            )
401
            self.logger.info("SSH proxy command: {}".format(command))
×
402

403
            proxy = ProxyCommand(command)
×
404

405
        with paramiko.SSHClient() as client:
1✔
406
            client.set_log_channel(self.logger.name)
1✔
407

408
            # Load known host keys
409
            known_hosts_path = os.path.expanduser("~/.ssh/known_hosts")
1✔
410
            if os.path.exists(known_hosts_path):
1✔
411
                client.load_host_keys(known_hosts_path)
×
412
            else:
413
                self.logger.error(
1✔
414
                    "No known_hosts file found — rejecting unknown hosts - make sure the SFTP host key is present in known_hosts before attempting connection."
415
                )
416

417
            client.set_missing_host_key_policy(paramiko.RejectPolicy())
1✔
418
            parameters = {
1✔
419
                "hostname": str(server.get("host", "")),
420
                "username": str(server.get("username", "")),
421
                "password": str(server.get("password", "")),
422
                "port": int(server.get("port", 22)),
423
            }
424
            if proxy:
1✔
425
                parameters["sock"] = proxy
×
426

427
            self.logger.info(
1✔
428
                "SSH connection hostname:post {}:{}".format(
429
                    parameters.get("hostname", "unknown"),
430
                    parameters.get("port", "unknown"),
431
                )
432
            )
433
            try:
1✔
434
                self._connect_with_ssh(ssh_client=client, parameters=parameters)
1✔
435

436
                with client.open_sftp() as sftp:
×
437
                    download_dir(sftp, "./", path)
×
438
            except paramiko.ssh_exception.SSHException as e:
1✔
439
                self.logger.error(f"SSH connection failed, error: {e}")
×
440

441
        if proxy:
×
442
            proxy.close()
×
443

444
    @backoff.on_exception(backoff.expo, Exception, **DEFAULT_BACKOFF_SETTINGS)
1✔
445
    def _connect_with_ssh(self, ssh_client, parameters):
1✔
446
        ssh_client.connect(**parameters)
1✔
447

448
    def _get_from_ftp_with_proxy(self, server, path):
1✔
449
        """
450
        Download data from ftp sever to a local dir
451

452
        Args:
453
            server (dict): dictionary containing information for accessing server
454
            path(str): path to local files
455

456
        Returns:
457
            None
458
        """
459
        execstr = (
×
460
            'lftp -u {},{}  {} -e "set ftp:proxy http://{}; mirror . {}; exit"'.format(
461
                server.get("username", ""),
462
                server.get("password", ""),
463
                server.get("host", ""),
464
                server.get("proxy", ""),
465
                path,
466
            )
467
        )
468
        os.system(execstr)
×
469

470
    def _get_parse_consent_code(self, dbgap_config={}):
1✔
471
        return dbgap_config.get(
1✔
472
            "parse_consent_code", True
473
        )  # Should this really be true?
474

475
    def _parse_csv(self, file_dict, sess, dbgap_config={}, encrypted=True):
1✔
476
        """
477
        parse csv files to python dict
478

479
        Args:
480
            file_dict: a dictionary with key(file path) and value(privileges)
481
            sess: sqlalchemy session
482
            dbgap_config: a dictionary containing information about the dbGaP sftp server
483
                (comes from fence config)
484
            encrypted: boolean indicating whether those files are encrypted
485

486

487
        Return:
488
            Tuple[[dict, dict]]:
489
                (user_project, user_info) where user_project is a mapping from
490
                usernames to project permissions and user_info is a mapping
491
                from usernames to user details, such as email
492

493
        Example:
494

495
            (
496
                {
497
                    username: {
498
                        'project1': {'read-storage','write-storage'},
499
                        'project2': {'read-storage'},
500
                    }
501
                },
502
                {
503
                    username: {
504
                        'email': 'email@mail.com',
505
                        'display_name': 'display name',
506
                        'phone_number': '123-456-789',
507
                        'tags': {'dbgap_role': 'PI'}
508
                    }
509
                },
510
            )
511

512
        """
513
        user_projects = dict()
1✔
514
        user_info = defaultdict(dict)
1✔
515

516
        # parse dbGaP sftp server information
517
        dbgap_key = dbgap_config.get("decrypt_key", None)
1✔
518

519
        self.id_patterns += (
1✔
520
            [
521
                item.replace("\\\\", "\\")
522
                for item in dbgap_config.get("allowed_whitelist_patterns", [])
523
            ]
524
            if dbgap_config.get("allow_non_dbGaP_whitelist", False)
525
            else []
526
        )
527

528
        enable_common_exchange_area_access = dbgap_config.get(
1✔
529
            "enable_common_exchange_area_access", False
530
        )
531
        study_common_exchange_areas = dbgap_config.get(
1✔
532
            "study_common_exchange_areas", {}
533
        )
534
        parse_consent_code = self._get_parse_consent_code(dbgap_config)
1✔
535

536
        if parse_consent_code and enable_common_exchange_area_access:
1✔
537
            self.logger.info(
1✔
538
                f"using study to common exchange area mapping: {study_common_exchange_areas}"
539
            )
540

541
        project_id_patterns = [r"phs(\d{6})"]
1✔
542
        if "additional_allowed_project_id_patterns" in dbgap_config:
1✔
543
            patterns = dbgap_config.get("additional_allowed_project_id_patterns")
1✔
544
            patterns = [
1✔
545
                pattern.replace("\\\\", "\\") for pattern in patterns
546
            ]  # when converting the YAML from fence-config, python reads it as Python string literal. So "\" turns into "\\" which messes with the regex match
547
            project_id_patterns += patterns
1✔
548

549
        self.logger.info(f"Using these file paths: {file_dict.items()}")
1✔
550
        for filepath, privileges in file_dict.items():
1✔
551
            self.logger.info("Reading file {}".format(filepath))
1✔
552
            if os.stat(filepath).st_size == 0:
1✔
553
                self.logger.warning("Empty file {}".format(filepath))
×
554
                continue
×
555
            if not self._match_pattern(
1✔
556
                filepath, id_patterns=self.id_patterns, encrypted=encrypted
557
            ):
558
                self.logger.warning(
1✔
559
                    "Filename {} does not match dbgap access control filename pattern;"
560
                    " this could mean that the filename has an invalid format, or has"
561
                    " an unexpected .enc extension, or lacks the .enc extension where"
562
                    " expected. This file is NOT being processed by usersync!".format(
563
                        filepath
564
                    )
565
                )
566
                continue
1✔
567

568
            with _read_file(
1✔
569
                filepath, encrypted=encrypted, key=dbgap_key, logger=self.logger
570
            ) as f:
571
                csv = DictReader(f, quotechar='"', skipinitialspace=True)
1✔
572

573
                for row in csv:
1✔
574
                    username = row.get("login") or ""
1✔
575
                    if username == "":
1✔
576
                        continue
×
577

578
                    if dbgap_config.get("allow_non_dbGaP_whitelist", False):
1✔
579
                        phsid = (
1✔
580
                            row.get("phsid") or (row.get("project_id") or "")
581
                        ).split(".")
582
                    else:
583
                        phsid = (row.get("phsid") or "").split(".")
1✔
584

585
                    dbgap_project = phsid[0]
1✔
586
                    # There are issues where dbgap has a wrong entry in their whitelist. Since we do a bulk arborist request, there are wrong entries in it that invalidates the whole request causing other correct entries not to be added
587
                    skip = False
1✔
588
                    for pattern in project_id_patterns:
1✔
589
                        self.logger.debug(
1✔
590
                            "Checking pattern:{} with project_id:{}".format(
591
                                pattern, dbgap_project
592
                            )
593
                        )
594
                        if re.match(pattern, dbgap_project):
1✔
595
                            skip = False
1✔
596
                            break
1✔
597
                        else:
598
                            skip = True
1✔
599
                    if skip:
1✔
600
                        self.logger.warning(
1✔
601
                            "Skip processing from file {}, user {} with project {}".format(
602
                                filepath,
603
                                username,
604
                                dbgap_project,
605
                            )
606
                        )
607
                        continue
1✔
608
                    if len(phsid) > 1 and parse_consent_code:
1✔
609
                        consent_code = phsid[-1]
1✔
610

611
                        # c999 indicates full access to all consents and access
612
                        # to a study-specific exchange area
613
                        # access to at least one study-specific exchange area implies access
614
                        # to the parent study's common exchange area
615
                        #
616
                        # NOTE: Handling giving access to all consents is done at
617
                        #       a later time, when we have full information about possible
618
                        #       consents
619
                        self.logger.debug(
1✔
620
                            f"got consent code {consent_code} from dbGaP project "
621
                            f"{dbgap_project}"
622
                        )
623
                        if (
1✔
624
                            consent_code == "c999"
625
                            and enable_common_exchange_area_access
626
                            and dbgap_project in study_common_exchange_areas
627
                        ):
628
                            self.logger.info(
1✔
629
                                "found study with consent c999 and Fence "
630
                                "is configured to parse exchange area data. Giving user "
631
                                f"{username} {privileges} privileges in project: "
632
                                f"{study_common_exchange_areas[dbgap_project]}."
633
                            )
634
                            self._add_dbgap_project_for_user(
1✔
635
                                study_common_exchange_areas[dbgap_project],
636
                                privileges,
637
                                username,
638
                                sess,
639
                                user_projects,
640
                                dbgap_config,
641
                            )
642

643
                        dbgap_project += "." + consent_code
1✔
644

645
                    self._add_children_for_dbgap_project(
1✔
646
                        dbgap_project,
647
                        privileges,
648
                        username,
649
                        sess,
650
                        user_projects,
651
                        dbgap_config,
652
                    )
653

654
                    display_name = row.get("user name") or ""
1✔
655
                    tags = {"dbgap_role": row.get("role") or ""}
1✔
656

657
                    # some dbgap telemetry files have information about a researchers PI
658
                    if "downloader for" in row:
1✔
659
                        tags["pi"] = row["downloader for"]
1✔
660

661
                    # prefer name over previous "downloader for" if it exists
662
                    if "downloader for names" in row:
1✔
663
                        tags["pi"] = row["downloader for names"]
×
664

665
                    user_info[username] = {
1✔
666
                        "email": row.get("email")
667
                        or user_info[username].get("email")
668
                        or "",
669
                        "display_name": display_name,
670
                        "phone_number": row.get("phone")
671
                        or user_info[username].get("phone_number")
672
                        or "",
673
                        "tags": tags,
674
                    }
675

676
                    self._process_dbgap_project(
1✔
677
                        dbgap_project,
678
                        privileges,
679
                        username,
680
                        sess,
681
                        user_projects,
682
                        dbgap_config,
683
                    )
684

685
        return user_projects, user_info
1✔
686

687
    def _get_children(self, dbgap_project):
1✔
688
        return self.parent_to_child_studies_mapping.get(dbgap_project.split(".")[0])
1✔
689

690
    def _add_children_for_dbgap_project(
1✔
691
        self, dbgap_project, privileges, username, sess, user_projects, dbgap_config
692
    ):
693
        """
694
        Adds the configured child studies for the given dbgap_project, adding it to the provided user_projects. If
695
        parse_consent_code is true, then the consents granted in the provided dbgap_project will also be granted to the
696
        child studies.
697
        """
698
        parent_phsid = dbgap_project
1✔
699
        parse_consent_code = self._get_parse_consent_code(dbgap_config)
1✔
700
        child_suffix = ""
1✔
701
        if parse_consent_code and re.match(
1✔
702
            config["DBGAP_ACCESSION_WITH_CONSENT_REGEX"], dbgap_project
703
        ):
704
            parent_phsid_parts = dbgap_project.split(".")
1✔
705
            parent_phsid = parent_phsid_parts[0]
1✔
706
            child_suffix = "." + parent_phsid_parts[1]
1✔
707

708
        if parent_phsid not in self.parent_to_child_studies_mapping:
1✔
709
            return
1✔
710

711
        self.logger.info(
1✔
712
            f"found parent study {parent_phsid} and Fence "
713
            "is configured to provide additional access to child studies. Giving user "
714
            f"{username} {privileges} privileges in projects: "
715
            f"{{k + child_suffix: v + child_suffix for k, v in self.parent_to_child_studies_mapping.items()}}."
716
        )
717
        child_studies = self.parent_to_child_studies_mapping.get(parent_phsid, [])
1✔
718
        for child_study in child_studies:
1✔
719
            self._add_dbgap_project_for_user(
1✔
720
                child_study + child_suffix,
721
                privileges,
722
                username,
723
                sess,
724
                user_projects,
725
                dbgap_config,
726
            )
727

728
    def _add_dbgap_project_for_user(
1✔
729
        self, dbgap_project, privileges, username, sess, user_projects, dbgap_config
730
    ):
731
        """
732
        Helper function for csv parsing that adds a given dbgap project to Fence/Arborist
733
        and then updates the dictionary containing all user's project access
734
        """
735
        if dbgap_project not in self._projects:
1✔
736
            self.logger.debug(
1✔
737
                "creating Project in fence for dbGaP study: {}".format(dbgap_project)
738
            )
739

740
            project = self._get_or_create(sess, Project, auth_id=dbgap_project)
1✔
741

742
            # need to add dbgap project to arborist
743
            if self.arborist_client:
1✔
744
                self._determine_arborist_resource(dbgap_project, dbgap_config)
1✔
745

746
            if project.name is None:
1✔
747
                project.name = dbgap_project
1✔
748
            self._projects[dbgap_project] = project
1✔
749
        phsid_privileges = {dbgap_project: set(privileges)}
1✔
750
        if username in user_projects:
1✔
751
            user_projects[username].update(phsid_privileges)
1✔
752
        else:
753
            user_projects[username] = phsid_privileges
1✔
754

755
    @staticmethod
1✔
756
    def sync_two_user_info_dict(user_info1, user_info2):
1✔
757
        """
758
        Merge user_info1 into user_info2. Values in user_info2 are overriden
759
        by values in user_info1. user_info2 ends up containing the merged dict.
760

761
        Args:
762
            user_info1 (dict): nested dict
763
            user_info2 (dict): nested dict
764

765
            Example:
766
            {username: {'email': 'abc@email.com'}}
767

768
        Returns:
769
            None
770
        """
771
        user_info2.update(user_info1)
1✔
772

773
    def sync_two_phsids_dict(
1✔
774
        self,
775
        phsids1,
776
        phsids2,
777
        source1=None,
778
        source2=None,
779
        phsids2_overrides_phsids1=True,
780
    ):
781
        """
782
        Merge phsids1 into phsids2. If `phsids2_overrides_phsids1`, values in
783
        phsids1 are overriden by values in phsids2. phsids2 ends up containing
784
        the merged dict (see explanation below).
785
        `source1` and `source2`: for logging.
786

787
        Args:
788
            phsids1, phsids2: nested dicts mapping phsids to sets of permissions
789

790
            source1, source2: source of authz information (eg. dbgap, user_yaml, visas)
791

792
            Example:
793
            {
794
                username: {
795
                    phsid1: {'read-storage','write-storage'},
796
                    phsid2: {'read-storage'},
797
                }
798
            }
799

800
        Return:
801
            None
802

803
        Explanation:
804
            Consider merging projects of the same user:
805

806
                {user1: {phsid1: privillege1}}
807

808
                {user1: {phsid2: privillege2}}
809

810
            case 1: phsid1 != phsid2. Output:
811

812
                {user1: {phsid1: privillege1, phsid2: privillege2}}
813

814
            case 2: phsid1 == phsid2 and privillege1! = privillege2. Output:
815

816
                {user1: {phsid1: union(privillege1, privillege2)}}
817

818
            For the other cases, just simple addition
819
        """
820

821
        for user, projects1 in phsids1.items():
1✔
822
            if not phsids2.get(user):
1✔
823
                if source1:
1✔
824
                    self.auth_source[user].add(source1)
1✔
825
                phsids2[user] = projects1
1✔
826
            elif phsids2_overrides_phsids1:
1✔
827
                if source1:
1✔
828
                    self.auth_source[user].add(source1)
×
829
                if source2:
1✔
830
                    self.auth_source[user].add(source2)
×
831
                for phsid1, privilege1 in projects1.items():
1✔
832
                    if phsid1 not in phsids2[user]:
1✔
833
                        phsids2[user][phsid1] = set()
1✔
834
                    phsids2[user][phsid1].update(privilege1)
1✔
835
            elif source2:
×
836
                self.auth_source[user].add(source2)
×
837

838
    def sync_to_db_and_storage_backend(
1✔
839
        self,
840
        user_project,
841
        user_info,
842
        sess,
843
        do_not_revoke_from_db_and_storage=False,
844
        expires=None,
845
    ):
846
        """
847
        sync user access control to database and storage backend
848

849
        Args:
850
            user_project (dict): a dictionary of
851

852
                {
853
                    username: {
854
                        'project1': {'read-storage','write-storage'},
855
                        'project2': {'read-storage'}
856
                    }
857
                }
858

859
            user_info (dict): a dictionary of {username: user_info{}}
860
            sess: a sqlalchemy session
861

862
        Return:
863
            None
864
        """
865
        google_bulk_mapping = None
1✔
866
        if config["GOOGLE_BULK_UPDATES"]:
1✔
867
            google_bulk_mapping = {}
1✔
868

869
        self._init_projects(user_project, sess)
1✔
870

871
        auth_provider_list = [
1✔
872
            self._get_or_create(sess, AuthorizationProvider, name="dbGaP"),
873
            self._get_or_create(sess, AuthorizationProvider, name="fence"),
874
        ]
875

876
        cur_db_user_project_list = {
1✔
877
            (ua.user.username.lower(), ua.project.auth_id)
878
            for ua in sess.query(AccessPrivilege).all()
879
        }
880

881
        # we need to compare db -> whitelist case-insensitively for username.
882
        # db stores case-sensitively, but we need to query case-insensitively
883
        user_project_lowercase = {}
1✔
884
        syncing_user_project_list = set()
1✔
885
        for username, projects in user_project.items():
1✔
886
            user_project_lowercase[username.lower()] = projects
1✔
887
            for project, _ in projects.items():
1✔
888
                syncing_user_project_list.add((username.lower(), project))
1✔
889

890
        user_info_lowercase = {
1✔
891
            username.lower(): info for username, info in user_info.items()
892
        }
893

894
        to_delete = set.difference(cur_db_user_project_list, syncing_user_project_list)
1✔
895
        to_add = set.difference(syncing_user_project_list, cur_db_user_project_list)
1✔
896
        to_update = set.intersection(
1✔
897
            cur_db_user_project_list, syncing_user_project_list
898
        )
899

900
        # when updating users we want to maintain case sesitivity in the username so
901
        # pass the original, non-lowered user_info dict
902
        self._upsert_userinfo(sess, user_info)
1✔
903

904
        if not do_not_revoke_from_db_and_storage:
1✔
905
            self._revoke_from_storage(
1✔
906
                to_delete, sess, google_bulk_mapping=google_bulk_mapping
907
            )
908
            self._revoke_from_db(sess, to_delete)
1✔
909

910
        self._grant_from_storage(
1✔
911
            to_add,
912
            user_project_lowercase,
913
            sess,
914
            google_bulk_mapping=google_bulk_mapping,
915
            expires=expires,
916
        )
917

918
        self._grant_from_db(
1✔
919
            sess,
920
            to_add,
921
            user_info_lowercase,
922
            user_project_lowercase,
923
            auth_provider_list,
924
        )
925

926
        # re-grant
927
        self._grant_from_storage(
1✔
928
            to_update,
929
            user_project_lowercase,
930
            sess,
931
            google_bulk_mapping=google_bulk_mapping,
932
            expires=expires,
933
        )
934
        self._update_from_db(sess, to_update, user_project_lowercase)
1✔
935

936
        if not do_not_revoke_from_db_and_storage:
1✔
937
            self._validate_and_update_user_admin(sess, user_info_lowercase)
1✔
938

939
        sess.commit()
1✔
940

941
        if config["GOOGLE_BULK_UPDATES"]:
1✔
942
            self.logger.info("Doing bulk Google update...")
1✔
943
            update_google_groups_for_users(google_bulk_mapping)
1✔
944
            self.logger.info("Bulk Google update done!")
×
945

946
        sess.commit()
1✔
947

948
    def sync_to_storage_backend(
1✔
949
        self, user_project, user_info, sess, expires, skip_google_updates=False
950
    ):
951
        """
952
        sync user access control to storage backend with given expiration
953

954
        Args:
955
            user_project (dict): a dictionary of
956

957
                {
958
                    username: {
959
                        'project1': {'read-storage','write-storage'},
960
                        'project2': {'read-storage'}
961
                    }
962
                }
963

964
            user_info (dict): a dictionary of attributes for a user.
965
            sess: a sqlalchemy session
966
            expires (int): time at which synced Arborist policies and
967
                   inclusion in any GBAG are set to expire
968
            skip_google_updates (bool): True if google group updates should be skipped. False if otherwise.
969
        Return:
970
            None
971
        """
972
        if not expires:
1✔
973
            raise Exception(
×
974
                f"sync to storage backend requires an expiration. you provided: {expires}"
975
            )
976

977
        google_group_user_mapping = None
1✔
978
        if config["GOOGLE_BULK_UPDATES"]:
1✔
979
            google_group_user_mapping = {}
×
980
            get_or_create_proxy_group_id(
×
981
                expires=expires,
982
                user_id=user_info["user_id"],
983
                username=user_info["username"],
984
                session=sess,
985
                storage_manager=self.storage_manager,
986
            )
987

988
        # TODO: eventually it'd be nice to remove this step but it's required
989
        #       so that grant_from_storage can determine what storage backends
990
        #       are needed for a project.
991
        self._init_projects(user_project, sess)
1✔
992

993
        # we need to compare db -> whitelist case-insensitively for username.
994
        # db stores case-sensitively, but we need to query case-insensitively
995
        user_project_lowercase = {}
1✔
996
        syncing_user_project_list = set()
1✔
997
        for username, projects in user_project.items():
1✔
998
            user_project_lowercase[username.lower()] = projects
1✔
999
            for project, _ in projects.items():
1✔
1000
                syncing_user_project_list.add((username.lower(), project))
1✔
1001

1002
        to_add = set(syncing_user_project_list)
1✔
1003

1004
        # when updating users we want to maintain case sensitivity in the username so
1005
        # pass the original, non-lowered user_info dict
1006
        self._upsert_userinfo(sess, {user_info["username"].lower(): user_info})
1✔
1007
        if not skip_google_updates:
1✔
1008
            self._grant_from_storage(
1✔
1009
                to_add,
1010
                user_project_lowercase,
1011
                sess,
1012
                google_bulk_mapping=google_group_user_mapping,
1013
                expires=expires,
1014
            )
1015

1016
            if config["GOOGLE_BULK_UPDATES"]:
1✔
1017
                self.logger.info("Updating user's google groups ...")
×
1018
                update_google_groups_for_users(google_group_user_mapping)
×
1019
                self.logger.info("Google groups update done!!")
×
1020

1021
        sess.commit()
1✔
1022

1023
    def _revoke_from_db(self, sess, to_delete):
1✔
1024
        """
1025
        Revoke user access to projects in the auth database
1026

1027
        Args:
1028
            sess: sqlalchemy session
1029
            to_delete: a set of (username, project.auth_id) to be revoked from db
1030
        Return:
1031
            None
1032
        """
1033
        for username, project_auth_id in to_delete:
1✔
1034
            q = (
1✔
1035
                sess.query(AccessPrivilege)
1036
                .filter(AccessPrivilege.project.has(auth_id=project_auth_id))
1037
                .join(AccessPrivilege.user)
1038
                .filter(func.lower(User.username) == username)
1039
                .all()
1040
            )
1041
            for access in q:
1✔
1042
                self.logger.info(
1✔
1043
                    "revoke {} access to {} in db".format(username, project_auth_id)
1044
                )
1045
                sess.delete(access)
1✔
1046

1047
    def _validate_and_update_user_admin(self, sess, user_info):
1✔
1048
        """
1049
        Make sure there is no admin user that is not in yaml/csv files
1050

1051
        Args:
1052
            sess: sqlalchemy session
1053
            user_info: a dict of
1054
            {
1055
                username: {
1056
                    'email': email,
1057
                    'display_name': display_name,
1058
                    'phone_number': phonenum,
1059
                    'tags': {'k1':'v1', 'k2': 'v2'}
1060
                    'admin': is_admin
1061
                }
1062
            }
1063
        Returns:
1064
            None
1065
        """
1066
        for admin_user in sess.query(User).filter_by(is_admin=True).all():
1✔
1067
            if admin_user.username.lower() not in user_info:
1✔
1068
                admin_user.is_admin = False
×
1069
                sess.add(admin_user)
×
1070
                self.logger.info(
×
1071
                    "remove admin access from {} in db".format(
1072
                        admin_user.username.lower()
1073
                    )
1074
                )
1075

1076
    def _update_from_db(self, sess, to_update, user_project):
1✔
1077
        """
1078
        Update user access to projects in the auth database
1079

1080
        Args:
1081
            sess: sqlalchemy session
1082
            to_update:
1083
                a set of (username, project.auth_id) to be updated from db
1084

1085
        Return:
1086
            None
1087
        """
1088

1089
        for username, project_auth_id in to_update:
1✔
1090
            q = (
1✔
1091
                sess.query(AccessPrivilege)
1092
                .filter(AccessPrivilege.project.has(auth_id=project_auth_id))
1093
                .join(AccessPrivilege.user)
1094
                .filter(func.lower(User.username) == username)
1095
                .all()
1096
            )
1097
            for access in q:
1✔
1098
                access.privilege = user_project[username][project_auth_id]
1✔
1099
                self.logger.info(
1✔
1100
                    "update {} with {} access to {} in db".format(
1101
                        username, access.privilege, project_auth_id
1102
                    )
1103
                )
1104

1105
    def _grant_from_db(self, sess, to_add, user_info, user_project, auth_provider_list):
1✔
1106
        """
1107
        Grant user access to projects in the auth database
1108
        Args:
1109
            sess: sqlalchemy session
1110
            to_add: a set of (username, project.auth_id) to be granted
1111
            user_project:
1112
                a dictionary of {username: {project: {'read','write'}}
1113
        Return:
1114
            None
1115
        """
1116
        for username, project_auth_id in to_add:
1✔
1117
            u = query_for_user(session=sess, username=username)
1✔
1118

1119
            auth_provider = auth_provider_list[0]
1✔
1120
            if "dbgap_role" not in user_info[username]["tags"]:
1✔
1121
                auth_provider = auth_provider_list[1]
1✔
1122
            user_access = AccessPrivilege(
1✔
1123
                user=u,
1124
                project=self._projects[project_auth_id],
1125
                privilege=list(user_project[username][project_auth_id]),
1126
                auth_provider=auth_provider,
1127
            )
1128
            self.logger.info(
1✔
1129
                "grant user {} to {} with access {}".format(
1130
                    username, user_access.project, user_access.privilege
1131
                )
1132
            )
1133
            sess.add(user_access)
1✔
1134

1135
    def _upsert_userinfo(self, sess, user_info):
1✔
1136
        """
1137
        update user info to database.
1138

1139
        Args:
1140
            sess: sqlalchemy session
1141
            user_info:
1142
                a dict of {username: {display_name, phone_number, tags, admin}
1143

1144
        Return:
1145
            None
1146
        """
1147

1148
        for username in user_info:
1✔
1149
            u = query_for_user(session=sess, username=username)
1✔
1150

1151
            if u is None:
1✔
1152
                self.logger.info("create user {}".format(username))
1✔
1153
                u = User(username=username)
1✔
1154
                sess.add(u)
1✔
1155

1156
            if self.arborist_client:
1✔
1157
                self.arborist_client.create_user({"name": username})
1✔
1158

1159
            u.email = user_info[username].get("email", "")
1✔
1160
            u.display_name = user_info[username].get("display_name", "")
1✔
1161
            u.phone_number = user_info[username].get("phone_number", "")
1✔
1162
            u.is_admin = user_info[username].get("admin", False)
1✔
1163

1164
            idp_name = user_info[username].get("idp_name", "")
1✔
1165
            if idp_name and not u.identity_provider:
1✔
1166
                idp = (
×
1167
                    sess.query(IdentityProvider)
1168
                    .filter(IdentityProvider.name == idp_name)
1169
                    .first()
1170
                )
1171
                if not idp:
×
1172
                    idp = IdentityProvider(name=idp_name)
×
1173
                u.identity_provider = idp
×
1174

1175
            # do not update if there is no tag
1176
            if not user_info[username].get("tags"):
1✔
1177
                continue
1✔
1178

1179
            # remove user db tags if they are not shown in new tags
1180
            for tag in u.tags:
1✔
1181
                if tag.key not in user_info[username]["tags"]:
1✔
1182
                    u.tags.remove(tag)
1✔
1183

1184
            # sync
1185
            for k, v in user_info[username]["tags"].items():
1✔
1186
                found = False
1✔
1187
                for tag in u.tags:
1✔
1188
                    if tag.key == k:
1✔
1189
                        found = True
1✔
1190
                        tag.value = v
1✔
1191
                # create new tag if not found
1192
                if not found:
1✔
1193
                    tag = Tag(key=k, value=v)
1✔
1194
                    u.tags.append(tag)
1✔
1195

1196
    def _revoke_from_storage(self, to_delete, sess, google_bulk_mapping=None):
1✔
1197
        """
1198
        If a project have storage backend, revoke user's access to buckets in
1199
        the storage backend.
1200

1201
        Args:
1202
            to_delete: a set of (username, project.auth_id) to be revoked
1203

1204
        Return:
1205
            None
1206
        """
1207
        for username, project_auth_id in to_delete:
1✔
1208
            project = (
1✔
1209
                sess.query(Project).filter(Project.auth_id == project_auth_id).first()
1210
            )
1211
            for sa in project.storage_access:
1✔
1212
                if not hasattr(self, "storage_manager"):
1✔
1213
                    self.logger.error(
×
1214
                        (
1215
                            "CANNOT revoke {} access to {} in {} because there is NO "
1216
                            "configured storage accesses at all. See configuration. "
1217
                            "Continuing anyway..."
1218
                        ).format(username, project_auth_id, sa.provider.name)
1219
                    )
1220
                    continue
×
1221

1222
                self.logger.info(
1✔
1223
                    "revoke {} access to {} in {}".format(
1224
                        username, project_auth_id, sa.provider.name
1225
                    )
1226
                )
1227
                self.storage_manager.revoke_access(
1✔
1228
                    provider=sa.provider.name,
1229
                    username=username,
1230
                    project=project,
1231
                    session=sess,
1232
                    google_bulk_mapping=google_bulk_mapping,
1233
                )
1234

1235
    def _grant_from_storage(
1✔
1236
        self, to_add, user_project, sess, google_bulk_mapping=None, expires=None
1237
    ):
1238
        """
1239
        If a project have storage backend, grant user's access to buckets in
1240
        the storage backend.
1241

1242
        Args:
1243
            to_add: a set of (username, project.auth_id)  to be granted
1244
            user_project: a dictionary like:
1245

1246
                    {username: {phsid: {'read-storage','write-storage'}}}
1247

1248
        Return:
1249
            dict of the users' storage usernames to their user_projects and the respective storage access.
1250
        """
1251
        storage_user_to_sa_and_user_project = defaultdict()
1✔
1252
        for username, project_auth_id in to_add:
1✔
1253
            project = self._projects[project_auth_id]
1✔
1254
            for sa in project.storage_access:
1✔
1255
                access = list(user_project[username][project_auth_id])
1✔
1256
                if not hasattr(self, "storage_manager"):
1✔
1257
                    self.logger.error(
×
1258
                        (
1259
                            "CANNOT grant {} access {} to {} in {} because there is NO "
1260
                            "configured storage accesses at all. See configuration. "
1261
                            "Continuing anyway..."
1262
                        ).format(username, access, project_auth_id, sa.provider.name)
1263
                    )
1264
                    continue
×
1265

1266
                self.logger.info(
1✔
1267
                    "grant {} access {} to {} in {}".format(
1268
                        username, access, project_auth_id, sa.provider.name
1269
                    )
1270
                )
1271
                storage_username = self.storage_manager.grant_access(
1✔
1272
                    provider=sa.provider.name,
1273
                    username=username,
1274
                    project=project,
1275
                    access=access,
1276
                    session=sess,
1277
                    google_bulk_mapping=google_bulk_mapping,
1278
                    expires=expires,
1279
                )
1280

1281
                storage_user_to_sa_and_user_project[storage_username] = (sa, project)
1✔
1282
        return storage_user_to_sa_and_user_project
1✔
1283

1284
    def _init_projects(self, user_project, sess):
1✔
1285
        """
1286
        initialize projects
1287
        """
1288

1289
        if self.project_mapping:
1✔
1290
            for projects in list(self.project_mapping.values()):
1✔
1291
                for p in projects:
1✔
1292
                    self.logger.debug(
1✔
1293
                        "creating Project with info from project_mapping: {}".format(p)
1294
                    )
1295
                    project = self._get_or_create(sess, Project, **p)
1✔
1296
                    self._projects[p["auth_id"]] = project
1✔
1297
        for _, projects in user_project.items():
1✔
1298
            for auth_id in list(projects.keys()):
1✔
1299
                project = sess.query(Project).filter(Project.auth_id == auth_id).first()
1✔
1300
                if not project:
1✔
1301
                    data = {"name": auth_id, "auth_id": auth_id}
1✔
1302
                    try:
1✔
1303
                        project = self._get_or_create(sess, Project, **data)
1✔
1304
                    except IntegrityError as e:
×
1305
                        sess.rollback()
×
1306
                        self.logger.error(
×
1307
                            f"Project {auth_id} already exists. Detail {str(e)}"
1308
                        )
1309
                        raise Exception(
×
1310
                            "Project {} already exists. Detail {}. Please contact your system administrator.".format(
1311
                                auth_id, str(e)
1312
                            )
1313
                        )
1314
                if auth_id not in self._projects:
1✔
1315
                    self._projects[auth_id] = project
1✔
1316

1317
    @staticmethod
1✔
1318
    def _get_or_create(sess, model, **kwargs):
1✔
1319
        instance = sess.query(model).filter_by(**kwargs).first()
1✔
1320
        if not instance:
1✔
1321
            instance = model(**kwargs)
1✔
1322
            sess.add(instance)
1✔
1323
        return instance
1✔
1324

1325
    def _process_dbgap_files(self, dbgap_config, sess):
1✔
1326
        """
1327
        Args:
1328
            dbgap_config : a dictionary containing information about a single
1329
                           dbgap sftp server (from fence config)
1330
            sess: database session
1331

1332
        Return:
1333
            user_projects (dict)
1334
            user_info (dict)
1335
        """
1336
        dbgap_file_list = []
1✔
1337
        hostname = dbgap_config["info"]["host"]
1✔
1338
        username = dbgap_config["info"]["username"]
1✔
1339
        encrypted = dbgap_config["info"].get("encrypted", True)
1✔
1340
        folderdir = os.path.join(str(self.folder), str(hostname), str(username))
1✔
1341

1342
        try:
1✔
1343
            if os.path.exists(folderdir):
1✔
1344
                dbgap_file_list = glob.glob(
×
1345
                    os.path.join(folderdir, "*")
1346
                )  # get lists of file from folder
1347
            else:
1348
                self.logger.info("Downloading files from: {}".format(hostname))
1✔
1349
                dbgap_file_list = self._download(dbgap_config)
1✔
1350
        except Exception as e:
1✔
1351
            self.logger.error(e)
1✔
1352
            exit(1)
1✔
1353
        self.logger.info("dbgap files: {}".format(dbgap_file_list))
×
1354
        user_projects, user_info = self._get_user_permissions_from_csv_list(
×
1355
            dbgap_file_list,
1356
            encrypted=encrypted,
1357
            session=sess,
1358
            dbgap_config=dbgap_config,
1359
        )
1360

1361
        user_projects = self.parse_projects(user_projects)
×
1362
        return user_projects, user_info
×
1363

1364
    def _get_user_permissions_from_csv_list(
1✔
1365
        self, file_list, encrypted, session, dbgap_config={}
1366
    ):
1367
        """
1368
        Args:
1369
            file_list: list of files (represented as strings)
1370
            encrypted: boolean indicating whether those files are encrypted
1371
            session: sqlalchemy session
1372
            dbgap_config: a dictionary containing information about the dbGaP sftp server
1373
                    (comes from fence config)
1374

1375
        Return:
1376
            user_projects (dict)
1377
            user_info (dict)
1378
        """
1379
        permissions = [{"read-storage", "read"} for _ in file_list]
1✔
1380
        user_projects, user_info = self._parse_csv(
1✔
1381
            dict(list(zip(file_list, permissions))),
1382
            sess=session,
1383
            dbgap_config=dbgap_config,
1384
            encrypted=encrypted,
1385
        )
1386
        return user_projects, user_info
1✔
1387

1388
    def _merge_multiple_local_csv_files(
1✔
1389
        self, dbgap_file_list, encrypted, dbgap_configs, session
1390
    ):
1391
        """
1392
        Args:
1393
            dbgap_file_list (list): a list of whitelist file locations stored locally
1394
            encrypted (bool): whether the file is encrypted (comes from fence config)
1395
            dbgap_configs (list): list of dictionaries containing information about the dbgap server (comes from fence config)
1396
            session (sqlalchemy.Session): database session
1397

1398
        Return:
1399
            merged_user_projects (dict)
1400
            merged_user_info (dict)
1401
        """
1402
        merged_user_projects = {}
1✔
1403
        merged_user_info = {}
1✔
1404

1405
        for dbgap_config in dbgap_configs:
1✔
1406
            user_projects, user_info = self._get_user_permissions_from_csv_list(
1✔
1407
                dbgap_file_list,
1408
                encrypted,
1409
                session=session,
1410
                dbgap_config=dbgap_config,
1411
            )
1412
            self.sync_two_user_info_dict(user_info, merged_user_info)
1✔
1413
            self.sync_two_phsids_dict(user_projects, merged_user_projects)
1✔
1414
        return merged_user_projects, merged_user_info
1✔
1415

1416
    def _merge_multiple_dbgap_sftp(self, dbgap_servers, sess):
1✔
1417
        """
1418
        Args:
1419
            dbgap_servers : a list of dictionaries each containging config on
1420
                           dbgap sftp server (comes from fence config)
1421
            sess: database session
1422

1423
        Return:
1424
            merged_user_projects (dict)
1425
            merged_user_info (dict)
1426
        """
1427
        merged_user_projects = {}
1✔
1428
        merged_user_info = {}
1✔
1429
        for dbgap in dbgap_servers:
1✔
1430
            user_projects, user_info = self._process_dbgap_files(dbgap, sess)
1✔
1431
            # merge into merged_user_info
1432
            # user_info overrides original info in merged_user_info
1433
            self.sync_two_user_info_dict(user_info, merged_user_info)
1✔
1434

1435
            # merge all access info dicts into "merged_user_projects".
1436
            # the access info is combined - if the user_projects access is
1437
            # ["read"] and the merged_user_projects is ["read-storage"], the
1438
            # resulting access is ["read", "read-storage"].
1439
            self.sync_two_phsids_dict(user_projects, merged_user_projects)
1✔
1440
        return merged_user_projects, merged_user_info
1✔
1441

1442
    def parse_projects(self, user_projects):
1✔
1443
        """
1444
        helper function for parsing projects
1445
        """
1446
        return {key.lower(): value for key, value in user_projects.items()}
1✔
1447

1448
    def _process_dbgap_project(
1✔
1449
        self, dbgap_project, privileges, username, sess, user_projects, dbgap_config
1450
    ):
1451
        if dbgap_project not in self.project_mapping:
1✔
1452
            self._add_dbgap_project_for_user(
1✔
1453
                dbgap_project,
1454
                privileges,
1455
                username,
1456
                sess,
1457
                user_projects,
1458
                dbgap_config,
1459
            )
1460

1461
        for element_dict in self.project_mapping.get(dbgap_project, []):
1✔
1462
            try:
1✔
1463
                phsid_privileges = {element_dict["auth_id"]: set(privileges)}
1✔
1464

1465
                # need to add dbgap project to arborist
1466
                if self.arborist_client:
1✔
1467
                    self._determine_arborist_resource(
1✔
1468
                        element_dict["auth_id"], dbgap_config
1469
                    )
1470

1471
                if username not in user_projects:
1✔
1472
                    user_projects[username] = {}
1✔
1473
                user_projects[username].update(phsid_privileges)
1✔
1474

1475
            except ValueError as e:
×
1476
                self.logger.info(e)
×
1477

1478
    def _process_user_projects(
1✔
1479
        self,
1480
        user_projects,
1481
        enable_common_exchange_area_access,
1482
        study_common_exchange_areas,
1483
        dbgap_config,
1484
        sess,
1485
    ):
1486
        user_projects_to_modify = copy.deepcopy(user_projects)
1✔
1487
        for username in user_projects.keys():
1✔
1488
            for project in user_projects[username].keys():
1✔
1489
                phsid = project.split(".")
1✔
1490
                dbgap_project = phsid[0]
1✔
1491
                privileges = user_projects[username][project]
1✔
1492
                if len(phsid) > 1 and self._get_parse_consent_code(dbgap_config):
1✔
1493
                    consent_code = phsid[-1]
1✔
1494

1495
                    # c999 indicates full access to all consents and access
1496
                    # to a study-specific exchange area
1497
                    # access to at least one study-specific exchange area implies access
1498
                    # to the parent study's common exchange area
1499
                    #
1500
                    # NOTE: Handling giving access to all consents is done at
1501
                    #       a later time, when we have full information about possible
1502
                    #       consents
1503
                    self.logger.debug(
1✔
1504
                        f"got consent code {consent_code} from dbGaP project "
1505
                        f"{dbgap_project}"
1506
                    )
1507
                    if (
1✔
1508
                        consent_code == "c999"
1509
                        and enable_common_exchange_area_access
1510
                        and dbgap_project in study_common_exchange_areas
1511
                    ):
1512
                        self.logger.info(
1✔
1513
                            "found study with consent c999 and Fence "
1514
                            "is configured to parse exchange area data. Giving user "
1515
                            f"{username} {privileges} privileges in project: "
1516
                            f"{study_common_exchange_areas[dbgap_project]}."
1517
                        )
1518
                        self._add_dbgap_project_for_user(
1✔
1519
                            study_common_exchange_areas[dbgap_project],
1520
                            privileges,
1521
                            username,
1522
                            sess,
1523
                            user_projects_to_modify,
1524
                            dbgap_config,
1525
                        )
1526

1527
                    dbgap_project += "." + consent_code
1✔
1528

1529
                self._process_dbgap_project(
1✔
1530
                    dbgap_project,
1531
                    privileges,
1532
                    username,
1533
                    sess,
1534
                    user_projects_to_modify,
1535
                    dbgap_config,
1536
                )
1537
        for user in user_projects_to_modify.keys():
1✔
1538
            user_projects[user] = user_projects_to_modify[user]
1✔
1539

1540
    def sync(self):
1✔
1541
        if self.session:
1✔
1542
            self._sync(self.session)
1✔
1543
        else:
1544
            with self.driver.session as s:
×
1545
                self._sync(s)
×
1546

1547
    def download(self):
1✔
1548
        for dbgap_server in self.dbGaP:
×
1549
            self._download(dbgap_server)
×
1550

1551
    def _download(self, dbgap_config):
1✔
1552
        """
1553
        Download files from dbgap server.
1554
        """
1555
        server = dbgap_config["info"]
1✔
1556
        protocol = dbgap_config["protocol"]
1✔
1557
        hostname = server["host"]
1✔
1558
        username = server["username"]
1✔
1559
        folderdir = os.path.join(str(self.folder), str(hostname), str(username))
1✔
1560

1561
        if not os.path.exists(folderdir):
1✔
1562
            os.makedirs(folderdir)
1✔
1563

1564
        self.logger.info("Download from server")
1✔
1565
        try:
1✔
1566
            if protocol == "sftp":
1✔
1567
                self._get_from_sftp_with_proxy(server, folderdir)
1✔
1568
            else:
1569
                self._get_from_ftp_with_proxy(server, folderdir)
×
1570
            dbgap_files = glob.glob(os.path.join(folderdir, "*"))
×
1571
            return dbgap_files
×
1572
        except Exception as e:
1✔
1573
            self.logger.error(e)
1✔
1574
            raise
1✔
1575

1576
    def _sync(self, sess):
1✔
1577
        """
1578
        Collect files from dbgap server(s), sync csv and yaml files to storage
1579
        backend and fence DB
1580
        """
1581
        # get all dbgap files
1582
        user_projects = {}
1✔
1583
        user_info = {}
1✔
1584
        if self.is_sync_from_dbgap_server:
1✔
1585
            self.logger.debug(
1✔
1586
                "Pulling telemetry files from {} dbgap sftp servers".format(
1587
                    len(self.dbGaP)
1588
                )
1589
            )
1590
            user_projects, user_info = self._merge_multiple_dbgap_sftp(self.dbGaP, sess)
1✔
1591

1592
        local_csv_file_list = []
1✔
1593
        if self.sync_from_local_csv_dir:
1✔
1594
            local_csv_file_list = glob.glob(
1✔
1595
                os.path.join(self.sync_from_local_csv_dir, "*")
1596
            )
1597
            # Sort the list so the order of of files is consistent across platforms
1598
            local_csv_file_list.sort()
1✔
1599

1600
        user_projects_csv, user_info_csv = self._merge_multiple_local_csv_files(
1✔
1601
            local_csv_file_list,
1602
            encrypted=False,
1603
            session=sess,
1604
            dbgap_configs=self.dbGaP,
1605
        )
1606

1607
        try:
1✔
1608
            user_yaml = UserYAML.from_file(
1✔
1609
                self.sync_from_local_yaml_file, encrypted=False, logger=self.logger
1610
            )
1611
        except (EnvironmentError, AssertionError) as e:
1✔
1612
            self.logger.error(str(e))
1✔
1613
            self.logger.error("aborting early")
1✔
1614
            raise
1✔
1615

1616
        # parse all projects
1617
        user_projects_csv = self.parse_projects(user_projects_csv)
1✔
1618
        user_projects = self.parse_projects(user_projects)
1✔
1619
        user_yaml.projects = self.parse_projects(user_yaml.projects)
1✔
1620

1621
        # merge all user info dicts into "user_info".
1622
        # the user info (such as email) in the user.yaml files
1623
        # overrides the user info from the CSV files.
1624
        self.sync_two_user_info_dict(user_info_csv, user_info)
1✔
1625
        self.sync_two_user_info_dict(user_yaml.user_info, user_info)
1✔
1626

1627
        # merge all access info dicts into "user_projects".
1628
        # the access info is combined - if the user.yaml access is
1629
        # ["read"] and the CSV file access is ["read-storage"], the
1630
        # resulting access is ["read", "read-storage"].
1631
        self.sync_two_phsids_dict(
1✔
1632
            user_projects_csv, user_projects, source1="local_csv", source2="dbgap"
1633
        )
1634
        self.sync_two_phsids_dict(
1✔
1635
            user_yaml.projects, user_projects, source1="user_yaml", source2="dbgap"
1636
        )
1637

1638
        # Note: if there are multiple dbgap sftp servers configured
1639
        # this parameter is always from the config for the first dbgap sftp server
1640
        # not any additional ones
1641
        for dbgap_config in self.dbGaP:
1✔
1642
            if self._get_parse_consent_code(dbgap_config):
1✔
1643
                self._grant_all_consents_to_c999_users(
1✔
1644
                    user_projects, user_yaml.project_to_resource
1645
                )
1646

1647
        google_update_ex = None
1✔
1648

1649
        try:
1✔
1650
            # update the Fence DB
1651
            if user_projects:
1✔
1652
                self.logger.info("Sync to db and storage backend")
1✔
1653
                self.sync_to_db_and_storage_backend(user_projects, user_info, sess)
1✔
1654
                self.logger.info("Finish syncing to db and storage backend")
1✔
1655
            else:
1656
                self.logger.info("No users for syncing")
×
1657
        except GoogleUpdateException as ex:
1✔
1658
            # save this to reraise later after all non-Google syncing has finished
1659
            # this way, any issues with Google only affect Google data access and don't
1660
            # cascade problems into non-Google AWS or Azure access
1661
            google_update_ex = ex
1✔
1662

1663
        # update the Arborist DB (resources, roles, policies, groups)
1664
        if user_yaml.authz:
1✔
1665
            if not self.arborist_client:
1✔
1666
                raise EnvironmentError(
×
1667
                    "yaml file contains authz section but sync is not configured with"
1668
                    " arborist client--did you run sync with --arborist <arborist client> arg?"
1669
                )
1670
            self.logger.info("Synchronizing arborist...")
1✔
1671
            success = self._update_arborist(sess, user_yaml)
1✔
1672
            if success:
1✔
1673
                self.logger.info("Finished synchronizing arborist")
1✔
1674
            else:
1675
                self.logger.error("Could not synchronize successfully")
×
1676
                exit(1)
×
1677
        else:
1678
            self.logger.info("No `authz` section; skipping arborist sync")
×
1679

1680
        # update the Arborist DB (user access)
1681
        if self.arborist_client:
1✔
1682
            self.logger.info("Synchronizing arborist with authorization info...")
1✔
1683
            success = self._update_authz_in_arborist(sess, user_projects, user_yaml)
1✔
1684
            if success:
1✔
1685
                self.logger.info(
1✔
1686
                    "Finished synchronizing authorization info to arborist"
1687
                )
1688
            else:
1689
                self.logger.error(
×
1690
                    "Could not synchronize authorization info successfully to arborist"
1691
                )
1692
                exit(1)
×
1693
        else:
1694
            self.logger.error("No arborist client set; skipping arborist sync")
×
1695

1696
        # Logging authz source
1697
        for u, s in self.auth_source.items():
1✔
1698
            self.logger.info("Access for user {} from {}".format(u, s))
1✔
1699

1700
        self.logger.info(
1✔
1701
            f"Persisting authz mapping to database: {user_yaml.project_to_resource}"
1702
        )
1703
        user_yaml.persist_project_to_resource(db_session=sess)
1✔
1704
        if google_update_ex is not None:
1✔
1705
            raise google_update_ex
1✔
1706

1707
    def _grant_all_consents_to_c999_users(
1✔
1708
        self, user_projects, user_yaml_project_to_resources
1709
    ):
1710
        access_number_matcher = re.compile(config["DBGAP_ACCESSION_WITH_CONSENT_REGEX"])
1✔
1711
        # combine dbgap/user.yaml projects into one big list (in case not all consents
1712
        # are in either)
1713
        all_projects = set(
1✔
1714
            list(self._projects.keys()) + list(user_yaml_project_to_resources.keys())
1715
        )
1716

1717
        self.logger.debug(f"all projects: {all_projects}")
1✔
1718

1719
        # construct a mapping from phsid (without consent) to all accessions with consent
1720
        consent_mapping = {}
1✔
1721
        for project in all_projects:
1✔
1722
            phs_match = access_number_matcher.match(project)
1✔
1723
            if phs_match:
1✔
1724
                accession_number = phs_match.groupdict()
1✔
1725

1726
                # TODO: This is not handling the .v1.p1 at all
1727
                consent_mapping.setdefault(accession_number["phsid"], set()).add(
1✔
1728
                    ".".join([accession_number["phsid"], accession_number["consent"]])
1729
                )
1730
                children = self._get_children(accession_number["phsid"])
1✔
1731
                if children:
1✔
1732
                    for child_phs in children:
1✔
1733
                        consent_mapping.setdefault(child_phs, set()).add(
1✔
1734
                            ".".join(
1735
                                [child_phs, accession_number["consent"]]
1736
                            )  # Assign parent consent to child study
1737
                        )
1738

1739
        self.logger.debug(f"consent mapping: {consent_mapping}")
1✔
1740

1741
        # go through existing access and find any c999's and make sure to give access to
1742
        # all accessions with consent for that phsid
1743
        for username, user_project_info in copy.deepcopy(user_projects).items():
1✔
1744
            for project, _ in user_project_info.items():
1✔
1745
                phs_match = access_number_matcher.match(project)
1✔
1746
                if phs_match and phs_match.groupdict()["consent"] == "c999":
1✔
1747
                    # give access to all consents
1748
                    all_phsids_with_consent = consent_mapping.get(
1✔
1749
                        phs_match.groupdict()["phsid"], []
1750
                    )
1751
                    self.logger.info(
1✔
1752
                        f"user {username} has c999 consent group for: {project}. "
1753
                        f"Granting access to all consents: {all_phsids_with_consent}"
1754
                    )
1755
                    # NOTE: Only giving read-storage at the moment (this is same
1756
                    #       permission we give for other dbgap projects)
1757
                    for phsid_with_consent in all_phsids_with_consent:
1✔
1758
                        user_projects[username].update(
1✔
1759
                            {phsid_with_consent: {"read-storage", "read"}}
1760
                        )
1761

1762
    def _update_arborist(self, session, user_yaml):
1✔
1763
        """
1764
        Create roles, resources, policies, groups in arborist from the information in
1765
        ``user_yaml``.
1766

1767
        The projects are sent to arborist as resources with paths like
1768
        ``/projects/{project}``. Roles are created with just the original names
1769
        for the privileges like ``"read-storage", "read"`` etc.
1770

1771
        Args:
1772
            session (sqlalchemy.Session)
1773
            user_yaml (UserYAML)
1774

1775
        Return:
1776
            bool: success
1777
        """
1778
        healthy = self._is_arborist_healthy()
1✔
1779
        if not healthy:
1✔
1780
            return False
×
1781

1782
        # Set up the resource tree in arborist by combining provided resources with any
1783
        # dbgap resources that were created before this.
1784
        #
1785
        # Why add dbgap resources if they've already been created?
1786
        #   B/C Arborist's PUT update will override existing subresources. So if a dbgap
1787
        #   resources was created under `/programs/phs000178` anything provided in
1788
        #   user.yaml under `/programs` would completely wipe it out.
1789
        resources = user_yaml.authz.get("resources", [])
1✔
1790

1791
        dbgap_resource_paths = []
1✔
1792
        for path_list in self._dbgap_study_to_resources.values():
1✔
1793
            dbgap_resource_paths.extend(path_list)
1✔
1794

1795
        self.logger.debug("user_yaml resources: {}".format(resources))
1✔
1796
        self.logger.debug("dbgap resource paths: {}".format(dbgap_resource_paths))
1✔
1797

1798
        combined_resources = utils.combine_provided_and_dbgap_resources(
1✔
1799
            resources, dbgap_resource_paths
1800
        )
1801

1802
        for resource in combined_resources:
1✔
1803
            try:
1✔
1804
                self.logger.debug(
1✔
1805
                    "attempting to update arborist resource: {}".format(resource)
1806
                )
1807
                self.arborist_client.update_resource("/", resource, merge=True)
1✔
1808
            except ArboristError as e:
×
1809
                self.logger.error(e)
×
1810
                # keep going; maybe just some conflicts from things existing already
1811

1812
        # update roles
1813
        roles = user_yaml.authz.get("roles", [])
1✔
1814
        for role in roles:
1✔
1815
            try:
1✔
1816
                response = self.arborist_client.update_role(role["id"], role)
1✔
1817
                if response:
1✔
1818
                    self._created_roles.add(role["id"])
1✔
1819
            except ArboristError as e:
×
1820
                self.logger.info(
×
1821
                    "couldn't update role '{}', creating instead".format(str(e))
1822
                )
1823
                try:
×
1824
                    response = self.arborist_client.create_role(role)
×
1825
                    if response:
×
1826
                        self._created_roles.add(role["id"])
×
1827
                except ArboristError as e:
×
1828
                    self.logger.error(e)
×
1829
                    # keep going; maybe just some conflicts from things existing already
1830

1831
        # update policies
1832
        policies = user_yaml.authz.get("policies", [])
1✔
1833
        for policy in policies:
1✔
1834
            policy_id = policy.pop("id")
1✔
1835
            try:
1✔
1836
                self.logger.debug(
1✔
1837
                    "Trying to upsert policy with id {}".format(policy_id)
1838
                )
1839
                response = self.arborist_client.update_policy(
1✔
1840
                    policy_id, policy, create_if_not_exist=True
1841
                )
1842
            except ArboristError as e:
×
1843
                self.logger.error(e)
×
1844
                # keep going; maybe just some conflicts from things existing already
1845
            else:
1846
                if response:
1✔
1847
                    self.logger.debug("Upserted policy with id {}".format(policy_id))
1✔
1848
                    self._created_policies.add(policy_id)
1✔
1849

1850
        # update groups
1851
        groups = user_yaml.authz.get("groups", [])
1✔
1852

1853
        # delete from arborist the groups that have been deleted
1854
        # from the user.yaml
1855
        arborist_groups = set(
1✔
1856
            g["name"] for g in self.arborist_client.list_groups().get("groups", [])
1857
        )
1858
        useryaml_groups = set(g["name"] for g in groups)
1✔
1859
        for deleted_group in arborist_groups.difference(useryaml_groups):
1✔
1860
            # do not try to delete built in groups
1861
            if deleted_group not in ["anonymous", "logged-in"]:
×
1862
                self.arborist_client.delete_group(deleted_group)
×
1863

1864
        # create/update the groups defined in the user.yaml
1865
        for group in groups:
1✔
1866
            missing = {"name", "users", "policies"}.difference(set(group.keys()))
×
1867
            if missing:
×
1868
                name = group.get("name", "{MISSING NAME}")
×
1869
                self.logger.error(
×
1870
                    "group {} missing required field(s): {}".format(name, list(missing))
1871
                )
1872
                continue
×
1873
            try:
×
1874
                response = self.arborist_client.put_group(
×
1875
                    group["name"],
1876
                    # Arborist doesn't handle group descriptions yet
1877
                    # description=group.get("description", ""),
1878
                    users=group["users"],
1879
                    policies=group["policies"],
1880
                )
1881
            except ArboristError as e:
×
1882
                self.logger.info("couldn't put group: {}".format(str(e)))
×
1883

1884
        # Update policies for built-in (`anonymous` and `logged-in`) groups
1885

1886
        # First recreate these groups in order to clear out old, possibly deleted policies
1887
        for builtin_group in ["anonymous", "logged-in"]:
1✔
1888
            try:
1✔
1889
                response = self.arborist_client.put_group(builtin_group)
1✔
1890
            except ArboristError as e:
×
1891
                self.logger.info("couldn't put group: {}".format(str(e)))
×
1892

1893
        # Now add back policies that are in the user.yaml
1894
        for policy in user_yaml.authz.get("anonymous_policies", []):
1✔
1895
            self.arborist_client.grant_group_policy("anonymous", policy)
×
1896

1897
        for policy in user_yaml.authz.get("all_users_policies", []):
1✔
1898
            self.arborist_client.grant_group_policy("logged-in", policy)
×
1899

1900
        return True
1✔
1901

1902
    def _revoke_all_policies_preserve_mfa(self, username, idp=None):
1✔
1903
        """
1904
        If MFA is enabled for the user's idp, check if they have the /multifactor_auth resource and restore the
1905
        mfa_policy after revoking all policies.
1906
        """
1907

1908
        is_mfa_enabled = "multifactor_auth_claim_info" in config["OPENID_CONNECT"].get(
1✔
1909
            idp, {}
1910
        )
1911

1912
        if not is_mfa_enabled:
1✔
1913
            # TODO This should be a diff, not a revocation of all policies.
1914
            self.arborist_client.revoke_all_policies_for_user(username)
1✔
1915
            return
1✔
1916

1917
        policies = []
1✔
1918
        try:
1✔
1919
            user_data_from_arborist = self.arborist_client.get_user(username)
1✔
1920
            policies = user_data_from_arborist["policies"]
1✔
1921
        except Exception as e:
×
1922
            self.logger.error(
×
1923
                f"Could not retrieve user's policies, revoking all policies anyway. {e}"
1924
            )
1925
        finally:
1926
            # TODO This should be a diff, not a revocation of all policies.
1927
            self.arborist_client.revoke_all_policies_for_user(username)
1✔
1928

1929
        if "mfa_policy" in policies:
1✔
1930
            self.arborist_client.grant_user_policy(username, "mfa_policy")
1✔
1931

1932
    def _grant_arborist_policies(
1✔
1933
        self, username, incoming_policies, user_yaml, expires=None
1934
    ):
1935
        """
1936
        Find the difference between the existing policies for a user and the incoming policies,
1937
        and decide whether to add, remove, or keep policies.
1938

1939
        Args:
1940
            username (str): the username of the user
1941
            incoming_policies (set): set of policies to be applied to the user
1942
            user_yaml (UserYAML): UserYAML object containing authz information
1943
            expires (int): time at which authz info in Arborist should expire
1944

1945
        Return:
1946
            bool: True if policies were successfully updated, False otherwise
1947
        """
1948
        user_existing_policies = set()
1✔
1949
        to_add = set()
1✔
1950
        to_remove = set()
1✔
1951
        is_revoke_all = False
1✔
1952

1953
        try:
1✔
1954
            user_existing_policies = set(
1✔
1955
                policy["policy"]
1956
                for policy in self.arborist_client.get_user(username)["policies"]
1957
            )
1958
            self.logger.info(
1✔
1959
                f"Fetched user {username} existing policies: {user_existing_policies}"
1960
            )
1961
        except ArboristError as e:
1✔
1962
            self.logger.error(
1✔
1963
                f"Could not get user {username} policies from Arborist: {e} Revoking all policies..."
1964
            )
1965
            # if getting existing policies fails, revoke all policies and re-apply
1966
            is_revoke_all = True
1✔
1967

1968
        if is_revoke_all is False and len(incoming_policies) > 0:
1✔
1969
            to_add = incoming_policies - user_existing_policies
1✔
1970
            to_remove = user_existing_policies - incoming_policies
1✔
1971

1972
            if user_yaml:
1✔
1973
                anonymous_policies = set()
1✔
1974
                for policy in to_remove:
1✔
1975
                    if policy in user_yaml.authz.get(
×
1976
                        "anonymous_policies", []
1977
                    ) or policy in user_yaml.authz.get("all_users_policies", []):
1978
                        self.logger.warning(
×
1979
                            f"Policy {policy} is an anonymous policy, not revoking it for user {username}."
1980
                        )
1981
                        anonymous_policies.add(policy)
×
1982
                to_remove -= anonymous_policies
1✔
1983
        else:
1984
            # if incoming_policies is empty, we revoke all policies
1985
            is_revoke_all = True
1✔
1986

1987
        if not is_revoke_all:
1✔
1988
            try:
1✔
1989
                if to_remove:
1✔
1990
                    for policy in to_remove:
1✔
1991
                        self.logger.info(
1✔
1992
                            f"Revoking policy {policy} for user {username}."
1993
                        )
1994
                        self.arborist_client.revoke_user_policy(username, policy)
1✔
1995
            except ArboristError as e:
×
1996
                self.logger.error(
×
1997
                    f"Could not revoke user {username} policy {policy}. Revoking all instead: {e}"
1998
                )
1999
                is_revoke_all = True
×
2000

2001
        if is_revoke_all:
1✔
2002
            try:
1✔
2003
                self.logger.info(f"Revoking all policies for user {username}.")
1✔
2004
                self.arborist_client.revoke_all_policies_for_user(username)
1✔
2005
            except ArboristError as e:
×
2006
                self.logger.error(
×
2007
                    f"Could not revoke all policies for user {username}. Error: {e}"
2008
                )
2009
                return False
×
2010
            to_add = incoming_policies  # if we revoke all, we need to add all incoming policies
1✔
2011

2012
        if (
1✔
2013
            "mfa_policy" not in incoming_policies
2014
            and "mfa_policy" in user_existing_policies
2015
        ):
2016
            to_add.add("mfa_policy")
×
2017

2018
        if to_add:
1✔
2019
            self.logger.info(f"Bulk granting user {username} policies {to_add}.")
1✔
2020
            return self._grant_bulk_user_policies(username, to_add, expires)
1✔
2021

2022
        return True
1✔
2023

2024
    def _update_authz_in_arborist(
1✔
2025
        self,
2026
        session,
2027
        user_projects,
2028
        user_yaml=None,
2029
        single_user_sync=False,
2030
        expires=None,
2031
    ):
2032
        """
2033
        Assign users policies in arborist from the information in
2034
        ``user_projects`` and optionally a ``user_yaml``.
2035

2036
        The projects are sent to arborist as resources with paths like
2037
        ``/projects/{project}``. Roles are created with just the original names
2038
        for the privileges like ``"read-storage", "read"`` etc.
2039

2040
        Args:
2041
            user_projects (dict)
2042
            user_yaml (UserYAML) optional, if there are policies for users in a user.yaml
2043
            single_user_sync (bool) whether authz update is for a single user
2044
            expires (int) time at which authz info in Arborist should expire
2045

2046
        Return:
2047
            bool: success
2048
        """
2049
        healthy = self._is_arborist_healthy()
1✔
2050
        if not healthy:
1✔
2051
            return False
×
2052

2053
        self.logger.debug("user_projects: {}".format(user_projects))
1✔
2054

2055
        if user_yaml:
1✔
2056
            self.logger.debug(
1✔
2057
                "useryaml abac before lowering usernames: {}".format(
2058
                    user_yaml.user_abac
2059
                )
2060
            )
2061
            user_yaml.user_abac = {
1✔
2062
                key.lower(): value for key, value in user_yaml.user_abac.items()
2063
            }
2064
            # update the project info with `projects` specified in user.yaml
2065
            self.sync_two_phsids_dict(user_yaml.user_abac, user_projects)
1✔
2066

2067
        # get list of users from arborist to make sure users that are completely removed
2068
        # from authorization sources get policies revoked
2069

2070
        arborist_user_projects = {}
1✔
2071
        if not single_user_sync:
1✔
2072

2073
            try:
1✔
2074
                arborist_users = self.arborist_client.get_users().json["users"]
1✔
2075

2076
                # construct user information, NOTE the lowering of the username. when adding/
2077
                # removing access, the case in the Fence db is used. For combining access, it is
2078
                # case-insensitive, so we lower
2079
                arborist_user_projects = {
1✔
2080
                    user["name"].lower(): {} for user in arborist_users
2081
                }
2082
            except (ArboristError, KeyError, AttributeError) as error:
×
2083
                # TODO usersync should probably exit with non-zero exit code at the end,
2084
                #      but sync should continue from this point so there are no partial
2085
                #      updates
2086
                self.logger.warning(
×
2087
                    "Could not get list of users in Arborist, continuing anyway. "
2088
                    "WARNING: this sync will NOT remove access for users no longer in "
2089
                    f"authorization sources. Error: {error}"
2090
                )
2091

2092
            # update the project info with users from arborist
2093
            self.sync_two_phsids_dict(arborist_user_projects, user_projects)
1✔
2094

2095
        # prefer in-memory if available from user_yaml, if not, get from database
2096
        if user_yaml and user_yaml.project_to_resource:
1✔
2097
            project_to_authz_mapping = user_yaml.project_to_resource
1✔
2098
            self.logger.debug(
1✔
2099
                f"using in-memory project to authz resource mapping from "
2100
                f"user.yaml (instead of database): {project_to_authz_mapping}"
2101
            )
2102
        else:
2103
            project_to_authz_mapping = get_project_to_authz_mapping(session)
1✔
2104
            self.logger.debug(
1✔
2105
                f"using persisted project to authz resource mapping from database "
2106
                f"(instead of user.yaml - as it may not be available): {project_to_authz_mapping}"
2107
            )
2108

2109
        self.logger.debug(
1✔
2110
            f"_dbgap_study_to_resources: {self._dbgap_study_to_resources}"
2111
        )
2112
        all_resources = [
1✔
2113
            r
2114
            for resources in self._dbgap_study_to_resources.values()
2115
            for r in resources
2116
        ]
2117
        all_resources.extend(r for r in project_to_authz_mapping.values())
1✔
2118
        self._create_arborist_resources(all_resources)
1✔
2119

2120
        for username, user_project_info in user_projects.items():
1✔
2121
            self.logger.info("processing user `{}`".format(username))
1✔
2122
            user = query_for_user(session=session, username=username)
1✔
2123
            idp = None
1✔
2124
            if user:
1✔
2125
                username = user.username
1✔
2126
                idp = user.identity_provider.name if user.identity_provider else None
1✔
2127

2128
            self.arborist_client.create_user_if_not_exist(username)
1✔
2129

2130
            # as of 2/11/2022, for single_user_sync, as RAS visa parsing has
2131
            # previously mapped each project to the same set of privileges
2132
            # (i.e.{'read', 'read-storage'}), unique_policies will just be a
2133
            # single policy with ('read', 'read-storage') being the single
2134
            # key
2135
            unique_policies = self._determine_unique_policies(
1✔
2136
                user_project_info, project_to_authz_mapping
2137
            )
2138
            for roles in unique_policies.keys():
1✔
2139
                for role in roles:
1✔
2140
                    self._create_arborist_role(role)
1✔
2141

2142
            incoming_policies = set()  # set of policies for current user.
1✔
2143

2144
            if single_user_sync:
1✔
2145
                for ordered_roles, ordered_resources in unique_policies.items():
1✔
2146
                    policy_hash = self._hash_policy_contents(
1✔
2147
                        ordered_roles, ordered_resources
2148
                    )
2149
                    self._create_arborist_policy(
1✔
2150
                        policy_hash,
2151
                        ordered_roles,
2152
                        ordered_resources,
2153
                        skip_if_exists=True,
2154
                    )
2155
                    # return here as it is not expected single_user_sync
2156
                    # will need any of the remaining user_yaml operations
2157
                    # left in _update_authz_in_arborist
2158
                    return self._grant_arborist_policy(
1✔
2159
                        username, policy_hash, expires=expires
2160
                    )
2161
            else:
2162
                policy_ids_to_grant = set()
1✔
2163
                for roles, resources in unique_policies.items():
1✔
2164
                    for role in roles:
1✔
2165
                        for resource in resources:
1✔
2166
                            # grant a policy to this user which is a single
2167
                            # role on a single resource
2168

2169
                            # format project '/x/y/z' -> 'x.y.z'
2170
                            # so the policy id will be something like 'x.y.z-create'
2171
                            policy_id = _format_policy_id(resource, role)
1✔
2172
                            incoming_policies.add(policy_id)
1✔
2173
                            if policy_id not in self._created_policies:
1✔
2174
                                try:
1✔
2175
                                    self.arborist_client.update_policy(
1✔
2176
                                        policy_id,
2177
                                        {
2178
                                            "description": "policy created by fence sync",
2179
                                            "role_ids": [role],
2180
                                            "resource_paths": [resource],
2181
                                        },
2182
                                        create_if_not_exist=True,
2183
                                    )
2184
                                except ArboristError as e:
×
2185
                                    self.logger.info(
×
2186
                                        "not creating policy in arborist; {}".format(
2187
                                            str(e)
2188
                                        )
2189
                                    )
2190
                                self._created_policies.add(policy_id)
1✔
2191
                            policy_ids_to_grant.add(policy_id)
1✔
2192
                self._grant_arborist_policies(
1✔
2193
                    username, policy_ids_to_grant, user_yaml=None, expires=expires
2194
                )
2195

2196
            if user_yaml:
1✔
2197
                user_yaml_policies = set(user_yaml.policies.get(username, []))
1✔
2198
                incoming_policies = (
1✔
2199
                    incoming_policies | user_yaml_policies
2200
                )  # add policies from whitelist and useryaml
2201

2202
            self._grant_arborist_policies(
1✔
2203
                username, incoming_policies, user_yaml, expires=expires
2204
            )
2205

2206
        if user_yaml:
1✔
2207
            for client_name, client_details in user_yaml.clients.items():
1✔
2208
                client_policies = client_details.get("policies", [])
×
2209
                clients = session.query(Client).filter_by(name=client_name).all()
×
2210
                # update existing clients, do not create new ones
2211
                if not clients:
×
2212
                    self.logger.warning(
×
2213
                        "client to update (`{}`) does not exist in fence: skipping".format(
2214
                            client_name
2215
                        )
2216
                    )
2217
                    continue
×
2218
                self.logger.debug(
×
2219
                    "updating client `{}` (found {} client IDs)".format(
2220
                        client_name, len(clients)
2221
                    )
2222
                )
2223
                # there may be more than 1 client with this name if credentials are being rotated,
2224
                # so we grant access to each client ID
2225
                for client in clients:
×
2226
                    try:
×
2227
                        self.arborist_client.update_client(
×
2228
                            client.client_id, client_policies
2229
                        )
2230
                    except ArboristError as e:
×
2231
                        self.logger.info(
×
2232
                            "not granting policies {} to client `{}` (`{}`); {}".format(
2233
                                client_policies, client_name, client.client_id, str(e)
2234
                            )
2235
                        )
2236

2237
        return True
1✔
2238

2239
    def _determine_unique_policies(self, user_project_info, project_to_authz_mapping):
1✔
2240
        """
2241
        Determine and return a dictionary of unique policies.
2242

2243
        Args (examples):
2244
            user_project_info (dict):
2245
            {
2246
                'phs000002.c1': { 'read-storage', 'read' },
2247
                'phs000001.c1': { 'read', 'read-storage' },
2248
                'phs000004.c1': { 'write', 'read' },
2249
                'phs000003.c1': { 'read', 'write' },
2250
                'phs000006.c1': { 'write-storage', 'write', 'read-storage', 'read' }
2251
                'phs000005.c1': { 'read', 'read-storage', 'write', 'write-storage' },
2252
            }
2253
            project_to_authz_mapping (dict):
2254
            {
2255
                'phs000001.c1': '/programs/DEV/projects/phs000001.c1'
2256
            }
2257

2258
        Return (for examples):
2259
            dict:
2260
            {
2261
                ('read', 'read-storage'): ('phs000001.c1', 'phs000002.c1'),
2262
                ('read', 'write'): ('phs000003.c1', 'phs000004.c1'),
2263
                ('read', 'read-storage', 'write', 'write-storage'): ('phs000005.c1', 'phs000006.c1'),
2264
            }
2265
        """
2266
        roles_to_resources = collections.defaultdict(list)
1✔
2267
        for study, roles in user_project_info.items():
1✔
2268
            ordered_roles = tuple(sorted(roles))
1✔
2269
            study_authz_paths = self._dbgap_study_to_resources.get(study, [study])
1✔
2270
            if study in project_to_authz_mapping:
1✔
2271
                study_authz_paths = [project_to_authz_mapping[study]]
1✔
2272
            roles_to_resources[ordered_roles].extend(study_authz_paths)
1✔
2273

2274
        policies = {}
1✔
2275
        for ordered_roles, unordered_resources in roles_to_resources.items():
1✔
2276
            policies[ordered_roles] = tuple(sorted(unordered_resources))
1✔
2277
        return policies
1✔
2278

2279
    def _create_arborist_role(self, role):
1✔
2280
        """
2281
        Wrapper around gen3authz's create_role with additional logging
2282

2283
        Args:
2284
            role (str): what the Arborist identity should be of the created role
2285

2286
        Return:
2287
            bool: True if the role was created successfully or it already
2288
                  exists. False otherwise
2289
        """
2290
        if role in self._created_roles:
1✔
2291
            return True
1✔
2292
        try:
1✔
2293
            response_json = self.arborist_client.create_role(
1✔
2294
                arborist_role_for_permission(role)
2295
            )
2296
        except ArboristError as e:
×
2297
            self.logger.error(
×
2298
                "could not create `{}` role in Arborist: {}".format(role, e)
2299
            )
2300
            return False
×
2301
        self._created_roles.add(role)
1✔
2302

2303
        if response_json is None:
1✔
2304
            self.logger.info("role `{}` already exists in Arborist".format(role))
×
2305
        else:
2306
            self.logger.info("created role `{}` in Arborist".format(role))
1✔
2307
        return True
1✔
2308

2309
    def _create_arborist_resources(self, resources):
1✔
2310
        """
2311
        Create resources in Arborist
2312

2313
        Args:
2314
            resources (list): a list of full Arborist resource paths to create
2315
            [
2316
                "/programs/DEV/projects/phs000001.c1",
2317
                "/programs/DEV/projects/phs000002.c1",
2318
                "/programs/DEV/projects/phs000003.c1"
2319
            ]
2320

2321
        Return:
2322
            bool: True if the resources were successfully created, False otherwise
2323

2324

2325
        As of 2/11/2022, for resources above,
2326
        utils.combine_provided_and_dbgap_resources({}, resources) returns:
2327
        [
2328
            { 'name': 'programs', 'subresources': [
2329
                { 'name': 'DEV', 'subresources': [
2330
                    { 'name': 'projects', 'subresources': [
2331
                        { 'name': 'phs000001.c1', 'subresources': []},
2332
                        { 'name': 'phs000002.c1', 'subresources': []},
2333
                        { 'name': 'phs000003.c1', 'subresources': []}
2334
                    ]}
2335
                ]}
2336
            ]}
2337
        ]
2338
        Because this list has a single object, only a single network request gets
2339
        sent to Arborist.
2340

2341
        However, for resources = ["/phs000001.c1", "/phs000002.c1", "/phs000003.c1"],
2342
        utils.combine_provided_and_dbgap_resources({}, resources) returns:
2343
        [
2344
            {'name': 'phs000001.c1', 'subresources': []},
2345
            {'name': 'phs000002.c1', 'subresources': []},
2346
            {'name': 'phs000003.c1', 'subresources': []}
2347
        ]
2348
        Because this list has 3 objects, 3 network requests get sent to Arborist.
2349

2350
        As a practical matter, for sync_single_user_visas, studies
2351
        should be nested under the `/programs` resource as in the former
2352
        example (i.e. only one network request gets made).
2353

2354
        TODO for the sake of simplicity, it would be nice if only one network
2355
        request was made no matter the input.
2356
        """
2357
        for request_body in utils.combine_provided_and_dbgap_resources({}, resources):
1✔
2358
            try:
1✔
2359
                response_json = self.arborist_client.update_resource(
1✔
2360
                    "/", request_body, merge=True
2361
                )
2362
            except ArboristError as e:
×
2363
                self.logger.error(
×
2364
                    "could not create Arborist resources using request body `{}`. error: {}".format(
2365
                        request_body, e
2366
                    )
2367
                )
2368
                return False
×
2369

2370
        self.logger.debug(
1✔
2371
            "created {} resource(s) in Arborist: `{}`".format(len(resources), resources)
2372
        )
2373
        return True
1✔
2374

2375
    def _create_arborist_policy(
1✔
2376
        self, policy_id, roles, resources, skip_if_exists=False
2377
    ):
2378
        """
2379
        Wrapper around gen3authz's create_policy with additional logging
2380

2381
        Args:
2382
            policy_id (str): what the Arborist identity should be of the created policy
2383
            roles (iterable): what roles the create policy should have
2384
            resources (iterable): what resources the created policy should have
2385
            skip_if_exists (bool): if True, this function will not treat an already
2386
                                   existent policy as an error
2387

2388
        Return:
2389
            bool: True if policy creation was successful. False otherwise
2390
        """
2391
        try:
1✔
2392
            response_json = self.arborist_client.create_policy(
1✔
2393
                {
2394
                    "id": policy_id,
2395
                    "role_ids": roles,
2396
                    "resource_paths": resources,
2397
                },
2398
                skip_if_exists=skip_if_exists,
2399
            )
2400
        except ArboristError as e:
×
2401
            self.logger.error(
×
2402
                "could not create policy `{}` in Arborist: {}".format(policy_id, e)
2403
            )
2404
            return False
×
2405

2406
        if response_json is None:
1✔
2407
            self.logger.info("policy `{}` already exists in Arborist".format(policy_id))
×
2408
        else:
2409
            self.logger.info("created policy `{}` in Arborist".format(policy_id))
1✔
2410
        return True
1✔
2411

2412
    def _hash_policy_contents(self, ordered_roles, ordered_resources):
1✔
2413
        """
2414
        Generate a sha256 hexdigest representing ordered_roles and ordered_resources.
2415

2416
        Args:
2417
            ordered_roles (iterable): policy roles in sorted order
2418
            ordered_resources (iterable): policy resources in sorted order
2419

2420
        Return:
2421
            str: SHA256 hex digest
2422
        """
2423

2424
        def escape(s):
1✔
2425
            return s.replace(",", "\\,")
1✔
2426

2427
        canonical_roles = ",".join(escape(r) for r in ordered_roles)
1✔
2428
        canonical_resources = ",".join(escape(r) for r in ordered_resources)
1✔
2429
        canonical_policy = f"{canonical_roles},,f{canonical_resources}"
1✔
2430
        policy_hash = hashlib.sha256(canonical_policy.encode("utf-8")).hexdigest()
1✔
2431

2432
        return policy_hash
1✔
2433

2434
    def _grant_arborist_policy(self, username, policy_id, expires=None):
1✔
2435
        """
2436
        Wrapper around gen3authz's grant_user_policy with additional logging
2437

2438
        Args:
2439
            username (str): username of user in Arborist who policy should be
2440
                            granted to
2441
            policy_id (str): Arborist policy id
2442
            expires (int): POSIX timestamp for when policy should expire
2443

2444
        Return:
2445
            bool: True if granting of policy was successful, False otherwise
2446
        """
2447
        try:
1✔
2448
            response_json = self.arborist_client.grant_user_policy(
1✔
2449
                username,
2450
                policy_id,
2451
                expires_at=expires,
2452
            )
2453
        except ArboristError as e:
×
2454
            self.logger.error(
×
2455
                "could not grant policy `{}` to user `{}`: {}".format(
2456
                    policy_id, username, e
2457
                )
2458
            )
2459
            return False
×
2460

2461
        self.logger.debug(
1✔
2462
            "granted policy `{}` to user `{}`".format(policy_id, username)
2463
        )
2464
        return True
1✔
2465

2466
    def _grant_bulk_user_policies(self, username, policy_ids, expires=None):
1✔
2467
        """
2468
        Wrapper around gen3authz's grant_user_policies with additional logging
2469

2470
        Args:
2471
            username (str): username of user in Arborist who policy should be
2472
                            granted to
2473
            policy_ids (set[str]): Arborist policy ids
2474

2475
        Return:
2476
            bool: True if granting of policies was successful, False otherwise
2477
        """
2478
        try:
1✔
2479
            response_json = self.arborist_client.grant_bulk_user_policy(
1✔
2480
                username, policy_ids, expires
2481
            )
2482
        except ArboristError as e:
×
2483
            self.logger.error(
×
2484
                "could not grant bulk policies  to user `{}`: {}".format(username, e)
2485
            )
2486
            return False
×
2487
        except ArboristTimeoutError as e:
×
2488
            self.logger.error(
×
2489
                f"Timeout waiting for response to grant bulk policies  to user `{username}`: {e}"
2490
                "This user will be skipped and usersync will continue."
2491
                "As long as the timeout is not a pool/connection timeout, then "
2492
            )
2493
            return False
×
2494
        return True
1✔
2495

2496
    def _determine_arborist_resource(self, dbgap_study, dbgap_config):
1✔
2497
        """
2498
        Determine the arborist resource path and add it to
2499
        _self._dbgap_study_to_resources
2500

2501
        Args:
2502
            dbgap_study (str): study phs identifier
2503
            dbgap_config (dict): dictionary of config for dbgap server
2504

2505
        """
2506
        default_namespaces = dbgap_config.get("study_to_resource_namespaces", {}).get(
1✔
2507
            "_default", ["/"]
2508
        )
2509
        namespaces = dbgap_config.get("study_to_resource_namespaces", {}).get(
1✔
2510
            dbgap_study, default_namespaces
2511
        )
2512

2513
        self.logger.debug(f"dbgap study namespaces: {namespaces}")
1✔
2514

2515
        arborist_resource_namespaces = [
1✔
2516
            namespace.rstrip("/") + "/programs/" for namespace in namespaces
2517
        ]
2518

2519
        for resource_namespace in arborist_resource_namespaces:
1✔
2520
            full_resource_path = resource_namespace + dbgap_study
1✔
2521
            if dbgap_study not in self._dbgap_study_to_resources:
1✔
2522
                self._dbgap_study_to_resources[dbgap_study] = []
1✔
2523
            self._dbgap_study_to_resources[dbgap_study].append(full_resource_path)
1✔
2524
        return arborist_resource_namespaces
1✔
2525

2526
    def _is_arborist_healthy(self):
1✔
2527
        if not self.arborist_client:
1✔
2528
            self.logger.warning("no arborist client set; skipping arborist dbgap sync")
×
2529
            return False
×
2530
        if not self.arborist_client.healthy():
1✔
2531
            # TODO (rudyardrichter, 2019-01-07): add backoff/retry here
2532
            self.logger.error(
×
2533
                "arborist service is unavailable; skipping main arborist dbgap sync"
2534
            )
2535
            return False
×
2536
        return True
1✔
2537

2538
    def _pick_sync_type(self, visa):
1✔
2539
        """
2540
        Pick type of visa to parse according to the visa provider
2541
        """
2542
        sync_client = None
1✔
2543
        if visa.type in self.visa_types["ras"]:
1✔
2544
            sync_client = self.ras_sync_client
1✔
2545
        else:
2546
            raise Exception(
×
2547
                "Visa type {} not recognized. Configure in fence-config".format(
2548
                    visa.type
2549
                )
2550
            )
2551
        if not sync_client:
1✔
2552
            raise Exception("Sync client for {} not configured".format(visa.type))
×
2553

2554
        return sync_client
1✔
2555

2556
    def sync_single_user_visas(
1✔
2557
        self, user, ga4gh_visas, sess=None, expires=None, skip_google_updates=False
2558
    ):
2559
        """
2560
        Sync a single user's visas during login or DRS/data access
2561

2562
        IMPORTANT NOTE: THIS DOES NOT VALIDATE THE VISA. ENSURE THIS IS DONE
2563
                        BEFORE THIS.
2564

2565
        Args:
2566
            user (userdatamodel.user.User): Fence user whose visas'
2567
                                            authz info is being synced
2568
            ga4gh_visas (list): a list of fence.models.GA4GHVisaV1 objects
2569
                                that are ALREADY VALIDATED
2570
            sess (sqlalchemy.orm.session.Session): database session
2571
            expires (int): time at which synced Arborist policies and
2572
                           inclusion in any GBAG are set to expire
2573
            skip_google_updates (bool): True if google group updates should be skipped. False if otherwise.
2574

2575
        Return:
2576
            list of successfully parsed visas
2577
        """
2578
        self.ras_sync_client = RASVisa(logger=self.logger)
1✔
2579
        dbgap_config = self.dbGaP[0]
1✔
2580
        parse_consent_code = self._get_parse_consent_code(dbgap_config)
1✔
2581
        enable_common_exchange_area_access = dbgap_config.get(
1✔
2582
            "enable_common_exchange_area_access", False
2583
        )
2584
        study_common_exchange_areas = dbgap_config.get(
1✔
2585
            "study_common_exchange_areas", {}
2586
        )
2587

2588
        try:
1✔
2589
            user_yaml = UserYAML.from_file(
1✔
2590
                self.sync_from_local_yaml_file, encrypted=False, logger=self.logger
2591
            )
2592
        except (EnvironmentError, AssertionError) as e:
×
2593
            self.logger.error(str(e))
×
2594
            self.logger.error("aborting early")
×
2595
            raise
×
2596

2597
        user_projects = dict()
1✔
2598
        projects = {}
1✔
2599
        info = {}
1✔
2600
        parsed_visas = []
1✔
2601

2602
        for visa in ga4gh_visas:
1✔
2603
            project = {}
1✔
2604
            visa_type = self._pick_sync_type(visa)
1✔
2605
            encoded_visa = visa.ga4gh_visa
1✔
2606

2607
            try:
1✔
2608
                project, info = visa_type._parse_single_visa(
1✔
2609
                    user,
2610
                    encoded_visa,
2611
                    visa.expires,
2612
                    parse_consent_code,
2613
                )
2614
            except Exception:
×
2615
                self.logger.warning(
×
2616
                    f"ignoring unsuccessfully parsed or expired visa: {encoded_visa}"
2617
                )
2618
                continue
×
2619

2620
            projects = {**projects, **project}
1✔
2621
            parsed_visas.append(visa)
1✔
2622

2623
        info["user_id"] = user.id
1✔
2624
        info["username"] = user.username
1✔
2625
        user_projects[user.username] = projects
1✔
2626

2627
        user_projects = self.parse_projects(user_projects)
1✔
2628

2629
        if parse_consent_code and enable_common_exchange_area_access:
1✔
2630
            self.logger.info(
1✔
2631
                f"using study to common exchange area mapping: {study_common_exchange_areas}"
2632
            )
2633

2634
        self._process_user_projects(
1✔
2635
            user_projects,
2636
            enable_common_exchange_area_access,
2637
            study_common_exchange_areas,
2638
            dbgap_config,
2639
            sess,
2640
        )
2641

2642
        if parse_consent_code:
1✔
2643
            self._grant_all_consents_to_c999_users(
1✔
2644
                user_projects, user_yaml.project_to_resource
2645
            )
2646

2647
        if user_projects:
1✔
2648
            self.sync_to_storage_backend(
1✔
2649
                user_projects,
2650
                info,
2651
                sess,
2652
                expires=expires,
2653
                skip_google_updates=skip_google_updates,
2654
            )
2655
        else:
2656
            self.logger.info("No users for syncing")
×
2657

2658
        # update arborist db (user access)
2659
        if self.arborist_client:
1✔
2660
            self.logger.info("Synchronizing arborist with authorization info...")
1✔
2661
            success = self._update_authz_in_arborist(
1✔
2662
                sess,
2663
                user_projects,
2664
                user_yaml=user_yaml,
2665
                single_user_sync=True,
2666
                expires=expires,
2667
            )
2668
            if success:
1✔
2669
                self.logger.info(
1✔
2670
                    "Finished synchronizing authorization info to arborist"
2671
                )
2672
            else:
2673
                self.logger.error(
×
2674
                    "Could not synchronize authorization info successfully to arborist"
2675
                )
2676
        else:
2677
            self.logger.error("No arborist client set; skipping arborist sync")
×
2678

2679
        return parsed_visas
1✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc