• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4893

20 Dec 2025 01:15PM UTC coverage: 65.57% (-0.001%) from 65.571%
#4893

push

travis-ci

web-flow
feat: support taos_connect_with func (#33952)

* feat: support taos_connect_with

* refactor: enhance connection options and add tests for taos_set_option and taos_connect_with

* fix: handle NULL keys and values in taos_connect_with options

* fix: revert TAOSWS_GIT_TAG to default value "main"

* docs: add TLS configuration options for WebSocket connections in documentation

* docs: modify zh docs and add en docs

* chore: update taos.cfg

* docs: add examples

* docs: add error handling for connection failure in example code

2 of 82 new or added lines in 3 files covered. (2.44%)

1158 existing lines in 109 files now uncovered.

182854 of 278870 relevant lines covered (65.57%)

105213271.06 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

71.43
/source/libs/sync/src/syncAppendEntriesReply.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "syncAppendEntriesReply.h"
18
#include "syncCommit.h"
19
#include "syncIndexMgr.h"
20
#include "syncPipeline.h"
21
#include "syncMessage.h"
22
#include "syncRaftEntry.h"
23
#include "syncRaftStore.h"
24
#include "syncReplication.h"
25
#include "syncSnapshot.h"
26
#include "syncUtil.h"
27

28
// TLA+ Spec
29
// HandleAppendEntriesResponse(i, j, m) ==
30
//    /\ m.mterm = currentTerm[i]
31
//    /\ \/ /\ m.msuccess \* successful
32
//          /\ nextIndex'  = [nextIndex  EXCEPT ![i][j] = m.mmatchIndex + 1]
33
//          /\ matchIndex' = [matchIndex EXCEPT ![i][j] = m.mmatchIndex]
34
//       \/ /\ \lnot m.msuccess \* not successful
35
//          /\ nextIndex' = [nextIndex EXCEPT ![i][j] =
36
//                               Max({nextIndex[i][j] - 1, 1})]
37
//          /\ UNCHANGED <<matchIndex>>
38
//    /\ Discard(m)
39
//    /\ UNCHANGED <<serverVars, candidateVars, logVars, elections>>
40
//
41

42
int32_t syncNodeOnAppendEntriesReply(SSyncNode* ths, const SRpcMsg* pRpcMsg) {
50,885,766✔
43
  int32_t                 code = 0;
50,885,766✔
44
  SyncAppendEntriesReply* pMsg = (SyncAppendEntriesReply*)pRpcMsg->pCont;
50,885,766✔
45
  int32_t                 ret = 0;
50,885,766✔
46

47
  // if already drop replica, do not process
48
  if (!syncNodeInRaftGroup(ths, &(pMsg->srcId))) {
50,885,766✔
49
    syncLogRecvAppendEntriesReply(ths, pMsg, "not in my config", &pRpcMsg->info.traceId);
×
50
    return 0;
×
51
  }
52

53
  // drop stale response
54
  if (pMsg->term < raftStoreGetTerm(ths)) {
50,885,766✔
UNCOV
55
    syncLogRecvAppendEntriesReply(ths, pMsg, "drop stale response", &pRpcMsg->info.traceId);
×
UNCOV
56
    return 0;
×
57
  }
58

59
  if (ths->state == TAOS_SYNC_STATE_LEADER || ths->state == TAOS_SYNC_STATE_ASSIGNED_LEADER) {
50,885,766✔
60
    if (pMsg->term != raftStoreGetTerm(ths)) {
50,885,766✔
UNCOV
61
      syncLogRecvAppendEntriesReply(ths, pMsg, "error term", &pRpcMsg->info.traceId);
×
UNCOV
62
      syncNodeStepDown(ths, pMsg->term, pMsg->srcId, "appendEntryReply");
×
UNCOV
63
      return TSDB_CODE_SYN_WRONG_TERM;
×
64
    }
65

66
    sGDebug(&pRpcMsg->info.traceId, "vgId:%d, received append entries reply, src addr:0x%" PRIx64 ", term:%" PRId64 ", matchIndex:%" PRId64,
50,885,766✔
67
            pMsg->vgId, pMsg->srcId.addr, pMsg->term, pMsg->matchIndex);
68

69
    if (pMsg->success) {
50,885,766✔
70
      SyncIndex oldMatchIndex = syncIndexMgrGetIndex(ths->pMatchIndex, &(pMsg->srcId));
48,371,324✔
71
      if (pMsg->matchIndex > oldMatchIndex) {
48,371,324✔
72
        syncIndexMgrSetIndex(ths->pMatchIndex, &(pMsg->srcId), pMsg->matchIndex);
44,343,102✔
73
      }
74

75
      // commit if needed
76
      SyncIndex indexLikely = TMIN(pMsg->matchIndex, ths->pLogBuf->matchIndex);
48,371,324✔
77
      SyncIndex commitIndex = syncNodeCheckCommitIndex(ths, indexLikely, &pRpcMsg->info.traceId);
48,371,324✔
78
      if (ths->state == TAOS_SYNC_STATE_ASSIGNED_LEADER) {
48,371,324✔
79
        if (commitIndex >= ths->assignedCommitIndex) {
×
80
          sInfo("vgId:%d, going to step down from assigned leader by append entries reply, commitIndex:%" PRId64
×
81
                ", assignedCommitIndex:%" PRId64,
82
                ths->vgId, ths->assignedCommitIndex, commitIndex);
83
          syncNodeStepDown(ths, pMsg->term, pMsg->destId, "appendEntryReply");
×
84
        }
85
      } else {
86
        TAOS_CHECK_RETURN(syncLogBufferCommit(ths->pLogBuf, ths, commitIndex, &pRpcMsg->info.traceId, "sync-append-entries-reply"));
48,371,324✔
87
      }
88
    }
89

90
    // replicate log
91
    SSyncLogReplMgr* pMgr = syncNodeGetLogReplMgr(ths, &pMsg->srcId);
50,885,766✔
92
    if (pMgr == NULL) {
50,885,474✔
93
      code = TSDB_CODE_MND_RETURN_VALUE_NULL;
697✔
94
      if (terrno != 0) code = terrno;
697✔
95
      sError("vgId:%d, failed to get log repl mgr for src addr:0x%" PRIx64, ths->vgId, pMsg->srcId.addr);
697✔
96
      TAOS_RETURN(code);
697✔
97
    }
98
    TAOS_CHECK_RETURN(syncLogReplProcessReply(pMgr, ths, pMsg));
50,884,777✔
99
  }
100
  TAOS_RETURN(code);
50,885,069✔
101
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc