20304984263

Committed 17 Dec 2025 01:46PM UTC coverage: 90.528% (+0.2%) from 90.358%

Build # 20304984263

Build Type

Pull #5167

github

Committed by

web-flow

Commit Message

Merge fc6e5fe09 into 3d96b675e

Pull Request Pull Request #5167: Changes to reduce unnecessary inclusions

Run Details

101179 of 111766 relevant lines covered (90.53%)

12666117.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

98.63

/src/lib/tls/msg_cert_req.cpp

/*
* Certificate Request Message
* (C) 2004-2006,2012 Jack Lloyd
*     2021 Elektrobit Automotive GmbH
*     2022 René Meusel, Hannes Rantzsch - neXenio GmbH
*
* Botan is released under the Simplified BSD License (see license.txt)
*/

#include <botan/tls_messages.h>

#include <botan/ber_dec.h>
#include <botan/der_enc.h>
#include <botan/tls_extensions.h>
#include <botan/tls_policy.h>
#include <botan/internal/tls_handshake_hash.h>
#include <botan/internal/tls_handshake_io.h>
#include <botan/internal/tls_reader.h>

namespace Botan::TLS {

Handshake_Type Certificate_Request_12::type() const {
   return Handshake_Type::CertificateRequest;
}

namespace {

std::string cert_type_code_to_name(uint8_t code) {
   switch(code) {
      case 1:
         return "RSA";
      case 64:
         return "ECDSA";
      default:
         return "";  // DH or something else
   }
}

uint8_t cert_type_name_to_code(std::string_view name) {
   if(name == "RSA") {
      return 1;
   }
   if(name == "ECDSA") {
      return 64;
   }

   throw Invalid_Argument(fmt("Unknown/unhandled TLS cert type {}", name));
}

}  // namespace

/**
* Create a new Certificate Request message
*/
Certificate_Request_12::Certificate_Request_12(Handshake_IO& io,
                                               Handshake_Hash& hash,
                                               const Policy& policy,
                                               const std::vector<X509_DN>& ca_certs) :
      m_names(ca_certs), m_cert_key_types({"RSA", "ECDSA"}) {
   m_schemes = policy.acceptable_signature_schemes();
   hash.update(io.send(*this));
}

/**
* Deserialize a Certificate Request message
*/
Certificate_Request_12::Certificate_Request_12(const std::vector<uint8_t>& buf) {
   if(buf.size() < 4) {
      throw Decoding_Error("Certificate_Req: Bad certificate request");
   }

   TLS_Data_Reader reader("CertificateRequest", buf);

   const auto cert_type_codes = reader.get_range_vector<uint8_t>(1, 1, 255);

   for(const auto cert_type_code : cert_type_codes) {
      const std::string cert_type_name = cert_type_code_to_name(cert_type_code);

      if(cert_type_name.empty()) {  // something we don't know
         continue;
      }

      m_cert_key_types.emplace_back(cert_type_name);
   }

   const std::vector<uint8_t> algs = reader.get_range_vector<uint8_t>(2, 2, 65534);

   if(algs.size() % 2 != 0) {
      throw Decoding_Error("Bad length for signature IDs in certificate request");
   }

   for(size_t i = 0; i != algs.size(); i += 2) {
      m_schemes.emplace_back(make_uint16(algs[i], algs[i + 1]));
   }

   const uint16_t purported_size = reader.get_uint16_t();

   if(reader.remaining_bytes() != purported_size) {
      throw Decoding_Error("Inconsistent length in certificate request");
   }

   while(reader.has_remaining()) {
      std::vector<uint8_t> name_bits = reader.get_range_vector<uint8_t>(2, 0, 65535);

      BER_Decoder decoder(name_bits.data(), name_bits.size());
      X509_DN name;
      decoder.decode(name);
      m_names.emplace_back(name);
   }
}

const std::vector<std::string>& Certificate_Request_12::acceptable_cert_types() const {
   return m_cert_key_types;
}

const std::vector<X509_DN>& Certificate_Request_12::acceptable_CAs() const {
   return m_names;
}

const std::vector<Signature_Scheme>& Certificate_Request_12::signature_schemes() const {
   return m_schemes;
}

/**
* Serialize a Certificate Request message
*/
std::vector<uint8_t> Certificate_Request_12::serialize() const {
   std::vector<uint8_t> buf;

   std::vector<uint8_t> cert_types;

   cert_types.reserve(m_cert_key_types.size());
   for(const auto& cert_key_type : m_cert_key_types) {
      cert_types.push_back(cert_type_name_to_code(cert_key_type));
   }

   append_tls_length_value(buf, cert_types, 1);

   if(!m_schemes.empty()) {
      buf += Signature_Algorithms(m_schemes).serialize(Connection_Side::Server);
   }

   std::vector<uint8_t> encoded_names;

   for(const auto& name : m_names) {
      DER_Encoder encoder;
      encoder.encode(name);

      append_tls_length_value(encoded_names, encoder.get_contents(), 2);
   }

   append_tls_length_value(buf, encoded_names, 2);

   return buf;
}
}  // namespace Botan::TLS

1	/*
2	* Certificate Request Message
3	* (C) 2004-2006,2012 Jack Lloyd
4	* 2021 Elektrobit Automotive GmbH
5	* 2022 René Meusel, Hannes Rantzsch - neXenio GmbH
6	*
7	* Botan is released under the Simplified BSD License (see license.txt)
8	*/
9
10	#include <botan/tls_messages.h>
11
12	#include <botan/ber_dec.h>
13	#include <botan/der_enc.h>
14	#include <botan/tls_extensions.h>
15	#include <botan/tls_policy.h>
16	#include <botan/internal/tls_handshake_hash.h>
17	#include <botan/internal/tls_handshake_io.h>
18	#include <botan/internal/tls_reader.h>
19
20	namespace Botan::TLS {
21
22	Handshake_Type Certificate_Request_12::type() const {	731✔
23	return Handshake_Type::CertificateRequest;	731✔
24	}
25
26	namespace {
27
28	std::string cert_type_code_to_name(uint8_t code) {	402✔
29	switch(code) {	402✔
30	case 1:	194✔
31	return "RSA";	194✔
32	case 64:	195✔
33	return "ECDSA";	195✔
34	default:	13✔
35	return ""; // DH or something else	13✔
36	}
37	}
38
39	uint8_t cert_type_name_to_code(std::string_view name) {	554✔
40	if(name == "RSA") {	554✔
41	return 1;	277✔
42	}
43	if(name == "ECDSA") {	277✔
44	return 64;	277✔
45	}
46
47	throw Invalid_Argument(fmt("Unknown/unhandled TLS cert type {}", name));	×
48	}
49
50	} // namespace
51
52	/**
53	* Create a new Certificate Request message
54	*/
55	Certificate_Request_12::Certificate_Request_12(Handshake_IO& io,	277✔
56	Handshake_Hash& hash,
57	const Policy& policy,
58	const std::vector<X509_DN>& ca_certs) :	277✔
59	m_names(ca_certs), m_cert_key_types({"RSA", "ECDSA"}) {	1,385✔
60	m_schemes = policy.acceptable_signature_schemes();	277✔
61	hash.update(io.send(*this));	554✔
62	}	831✔
63
64	/**
65	* Deserialize a Certificate Request message
66	*/
67	Certificate_Request_12::Certificate_Request_12(const std::vector<uint8_t>& buf) {	200✔
68	if(buf.size() < 4) {	200✔
69	throw Decoding_Error("Certificate_Req: Bad certificate request");	1✔
70	}
71
72	TLS_Data_Reader reader("CertificateRequest", buf);	199✔
73
74	const auto cert_type_codes = reader.get_range_vector<uint8_t>(1, 1, 255);	199✔
75
76	for(const auto cert_type_code : cert_type_codes) {	601✔
77	const std::string cert_type_name = cert_type_code_to_name(cert_type_code);	402✔
78
79	if(cert_type_name.empty()) { // something we don't know	402✔
80	continue;	13✔
81	}
82
83	m_cert_key_types.emplace_back(cert_type_name);	389✔
84	}	402✔
85
86	const std::vector<uint8_t> algs = reader.get_range_vector<uint8_t>(2, 2, 65534);	199✔
87
88	if(algs.size() % 2 != 0) {	195✔
89	throw Decoding_Error("Bad length for signature IDs in certificate request");	1✔
90	}
91
92	for(size_t i = 0; i != algs.size(); i += 2) {	1,869✔
93	m_schemes.emplace_back(make_uint16(algs[i], algs[i + 1]));	1,679✔
94	}
95
96	const uint16_t purported_size = reader.get_uint16_t();	194✔
97
98	if(reader.remaining_bytes() != purported_size) {	194✔
99	throw Decoding_Error("Inconsistent length in certificate request");	3✔
100	}
101
102	while(reader.has_remaining()) {	361✔
103	std::vector<uint8_t> name_bits = reader.get_range_vector<uint8_t>(2, 0, 65535);	170✔
104
105	BER_Decoder decoder(name_bits.data(), name_bits.size());	170✔
106	X509_DN name;	170✔
107	decoder.decode(name);	170✔
108	m_names.emplace_back(name);	170✔
109	}	340✔
110	}	413✔
111
112	const std::vector<std::string>& Certificate_Request_12::acceptable_cert_types() const {	191✔
113	return m_cert_key_types;	191✔
114	}
115
116	const std::vector<X509_DN>& Certificate_Request_12::acceptable_CAs() const {	191✔
117	return m_names;	191✔
118	}
119
120	const std::vector<Signature_Scheme>& Certificate_Request_12::signature_schemes() const {	256✔
121	return m_schemes;	256✔
122	}
123
124	/**
125	* Serialize a Certificate Request message
126	*/
127	std::vector<uint8_t> Certificate_Request_12::serialize() const {	277✔
128	std::vector<uint8_t> buf;	277✔
129
130	std::vector<uint8_t> cert_types;	277✔
131
132	cert_types.reserve(m_cert_key_types.size());	277✔
133	for(const auto& cert_key_type : m_cert_key_types) {	831✔
134	cert_types.push_back(cert_type_name_to_code(cert_key_type));	554✔
135	}
136
137	append_tls_length_value(buf, cert_types, 1);	277✔
138
139	if(!m_schemes.empty()) {	277✔
140	buf += Signature_Algorithms(m_schemes).serialize(Connection_Side::Server);	554✔
141	}
142
143	std::vector<uint8_t> encoded_names;	277✔
144
145	for(const auto& name : m_names) {	616✔
146	DER_Encoder encoder;	339✔
147	encoder.encode(name);	339✔
148
149	append_tls_length_value(encoded_names, encoder.get_contents(), 2);	678✔
150	}	339✔
151
152	append_tls_length_value(buf, encoded_names, 2);	277✔
153
154	return buf;	277✔
155	}	554✔
156	} // namespace Botan::TLS

randombit / botan / 20304984263

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous