3032

pending completion

Build # 3032

Build Type

Pull #844

travis-ci

Committed by

web-flow

Commit Message

when checksumming uploaded assets, go 100MiB at a time

just piping the entire file to a 'cksum' system call can block
the worker process for over a minute if the file is large,
again rendering us vulnerable to the 'dead worker' check, as
the worker will not send status updates to the server while
it's blocked. Instead, use Digest::MD5 (we're using it in some
other places too) and read 100MiB at a time from the file into
the digest context, updating the status every ~5 seconds. I
tried to find a way to let the timer fire while this is going
on, but I can't; this is simple enough and works.

The actual digest calculation does not take long at all, it's
reading gigabytes of data from disk that takes time.

Pull Request Pull Request #844: Make sure worker updates status throughout asset upload and checksum

Run Details

45 of 45 new or added lines in 1 file covered. (100.0%)

4177 of 5904 relevant lines covered (70.75%)

98.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

4.24

/lib/OpenQA/Worker/Jobs.pm

Build SHA Not Found

The commit SHA "de50eda16cccd368f7213d52bc7240bf59e992ef" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

os-autoinst / openQA / 3032

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous