20253990934

Committed 16 Dec 2025 02:04AM UTC coverage: 80.856% (+0.04%) from 80.813%

Build # 20253990934

Build Type

Pull #158

github

Committed by

web-flow

Commit Message

Merge c7b30343f into 414f15082

Pull Request Pull Request #158: refactor: prefer undefined over null

Run Details

696 of 929 branches covered (74.92%)

Branch coverage included in aggregate %.

62 of 81 new or added lines in 20 files covered. (76.54%)

14 existing lines in 2 files now uncovered.

1855 of 2226 relevant lines covered (83.33%)

125846.55 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.24

/src/node/SlippiGameNode.ts

import { SlippiGameBase } from "../common/SlippiGameBase";
import type { StatOptions } from "../common/stats";
import { type BinaryLike, isBufferLike } from "../common/utils/bufferHelpers";
import { SlpBufferInputRef } from "../common/utils/slpInputRef";
import { SlpFileInputRef } from "./utils/slpFileInputRef";

export class SlippiGameNode extends SlippiGameBase {
  private readonly filePath: string | undefined;

  public constructor(input: string | BinaryLike, opts?: StatOptions) {
    if (typeof input === "string") {
      super(new SlpFileInputRef(input), opts);
      this.filePath = input;
    } else if (isBufferLike(input)) {
      super(new SlpBufferInputRef(input), opts);
      this.filePath = undefined;
    } else {
      throw new Error("Cannot create SlippiGame with input of that type");
    }
  }

  public override getFilePath(): string | undefined {
    return this.filePath;
  }
}

1	import { SlippiGameBase } from "../common/SlippiGameBase";	12✔
2	import type { StatOptions } from "../common/stats";
3	import { type BinaryLike, isBufferLike } from "../common/utils/bufferHelpers";	12✔
4	import { SlpBufferInputRef } from "../common/utils/slpInputRef";	12✔
5	import { SlpFileInputRef } from "./utils/slpFileInputRef";	12✔
6
7	export class SlippiGameNode extends SlippiGameBase {	12✔
8	private readonly filePath: string \| undefined;
9
10	public constructor(input: string \| BinaryLike, opts?: StatOptions) {
11	if (typeof input === "string") {	79✔
12	super(new SlpFileInputRef(input), opts);	75✔
13	this.filePath = input;	75✔
14	} else if (isBufferLike(input)) {	4!
15	super(new SlpBufferInputRef(input), opts);	4✔
16	this.filePath = undefined;	4✔
17	} else {
UNCOV 18	throw new Error("Cannot create SlippiGame with input of that type");	×
19	}
20	}
21
22	public override getFilePath(): string \| undefined {
23	return this.filePath;	2✔
24	}
25	}

project-slippi / slippi-js / 20253990934

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous