• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4881

14 Dec 2025 03:48AM UTC coverage: 60.617% (+0.5%) from 60.092%
#4881

push

travis-ci

web-flow
test: update coverage workflow time (#33918)

156854 of 258761 relevant lines covered (60.62%)

75258957.81 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

82.42
/source/dnode/mnode/impl/src/mndBnode.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "mndBnode.h"
18
#include "mndDnode.h"
19
#include "mndPrivilege.h"
20
#include "mndShow.h"
21
#include "mndTrans.h"
22
#include "mndUser.h"
23

24
#define BNODE_VER_NUMBER   1
25
#define BNODE_RESERVE_SIZE 64
26

27
static SSdbRaw *mndBnodeActionEncode(SBnodeObj *pObj) {
92,701✔
28
  int32_t code = 0;
92,701✔
29
  int32_t lino = 0;
92,701✔
30

31
  terrno = TSDB_CODE_OUT_OF_MEMORY;
92,701✔
32

33
  SSdbRaw *pRaw = sdbAllocRaw(SDB_BNODE, BNODE_VER_NUMBER, sizeof(SBnodeObj) + BNODE_RESERVE_SIZE);
92,701✔
34
  if (pRaw == NULL) goto _OVER;
92,701✔
35

36
  int32_t dataPos = 0;
92,701✔
37
  SDB_SET_INT32(pRaw, dataPos, pObj->id, _OVER)
92,701✔
38
  SDB_SET_INT32(pRaw, dataPos, pObj->proto, _OVER)
92,701✔
39
  SDB_SET_INT64(pRaw, dataPos, pObj->createdTime, _OVER)
92,701✔
40
  SDB_SET_INT64(pRaw, dataPos, pObj->updateTime, _OVER)
92,701✔
41
  SDB_SET_RESERVE(pRaw, dataPos, BNODE_RESERVE_SIZE, _OVER)
92,701✔
42

43
  terrno = 0;
92,701✔
44

45
_OVER:
92,701✔
46
  if (terrno != 0) {
92,701✔
47
    mError("bnode:%d, failed to encode to raw:%p since %s", pObj->id, pRaw, terrstr());
×
48
    sdbFreeRaw(pRaw);
×
49
    return NULL;
×
50
  }
51

52
  mTrace("bnode:%d, encode to raw:%p, row:%p", pObj->id, pRaw, pObj);
92,701✔
53
  return pRaw;
92,701✔
54
}
55

56
static SSdbRow *mndBnodeActionDecode(SSdbRaw *pRaw) {
73,054✔
57
  int32_t    code = 0;
73,054✔
58
  int32_t    lino = 0;
73,054✔
59
  SSdbRow   *pRow = NULL;
73,054✔
60
  SBnodeObj *pObj = NULL;
73,054✔
61
  int8_t     sver = 0;
73,054✔
62

63
  terrno = TSDB_CODE_OUT_OF_MEMORY;
73,054✔
64

65
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;
73,054✔
66

67
  if (sver != BNODE_VER_NUMBER) {
73,054✔
68
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
69
    goto _OVER;
×
70
  }
71

72
  pRow = sdbAllocRow(sizeof(SBnodeObj));
73,054✔
73
  if (pRow == NULL) goto _OVER;
73,054✔
74

75
  pObj = sdbGetRowObj(pRow);
73,054✔
76
  if (pObj == NULL) goto _OVER;
73,054✔
77

78
  int32_t dataPos = 0;
73,054✔
79
  SDB_GET_INT32(pRaw, dataPos, &pObj->id, _OVER)
73,054✔
80
  SDB_GET_INT32(pRaw, dataPos, &pObj->proto, _OVER)
73,054✔
81
  SDB_GET_INT64(pRaw, dataPos, &pObj->createdTime, _OVER)
73,054✔
82
  SDB_GET_INT64(pRaw, dataPos, &pObj->updateTime, _OVER)
73,054✔
83
  SDB_GET_RESERVE(pRaw, dataPos, BNODE_RESERVE_SIZE, _OVER)
73,054✔
84

85
  terrno = 0;
73,054✔
86

87
_OVER:
73,054✔
88
  if (terrno != 0) {
73,054✔
89
    mError("bnode:%d, failed to decode from raw:%p since %s", pObj == NULL ? 0 : pObj->id, pRaw, terrstr());
×
90
    taosMemoryFreeClear(pRow);
×
91
    return NULL;
×
92
  }
93

94
  mTrace("bnode:%d, decode from raw:%p, row:%p", pObj->id, pRaw, pObj);
73,054✔
95
  return pRow;
73,054✔
96
}
97

98
static int32_t mndBnodeActionInsert(SSdb *pSdb, SBnodeObj *pObj) {
18,760✔
99
  mTrace("bnode:%d, perform insert action, row:%p", pObj->id, pObj);
18,760✔
100
  pObj->pDnode = sdbAcquire(pSdb, SDB_DNODE, &pObj->id);
18,760✔
101
  if (pObj->pDnode == NULL) {
18,760✔
102
    terrno = TSDB_CODE_MND_DNODE_NOT_EXIST;
×
103
    mError("bnode:%d, failed to perform insert action since %s", pObj->id, terrstr());
×
104
    return -1;
×
105
  }
106

107
  return 0;
18,760✔
108
}
109

110
static int32_t mndBnodeActionDelete(SSdb *pSdb, SBnodeObj *pObj) {
73,054✔
111
  mTrace("bnode:%d, perform delete action, row:%p", pObj->id, pObj);
73,054✔
112
  if (pObj->pDnode != NULL) {
73,054✔
113
    sdbRelease(pSdb, pObj->pDnode);
18,760✔
114
    pObj->pDnode = NULL;
18,760✔
115
  }
116

117
  return 0;
73,054✔
118
}
119

120
static int32_t mndBnodeActionUpdate(SSdb *pSdb, SBnodeObj *pOld, SBnodeObj *pNew) {
36,200✔
121
  mTrace("bnode:%d, perform update action, old row:%p new row:%p", pOld->id, pOld, pNew);
36,200✔
122
  pOld->updateTime = pNew->updateTime;
36,200✔
123
  return 0;
36,200✔
124
}
125

126
static int32_t mndSetCreateBnodeRedoLogs(STrans *pTrans, SBnodeObj *pObj) {
18,106✔
127
  int32_t  code = 0;
18,106✔
128
  SSdbRaw *pRedoRaw = mndBnodeActionEncode(pObj);
18,106✔
129
  if (pRedoRaw == NULL) {
18,106✔
130
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
131
    if (terrno != 0) code = terrno;
×
132
    TAOS_RETURN(code);
×
133
  }
134
  TAOS_CHECK_RETURN(mndTransAppendRedolog(pTrans, pRedoRaw));
18,106✔
135
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
18,106✔
136
  TAOS_RETURN(code);
18,106✔
137
}
138

139
static int32_t mndSetCreateBnodeUndoLogs(STrans *pTrans, SBnodeObj *pObj) {
18,106✔
140
  int32_t  code = 0;
18,106✔
141
  SSdbRaw *pUndoRaw = mndBnodeActionEncode(pObj);
18,106✔
142
  if (pUndoRaw == NULL) {
18,106✔
143
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
144
    if (terrno != 0) code = terrno;
×
145
    TAOS_RETURN(code);
×
146
  }
147
  TAOS_CHECK_RETURN(mndTransAppendUndolog(pTrans, pUndoRaw));
18,106✔
148
  TAOS_CHECK_RETURN(sdbSetRawStatus(pUndoRaw, SDB_STATUS_DROPPED));
18,106✔
149
  TAOS_RETURN(code);
18,106✔
150
}
151

152
static int32_t mndSetCreateBnodeCommitLogs(STrans *pTrans, SBnodeObj *pObj) {
18,106✔
153
  int32_t  code = 0;
18,106✔
154
  SSdbRaw *pCommitRaw = mndBnodeActionEncode(pObj);
18,106✔
155
  if (pCommitRaw == NULL) {
18,106✔
156
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
157
    if (terrno != 0) code = terrno;
×
158
    TAOS_RETURN(code);
×
159
  }
160
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
18,106✔
161
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
18,106✔
162
  TAOS_RETURN(code);
18,106✔
163
}
164

165
static int32_t mndSetCreateBnodeRedoActions(STrans *pTrans, SDnodeObj *pDnode, SBnodeObj *pObj) {
18,106✔
166
  int32_t          code = 0;
18,106✔
167
  SDCreateBnodeReq createReq = {0};
18,106✔
168
  createReq.dnodeId = pDnode->id;
18,106✔
169
  createReq.bnodeProto = pObj->proto;
18,106✔
170

171
  int32_t contLen = tSerializeSMCreateBnodeReq(NULL, 0, &createReq);
18,106✔
172
  void   *pReq = taosMemoryMalloc(contLen);
18,106✔
173
  if (pReq == NULL) {
18,106✔
174
    code = terrno;
×
175
    TAOS_RETURN(code);
×
176
  }
177
  code = tSerializeSMCreateBnodeReq(pReq, contLen, &createReq);
18,106✔
178
  if (code < 0) {
18,106✔
179
    mError("bnode:%d, failed to serialize create drop bnode request since %s", createReq.dnodeId, terrstr());
×
180

181
    taosMemoryFree(pReq);
×
182
    TAOS_RETURN(code);
×
183
  }
184

185
  STransAction action = {0};
18,106✔
186
  action.epSet = mndGetDnodeEpset(pDnode);
18,106✔
187
  action.pCont = pReq;
18,106✔
188
  action.contLen = contLen;
18,106✔
189
  action.msgType = TDMT_DND_CREATE_BNODE;
18,106✔
190
  action.acceptableCode = TSDB_CODE_BNODE_ALREADY_DEPLOYED;
18,106✔
191

192
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
18,106✔
193
    taosMemoryFree(pReq);
×
194
    TAOS_RETURN(code);
×
195
  }
196

197
  TAOS_RETURN(code);
18,106✔
198
}
199

200
static int32_t mndSetCreateBnodeUndoActions(STrans *pTrans, SDnodeObj *pDnode, SBnodeObj *pObj) {
18,106✔
201
  int32_t        code = 0;
18,106✔
202
  SDDropBnodeReq dropReq = {0};
18,106✔
203
  dropReq.dnodeId = pDnode->id;
18,106✔
204

205
  int32_t contLen = tSerializeSMDropBnodeReq(NULL, 0, &dropReq);
18,106✔
206
  void   *pReq = taosMemoryMalloc(contLen);
18,106✔
207
  if (pReq == NULL) {
18,106✔
208
    code = terrno;
×
209
    TAOS_RETURN(code);
×
210
  }
211
  code = tSerializeSMDropBnodeReq(pReq, contLen, &dropReq);
18,106✔
212
  if (code < 0) {
18,106✔
213
    mError("bnode:%d, failed to serialize create drop bnode request since %s", dropReq.dnodeId, terrstr());
×
214
  }
215

216
  STransAction action = {0};
18,106✔
217
  action.epSet = mndGetDnodeEpset(pDnode);
18,106✔
218
  action.pCont = pReq;
18,106✔
219
  action.contLen = contLen;
18,106✔
220
  action.msgType = TDMT_DND_DROP_BNODE;
18,106✔
221
  action.acceptableCode = TSDB_CODE_BNODE_NOT_DEPLOYED;
18,106✔
222

223
  if ((code = mndTransAppendUndoAction(pTrans, &action)) != 0) {
18,106✔
224
    taosMemoryFree(pReq);
×
225
    TAOS_RETURN(code);
×
226
  }
227

228
  TAOS_RETURN(code);
18,106✔
229
}
230

231
static int32_t mndCreateBnode(SMnode *pMnode, SRpcMsg *pReq, SDnodeObj *pDnode, SMCreateBnodeReq *pCreate) {
18,106✔
232
  int32_t code = -1;
18,106✔
233

234
  SBnodeObj bnodeObj = {0};
18,106✔
235
  bnodeObj.id = pDnode->id;
18,106✔
236
  bnodeObj.proto = pCreate->bnodeProto;
18,106✔
237
  bnodeObj.createdTime = taosGetTimestampMs();
18,106✔
238
  bnodeObj.updateTime = bnodeObj.createdTime;
18,106✔
239

240
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_NOTHING, pReq, "create-bnode");
18,106✔
241
  if (pTrans == NULL) {
18,106✔
242
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
243
    if (terrno != 0) code = terrno;
×
244
    goto _OVER;
×
245
  }
246
  mndTransSetSerial(pTrans);
18,106✔
247

248
  mInfo("trans:%d, to create bnode:%d %d", pTrans->id, pCreate->dnodeId, pCreate->bnodeProto);
18,106✔
249

250
  TAOS_CHECK_GOTO(mndSetCreateBnodeRedoLogs(pTrans, &bnodeObj), NULL, _OVER);
18,106✔
251
  TAOS_CHECK_GOTO(mndSetCreateBnodeUndoLogs(pTrans, &bnodeObj), NULL, _OVER);
18,106✔
252
  TAOS_CHECK_GOTO(mndSetCreateBnodeCommitLogs(pTrans, &bnodeObj), NULL, _OVER);
18,106✔
253
  TAOS_CHECK_GOTO(mndSetCreateBnodeRedoActions(pTrans, pDnode, &bnodeObj), NULL, _OVER);
18,106✔
254
  TAOS_CHECK_GOTO(mndSetCreateBnodeUndoActions(pTrans, pDnode, &bnodeObj), NULL, _OVER);
18,106✔
255
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
18,106✔
256

257
  code = 0;
18,106✔
258

259
_OVER:
18,106✔
260
  mndTransDrop(pTrans);
18,106✔
261
  TAOS_RETURN(code);
18,106✔
262
}
263

264
static int32_t mndProcessCreateBnodeReq(SRpcMsg *pReq) {
20,104✔
265
  SMnode          *pMnode = pReq->info.node;
20,104✔
266
  int32_t          code = -1;
20,104✔
267
  SBnodeObj       *pObj = NULL;
20,104✔
268
  SDnodeObj       *pDnode = NULL;
20,104✔
269
  SMCreateBnodeReq createReq = {0};
20,104✔
270

271
  #ifdef LINUX
272

273
  TAOS_CHECK_GOTO(tDeserializeSMCreateBnodeReq(pReq->pCont, pReq->contLen, &createReq), NULL, _OVER);
20,104✔
274

275
  mInfo("bnode:%d, start to create", createReq.dnodeId);
20,104✔
276
  TAOS_CHECK_GOTO(mndCheckOperPrivilege(pMnode, pReq->info.conn.user, MND_OPER_CREATE_BNODE), NULL, _OVER);
20,104✔
277

278
  pObj = mndAcquireBnode(pMnode, createReq.dnodeId);
20,104✔
279
  if (pObj != NULL) {
20,104✔
280
    code = terrno = TSDB_CODE_MND_BNODE_ALREADY_EXIST;
×
281
    goto _OVER;
×
282
  } else if (terrno != TSDB_CODE_MND_BNODE_NOT_EXIST) {
20,104✔
283
    code = terrno;
×
284
    goto _OVER;
×
285
  }
286

287
  pDnode = mndAcquireDnode(pMnode, createReq.dnodeId);
20,104✔
288
  if (pDnode == NULL) {
20,104✔
289
    code = TSDB_CODE_MND_DNODE_NOT_EXIST;
1,998✔
290
    goto _OVER;
1,998✔
291
  }
292

293
  code = mndCreateBnode(pMnode, pReq, pDnode, &createReq);
18,106✔
294
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
18,106✔
295

296
_OVER:
20,104✔
297
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
20,104✔
298
    mError("bnode:%d, failed to create since %s", createReq.dnodeId, tstrerror(code));
1,998✔
299
    TAOS_RETURN(code);
1,998✔
300
  }
301

302
  //  mndReleaseBnode(pMnode, pObj);
303
  mndReleaseDnode(pMnode, pDnode);
18,106✔
304
  tFreeSMCreateBnodeReq(&createReq);
18,106✔
305

306
  #else
307

308
  code = TSDB_CODE_OPS_NOT_SUPPORT;
309

310
  #endif
311

312
  TAOS_RETURN(code);
18,106✔
313
}
314

315
static int32_t mndSetDropBnodeRedoLogs(STrans *pTrans, SBnodeObj *pObj) {
18,748✔
316
  int32_t code = 0, lino = 0;
18,748✔
317

318
  SSdbRaw *pRedoRaw = mndBnodeActionEncode(pObj);
18,748✔
319
  if (pRedoRaw == NULL) {
18,748✔
320
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
321
    if (terrno != 0) code = terrno;
×
322
    TAOS_RETURN(code);
×
323
  }
324
  TAOS_CHECK_GOTO(mndTransAppendGroupRedolog(pTrans, pRedoRaw, -1), &lino, _OVER);
18,748✔
325
  TAOS_CHECK_GOTO(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING), &lino, _OVER);
18,748✔
326

327
_OVER:
18,748✔
328
  if (code != 0) {
18,748✔
329
    mError("bnode:%d, failed to drop bnode at line:%d since %s", pObj->id, lino, tstrerror(code));
×
330
  }
331

332
  TAOS_RETURN(code);
18,748✔
333
}
334

335
static int32_t mndSetDropBnodeCommitLogs(STrans *pTrans, SBnodeObj *pObj) {
18,748✔
336
  int32_t  code = 0;
18,748✔
337
  SSdbRaw *pCommitRaw = mndBnodeActionEncode(pObj);
18,748✔
338
  if (pCommitRaw == NULL) {
18,748✔
339
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
340
    if (terrno != 0) code = terrno;
×
341
    TAOS_RETURN(code);
×
342
  }
343
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
18,748✔
344
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
18,748✔
345
  TAOS_RETURN(code);
18,748✔
346
}
347

348
static int32_t mndSetDropBnodeRedoActions(STrans *pTrans, SDnodeObj *pDnode, SBnodeObj *pObj) {
18,748✔
349
  int32_t        code = 0;
18,748✔
350
  SDDropBnodeReq dropReq = {0};
18,748✔
351
  dropReq.dnodeId = pDnode->id;
18,748✔
352

353
  int32_t contLen = tSerializeSMDropBnodeReq(NULL, 0, &dropReq);
18,748✔
354
  void   *pReq = taosMemoryMalloc(contLen);
18,748✔
355
  if (pReq == NULL) {
18,748✔
356
    code = terrno;
×
357
    TAOS_RETURN(code);
×
358
  }
359
  code = tSerializeSMDropBnodeReq(pReq, contLen, &dropReq);
18,748✔
360
  if (code < 0) {
18,748✔
361
    mError("bnode:%d, failed to serialize create drop bnode request since %s", dropReq.dnodeId, terrstr());
×
362
  }
363

364
  STransAction action = {0};
18,748✔
365
  action.epSet = mndGetDnodeEpset(pDnode);
18,748✔
366
  action.pCont = pReq;
18,748✔
367
  action.contLen = contLen;
18,748✔
368
  action.msgType = TDMT_DND_DROP_BNODE;
18,748✔
369
  action.acceptableCode = TSDB_CODE_BNODE_NOT_DEPLOYED;
18,748✔
370

371
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
18,748✔
372
    taosMemoryFree(pReq);
654✔
373
    TAOS_RETURN(code);
654✔
374
  }
375

376
  TAOS_RETURN(code);
18,094✔
377
}
378

379
int32_t mndSetDropBnodeInfoToTrans(SMnode *pMnode, STrans *pTrans, SBnodeObj *pObj, bool force) {
18,748✔
380
  int32_t code = -1, lino = 0;
18,748✔
381

382
  if (pObj == NULL) return 0;
18,748✔
383
  TAOS_CHECK_GOTO(mndSetDropBnodeRedoLogs(pTrans, pObj), &lino, _OVER);
18,748✔
384
  TAOS_CHECK_GOTO(mndSetDropBnodeCommitLogs(pTrans, pObj), &lino, _OVER);
18,748✔
385
  if (!force) {
18,748✔
386
    TAOS_CHECK_GOTO(mndSetDropBnodeRedoActions(pTrans, pObj->pDnode, pObj), &lino, _OVER);
18,748✔
387
  }
388

389
_OVER:
18,748✔
390
  if (code != 0) {
18,748✔
391
    mError("bnode:%d, failed to drop bnode at line:%d since %s", pObj->id, lino, tstrerror(code));
654✔
392
  }
393

394
  return code;
18,748✔
395
}
396

397
static int32_t mndDropBnode(SMnode *pMnode, SRpcMsg *pReq, SBnodeObj *pObj) {
18,094✔
398
  int32_t code = -1;
18,094✔
399

400
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_NOTHING, pReq, "drop-bnode");
18,094✔
401
  if (pTrans == NULL) {
18,094✔
402
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
403
    if (terrno != 0) code = terrno;
×
404
    goto _OVER;
×
405
  }
406
  mndTransSetSerial(pTrans);
18,094✔
407

408
  mInfo("trans:%d, used to drop bnode:%d", pTrans->id, pObj->id);
18,094✔
409
  TAOS_CHECK_GOTO(mndSetDropBnodeInfoToTrans(pMnode, pTrans, pObj, false), NULL, _OVER);
18,094✔
410
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
18,094✔
411

412
  code = 0;
18,094✔
413

414
_OVER:
18,094✔
415
  mndTransDrop(pTrans);
18,094✔
416
  TAOS_RETURN(code);
18,094✔
417
}
418

419
static int32_t mndProcessDropBnodeReq(SRpcMsg *pReq) {
24,076✔
420
  SMnode        *pMnode = pReq->info.node;
24,076✔
421
  int32_t        code = -1;
24,076✔
422
  SBnodeObj     *pObj = NULL;
24,076✔
423
  SDnodeObj     *pDnode = NULL;
24,076✔
424
  SMDropBnodeReq dropReq = {0};
24,076✔
425

426
  TAOS_CHECK_GOTO(tDeserializeSMDropBnodeReq(pReq->pCont, pReq->contLen, &dropReq), NULL, _OVER);
24,076✔
427

428
  mInfo("bnode:%d, start to drop", dropReq.dnodeId);
24,076✔
429
  TAOS_CHECK_GOTO(mndCheckOperPrivilege(pMnode, pReq->info.conn.user, MND_OPER_DROP_BNODE), NULL, _OVER);
24,076✔
430

431
  if (dropReq.dnodeId <= 0) {
24,076✔
432
    code = TSDB_CODE_INVALID_MSG;
1,332✔
433
    goto _OVER;
1,332✔
434
  }
435

436
  pDnode = mndAcquireDnode(pMnode, dropReq.dnodeId);
22,744✔
437
  if (pDnode == NULL) {
22,744✔
438
    code = TSDB_CODE_MND_DNODE_NOT_EXIST;
1,782✔
439
    goto _OVER;
1,782✔
440
  }
441

442
  if (!mndIsDnodeOnline(pDnode, taosGetTimestampMs())) {
20,962✔
443
    code = TSDB_CODE_DNODE_OFFLINE;
654✔
444
    goto _OVER;
654✔
445
  }
446

447
  pObj = mndAcquireBnode(pMnode, dropReq.dnodeId);
20,308✔
448
  if (pObj == NULL) {
20,308✔
449
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
2,214✔
450
    if (terrno != 0) code = terrno;
2,214✔
451
    goto _OVER;
2,214✔
452
  }
453

454
  // check deletable
455
  code = mndDropBnode(pMnode, pReq, pObj);
18,094✔
456
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
18,094✔
457

458
_OVER:
24,076✔
459
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
24,076✔
460
    mError("bnode:%d, failed to drop since %s", dropReq.dnodeId, tstrerror(code));
5,982✔
461
  }
462

463
  mndReleaseBnode(pMnode, pObj);
24,076✔
464
  mndReleaseDnode(pMnode, pDnode);
24,076✔
465
  tFreeSMDropBnodeReq(&dropReq);
24,076✔
466
  TAOS_RETURN(code);
24,076✔
467
}
468

469
static const char *mndBnodeProtoStr(int32_t proto) {
117,864✔
470
  switch (proto) {
117,864✔
471
    case TSDB_BNODE_OPT_PROTO_MQTT:
117,864✔
472
      return TSDB_BNODE_OPT_PROTO_STR_MQTT;
117,864✔
473
    default:
×
474
      break;
×
475
  }
476
  return "unknown";
×
477
}
478

479
static int32_t mndRetrieveBnodes(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
61,868✔
480
  SMnode    *pMnode = pReq->info.node;
61,868✔
481
  SSdb      *pSdb = pMnode->pSdb;
61,868✔
482
  int32_t    numOfRows = 0;
61,868✔
483
  int32_t    cols = 0;
61,868✔
484
  SBnodeObj *pObj = NULL;
61,868✔
485
  char       buf[TSDB_EP_LEN + VARSTR_HEADER_SIZE];
61,868✔
486

487
  while (numOfRows < rows) {
120,800✔
488
    pShow->pIter = sdbFetch(pSdb, SDB_BNODE, pShow->pIter, (void **)&pObj);
120,800✔
489
    if (pShow->pIter == NULL) break;
120,800✔
490

491
    cols = 0;
58,932✔
492
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
58,932✔
493
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pObj->id, false), pSdb, pObj);
58,932✔
494

495
    char mqtt_ep[TSDB_EP_LEN] = {0};
58,932✔
496
    char ep[TSDB_EP_LEN + VARSTR_HEADER_SIZE] = {0};
58,932✔
497

498
    TAOS_UNUSED(tsnprintf(mqtt_ep, TSDB_EP_LEN - 1, "%s:%hu", pObj->pDnode->fqdn, tsMqttPort));
58,932✔
499
    STR_WITH_MAXSIZE_TO_VARSTR(ep, mqtt_ep, pShow->pMeta->pSchemas[cols].bytes);
58,932✔
500

501
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
58,932✔
502
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)ep, false), pSdb, pObj);
58,932✔
503

504
    STR_TO_VARSTR(buf, mndBnodeProtoStr(pObj->proto));
58,932✔
505
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
58,932✔
506
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)buf, false), pSdb, pObj);
58,932✔
507

508
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
58,932✔
509
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pObj->createdTime, false), pSdb,
58,932✔
510
                                   pObj);
511

512
    numOfRows++;
58,932✔
513
    sdbRelease(pSdb, pObj);
58,932✔
514
  }
515

516
  pShow->numOfRows += numOfRows;
61,868✔
517

518
  return numOfRows;
61,868✔
519
}
520

521
static void mndCancelGetNextBnode(SMnode *pMnode, void *pIter) {
×
522
  SSdb *pSdb = pMnode->pSdb;
×
523
  sdbCancelFetchByType(pSdb, pIter, SDB_BNODE);
×
524
}
×
525

526
SEpSet mndAcquireEpFromBnode(SMnode *pMnode, const SBnodeObj *pBnode) {
×
527
  SEpSet epSet = {.numOfEps = 1, .inUse = 0};
×
528
  memcpy(epSet.eps[0].fqdn, pBnode->pDnode->fqdn, TSDB_FQDN_LEN);
×
529
  epSet.eps[0].port = pBnode->pDnode->port;
×
530
  return epSet;
×
531
}
532

533
SBnodeObj *mndAcquireBnode(SMnode *pMnode, int32_t dnodeId) {
48,697✔
534
  SBnodeObj *pObj = sdbAcquire(pMnode->pSdb, SDB_BNODE, &dnodeId);
48,697✔
535
  if (pObj == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
48,697✔
536
    terrno = TSDB_CODE_MND_BNODE_NOT_EXIST;
29,949✔
537
  }
538
  return pObj;
48,697✔
539
}
540

541
void mndReleaseBnode(SMnode *pMnode, SBnodeObj *pObj) {
32,566✔
542
  SSdb *pSdb = pMnode->pSdb;
32,566✔
543
  sdbRelease(pSdb, pObj);
32,566✔
544
}
32,566✔
545

546
int32_t mndInitBnode(SMnode *pMnode) {
228,256✔
547
  SSdbTable table = {
228,256✔
548
      .sdbType = SDB_BNODE,
549
      .keyType = SDB_KEY_INT32,
550
      .encodeFp = (SdbEncodeFp)mndBnodeActionEncode,
551
      .decodeFp = (SdbDecodeFp)mndBnodeActionDecode,
552
      .insertFp = (SdbInsertFp)mndBnodeActionInsert,
553
      .updateFp = (SdbUpdateFp)mndBnodeActionUpdate,
554
      .deleteFp = (SdbDeleteFp)mndBnodeActionDelete,
555
  };
556

557
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_BNODE, mndProcessCreateBnodeReq);
228,256✔
558
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_BNODE, mndProcessDropBnodeReq);
228,256✔
559
  mndSetMsgHandle(pMnode, TDMT_DND_CREATE_BNODE_RSP, mndTransProcessRsp);
228,256✔
560
  mndSetMsgHandle(pMnode, TDMT_DND_DROP_BNODE_RSP, mndTransProcessRsp);
228,256✔
561

562
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_BNODE, mndRetrieveBnodes);
228,256✔
563
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_BNODE, mndCancelGetNextBnode);
228,256✔
564

565
  return sdbSetTable(pMnode->pSdb, table);
228,256✔
566
}
567

568
void mndCleanupBnode(SMnode *pMnode) {}
228,205✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc