• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4881

14 Dec 2025 03:48AM UTC coverage: 60.617% (+0.5%) from 60.092%
#4881

push

travis-ci

web-flow
test: update coverage workflow time (#33918)

156854 of 258761 relevant lines covered (60.62%)

75258957.81 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.58
/source/client/src/clientSmlTelnet.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include <ctype.h>
17
#include <stdio.h>
18
#include <stdlib.h>
19
#include <string.h>
20

21
#include "clientSml.h"
22

23
int32_t is_same_child_table_telnet(const void *a, const void *b) {
491,066✔
24
  SSmlLineInfo *t1 = (SSmlLineInfo *)a;
491,066✔
25
  SSmlLineInfo *t2 = (SSmlLineInfo *)b;
491,066✔
26
  if (t1 == NULL || t2 == NULL || t1->measure == NULL || t2->measure == NULL || t1->tags == NULL || t2->tags == NULL)
491,066✔
27
    return 1;
343,053✔
28
  return (((t1->measureLen == t2->measureLen) && memcmp(t1->measure, t2->measure, t1->measureLen) == 0) &&
149,405✔
29
          ((t1->tagsLen == t2->tagsLen) && memcmp(t1->tags, t2->tags, t1->tagsLen) == 0))
146,126✔
30
             ? 0
31
             : 1;
440,538✔
32
}
33

34
int64_t smlParseOpenTsdbTime(SSmlHandle *info, const char *data, int32_t len) {
186,431✔
35
  uint8_t toPrecision = info->currSTableMeta ? info->currSTableMeta->tableInfo.precision : TSDB_TIME_PRECISION_NANO;
186,431✔
36

37
  if (unlikely(!data)) {
186,431✔
38
    smlBuildInvalidDataMsg(&info->msgBuf, "timestamp can not be null", NULL);
×
39
    return -1;
×
40
  }
41
  if (unlikely(len == 1 && data[0] == '0')) {
186,431✔
42
    return taosGetTimestampNs() / smlFactorNS[toPrecision];
1,572✔
43
  }
44
  int8_t fromPrecision = smlGetTsTypeByLen(len);
185,645✔
45
  if (unlikely(fromPrecision == -1)) {
185,645✔
46
    smlBuildInvalidDataMsg(&info->msgBuf,
8,253✔
47
                           "timestamp precision can only be seconds(10 digits) or milli seconds(13 digits)", data);
48
    return -1;
8,253✔
49
  }
50
  int64_t ts = smlGetTimeValue(data, len, fromPrecision, toPrecision);
177,392✔
51
  if (unlikely(ts == -1)) {
177,392✔
52
    smlBuildInvalidDataMsg(&info->msgBuf, "invalid timestamp", data);
24✔
53
    return -1;
×
54
  }
55
  return ts;
177,368✔
56
}
57

58
static void smlParseTelnetElement(char **sql, char *sqlEnd, char **data, int32_t *len) {
556,005✔
59
  while (*sql < sqlEnd) {
6,139,238✔
60
    if (unlikely((**sql != SPACE && !(*data)))) {
6,134,249✔
61
      *data = *sql;
556,077✔
62
    } else if (unlikely(**sql == SPACE && *data)) {
5,578,172✔
63
      *len = *sql - *data;
551,016✔
64
      break;
551,016✔
65
    }
66
    (*sql)++;
5,583,233✔
67
  }
68
}
556,005✔
69

70
static int32_t smlProcessTagTelnet(SSmlHandle *info, char *data, char *sqlEnd){
64,920✔
71
  SArray *preLineKV = info->preLineTagKV;
64,920✔
72
  taosArrayClearEx(preLineKV, freeSSmlKv);
64,920✔
73
  int     cnt = 0;
64,920✔
74

75
  const char *sql = data;
64,920✔
76
  while (sql < sqlEnd) {
621,378✔
77
    JUMP_SPACE(sql, sqlEnd)
1,066,619✔
78
    if (unlikely(*sql == '\0' || *sql == '\n')) break;
565,048✔
79

80
    const char *key = sql;
558,534✔
81
    size_t      keyLen = 0;
558,534✔
82

83
    // parse key
84
    while (sql < sqlEnd) {
1,879,579✔
85
      if (unlikely(*sql == SPACE)) {
1,879,186✔
86
        smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", sql);
786✔
87
        return TSDB_CODE_SML_INVALID_DATA;
786✔
88
      }
89
      if (unlikely(*sql == EQUAL)) {
1,878,400✔
90
        keyLen = sql - key;
557,355✔
91
        sql++;
557,355✔
92
        break;
557,355✔
93
      }
94
      sql++;
1,321,045✔
95
    }
96

97
    if (unlikely(IS_INVALID_COL_LEN(keyLen))) {
557,748✔
98
      smlBuildInvalidDataMsg(&info->msgBuf, "invalid key or key is too long than 64", key);
786✔
99
      return TSDB_CODE_TSC_INVALID_COLUMN_LENGTH;
786✔
100
    }
101

102
    // parse value
103
    const char *value = sql;
556,962✔
104
    size_t      valueLen = 0;
556,962✔
105
    while (sql < sqlEnd) {
6,149,340✔
106
      // parse value
107
      if (unlikely(*sql == SPACE)) {
6,093,010✔
108
        break;
500,632✔
109
      }
110
      if (unlikely(*sql == EQUAL)) {
5,592,378✔
111
        smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", sql);
×
112
        return TSDB_CODE_SML_INVALID_DATA;
×
113
      }
114
      sql++;
5,592,378✔
115
    }
116
    valueLen = sql - value;
556,962✔
117

118
    if (unlikely(valueLen == 0)) {
556,962✔
119
      smlBuildInvalidDataMsg(&info->msgBuf, "invalid value", value);
×
120
      return TSDB_CODE_TSC_INVALID_VALUE;
×
121
    }
122

123
    if (unlikely(valueLen > (TSDB_MAX_TAGS_LEN - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE)) {
556,962✔
124
      return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
125
    }
126

127
    SSmlKv kv = {.key = key,
556,962✔
128
        .keyLen = keyLen,
129
        .type = TSDB_DATA_TYPE_NCHAR,
130
        .value = value,
131
        .length = valueLen,
132
        .keyEscaped = false,
133
        .valueEscaped = false};
134
    if (taosArrayPush(preLineKV, &kv) == NULL){
556,962✔
135
      return terrno;
×
136
    }
137
    if (info->dataFormat && !isSmlTagAligned(info, cnt, &kv)) {
556,962✔
138
      return TSDB_CODE_SML_INVALID_DATA;
504✔
139
    }
140
    cnt++;
556,458✔
141
  }
142
  return TSDB_CODE_SUCCESS;
62,844✔
143
}
144

145
static int32_t smlParseTelnetTags(SSmlHandle *info, char *data, char *sqlEnd, SSmlLineInfo *elements) {
171,104✔
146
  if (is_same_child_table_telnet(elements, &info->preLine) == 0) {
171,104✔
147
    elements->measureTag = info->preLine.measureTag;
49,121✔
148
    return TSDB_CODE_SUCCESS;
49,121✔
149
  }
150

151
  int32_t code = 0;
122,007✔
152
  int32_t lino = 0;
122,007✔
153
  if(info->dataFormat){
122,007✔
154
    SML_CHECK_CODE(smlProcessSuperTable(info, elements));
64,134✔
155
  }
156
  SML_CHECK_CODE(smlProcessTagTelnet(info, data, sqlEnd));
64,920✔
157
  SML_CHECK_CODE(smlJoinMeasureTag(elements));
62,844✔
158

159
  code = smlProcessChildTable(info, elements);
62,844✔
160

161
END:
122,007✔
162
  if(info->reRun){
122,007✔
163
    return TSDB_CODE_SUCCESS;
57,045✔
164
  }
165
  RETURN
64,962✔
166
}
167

168
// format: <metric> <timestamp> <value> <tagk_1>=<tagv_1>[ <tagk_n>=<tagv_n>]
169
int32_t smlParseTelnetString(SSmlHandle *info, char *sql, char *sqlEnd, SSmlLineInfo *elements) {
191,564✔
170
  if (!sql) return TSDB_CODE_SML_INVALID_DATA;
191,564✔
171

172
  // parse metric
173
  smlParseTelnetElement(&sql, sqlEnd, &elements->measure, &elements->measureLen);
191,564✔
174
  if (unlikely((!(elements->measure) || IS_INVALID_TABLE_LEN(elements->measureLen)))) {
191,540✔
175
    smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid measure", sql);
5,109✔
176
    return TSDB_CODE_TSC_INVALID_TABLE_ID_LENGTH;
5,109✔
177
  }
178

179
  // parse timestamp
180
  smlParseTelnetElement(&sql, sqlEnd, &elements->timestamp, &elements->timestampLen);
186,431✔
181
  if (unlikely(!elements->timestamp || elements->timestampLen == 0)) {
186,455✔
182
    smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid timestamp", sql);
×
183
    return TSDB_CODE_SML_INVALID_DATA;
×
184
  }
185

186
  bool needConverTime = false;  // get TS before parse tag(get meta), so need convert time
186,455✔
187
  if (info->dataFormat && info->currSTableMeta == NULL) {
186,455✔
188
    needConverTime = true;
79,002✔
189
  }
190
  int64_t ts = smlParseOpenTsdbTime(info, elements->timestamp, elements->timestampLen);
186,455✔
191
  if (unlikely(ts < 0)) {
186,407✔
192
    smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet parse timestamp failed", sql);
8,253✔
193
    return TSDB_CODE_INVALID_TIMESTAMP;
8,253✔
194
  }
195

196
  // parse value
197
  smlParseTelnetElement(&sql, sqlEnd, &elements->cols, &elements->colsLen);
178,154✔
198
  if (unlikely(!elements->cols || elements->colsLen == 0)) {
178,178✔
199
    smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid value", sql);
393✔
200
    return TSDB_CODE_TSC_INVALID_VALUE;
393✔
201
  }
202

203
  SSmlKv kv = {.key = VALUE, .keyLen = VALUE_LEN, .value = elements->cols, .length = (size_t)elements->colsLen};
177,785✔
204
  int ret = smlParseValue(&kv, &info->msgBuf);
177,785✔
205
  if (ret != TSDB_CODE_SUCCESS) {
177,785✔
206
    uError("SML:0x%" PRIx64 " %s parse value error:%d.", info->id, __FUNCTION__, ret);
6,681✔
207
    return TSDB_CODE_TSC_INVALID_VALUE;
6,681✔
208
  }
209

210
  JUMP_SPACE(sql, sqlEnd)
353,128✔
211

212
  elements->tags = sql;
171,104✔
213
  elements->tagsLen = sqlEnd - sql;
171,104✔
214
  if (unlikely(!elements->tags || elements->tagsLen == 0)) {
171,104✔
215
    smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid tag value", sql);
×
216
    return TSDB_CODE_TSC_INVALID_VALUE;
×
217
  }
218

219
  ret = smlParseTelnetTags(info, sql, sqlEnd, elements);
171,104✔
220
  if (unlikely(ret != TSDB_CODE_SUCCESS)) {
171,128✔
221
    return ret;
2,118✔
222
  }
223

224
  if (unlikely(info->reRun)) {
169,010✔
225
    return TSDB_CODE_SUCCESS;
57,045✔
226
  }
227

228
  SSmlKv kvTs = {0};
111,965✔
229
  smlBuildTsKv(&kvTs, ts);
111,965✔
230
  if (needConverTime && info->currSTableMeta != NULL) {
111,965✔
231
    kvTs.i = convertTimePrecision(kvTs.i, TSDB_TIME_PRECISION_NANO, info->currSTableMeta->tableInfo.precision);
5,691✔
232
  }
233

234
  if (info->dataFormat){
111,965✔
235
    ret = smlParseEndTelnetJsonFormat(info, elements, &kvTs, &kv);
44,994✔
236
  } else {
237
    ret = smlParseEndTelnetJsonUnFormat(info, elements, &kvTs, &kv);
66,971✔
238
  }
239
  info->preLine = *elements;
111,965✔
240

241
  return ret;
111,965✔
242
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc