• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4879

11 Dec 2025 02:43AM UTC coverage: 64.544% (-0.03%) from 64.569%
#4879

push

travis-ci

guanshengliang
feat(TS-7270): internal dependence

307 of 617 new or added lines in 24 files covered. (49.76%)

3883 existing lines in 125 files now uncovered.

163565 of 253417 relevant lines covered (64.54%)

105600506.39 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.64
/source/dnode/vnode/src/meta/metaTable2.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "meta.h"
17

18
extern int32_t metaHandleEntry2(SMeta *pMeta, const SMetaEntry *pEntry);
19
extern int32_t metaUpdateMetaRsp(tb_uid_t uid, char *tbName, SSchemaWrapper *pSchema, STableMetaRsp *pMetaRsp);
20
extern int32_t metaUpdateVtbMetaRsp(SMetaEntry *pEntry, char *tbName, SSchemaWrapper *pSchema, SColRefWrapper *pRef,
21
                                    STableMetaRsp *pMetaRsp, int8_t tableType);
22
extern int32_t metaFetchEntryByUid(SMeta *pMeta, int64_t uid, SMetaEntry **ppEntry);
23
extern int32_t metaFetchEntryByName(SMeta *pMeta, const char *name, SMetaEntry **ppEntry);
24
extern void    metaFetchEntryFree(SMetaEntry **ppEntry);
25
extern int32_t updataTableColCmpr(SColCmprWrapper *pWp, SSchema *pSchema, int8_t add, uint32_t compress);
26
extern int32_t addTableExtSchema(SMetaEntry *pEntry, const SSchema *pColumn, int32_t newColNum, SExtSchema *pExtSchema);
27
extern int32_t dropTableExtSchema(SMetaEntry *pEntry, int32_t dropColId, int32_t newColNum);
28

29
static int32_t metaCheckCreateSuperTableReq(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
7,073,626✔
30
  int32_t   vgId = TD_VID(pMeta->pVnode);
7,073,626✔
31
  void     *value = NULL;
7,100,109✔
32
  int32_t   valueSize = 0;
7,101,784✔
33
  SMetaInfo info;
7,095,937✔
34

35
  // check name
36
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
7,101,172✔
37
    metaError("vgId:%d, %s failed at %s:%d since invalid name:%s, version:%" PRId64, vgId, __func__, __FILE__, __LINE__,
885✔
38
              pReq->name, version);
39
    return TSDB_CODE_INVALID_MSG;
×
40
  }
41

42
  int32_t r = tdbTbGet(pMeta->pNameIdx, pReq->name, strlen(pReq->name) + 1, &value, &valueSize);
7,096,827✔
43
  if (r == 0) {  // name exists, check uid and type
7,083,461✔
44
    int64_t uid = *(tb_uid_t *)value;
2,256✔
45
    tdbFree(value);
2,256✔
46

47
    if (pReq->suid != uid) {
2,256✔
48
      metaError("vgId:%d, %s failed at %s:%d since table %s uid:%" PRId64 " already exists, request uid:%" PRId64
2,256✔
49
                " version:%" PRId64,
50
                vgId, __func__, __FILE__, __LINE__, pReq->name, uid, pReq->suid, version);
51
      return TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
2,256✔
52
    }
53

54
    if (metaGetInfo(pMeta, uid, &info, NULL) == TSDB_CODE_NOT_FOUND) {
×
55
      metaError("vgId:%d, %s failed at %s:%d since table %s uid:%" PRId64
×
56
                " not found, this is an internal error in meta, version:%" PRId64,
57
                vgId, __func__, __FILE__, __LINE__, pReq->name, uid, version);
58
      return TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
59
    }
60

61
    if (info.uid == info.suid) {
×
62
      return TSDB_CODE_TDB_STB_ALREADY_EXIST;
×
63
    } else {
64
      metaError("vgId:%d, %s failed at %s:%d since table %s uid:%" PRId64
×
65
                " already exists but not a super table, version:%" PRId64,
66
                vgId, __func__, __FILE__, __LINE__, pReq->name, uid, version);
67
      return TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
×
68
    }
69
  }
70

71
  // check suid
72
  if (metaGetInfo(pMeta, pReq->suid, &info, NULL) != TSDB_CODE_NOT_FOUND) {
7,081,205✔
73
    metaError("vgId:%d, %s failed at %s:%d since table with uid:%" PRId64 " already exist, name:%s version:%" PRId64,
×
74
              vgId, __func__, __FILE__, __LINE__, pReq->suid, pReq->name, version);
75
    return TSDB_CODE_INVALID_MSG;
×
76
  }
77

78
  return TSDB_CODE_SUCCESS;
7,089,956✔
79
}
80

81
static int32_t metaCheckDropTableReq(SMeta *pMeta, int64_t version, SVDropTbReq *pReq) {
946,698✔
82
  int32_t   code = TSDB_CODE_SUCCESS;
946,698✔
83
  void     *value = NULL;
946,698✔
84
  int32_t   valueSize = 0;
946,698✔
85
  SMetaInfo info;
946,698✔
86

87
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
946,698✔
88
    metaError("vgId:%d, %s failed at %s:%d since invalid name:%s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
89
              __FILE__, __LINE__, pReq->name, version);
90
    return TSDB_CODE_INVALID_MSG;
×
91
  }
92

93
  code = tdbTbGet(pMeta->pNameIdx, pReq->name, strlen(pReq->name) + 1, &value, &valueSize);
946,698✔
94
  if (TSDB_CODE_SUCCESS != code) {
946,698✔
95
    if (pReq->igNotExists) {
×
96
      metaTrace("vgId:%d, %s success since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
97
                pReq->name, version);
98
    } else {
99
      metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode),
×
100
                __func__, __FILE__, __LINE__, pReq->name, version);
101
    }
102
    return TSDB_CODE_TDB_TABLE_NOT_EXIST;
×
103
  }
104
  pReq->uid = *(tb_uid_t *)value;
946,698✔
105
  tdbFreeClear(value);
946,698✔
106

107
  code = metaGetInfo(pMeta, pReq->uid, &info, NULL);
946,698✔
108
  if (TSDB_CODE_SUCCESS != code) {
946,698✔
109
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64
×
110
              " not found, this is an internal error, version:%" PRId64,
111
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pReq->uid, version);
112
    code = TSDB_CODE_INTERNAL_ERROR;
×
113
    return code;
×
114
  }
115
  pReq->suid = info.suid;
946,698✔
116

117
  return code;
946,698✔
118
}
119

120
static int32_t metaCheckDropSuperTableReq(SMeta *pMeta, int64_t version, SVDropStbReq *pReq) {
999,925✔
121
  int32_t   code = TSDB_CODE_SUCCESS;
999,925✔
122
  void     *value = NULL;
999,925✔
123
  int32_t   valueSize = 0;
999,925✔
124
  SMetaInfo info;
999,925✔
125

126
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
1,000,540✔
127
    metaError("vgId:%d, %s failed at %s:%d since invalid name:%s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
615✔
128
              __FILE__, __LINE__, pReq->name, version);
129
    return TSDB_CODE_INVALID_MSG;
×
130
  }
131

132
  code = tdbTbGet(pMeta->pNameIdx, pReq->name, strlen(pReq->name) + 1, &value, &valueSize);
999,925✔
133
  if (code) {
998,530✔
134
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
752✔
135
              __FILE__, __LINE__, pReq->name, version);
136
    return TSDB_CODE_TDB_STB_NOT_EXIST;
752✔
137
  } else {
138
    int64_t uid = *(int64_t *)value;
997,778✔
139
    tdbFreeClear(value);
997,902✔
140

141
    if (uid != pReq->suid) {
997,287✔
142
      metaError("vgId:%d, %s failed at %s:%d since table %s uid:%" PRId64 " not match, version:%" PRId64,
752✔
143
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pReq->suid, version);
144
      return TSDB_CODE_TDB_STB_NOT_EXIST;
752✔
145
    }
146
  }
147

148
  code = metaGetInfo(pMeta, pReq->suid, &info, NULL);
996,452✔
149
  if (code) {
997,765✔
150
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64
×
151
              " not found, this is an internal error, version:%" PRId64,
152
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pReq->suid, version);
153
    return TSDB_CODE_INTERNAL_ERROR;
×
154
  }
155
  if (info.suid != info.uid) {
997,765✔
156
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64 " is not a super table, version:%" PRId64,
×
157
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pReq->suid, version);
158
    return TSDB_CODE_INVALID_MSG;
×
159
  }
160
  return code;
997,765✔
161
}
162

163
// Create Super Table
164
int32_t metaCreateSuperTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
7,081,608✔
165
  int32_t code = TSDB_CODE_SUCCESS;
7,081,608✔
166

167
  // check request
168
  code = metaCheckCreateSuperTableReq(pMeta, version, pReq);
7,081,608✔
169
  if (code != TSDB_CODE_SUCCESS) {
7,089,441✔
170
    if (code == TSDB_CODE_TDB_STB_ALREADY_EXIST) {
2,256✔
171
      metaWarn("vgId:%d, super table %s uid:%" PRId64 " already exists, version:%" PRId64, TD_VID(pMeta->pVnode),
×
172
               pReq->name, pReq->suid, version);
173
      TAOS_RETURN(TSDB_CODE_SUCCESS);
×
174
    } else {
175
      TAOS_RETURN(code);
2,256✔
176
    }
177
  }
178

179
  // handle entry
180
  SMetaEntry entry = {
14,157,143✔
181
      .version = version,
182
      .type = TSDB_SUPER_TABLE,
183
      .uid = pReq->suid,
7,089,650✔
184
      .name = pReq->name,
7,087,972✔
185
      .stbEntry.schemaRow = pReq->schemaRow,
186
      .stbEntry.schemaTag = pReq->schemaTag,
187
      .stbEntry.keep = pReq->keep,
7,076,657✔
188
  };
189
  if (pReq->rollup) {
7,074,332✔
190
    TABLE_SET_ROLLUP(entry.flags);
×
191
    entry.stbEntry.rsmaParam = pReq->rsmaParam;
×
192
  }
193
  if (pReq->colCmpred) {
7,088,823✔
194
    TABLE_SET_COL_COMPRESSED(entry.flags);
7,086,517✔
195
    entry.colCmpr = pReq->colCmpr;
7,086,517✔
196
  }
197

198
  entry.pExtSchemas = pReq->pExtSchemas;
7,056,576✔
199

200
  if (pReq->virtualStb) {
7,080,044✔
201
    TABLE_SET_VIRTUAL(entry.flags);
48,899✔
202
  }
203

204
  code = metaHandleEntry2(pMeta, &entry);
7,074,423✔
205
  if (TSDB_CODE_SUCCESS == code) {
7,100,671✔
206
    metaInfo("vgId:%d, super table %s suid:%" PRId64 " is created, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->name,
7,099,597✔
207
             pReq->suid, version);
208
  } else {
209
    metaError("vgId:%d, failed to create stb:%s uid:%" PRId64 " since %s", TD_VID(pMeta->pVnode), pReq->name,
1,074✔
210
              pReq->suid, tstrerror(code));
211
  }
212
  TAOS_RETURN(code);
7,100,671✔
213
}
214

215
// Drop Super Table
216
int32_t metaDropSuperTable(SMeta *pMeta, int64_t verison, SVDropStbReq *pReq) {
999,925✔
217
  int32_t code = TSDB_CODE_SUCCESS;
999,925✔
218

219
  // check request
220
  code = metaCheckDropSuperTableReq(pMeta, verison, pReq);
999,925✔
221
  if (code) {
999,925✔
222
    TAOS_RETURN(code);
1,504✔
223
  }
224

225
  // handle entry
226
  SMetaEntry entry = {
998,421✔
227
      .version = verison,
228
      .type = -TSDB_SUPER_TABLE,
229
      .uid = pReq->suid,
997,398✔
230
  };
231
  code = metaHandleEntry2(pMeta, &entry);
996,127✔
232
  if (code) {
999,036✔
233
    metaError("vgId:%d, failed to drop stb:%s uid:%" PRId64 " since %s", TD_VID(pMeta->pVnode), pReq->name, pReq->suid,
×
234
              tstrerror(code));
235
  } else {
236
    metaInfo("vgId:%d, super table %s uid:%" PRId64 " is dropped, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->name,
999,036✔
237
             pReq->suid, verison);
238
  }
239
  TAOS_RETURN(code);
999,036✔
240
}
241

242
// Alter Super Table
243

244
// Create Child Table
245
static int32_t metaCheckCreateChildTableReq(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq) {
52,162,685✔
246
  int32_t   code = TSDB_CODE_SUCCESS;
52,162,685✔
247
  void     *value = NULL;
52,162,685✔
248
  int32_t   valueSize = 0;
52,163,976✔
249
  SMetaInfo info;
52,142,842✔
250

251
  if (NULL == pReq->name || strlen(pReq->name) == 0 || NULL == pReq->ctb.stbName || strlen(pReq->ctb.stbName) == 0 ||
52,165,217✔
252
      pReq->ctb.suid == 0) {
52,161,388✔
253
    metaError("vgId:%d, %s failed at %s:%d since invalid name:%s stb name:%s, version:%" PRId64, TD_VID(pMeta->pVnode),
1,765✔
254
              __func__, __FILE__, __LINE__, pReq->name, pReq->ctb.stbName, version);
255
    return TSDB_CODE_INVALID_MSG;
×
256
  }
257

258
  // check table existence
259
  if (tdbTbGet(pMeta->pNameIdx, pReq->name, strlen(pReq->name) + 1, &value, &valueSize) == 0) {
52,162,214✔
260
    pReq->uid = *(int64_t *)value;
706,649✔
261
    tdbFreeClear(value);
706,649✔
262

263
    if (metaGetInfo(pMeta, pReq->uid, &info, NULL) != 0) {
706,649✔
264
      metaError("vgId:%d, %s failed at %s:%d since cannot find table with uid %" PRId64
×
265
                ", which is an internal error, version:%" PRId64,
266
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->uid, version);
267
      return TSDB_CODE_INTERNAL_ERROR;
×
268
    }
269

270
    // check table type
271
    if (info.suid == info.uid || info.suid == 0) {
706,649✔
272
      metaError("vgId:%d, %s failed at %s:%d since table with uid %" PRId64 " is not a super table, version:%" PRId64,
1,044✔
273
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->uid, version);
274
      return TSDB_CODE_TDB_TABLE_IN_OTHER_STABLE;
1,044✔
275
    }
276

277
    // check suid
278
    if (info.suid != pReq->ctb.suid) {
705,605✔
279
      metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64 " exists in another stable with uid %" PRId64
×
280
                " instead of stable with uid %" PRId64 " version:%" PRId64,
281
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pReq->uid, info.suid, pReq->ctb.suid,
282
                version);
283
      return TSDB_CODE_TDB_TABLE_IN_OTHER_STABLE;
×
284
    }
285

286
    return TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
705,605✔
287
  }
288

289
  // check super table existence
290
  SMetaEntry *pStbEntry = NULL;
51,456,384✔
291
  code = metaFetchEntryByName(pMeta, pReq->ctb.stbName, &pStbEntry);
51,456,080✔
292
  if (code) {
51,451,481✔
293
    metaError("vgId:%d, %s failed at %s:%d since super table %s does not exist, version:%" PRId64,
×
294
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->ctb.stbName, version);
295
    return TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
296
  }
297

298
  if (pStbEntry->type != TSDB_SUPER_TABLE) {
51,451,481✔
299
    metaError("vgId:%d, %s failed at %s:%d since table %s is not a super table, version:%" PRId64,
×
300
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->ctb.stbName, version);
301
    metaFetchEntryFree(&pStbEntry);
×
302
    return TSDB_CODE_INVALID_MSG;
×
303
  }
304

305
  if (pStbEntry->uid != pReq->ctb.suid) {
51,451,143✔
306
    metaError("vgId:%d, %s failed at %s:%d since super table %s uid %" PRId64 " does not match request uid %" PRId64
×
307
              ", version:%" PRId64,
308
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->ctb.stbName, pStbEntry->uid, pReq->ctb.suid,
309
              version);
310
    metaFetchEntryFree(&pStbEntry);
×
311
    return TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
312
  }
313

314
  // Check tag value
315
  SSchemaWrapper *pTagSchema = &pStbEntry->stbEntry.schemaTag;
51,447,093✔
316
  const STag     *pTag = (const STag *)pReq->ctb.pTag;
51,454,407✔
317
  if (pTagSchema->nCols != 1 || pTagSchema->pSchema[0].type != TSDB_DATA_TYPE_JSON) {
51,450,284✔
318
    for (int32_t i = 0; i < pTagSchema->nCols; ++i) {
233,078,069✔
319
      STagVal tagVal = {
181,945,127✔
320
          .cid = pTagSchema->pSchema[i].colId,
181,940,433✔
321
      };
322

323
      if (tTagGet(pTag, &tagVal)) {
181,946,508✔
324
        if (pTagSchema->pSchema[i].type != tagVal.type) {
134,043,841✔
325
          metaError("vgId:%d, %s failed at %s:%d since child table %s tag type does not match the expected type, version:%" PRId64,
×
326
                    TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, version);
327
          metaFetchEntryFree(&pStbEntry);
×
328
          return TSDB_CODE_INVALID_MSG;
×
329
        }
330
      }
331
    }
332
  }
333

334
  metaFetchEntryFree(&pStbEntry);
51,451,726✔
335

336
  // check grant
337
  if (!metaTbInFilterCache(pMeta, pReq->ctb.stbName, 1)) {
51,451,382✔
338
    code = grantCheck(TSDB_GRANT_TIMESERIES);
51,454,551✔
339
    if (TSDB_CODE_SUCCESS != code) {
51,443,067✔
340
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
341
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
342
    }
343
  }
344
  return code;
51,447,959✔
345
}
346

347
static int32_t metaBuildCreateChildTableRsp(SMeta *pMeta, const SMetaEntry *pEntry, STableMetaRsp **ppRsp) {
51,260,540✔
348
  int32_t code = TSDB_CODE_SUCCESS;
51,260,540✔
349

350
  if (NULL == ppRsp) {
51,260,540✔
351
    return code;
×
352
  }
353

354
  *ppRsp = taosMemoryCalloc(1, sizeof(STableMetaRsp));
51,260,540✔
355
  if (NULL == ppRsp) {
51,252,541✔
356
    return terrno;
×
357
  }
358

359
  (*ppRsp)->tableType = TSDB_CHILD_TABLE;
51,252,541✔
360
  (*ppRsp)->tuid = pEntry->uid;
51,260,544✔
361
  (*ppRsp)->suid = pEntry->ctbEntry.suid;
51,259,293✔
362
  tstrncpy((*ppRsp)->tbName, pEntry->name, TSDB_TABLE_NAME_LEN);
51,265,974✔
363

364
  return code;
51,264,131✔
365
}
366

367
static int32_t metaCreateChildTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq, STableMetaRsp **ppRsp) {
51,973,280✔
368
  int32_t code = TSDB_CODE_SUCCESS;
51,973,280✔
369

370
  // check request
371
  code = metaCheckCreateChildTableReq(pMeta, version, pReq);
51,973,280✔
372
  if (code) {
51,965,053✔
373
    if (TSDB_CODE_TDB_TABLE_ALREADY_EXIST != code) {
706,649✔
374
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
1,044✔
375
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
376
    }
377
    return code;
706,649✔
378
  }
379

380
  SMetaEntry entry = {
51,258,404✔
381
      .version = version,
382
      .type = TSDB_CHILD_TABLE,
383
      .uid = pReq->uid,
51,259,616✔
384
      .name = pReq->name,
51,256,678✔
385
      .ctbEntry.btime = pReq->btime,
51,255,544✔
386
      .ctbEntry.ttlDays = pReq->ttl,
51,254,372✔
387
      .ctbEntry.commentLen = pReq->commentLen,
51,263,731✔
388
      .ctbEntry.comment = pReq->comment,
51,262,914✔
389
      .ctbEntry.suid = pReq->ctb.suid,
51,256,885✔
390
      .ctbEntry.pTags = pReq->ctb.pTag,
51,253,728✔
391
  };
392

393
  // build response
394
  code = metaBuildCreateChildTableRsp(pMeta, &entry, ppRsp);
51,262,013✔
395
  if (code) {
51,262,752✔
396
    metaError("vgId:%d, %s failed at %s:%d since %s", TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__,
×
397
              tstrerror(code));
398
  }
399

400
  // handle entry
401
  code = metaHandleEntry2(pMeta, &entry);
51,262,752✔
402
  if (TSDB_CODE_SUCCESS == code) {
51,264,137✔
403
    metaInfo("vgId:%d, index:%" PRId64 ", child table is created, tb:%s uid:%" PRId64 " suid:%" PRId64,
51,266,742✔
404
             TD_VID(pMeta->pVnode), version, pReq->name, pReq->uid, pReq->ctb.suid);
405
  } else {
406
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s suid:%" PRId64 " version:%" PRId64,
×
407
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name,
408
              pReq->ctb.suid, version);
409
  }
410
  return code;
51,270,840✔
411
}
412

413
// Drop Child Table
414

415
// Alter Child Table
416

417
// Create Normal Table
418
static int32_t metaCheckCreateNormalTableReq(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq) {
2,396,690✔
419
  int32_t code = 0;
2,396,690✔
420
  void   *value = NULL;
2,396,690✔
421
  int32_t valueSize = 0;
2,396,690✔
422

423
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
2,396,690✔
424
    metaError("vgId:%d, %s failed at %s:%d since invalid name:%s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
425
              __FILE__, __LINE__, pReq->name, version);
426
    return TSDB_CODE_INVALID_MSG;
×
427
  }
428

429
  // check name
430
  if (tdbTbGet(pMeta->pNameIdx, pReq->name, strlen(pReq->name) + 1, &value, &valueSize) == 0) {
2,396,690✔
431
    // for auto create table, we return the uid of the existing table
432
    pReq->uid = *(tb_uid_t *)value;
38,970✔
433
    tdbFree(value);
38,970✔
434
    return TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
38,970✔
435
  }
436

437
  // grant check
438
  code = grantCheck(TSDB_GRANT_TIMESERIES);
2,357,720✔
439
  if (code) {
2,357,720✔
440
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
441
              __FILE__, __LINE__, tstrerror(code), version, pReq->name);
442
  }
443
  return code;
2,357,720✔
444
}
445

446
static int32_t metaBuildCreateNormalTableRsp(SMeta *pMeta, SMetaEntry *pEntry, STableMetaRsp **ppRsp) {
2,251,913✔
447
  int32_t code = TSDB_CODE_SUCCESS;
2,251,913✔
448

449
  if (NULL == ppRsp) {
2,251,913✔
450
    return code;
×
451
  }
452

453
  *ppRsp = taosMemoryCalloc(1, sizeof(STableMetaRsp));
2,251,913✔
454
  if (NULL == *ppRsp) {
2,251,913✔
455
    return terrno;
×
456
  }
457

458
  code = metaUpdateMetaRsp(pEntry->uid, pEntry->name, &pEntry->ntbEntry.schemaRow, *ppRsp);
2,251,913✔
459
  if (code) {
2,251,913✔
460
    taosMemoryFreeClear(*ppRsp);
×
461
    return code;
×
462
  }
463

464
  for (int32_t i = 0; i < pEntry->colCmpr.nCols; i++) {
35,463,943✔
465
    SColCmpr *p = &pEntry->colCmpr.pColCmpr[i];
33,212,030✔
466
    (*ppRsp)->pSchemaExt[i].colId = p->id;
33,212,030✔
467
    (*ppRsp)->pSchemaExt[i].compress = p->alg;
33,212,030✔
468
    if (pEntry->pExtSchemas) {
33,212,030✔
469
      (*ppRsp)->pSchemaExt[i].typeMod = pEntry->pExtSchemas[i].typeMod;
777,135✔
470
    }
471
  }
472

473
  return code;
2,251,913✔
474
}
475

476
static int32_t metaCreateNormalTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq, STableMetaRsp **ppRsp) {
2,290,883✔
477
  int32_t code = TSDB_CODE_SUCCESS;
2,290,883✔
478

479
  // check request
480
  code = metaCheckCreateNormalTableReq(pMeta, version, pReq);
2,290,883✔
481
  if (code) {
2,290,883✔
482
    if (TSDB_CODE_TDB_TABLE_ALREADY_EXIST != code) {
38,970✔
483
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
484
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
485
    }
486
    TAOS_RETURN(code);
38,970✔
487
  }
488

489
  SMetaEntry entry = {
4,500,945✔
490
      .version = version,
491
      .type = TSDB_NORMAL_TABLE,
492
      .uid = pReq->uid,
2,251,913✔
493
      .name = pReq->name,
2,251,913✔
494
      .ntbEntry.btime = pReq->btime,
2,251,913✔
495
      .ntbEntry.ttlDays = pReq->ttl,
2,251,913✔
496
      .ntbEntry.commentLen = pReq->commentLen,
2,251,913✔
497
      .ntbEntry.comment = pReq->comment,
2,251,913✔
498
      .ntbEntry.schemaRow = pReq->ntb.schemaRow,
499
      .ntbEntry.ncid = pReq->ntb.schemaRow.pSchema[pReq->ntb.schemaRow.nCols - 1].colId + 1,
2,251,913✔
500
      .colCmpr = pReq->colCmpr,
501
      .pExtSchemas = pReq->pExtSchemas,
2,251,913✔
502
  };
503
  TABLE_SET_COL_COMPRESSED(entry.flags);
2,251,913✔
504

505
  // build response
506
  code = metaBuildCreateNormalTableRsp(pMeta, &entry, ppRsp);
2,251,913✔
507
  if (code) {
2,251,913✔
508
    metaError("vgId:%d, %s failed at %s:%d since %s", TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__,
×
509
              tstrerror(code));
510
  }
511

512
  // handle entry
513
  code = metaHandleEntry2(pMeta, &entry);
2,251,913✔
514
  if (TSDB_CODE_SUCCESS == code) {
2,251,913✔
515
    metaInfo("vgId:%d, index:%" PRId64 ", normal table is created, tb:%s uid:%" PRId64, TD_VID(pMeta->pVnode), version,
2,251,913✔
516
             pReq->name, pReq->uid);
517
  } else {
518
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
519
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name, version);
520
  }
521
  TAOS_RETURN(code);
2,251,913✔
522
}
523

524
static int32_t metaBuildCreateVirtualNormalTableRsp(SMeta *pMeta, SMetaEntry *pEntry, STableMetaRsp **ppRsp) {
105,807✔
525
  int32_t code = TSDB_CODE_SUCCESS;
105,807✔
526

527
  if (NULL == ppRsp) {
105,807✔
528
    return code;
×
529
  }
530

531
  *ppRsp = taosMemoryCalloc(1, sizeof(STableMetaRsp));
105,807✔
532
  if (NULL == *ppRsp) {
105,807✔
533
    return terrno;
×
534
  }
535

536
  code = metaUpdateVtbMetaRsp(pEntry, pEntry->name, &pEntry->ntbEntry.schemaRow, &pEntry->colRef, *ppRsp,
105,807✔
537
                              TSDB_VIRTUAL_NORMAL_TABLE);
538
  if (code) {
105,807✔
539
    taosMemoryFreeClear(*ppRsp);
×
540
    return code;
×
541
  }
542

543
  return code;
105,807✔
544
}
545

546
static int32_t metaCreateVirtualNormalTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq, STableMetaRsp **ppRsp) {
105,807✔
547
  // check request
548
  int32_t code = metaCheckCreateNormalTableReq(pMeta, version, pReq);
105,807✔
549
  if (code) {
105,807✔
550
    if (TSDB_CODE_TDB_TABLE_ALREADY_EXIST != code) {
×
551
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
552
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
553
    }
554
    TAOS_RETURN(code);
×
555
  }
556

557
  SMetaEntry entry = {.version = version,
211,614✔
558
                      .type = TSDB_VIRTUAL_NORMAL_TABLE,
559
                      .uid = pReq->uid,
105,807✔
560
                      .name = pReq->name,
105,807✔
561
                      .ntbEntry.btime = pReq->btime,
105,807✔
562
                      .ntbEntry.ttlDays = pReq->ttl,
105,807✔
563
                      .ntbEntry.commentLen = pReq->commentLen,
105,807✔
564
                      .ntbEntry.comment = pReq->comment,
105,807✔
565
                      .ntbEntry.schemaRow = pReq->ntb.schemaRow,
566
                      .ntbEntry.ncid = pReq->ntb.schemaRow.pSchema[pReq->ntb.schemaRow.nCols - 1].colId + 1,
105,807✔
567
                      .colRef = pReq->colRef};
568

569
  code = metaBuildCreateVirtualNormalTableRsp(pMeta, &entry, ppRsp);
105,807✔
570
  if (code) {
105,807✔
571
    metaError("vgId:%d, %s failed at %s:%d since %s", TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__,
×
572
              tstrerror(code));
573
  }
574

575
  // handle entry
576
  code = metaHandleEntry2(pMeta, &entry);
105,807✔
577
  if (TSDB_CODE_SUCCESS == code) {
105,807✔
578
    metaInfo("vgId:%d, index:%" PRId64 ", virtual normal table is created, tb:%s uid:%" PRId64, TD_VID(pMeta->pVnode),
105,807✔
579
             version, pReq->name, pReq->uid);
580
  } else {
581
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
582
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name, version);
583
  }
584
  TAOS_RETURN(code);
105,807✔
585
#if 0
586
  metaTimeSeriesNotifyCheck(pMeta);
587
#endif
588
}
589

590
static int32_t metaBuildCreateVirtualChildTableRsp(SMeta *pMeta, SMetaEntry *pEntry, STableMetaRsp **ppRsp) {
189,565✔
591
  int32_t code = TSDB_CODE_SUCCESS;
189,565✔
592

593
  if (NULL == ppRsp) {
189,565✔
594
    return code;
×
595
  }
596

597
  *ppRsp = taosMemoryCalloc(1, sizeof(STableMetaRsp));
189,565✔
598
  if (NULL == *ppRsp) {
189,565✔
599
    return terrno;
×
600
  }
601

602
  code = metaUpdateVtbMetaRsp(pEntry, pEntry->name, NULL, &pEntry->colRef, *ppRsp, TSDB_VIRTUAL_CHILD_TABLE);
189,565✔
603
  if (code) {
189,565✔
604
    taosMemoryFreeClear(*ppRsp);
×
605
    return code;
×
606
  }
607
  (*ppRsp)->suid = pEntry->ctbEntry.suid;
189,565✔
608

609
  return code;
189,565✔
610
}
611

612
static int32_t metaCreateVirtualChildTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq, STableMetaRsp **ppRsp) {
189,565✔
613
  // check request
614
  int32_t code = metaCheckCreateChildTableReq(pMeta, version, pReq);
189,565✔
615
  if (code) {
189,565✔
616
    if (TSDB_CODE_TDB_TABLE_ALREADY_EXIST != code) {
×
617
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
618
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
619
    }
620
    TAOS_RETURN(code);
×
621
  }
622

623
  SMetaEntry entry = {.version = version,
379,130✔
624
                      .type = TSDB_VIRTUAL_CHILD_TABLE,
625
                      .uid = pReq->uid,
189,565✔
626
                      .name = pReq->name,
189,565✔
627
                      .ctbEntry.btime = pReq->btime,
189,565✔
628
                      .ctbEntry.ttlDays = pReq->ttl,
189,565✔
629
                      .ctbEntry.commentLen = pReq->commentLen,
189,565✔
630
                      .ctbEntry.comment = pReq->comment,
189,565✔
631
                      .ctbEntry.suid = pReq->ctb.suid,
189,565✔
632
                      .ctbEntry.pTags = pReq->ctb.pTag,
189,565✔
633
                      .colRef = pReq->colRef};
634

635
  code = metaBuildCreateVirtualChildTableRsp(pMeta, &entry, ppRsp);
189,565✔
636
  if (code) {
189,565✔
637
    metaError("vgId:%d, %s failed at %s:%d since %s", TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__,
×
638
              tstrerror(code));
639
  }
640

641
  // handle entry
642
  code = metaHandleEntry2(pMeta, &entry);
189,565✔
643
  if (TSDB_CODE_SUCCESS == code) {
189,565✔
644
    metaInfo("vgId:%d, index:%" PRId64 ", virtual child table is created, tb:%s uid:%" PRId64, TD_VID(pMeta->pVnode),
189,565✔
645
             version, pReq->name, pReq->uid);
646
  } else {
647
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
648
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name, version);
649
  }
650
  TAOS_RETURN(code);
189,565✔
651
#if 0
652
  metaTimeSeriesNotifyCheck(pMeta);
653
#endif
654
}
655

656
// Drop Normal Table
657

658
// Alter Normal Table
659

660
int32_t metaCreateTable2(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq, STableMetaRsp **ppRsp) {
54,556,789✔
661
  int32_t code = TSDB_CODE_SUCCESS;
54,556,789✔
662
  if (TSDB_CHILD_TABLE == pReq->type) {
54,556,789✔
663
    code = metaCreateChildTable(pMeta, version, pReq, ppRsp);
51,974,024✔
664
  } else if (TSDB_NORMAL_TABLE == pReq->type) {
2,586,255✔
665
    code = metaCreateNormalTable(pMeta, version, pReq, ppRsp);
2,290,883✔
666
  } else if (TSDB_VIRTUAL_NORMAL_TABLE == pReq->type) {
295,372✔
667
    code = metaCreateVirtualNormalTable(pMeta, version, pReq, ppRsp);
105,807✔
668
  } else if (TSDB_VIRTUAL_CHILD_TABLE == pReq->type) {
189,565✔
669
    code = metaCreateVirtualChildTable(pMeta, version, pReq, ppRsp);
189,565✔
670
  } else {
671
    code = TSDB_CODE_INVALID_MSG;
×
672
  }
673
  TAOS_RETURN(code);
54,563,652✔
674
}
675

676
int32_t metaDropTable2(SMeta *pMeta, int64_t version, SVDropTbReq *pReq) {
946,698✔
677
  int32_t code = TSDB_CODE_SUCCESS;
946,698✔
678

679
  // check request
680
  code = metaCheckDropTableReq(pMeta, version, pReq);
946,698✔
681
  if (code) {
946,698✔
682
    if (TSDB_CODE_TDB_TABLE_NOT_EXIST != code) {
×
683
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
684
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
685
    }
686
    TAOS_RETURN(code);
×
687
  }
688

689
  if (pReq->suid == pReq->uid) {
946,698✔
690
    code = TSDB_CODE_INVALID_PARA;
×
691
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
692
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name, version);
693
    TAOS_RETURN(code);
×
694
  }
695

696
  SMetaEntry entry = {
946,698✔
697
      .version = version,
698
      .uid = pReq->uid,
946,698✔
699
  };
700

701
  if (pReq->isVirtual) {
946,698✔
702
    if (pReq->suid == 0) {
57,061✔
703
      entry.type = -TSDB_VIRTUAL_NORMAL_TABLE;
28,701✔
704
    } else {
705
      entry.type = -TSDB_VIRTUAL_CHILD_TABLE;
28,360✔
706
    }
707
  } else {
708
    if (pReq->suid == 0) {
889,637✔
709
      entry.type = -TSDB_NORMAL_TABLE;
485,865✔
710
    } else {
711
      entry.type = -TSDB_CHILD_TABLE;
403,772✔
712
    }
713
  }
714
  code = metaHandleEntry2(pMeta, &entry);
946,698✔
715
  if (code) {
946,698✔
716
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
717
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name, version);
718
  } else {
719
    metaInfo("vgId:%d, table %s uid %" PRId64 " is dropped, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->name,
946,698✔
720
             pReq->uid, version);
721
  }
722
  TAOS_RETURN(code);
946,698✔
723
}
724

725
static int32_t metaCheckAlterTableColumnReq(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
4,417,197✔
726
  int32_t code = 0;
4,417,197✔
727

728
  if (NULL == pReq->colName || strlen(pReq->colName) == 0) {
4,417,197✔
729
    metaError("vgId:%d, %s failed at %s:%d since invalid column name:%s, version:%" PRId64, TD_VID(pMeta->pVnode),
×
730
              __func__, __FILE__, __LINE__, pReq->colName, version);
731
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
732
  }
733

734
  // check name
735
  void   *value = NULL;
4,417,197✔
736
  int32_t valueSize = 0;
4,417,197✔
737
  code = tdbTbGet(pMeta->pNameIdx, pReq->tbName, strlen(pReq->tbName) + 1, &value, &valueSize);
4,417,197✔
738
  if (code) {
4,417,197✔
739
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
740
              __FILE__, __LINE__, pReq->tbName, version);
741
    code = TSDB_CODE_TDB_TABLE_NOT_EXIST;
×
742
    TAOS_RETURN(code);
×
743
  }
744
  int64_t uid = *(int64_t *)value;
4,417,197✔
745
  tdbFreeClear(value);
4,417,197✔
746

747
  // check table type
748
  SMetaInfo info;
4,417,197✔
749
  if (metaGetInfo(pMeta, uid, &info, NULL) != 0) {
4,417,197✔
750
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64
×
751
              " not found, this is an internal error in meta, version:%" PRId64,
752
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, uid, version);
753
    code = TSDB_CODE_INTERNAL_ERROR;
×
754
    TAOS_RETURN(code);
×
755
  }
756
  if (info.suid != 0 && pReq->action != TSDB_ALTER_TABLE_ALTER_COLUMN_REF &&
4,417,197✔
757
      pReq->action != TSDB_ALTER_TABLE_REMOVE_COLUMN_REF) {
29,614✔
758
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64 " is not a normal table, version:%" PRId64,
×
759
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, uid, version);
760
    code = TSDB_CODE_VND_INVALID_TABLE_ACTION;
×
761
    TAOS_RETURN(code);
×
762
  }
763

764
  // check grant
765
  code = grantCheck(TSDB_GRANT_TIMESERIES);
4,417,197✔
766
  if (code) {
4,417,197✔
767
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
768
              __FILE__, __LINE__, tstrerror(code), version, pReq->tbName);
769
    TAOS_RETURN(code);
×
770
  }
771
  TAOS_RETURN(code);
4,417,197✔
772
}
773

774
int32_t metaAddTableColumn(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
3,628,725✔
775
  int32_t code = TSDB_CODE_SUCCESS;
3,628,725✔
776

777
  // check request
778
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
3,628,725✔
779
  if (code) {
3,628,725✔
780
    TAOS_RETURN(code);
×
781
  }
782

783
  // fetch old entry
784
  SMetaEntry *pEntry = NULL;
3,628,725✔
785
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
3,628,725✔
786
  if (code) {
3,628,725✔
787
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
788
              __FILE__, __LINE__, pReq->tbName, version);
789
    TAOS_RETURN(code);
×
790
  }
791
  if (pEntry->version >= version) {
3,628,725✔
792
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
793
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
794
    metaFetchEntryFree(&pEntry);
×
795
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
796
  }
797

798
  // do add column
799
  int32_t         rowSize = 0;
3,628,725✔
800
  SSchemaWrapper *pSchema = &pEntry->ntbEntry.schemaRow;
3,628,725✔
801
  SSchema        *pColumn;
802
  SExtSchema      extSchema = {0};
3,628,725✔
803
  pEntry->version = version;
3,628,725✔
804
  for (int32_t i = 0; i < pSchema->nCols; i++) {
2,147,483,647✔
805
    pColumn = &pSchema->pSchema[i];
2,147,483,647✔
806
    if (strncmp(pColumn->name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
2,147,483,647✔
807
      metaError("vgId:%d, %s failed at %s:%d since column %s already exists in table %s, version:%" PRId64,
328,656✔
808
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colName, pReq->tbName, version);
809
      metaFetchEntryFree(&pEntry);
328,656✔
810
      TAOS_RETURN(TSDB_CODE_VND_COL_ALREADY_EXISTS);
328,656✔
811
    }
812
    rowSize += pColumn->bytes;
2,147,483,647✔
813
  }
814

815
  if (rowSize + pReq->bytes > TSDB_MAX_BYTES_PER_ROW) {
3,300,069✔
816
    metaError("vgId:%d, %s failed at %s:%d since row size %d + %d > %d, version:%" PRId64, TD_VID(pMeta->pVnode),
6,680✔
817
              __func__, __FILE__, __LINE__, rowSize, pReq->bytes, TSDB_MAX_BYTES_PER_ROW, version);
818
    metaFetchEntryFree(&pEntry);
6,680✔
819
    TAOS_RETURN(TSDB_CODE_PAR_INVALID_ROW_LENGTH);
6,680✔
820
  }
821

822
  if (pSchema->nCols + 1 > TSDB_MAX_COLUMNS) {
3,293,389✔
823
    metaError("vgId:%d, %s failed at %s:%d since column count %d + 1 > %d, version:%" PRId64, TD_VID(pMeta->pVnode),
×
824
              __func__, __FILE__, __LINE__, pSchema->nCols, TSDB_MAX_COLUMNS, version);
825
    metaFetchEntryFree(&pEntry);
×
826
    TAOS_RETURN(TSDB_CODE_PAR_TOO_MANY_COLUMNS);
×
827
  }
828

829
  SSchema *pNewSchema = taosMemoryRealloc(pSchema->pSchema, sizeof(SSchema) * (pSchema->nCols + 1));
3,293,389✔
830
  if (NULL == pNewSchema) {
3,293,389✔
831
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
832
              __LINE__, tstrerror(terrno), version);
833
    metaFetchEntryFree(&pEntry);
×
834
    TAOS_RETURN(terrno);
×
835
  }
836
  pSchema->pSchema = pNewSchema;
3,293,389✔
837
  pSchema->version++;
3,293,389✔
838
  pSchema->nCols++;
3,293,389✔
839
  pColumn = &pSchema->pSchema[pSchema->nCols - 1];
3,293,389✔
840
  pColumn->bytes = pReq->bytes;
3,293,389✔
841
  pColumn->type = pReq->type;
3,293,389✔
842
  pColumn->flags = pReq->flags;
3,293,389✔
843
  pColumn->colId = pEntry->ntbEntry.ncid++;
3,293,389✔
844
  extSchema.typeMod = pReq->typeMod;
3,293,389✔
845
  tstrncpy(pColumn->name, pReq->colName, TSDB_COL_NAME_LEN);
3,293,389✔
846
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
3,293,389✔
847
    SColRef tmpRef;
53,774✔
848
    if (TSDB_ALTER_TABLE_ADD_COLUMN == pReq->action) {
53,774✔
849
      tmpRef.hasRef = false;
31,697✔
850
      tmpRef.id = pColumn->colId;
31,697✔
851
    } else {
852
      tmpRef.hasRef = true;
22,077✔
853
      tmpRef.id = pColumn->colId;
22,077✔
854
      tstrncpy(tmpRef.refDbName, pReq->refDbName, TSDB_DB_NAME_LEN);
22,077✔
855
      tstrncpy(tmpRef.refTableName, pReq->refTbName, TSDB_TABLE_NAME_LEN);
22,077✔
856
      tstrncpy(tmpRef.refColName, pReq->refColName, TSDB_COL_NAME_LEN);
22,077✔
857
    }
858
    code = updataTableColRef(&pEntry->colRef, pColumn, 1, &tmpRef);
53,774✔
859
    if (code) {
53,774✔
860
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
861
                __LINE__, tstrerror(code), version);
862
      metaFetchEntryFree(&pEntry);
×
863
      TAOS_RETURN(code);
×
864
    }
865
  } else {
866
    uint32_t compress;
867
    if (TSDB_ALTER_TABLE_ADD_COLUMN == pReq->action) {
3,239,615✔
868
      compress = createDefaultColCmprByType(pColumn->type);
3,232,393✔
869
    } else {
870
      compress = pReq->compress;
7,222✔
871
    }
872
    code = updataTableColCmpr(&pEntry->colCmpr, pColumn, 1, compress);
3,239,615✔
873
    if (code) {
3,239,615✔
874
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
875
                __LINE__, tstrerror(code), version);
876
      metaFetchEntryFree(&pEntry);
×
877
      TAOS_RETURN(code);
×
878
    }
879
  }
880
  code = addTableExtSchema(pEntry, pColumn, pSchema->nCols, &extSchema);
3,293,389✔
881
  if (code) {
3,293,389✔
882
    metaError("vgId:%d, %s failed to add ext schema at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode),
×
883
              __func__, __FILE__, __LINE__, tstrerror(code), version);
884
    metaFetchEntryFree(&pEntry);
×
885
    TAOS_RETURN(code);
×
886
  }
887

888
  // do handle entry
889
  code = metaHandleEntry2(pMeta, pEntry);
3,293,389✔
890
  if (code) {
3,293,389✔
891
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
892
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
893
    metaFetchEntryFree(&pEntry);
×
894
    TAOS_RETURN(code);
×
895
  } else {
896
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
3,293,389✔
897
             pEntry->uid, version);
898
  }
899

900
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
3,293,389✔
901
    if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
53,774✔
902
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
903
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
904
    } else {
905
      for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
410,634✔
906
        SColRef *p = &pEntry->colRef.pColRef[i];
356,860✔
907
        pRsp->pColRefs[i].hasRef = p->hasRef;
356,860✔
908
        pRsp->pColRefs[i].id = p->id;
356,860✔
909
        if (p->hasRef) {
356,860✔
910
          tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
175,344✔
911
          tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
175,344✔
912
          tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
175,344✔
913
        }
914
      }
915
    }
916
  } else {
917
    if (metaUpdateMetaRsp(pEntry->uid, pReq->tbName, pSchema, pRsp) < 0) {
3,239,615✔
918
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
919
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
920
    } else {
921
      for (int32_t i = 0; i < pEntry->colCmpr.nCols; i++) {
2,147,483,647✔
922
        SColCmpr *p = &pEntry->colCmpr.pColCmpr[i];
2,147,483,647✔
923
        pRsp->pSchemaExt[i].colId = p->id;
2,147,483,647✔
924
        pRsp->pSchemaExt[i].compress = p->alg;
2,147,483,647✔
925
      }
926
    }
927
  }
928

929
  metaFetchEntryFree(&pEntry);
3,293,389✔
930
  TAOS_RETURN(code);
3,293,389✔
931
}
932

933
int32_t metaDropTableColumn(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
96,605✔
934
  int32_t code = TSDB_CODE_SUCCESS;
96,605✔
935

936
  // check request
937
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
96,605✔
938
  if (code) {
96,605✔
939
    TAOS_RETURN(code);
×
940
  }
941

942
  // fetch old entry
943
  SMetaEntry *pEntry = NULL;
96,605✔
944
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
96,605✔
945
  if (code) {
96,605✔
946
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
947
              __FILE__, __LINE__, pReq->tbName, version);
948
    TAOS_RETURN(code);
×
949
  }
950

951
  if (pEntry->version >= version) {
96,605✔
952
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
953
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
954
    metaFetchEntryFree(&pEntry);
×
955
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
956
  }
957

958
  // search the column to drop
959
  SSchemaWrapper *pSchema = &pEntry->ntbEntry.schemaRow;
96,605✔
960
  SSchema        *pColumn = NULL;
96,605✔
961
  SSchema         tColumn;
96,605✔
962
  int32_t         iColumn = 0;
96,605✔
963
  for (; iColumn < pSchema->nCols; iColumn++) {
42,216,207✔
964
    pColumn = &pSchema->pSchema[iColumn];
42,216,207✔
965
    if (strncmp(pColumn->name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
42,216,207✔
966
      break;
96,605✔
967
    }
968
  }
969

970
  if (iColumn == pSchema->nCols) {
96,605✔
971
    metaError("vgId:%d, %s failed at %s:%d since column %s not found in table %s, version:%" PRId64,
×
972
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colName, pReq->tbName, version);
973
    metaFetchEntryFree(&pEntry);
×
974
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
975
  }
976

977
  if (pColumn->colId == 0 || pColumn->flags & COL_IS_KEY) {
96,605✔
978
    metaError("vgId:%d, %s failed at %s:%d since column %s is primary key, version:%" PRId64, TD_VID(pMeta->pVnode),
×
979
              __func__, __FILE__, __LINE__, pReq->colName, version);
980
    metaFetchEntryFree(&pEntry);
×
981
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
982
  }
983

984
  if (tqCheckColModifiable(pMeta->pVnode->pTq, pEntry->uid, pColumn->colId) != 0) {
96,605✔
985
    metaError("vgId:%d, %s failed at %s:%d since column %s is not modifiable, version:%" PRId64, TD_VID(pMeta->pVnode),
1,012✔
986
              __func__, __FILE__, __LINE__, pReq->colName, version);
987
    metaFetchEntryFree(&pEntry);
1,012✔
988
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
1,012✔
989
  }
990
  tColumn = *pColumn;
95,593✔
991

992
  // do drop column
993
  pEntry->version = version;
95,593✔
994
  if (pSchema->nCols - iColumn - 1 > 0) {
95,593✔
995
    memmove(pColumn, pColumn + 1, (pSchema->nCols - iColumn - 1) * sizeof(SSchema));
73,636✔
996
  }
997
  pSchema->nCols--;
95,593✔
998
  pSchema->version++;
95,593✔
999
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
95,593✔
1000
    code = updataTableColRef(&pEntry->colRef, &tColumn, 0, NULL);
30,160✔
1001
    if (code) {
30,160✔
1002
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1003
                __LINE__, tstrerror(code), version);
1004
      metaFetchEntryFree(&pEntry);
×
1005
      TAOS_RETURN(code);
×
1006
    }
1007
    if (pEntry->colRef.nCols != pSchema->nCols) {
30,160✔
1008
      metaError("vgId:%d, %s failed at %s:%d since column count mismatch, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1009
                __func__, __FILE__, __LINE__, version);
1010
      metaFetchEntryFree(&pEntry);
×
1011
      TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1012
    }
1013
  } else {
1014
    code = updataTableColCmpr(&pEntry->colCmpr, &tColumn, 0, 0);
65,433✔
1015
    if (code) {
65,433✔
1016
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1017
                __LINE__, tstrerror(code), version);
1018
      metaFetchEntryFree(&pEntry);
×
1019
      TAOS_RETURN(code);
×
1020
    }
1021
    if (pEntry->colCmpr.nCols != pSchema->nCols) {
65,433✔
1022
      metaError("vgId:%d, %s failed at %s:%d since column count mismatch, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1023
                __func__, __FILE__, __LINE__, version);
1024
      metaFetchEntryFree(&pEntry);
×
1025
      TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1026
    }
1027
  }
1028

1029
  // update column extschema
1030
  code = dropTableExtSchema(pEntry, iColumn, pSchema->nCols);
95,593✔
1031
  if (code) {
95,593✔
1032
    metaError("vgId:%d, %s failed to remove extschema at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1033
              __func__, __FILE__, __LINE__, tstrerror(code), version);
1034
    metaFetchEntryFree(&pEntry);
×
1035
    TAOS_RETURN(code);
×
1036
  }
1037

1038
  // do handle entry
1039
  code = metaHandleEntry2(pMeta, pEntry);
95,593✔
1040
  if (code) {
95,593✔
1041
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1042
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1043
    metaFetchEntryFree(&pEntry);
×
1044
  } else {
1045
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
95,593✔
1046
             pEntry->uid, version);
1047
  }
1048

1049
  // build response
1050
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
95,593✔
1051
    if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
30,160✔
1052
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1053
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1054
    } else {
1055
      for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
204,468✔
1056
        SColRef *p = &pEntry->colRef.pColRef[i];
174,308✔
1057
        pRsp->pColRefs[i].hasRef = p->hasRef;
174,308✔
1058
        pRsp->pColRefs[i].id = p->id;
174,308✔
1059
        if (p->hasRef) {
174,308✔
1060
          tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
97,671✔
1061
          tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
97,671✔
1062
          tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
97,671✔
1063
        }
1064
      }
1065
    }
1066
  } else {
1067
    if (metaUpdateMetaRsp(pEntry->uid, pReq->tbName, pSchema, pRsp) < 0) {
65,433✔
1068
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1069
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1070
    } else {
1071
      for (int32_t i = 0; i < pEntry->colCmpr.nCols; i++) {
87,565,032✔
1072
        SColCmpr *p = &pEntry->colCmpr.pColCmpr[i];
87,499,599✔
1073
        pRsp->pSchemaExt[i].colId = p->id;
87,499,599✔
1074
        pRsp->pSchemaExt[i].compress = p->alg;
87,499,599✔
1075
      }
1076
    }
1077
  }
1078

1079
  metaFetchEntryFree(&pEntry);
95,593✔
1080
  TAOS_RETURN(code);
95,593✔
1081
}
1082

1083
int32_t metaAlterTableColumnName(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
45,672✔
1084
  int32_t code = TSDB_CODE_SUCCESS;
45,672✔
1085

1086
  // check request
1087
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
45,672✔
1088
  if (code) {
45,672✔
1089
    TAOS_RETURN(code);
×
1090
  }
1091

1092
  if (NULL == pReq->colNewName) {
45,672✔
1093
    metaError("vgId:%d, %s failed at %s:%d since invalid new column name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1094
              __func__, __FILE__, __LINE__, version);
1095
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1096
  }
1097

1098
  // fetch old entry
1099
  SMetaEntry *pEntry = NULL;
45,672✔
1100
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
45,672✔
1101
  if (code) {
45,672✔
1102
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1103
              __FILE__, __LINE__, pReq->tbName, version);
1104
    TAOS_RETURN(code);
×
1105
  }
1106

1107
  if (pEntry->version >= version) {
45,672✔
1108
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
1109
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
1110
    metaFetchEntryFree(&pEntry);
×
1111
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
1112
  }
1113

1114
  // search the column to update
1115
  SSchemaWrapper *pSchema = &pEntry->ntbEntry.schemaRow;
45,672✔
1116
  SSchema        *pColumn = NULL;
45,672✔
1117
  int32_t         iColumn = 0;
45,672✔
1118
  for (int32_t i = 0; i < pSchema->nCols; i++) {
207,335✔
1119
    if (strncmp(pSchema->pSchema[i].name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
207,335✔
1120
      pColumn = &pSchema->pSchema[i];
45,672✔
1121
      iColumn = i;
45,672✔
1122
      break;
45,672✔
1123
    }
1124
  }
1125

1126
  if (NULL == pColumn) {
45,672✔
1127
    metaError("vgId:%d, %s failed at %s:%d since column id %d not found in table %s, version:%" PRId64,
×
1128
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colId, pReq->tbName, version);
1129
    metaFetchEntryFree(&pEntry);
×
1130
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1131
  }
1132

1133
  if (tqCheckColModifiable(pMeta->pVnode->pTq, pEntry->uid, pColumn->colId) != 0) {
45,672✔
1134
    metaError("vgId:%d, %s failed at %s:%d since column %s is not modifiable, version:%" PRId64, TD_VID(pMeta->pVnode),
1,012✔
1135
              __func__, __FILE__, __LINE__, pColumn->name, version);
1136
    metaFetchEntryFree(&pEntry);
1,012✔
1137
    TAOS_RETURN(TSDB_CODE_VND_COL_SUBSCRIBED);
1,012✔
1138
  }
1139

1140
  // do update column name
1141
  pEntry->version = version;
44,660✔
1142
  tstrncpy(pColumn->name, pReq->colNewName, TSDB_COL_NAME_LEN);
44,660✔
1143
  pSchema->version++;
44,660✔
1144

1145
  // do handle entry
1146
  code = metaHandleEntry2(pMeta, pEntry);
44,660✔
1147
  if (code) {
44,660✔
1148
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1149
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1150
    metaFetchEntryFree(&pEntry);
×
1151
    TAOS_RETURN(code);
×
1152
  } else {
1153
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
44,660✔
1154
             pEntry->uid, version);
1155
  }
1156

1157
  // build response
1158
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
44,660✔
1159
    if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
29,817✔
1160
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1161
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1162
    } else {
1163
      for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
208,626✔
1164
        SColRef *p = &pEntry->colRef.pColRef[i];
178,809✔
1165
        pRsp->pColRefs[i].hasRef = p->hasRef;
178,809✔
1166
        pRsp->pColRefs[i].id = p->id;
178,809✔
1167
        if (p->hasRef) {
178,809✔
1168
          tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
110,859✔
1169
          tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
110,859✔
1170
          tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
110,859✔
1171
        }
1172
      }
1173
    }
1174
  } else {
1175
    if (metaUpdateMetaRsp(pEntry->uid, pReq->tbName, pSchema, pRsp) < 0) {
14,843✔
1176
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1177
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1178
    } else {
1179
      for (int32_t i = 0; i < pEntry->colCmpr.nCols; i++) {
169,733✔
1180
        SColCmpr *p = &pEntry->colCmpr.pColCmpr[i];
154,890✔
1181
        pRsp->pSchemaExt[i].colId = p->id;
154,890✔
1182
        pRsp->pSchemaExt[i].compress = p->alg;
154,890✔
1183
      }
1184
    }
1185
  }
1186

1187
  metaFetchEntryFree(&pEntry);
44,660✔
1188
  TAOS_RETURN(code);
44,660✔
1189
}
1190

1191
int32_t metaAlterTableColumnBytes(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
506,737✔
1192
  int32_t code = TSDB_CODE_SUCCESS;
506,737✔
1193

1194
  // check request
1195
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
506,737✔
1196
  if (code) {
506,737✔
1197
    TAOS_RETURN(code);
×
1198
  }
1199

1200
  // fetch old entry
1201
  SMetaEntry *pEntry = NULL;
506,737✔
1202
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
506,737✔
1203
  if (code) {
506,737✔
1204
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1205
              __FILE__, __LINE__, pReq->tbName, version);
1206
    TAOS_RETURN(code);
×
1207
  }
1208

1209
  if (pEntry->version >= version) {
506,737✔
1210
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
1211
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
1212
    metaFetchEntryFree(&pEntry);
×
1213
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
1214
  }
1215

1216
  // search the column to update
1217
  SSchemaWrapper *pSchema = &pEntry->ntbEntry.schemaRow;
506,737✔
1218
  SSchema        *pColumn = NULL;
506,737✔
1219
  int32_t         iColumn = 0;
506,737✔
1220
  int32_t         rowSize = 0;
506,737✔
1221
  for (int32_t i = 0; i < pSchema->nCols; i++) {
20,101,918✔
1222
    if (strncmp(pSchema->pSchema[i].name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
19,595,181✔
1223
      pColumn = &pSchema->pSchema[i];
506,737✔
1224
      iColumn = i;
506,737✔
1225
    }
1226
    rowSize += pSchema->pSchema[i].bytes;
19,595,181✔
1227
  }
1228

1229
  if (NULL == pColumn) {
506,737✔
1230
    metaError("vgId:%d, %s failed at %s:%d since column %s not found in table %s, version:%" PRId64,
×
1231
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colName, pReq->tbName, version);
1232
    metaFetchEntryFree(&pEntry);
×
1233
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1234
  }
1235

1236
  if (!IS_VAR_DATA_TYPE(pColumn->type) || pColumn->bytes >= pReq->colModBytes) {
506,737✔
1237
    metaError("vgId:%d, %s failed at %s:%d since column %s is not var data type or bytes %d >= %d, version:%" PRId64,
205,744✔
1238
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colName, pColumn->bytes, pReq->colModBytes,
1239
              version);
1240
    metaFetchEntryFree(&pEntry);
205,744✔
1241
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
205,744✔
1242
  }
1243

1244
  if (tqCheckColModifiable(pMeta->pVnode->pTq, pEntry->uid, pColumn->colId) != 0) {
300,993✔
1245
    metaError("vgId:%d, %s failed at %s:%d since column %s is not modifiable, version:%" PRId64, TD_VID(pMeta->pVnode),
612✔
1246
              __func__, __FILE__, __LINE__, pReq->colName, version);
1247
    metaFetchEntryFree(&pEntry);
612✔
1248
    TAOS_RETURN(TSDB_CODE_VND_COL_SUBSCRIBED);
612✔
1249
  }
1250

1251
  if (rowSize + pReq->colModBytes - pColumn->bytes > TSDB_MAX_BYTES_PER_ROW) {
300,381✔
1252
    metaError("vgId:%d, %s failed at %s:%d since row size %d + %d - %d > %d, version:%" PRId64, TD_VID(pMeta->pVnode),
46,760✔
1253
              __func__, __FILE__, __LINE__, rowSize, pReq->colModBytes, pColumn->bytes, TSDB_MAX_BYTES_PER_ROW,
1254
              version);
1255
    metaFetchEntryFree(&pEntry);
46,760✔
1256
    TAOS_RETURN(TSDB_CODE_PAR_INVALID_ROW_LENGTH);
46,760✔
1257
  }
1258

1259
  // do change the column bytes
1260
  pEntry->version = version;
253,621✔
1261
  pSchema->version++;
253,621✔
1262
  pColumn->bytes = pReq->colModBytes;
253,621✔
1263

1264
  // do handle entry
1265
  code = metaHandleEntry2(pMeta, pEntry);
253,621✔
1266
  if (code) {
253,621✔
1267
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1268
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1269
    metaFetchEntryFree(&pEntry);
×
1270
    TAOS_RETURN(code);
×
1271
  } else {
1272
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
253,621✔
1273
             pEntry->uid, version);
1274
  }
1275

1276
  // build response
1277
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
253,621✔
1278
    if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
27,429✔
1279
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1280
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1281
    } else {
1282
      for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
196,686✔
1283
        SColRef *p = &pEntry->colRef.pColRef[i];
169,257✔
1284
        pRsp->pColRefs[i].hasRef = p->hasRef;
169,257✔
1285
        pRsp->pColRefs[i].id = p->id;
169,257✔
1286
        if (p->hasRef) {
169,257✔
1287
          tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
81,618✔
1288
          tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
81,618✔
1289
          tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
81,618✔
1290
        }
1291
      }
1292
    }
1293
  } else {
1294
    if (metaUpdateMetaRsp(pEntry->uid, pReq->tbName, pSchema, pRsp) < 0) {
226,192✔
1295
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1296
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1297
    } else {
1298
      for (int32_t i = 0; i < pEntry->colCmpr.nCols; i++) {
9,296,020✔
1299
        SColCmpr *p = &pEntry->colCmpr.pColCmpr[i];
9,069,828✔
1300
        pRsp->pSchemaExt[i].colId = p->id;
9,069,828✔
1301
        pRsp->pSchemaExt[i].compress = p->alg;
9,069,828✔
1302
      }
1303
    }
1304
  }
1305

1306
  metaFetchEntryFree(&pEntry);
253,621✔
1307
  TAOS_RETURN(code);
253,621✔
1308
}
1309

1310
static int32_t metaCheckUpdateTableTagValReq(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
7,880,190✔
1311
  int32_t code = 0;
7,880,190✔
1312

1313
  // check tag name
1314
  if (NULL == pReq->tagName || strlen(pReq->tagName) == 0) {
7,880,190✔
1315
    metaError("vgId:%d, %s failed at %s:%d since invalid tag name:%s, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1316
              __func__, __FILE__, __LINE__, pReq->tagName, version);
1317
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1318
  }
1319

1320
  // check name
1321
  void   *value = NULL;
7,880,190✔
1322
  int32_t valueSize = 0;
7,880,190✔
1323
  code = tdbTbGet(pMeta->pNameIdx, pReq->tbName, strlen(pReq->tbName) + 1, &value, &valueSize);
7,880,190✔
1324
  if (code) {
7,880,190✔
1325
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
12✔
1326
              __FILE__, __LINE__, pReq->tbName, version);
1327
    code = TSDB_CODE_TDB_TABLE_NOT_EXIST;
12✔
1328
    TAOS_RETURN(code);
12✔
1329
  }
1330
  tdbFreeClear(value);
7,880,178✔
1331

1332
  TAOS_RETURN(code);
7,880,178✔
1333
}
1334

1335
int32_t metaUpdateTableTagValue(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
7,880,190✔
1336
  int32_t code = TSDB_CODE_SUCCESS;
7,880,190✔
1337

1338
  // check request
1339
  code = metaCheckUpdateTableTagValReq(pMeta, version, pReq);
7,880,190✔
1340
  if (code) {
7,880,190✔
1341
    TAOS_RETURN(code);
12✔
1342
  }
1343

1344
  // fetch child entry
1345
  SMetaEntry *pChild = NULL;
7,880,178✔
1346
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pChild);
7,880,178✔
1347
  if (code) {
7,880,178✔
1348
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1349
              __FILE__, __LINE__, pReq->tbName, version);
1350
    TAOS_RETURN(code);
×
1351
  }
1352

1353
  if (pChild->type != TSDB_CHILD_TABLE && pChild->type != TSDB_VIRTUAL_CHILD_TABLE) {
7,880,178✔
1354
    metaError("vgId:%d, %s failed at %s:%d since table %s is not a child table, version:%" PRId64,
×
1355
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, version);
1356
    metaFetchEntryFree(&pChild);
×
1357
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1358
  }
1359

1360
  // fetch super entry
1361
  SMetaEntry *pSuper = NULL;
7,880,178✔
1362
  code = metaFetchEntryByUid(pMeta, pChild->ctbEntry.suid, &pSuper);
7,880,178✔
1363
  if (code) {
7,880,178✔
1364
    metaError("vgId:%d, %s failed at %s:%d since super table uid %" PRId64 " not found, version:%" PRId64,
×
1365
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pChild->ctbEntry.suid, version);
1366
    metaFetchEntryFree(&pChild);
×
1367
    TAOS_RETURN(TSDB_CODE_INTERNAL_ERROR);
×
1368
  }
1369

1370
  // search the tag to update
1371
  SSchemaWrapper *pTagSchema = &pSuper->stbEntry.schemaTag;
7,880,178✔
1372
  SSchema        *pColumn = NULL;
7,880,178✔
1373
  int32_t         iColumn = 0;
7,880,178✔
1374
  for (int32_t i = 0; i < pTagSchema->nCols; i++) {
8,580,997✔
1375
    if (strncmp(pTagSchema->pSchema[i].name, pReq->tagName, TSDB_COL_NAME_LEN) == 0) {
8,580,997✔
1376
      pColumn = &pTagSchema->pSchema[i];
7,880,178✔
1377
      iColumn = i;
7,880,178✔
1378
      break;
7,880,178✔
1379
    }
1380
  }
1381

1382
  if (NULL == pColumn) {
7,880,178✔
1383
    metaError("vgId:%d, %s failed at %s:%d since tag %s not found in table %s, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1384
              __func__, __FILE__, __LINE__, pReq->tagName, pReq->tbName, version);
1385
    metaFetchEntryFree(&pChild);
×
1386
    metaFetchEntryFree(&pSuper);
×
1387
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1388
  }
1389

1390
  // do change tag value
1391
  pChild->version = version;
7,880,178✔
1392
  if (pTagSchema->nCols == 1 && pTagSchema->pSchema[0].type == TSDB_DATA_TYPE_JSON) {
7,880,178✔
1393
    void *pNewTag = taosMemoryRealloc(pChild->ctbEntry.pTags, pReq->nTagVal);
126,631✔
1394
    if (NULL == pNewTag) {
126,631✔
1395
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1396
                __LINE__, tstrerror(terrno), version);
1397
      metaFetchEntryFree(&pChild);
×
1398
      metaFetchEntryFree(&pSuper);
×
1399
      TAOS_RETURN(terrno);
×
1400
    }
1401
    pChild->ctbEntry.pTags = pNewTag;
126,631✔
1402
    memcpy(pChild->ctbEntry.pTags, pReq->pTagVal, pReq->nTagVal);
126,631✔
1403
  } else {
1404
    STag *pOldTag = (STag *)pChild->ctbEntry.pTags;
7,753,547✔
1405

1406
    SArray *pTagArray = taosArrayInit(pTagSchema->nCols, sizeof(STagVal));
7,753,547✔
1407
    if (NULL == pTagArray) {
7,753,547✔
1408
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1409
                __LINE__, tstrerror(terrno), version);
1410
      metaFetchEntryFree(&pChild);
×
1411
      metaFetchEntryFree(&pSuper);
×
1412
      TAOS_RETURN(terrno);
×
1413
    }
1414

1415
    for (int32_t i = 0; i < pTagSchema->nCols; i++) {
16,641,900✔
1416
      STagVal value = {
8,888,353✔
1417
          .type = pTagSchema->pSchema[i].type,
8,888,353✔
1418
          .cid = pTagSchema->pSchema[i].colId,
8,888,353✔
1419
      };
1420

1421
      if (iColumn == i) {
8,888,353✔
1422
        if (pReq->isNull) {
7,753,547✔
1423
          continue;
45,138✔
1424
        }
1425
        if (IS_VAR_DATA_TYPE(value.type)) {
7,708,409✔
1426
          value.pData = pReq->pTagVal;
144,142✔
1427
          value.nData = pReq->nTagVal;
144,142✔
1428
        } else {
1429
          memcpy(&value.i64, pReq->pTagVal, pReq->nTagVal);
7,564,267✔
1430
        }
1431
      } else if (!tTagGet(pOldTag, &value)) {
1,134,806✔
1432
        continue;
298,845✔
1433
      }
1434

1435
      if (NULL == taosArrayPush(pTagArray, &value)) {
8,544,370✔
1436
        metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1437
                  __LINE__, tstrerror(terrno), version);
1438
        taosArrayDestroy(pTagArray);
×
1439
        metaFetchEntryFree(&pChild);
×
1440
        metaFetchEntryFree(&pSuper);
×
1441
        TAOS_RETURN(terrno);
×
1442
      }
1443
    }
1444

1445
    STag *pNewTag = NULL;
7,753,547✔
1446
    code = tTagNew(pTagArray, pTagSchema->version, false, &pNewTag);
7,753,547✔
1447
    if (code) {
7,753,547✔
1448
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1449
                __LINE__, tstrerror(code), version);
1450
      taosArrayDestroy(pTagArray);
×
1451
      metaFetchEntryFree(&pChild);
×
1452
      metaFetchEntryFree(&pSuper);
×
1453
      TAOS_RETURN(code);
×
1454
    }
1455
    taosArrayDestroy(pTagArray);
7,753,547✔
1456
    taosMemoryFree(pChild->ctbEntry.pTags);
7,753,547✔
1457
    pChild->ctbEntry.pTags = (uint8_t *)pNewTag;
7,753,547✔
1458
  }
1459

1460
  // do handle entry
1461
  code = metaHandleEntry2(pMeta, pChild);
7,880,178✔
1462
  if (code) {
7,880,178✔
1463
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1464
              __func__, __FILE__, __LINE__, tstrerror(code), pChild->uid, pReq->tbName, version);
1465
    metaFetchEntryFree(&pChild);
×
1466
    metaFetchEntryFree(&pSuper);
×
1467
    TAOS_RETURN(code);
×
1468
  } else {
1469
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
7,880,178✔
1470
             pChild->uid, version);
1471
  }
1472

1473
  // free resource and return
1474
  metaFetchEntryFree(&pChild);
7,880,178✔
1475
  metaFetchEntryFree(&pSuper);
7,880,178✔
1476
  TAOS_RETURN(code);
7,880,178✔
1477
}
1478

1479
static int32_t metaCheckUpdateTableMultiTagValueReq(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
3,415✔
1480
  int32_t code = 0;
3,415✔
1481

1482
  // check tag name
1483
  if (NULL == pReq->pMultiTag || taosArrayGetSize(pReq->pMultiTag) == 0) {
3,415✔
1484
    metaError("vgId:%d, %s failed at %s:%d since invalid tag name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1485
              __FILE__, __LINE__, version);
1486
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1487
  }
1488

1489
  // check name
1490
  void   *value = NULL;
3,415✔
1491
  int32_t valueSize = 0;
3,415✔
1492
  code = tdbTbGet(pMeta->pNameIdx, pReq->tbName, strlen(pReq->tbName) + 1, &value, &valueSize);
3,415✔
1493
  if (code) {
3,415✔
1494
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1495
              __FILE__, __LINE__, pReq->tbName, version);
1496
    code = TSDB_CODE_TDB_TABLE_NOT_EXIST;
×
1497
    TAOS_RETURN(code);
×
1498
  }
1499
  tdbFreeClear(value);
3,415✔
1500

1501
  if (taosArrayGetSize(pReq->pMultiTag) == 0) {
3,415✔
1502
    metaError("vgId:%d, %s failed at %s:%d since invalid tag name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1503
              __FILE__, __LINE__, version);
1504
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1505
  }
1506

1507
  TAOS_RETURN(code);
3,415✔
1508
}
1509

1510
int32_t metaUpdateTableMultiTagValue(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
3,415✔
1511
  int32_t code = TSDB_CODE_SUCCESS;
3,415✔
1512

1513
  code = metaCheckUpdateTableMultiTagValueReq(pMeta, version, pReq);
3,415✔
1514
  if (code) {
3,415✔
1515
    TAOS_RETURN(code);
×
1516
  }
1517

1518
  // fetch child entry
1519
  SMetaEntry *pChild = NULL;
3,415✔
1520
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pChild);
3,415✔
1521
  if (code) {
3,415✔
1522
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1523
              __FILE__, __LINE__, pReq->tbName, version);
1524
    TAOS_RETURN(code);
×
1525
  }
1526

1527
  if (pChild->type != TSDB_CHILD_TABLE) {
3,415✔
1528
    metaError("vgId:%d, %s failed at %s:%d since table %s is not a child table, version:%" PRId64,
×
1529
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, version);
1530
    metaFetchEntryFree(&pChild);
×
1531
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1532
  }
1533

1534
  // fetch super entry
1535
  SMetaEntry *pSuper = NULL;
3,415✔
1536
  code = metaFetchEntryByUid(pMeta, pChild->ctbEntry.suid, &pSuper);
3,415✔
1537
  if (code) {
3,415✔
1538
    metaError("vgId:%d, %s failed at %s:%d since super table uid %" PRId64 " not found, version:%" PRId64,
×
1539
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pChild->ctbEntry.suid, version);
1540
    metaFetchEntryFree(&pChild);
×
1541
    TAOS_RETURN(TSDB_CODE_INTERNAL_ERROR);
×
1542
  }
1543

1544
  // search the tags to update
1545
  SSchemaWrapper *pTagSchema = &pSuper->stbEntry.schemaTag;
3,415✔
1546

1547
  if (pTagSchema->nCols == 1 && pTagSchema->pSchema[0].type == TSDB_DATA_TYPE_JSON) {
3,415✔
1548
    metaError("vgId:%d, %s failed at %s:%d since table %s has no tag, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1549
              __func__, __FILE__, __LINE__, pReq->tbName, version);
1550
    metaFetchEntryFree(&pChild);
×
1551
    metaFetchEntryFree(&pSuper);
×
1552
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1553
  }
1554

1555
  // do check if tag name exists
1556
  SHashObj *pTagTable =
1557
      taosHashInit(pTagSchema->nCols, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY), true, HASH_NO_LOCK);
3,415✔
1558
  if (pTagTable == NULL) {
3,415✔
1559
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1560
              __LINE__, tstrerror(terrno), version);
1561
    metaFetchEntryFree(&pChild);
×
1562
    metaFetchEntryFree(&pSuper);
×
1563
    TAOS_RETURN(terrno);
×
1564
  }
1565

1566
  for (int32_t i = 0; i < taosArrayGetSize(pReq->pMultiTag); i++) {
23,905✔
1567
    SMultiTagUpateVal *pTagVal = taosArrayGet(pReq->pMultiTag, i);
20,490✔
1568
    if (taosHashPut(pTagTable, pTagVal->tagName, strlen(pTagVal->tagName), pTagVal, sizeof(*pTagVal)) != 0) {
20,490✔
1569
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1570
                __LINE__, tstrerror(terrno), version);
1571
      taosHashCleanup(pTagTable);
×
1572
      metaFetchEntryFree(&pChild);
×
1573
      metaFetchEntryFree(&pSuper);
×
1574
      TAOS_RETURN(terrno);
×
1575
    }
1576
  }
1577

1578
  int32_t numOfChangedTags = 0;
3,415✔
1579
  for (int32_t i = 0; i < pTagSchema->nCols; i++) {
27,320✔
1580
    taosHashGet(pTagTable, pTagSchema->pSchema[i].name, strlen(pTagSchema->pSchema[i].name)) != NULL
23,905✔
1581
        ? numOfChangedTags++
20,490✔
1582
        : 0;
23,905✔
1583
  }
1584
  if (numOfChangedTags < taosHashGetSize(pTagTable)) {
3,415✔
1585
    metaError("vgId:%d, %s failed at %s:%d since tag count mismatch, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1586
              __FILE__, __LINE__, version);
1587
    taosHashCleanup(pTagTable);
×
1588
    metaFetchEntryFree(&pChild);
×
1589
    metaFetchEntryFree(&pSuper);
×
1590
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1591
  }
1592

1593
  // do change tag value
1594
  pChild->version = version;
3,415✔
1595
  const STag *pOldTag = (const STag *)pChild->ctbEntry.pTags;
3,415✔
1596
  SArray     *pTagArray = taosArrayInit(pTagSchema->nCols, sizeof(STagVal));
3,415✔
1597
  if (NULL == pTagArray) {
3,415✔
1598
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1599
              __LINE__, tstrerror(terrno), version);
1600
    taosHashCleanup(pTagTable);
×
1601
    metaFetchEntryFree(&pChild);
×
1602
    metaFetchEntryFree(&pSuper);
×
1603
    TAOS_RETURN(terrno);
×
1604
  }
1605

1606
  for (int32_t i = 0; i < pTagSchema->nCols; i++) {
27,320✔
1607
    SSchema *pCol = &pTagSchema->pSchema[i];
23,905✔
1608
    STagVal  value = {
23,905✔
1609
         .cid = pCol->colId,
23,905✔
1610
    };
1611

1612
    SMultiTagUpateVal *pTagVal = taosHashGet(pTagTable, pCol->name, strlen(pCol->name));
23,905✔
1613
    if (pTagVal == NULL) {
23,905✔
1614
      if (!tTagGet(pOldTag, &value)) {
3,415✔
1615
        continue;
×
1616
      }
1617
    } else {
1618
      value.type = pCol->type;
20,490✔
1619
      if (pTagVal->isNull) {
20,490✔
1620
        continue;
4,098✔
1621
      }
1622

1623
      if (IS_VAR_DATA_TYPE(pCol->type)) {
16,392✔
1624
        value.pData = pTagVal->pTagVal;
2,732✔
1625
        value.nData = pTagVal->nTagVal;
2,732✔
1626
      } else {
1627
        memcpy(&value.i64, pTagVal->pTagVal, pTagVal->nTagVal);
13,660✔
1628
      }
1629
    }
1630

1631
    if (taosArrayPush(pTagArray, &value) == NULL) {
19,807✔
1632
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1633
                __LINE__, tstrerror(terrno), version);
1634
      taosHashCleanup(pTagTable);
×
1635
      taosArrayDestroy(pTagArray);
×
1636
      metaFetchEntryFree(&pChild);
×
1637
      metaFetchEntryFree(&pSuper);
×
1638
      TAOS_RETURN(terrno);
×
1639
    }
1640
  }
1641

1642
  STag *pNewTag = NULL;
3,415✔
1643
  code = tTagNew(pTagArray, pTagSchema->version, false, &pNewTag);
3,415✔
1644
  if (code) {
3,415✔
1645
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1646
              __LINE__, tstrerror(code), version);
1647
    taosHashCleanup(pTagTable);
×
1648
    taosArrayDestroy(pTagArray);
×
1649
    metaFetchEntryFree(&pChild);
×
1650
    metaFetchEntryFree(&pSuper);
×
1651
    TAOS_RETURN(code);
×
1652
  }
1653
  taosArrayDestroy(pTagArray);
3,415✔
1654
  taosMemoryFree(pChild->ctbEntry.pTags);
3,415✔
1655
  pChild->ctbEntry.pTags = (uint8_t *)pNewTag;
3,415✔
1656

1657
  // do handle entry
1658
  code = metaHandleEntry2(pMeta, pChild);
3,415✔
1659
  if (code) {
3,415✔
1660
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1661
              __func__, __FILE__, __LINE__, tstrerror(code), pChild->uid, pReq->tbName, version);
1662
    taosHashCleanup(pTagTable);
×
1663
    metaFetchEntryFree(&pChild);
×
1664
    metaFetchEntryFree(&pSuper);
×
1665
    TAOS_RETURN(code);
×
1666
  } else {
1667
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
3,415✔
1668
             pChild->uid, version);
1669
  }
1670

1671
  taosHashCleanup(pTagTable);
3,415✔
1672
  metaFetchEntryFree(&pChild);
3,415✔
1673
  metaFetchEntryFree(&pSuper);
3,415✔
1674
  TAOS_RETURN(code);
3,415✔
1675
}
1676

1677
static int32_t metaCheckUpdateTableOptionsReq(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
17,344✔
1678
  int32_t code = TSDB_CODE_SUCCESS;
17,344✔
1679

1680
  if (pReq->tbName == NULL || strlen(pReq->tbName) == 0) {
17,344✔
1681
    metaError("vgId:%d, %s failed at %s:%d since invalid table name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1682
              __FILE__, __LINE__, version);
1683
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1684
  }
1685

1686
  return code;
17,344✔
1687
}
1688

1689
int32_t metaUpdateTableOptions2(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
17,344✔
1690
  int32_t code = 0;
17,344✔
1691

1692
  code = metaCheckUpdateTableOptionsReq(pMeta, version, pReq);
17,344✔
1693
  if (code) {
17,344✔
1694
    TAOS_RETURN(code);
×
1695
  }
1696

1697
  // fetch entry
1698
  SMetaEntry *pEntry = NULL;
17,344✔
1699
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
17,344✔
1700
  if (code) {
17,344✔
1701
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1702
              __FILE__, __LINE__, pReq->tbName, version);
1703
    TAOS_RETURN(code);
×
1704
  }
1705

1706
  // do change the entry
1707
  pEntry->version = version;
17,344✔
1708
  if (pEntry->type == TSDB_CHILD_TABLE) {
17,344✔
1709
    if (pReq->updateTTL) {
8,500✔
1710
      pEntry->ctbEntry.ttlDays = pReq->newTTL;
3,666✔
1711
    }
1712
    if (pReq->newCommentLen >= 0) {
8,500✔
1713
      char *pNewComment = NULL;
4,834✔
1714
      if (pReq->newCommentLen) {
4,834✔
1715
        pNewComment = taosMemoryRealloc(pEntry->ctbEntry.comment, pReq->newCommentLen + 1);
2,654✔
1716
        if (NULL == pNewComment) {
2,654✔
1717
          metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1718
                    __LINE__, tstrerror(terrno), version);
1719
          metaFetchEntryFree(&pEntry);
×
1720
          TAOS_RETURN(terrno);
×
1721
        }
1722
        memcpy(pNewComment, pReq->newComment, pReq->newCommentLen + 1);
2,654✔
1723
      } else {
1724
        taosMemoryFreeClear(pEntry->ctbEntry.comment);
2,180✔
1725
      }
1726
      pEntry->ctbEntry.comment = pNewComment;
4,834✔
1727
      pEntry->ctbEntry.commentLen = pReq->newCommentLen;
4,834✔
1728
    }
1729
  } else if (pEntry->type == TSDB_NORMAL_TABLE) {
8,844✔
1730
    if (pReq->updateTTL) {
8,844✔
1731
      pEntry->ntbEntry.ttlDays = pReq->newTTL;
4,206✔
1732
    }
1733
    if (pReq->newCommentLen >= 0) {
8,844✔
1734
      char *pNewComment = NULL;
4,638✔
1735
      if (pReq->newCommentLen > 0) {
4,638✔
1736
        pNewComment = taosMemoryRealloc(pEntry->ntbEntry.comment, pReq->newCommentLen + 1);
2,458✔
1737
        if (NULL == pNewComment) {
2,458✔
1738
          metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1739
                    __LINE__, tstrerror(terrno), version);
1740
          metaFetchEntryFree(&pEntry);
×
1741
          TAOS_RETURN(terrno);
×
1742
        }
1743
        memcpy(pNewComment, pReq->newComment, pReq->newCommentLen + 1);
2,458✔
1744
      } else {
1745
        taosMemoryFreeClear(pEntry->ntbEntry.comment);
2,180✔
1746
      }
1747
      pEntry->ntbEntry.comment = pNewComment;
4,638✔
1748
      pEntry->ntbEntry.commentLen = pReq->newCommentLen;
4,638✔
1749
    }
1750
  } else {
1751
    metaError("vgId:%d, %s failed at %s:%d since table %s type %d is invalid, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1752
              __func__, __FILE__, __LINE__, pReq->tbName, pEntry->type, version);
1753
    metaFetchEntryFree(&pEntry);
×
1754
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1755
  }
1756

1757
  // do handle entry
1758
  code = metaHandleEntry2(pMeta, pEntry);
17,344✔
1759
  if (code) {
17,344✔
1760
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1761
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1762
    metaFetchEntryFree(&pEntry);
×
1763
    TAOS_RETURN(code);
×
1764
  } else {
1765
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
17,344✔
1766
             pEntry->uid, version);
1767
  }
1768

1769
  metaFetchEntryFree(&pEntry);
17,344✔
1770
  TAOS_RETURN(code);
17,344✔
1771
}
1772

1773
int32_t metaUpdateTableColCompress2(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
6,550✔
1774
  int32_t code = TSDB_CODE_SUCCESS;
6,550✔
1775

1776
  if (NULL == pReq->tbName || strlen(pReq->tbName) == 0) {
6,550✔
1777
    metaError("vgId:%d, %s failed at %s:%d since invalid table name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1778
              __FILE__, __LINE__, version);
1779
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1780
  }
1781

1782
  SMetaEntry *pEntry = NULL;
6,550✔
1783
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
6,550✔
1784
  if (code) {
6,550✔
1785
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1786
              __FILE__, __LINE__, pReq->tbName, version);
1787
    TAOS_RETURN(code);
×
1788
  }
1789

1790
  if (pEntry->version >= version) {
6,550✔
1791
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
1792
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
1793
    metaFetchEntryFree(&pEntry);
×
1794
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
1795
  }
1796

1797
  if (pEntry->type != TSDB_NORMAL_TABLE && pEntry->type != TSDB_SUPER_TABLE) {
6,550✔
1798
    metaError("vgId:%d, %s failed at %s:%d since table %s type %d is invalid, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1799
              __func__, __FILE__, __LINE__, pReq->tbName, pEntry->type, version);
1800
    metaFetchEntryFree(&pEntry);
×
1801
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1802
  }
1803

1804
  // do change the entry
1805
  int8_t           updated = 0;
6,550✔
1806
  SColCmprWrapper *wp = &pEntry->colCmpr;
6,550✔
1807
  for (int32_t i = 0; i < wp->nCols; i++) {
52,400✔
1808
    SColCmpr *p = &wp->pColCmpr[i];
45,850✔
1809
    if (p->id == pReq->colId) {
45,850✔
1810
      uint32_t dst = 0;
6,550✔
1811
      updated = tUpdateCompress(p->alg, pReq->compress, TSDB_COLVAL_COMPRESS_DISABLED, TSDB_COLVAL_LEVEL_DISABLED,
6,550✔
1812
                                TSDB_COLVAL_LEVEL_MEDIUM, &dst);
1813
      if (updated > 0) {
6,550✔
1814
        p->alg = dst;
6,550✔
1815
      }
1816
    }
1817
  }
1818

1819
  if (updated == 0) {
6,550✔
1820
    code = TSDB_CODE_VND_COLUMN_COMPRESS_ALREADY_EXIST;
×
1821
    metaError("vgId:%d, %s failed at %s:%d since column %d compress level is not changed, version:%" PRId64,
×
1822
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colId, version);
1823
    metaFetchEntryFree(&pEntry);
×
1824
    TAOS_RETURN(code);
×
1825
  } else if (updated < 0) {
6,550✔
1826
    code = TSDB_CODE_TSC_COMPRESS_LEVEL_ERROR;
×
1827
    metaError("vgId:%d, %s failed at %s:%d since column %d compress level is invalid, version:%" PRId64,
×
1828
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colId, version);
1829
    metaFetchEntryFree(&pEntry);
×
1830
    TAOS_RETURN(code);
×
1831
  }
1832

1833
  pEntry->version = version;
6,550✔
1834

1835
  // do handle entry
1836
  code = metaHandleEntry2(pMeta, pEntry);
6,550✔
1837
  if (code) {
6,550✔
1838
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1839
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1840
    metaFetchEntryFree(&pEntry);
×
1841
    TAOS_RETURN(code);
×
1842
  } else {
1843
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
6,550✔
1844
             pEntry->uid, version);
1845
  }
1846

1847
  metaFetchEntryFree(&pEntry);
6,550✔
1848
  TAOS_RETURN(code);
6,550✔
1849
}
1850

1851
int32_t metaAlterTableColumnRef(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
80,968✔
1852
  int32_t code = TSDB_CODE_SUCCESS;
80,968✔
1853

1854
  // check request
1855
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
80,968✔
1856
  if (code) {
80,968✔
1857
    TAOS_RETURN(code);
×
1858
  }
1859

1860
  if (NULL == pReq->refDbName) {
80,968✔
1861
    metaError("vgId:%d, %s failed at %s:%d since invalid ref db name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1862
              __func__, __FILE__, __LINE__, version);
1863
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1864
  }
1865

1866
  if (NULL == pReq->refTbName) {
80,968✔
1867
    metaError("vgId:%d, %s failed at %s:%d since invalid ref table name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1868
              __func__, __FILE__, __LINE__, version);
1869
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1870
  }
1871

1872
  if (NULL == pReq->refColName) {
80,968✔
1873
    metaError("vgId:%d, %s failed at %s:%d since invalid ref Col name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1874
              __func__, __FILE__, __LINE__, version);
1875
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1876
  }
1877

1878
  // fetch old entry
1879
  SMetaEntry *pEntry = NULL;
80,968✔
1880
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
80,968✔
1881
  if (code) {
80,968✔
1882
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1883
              __FILE__, __LINE__, pReq->tbName, version);
1884
    TAOS_RETURN(code);
×
1885
  }
1886

1887
  if (pEntry->version >= version) {
80,968✔
1888
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
1889
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
1890
    metaFetchEntryFree(&pEntry);
×
1891
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
1892
  }
1893

1894
  // fetch super entry
1895
  SMetaEntry *pSuper = NULL;
80,968✔
1896
  if (pEntry->type == TSDB_VIRTUAL_CHILD_TABLE) {
80,968✔
1897
    code = metaFetchEntryByUid(pMeta, pEntry->ctbEntry.suid, &pSuper);
29,805✔
1898
    if (code) {
29,805✔
1899
      metaError("vgId:%d, %s failed at %s:%d since super table uid %" PRId64 " not found, version:%" PRId64,
×
1900
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pEntry->ctbEntry.suid, version);
1901
      metaFetchEntryFree(&pEntry);
×
1902
      TAOS_RETURN(TSDB_CODE_INTERNAL_ERROR);
×
1903
    }
1904
  }
1905

1906
  // search the column to update
1907
  SSchemaWrapper *pSchema =
80,968✔
1908
      pEntry->type == TSDB_VIRTUAL_CHILD_TABLE ? &pSuper->stbEntry.schemaRow : &pEntry->ntbEntry.schemaRow;
80,968✔
1909
  SColRef *pColRef = NULL;
80,968✔
1910
  int32_t  iColumn = 0;
80,968✔
1911
  for (int32_t i = 0; i < pSchema->nCols; i++) {
397,596✔
1912
    if (strncmp(pSchema->pSchema[i].name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
397,596✔
1913
      pColRef = &pEntry->colRef.pColRef[i];
80,968✔
1914
      iColumn = i;
80,968✔
1915
      break;
80,968✔
1916
    }
1917
  }
1918

1919
  if (NULL == pColRef) {
80,968✔
1920
    metaError("vgId:%d, %s failed at %s:%d since column id %d not found in table %s, version:%" PRId64,
×
1921
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colId, pReq->tbName, version);
1922
    metaFetchEntryFree(&pEntry);
×
1923
    metaFetchEntryFree(&pSuper);
×
1924
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1925
  }
1926

1927
  // do update column name
1928
  pEntry->version = version;
80,968✔
1929
  pColRef->hasRef = true;
80,968✔
1930
  pColRef->id = pSchema->pSchema[iColumn].colId;
80,968✔
1931
  tstrncpy(pColRef->refDbName, pReq->refDbName, TSDB_DB_NAME_LEN);
80,968✔
1932
  tstrncpy(pColRef->refTableName, pReq->refTbName, TSDB_TABLE_NAME_LEN);
80,968✔
1933
  tstrncpy(pColRef->refColName, pReq->refColName, TSDB_COL_NAME_LEN);
80,968✔
1934
  pSchema->version++;
80,968✔
1935
  pEntry->colRef.version++;
80,968✔
1936

1937
  // do handle entry
1938
  code = metaHandleEntry2(pMeta, pEntry);
80,968✔
1939
  if (code) {
80,968✔
1940
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1941
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1942
    metaFetchEntryFree(&pEntry);
×
1943
    metaFetchEntryFree(&pSuper);
×
1944
    TAOS_RETURN(code);
×
1945
  } else {
1946
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
80,968✔
1947
             pEntry->uid, version);
1948
  }
1949

1950
  // build response
1951
  if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
80,968✔
1952
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1953
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1954
  } else {
1955
    for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
597,700✔
1956
      SColRef *p = &pEntry->colRef.pColRef[i];
516,732✔
1957
      pRsp->pColRefs[i].hasRef = p->hasRef;
516,732✔
1958
      pRsp->pColRefs[i].id = p->id;
516,732✔
1959
      if (p->hasRef) {
516,732✔
1960
        tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
356,009✔
1961
        tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
356,009✔
1962
        tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
356,009✔
1963
      }
1964
    }
1965
  }
1966

1967
  metaFetchEntryFree(&pEntry);
80,968✔
1968
  metaFetchEntryFree(&pSuper);
80,968✔
1969
  TAOS_RETURN(code);
80,968✔
1970
}
1971

1972
int32_t metaRemoveTableColumnRef(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
58,490✔
1973
  int32_t code = TSDB_CODE_SUCCESS;
58,490✔
1974

1975
  // check request
1976
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
58,490✔
1977
  if (code) {
58,490✔
1978
    TAOS_RETURN(code);
×
1979
  }
1980

1981
  // fetch old entry
1982
  SMetaEntry *pEntry = NULL;
58,490✔
1983
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
58,490✔
1984
  if (code) {
58,490✔
1985
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1986
              __FILE__, __LINE__, pReq->tbName, version);
1987
    TAOS_RETURN(code);
×
1988
  }
1989

1990
  if (pEntry->version >= version) {
58,490✔
1991
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
1992
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
1993
    metaFetchEntryFree(&pEntry);
×
1994
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
1995
  }
1996

1997
  // fetch super entry
1998
  SMetaEntry *pSuper = NULL;
58,490✔
1999
  if (pEntry->type == TSDB_VIRTUAL_CHILD_TABLE) {
58,490✔
2000
    code = metaFetchEntryByUid(pMeta, pEntry->ctbEntry.suid, &pSuper);
29,614✔
2001
    if (code) {
29,614✔
2002
      metaError("vgId:%d, %s failed at %s:%d since super table uid %" PRId64 " not found, version:%" PRId64,
×
2003
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pEntry->ctbEntry.suid, version);
2004
      metaFetchEntryFree(&pEntry);
×
2005
      TAOS_RETURN(TSDB_CODE_INTERNAL_ERROR);
×
2006
    }
2007
  }
2008

2009
  // search the column to update
2010
  SSchemaWrapper *pSchema =
58,490✔
2011
      pEntry->type == TSDB_VIRTUAL_CHILD_TABLE ? &pSuper->stbEntry.schemaRow : &pEntry->ntbEntry.schemaRow;
58,490✔
2012
  SColRef *pColRef = NULL;
58,490✔
2013
  int32_t  iColumn = 0;
58,490✔
2014
  for (int32_t i = 0; i < pSchema->nCols; i++) {
237,516✔
2015
    if (strncmp(pSchema->pSchema[i].name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
237,516✔
2016
      pColRef = &pEntry->colRef.pColRef[i];
58,490✔
2017
      iColumn = i;
58,490✔
2018
      break;
58,490✔
2019
    }
2020
  }
2021

2022
  if (NULL == pColRef) {
58,490✔
2023
    metaError("vgId:%d, %s failed at %s:%d since column id %d not found in table %s, version:%" PRId64,
×
2024
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, iColumn + 1, pReq->tbName, version);
2025
    metaFetchEntryFree(&pEntry);
×
2026
    metaFetchEntryFree(&pSuper);
×
2027
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
2028
  }
2029

2030
  // do update column name
2031
  pEntry->version = version;
58,490✔
2032
  pColRef->hasRef = false;
58,490✔
2033
  pColRef->id = pSchema->pSchema[iColumn].colId;
58,490✔
2034
  pSchema->version++;
58,490✔
2035
  pEntry->colRef.version++;
58,490✔
2036

2037
  // do handle entry
2038
  code = metaHandleEntry2(pMeta, pEntry);
58,490✔
2039
  if (code) {
58,490✔
2040
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
2041
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
2042
    metaFetchEntryFree(&pEntry);
×
2043
    metaFetchEntryFree(&pSuper);
×
2044
    TAOS_RETURN(code);
×
2045
  } else {
2046
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
58,490✔
2047
             pEntry->uid, version);
2048
  }
2049

2050
  // build response
2051
  if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
58,490✔
2052
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
2053
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
2054
  } else {
2055
    for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
358,052✔
2056
      SColRef *p = &pEntry->colRef.pColRef[i];
299,562✔
2057
      pRsp->pColRefs[i].hasRef = p->hasRef;
299,562✔
2058
      pRsp->pColRefs[i].id = p->id;
299,562✔
2059
      if (p->hasRef) {
299,562✔
2060
        tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
147,965✔
2061
        tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
147,965✔
2062
        tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
147,965✔
2063
      }
2064
    }
2065
  }
2066

2067
  metaFetchEntryFree(&pEntry);
58,490✔
2068
  metaFetchEntryFree(&pSuper);
58,490✔
2069
  TAOS_RETURN(code);
58,490✔
2070
}
2071

2072
int32_t metaAddIndexToSuperTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
5,850✔
2073
  int32_t code = TSDB_CODE_SUCCESS;
5,850✔
2074

2075
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
5,850✔
2076
    metaError("vgId:%d, %s failed at %s:%d since invalid table name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2077
              __FILE__, __LINE__, version);
2078
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2079
  }
2080

2081
  SMetaEntry *pEntry = NULL;
5,850✔
2082
  code = metaFetchEntryByName(pMeta, pReq->name, &pEntry);
5,850✔
2083
  if (code) {
5,850✔
2084
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2085
              __FILE__, __LINE__, pReq->name, version);
2086
    TAOS_RETURN(code);
×
2087
  }
2088

2089
  if (pEntry->type != TSDB_SUPER_TABLE) {
5,850✔
2090
    metaError("vgId:%d, %s failed at %s:%d since table %s type %d is invalid, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2091
              __func__, __FILE__, __LINE__, pReq->name, pEntry->type, version);
2092
    metaFetchEntryFree(&pEntry);
×
2093
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2094
  }
2095

2096
  if (pEntry->uid != pReq->suid) {
5,850✔
2097
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64 " is not equal to %" PRId64
×
2098
              ", version:%" PRId64,
2099
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pEntry->uid, pReq->suid, version);
2100
    metaFetchEntryFree(&pEntry);
×
2101
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2102
  }
2103

2104
  // if (pEntry->stbEntry.schemaTag.version >= pReq->schemaTag.version) {
2105
  //   metaError("vgId:%d, %s failed at %s:%d since table %s tag schema version %d is not less than %d, version:%"
2106
  //   PRId64,
2107
  //             TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pEntry->stbEntry.schemaTag.version,
2108
  //             pReq->schemaTag.version, version);
2109
  //   metaFetchEntryFree(&pEntry);
2110
  //   TAOS_RETURN(TSDB_CODE_INVALID_MSG);
2111
  // }
2112

2113
  // do change the entry
2114
  SSchemaWrapper *pOldTagSchema = &pEntry->stbEntry.schemaTag;
5,850✔
2115
  SSchemaWrapper *pNewTagSchema = &pReq->schemaTag;
5,850✔
2116
  if (pOldTagSchema->nCols == 1 && pOldTagSchema->pSchema[0].type == TSDB_DATA_TYPE_JSON) {
5,850✔
2117
    metaError("vgId:%d, %s failed at %s:%d since table %s has no tag, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2118
              __func__, __FILE__, __LINE__, pReq->name, version);
2119
    metaFetchEntryFree(&pEntry);
×
2120
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
2121
  }
2122

2123
  if (pOldTagSchema->nCols != pNewTagSchema->nCols) {
5,850✔
2124
    metaError(
×
2125
        "vgId:%d, %s failed at %s:%d since table %s tag schema column count %d is not equal to %d, version:%" PRId64,
2126
        TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pOldTagSchema->nCols, pNewTagSchema->nCols,
2127
        version);
2128
    metaFetchEntryFree(&pEntry);
×
2129
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2130
  }
2131

2132
  // if (pOldTagSchema->version >= pNewTagSchema->version) {
2133
  //   metaError("vgId:%d, %s failed at %s:%d since table %s tag schema version %d is not less than %d, version:%"
2134
  //   PRId64,
2135
  //             TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pOldTagSchema->version,
2136
  //             pNewTagSchema->version, version);
2137
  //   metaFetchEntryFree(&pEntry);
2138
  //   TAOS_RETURN(TSDB_CODE_INVALID_MSG);
2139
  // }
2140

2141
  int32_t numOfChangedTags = 0;
5,850✔
2142
  for (int32_t i = 0; i < pOldTagSchema->nCols; i++) {
29,844✔
2143
    SSchema *pOldColumn = pOldTagSchema->pSchema + i;
23,994✔
2144
    SSchema *pNewColumn = pNewTagSchema->pSchema + i;
23,994✔
2145

2146
    if (pOldColumn->type != pNewColumn->type || pOldColumn->colId != pNewColumn->colId ||
23,994✔
2147
        strncmp(pOldColumn->name, pNewColumn->name, sizeof(pNewColumn->name))) {
23,994✔
2148
      metaError("vgId:%d, %s failed at %s:%d since table %s tag schema column %d is not equal, version:%" PRId64,
×
2149
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, i, version);
2150
      metaFetchEntryFree(&pEntry);
×
2151
      TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2152
    }
2153

2154
    if (IS_IDX_ON(pNewColumn) && !IS_IDX_ON(pOldColumn)) {
23,994✔
2155
      numOfChangedTags++;
5,850✔
2156
      SSCHMEA_SET_IDX_ON(pOldColumn);
5,850✔
2157
    } else if (!IS_IDX_ON(pNewColumn) && IS_IDX_ON(pOldColumn)) {
18,144✔
2158
      metaError("vgId:%d, %s failed at %s:%d since table %s tag schema column %d is not equal, version:%" PRId64,
×
2159
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, i, version);
2160
      metaFetchEntryFree(&pEntry);
×
2161
      TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2162
    }
2163
  }
2164

2165
  if (numOfChangedTags != 1) {
5,850✔
2166
    metaError(
×
2167
        "vgId:%d, %s failed at %s:%d since table %s tag schema column count %d is not equal to 1, version:%" PRId64,
2168
        TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, numOfChangedTags, version);
2169
    metaFetchEntryFree(&pEntry);
×
2170
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2171
  }
2172

2173
  pEntry->version = version;
5,850✔
2174
  pEntry->stbEntry.schemaTag.version = pNewTagSchema->version;
5,850✔
2175

2176
  // do handle the entry
2177
  code = metaHandleEntry2(pMeta, pEntry);
5,850✔
2178
  if (code) {
5,850✔
2179
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
2180
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->name, version);
2181
    metaFetchEntryFree(&pEntry);
×
2182
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2183
  } else {
2184
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->name,
5,850✔
2185
             pEntry->uid, version);
2186
  }
2187

2188
  metaFetchEntryFree(&pEntry);
5,850✔
2189
  TAOS_RETURN(code);
5,850✔
2190
}
2191

2192
int32_t metaDropIndexFromSuperTable(SMeta *pMeta, int64_t version, SDropIndexReq *pReq) {
3,906✔
2193
  int32_t code = TSDB_CODE_SUCCESS;
3,906✔
2194

2195
  if (strlen(pReq->colName) == 0 || strlen(pReq->stb) == 0) {
3,906✔
2196
    metaError("vgId:%d, %s failed at %s:%d since invalid table name or column name, version:%" PRId64,
×
2197
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, version);
2198
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2199
  }
2200

2201
  SMetaEntry *pEntry = NULL;
3,906✔
2202
  code = metaFetchEntryByUid(pMeta, pReq->stbUid, &pEntry);
3,906✔
2203
  if (code) {
3,906✔
2204
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2205
              __FILE__, __LINE__, pReq->stb, version);
2206
    TAOS_RETURN(code);
×
2207
  }
2208

2209
  if (TSDB_SUPER_TABLE != pEntry->type) {
3,906✔
2210
    metaError("vgId:%d, %s failed at %s:%d since table %s type %d is invalid, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2211
              __func__, __FILE__, __LINE__, pReq->stb, pEntry->type, version);
2212
    metaFetchEntryFree(&pEntry);
×
2213
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2214
  }
2215

2216
  SSchemaWrapper *pTagSchema = &pEntry->stbEntry.schemaTag;
3,906✔
2217
  if (pTagSchema->nCols == 1 && pTagSchema->pSchema[0].type == TSDB_DATA_TYPE_JSON) {
3,906✔
2218
    metaError("vgId:%d, %s failed at %s:%d since table %s has no tag, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2219
              __func__, __FILE__, __LINE__, pReq->stb, version);
2220
    metaFetchEntryFree(&pEntry);
×
2221
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2222
  }
2223

2224
  // search and set the tag index off
2225
  int32_t numOfChangedTags = 0;
3,906✔
2226
  for (int32_t i = 0; i < pTagSchema->nCols; i++) {
10,240✔
2227
    SSchema *pCol = pTagSchema->pSchema + i;
10,240✔
2228
    if (0 == strncmp(pCol->name, pReq->colName, sizeof(pReq->colName))) {
10,240✔
2229
      if (!IS_IDX_ON(pCol)) {
3,906✔
2230
        metaError("vgId:%d, %s failed at %s:%d since table %s column %s is not indexed, version:%" PRId64,
×
2231
                  TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->stb, pReq->colName, version);
2232
        metaFetchEntryFree(&pEntry);
×
2233
        TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2234
      }
2235
      numOfChangedTags++;
3,906✔
2236
      SSCHMEA_SET_IDX_OFF(pCol);
3,906✔
2237
      break;
3,906✔
2238
    }
2239
  }
2240

2241
  if (numOfChangedTags != 1) {
3,906✔
2242
    metaError("vgId:%d, %s failed at %s:%d since table %s column %s is not found, version:%" PRId64,
×
2243
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->stb, pReq->colName, version);
2244
    metaFetchEntryFree(&pEntry);
×
2245
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
2246
  }
2247

2248
  // do handle the entry
2249
  pEntry->version = version;
3,906✔
2250
  pTagSchema->version++;
3,906✔
2251
  code = metaHandleEntry2(pMeta, pEntry);
3,906✔
2252
  if (code) {
3,906✔
2253
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
2254
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->stb, version);
2255
    metaFetchEntryFree(&pEntry);
×
2256
    TAOS_RETURN(code);
×
2257
  } else {
2258
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->stb,
3,906✔
2259
             pEntry->uid, version);
2260
  }
2261

2262
  metaFetchEntryFree(&pEntry);
3,906✔
2263
  TAOS_RETURN(code);
3,906✔
2264
}
2265

2266
int32_t metaAlterSuperTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
8,247,742✔
2267
  int32_t code = TSDB_CODE_SUCCESS;
8,247,742✔
2268

2269
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
8,247,742✔
2270
    metaError("vgId:%d, %s failed at %s:%d since invalid table name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
20,549✔
2271
              __FILE__, __LINE__, version);
2272
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
20,549✔
2273
  }
2274

2275
  SMetaEntry *pEntry = NULL;
8,231,767✔
2276
  code = metaFetchEntryByName(pMeta, pReq->name, &pEntry);
8,248,679✔
2277
  if (code) {
8,235,404✔
2278
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2279
              __FILE__, __LINE__, pReq->name, version);
2280
    TAOS_RETURN(TSDB_CODE_TDB_STB_NOT_EXIST);
×
2281
  }
2282

2283
  if (pEntry->type != TSDB_SUPER_TABLE) {
8,235,404✔
2284
    metaError("vgId:%d, %s failed at %s:%d since table %s type %d is invalid, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2285
              __func__, __FILE__, __LINE__, pReq->name, pEntry->type, version);
2286
    metaFetchEntryFree(&pEntry);
×
2287
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2288
  }
2289

2290
  SMetaEntry entry = {
24,688,834✔
2291
      .version = version,
2292
      .type = TSDB_SUPER_TABLE,
2293
      .uid = pReq->suid,
8,238,249✔
2294
      .name = pReq->name,
8,236,199✔
2295
      .stbEntry.schemaRow = pReq->schemaRow,
2296
      .stbEntry.schemaTag = pReq->schemaTag,
2297
      .stbEntry.keep = pReq->keep,
8,239,182✔
2298
      .colCmpr = pReq->colCmpr,
2299
      .pExtSchemas = pReq->pExtSchemas,
8,226,541✔
2300
  };
2301
  TABLE_SET_COL_COMPRESSED(entry.flags);
8,228,868✔
2302
  if (pReq->virtualStb) {
8,228,868✔
2303
    TABLE_SET_VIRTUAL(entry.flags);
16,581✔
2304
  }
2305
  if(TABLE_IS_ROLLUP(pEntry->flags)) {
8,236,097✔
2306
    TABLE_SET_ROLLUP(entry.flags);
9,264✔
2307
    entry.stbEntry.rsmaParam = pEntry->stbEntry.rsmaParam;
9,264✔
2308
  }
2309

2310
  // do handle the entry
2311
  code = metaHandleEntry2(pMeta, &entry);
8,233,429✔
2312
  if (code) {
8,220,200✔
2313
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
2314
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->suid, pReq->name, version);
2315
    metaFetchEntryFree(&pEntry);
×
2316
    TAOS_RETURN(code);
×
2317
  } else {
2318
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->name,
8,220,200✔
2319
             pReq->suid, version);
2320
  }
2321

2322
  metaFetchEntryFree(&pEntry);
8,237,188✔
2323
  TAOS_RETURN(code);
8,252,857✔
2324
}
2325

2326
int32_t metaDropMultipleTables(SMeta *pMeta, int64_t version, SArray *uidArray) {
×
2327
  int32_t code = 0;
×
2328

2329
  if (taosArrayGetSize(uidArray) == 0) {
×
2330
    return TSDB_CODE_SUCCESS;
×
2331
  }
2332

2333
  for (int32_t i = 0; i < taosArrayGetSize(uidArray); i++) {
×
2334
    tb_uid_t  uid = *(tb_uid_t *)taosArrayGet(uidArray, i);
×
2335
    SMetaInfo info;
×
2336
    code = metaGetInfo(pMeta, uid, &info, NULL);
×
2337
    if (code) {
×
2338
      metaError("vgId:%d, %s failed at %s:%d since table uid %" PRId64 " not found, code:%d", TD_VID(pMeta->pVnode),
×
2339
                __func__, __FILE__, __LINE__, uid, code);
2340
      return code;
×
2341
    }
2342

2343
    SMetaEntry entry = {
×
2344
        .version = version,
2345
        .uid = uid,
2346
    };
2347

2348
    if (info.suid == 0) {
×
2349
      entry.type = -TSDB_NORMAL_TABLE;
×
2350
    } else if (info.suid == uid) {
×
2351
      entry.type = -TSDB_SUPER_TABLE;
×
2352
    } else {
2353
      entry.type = -TSDB_CHILD_TABLE;
×
2354
    }
2355
    code = metaHandleEntry2(pMeta, &entry);
×
2356
    if (code) {
×
2357
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " version:%" PRId64, TD_VID(pMeta->pVnode),
×
2358
                __func__, __FILE__, __LINE__, tstrerror(code), uid, version);
2359
      return code;
×
2360
    }
2361
  }
2362
  return code;
×
2363
}
2364

2365
int metaCreateRsma(SMeta *pMeta, int64_t version, SVCreateRsmaReq *pReq) {
46,320✔
2366
  int32_t code = TSDB_CODE_SUCCESS;
46,320✔
2367

2368
  if (NULL == pReq->name || pReq->name[0] == 0) {
46,320✔
2369
    metaError("vgId:%d, failed at %d to create rsma since invalid rsma name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2370
              __LINE__, version);
2371
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2372
  }
2373

2374
  SMetaEntry *pEntry = NULL;
46,320✔
2375
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
46,320✔
2376
  if (code) {
46,320✔
2377
    metaError("vgId:%d, failed at %d to create rsma %s since table %s not found, version:%" PRId64,
×
2378
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, version);
2379
    TAOS_RETURN(TSDB_CODE_TDB_STB_NOT_EXIST);
×
2380
  }
2381

2382
  if (pEntry->type != TSDB_SUPER_TABLE) {
46,320✔
2383
    metaError("vgId:%d, failed at %d to create rsma %s since table %s type %d is invalid, version:%" PRId64,
×
2384
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, pEntry->type, version);
2385
    metaFetchEntryFree(&pEntry);
×
2386
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2387
  }
2388

2389
  if (pEntry->uid != pReq->tbUid) {
45,548✔
2390
    metaError("vgId:%d, failed at %d to create rsma %s since table %s uid %" PRId64 " is not equal to %" PRId64
×
2391
              ", version:%" PRId64,
2392
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, pEntry->uid, pReq->tbUid, version);
2393
    metaFetchEntryFree(&pEntry);
×
2394
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2395
  }
2396

2397
  if (TABLE_IS_ROLLUP(pEntry->flags)) {
46,320✔
2398
    // overwrite the old rsma definition if exists
2399
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcColIds);
×
2400
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcIds);
×
2401
  } else {
2402
    TABLE_SET_ROLLUP(pEntry->flags);
46,320✔
2403
  }
2404

2405
  SMetaEntry entry = *pEntry;
46,320✔
2406
  entry.version = version;
46,320✔
2407
  entry.stbEntry.rsmaParam.name = pReq->name;
46,320✔
2408
  entry.stbEntry.rsmaParam.uid = pReq->uid;
46,320✔
2409
  entry.stbEntry.rsmaParam.interval[0] = pReq->interval[0];
46,320✔
2410
  entry.stbEntry.rsmaParam.interval[1] = pReq->interval[1];
46,320✔
2411
  entry.stbEntry.rsmaParam.intervalUnit = pReq->intervalUnit;
46,320✔
2412
  entry.stbEntry.rsmaParam.nFuncs = pReq->nFuncs;
45,548✔
2413
  entry.stbEntry.rsmaParam.funcColIds = pReq->funcColIds;
45,548✔
2414
  entry.stbEntry.rsmaParam.funcIds = pReq->funcIds;
46,320✔
2415

2416
  // do handle the entry
2417
  code = metaHandleEntry2(pMeta, &entry);
45,548✔
2418
  if (code) {
46,320✔
2419
    metaError("vgId:%d, failed at %d to create rsma %s since %s, uid:%" PRId64 ", version:%" PRId64,
×
2420
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, tstrerror(code), pReq->tbUid, version);
2421
    metaFetchEntryFree(&pEntry);
×
2422
    TAOS_RETURN(code);
×
2423
  } else {
2424
    pMeta->pVnode->config.vndStats.numOfRSMAs++;
46,320✔
2425
    pMeta->pVnode->config.isRsma = 1;
46,320✔
2426
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated since rsma created %s:%" PRIi64 ", version:%" PRId64,
46,320✔
2427
             TD_VID(pMeta->pVnode), pReq->tbName, pReq->tbUid, pReq->name, pReq->uid, version);
2428
  }
2429

2430
  metaFetchEntryFree(&pEntry);
46,320✔
2431
  TAOS_RETURN(code);
46,320✔
2432
}
2433

2434
int metaDropRsma(SMeta *pMeta, int64_t version, SVDropRsmaReq *pReq) {
9,264✔
2435
  int32_t code = TSDB_CODE_SUCCESS;
9,264✔
2436

2437
  if (NULL == pReq->name || pReq->name[0] == 0) {
9,264✔
2438
    metaError("vgId:%d, %s failed at %d since invalid rsma name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2439
              __LINE__, version);
2440
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2441
  }
2442

2443
  if (NULL == pReq->tbName || pReq->tbName[0] == 0) {
9,264✔
2444
    metaError("vgId:%d, %s failed at %d since invalid table name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2445
              __LINE__, version);
2446
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2447
  }
2448

2449
  SMetaEntry *pEntry = NULL;
9,264✔
2450
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
9,264✔
2451
  if (code) {
8,492✔
2452
    metaWarn("vgId:%d, %s no need at %d to drop %s since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2453
             __func__, __LINE__, pReq->name, pReq->tbName, version);
2454
    TAOS_RETURN(TSDB_CODE_RSMA_NOT_EXIST);
×
2455
  }
2456

2457
  if (pEntry->type != pReq->tbType) {
8,492✔
2458
    metaError("vgId:%d, %s failed at %d to drop %s since table %s type %d is invalid, version:%" PRId64,
×
2459
              TD_VID(pMeta->pVnode), __func__, __LINE__, pReq->name, pReq->tbName, pEntry->type, version);
2460
    metaFetchEntryFree(&pEntry);
×
2461
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2462
  }
2463

2464
  if (pEntry->uid != pReq->tbUid) {
8,492✔
2465
    metaError("vgId:%d, %s failed at %d %s since table %s uid %" PRId64 " is not equal to %" PRId64
×
2466
              ", version:%" PRId64,
2467
              TD_VID(pMeta->pVnode), __func__, __LINE__, pReq->name, pReq->tbName, pEntry->uid, pReq->tbUid, version);
2468
    metaFetchEntryFree(&pEntry);
×
2469
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2470
  }
2471

2472
  if (TABLE_IS_ROLLUP(pEntry->flags)) {
8,492✔
2473
    if (pEntry->stbEntry.rsmaParam.uid != pReq->uid ||
9,264✔
2474
        strncmp(pEntry->stbEntry.rsmaParam.name, pReq->name, TSDB_TABLE_NAME_LEN) != 0) {
9,264✔
UNCOV
2475
      metaError(
×
2476
          "vgId:%d, %s failed at line %d to drop %s since table %s is rollup table with different rsma name %s or "
2477
          "uid:%" PRIi64 ", version:%" PRId64,
2478
          TD_VID(pMeta->pVnode), __func__, __LINE__, pReq->name, pReq->tbName, pEntry->stbEntry.rsmaParam.name,
2479
          pReq->uid, version);
UNCOV
2480
      metaFetchEntryFree(&pEntry);
×
2481
      TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2482
    }
2483
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcColIds);
9,264✔
2484
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcIds);
8,492✔
2485
  } else {
2486
    metaWarn("vgId:%d, %s no need at %d to drop %s since table %s is not rollup table, version:%" PRId64,
×
2487
             TD_VID(pMeta->pVnode), __func__, __LINE__, pReq->name, pReq->tbName, version);
2488
    metaFetchEntryFree(&pEntry);
×
2489
    TAOS_RETURN(TSDB_CODE_RSMA_NOT_EXIST);
×
2490
  }
2491

2492
  SMetaEntry entry = *pEntry;
10,036✔
2493
  entry.version = version;
9,264✔
2494
  TABLE_RESET_ROLLUP(entry.flags);
9,264✔
2495
  entry.stbEntry.rsmaParam.uid = 0;
9,264✔
2496
  entry.stbEntry.rsmaParam.name = NULL;
9,264✔
2497
  entry.stbEntry.rsmaParam.nFuncs = 0;
9,264✔
2498
  entry.stbEntry.rsmaParam.funcColIds = NULL;
9,264✔
2499
  entry.stbEntry.rsmaParam.funcIds = NULL;
9,264✔
2500

2501
  // do handle the entry
2502
  code = metaHandleEntry2(pMeta, &entry);
9,264✔
2503
  if (code) {
9,264✔
2504
    metaError("vgId:%d, %s failed at %d to drop %s since %s, uid:%" PRId64 ", version:%" PRId64, TD_VID(pMeta->pVnode),
×
2505
              __func__, __LINE__, pReq->name, tstrerror(code), pReq->uid, version);
2506
    metaFetchEntryFree(&pEntry);
×
2507
    TAOS_RETURN(code);
×
2508
  } else {
2509
    if (--pMeta->pVnode->config.vndStats.numOfRSMAs <= 0) {
9,264✔
2510
      pMeta->pVnode->config.isRsma = 0;
×
2511
    }
2512
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated since rsma created %s:%" PRIi64 ", version:%" PRId64,
9,264✔
2513
             TD_VID(pMeta->pVnode), pReq->tbName, pReq->tbUid, pReq->name, pReq->uid, version);
2514
  }
2515

2516
  metaFetchEntryFree(&pEntry);
9,264✔
2517
  TAOS_RETURN(code);
9,264✔
2518
}
2519

2520
int metaAlterRsma(SMeta *pMeta, int64_t version, SVAlterRsmaReq *pReq) {
23,932✔
2521
  int32_t code = TSDB_CODE_SUCCESS;
23,932✔
2522

2523
  if (NULL == pReq->name || pReq->name[0] == 0) {
23,932✔
2524
    metaError("vgId:%d, failed at %d to alter rsma since invalid rsma name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2525
              __LINE__, version);
2526
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2527
  }
2528

2529
  SMetaEntry *pEntry = NULL;
23,932✔
2530
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
23,932✔
2531
  if (code) {
23,932✔
2532
    metaError("vgId:%d, failed at %d to alter rsma %s since table %s not found, version:%" PRId64,
×
2533
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, version);
2534
    TAOS_RETURN(TSDB_CODE_TDB_STB_NOT_EXIST);
×
2535
  }
2536

2537
  if (pEntry->uid != pReq->tbUid) {
23,932✔
2538
    metaError("vgId:%d, failed at %d to alter rsma %s since table %s uid %" PRId64 " is not equal to %" PRId64
×
2539
              ", version:%" PRId64,
2540
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, pEntry->uid, pReq->tbUid, version);
2541
    metaFetchEntryFree(&pEntry);
×
2542
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2543
  }
2544

2545
  if (TABLE_IS_ROLLUP(pEntry->flags)) {
23,932✔
2546
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcColIds);
23,932✔
2547
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcIds);
23,932✔
2548
  } else {
2549
    metaError("vgId:%d, failed at %d to alter rsma %s since table %s is not rollup table, version:%" PRId64,
×
2550
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, version);
2551
    metaFetchEntryFree(&pEntry);
×
2552
    TAOS_RETURN(TSDB_CODE_RSMA_NOT_EXIST);
×
2553
  }
2554

2555
  SMetaEntry entry = *pEntry;
23,932✔
2556
  entry.version = version;
23,932✔
2557
  if (pReq->alterType == TSDB_ALTER_RSMA_FUNCTION) {
23,932✔
2558
    entry.stbEntry.rsmaParam.nFuncs = pReq->nFuncs;
23,932✔
2559
    entry.stbEntry.rsmaParam.funcColIds = pReq->funcColIds;
23,932✔
2560
    entry.stbEntry.rsmaParam.funcIds = pReq->funcIds;
23,932✔
2561
  }
2562
  // do handle the entry
2563
  code = metaHandleEntry2(pMeta, &entry);
24,704✔
2564
  if (code) {
24,704✔
2565
    metaError("vgId:%d, failed at %d to alter rsma %s since %s, uid:%" PRId64 ", version:%" PRId64,
×
2566
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, tstrerror(code), pReq->tbUid, version);
2567
    metaFetchEntryFree(&pEntry);
×
2568
    TAOS_RETURN(code);
×
2569
  } else {
2570
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated since rsma altered %s:%" PRIi64 ", version:%" PRId64,
24,704✔
2571
             TD_VID(pMeta->pVnode), pReq->tbName, pReq->tbUid, pReq->name, pReq->uid, version);
2572
  }
2573

2574
  metaFetchEntryFree(&pEntry);
24,704✔
2575
  TAOS_RETURN(code);
24,704✔
2576
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc