20160266155

Committed 12 Dec 2025 08:01AM UTC coverage: 90.357% (-0.001%) from 90.358%

Build # 20160266155

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #5172 from randombit/jack/fix-clang-tidy-misc-const-correctness

Fix and enable clang-tidy warning misc-const-correctness

Run Details

100951 of 111725 relevant lines covered (90.36%)

12817908.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

79.75

/src/lib/tls/sessions_sql/tls_session_manager_sql.cpp

/*
* SQL TLS Session Manager
* (C) 2012,2014 Jack Lloyd
*
* Botan is released under the Simplified BSD License (see license.txt)
*/

#include <botan/tls_session_manager_sql.h>

#include <botan/database.h>
#include <botan/hex.h>
#include <botan/pwdhash.h>
#include <botan/rng.h>
#include <botan/internal/loadstor.h>
#include <chrono>

namespace Botan::TLS {

Session_Manager_SQL::Session_Manager_SQL(std::shared_ptr<SQL_Database> db,
                                         std::string_view passphrase,
                                         const std::shared_ptr<RandomNumberGenerator>& rng,
                                         size_t max_sessions) :
      Session_Manager(rng), m_db(std::move(db)), m_max_sessions(max_sessions) {
   create_or_migrate_and_open(passphrase);
}

void Session_Manager_SQL::create_or_migrate_and_open(std::string_view passphrase) {
   switch(detect_schema_revision()) {
      case CORRUPTED:
      case PRE_BOTAN_3_0:
      case EMPTY:
         // Legacy sessions before Botan 3.0 are simply dropped, no actual
         // migration is implemented. Same for apparently corrupt databases.
         m_db->exec("DROP TABLE IF EXISTS tls_sessions");
         m_db->exec("DROP TABLE IF EXISTS tls_sessions_metadata");
         create_with_latest_schema(passphrase, BOTAN_3_0);
         break;
      case BOTAN_3_0:
         initialize_existing_database(passphrase);
         break;
      default:
         throw Internal_Error("TLS session db has unknown database schema");
   }
}

Session_Manager_SQL::Schema_Revision Session_Manager_SQL::detect_schema_revision() {
   try {
      const auto meta_data_rows = m_db->row_count("tls_sessions_metadata");
      if(meta_data_rows != 1) {
         return CORRUPTED;
      }
   } catch(const SQL_Database::SQL_DB_Error&) {
      return EMPTY;  // `tls_sessions_metadata` probably didn't exist at all
   }

   try {
      auto stmt = m_db->new_statement("SELECT database_revision FROM tls_sessions_metadata");
      if(!stmt->step()) {
         throw Internal_Error("Failed to read revision of TLS session database");
      }
      return Schema_Revision(stmt->get_size_t(0));
   } catch(const SQL_Database::SQL_DB_Error&) {
      return PRE_BOTAN_3_0;  // `database_revision` did not exist yet -> preparing the statement failed
   }
}

void Session_Manager_SQL::create_with_latest_schema(std::string_view passphrase, Schema_Revision rev) {
   m_db->create_table(
      "CREATE TABLE tls_sessions "
      "("
      "session_id TEXT PRIMARY KEY, "
      "session_ticket BLOB, "
      "session_start INTEGER, "
      "hostname TEXT, "
      "hostport INTEGER, "
      "session BLOB NOT NULL"
      ")");

   m_db->create_table(
      "CREATE TABLE tls_sessions_metadata "
      "("
      "passphrase_salt BLOB, "
      "passphrase_iterations INTEGER, "
      "passphrase_check INTEGER, "
      "password_hash_family TEXT, "
      "database_revision INTEGER"
      ")");

   // speeds up lookups on session_tickets when deleting
   m_db->create_table("CREATE INDEX tls_tickets ON tls_sessions (session_ticket)");

   auto salt = m_rng->random_vec<std::vector<uint8_t>>(16);

   secure_vector<uint8_t> derived_key(32 + 2);

   const std::string pbkdf_name = "PBKDF2(SHA-512)";
   auto pbkdf_fam = PasswordHashFamily::create_or_throw(pbkdf_name);

   auto desired_runtime = std::chrono::milliseconds(100);
   auto pbkdf = pbkdf_fam->tune(derived_key.size(), desired_runtime);

   pbkdf->derive_key(
      derived_key.data(), derived_key.size(), passphrase.data(), passphrase.size(), salt.data(), salt.size());

   const size_t iterations = pbkdf->iterations();
   const size_t check_val = make_uint16(derived_key[0], derived_key[1]);
   m_session_key = SymmetricKey(std::span(derived_key).subspan(2));

   auto stmt = m_db->new_statement("INSERT INTO tls_sessions_metadata VALUES (?1, ?2, ?3, ?4, ?5)");

   stmt->bind(1, salt);
   stmt->bind(2, iterations);
   stmt->bind(3, check_val);
   stmt->bind(4, pbkdf_name);
   stmt->bind(5, rev);

   stmt->spin();
}

void Session_Manager_SQL::initialize_existing_database(std::string_view passphrase) {
   auto stmt = m_db->new_statement("SELECT * FROM tls_sessions_metadata");
   if(!stmt->step()) {
      throw Internal_Error("Failed to initialize TLS session database");
   }

   const std::pair<const uint8_t*, size_t> salt = stmt->get_blob(0);
   const size_t iterations = stmt->get_size_t(1);
   const size_t check_val_db = stmt->get_size_t(2);
   const std::string pbkdf_name = stmt->get_str(3);

   secure_vector<uint8_t> derived_key(32 + 2);

   auto pbkdf_fam = PasswordHashFamily::create_or_throw(pbkdf_name);
   auto pbkdf = pbkdf_fam->from_params(iterations);

   pbkdf->derive_key(
      derived_key.data(), derived_key.size(), passphrase.data(), passphrase.size(), salt.first, salt.second);

   const size_t check_val_created = make_uint16(derived_key[0], derived_key[1]);

   if(check_val_created != check_val_db) {
      throw Invalid_Argument("Session database password not valid");
   }

   m_session_key = SymmetricKey(std::span(derived_key).subspan(2));
}

void Session_Manager_SQL::store(const Session& session, const Session_Handle& handle) {
   std::optional<lock_guard_type<recursive_mutex_type>> lk;
   if(!database_is_threadsafe()) {
      lk.emplace(mutex());
   }

   if(session.server_info().hostname().empty()) {
      return;
   }

   auto stmt = m_db->new_statement(
      "INSERT OR REPLACE INTO tls_sessions"
      " VALUES (?1, ?2, ?3, ?4, ?5, ?6)");

   // Generate a random session ID if the peer did not provide one. Note that
   // this ID will not be returned on ::find(), as the ticket is preferred.
   const auto id = handle.id().value_or(m_rng->random_vec<Session_ID>(32));
   const auto ticket = handle.ticket().value_or(Session_Ticket());

   stmt->bind(1, hex_encode(id.get()));
   stmt->bind(2, ticket.get());
   stmt->bind(3, session.start_time());
   stmt->bind(4, session.server_info().hostname());
   stmt->bind(5, session.server_info().port());
   stmt->bind(6, session.encrypt(m_session_key, *m_rng));

   stmt->spin();

   prune_session_cache();
}

std::optional<Session> Session_Manager_SQL::retrieve_one(const Session_Handle& handle) {
   std::optional<lock_guard_type<recursive_mutex_type>> lk;
   if(!database_is_threadsafe()) {
      lk.emplace(mutex());
   }

   if(auto session_id = handle.id()) {
      auto stmt = m_db->new_statement("SELECT session FROM tls_sessions WHERE session_id = ?1");

      stmt->bind(1, hex_encode(session_id->get()));

      while(stmt->step()) {
         const std::pair<const uint8_t*, size_t> blob = stmt->get_blob(0);

         try {
            return Session::decrypt(blob.first, blob.second, m_session_key);
         } catch(...) {}
      }
   }

   return std::nullopt;
}

std::vector<Session_with_Handle> Session_Manager_SQL::find_some(const Server_Information& info,
                                                                const size_t max_sessions_hint) {
   std::optional<lock_guard_type<recursive_mutex_type>> lk;
   if(!database_is_threadsafe()) {
      lk.emplace(mutex());
   }

   auto stmt = m_db->new_statement(
      "SELECT session_id, session_ticket, session FROM tls_sessions"
      " WHERE hostname = ?1 AND hostport = ?2"
      " ORDER BY session_start DESC"
      " LIMIT ?3");

   stmt->bind(1, info.hostname());
   stmt->bind(2, info.port());
   stmt->bind(3, max_sessions_hint);

   std::vector<Session_with_Handle> found_sessions;
   while(stmt->step()) {
      auto handle = [&]() -> Session_Handle {
         auto ticket_blob = stmt->get_blob(1);
         if(ticket_blob.second > 0) {
            return Session_Handle(Session_Ticket(std::span(ticket_blob.first, ticket_blob.second)));
         } else {
            return Session_Handle(Session_ID(Botan::hex_decode(stmt->get_str(0))));
         }
      }();

      const std::pair<const uint8_t*, size_t> blob = stmt->get_blob(2);

      try {
         found_sessions.emplace_back(
            Session_with_Handle{Session::decrypt(blob.first, blob.second, m_session_key), std::move(handle)});
      } catch(...) {}
   }

   return found_sessions;
}

size_t Session_Manager_SQL::remove(const Session_Handle& handle) {
   // The number of deleted rows is taken globally from the database connection,
   // therefore we need to serialize this implementation.
   const lock_guard_type<recursive_mutex_type> lk(mutex());

   if(const auto id = handle.id()) {
      auto stmt = m_db->new_statement("DELETE FROM tls_sessions WHERE session_id = ?1");
      stmt->bind(1, hex_encode(id->get()));
      stmt->spin();
   } else if(const auto ticket = handle.ticket()) {
      auto stmt = m_db->new_statement("DELETE FROM tls_sessions WHERE session_ticket = ?1");
      stmt->bind(1, ticket->get());
      stmt->spin();
   } else {
      // should not happen, as session handles are exclusively either an ID or a ticket
      throw Invalid_Argument("provided a session handle that is neither ID nor ticket");
   }

   return m_db->rows_changed_by_last_statement();
}

size_t Session_Manager_SQL::remove_all() {
   // The number of deleted rows is taken globally from the database connection,
   // therefore we need to serialize this implementation.
   const lock_guard_type<recursive_mutex_type> lk(mutex());

   m_db->exec("DELETE FROM tls_sessions");
   return m_db->rows_changed_by_last_statement();
}

void Session_Manager_SQL::prune_session_cache() {
   // internal API: assuming that the lock is held already if needed

   if(m_max_sessions == 0) {
      return;
   }

   auto remove_oldest = m_db->new_statement(
      "DELETE FROM tls_sessions WHERE session_id NOT IN "
      "(SELECT session_id FROM tls_sessions ORDER BY session_start DESC LIMIT ?1)");
   remove_oldest->bind(1, m_max_sessions);
   remove_oldest->spin();
}

}  // namespace Botan::TLS

1	/*
2	* SQL TLS Session Manager
3	* (C) 2012,2014 Jack Lloyd
4	*
5	* Botan is released under the Simplified BSD License (see license.txt)
6	*/
7
8	#include <botan/tls_session_manager_sql.h>
9
10	#include <botan/database.h>
11	#include <botan/hex.h>
12	#include <botan/pwdhash.h>
13	#include <botan/rng.h>
14	#include <botan/internal/loadstor.h>
15	#include <chrono>
16
17	namespace Botan::TLS {
18
19	Session_Manager_SQL::Session_Manager_SQL(std::shared_ptr<SQL_Database> db,	22✔
20	std::string_view passphrase,
21	const std::shared_ptr<RandomNumberGenerator>& rng,
22	size_t max_sessions) :	22✔
23	Session_Manager(rng), m_db(std::move(db)), m_max_sessions(max_sessions) {	22✔
24	create_or_migrate_and_open(passphrase);	22✔
25	}	22✔
26
27	void Session_Manager_SQL::create_or_migrate_and_open(std::string_view passphrase) {	22✔
28	switch(detect_schema_revision()) {	22✔
29	case CORRUPTED:	22✔
30	case PRE_BOTAN_3_0:	22✔
31	case EMPTY:	22✔
32	// Legacy sessions before Botan 3.0 are simply dropped, no actual
33	// migration is implemented. Same for apparently corrupt databases.
34	m_db->exec("DROP TABLE IF EXISTS tls_sessions");	22✔
35	m_db->exec("DROP TABLE IF EXISTS tls_sessions_metadata");	22✔
36	create_with_latest_schema(passphrase, BOTAN_3_0);	22✔
37	break;	22✔
38	case BOTAN_3_0:	×
39	initialize_existing_database(passphrase);	×
40	break;	×
41	default:	×
42	throw Internal_Error("TLS session db has unknown database schema");	×
43	}
44	}	22✔
45
46	Session_Manager_SQL::Schema_Revision Session_Manager_SQL::detect_schema_revision() {	22✔
47	try {	22✔
48	const auto meta_data_rows = m_db->row_count("tls_sessions_metadata");	22✔
49	if(meta_data_rows != 1) {	1✔
50	return CORRUPTED;
51	}
52	} catch(const SQL_Database::SQL_DB_Error&) {	21✔
53	return EMPTY; // `tls_sessions_metadata` probably didn't exist at all	21✔
54	}	21✔
55
56	try {	1✔
57	auto stmt = m_db->new_statement("SELECT database_revision FROM tls_sessions_metadata");	1✔
58	if(!stmt->step()) {	×
59	throw Internal_Error("Failed to read revision of TLS session database");	×
60	}
61	return Schema_Revision(stmt->get_size_t(0));	×
62	} catch(const SQL_Database::SQL_DB_Error&) {	1✔
63	return PRE_BOTAN_3_0; // `database_revision` did not exist yet -> preparing the statement failed	1✔
64	}	1✔
65	}
66
67	void Session_Manager_SQL::create_with_latest_schema(std::string_view passphrase, Schema_Revision rev) {	22✔
68	m_db->create_table(	22✔
69	"CREATE TABLE tls_sessions "
70	"("
71	"session_id TEXT PRIMARY KEY, "
72	"session_ticket BLOB, "
73	"session_start INTEGER, "
74	"hostname TEXT, "
75	"hostport INTEGER, "
76	"session BLOB NOT NULL"
77	")");
78
79	m_db->create_table(	22✔
80	"CREATE TABLE tls_sessions_metadata "
81	"("
82	"passphrase_salt BLOB, "
83	"passphrase_iterations INTEGER, "
84	"passphrase_check INTEGER, "
85	"password_hash_family TEXT, "
86	"database_revision INTEGER"
87	")");
88
89	// speeds up lookups on session_tickets when deleting
90	m_db->create_table("CREATE INDEX tls_tickets ON tls_sessions (session_ticket)");	22✔
91
92	auto salt = m_rng->random_vec<std::vector<uint8_t>>(16);	22✔
93
94	secure_vector<uint8_t> derived_key(32 + 2);	22✔
95
96	const std::string pbkdf_name = "PBKDF2(SHA-512)";	22✔
97	auto pbkdf_fam = PasswordHashFamily::create_or_throw(pbkdf_name);	22✔
98
99	auto desired_runtime = std::chrono::milliseconds(100);	22✔
100	auto pbkdf = pbkdf_fam->tune(derived_key.size(), desired_runtime);	22✔
101
102	pbkdf->derive_key(	22✔
103	derived_key.data(), derived_key.size(), passphrase.data(), passphrase.size(), salt.data(), salt.size());	22✔
104
105	const size_t iterations = pbkdf->iterations();	22✔
106	const size_t check_val = make_uint16(derived_key[0], derived_key[1]);	22✔
107	m_session_key = SymmetricKey(std::span(derived_key).subspan(2));	22✔
108
109	auto stmt = m_db->new_statement("INSERT INTO tls_sessions_metadata VALUES (?1, ?2, ?3, ?4, ?5)");	22✔
110
111	stmt->bind(1, salt);	22✔
112	stmt->bind(2, iterations);	22✔
113	stmt->bind(3, check_val);	22✔
114	stmt->bind(4, pbkdf_name);	22✔
115	stmt->bind(5, rev);	22✔
116
117	stmt->spin();	22✔
118	}	110✔
119
120	void Session_Manager_SQL::initialize_existing_database(std::string_view passphrase) {	×
121	auto stmt = m_db->new_statement("SELECT * FROM tls_sessions_metadata");	×
122	if(!stmt->step()) {	×
123	throw Internal_Error("Failed to initialize TLS session database");	×
124	}
125
126	const std::pair<const uint8_t*, size_t> salt = stmt->get_blob(0);	×
127	const size_t iterations = stmt->get_size_t(1);	×
128	const size_t check_val_db = stmt->get_size_t(2);	×
129	const std::string pbkdf_name = stmt->get_str(3);	×
130
131	secure_vector<uint8_t> derived_key(32 + 2);	×
132
133	auto pbkdf_fam = PasswordHashFamily::create_or_throw(pbkdf_name);	×
134	auto pbkdf = pbkdf_fam->from_params(iterations);	×
135
136	pbkdf->derive_key(	×
137	derived_key.data(), derived_key.size(), passphrase.data(), passphrase.size(), salt.first, salt.second);	×
138
139	const size_t check_val_created = make_uint16(derived_key[0], derived_key[1]);	×
140
141	if(check_val_created != check_val_db) {	×
142	throw Invalid_Argument("Session database password not valid");	×
143	}
144
145	m_session_key = SymmetricKey(std::span(derived_key).subspan(2));	×
146	}	×
147
148	void Session_Manager_SQL::store(const Session& session, const Session_Handle& handle) {	236✔
149	std::optional<lock_guard_type<recursive_mutex_type>> lk;	236✔
150	if(!database_is_threadsafe()) {	236✔
151	lk.emplace(mutex());	×
152	}
153
154	if(session.server_info().hostname().empty()) {	472✔
155	return;	×
156	}
157
158	auto stmt = m_db->new_statement(	236✔
159	"INSERT OR REPLACE INTO tls_sessions"
160	" VALUES (?1, ?2, ?3, ?4, ?5, ?6)");	236✔
161
162	// Generate a random session ID if the peer did not provide one. Note that
163	// this ID will not be returned on ::find(), as the ticket is preferred.
164	const auto id = handle.id().value_or(m_rng->random_vec<Session_ID>(32));	698✔
165	const auto ticket = handle.ticket().value_or(Session_Ticket());	472✔
166
167	stmt->bind(1, hex_encode(id.get()));	236✔
168	stmt->bind(2, ticket.get());	236✔
169	stmt->bind(3, session.start_time());	236✔
170	stmt->bind(4, session.server_info().hostname());	472✔
171	stmt->bind(5, session.server_info().port());	236✔
172	stmt->bind(6, session.encrypt(m_session_key, *m_rng));	236✔
173
174	stmt->spin();	236✔
175
176	prune_session_cache();	236✔
177	}	708✔
178
179	std::optional<Session> Session_Manager_SQL::retrieve_one(const Session_Handle& handle) {	36✔
180	std::optional<lock_guard_type<recursive_mutex_type>> lk;	36✔
181	if(!database_is_threadsafe()) {	36✔
182	lk.emplace(mutex());	×
183	}
184
185	if(auto session_id = handle.id()) {	36✔
186	auto stmt = m_db->new_statement("SELECT session FROM tls_sessions WHERE session_id = ?1");	34✔
187
188	stmt->bind(1, hex_encode(session_id->get()));	34✔
189
190	while(stmt->step()) {	34✔
191	const std::pair<const uint8_t*, size_t> blob = stmt->get_blob(0);	21✔
192
193	try {	21✔
194	return Session::decrypt(blob.first, blob.second, m_session_key);	21✔
195	} catch(...) {}	×
196	}
197	}	34✔
198
199	return std::nullopt;	15✔
200	}	36✔
201
202	std::vector<Session_with_Handle> Session_Manager_SQL::find_some(const Server_Information& info,	102✔
203	const size_t max_sessions_hint) {
204	std::optional<lock_guard_type<recursive_mutex_type>> lk;	102✔
205	if(!database_is_threadsafe()) {	102✔
206	lk.emplace(mutex());	×
207	}
208
209	auto stmt = m_db->new_statement(	102✔
210	"SELECT session_id, session_ticket, session FROM tls_sessions"
211	" WHERE hostname = ?1 AND hostport = ?2"
212	" ORDER BY session_start DESC"
213	" LIMIT ?3");	102✔
214
215	stmt->bind(1, info.hostname());	204✔
216	stmt->bind(2, info.port());	102✔
217	stmt->bind(3, max_sessions_hint);	102✔
218
219	std::vector<Session_with_Handle> found_sessions;	102✔
220	while(stmt->step()) {	210✔
221	auto handle = [&]() -> Session_Handle {	324✔
222	auto ticket_blob = stmt->get_blob(1);	108✔
223	if(ticket_blob.second > 0) {	108✔
224	return Session_Handle(Session_Ticket(std::span(ticket_blob.first, ticket_blob.second)));	26✔
225	} else {
226	return Session_Handle(Session_ID(Botan::hex_decode(stmt->get_str(0))));	190✔
227	}
228	}();	108✔
229
230	const std::pair<const uint8_t*, size_t> blob = stmt->get_blob(2);	108✔
231
232	try {	108✔
233	found_sessions.emplace_back(	216✔
234	Session_with_Handle{Session::decrypt(blob.first, blob.second, m_session_key), std::move(handle)});	108✔
235	} catch(...) {}	×
236	}	108✔
237
238	return found_sessions;	102✔
239	}	102✔
240
241	size_t Session_Manager_SQL::remove(const Session_Handle& handle) {	9✔
242	// The number of deleted rows is taken globally from the database connection,
243	// therefore we need to serialize this implementation.
244	const lock_guard_type<recursive_mutex_type> lk(mutex());	9✔
245
246	if(const auto id = handle.id()) {	9✔
247	auto stmt = m_db->new_statement("DELETE FROM tls_sessions WHERE session_id = ?1");	6✔
248	stmt->bind(1, hex_encode(id->get()));	6✔
249	stmt->spin();	6✔
250	} else if(const auto ticket = handle.ticket()) {	9✔
251	auto stmt = m_db->new_statement("DELETE FROM tls_sessions WHERE session_ticket = ?1");	3✔
252	stmt->bind(1, ticket->get());	3✔
253	stmt->spin();	3✔
254	} else {	3✔
255	// should not happen, as session handles are exclusively either an ID or a ticket
256	throw Invalid_Argument("provided a session handle that is neither ID nor ticket");	×
257	}	3✔
258
259	return m_db->rows_changed_by_last_statement();	9✔
260	}	9✔
261
262	size_t Session_Manager_SQL::remove_all() {	13✔
263	// The number of deleted rows is taken globally from the database connection,
264	// therefore we need to serialize this implementation.
265	const lock_guard_type<recursive_mutex_type> lk(mutex());	13✔
266
267	m_db->exec("DELETE FROM tls_sessions");	13✔
268	return m_db->rows_changed_by_last_statement();	13✔
269	}	13✔
270
271	void Session_Manager_SQL::prune_session_cache() {	236✔
272	// internal API: assuming that the lock is held already if needed
273
274	if(m_max_sessions == 0) {	236✔
275	return;	25✔
276	}
277
278	auto remove_oldest = m_db->new_statement(	211✔
279	"DELETE FROM tls_sessions WHERE session_id NOT IN "
280	"(SELECT session_id FROM tls_sessions ORDER BY session_start DESC LIMIT ?1)");	211✔
281	remove_oldest->bind(1, m_max_sessions);	211✔
282	remove_oldest->spin();	211✔
283	}	211✔
284
285	} // namespace Botan::TLS

randombit / botan / 20160266155

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous