stacklok / toolhive / 20082269667

push

github

Fix VirtualMCPServer reconciliation for discovered auth config updates (#2957)

* Fix VirtualMCPServer reconciliation for discovered auth config updates

When an MCPExternalAuthConfig is updated, VirtualMCPServer resources
should reconcile to pick up the changes. However, the watch handler only
checked inline references in the VirtualMCPServer.Spec.OutgoingAuth field
and ignored discovered references when source: discovered mode is used.

In discovered mode, auth configs are referenced through MCPServer
resources in the group rather than inline in the VirtualMCPServer spec.
The watch handler now checks both inline and discovered references by
listing MCPServers in the group and checking if any reference the
updated MCPExternalAuthConfig.

This ensures that VirtualMCPServers using discovered mode will properly
reconcile when their backend auth configurations change.

Fixes #2831

* changes from review

---------

Co-authored-by: taskbot <taskbot@users.noreply.github.com>
Co-authored-by: Jakub Hrozek <jakub.hrozek@posteo.se>

34 of 38 new or added lines in 1 file covered. (89.47%)

26652 of 53827 relevant lines covered (49.51%)

57.86 hits per line