#558

Committed 08 Dec 2025 02:56PM UTC coverage: 48.239% (+0.02%) from 48.215%

Build # #558

Build Type

push

github

Committed by

aalmiray

Commit Message

feat(core): warn when a name template cannot be resolved

Closes #1960

Closes #1961

Coverage Stats

299 of 573 new or added lines in 133 files covered. (52.18%)

4 existing lines in 4 files now uncovered.

26047 of 53996 relevant lines covered (48.24%)

0.48 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.89

/core/jreleaser-engine/src/main/java/org/jreleaser/packagers/MacportsPackagerProcessor.java

/*
 * SPDX-License-Identifier: Apache-2.0
 *
 * Copyright 2020-2025 The JReleaser authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     https://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.jreleaser.packagers;

import org.jreleaser.model.internal.JReleaserContext;
import org.jreleaser.model.internal.distributions.Distribution;
import org.jreleaser.model.internal.packagers.MacportsPackager;
import org.jreleaser.model.internal.release.BaseReleaser;
import org.jreleaser.model.spi.packagers.PackagerProcessingException;
import org.jreleaser.mustache.TemplateContext;

import java.nio.file.Path;
import java.util.Arrays;
import java.util.List;

import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_FILE;
import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_FILE_NAME;
import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_NAME;
import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_VERSION;
import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_JAVA_MAIN_CLASS;
import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_JAVA_MAIN_MODULE;
import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_URL;
import static org.jreleaser.model.Constants.KEY_MACPORTS_APP_NAME;
import static org.jreleaser.model.Constants.KEY_MACPORTS_CATEGORIES;
import static org.jreleaser.model.Constants.KEY_MACPORTS_DISTNAME;
import static org.jreleaser.model.Constants.KEY_MACPORTS_DISTRIBUTION_URL;
import static org.jreleaser.model.Constants.KEY_MACPORTS_JAVA_VERSION;
import static org.jreleaser.model.Constants.KEY_MACPORTS_MAINTAINERS;
import static org.jreleaser.model.Constants.KEY_MACPORTS_PACKAGE_NAME;
import static org.jreleaser.model.Constants.KEY_MACPORTS_REPOSITORY_CLONE_URL;
import static org.jreleaser.model.Constants.KEY_MACPORTS_REPOSITORY_REPO_CLONE_URL;
import static org.jreleaser.model.Constants.KEY_MACPORTS_REPOSITORY_REPO_URL;
import static org.jreleaser.model.Constants.KEY_MACPORTS_REPOSITORY_URL;
import static org.jreleaser.model.Constants.KEY_MACPORTS_REVISION;
import static org.jreleaser.model.Constants.KEY_PROJECT_LONG_DESCRIPTION;
import static org.jreleaser.model.api.packagers.MacportsPackager.APP_NAME;
import static org.jreleaser.mustache.MustacheUtils.passThrough;
import static org.jreleaser.mustache.Templates.resolveTemplate;
import static org.jreleaser.templates.TemplateUtils.trimTplExtension;

/**
 * @author Andres Almiray
 * @since 0.9.0
 */
public class MacportsPackagerProcessor extends AbstractRepositoryPackagerProcessor<MacportsPackager> {
    private static final String LINE_SEPARATOR = " \\\n                 ";

    public MacportsPackagerProcessor(JReleaserContext context) {
        super(context);
    }

    @Override
    protected void doPackageDistribution(Distribution distribution, TemplateContext props, Path packageDirectory) throws PackagerProcessingException {
        super.doPackageDistribution(distribution, props, packageDirectory);
        copyPreparedFiles(props);
    }

    @Override
    protected void fillPackagerProperties(TemplateContext props, Distribution distribution) {
        props.set(KEY_DISTRIBUTION_JAVA_MAIN_CLASS, distribution.getJava().getMainClass());
        props.set(KEY_DISTRIBUTION_JAVA_MAIN_MODULE, distribution.getJava().getMainModule());
        BaseReleaser<?, ?> releaser = context.getModel().getRelease().getReleaser();

        props.set(KEY_MACPORTS_REPOSITORY_REPO_URL,
            releaser.getResolvedRepoUrl(context, packager.getRepository().getOwner(), packager.getRepository().getResolvedName()));
        props.set(KEY_MACPORTS_REPOSITORY_REPO_CLONE_URL,
            releaser.getResolvedRepoCloneUrl(context, packager.getRepository().getOwner(), packager.getRepository().getResolvedName()));

        props.set(KEY_MACPORTS_REPOSITORY_URL,
            releaser.getResolvedRepoUrl(context, packager.getRepository().getOwner(), packager.getRepository().getResolvedName()));
        props.set(KEY_MACPORTS_REPOSITORY_CLONE_URL,
            releaser.getResolvedRepoCloneUrl(context, packager.getRepository().getOwner(), packager.getRepository().getResolvedName()));

        List<String> longDescription = Arrays.asList(context.getModel().getProject().getLongDescription().split("\\n"));

        props.set(KEY_MACPORTS_PACKAGE_NAME, packager.getPackageName());
        props.set(KEY_MACPORTS_REVISION, packager.getRevision());
        props.set(KEY_MACPORTS_CATEGORIES, String.join(" ", packager.getCategories()));
        props.set(KEY_MACPORTS_MAINTAINERS, passThrough(String.join(LINE_SEPARATOR, packager.getResolvedMaintainers(context))));
        props.set(KEY_PROJECT_LONG_DESCRIPTION, passThrough(String.join(LINE_SEPARATOR, longDescription)));
        if (distribution.getType() == org.jreleaser.model.Distribution.DistributionType.JAVA_BINARY ||
            distribution.getType() == org.jreleaser.model.Distribution.DistributionType.SINGLE_JAR) {
            props.set(KEY_MACPORTS_JAVA_VERSION, resolveJavaVersion(distribution));
        }
        if (packager.getExtraProperties().containsKey(APP_NAME)) {
            props.set(KEY_MACPORTS_APP_NAME, resolveTemplate(context.getLogger(), packager.getExtraProperty(APP_NAME), props));
        }

        String distributionUrl = props.get(KEY_DISTRIBUTION_URL);
        String artifactFile = props.get(KEY_DISTRIBUTION_ARTIFACT_FILE);
        if (distributionUrl.endsWith(artifactFile)) {
            distributionUrl = distributionUrl.substring(0, distributionUrl.length() - artifactFile.length() - 1);
        }
        distributionUrl = distributionUrl.replace(context.getModel().getProject().getEffectiveVersion(), "${version}");
        props.set(KEY_MACPORTS_DISTRIBUTION_URL, distributionUrl);

        String artifactFileName = props.get(KEY_DISTRIBUTION_ARTIFACT_FILE_NAME);
        String artifactName = props.get(KEY_DISTRIBUTION_ARTIFACT_NAME);
        String artifactVersion = props.get(KEY_DISTRIBUTION_ARTIFACT_VERSION);
        props.set(KEY_MACPORTS_DISTNAME, artifactFileName.replace(artifactName, "${name}")
            .replace(artifactVersion, "${version}"));
    }

    private String resolveJavaVersion(Distribution distribution) {
        String version = distribution.getJava().getVersion();
        if ("8".equals(version)) return "1.8+";
        try {
            Integer.parseInt(version);
            return version + "+";
        } catch (NumberFormatException ignored) {
            // noop
        }

        return version;
    }

    @Override
    protected void writeFile(Distribution distribution,
                             String content,
                             TemplateContext props,
                             Path outputDirectory,
                             String fileName) throws PackagerProcessingException {
        fileName = trimTplExtension(fileName);

        Path outputFile = "Portfile".equals(fileName) ?
            outputDirectory.resolve("ports")
                .resolve(packager.getCategories().get(0))
                .resolve(packager.getPackageName())
                .resolve(fileName) :
            outputDirectory.resolve(fileName);

        writeFile(content, outputFile);
    }
}

1	/*
2	* SPDX-License-Identifier: Apache-2.0
3	*
4	* Copyright 2020-2025 The JReleaser authors.
5	*
6	* Licensed under the Apache License, Version 2.0 (the "License");
7	* you may not use this file except in compliance with the License.
8	* You may obtain a copy of the License at
9	*
10	* https://www.apache.org/licenses/LICENSE-2.0
11	*
12	* Unless required by applicable law or agreed to in writing, software
13	* distributed under the License is distributed on an "AS IS" BASIS,
14	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15	* See the License for the specific language governing permissions and
16	* limitations under the License.
17	*/
18	package org.jreleaser.packagers;
19
20	import org.jreleaser.model.internal.JReleaserContext;
21	import org.jreleaser.model.internal.distributions.Distribution;
22	import org.jreleaser.model.internal.packagers.MacportsPackager;
23	import org.jreleaser.model.internal.release.BaseReleaser;
24	import org.jreleaser.model.spi.packagers.PackagerProcessingException;
25	import org.jreleaser.mustache.TemplateContext;
26
27	import java.nio.file.Path;
28	import java.util.Arrays;
29	import java.util.List;
30
31	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_FILE;
32	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_FILE_NAME;
33	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_NAME;
34	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_VERSION;
35	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_JAVA_MAIN_CLASS;
36	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_JAVA_MAIN_MODULE;
37	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_URL;
38	import static org.jreleaser.model.Constants.KEY_MACPORTS_APP_NAME;
39	import static org.jreleaser.model.Constants.KEY_MACPORTS_CATEGORIES;
40	import static org.jreleaser.model.Constants.KEY_MACPORTS_DISTNAME;
41	import static org.jreleaser.model.Constants.KEY_MACPORTS_DISTRIBUTION_URL;
42	import static org.jreleaser.model.Constants.KEY_MACPORTS_JAVA_VERSION;
43	import static org.jreleaser.model.Constants.KEY_MACPORTS_MAINTAINERS;
44	import static org.jreleaser.model.Constants.KEY_MACPORTS_PACKAGE_NAME;
45	import static org.jreleaser.model.Constants.KEY_MACPORTS_REPOSITORY_CLONE_URL;
46	import static org.jreleaser.model.Constants.KEY_MACPORTS_REPOSITORY_REPO_CLONE_URL;
47	import static org.jreleaser.model.Constants.KEY_MACPORTS_REPOSITORY_REPO_URL;
48	import static org.jreleaser.model.Constants.KEY_MACPORTS_REPOSITORY_URL;
49	import static org.jreleaser.model.Constants.KEY_MACPORTS_REVISION;
50	import static org.jreleaser.model.Constants.KEY_PROJECT_LONG_DESCRIPTION;
51	import static org.jreleaser.model.api.packagers.MacportsPackager.APP_NAME;
52	import static org.jreleaser.mustache.MustacheUtils.passThrough;
53	import static org.jreleaser.mustache.Templates.resolveTemplate;
54	import static org.jreleaser.templates.TemplateUtils.trimTplExtension;
55
56	/**
57	* @author Andres Almiray
58	* @since 0.9.0
59	*/
60	public class MacportsPackagerProcessor extends AbstractRepositoryPackagerProcessor<MacportsPackager> {
61	private static final String LINE_SEPARATOR = " \\\n ";
62
63	public MacportsPackagerProcessor(JReleaserContext context) {
64	super(context);	1✔
65	}	1✔
66
67	@Override
68	protected void doPackageDistribution(Distribution distribution, TemplateContext props, Path packageDirectory) throws PackagerProcessingException {
69	super.doPackageDistribution(distribution, props, packageDirectory);	1✔
70	copyPreparedFiles(props);	1✔
71	}	1✔
72
73	@Override
74	protected void fillPackagerProperties(TemplateContext props, Distribution distribution) {
75	props.set(KEY_DISTRIBUTION_JAVA_MAIN_CLASS, distribution.getJava().getMainClass());	1✔
76	props.set(KEY_DISTRIBUTION_JAVA_MAIN_MODULE, distribution.getJava().getMainModule());	1✔
77	BaseReleaser<?, ?> releaser = context.getModel().getRelease().getReleaser();	1✔
78
79	props.set(KEY_MACPORTS_REPOSITORY_REPO_URL,	1✔
80	releaser.getResolvedRepoUrl(context, packager.getRepository().getOwner(), packager.getRepository().getResolvedName()));	1✔
81	props.set(KEY_MACPORTS_REPOSITORY_REPO_CLONE_URL,	1✔
82	releaser.getResolvedRepoCloneUrl(context, packager.getRepository().getOwner(), packager.getRepository().getResolvedName()));	1✔
83
84	props.set(KEY_MACPORTS_REPOSITORY_URL,	1✔
85	releaser.getResolvedRepoUrl(context, packager.getRepository().getOwner(), packager.getRepository().getResolvedName()));	1✔
86	props.set(KEY_MACPORTS_REPOSITORY_CLONE_URL,	1✔
87	releaser.getResolvedRepoCloneUrl(context, packager.getRepository().getOwner(), packager.getRepository().getResolvedName()));	1✔
88
89	List<String> longDescription = Arrays.asList(context.getModel().getProject().getLongDescription().split("\\n"));	1✔
90
91	props.set(KEY_MACPORTS_PACKAGE_NAME, packager.getPackageName());	1✔
92	props.set(KEY_MACPORTS_REVISION, packager.getRevision());	1✔
93	props.set(KEY_MACPORTS_CATEGORIES, String.join(" ", packager.getCategories()));	1✔
94	props.set(KEY_MACPORTS_MAINTAINERS, passThrough(String.join(LINE_SEPARATOR, packager.getResolvedMaintainers(context))));	1✔
95	props.set(KEY_PROJECT_LONG_DESCRIPTION, passThrough(String.join(LINE_SEPARATOR, longDescription)));	1✔
96	if (distribution.getType() == org.jreleaser.model.Distribution.DistributionType.JAVA_BINARY \|\|	1✔
97	distribution.getType() == org.jreleaser.model.Distribution.DistributionType.SINGLE_JAR) {	×
98	props.set(KEY_MACPORTS_JAVA_VERSION, resolveJavaVersion(distribution));	1✔
99	}
100	if (packager.getExtraProperties().containsKey(APP_NAME)) {	1✔
NEW 101	props.set(KEY_MACPORTS_APP_NAME, resolveTemplate(context.getLogger(), packager.getExtraProperty(APP_NAME), props));	×
102	}
103
104	String distributionUrl = props.get(KEY_DISTRIBUTION_URL);	1✔
105	String artifactFile = props.get(KEY_DISTRIBUTION_ARTIFACT_FILE);	1✔
106	if (distributionUrl.endsWith(artifactFile)) {	1✔
107	distributionUrl = distributionUrl.substring(0, distributionUrl.length() - artifactFile.length() - 1);	1✔
108	}
109	distributionUrl = distributionUrl.replace(context.getModel().getProject().getEffectiveVersion(), "${version}");	1✔
110	props.set(KEY_MACPORTS_DISTRIBUTION_URL, distributionUrl);	1✔
111
112	String artifactFileName = props.get(KEY_DISTRIBUTION_ARTIFACT_FILE_NAME);	1✔
113	String artifactName = props.get(KEY_DISTRIBUTION_ARTIFACT_NAME);	1✔
114	String artifactVersion = props.get(KEY_DISTRIBUTION_ARTIFACT_VERSION);	1✔
115	props.set(KEY_MACPORTS_DISTNAME, artifactFileName.replace(artifactName, "${name}")	1✔
116	.replace(artifactVersion, "${version}"));	1✔
117	}	1✔
118
119	private String resolveJavaVersion(Distribution distribution) {
120	String version = distribution.getJava().getVersion();	1✔
121	if ("8".equals(version)) return "1.8+";	1✔
122	try {
123	Integer.parseInt(version);	×
124	return version + "+";	×
125	} catch (NumberFormatException ignored) {	×
126	// noop
127	}
128
129	return version;	×
130	}
131
132	@Override
133	protected void writeFile(Distribution distribution,
134	String content,
135	TemplateContext props,
136	Path outputDirectory,
137	String fileName) throws PackagerProcessingException {
138	fileName = trimTplExtension(fileName);	1✔
139
140	Path outputFile = "Portfile".equals(fileName) ?	1✔
141	outputDirectory.resolve("ports")	1✔
142	.resolve(packager.getCategories().get(0))	1✔
143	.resolve(packager.getPackageName())	1✔
144	.resolve(fileName) :	1✔
145	outputDirectory.resolve(fileName);	1✔
146
147	writeFile(content, outputFile);	1✔
148	}	1✔
149	}

jreleaser / jreleaser / #558

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous