Build has been canceled!

#558

Committed 08 Dec 2025 02:56PM UTC coverage: 48.239% (+0.02%) from 48.215%

Build # #558

Build Type

push

github

Committed by

aalmiray

Commit Message

feat(core): warn when a name template cannot be resolved

Closes #1960

Closes #1961

Run Details

299 of 573 new or added lines in 133 files covered. (52.18%)

4 existing lines in 4 files now uncovered.

26047 of 53996 relevant lines covered (48.24%)

0.48 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

2.74

/core/jreleaser-engine/src/main/java/org/jreleaser/packagers/AppImagePackagerProcessor.java

/*
 * SPDX-License-Identifier: Apache-2.0
 *
 * Copyright 2020-2025 The JReleaser authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *     https://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package org.jreleaser.packagers;

import org.apache.commons.lang3.StringUtils;
import org.jreleaser.bundle.RB;
import org.jreleaser.engine.release.Releasers;
import org.jreleaser.model.Stereotype;
import org.jreleaser.model.internal.JReleaserContext;
import org.jreleaser.model.internal.common.Screenshot;
import org.jreleaser.model.internal.distributions.Distribution;
import org.jreleaser.model.internal.packagers.AppImagePackager;
import org.jreleaser.model.internal.release.BaseReleaser;
import org.jreleaser.model.internal.release.GithubReleaser;
import org.jreleaser.model.internal.release.Releaser;
import org.jreleaser.model.spi.packagers.PackagerProcessingException;
import org.jreleaser.mustache.TemplateContext;

import java.io.IOException;
import java.io.InputStream;
import java.nio.file.Path;
import java.util.Optional;

import static java.util.stream.Collectors.toList;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_CATEGORIES;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_CATEGORIES_BY_COMMA;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_COMPONENT_ID;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_DEVELOPER_ID;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_DEVELOPER_NAME;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_DISTRIBUTION_ARTIFACT_FILE;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_DISTRIBUTION_ARTIFACT_FILE_NAME;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_DISTRIBUTION_URL;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_ICONS;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_RELEASES;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_REPOSITORY_NAME;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_REPOSITORY_OWNER;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_REPO_NAME;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_REPO_OWNER;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_REQUIRES_TERMINAL;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_SCREENSHOTS;
import static org.jreleaser.model.Constants.KEY_APPIMAGE_URLS;
import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_FILE;
import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_FILE_NAME;
import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_JAVA_MAIN_CLASS;
import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_JAVA_MAIN_MODULE;
import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_URL;
import static org.jreleaser.model.Constants.KEY_PROJECT_AUTHORS;
import static org.jreleaser.packagers.AppdataUtils.isReleaseIncluded;
import static org.jreleaser.packagers.AppdataUtils.resolveIcons;
import static org.jreleaser.templates.TemplateUtils.trimTplExtension;

/**
 * @author Andres Almiray
 * @since 1.2.0
 */
public class AppImagePackagerProcessor extends AbstractRepositoryPackagerProcessor<AppImagePackager> {
    public AppImagePackagerProcessor(JReleaserContext context) {
        super(context);
    }

    @Override
    protected void doPrepareDistribution(Distribution distribution, TemplateContext props) throws PackagerProcessingException {
        setupPrepare(distribution, props);
        super.doPrepareDistribution(distribution, props);
    }

    @Override
    protected void doPackageDistribution(Distribution distribution, TemplateContext props, Path packageDirectory) throws PackagerProcessingException {
        super.doPackageDistribution(distribution, props, packageDirectory);
        copyPreparedFiles(props);
    }

    private void setupPrepare(Distribution distribution, TemplateContext props) throws PackagerProcessingException {
        BaseReleaser<?, ?> releaser = context.getModel().getRelease().getReleaser();

        try {
            props.set(KEY_APPIMAGE_RELEASES, Releasers.releaserFor(context)
                .listReleases(releaser.getOwner(), releaser.getName()).stream()
                .filter(r -> isReleaseIncluded(packager.getSkipReleases(), r.getVersion().toString()))
                .map(r -> AppdataUtils.Release.of(r.getUrl(), r.getVersion().toString(), r.getPublishedAt()))
                .collect(toList()));
        } catch (IOException e) {
            throw new PackagerProcessingException(RB.$("ERROR_unexpected_error"), e);
        }

        props.set(KEY_APPIMAGE_SCREENSHOTS, packager.getScreenshots().stream()
            .map(Screenshot::asScreenshotTemplate)
            .collect(toList()));

        context.getLogger().debug(RB.$("packager.fetch.icons"));
        props.set(KEY_APPIMAGE_ICONS, packager.getIcons());
        resolveIcons(context, packager, distribution, props, packager.getIcons());
    }

    @Override
    protected void fillPackagerProperties(TemplateContext props, Distribution distribution) {
        props.set(KEY_DISTRIBUTION_JAVA_MAIN_CLASS, distribution.getJava().getMainClass());
        props.set(KEY_DISTRIBUTION_JAVA_MAIN_MODULE, distribution.getJava().getMainModule());
        props.set(KEY_PROJECT_AUTHORS, context.getModel().getProject().getAuthors());
        props.set(KEY_APPIMAGE_URLS, context.getModel().getProject().getLinks().asLinkTemplates(false));
        props.set(KEY_APPIMAGE_COMPONENT_ID, getPackager().getComponentId());
        props.set(KEY_APPIMAGE_CATEGORIES, getPackager().getCategories());
        props.set(KEY_APPIMAGE_CATEGORIES_BY_COMMA, String.join(",", getPackager().getCategories()));
        props.set(KEY_APPIMAGE_DEVELOPER_ID, getPackager().getDeveloperId());
        props.set(KEY_APPIMAGE_DEVELOPER_NAME, getPackager().getDeveloperName());
        props.set(KEY_APPIMAGE_REQUIRES_TERMINAL, getPackager().isRequiresTerminal());
        props.set(KEY_APPIMAGE_REPO_OWNER, packager.getRepository().getOwner());
        props.set(KEY_APPIMAGE_REPO_NAME, packager.getRepository().getName());
        props.set(KEY_APPIMAGE_REPOSITORY_OWNER, packager.getRepository().getOwner());
        props.set(KEY_APPIMAGE_REPOSITORY_NAME, packager.getRepository().getName());

        BaseReleaser<?, ?> releaser = context.getModel().getRelease().getReleaser();
        String str = props.get(KEY_DISTRIBUTION_ARTIFACT_FILE);
        str = str.replace(context.getModel().getProject().getEffectiveVersion(), "${DISTRIBUTION_VERSION}");
        props.set(KEY_APPIMAGE_DISTRIBUTION_ARTIFACT_FILE, str);
        str = props.get(KEY_DISTRIBUTION_ARTIFACT_FILE_NAME);
        str = str.replace(context.getModel().getProject().getEffectiveVersion(), "${DISTRIBUTION_VERSION}");
        props.set(KEY_APPIMAGE_DISTRIBUTION_ARTIFACT_FILE_NAME, str);
        str = props.get(KEY_DISTRIBUTION_URL);
        str = str.replace(releaser.getEffectiveTagName(context), "${DISTRIBUTION_TAG}")
            .replace(props.get(KEY_DISTRIBUTION_ARTIFACT_FILE), "${DISTRIBUTION_FILE}");
        props.set(KEY_APPIMAGE_DISTRIBUTION_URL, str);
    }

    @Override
    protected void writeFile(Distribution distribution,
                             String content,
                             TemplateContext props,
                             Path outputDirectory,
                             String fileName) throws PackagerProcessingException {
        Releaser<?> gitService = context.getModel().getRelease().getReleaser();
        if (fileName.contains("github") && !(gitService instanceof GithubReleaser)) {
            // skip
            return;
        } else if (fileName.contains("-github")) {
            fileName = StringUtils.remove(fileName, "-github");
        }

        fileName = trimTplExtension(fileName);
        Optional<Stereotype> stereotype = resolveStereotype(fileName);
        if (stereotype.isPresent()) {
            if (distribution.getStereotype() == stereotype.get()) {
                fileName = fileName.substring(distribution.getStereotype().formatted().length() + 1);
            } else {
                // skip it
                return;
            }
        }

        Path outputFile = outputDirectory.resolve(fileName);

        if ("app.desktop".equals(fileName)) {
            outputFile = outputDirectory.resolve(distribution.getExecutable().getName() + ".desktop");
        } else if ("appdata.xml".equals(fileName)) {
            outputFile = outputDirectory.resolve(getPackager().getComponentId() + ".appdata.xml");
        }

        writeFile(content, outputFile);
    }

    @Override
    protected void writeFile(Distribution distribution, InputStream inputStream, TemplateContext props, Path outputDirectory, String fileName) throws PackagerProcessingException {
        Path outputFile = outputDirectory.resolve(fileName);

        if (fileName.endsWith("app.png")) {
            outputFile = outputDirectory.resolve(fileName.replace("app", distribution.getExecutable().getName()));
        }

        writeFile(inputStream, outputFile);
    }
}

1	/*
2	* SPDX-License-Identifier: Apache-2.0
3	*
4	* Copyright 2020-2025 The JReleaser authors.
5	*
6	* Licensed under the Apache License, Version 2.0 (the "License");
7	* you may not use this file except in compliance with the License.
8	* You may obtain a copy of the License at
9	*
10	* https://www.apache.org/licenses/LICENSE-2.0
11	*
12	* Unless required by applicable law or agreed to in writing, software
13	* distributed under the License is distributed on an "AS IS" BASIS,
14	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15	* See the License for the specific language governing permissions and
16	* limitations under the License.
17	*/
18	package org.jreleaser.packagers;
19
20	import org.apache.commons.lang3.StringUtils;
21	import org.jreleaser.bundle.RB;
22	import org.jreleaser.engine.release.Releasers;
23	import org.jreleaser.model.Stereotype;
24	import org.jreleaser.model.internal.JReleaserContext;
25	import org.jreleaser.model.internal.common.Screenshot;
26	import org.jreleaser.model.internal.distributions.Distribution;
27	import org.jreleaser.model.internal.packagers.AppImagePackager;
28	import org.jreleaser.model.internal.release.BaseReleaser;
29	import org.jreleaser.model.internal.release.GithubReleaser;
30	import org.jreleaser.model.internal.release.Releaser;
31	import org.jreleaser.model.spi.packagers.PackagerProcessingException;
32	import org.jreleaser.mustache.TemplateContext;
33
34	import java.io.IOException;
35	import java.io.InputStream;
36	import java.nio.file.Path;
37	import java.util.Optional;
38
39	import static java.util.stream.Collectors.toList;
40	import static org.jreleaser.model.Constants.KEY_APPIMAGE_CATEGORIES;
41	import static org.jreleaser.model.Constants.KEY_APPIMAGE_CATEGORIES_BY_COMMA;
42	import static org.jreleaser.model.Constants.KEY_APPIMAGE_COMPONENT_ID;
43	import static org.jreleaser.model.Constants.KEY_APPIMAGE_DEVELOPER_ID;
44	import static org.jreleaser.model.Constants.KEY_APPIMAGE_DEVELOPER_NAME;
45	import static org.jreleaser.model.Constants.KEY_APPIMAGE_DISTRIBUTION_ARTIFACT_FILE;
46	import static org.jreleaser.model.Constants.KEY_APPIMAGE_DISTRIBUTION_ARTIFACT_FILE_NAME;
47	import static org.jreleaser.model.Constants.KEY_APPIMAGE_DISTRIBUTION_URL;
48	import static org.jreleaser.model.Constants.KEY_APPIMAGE_ICONS;
49	import static org.jreleaser.model.Constants.KEY_APPIMAGE_RELEASES;
50	import static org.jreleaser.model.Constants.KEY_APPIMAGE_REPOSITORY_NAME;
51	import static org.jreleaser.model.Constants.KEY_APPIMAGE_REPOSITORY_OWNER;
52	import static org.jreleaser.model.Constants.KEY_APPIMAGE_REPO_NAME;
53	import static org.jreleaser.model.Constants.KEY_APPIMAGE_REPO_OWNER;
54	import static org.jreleaser.model.Constants.KEY_APPIMAGE_REQUIRES_TERMINAL;
55	import static org.jreleaser.model.Constants.KEY_APPIMAGE_SCREENSHOTS;
56	import static org.jreleaser.model.Constants.KEY_APPIMAGE_URLS;
57	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_FILE;
58	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_ARTIFACT_FILE_NAME;
59	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_JAVA_MAIN_CLASS;
60	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_JAVA_MAIN_MODULE;
61	import static org.jreleaser.model.Constants.KEY_DISTRIBUTION_URL;
62	import static org.jreleaser.model.Constants.KEY_PROJECT_AUTHORS;
63	import static org.jreleaser.packagers.AppdataUtils.isReleaseIncluded;
64	import static org.jreleaser.packagers.AppdataUtils.resolveIcons;
65	import static org.jreleaser.templates.TemplateUtils.trimTplExtension;
66
67	/**
68	* @author Andres Almiray
69	* @since 1.2.0
70	*/
71	public class AppImagePackagerProcessor extends AbstractRepositoryPackagerProcessor<AppImagePackager> {
72	public AppImagePackagerProcessor(JReleaserContext context) {
73	super(context);	1✔
74	}	1✔
75
76	@Override
77	protected void doPrepareDistribution(Distribution distribution, TemplateContext props) throws PackagerProcessingException {
78	setupPrepare(distribution, props);	×
79	super.doPrepareDistribution(distribution, props);	×
80	}	×
81
82	@Override
83	protected void doPackageDistribution(Distribution distribution, TemplateContext props, Path packageDirectory) throws PackagerProcessingException {
84	super.doPackageDistribution(distribution, props, packageDirectory);	×
85	copyPreparedFiles(props);	×
86	}	×
87
88	private void setupPrepare(Distribution distribution, TemplateContext props) throws PackagerProcessingException {
89	BaseReleaser<?, ?> releaser = context.getModel().getRelease().getReleaser();	×
90
91	try {
92	props.set(KEY_APPIMAGE_RELEASES, Releasers.releaserFor(context)	×
93	.listReleases(releaser.getOwner(), releaser.getName()).stream()	×
94	.filter(r -> isReleaseIncluded(packager.getSkipReleases(), r.getVersion().toString()))	×
95	.map(r -> AppdataUtils.Release.of(r.getUrl(), r.getVersion().toString(), r.getPublishedAt()))	×
96	.collect(toList()));	×
97	} catch (IOException e) {	×
98	throw new PackagerProcessingException(RB.$("ERROR_unexpected_error"), e);	×
99	}	×
100
101	props.set(KEY_APPIMAGE_SCREENSHOTS, packager.getScreenshots().stream()	×
102	.map(Screenshot::asScreenshotTemplate)	×
103	.collect(toList()));	×
104
105	context.getLogger().debug(RB.$("packager.fetch.icons"));	×
106	props.set(KEY_APPIMAGE_ICONS, packager.getIcons());	×
107	resolveIcons(context, packager, distribution, props, packager.getIcons());	×
108	}	×
109
110	@Override
111	protected void fillPackagerProperties(TemplateContext props, Distribution distribution) {
112	props.set(KEY_DISTRIBUTION_JAVA_MAIN_CLASS, distribution.getJava().getMainClass());	×
113	props.set(KEY_DISTRIBUTION_JAVA_MAIN_MODULE, distribution.getJava().getMainModule());	×
114	props.set(KEY_PROJECT_AUTHORS, context.getModel().getProject().getAuthors());	×
115	props.set(KEY_APPIMAGE_URLS, context.getModel().getProject().getLinks().asLinkTemplates(false));	×
116	props.set(KEY_APPIMAGE_COMPONENT_ID, getPackager().getComponentId());	×
117	props.set(KEY_APPIMAGE_CATEGORIES, getPackager().getCategories());	×
118	props.set(KEY_APPIMAGE_CATEGORIES_BY_COMMA, String.join(",", getPackager().getCategories()));	×
119	props.set(KEY_APPIMAGE_DEVELOPER_ID, getPackager().getDeveloperId());	×
120	props.set(KEY_APPIMAGE_DEVELOPER_NAME, getPackager().getDeveloperName());	×
121	props.set(KEY_APPIMAGE_REQUIRES_TERMINAL, getPackager().isRequiresTerminal());	×
122	props.set(KEY_APPIMAGE_REPO_OWNER, packager.getRepository().getOwner());	×
123	props.set(KEY_APPIMAGE_REPO_NAME, packager.getRepository().getName());	×
124	props.set(KEY_APPIMAGE_REPOSITORY_OWNER, packager.getRepository().getOwner());	×
125	props.set(KEY_APPIMAGE_REPOSITORY_NAME, packager.getRepository().getName());	×
126
127	BaseReleaser<?, ?> releaser = context.getModel().getRelease().getReleaser();	×
128	String str = props.get(KEY_DISTRIBUTION_ARTIFACT_FILE);	×
129	str = str.replace(context.getModel().getProject().getEffectiveVersion(), "${DISTRIBUTION_VERSION}");	×
130	props.set(KEY_APPIMAGE_DISTRIBUTION_ARTIFACT_FILE, str);	×
131	str = props.get(KEY_DISTRIBUTION_ARTIFACT_FILE_NAME);	×
132	str = str.replace(context.getModel().getProject().getEffectiveVersion(), "${DISTRIBUTION_VERSION}");	×
133	props.set(KEY_APPIMAGE_DISTRIBUTION_ARTIFACT_FILE_NAME, str);	×
134	str = props.get(KEY_DISTRIBUTION_URL);	×
NEW 135	str = str.replace(releaser.getEffectiveTagName(context), "${DISTRIBUTION_TAG}")	×
136	.replace(props.get(KEY_DISTRIBUTION_ARTIFACT_FILE), "${DISTRIBUTION_FILE}");	×
137	props.set(KEY_APPIMAGE_DISTRIBUTION_URL, str);	×
138	}	×
139
140	@Override
141	protected void writeFile(Distribution distribution,
142	String content,
143	TemplateContext props,
144	Path outputDirectory,
145	String fileName) throws PackagerProcessingException {
146	Releaser<?> gitService = context.getModel().getRelease().getReleaser();	×
147	if (fileName.contains("github") && !(gitService instanceof GithubReleaser)) {	×
148	// skip
149	return;	×
150	} else if (fileName.contains("-github")) {	×
151	fileName = StringUtils.remove(fileName, "-github");	×
152	}
153
154	fileName = trimTplExtension(fileName);	×
155	Optional<Stereotype> stereotype = resolveStereotype(fileName);	×
156	if (stereotype.isPresent()) {	×
157	if (distribution.getStereotype() == stereotype.get()) {	×
158	fileName = fileName.substring(distribution.getStereotype().formatted().length() + 1);	×
159	} else {
160	// skip it
161	return;	×
162	}
163	}
164
165	Path outputFile = outputDirectory.resolve(fileName);	×
166
167	if ("app.desktop".equals(fileName)) {	×
168	outputFile = outputDirectory.resolve(distribution.getExecutable().getName() + ".desktop");	×
169	} else if ("appdata.xml".equals(fileName)) {	×
170	outputFile = outputDirectory.resolve(getPackager().getComponentId() + ".appdata.xml");	×
171	}
172
173	writeFile(content, outputFile);	×
174	}	×
175
176	@Override
177	protected void writeFile(Distribution distribution, InputStream inputStream, TemplateContext props, Path outputDirectory, String fileName) throws PackagerProcessingException {
178	Path outputFile = outputDirectory.resolve(fileName);	×
179
180	if (fileName.endsWith("app.png")) {	×
181	outputFile = outputDirectory.resolve(fileName.replace("app", distribution.getExecutable().getName()));	×
182	}
183
184	writeFile(inputStream, outputFile);	×
185	}	×
186	}

jreleaser / jreleaser / #558

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous