gcivil-nyu-org / team4-wed-fall25 / 112

Committed 07 Dec 2025 03:22AM UTC coverage: 91.325% (+0.5%) from 90.869%

Build # 112

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Merge pull request #111 from gcivil-nyu-org/fix/imp_issues

fixed all the issues

Run Details

42 of 68 new or added lines in 4 files covered. (61.76%)

1 existing line in 1 file now uncovered.

2095 of 2294 relevant lines covered (91.33%)

0.91 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.89

/note2webapp/decorators.py

from functools import wraps

from django.contrib import messages
from django.contrib.auth.decorators import login_required
from django.shortcuts import redirect


def role_required(*allowed_roles):
    """
    Decorator that:
    - requires the user to be logged in
    - checks that user.profile.role is in allowed_roles
    - otherwise redirects them to the main dashboard
    """
    allowed_roles = set(allowed_roles)

    def decorator(view_func):
        @wraps(view_func)
        @login_required
        def _wrapped_view(request, *args, **kwargs):
            profile = getattr(request.user, "profile", None)
            role = getattr(profile, "role", None)

            if role not in allowed_roles:
                messages.error(
                    request,
                    "You do not have permission to access that page.",
                )
                return redirect("dashboard")  # send them to their own dashboard

            return view_func(request, *args, **kwargs)

        return _wrapped_view

    return decorator

1	from functools import wraps	1✔
2
3	from django.contrib import messages	1✔
4	from django.contrib.auth.decorators import login_required	1✔
5	from django.shortcuts import redirect	1✔
6
7
8	def role_required(*allowed_roles):	1✔
9	"""
10	Decorator that:
11	- requires the user to be logged in
12	- checks that user.profile.role is in allowed_roles
13	- otherwise redirects them to the main dashboard
14	"""
15	allowed_roles = set(allowed_roles)	1✔
16
17	def decorator(view_func):	1✔
18	@wraps(view_func)	1✔
19	@login_required	1✔
20	def _wrapped_view(request, args, *kwargs):	1✔
21	profile = getattr(request.user, "profile", None)	1✔
22	role = getattr(profile, "role", None)	1✔
23
24	if role not in allowed_roles:	1✔
NEW 25	messages.error(	×
26	request,
27	"You do not have permission to access that page.",
28	)
NEW 29	return redirect("dashboard") # send them to their own dashboard	×
30
31	return view_func(request, args, *kwargs)	1✔
32
33	return _wrapped_view	1✔
34
35	return decorator	1✔

gcivil-nyu-org / team4-wed-fall25 / 112

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous