19992174439

Committed 06 Dec 2025 05:56PM UTC coverage: 58.742% (-0.005%) from 58.747%

Build # 19992174439

Build Type

Pull #1118

github

Committed by

web-flow

Commit Message

Merge d1d251ac8 into 45a8cb1c3

Pull Request Pull Request #1118: Reduce/cordon bloat in facet, introduce bloatbench

Run Details

1138 of 3103 new or added lines in 61 files covered. (36.67%)

540 existing lines in 30 files now uncovered.

24225 of 41240 relevant lines covered (58.74%)

502.5 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

53.4

/facet-core/src/impls_bytes.rs

use core::ptr::NonNull;

use alloc::boxed::Box;

use bytes::{BufMut as _, Bytes, BytesMut};

use crate::{
    Def, Facet, IterVTable, ListDef, ListVTable, PtrConst, PtrMut, PtrUninit, Shape, Type,
    UserType, value_vtable,
};

type BytesIterator<'mem> = core::slice::Iter<'mem, u8>;

unsafe impl Facet<'_> for Bytes {
    const SHAPE: &'static Shape = &const {
        Shape {
            id: Shape::id_of::<Self>(),
            layout: Shape::layout_of::<Self>(),
            vtable: {
                let mut vtable = value_vtable!(Bytes, |f, _opts| write!(
                    f,
                    "{}",
                    Self::SHAPE.type_identifier
                ));
                {
                    vtable.try_from = {
                        Some(
                            |source: PtrConst, source_shape: &Shape, target: PtrUninit| {
                                if source_shape.is_type::<BytesMut>() {
                                    let source = unsafe { source.read::<BytesMut>() };
                                    let bytes = source.freeze();
                                    Ok(unsafe { target.put(bytes) })
                                } else {
                                    Err(crate::TryFromError::UnsupportedSourceShape {
                                        src_shape: source_shape,
                                        expected: &[Bytes::SHAPE],
                                    })
                                }
                            },
                        )
                    };
                }

                vtable
            },
            ty: Type::User(UserType::Opaque),
            def: Def::List(ListDef::new(
                &const {
                    ListVTable {
                        init_in_place_with_capacity: None,
                        push: None,
                        len: |ptr| unsafe {
                            let bytes = ptr.get::<Self>();
                            bytes.len()
                        },
                        get: |ptr, index| unsafe {
                            let bytes = ptr.get::<Self>();
                            let item = bytes.get(index)?;
                            Some(PtrConst::new(item.into()))
                        },
                        get_mut: None,
                        as_ptr: Some(|ptr| unsafe {
                            let bytes: &Self = ptr.get::<Self>();
                            PtrConst::new(core::ptr::NonNull::new_unchecked(
                                bytes.as_ptr() as *mut u8
                            ))
                        }),
                        as_mut_ptr: None,
                        iter_vtable: IterVTable {
                            init_with_value: Some(|ptr| unsafe {
                                let bytes = ptr.get::<Self>();
                                let iter: BytesIterator = bytes.iter();
                                let iter_state = Box::new(iter);
                                PtrMut::new(NonNull::new_unchecked(
                                    Box::into_raw(iter_state) as *mut u8
                                ))
                            }),
                            next: |iter_ptr| unsafe {
                                let state = iter_ptr.as_mut::<BytesIterator<'_>>();
                                state.next().map(|value| PtrConst::new(value.into()))
                            },
                            next_back: Some(|iter_ptr| unsafe {
                                let state = iter_ptr.as_mut::<BytesIterator<'_>>();
                                state.next_back().map(|value| PtrConst::new(value.into()))
                            }),
                            size_hint: None,
                            dealloc: |iter_ptr| unsafe {
                                drop(Box::from_raw(iter_ptr.as_ptr::<BytesIterator<'_>>()
                                    as *mut BytesIterator<'_>));
                            },
                        },
                    }
                },
                u8::SHAPE,
            )),
            type_identifier: "Bytes",
            type_params: &[],
            doc: &[],
            attributes: &[],
            type_tag: None,
            inner: Some(BytesMut::SHAPE),
        }
    };
}

unsafe impl Facet<'_> for BytesMut {
    const SHAPE: &'static Shape = &const {
        Shape {
            id: Shape::id_of::<Self>(),
            layout: Shape::layout_of::<Self>(),
            vtable: value_vtable!(BytesMut, |f, _opts| write!(
                f,
                "{}",
                Self::SHAPE.type_identifier
            )),
            ty: Type::User(UserType::Opaque),
            def: Def::List(ListDef::new(
                &const {
                    ListVTable {
                        init_in_place_with_capacity: Some(|data, capacity| unsafe {
                            data.put(Self::with_capacity(capacity))
                        }),
                        push: Some(|ptr, item| unsafe {
                            let bytes = ptr.as_mut::<Self>();
                            let item = item.read::<u8>();
                            (*bytes).put_u8(item);
                        }),
                        len: |ptr| unsafe {
                            let bytes = ptr.get::<Self>();
                            bytes.len()
                        },
                        get: |ptr, index| unsafe {
                            let bytes = ptr.get::<Self>();
                            let item = bytes.get(index)?;
                            Some(PtrConst::new(item.into()))
                        },
                        get_mut: Some(|ptr, index| unsafe {
                            let bytes = ptr.as_mut::<Self>();
                            let item = bytes.get_mut(index)?;
                            Some(PtrMut::new(item.into()))
                        }),
                        as_ptr: Some(|ptr| unsafe {
                            let bytes = ptr.get::<Self>();
                            PtrConst::new(core::ptr::NonNull::new_unchecked(
                                bytes.as_ptr() as *mut u8
                            ))
                        }),
                        as_mut_ptr: Some(|ptr| unsafe {
                            let bytes = ptr.as_mut::<Self>();
                            PtrMut::new(core::ptr::NonNull::new_unchecked(bytes.as_mut_ptr()))
                        }),
                        iter_vtable: IterVTable {
                            init_with_value: Some(|ptr| unsafe {
                                let bytes = ptr.get::<Self>();
                                let iter: BytesIterator = bytes.iter();
                                let iter_state = Box::new(iter);
                                PtrMut::new(NonNull::new_unchecked(
                                    Box::into_raw(iter_state) as *mut u8
                                ))
                            }),
                            next: |iter_ptr| unsafe {
                                let state = iter_ptr.as_mut::<BytesIterator<'_>>();
                                state.next().map(|value| PtrConst::new(value.into()))
                            },
                            next_back: Some(|iter_ptr| unsafe {
                                let state = iter_ptr.as_mut::<BytesIterator<'_>>();
                                state.next_back().map(|value| PtrConst::new(value.into()))
                            }),
                            size_hint: None,
                            dealloc: |iter_ptr| unsafe {
                                drop(Box::from_raw(iter_ptr.as_ptr::<BytesIterator<'_>>()
                                    as *mut BytesIterator<'_>));
                            },
                        },
                    }
                },
                u8::SHAPE,
            )),
            type_identifier: "BytesMut",
            type_params: &[],
            doc: &[],
            attributes: &[],
            type_tag: None,
            inner: None,
        }
    };
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_as_ptr() {
        let bytes = Bytes::from(vec![0, 1, 2, 3, 4]);
        let expected = bytes.as_ptr();
        let Def::List(def) = Bytes::SHAPE.def else {
            panic!()
        };
        let actual =
            unsafe { (def.vtable.as_ptr).unwrap()(PtrConst::new((&bytes).into())) }.as_byte_ptr();
        assert_eq!(expected, actual);
    }

    #[test]
    fn test_as_ptr_mut() {
        let bytes = Bytes::from(vec![0, 1, 2, 3, 4]);
        let mut bytes = BytesMut::from(bytes);
        let expected = bytes.as_ptr();
        let Def::List(def) = BytesMut::SHAPE.def else {
            panic!()
        };
        let actual =
            unsafe { (def.vtable.as_ptr).unwrap()(PtrConst::new((&bytes).into())) }.as_byte_ptr();
        assert_eq!(expected, actual);

        let actual = unsafe { (def.vtable.as_mut_ptr).unwrap()(PtrMut::new((&mut bytes).into())) }
            .as_byte_ptr();
        assert_eq!(expected, actual);
    }
}

1	use core::ptr::NonNull;
2
3	use alloc::boxed::Box;
4
5	use bytes::{BufMut as _, Bytes, BytesMut};
6
7	use crate::{
8	Def, Facet, IterVTable, ListDef, ListVTable, PtrConst, PtrMut, PtrUninit, Shape, Type,
9	UserType, value_vtable,
10	};
11
12	type BytesIterator<'mem> = core::slice::Iter<'mem, u8>;
13
14	unsafe impl Facet<'_> for Bytes {
15	const SHAPE: &'static Shape = &const {
16	Shape {
17	id: Shape::id_of::<Self>(),
18	layout: Shape::layout_of::<Self>(),
19	vtable: {
20	let mut vtable = value_vtable!(Bytes, \|f, _opts\| write!(	2✔
21	f,	2✔
22	"{}",
23	Self::SHAPE.type_identifier	2✔
24	));
25	{
26	vtable.try_from = {
27	Some(
28	\|source: PtrConst, source_shape: &Shape, target: PtrUninit\| {	1✔
29	if source_shape.is_type::<BytesMut>() {	1✔
30	let source = unsafe { source.read::<BytesMut>() };	1✔
31	let bytes = source.freeze();	1✔
32	Ok(unsafe { target.put(bytes) })	1✔
33	} else {
34	Err(crate::TryFromError::UnsupportedSourceShape {	×
35	src_shape: source_shape,	×
36	expected: &[Bytes::SHAPE],	×
37	})	×
38	}
39	},	1✔
40	)
41	};
42	}
43
44	vtable
45	},
46	ty: Type::User(UserType::Opaque),
47	def: Def::List(ListDef::new(
48	&const {
49	ListVTable {
50	init_in_place_with_capacity: None,
51	push: None,
52	len: \|ptr\| unsafe {
53	let bytes = ptr.get::<Self>();	1✔
54	bytes.len()	1✔
55	},	1✔
56	get: \|ptr, index\| unsafe {
NEW 57	let bytes = ptr.get::<Self>();	×
NEW 58	let item = bytes.get(index)?;	×
NEW 59	Some(PtrConst::new(item.into()))	×
NEW 60	},	×
61	get_mut: None,
62	as_ptr: Some(\|ptr\| unsafe {
63	let bytes: &Self = ptr.get::<Self>();	2✔
64	PtrConst::new(core::ptr::NonNull::new_unchecked(	2✔
65	bytes.as_ptr() as *mut u8	2✔
66	))
67	}),	2✔
68	as_mut_ptr: None,
69	iter_vtable: IterVTable {
70	init_with_value: Some(\|ptr\| unsafe {
NEW 71	let bytes = ptr.get::<Self>();	×
NEW 72	let iter: BytesIterator = bytes.iter();	×
NEW 73	let iter_state = Box::new(iter);	×
NEW 74	PtrMut::new(NonNull::new_unchecked(	×
NEW 75	Box::into_raw(iter_state) as *mut u8	×
76	))
NEW 77	}),	×
78	next: \|iter_ptr\| unsafe {
NEW 79	let state = iter_ptr.as_mut::<BytesIterator<'_>>();	×
NEW 80	state.next().map(\|value\| PtrConst::new(value.into()))	×
NEW 81	},	×
82	next_back: Some(\|iter_ptr\| unsafe {
NEW 83	let state = iter_ptr.as_mut::<BytesIterator<'_>>();	×
NEW 84	state.next_back().map(\|value\| PtrConst::new(value.into()))	×
NEW 85	}),	×
86	size_hint: None,
87	dealloc: \|iter_ptr\| unsafe {
NEW 88	drop(Box::from_raw(iter_ptr.as_ptr::<BytesIterator<'_>>()	×
NEW 89	as *mut BytesIterator<'_>));	×
NEW 90	},	×
91	},
92	}
93	},
94	u8::SHAPE,
95	)),
96	type_identifier: "Bytes",
97	type_params: &[],
98	doc: &[],
99	attributes: &[],
100	type_tag: None,
101	inner: Some(BytesMut::SHAPE),
102	}
103	};
104	}
105
106	unsafe impl Facet<'_> for BytesMut {
107	const SHAPE: &'static Shape = &const {
108	Shape {
109	id: Shape::id_of::<Self>(),
110	layout: Shape::layout_of::<Self>(),
111	vtable: value_vtable!(BytesMut, \|f, _opts\| write!(	2✔
112	f,	2✔
113	"{}",
114	Self::SHAPE.type_identifier	2✔
115	)),
116	ty: Type::User(UserType::Opaque),
117	def: Def::List(ListDef::new(
118	&const {
119	ListVTable {
120	init_in_place_with_capacity: Some(\|data, capacity\| unsafe {
121	data.put(Self::with_capacity(capacity))	2✔
122	}),	2✔
123	push: Some(\|ptr, item\| unsafe {
124	let bytes = ptr.as_mut::<Self>();	10✔
125	let item = item.read::<u8>();	10✔
126	(*bytes).put_u8(item);	10✔
127	}),	10✔
128	len: \|ptr\| unsafe {
129	let bytes = ptr.get::<Self>();	1✔
130	bytes.len()	1✔
131	},	1✔
132	get: \|ptr, index\| unsafe {
NEW 133	let bytes = ptr.get::<Self>();	×
NEW 134	let item = bytes.get(index)?;	×
NEW 135	Some(PtrConst::new(item.into()))	×
NEW 136	},	×
137	get_mut: Some(\|ptr, index\| unsafe {
NEW 138	let bytes = ptr.as_mut::<Self>();	×
NEW 139	let item = bytes.get_mut(index)?;	×
NEW 140	Some(PtrMut::new(item.into()))	×
NEW 141	}),	×
142	as_ptr: Some(\|ptr\| unsafe {
143	let bytes = ptr.get::<Self>();	2✔
144	PtrConst::new(core::ptr::NonNull::new_unchecked(	2✔
145	bytes.as_ptr() as *mut u8	2✔
146	))
147	}),	2✔
148	as_mut_ptr: Some(\|ptr\| unsafe {
149	let bytes = ptr.as_mut::<Self>();	1✔
150	PtrMut::new(core::ptr::NonNull::new_unchecked(bytes.as_mut_ptr()))	1✔
151	}),	1✔
152	iter_vtable: IterVTable {
153	init_with_value: Some(\|ptr\| unsafe {
NEW 154	let bytes = ptr.get::<Self>();	×
NEW 155	let iter: BytesIterator = bytes.iter();	×
NEW 156	let iter_state = Box::new(iter);	×
NEW 157	PtrMut::new(NonNull::new_unchecked(	×
NEW 158	Box::into_raw(iter_state) as *mut u8	×
159	))
NEW 160	}),	×
161	next: \|iter_ptr\| unsafe {
NEW 162	let state = iter_ptr.as_mut::<BytesIterator<'_>>();	×
NEW 163	state.next().map(\|value\| PtrConst::new(value.into()))	×
NEW 164	},	×
165	next_back: Some(\|iter_ptr\| unsafe {
NEW 166	let state = iter_ptr.as_mut::<BytesIterator<'_>>();	×
NEW 167	state.next_back().map(\|value\| PtrConst::new(value.into()))	×
NEW 168	}),	×
169	size_hint: None,
170	dealloc: \|iter_ptr\| unsafe {
NEW 171	drop(Box::from_raw(iter_ptr.as_ptr::<BytesIterator<'_>>()	×
NEW 172	as *mut BytesIterator<'_>));	×
NEW 173	},	×
174	},
175	}
176	},
177	u8::SHAPE,
178	)),
179	type_identifier: "BytesMut",
180	type_params: &[],
181	doc: &[],
182	attributes: &[],
183	type_tag: None,
184	inner: None,
185	}
186	};
187	}
188
189	#[cfg(test)]
190	mod tests {
191	use super::*;
192
193	#[test]
194	fn test_as_ptr() {	1✔
195	let bytes = Bytes::from(vec![0, 1, 2, 3, 4]);	1✔
196	let expected = bytes.as_ptr();	1✔
197	let Def::List(def) = Bytes::SHAPE.def else {	1✔
198	panic!()	×
199	};
200	let actual =	1✔
201	unsafe { (def.vtable.as_ptr).unwrap()(PtrConst::new((&bytes).into())) }.as_byte_ptr();	1✔
202	assert_eq!(expected, actual);	1✔
203	}	1✔
204
205	#[test]
206	fn test_as_ptr_mut() {	1✔
207	let bytes = Bytes::from(vec![0, 1, 2, 3, 4]);	1✔
208	let mut bytes = BytesMut::from(bytes);	1✔
209	let expected = bytes.as_ptr();	1✔
210	let Def::List(def) = BytesMut::SHAPE.def else {	1✔
211	panic!()	×
212	};
213	let actual =	1✔
214	unsafe { (def.vtable.as_ptr).unwrap()(PtrConst::new((&bytes).into())) }.as_byte_ptr();	1✔
215	assert_eq!(expected, actual);	1✔
216
217	let actual = unsafe { (def.vtable.as_mut_ptr).unwrap()(PtrMut::new((&mut bytes).into())) }	1✔
218	.as_byte_ptr();	1✔
219	assert_eq!(expected, actual);	1✔
220	}	1✔
221	}

facet-rs / facet / 19992174439

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous