19973536637

Committed 05 Dec 2025 07:18PM UTC coverage: 81.336% (+0.08%) from 81.254%

Build # 19973536637

Build Type

push

github

Committed by

web-flow

Commit Message

Refactor SlippiGame to be web-compatible by default (#150)

* use EventTarget instead of event emitter

* fix event emitter shim

* stop using EventEmitter in stats

* it works!

* fix imports and typings

* create two distinct index.ts files for the different environments

* dont use accessor cuz it causes issues or something

* i think this actually works

* use cross env for windows env

* add node subpath to exports

* i think it actually works

* dts is not very configurable so use rollup directly instead

* don't hardcode filenames

* fix lint not working

* update readme to include distinction between web and node exports

* update example to use the node export

* fix windows builds

* separate common from other node exports

* i dont think slpReader should actually be exported

* for typesafety, don't accept string as input on the web

* remove unused dependency

* chore: fix eslint error

* minify for production

* chore(deps): remove unused lodash-es dependency

* chore(deps): remove tslib dependency

* reduce duplication

* reorganise structure

* try to fix windows build

* simplify build config

* add old style exports for backwards compatibility

* simplify browser constructor

* rename node/nodeUtils to just node/utils

* fix lint

* update error message with explicit node import path

* fix missing ws dependency issue with enet

* update package-lock.json

* update date-fns to match launcher version

* simplify buffer input ref creation

* make slpstream web-first

* fix issue with slp parsing expecting a frame

* create a single TextDecoder

* use .subarray() instead of .slice() where possible

* rename TypedEventTarget -> TypedEventEmitter

* try to fix build taking forever

* simplify TypedEventEmitter

* make node event emitters also type-safe

* add a once() method to event emitter

* deps: see if upgrading deps fixes random macos hangs

* working abstract class impl

* add missing getFilePath override

* bundle ubjson with requi... (continued)

Run Details

694 of 928 branches covered (74.78%)

Branch coverage included in aggregate %.

158 of 178 new or added lines in 16 files covered. (88.76%)

1960 of 2335 relevant lines covered (83.94%)

119971.77 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

88.24

/src/node/SlippiGameNode.ts

import { SlippiGameBase } from "../common/SlippiGameBase";
import type { StatOptions } from "../common/stats";
import { type BinaryLike, isBufferLike } from "../common/utils/bufferHelpers";
import { SlpBufferInputRef } from "../common/utils/slpInputRef";
import { SlpFileInputRef } from "./utils/slpFileInputRef";

export class SlippiGameNode extends SlippiGameBase {
  private readonly filePath: string | null;

  public constructor(input: string | BinaryLike, opts?: StatOptions) {
    if (typeof input === "string") {
      super(new SlpFileInputRef(input), opts);
      this.filePath = input;
    } else if (isBufferLike(input)) {
      super(new SlpBufferInputRef(input), opts);
      this.filePath = null;
    } else {
      throw new Error("Cannot create SlippiGame with input of that type");
    }
  }

  public override getFilePath(): string | null {
    return this.filePath;
  }
}

1	import { SlippiGameBase } from "../common/SlippiGameBase";	12✔
2	import type { StatOptions } from "../common/stats";
3	import { type BinaryLike, isBufferLike } from "../common/utils/bufferHelpers";	12✔
4	import { SlpBufferInputRef } from "../common/utils/slpInputRef";	12✔
5	import { SlpFileInputRef } from "./utils/slpFileInputRef";	12✔
6
7	export class SlippiGameNode extends SlippiGameBase {	12✔
8	private readonly filePath: string \| null;
9
10	public constructor(input: string \| BinaryLike, opts?: StatOptions) {
11	if (typeof input === "string") {	79✔
12	super(new SlpFileInputRef(input), opts);	75✔
13	this.filePath = input;	75✔
14	} else if (isBufferLike(input)) {	4!
15	super(new SlpBufferInputRef(input), opts);	4✔
16	this.filePath = null;	4✔
17	} else {
NEW 18	throw new Error("Cannot create SlippiGame with input of that type");	×
19	}
20	}
21
22	public override getFilePath(): string \| null {
23	return this.filePath;	2✔
24	}
25	}

project-slippi / slippi-js / 19973536637

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous