9c5c59d1-3953-4cfa-81d2-86bdb0986555

Committed 03 Dec 2025 07:02PM UTC coverage: 91.319% (+20.0%) from 71.313%

Build # 9c5c59d1-3953-4cfa-81d2-86bdb0986555

Build Type

push

circleci

Committed by

web-flow

Commit Message

Allow requested by or approved by information to be empty (#2267)

There are no tests yet, but the detail page may not load for you (like
it did not load for me)

Run Details

30 of 36 new or added lines in 3 files covered. (83.33%)

710 existing lines in 42 files now uncovered.

2956 of 3237 relevant lines covered (91.32%)

698.45 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/app/models/project_validator.rb

class ProjectValidator < ActiveModel::Validator
    def validate(project)
        @schema = TigerdataSchema.new(namespace: "tigerdata", type: "tigerdata:project")

        # we need this because this method references the metadata_json which is not updated until the project is saved
        project.metadata = project.metadata_model

        # Required fields, always validate
        validate_role(project:, netid: project.metadata_model.data_manager, role: "Data Manager")
        validate_role(project:, netid: project.metadata_model.data_sponsor, role: "Data Sponsor")

        # Validate if present
        project.metadata_model.data_user_read_only&.each { |read_only| validate_role(project:, netid: read_only, role: "Data User Read Only")}
        project.metadata_model.data_user_read_write&.each { |read_write| validate_role(project:, netid: read_write, role: "Data User Read Write")}

        # validate all required fields
        required_metadata_field_errors = []
        required_metadata = required_attributes(project:)
        if required_metadata.values.include?(nil)
            required_keys.each do |attr|
                value = required_metadata[attr]
                required_metadata_field_errors << "Missing metadata value for #{attr}" if value.nil? && project.metadata_json.include?(attr)
            end
        end
        if required_metadata_field_errors.count > 0
            project.errors.add :base, "Invalid Project Metadata it does not match the schema #{TigerdataSchema::SCHEMA_VERSION}\n #{required_metadata_field_errors.join(", ")}"
        end
    end

    private

    def validate_role(project:, netid:, role:)
        if netid.blank?
            project.errors.add :base, "Missing netid for role #{role}"
        elsif User.where(uid: netid).empty?
            project.errors.add :base, "Invalid netid: #{netid} for role #{role}"
        end
    end

    def required_field_labels
        @schema.required_project_schema_fields.pluck(:name)
    end

    def required_keys
        tableized = required_field_labels.map { |v| v.underscore }
        tableized
    end

    def required_attributes(project:)
        project.metadata_json.select { |k, _v| required_keys.include?(k) }
    end

end

1	class ProjectValidator < ActiveModel::Validator	5✔
2	def validate(project)	5✔
3	@schema = TigerdataSchema.new(namespace: "tigerdata", type: "tigerdata:project")	1,791✔
4
5	# we need this because this method references the metadata_json which is not updated until the project is saved
6	project.metadata = project.metadata_model	1,791✔
7
8	# Required fields, always validate
9	validate_role(project:, netid: project.metadata_model.data_manager, role: "Data Manager")	1,791✔
10	validate_role(project:, netid: project.metadata_model.data_sponsor, role: "Data Sponsor")	1,791✔
11
12	# Validate if present
13	project.metadata_model.data_user_read_only&.each { \|read_only\| validate_role(project:, netid: read_only, role: "Data User Read Only")}	2,096✔
14	project.metadata_model.data_user_read_write&.each { \|read_write\| validate_role(project:, netid: read_write, role: "Data User Read Write")}	1,872✔
15
16	# validate all required fields
17	required_metadata_field_errors = []	1,791✔
18	required_metadata = required_attributes(project:)	1,791✔
19	if required_metadata.values.include?(nil)	1,791✔
20	required_keys.each do \|attr\|	7✔
21	value = required_metadata[attr]	49✔
22	required_metadata_field_errors << "Missing metadata value for #{attr}" if value.nil? && project.metadata_json.include?(attr)	49✔
23	end
24	end
25	if required_metadata_field_errors.count > 0	1,791✔
26	project.errors.add :base, "Invalid Project Metadata it does not match the schema #{TigerdataSchema::SCHEMA_VERSION}\n #{required_metadata_field_errors.join(", ")}"	7✔
27	end
28	end
29
30	private	5✔
31
32	def validate_role(project:, netid:, role:)	5✔
33	if netid.blank?	3,968✔
UNCOV 34	project.errors.add :base, "Missing netid for role #{role}"	5✔
35	elsif User.where(uid: netid).empty?	3,963✔
36	project.errors.add :base, "Invalid netid: #{netid} for role #{role}"	42✔
37	end
38	end
39
40	def required_field_labels	5✔
41	@schema.required_project_schema_fields.pluck(:name)	44,883✔
42	end
43
44	def required_keys	5✔
45	tableized = required_field_labels.map { \|v\| v.underscore }	359,064✔
46	tableized	44,883✔
47	end
48
49	def required_attributes(project:)	5✔
50	project.metadata_json.select { \|k, _v\| required_keys.include?(k) }	46,667✔
51	end
52
53	end

pulibrary / tigerdata-app / 9c5c59d1-3953-4cfa-81d2-86bdb0986555

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous