• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4868

26 Nov 2025 05:46AM UTC coverage: 64.629% (+0.2%) from 64.473%
#4868

push

travis-ci

guanshengliang
Merge branch '3.0' into cover/3.0

770 of 945 new or added lines in 33 files covered. (81.48%)

3010 existing lines in 120 files now uncovered.

158425 of 245129 relevant lines covered (64.63%)

113048242.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

81.19
/source/dnode/mnode/impl/src/mndCompactDetail.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15
#include "mndCompactDetail.h"
16
#include "mndDb.h"
17
#include "mndShow.h"
18
#include "mndTrans.h"
19

20
#define MND_COMPACT_DETAIL_VER_NUMBER 1
21

22
int32_t mndInitCompactDetail(SMnode *pMnode) {
484,929✔
23
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_COMPACT_DETAIL, mndRetrieveCompactDetail);
484,929✔
24

25
  SSdbTable table = {
484,929✔
26
      .sdbType = SDB_COMPACT_DETAIL,
27
      .keyType = SDB_KEY_INT64,
28
      .encodeFp = (SdbEncodeFp)mndCompactDetailActionEncode,
29
      .decodeFp = (SdbDecodeFp)mndCompactDetailActionDecode,
30
      .insertFp = (SdbInsertFp)mndCompactDetailActionInsert,
31
      .updateFp = (SdbUpdateFp)mndCompactDetailActionUpdate,
32
      .deleteFp = (SdbDeleteFp)mndCompactDetailActionDelete,
33
  };
34

35
  return sdbSetTable(pMnode->pSdb, table);
484,929✔
36
}
37

38
void mndCleanupCompactDetail(SMnode *pMnode) { mDebug("mnd compact detail cleanup"); }
484,151✔
39

40
int32_t mndRetrieveCompactDetail(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
19,754✔
41
  SMnode            *pMnode = pReq->info.node;
19,754✔
42
  SSdb              *pSdb = pMnode->pSdb;
19,754✔
43
  int32_t            numOfRows = 0;
19,754✔
44
  SCompactDetailObj *pCompactDetail = NULL;
19,754✔
45
  char              *sep = NULL;
19,754✔
46
  SDbObj            *pDb = NULL;
19,754✔
47

48
  mInfo("retrieve compact detail");
19,754✔
49

50
  if (strlen(pShow->db) > 0) {
19,754✔
51
    sep = strchr(pShow->db, '.');
×
52
    if (sep &&
×
53
        ((0 == strcmp(sep + 1, TSDB_INFORMATION_SCHEMA_DB) || (0 == strcmp(sep + 1, TSDB_PERFORMANCE_SCHEMA_DB))))) {
×
54
      sep++;
×
55
    } else {
56
      pDb = mndAcquireDb(pMnode, pShow->db);
×
57
      if (pDb == NULL) return terrno;
×
58
    }
59
  }
60

61
  while (numOfRows < rows) {
54,070✔
62
    pShow->pIter = sdbFetch(pSdb, SDB_COMPACT_DETAIL, pShow->pIter, (void **)&pCompactDetail);
54,070✔
63
    if (pShow->pIter == NULL) break;
54,070✔
64

65
    SColumnInfoData *pColInfo;
66
    SName            n;
67
    int32_t          cols = 0;
34,316✔
68

69
    char tmpBuf[TSDB_SHOW_SQL_LEN + VARSTR_HEADER_SIZE] = {0};
34,316✔
70

71
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,316✔
72
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->compactId, false),
34,316✔
73
                                   pSdb, pCompactDetail);
74

75
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,316✔
76
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->vgId, false), pSdb,
34,316✔
77
                                   pCompactDetail);
78

79
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,316✔
80
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->dnodeId, false),
34,316✔
81
                                   pSdb, pCompactDetail);
82

83
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,316✔
84
    TAOS_CHECK_RETURN_WITH_RELEASE(
34,316✔
85
        colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->numberFileset, false), pSdb, pCompactDetail);
86

87
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,316✔
88
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->finished, false),
34,316✔
89
                                   pSdb, pCompactDetail);
90

91
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,316✔
92
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->startTime, false),
34,316✔
93
                                   pSdb, pCompactDetail);
94

95
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,316✔
96
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->progress, false),
34,316✔
97
                                   pSdb, pCompactDetail);
98

99
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
34,316✔
100
    TAOS_CHECK_RETURN_WITH_RELEASE(
34,316✔
101
        colDataSetVal(pColInfo, numOfRows, (const char *)&pCompactDetail->remainingTime, false), pSdb, pCompactDetail);
102

103
    numOfRows++;
34,316✔
104
    sdbRelease(pSdb, pCompactDetail);
34,316✔
105
  }
106

107
  pShow->numOfRows += numOfRows;
19,754✔
108
  mndReleaseDb(pMnode, pDb);
19,754✔
109
  return numOfRows;
19,754✔
110
}
111

112
void tFreeCompactDetailObj(SCompactDetailObj *pCompact) {}
348,304✔
113

114
int32_t tSerializeSCompactDetailObj(void *buf, int32_t bufLen, const SCompactDetailObj *pObj) {
1,025,810✔
115
  SEncoder encoder = {0};
1,025,810✔
116
  int32_t  code = 0;
1,025,810✔
117
  int32_t  lino;
118
  int32_t  tlen;
119
  tEncoderInit(&encoder, buf, bufLen);
1,025,810✔
120

121
  TAOS_CHECK_EXIT(tStartEncode(&encoder));
1,025,810✔
122
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->compactDetailId));
2,051,620✔
123
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->compactId));
2,051,620✔
124
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->vgId));
2,051,620✔
125
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->dnodeId));
2,051,620✔
126
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->numberFileset));
2,051,620✔
127
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->finished));
2,051,620✔
128
  TAOS_CHECK_EXIT(tEncodeI64(&encoder, pObj->startTime));
2,051,620✔
129
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->newNumberFileset));
2,051,620✔
130
  TAOS_CHECK_EXIT(tEncodeI32(&encoder, pObj->newFinished));
2,051,620✔
131
  // 1. add progress and remaining time
132
  TAOS_CHECK_EXIT(tEncodeI32v(&encoder, pObj->progress));
2,051,620✔
133
  TAOS_CHECK_EXIT(tEncodeI64v(&encoder, pObj->remainingTime));
2,051,620✔
134

135
  tEndEncode(&encoder);
1,025,810✔
136

137
_exit:
1,025,810✔
138
  if (code) {
1,025,810✔
UNCOV
139
    tlen = code;
×
140
  } else {
141
    tlen = encoder.pos;
1,025,810✔
142
  }
143
  tEncoderClear(&encoder);
1,025,810✔
144
  return tlen;
1,025,810✔
145
}
146

147
int32_t tDeserializeSCompactDetailObj(void *buf, int32_t bufLen, SCompactDetailObj *pObj) {
479,074✔
148
  int32_t  code = 0;
479,074✔
149
  int32_t  lino;
150
  SDecoder decoder = {0};
479,074✔
151
  tDecoderInit(&decoder, buf, bufLen);
479,074✔
152

153
  TAOS_CHECK_EXIT(tStartDecode(&decoder));
479,074✔
154
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->compactDetailId));
958,148✔
155
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->compactId));
958,148✔
156
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->vgId));
958,148✔
157
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->dnodeId));
958,148✔
158
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->numberFileset));
958,148✔
159
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->finished));
958,148✔
160
  TAOS_CHECK_EXIT(tDecodeI64(&decoder, &pObj->startTime));
958,148✔
161
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->newNumberFileset));
958,148✔
162
  TAOS_CHECK_EXIT(tDecodeI32(&decoder, &pObj->newFinished));
958,148✔
163
  // 1. add progress and remaining time decode
164
  if (!tDecodeIsEnd(&decoder)) {
479,074✔
165
    TAOS_CHECK_EXIT(tDecodeI32v(&decoder, &pObj->progress));
958,148✔
166
    TAOS_CHECK_EXIT(tDecodeI64v(&decoder, &pObj->remainingTime));
958,148✔
167
  } else {
168
    pObj->progress = 0;
×
169
    pObj->remainingTime = 0;
×
170
  }
171

172
  tEndDecode(&decoder);
479,074✔
173

174
_exit:
479,074✔
175
  tDecoderClear(&decoder);
479,074✔
176
  return code;
479,074✔
177
}
178

179
SSdbRaw *mndCompactDetailActionEncode(SCompactDetailObj *pCompact) {
374,971✔
180
  int32_t code = 0;
374,971✔
181
  int32_t lino = 0;
374,971✔
182
  terrno = TSDB_CODE_SUCCESS;
374,971✔
183

184
  void    *buf = NULL;
374,971✔
185
  SSdbRaw *pRaw = NULL;
374,971✔
186

187
  int32_t tlen = tSerializeSCompactDetailObj(NULL, 0, pCompact);
374,971✔
188
  if (tlen < 0) {
374,971✔
189
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
190
    goto OVER;
×
191
  }
192

193
  int32_t size = sizeof(int32_t) + tlen;
374,971✔
194
  pRaw = sdbAllocRaw(SDB_COMPACT_DETAIL, MND_COMPACT_DETAIL_VER_NUMBER, size);
374,971✔
195
  if (pRaw == NULL) {
374,971✔
196
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
197
    goto OVER;
×
198
  }
199

200
  buf = taosMemoryMalloc(tlen);
374,971✔
201
  if (buf == NULL) {
374,971✔
202
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
203
    goto OVER;
×
204
  }
205

206
  tlen = tSerializeSCompactDetailObj(buf, tlen, pCompact);
374,971✔
207
  if (tlen < 0) {
374,971✔
UNCOV
208
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
UNCOV
209
    goto OVER;
×
210
  }
211

212
  int32_t dataPos = 0;
374,971✔
213
  SDB_SET_INT32(pRaw, dataPos, tlen, OVER);
374,971✔
214
  SDB_SET_BINARY(pRaw, dataPos, buf, tlen, OVER);
374,971✔
215
  SDB_SET_DATALEN(pRaw, dataPos, OVER);
374,971✔
216

217
OVER:
374,971✔
218
  taosMemoryFreeClear(buf);
374,971✔
219
  if (terrno != TSDB_CODE_SUCCESS) {
374,971✔
UNCOV
220
    mError("compact detail:%" PRId32 ", failed to encode to raw:%p since %s", pCompact->compactId, pRaw, terrstr());
×
UNCOV
221
    sdbFreeRaw(pRaw);
×
UNCOV
222
    return NULL;
×
223
  }
224

225
  mTrace("compact detail:%" PRId32 ", encode to raw:%p, row:%p", pCompact->compactId, pRaw, pCompact);
374,971✔
226
  return pRaw;
374,971✔
227
}
228

229
SSdbRow *mndCompactDetailActionDecode(SSdbRaw *pRaw) {
348,304✔
230
  int32_t            code = 0;
348,304✔
231
  int32_t            lino = 0;
348,304✔
232
  SSdbRow           *pRow = NULL;
348,304✔
233
  SCompactDetailObj *pCompact = NULL;
348,304✔
234
  void              *buf = NULL;
348,304✔
235
  terrno = TSDB_CODE_SUCCESS;
348,304✔
236

237
  int8_t sver = 0;
348,304✔
238
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) {
348,304✔
239
    goto OVER;
×
240
  }
241

242
  if (sver != MND_COMPACT_DETAIL_VER_NUMBER) {
348,304✔
243
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
244
    mError("compact detail read invalid ver, data ver: %d, curr ver: %d", sver, MND_COMPACT_DETAIL_VER_NUMBER);
×
245
    goto OVER;
×
246
  }
247

248
  pRow = sdbAllocRow(sizeof(SCompactObj));
348,304✔
249
  if (pRow == NULL) {
348,304✔
250
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
251
    goto OVER;
×
252
  }
253

254
  pCompact = sdbGetRowObj(pRow);
348,304✔
255
  if (pCompact == NULL) {
348,304✔
256
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
257
    goto OVER;
×
258
  }
259

260
  int32_t tlen;
348,304✔
261
  int32_t dataPos = 0;
348,304✔
262
  SDB_GET_INT32(pRaw, dataPos, &tlen, OVER);
348,304✔
263
  buf = taosMemoryMalloc(tlen + 1);
348,304✔
264
  if (buf == NULL) {
348,304✔
265
    terrno = TSDB_CODE_OUT_OF_MEMORY;
×
266
    goto OVER;
×
267
  }
268
  SDB_GET_BINARY(pRaw, dataPos, buf, tlen, OVER);
348,304✔
269

270
  if ((terrno = tDeserializeSCompactDetailObj(buf, tlen, pCompact)) < 0) {
348,304✔
271
    goto OVER;
×
272
  }
273

274
OVER:
348,304✔
275
  taosMemoryFreeClear(buf);
348,304✔
276
  if (terrno != TSDB_CODE_SUCCESS) {
348,304✔
277
    mError("compact detail:%" PRId32 ", failed to decode from raw:%p since %s", pCompact->compactId, pRaw, terrstr());
×
278
    taosMemoryFreeClear(pRow);
×
279
    return NULL;
×
280
  }
281

282
  mTrace("compact detail:%" PRId32 ", decode from raw:%p, row:%p", pCompact->compactId, pRaw, pCompact);
348,304✔
283
  return pRow;
348,304✔
284
}
285

286
int32_t mndCompactDetailActionInsert(SSdb *pSdb, SCompactDetailObj *pCompact) {
158,506✔
287
  mTrace("compact detail:%" PRId32 ", perform insert action", pCompact->compactId);
158,506✔
288
  return 0;
158,506✔
289
}
290

291
int32_t mndCompactDetailActionDelete(SSdb *pSdb, SCompactDetailObj *pCompact) {
348,304✔
292
  mTrace("compact detail:%" PRId32 ", perform insert action", pCompact->compactId);
348,304✔
293
  tFreeCompactDetailObj(pCompact);
348,304✔
294
  return 0;
348,304✔
295
}
296

297
int32_t mndCompactDetailActionUpdate(SSdb *pSdb, SCompactDetailObj *pOldCompact, SCompactDetailObj *pNewCompact) {
104,089✔
298
  mTrace("compact detail:%" PRId32 ", perform update action, old row:%p new row:%p", pOldCompact->compactId,
104,089✔
299
         pOldCompact, pNewCompact);
300

301
  pOldCompact->numberFileset = pNewCompact->numberFileset;
104,089✔
302
  pOldCompact->finished = pNewCompact->finished;
104,089✔
303

304
  return 0;
104,089✔
305
}
306

307
int32_t mndAddCompactDetailToTran(SMnode *pMnode, STrans *pTrans, SCompactObj *pCompact, SVgObj *pVgroup,
69,713✔
308
                                  SVnodeGid *pVgid, int32_t index) {
309
  int32_t           code = 0;
69,713✔
310
  SCompactDetailObj compactDetail = {0};
69,713✔
311
  compactDetail.compactDetailId = index;
69,713✔
312
  compactDetail.compactId = pCompact->compactId;
69,713✔
313
  compactDetail.vgId = pVgroup->vgId;
69,713✔
314
  compactDetail.dnodeId = pVgid->dnodeId;
69,713✔
315
  compactDetail.startTime = taosGetTimestampMs();
69,713✔
316
  compactDetail.numberFileset = -1;
69,713✔
317
  compactDetail.finished = -1;
69,713✔
318
  compactDetail.newNumberFileset = -1;
69,713✔
319
  compactDetail.newFinished = -1;
69,713✔
320

321
  mInfo("compact:%d, add compact detail to trans, index:%d, vgId:%d, dnodeId:%d", compactDetail.compactId,
69,713✔
322
        compactDetail.compactDetailId, compactDetail.vgId, compactDetail.dnodeId);
323

324
  SSdbRaw *pVgRaw = mndCompactDetailActionEncode(&compactDetail);
69,713✔
325
  if (pVgRaw == NULL) return -1;
69,713✔
326
  if (mndTransAppendCommitlog(pTrans, pVgRaw) != 0) {
69,713✔
327
    sdbFreeRaw(pVgRaw);
×
328
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
329
    if (terrno != 0) code = terrno;
×
330
    TAOS_RETURN(code);
×
331
  }
332
  code = sdbSetRawStatus(pVgRaw, SDB_STATUS_READY);
69,713✔
333

334
  TAOS_RETURN(code);
69,713✔
335
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc