19751480105

Committed 28 Nov 2025 01:26AM UTC coverage: 69.441% (+0.3%) from 69.136%

Build # 19751480105

Build Type

push

github

Committed by

web-flow

Commit Message

#1613: fixed duplicated CVE check and refactored installation routine (#1614)

Run Details

3696 of 5851 branches covered (63.17%)

Branch coverage included in aggregate %.

9620 of 13325 relevant lines covered (72.2%)

3.14 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

8.33

cli/src/main/java/com/devonfw/tools/ide/tool/python/Python.java

package com.devonfw.tools.ide.tool.python;

import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardCopyOption;
import java.util.Set;

import com.devonfw.tools.ide.cli.CliException;
import com.devonfw.tools.ide.common.Tag;
import com.devonfw.tools.ide.context.IdeContext;
import com.devonfw.tools.ide.io.FileAccess;
import com.devonfw.tools.ide.process.EnvironmentContext;
import com.devonfw.tools.ide.tool.LocalToolCommandlet;
import com.devonfw.tools.ide.tool.ToolCommandlet;
import com.devonfw.tools.ide.tool.ToolInstallRequest;
import com.devonfw.tools.ide.tool.ToolInstallation;
import com.devonfw.tools.ide.tool.uv.Uv;
import com.devonfw.tools.ide.version.VersionIdentifier;

/**
 * {@link ToolCommandlet} for <a href="https://www.python.org/">python</a>.
 */
public class Python extends LocalToolCommandlet {

  private final VersionIdentifier PYTHON_MIN_VERSION = VersionIdentifier.of("3.8.2");

  /**
   * The constructor.
   *
   * @param context the {@link IdeContext}.
   */
  public Python(IdeContext context) {

    super(context, "python", Set.of(Tag.PYTHON));
  }

  @Override
  protected void performToolInstallation(ToolInstallRequest request, Path installationPath) {

    VersionIdentifier resolvedVersion = request.getRequested().getResolvedVersion();
    if (resolvedVersion.compareVersion(PYTHON_MIN_VERSION).isLess()) {
      throw new CliException("Python version must be at least " + this.PYTHON_MIN_VERSION);
    }

    FileAccess fileAccess = this.context.getFileAccess();
    if (Files.exists(installationPath)) {
      fileAccess.backup(installationPath);
    }
    Path softwarePath = installationPath.getParent();
    Uv uv = this.context.getCommandletManager().getCommandlet(Uv.class);

    uv.installPython(softwarePath, resolvedVersion, request.getProcessContext());
    renameVenvFolderToPython(fileAccess, softwarePath, installationPath);
    this.context.writeVersionFile(resolvedVersion, installationPath);
    createWindowsSymlinkBinFolder(fileAccess, installationPath);
    this.context.debug("Installed {} in version {} at {}", this.tool, resolvedVersion, installationPath);
  }

  @Override
  public void setEnvironment(EnvironmentContext environmentContext, ToolInstallation toolInstallation, boolean extraInstallation) {

    super.setEnvironment(environmentContext, toolInstallation, extraInstallation);
    environmentContext.withEnvVar("VIRTUAL_ENV", toolInstallation.rootDir().toString());
  }

  @Override
  protected boolean isIgnoreSoftwareRepo() {

    return true;
  }

  /**
   * Creates a symlink from the "Scripts" folder to the "bin" folder on Windows systems. This is necessary for compatibility with tools that expect a "bin"
   * directory.
   *
   * @param fileAccess the {@link FileAccess} utility for file operations.
   * @param installationPath the path where Python is installed.
   */
  private void createWindowsSymlinkBinFolder(FileAccess fileAccess, Path installationPath) {

    if (!this.context.getSystemInfo().isWindows()) {
      return;
    }
    Path scriptsPath = installationPath.resolve("Scripts");
    Path binPath = installationPath.resolve("bin");
    fileAccess.symlink(scriptsPath, binPath);
  }

  /**
   * Renames the ".venv" folder into the installation path (Python).
   *
   * @param fileAccess the {@link FileAccess} utility for file operations.
   * @param softwarePath the path where the software is installed.
   * @param installationPath the target path where the ".venv" folder should be moved.
   */
  private void renameVenvFolderToPython(FileAccess fileAccess, Path softwarePath, Path installationPath) {

    Path venvPath = softwarePath.resolve(".venv");
    fileAccess.move(venvPath, installationPath, StandardCopyOption.REPLACE_EXISTING);
  }

}

1	package com.devonfw.tools.ide.tool.python;
2
3	import java.nio.file.Files;
4	import java.nio.file.Path;
5	import java.nio.file.StandardCopyOption;
6	import java.util.Set;
7
8	import com.devonfw.tools.ide.cli.CliException;
9	import com.devonfw.tools.ide.common.Tag;
10	import com.devonfw.tools.ide.context.IdeContext;
11	import com.devonfw.tools.ide.io.FileAccess;
12	import com.devonfw.tools.ide.process.EnvironmentContext;
13	import com.devonfw.tools.ide.tool.LocalToolCommandlet;
14	import com.devonfw.tools.ide.tool.ToolCommandlet;
15	import com.devonfw.tools.ide.tool.ToolInstallRequest;
16	import com.devonfw.tools.ide.tool.ToolInstallation;
17	import com.devonfw.tools.ide.tool.uv.Uv;
18	import com.devonfw.tools.ide.version.VersionIdentifier;
19
20	/**
21	* {@link ToolCommandlet} for <a href="https://www.python.org/">python</a>.
22	*/
23	public class Python extends LocalToolCommandlet {
24
25	private final VersionIdentifier PYTHON_MIN_VERSION = VersionIdentifier.of("3.8.2");	4✔
26
27	/**
28	* The constructor.
29	*
30	* @param context the {@link IdeContext}.
31	*/
32	public Python(IdeContext context) {
33
34	super(context, "python", Set.of(Tag.PYTHON));	6✔
35	}	1✔
36
37	@Override
38	protected void performToolInstallation(ToolInstallRequest request, Path installationPath) {
39
40	VersionIdentifier resolvedVersion = request.getRequested().getResolvedVersion();	×
41	if (resolvedVersion.compareVersion(PYTHON_MIN_VERSION).isLess()) {	×
42	throw new CliException("Python version must be at least " + this.PYTHON_MIN_VERSION);	×
43	}
44
45	FileAccess fileAccess = this.context.getFileAccess();	×
46	if (Files.exists(installationPath)) {	×
47	fileAccess.backup(installationPath);	×
48	}
49	Path softwarePath = installationPath.getParent();	×
50	Uv uv = this.context.getCommandletManager().getCommandlet(Uv.class);	×
51
52	uv.installPython(softwarePath, resolvedVersion, request.getProcessContext());	×
53	renameVenvFolderToPython(fileAccess, softwarePath, installationPath);	×
54	this.context.writeVersionFile(resolvedVersion, installationPath);	×
55	createWindowsSymlinkBinFolder(fileAccess, installationPath);	×
56	this.context.debug("Installed {} in version {} at {}", this.tool, resolvedVersion, installationPath);	×
57	}	×
58
59	@Override
60	public void setEnvironment(EnvironmentContext environmentContext, ToolInstallation toolInstallation, boolean extraInstallation) {
61
62	super.setEnvironment(environmentContext, toolInstallation, extraInstallation);	×
63	environmentContext.withEnvVar("VIRTUAL_ENV", toolInstallation.rootDir().toString());	×
64	}	×
65
66	@Override
67	protected boolean isIgnoreSoftwareRepo() {
68
69	return true;	×
70	}
71
72	/**
73	* Creates a symlink from the "Scripts" folder to the "bin" folder on Windows systems. This is necessary for compatibility with tools that expect a "bin"
74	* directory.
75	*
76	* @param fileAccess the {@link FileAccess} utility for file operations.
77	* @param installationPath the path where Python is installed.
78	*/
79	private void createWindowsSymlinkBinFolder(FileAccess fileAccess, Path installationPath) {
80
81	if (!this.context.getSystemInfo().isWindows()) {	×
82	return;	×
83	}
84	Path scriptsPath = installationPath.resolve("Scripts");	×
85	Path binPath = installationPath.resolve("bin");	×
86	fileAccess.symlink(scriptsPath, binPath);	×
87	}	×
88
89	/**
90	* Renames the ".venv" folder into the installation path (Python).
91	*
92	* @param fileAccess the {@link FileAccess} utility for file operations.
93	* @param softwarePath the path where the software is installed.
94	* @param installationPath the target path where the ".venv" folder should be moved.
95	*/
96	private void renameVenvFolderToPython(FileAccess fileAccess, Path softwarePath, Path installationPath) {
97
98	Path venvPath = softwarePath.resolve(".venv");	×
99	fileAccess.move(venvPath, installationPath, StandardCopyOption.REPLACE_EXISTING);	×
100	}	×
101
102	}

devonfw / IDEasy / 19751480105

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous