Alan-Jowett / dagir / 19606629258

push

github

Use string_view for IR attributes; add string_view_cache (#51)

* ir: use std::string_view for attributes; add string_view_cache and update builders/renderers/policies

* ir: migrate attributes to std::string_view and add attr cache; cache policy strings

* tests: guard Catch2 StringMaker for std::string_view to avoid duplicate definition on CI

* tests: make catch string_view stringifier a header-only inline helper to avoid ODR

* tests: provide single TU implementation for Catch StringMaker<std::string_view> when absent

* tests: only define missing StringMaker<std::string_view> on Windows to avoid Linux CI ODR conflicts

* tests: provide both StringMaker<std::string_view> instantiations on Windows to satisfy linker

* tests: relax guard to define symbol on Windows when Catch doesn't provide StringMaker

* tests: consolidate Catch std::string_view stringifier into single TU with guard

* tests: remove redundant impl TU for string_view stringifier

* tests: ensure Catch string_view stringifier available on Windows; keep guard on other platforms

* tests: clean up string_view stringifier TU to a single guarded definition

* tests: provide single TU Catch2 StringMaker for std::string_view on Windows only

* Fix

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Remove catch stringify

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Make policy attribute maps own strings to avoid dangling string_view

* Document ir_attr_map lifetime; make string_view_cache movable-only; update expression_policy docs

* Format expression2bdd main.cpp (clang-format)

* Replace small label-replacement loops with std::find_if in cudd/teddy policies

* string_view_cache: initialize storage_ in move ctor initializer list

* docs: add Doxygen comments to string_view_cache public API

* docs: add Doxygen comments to cudd conversion helpers

* docs: add Doxygen comments to several read-only view and conversion headers

* cudd: include id attribute in single-arg... (continued)

1498 of 2076 branches covered (72.16%)

Branch coverage included in aggregate %.

191 of 208 new or added lines in 10 files covered. (91.83%)

1245 of 1435 relevant lines covered (86.76%)

5675953.36 hits per line