1212

Committed 18 Nov 2025 12:37PM UTC coverage: 33.784% (+0.003%) from 33.781%

Build # 1212

Build Type

push

github

Committed by

badlop

Commit Message

mod_conversejs: Improve link to conversejs in WebAdmin (#4495)

Until now, the WebAdmin menu included a link to the first request handler
with mod_conversejs that the admin configured in ejabberd.yml
That link included the authentication credentials hashed as URI arguments
if using HTTPS. Then process/2 extracted those arguments and passed them
as autologin options to Converse.

From now, mod_conversejs automatically adds a request_handler nested in
webadmin subpath. The webadmin menu links to that converse URI; this allows
to access the HTTP auth credentials, no need to explicitly pass them.
process/2 extracts this HTTP auth and passes autologin options to Converse.
Now scram password storage is supported too.

This minimum configuration allows WebAdmin to access Converse:

listen:
  -
    port: 5443
    module: ejabberd_http
    tls: true
    request_handlers:
      /admin: ejabberd_web_admin
      /ws: ejabberd_http_ws
modules:
  mod_conversejs:
    conversejs_resources: "/home/conversejs/12.0.0/dist"

Run Details

0 of 12 new or added lines in 1 file covered. (0.0%)

11290 existing lines in 174 files now uncovered.

15515 of 45924 relevant lines covered (33.78%)

1277.8 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

50.0

/src/mod_push_keepalive_opt.erl

%% Generated automatically
%% DO NOT EDIT: run `make options` instead

-module(mod_push_keepalive_opt).

-export([resume_timeout/1]).
-export([wake_on_start/1]).
-export([wake_on_timeout/1]).

-spec resume_timeout(gen_mod:opts() | global | binary()) -> non_neg_integer().
resume_timeout(Opts) when is_map(Opts) ->
    gen_mod:get_opt(resume_timeout, Opts);
resume_timeout(Host) ->
    gen_mod:get_module_opt(Host, mod_push_keepalive, resume_timeout).

-spec wake_on_start(gen_mod:opts() | global | binary()) -> boolean().
wake_on_start(Opts) when is_map(Opts) ->
    gen_mod:get_opt(wake_on_start, Opts);
wake_on_start(Host) ->
    gen_mod:get_module_opt(Host, mod_push_keepalive, wake_on_start).

-spec wake_on_timeout(gen_mod:opts() | global | binary()) -> boolean().
wake_on_timeout(Opts) when is_map(Opts) ->
    gen_mod:get_opt(wake_on_timeout, Opts);
wake_on_timeout(Host) ->
    gen_mod:get_module_opt(Host, mod_push_keepalive, wake_on_timeout).


1	%% Generated automatically
2	%% DO NOT EDIT: run `make options` instead
3
4	-module(mod_push_keepalive_opt).
5
6	-export([resume_timeout/1]).
7	-export([wake_on_start/1]).
8	-export([wake_on_timeout/1]).
9
10	-spec resume_timeout(gen_mod:opts() \| global \| binary()) -> non_neg_integer().
11	resume_timeout(Opts) when is_map(Opts) ->
12	gen_mod:get_opt(resume_timeout, Opts);	×
13	resume_timeout(Host) ->
UNCOV 14	gen_mod:get_module_opt(Host, mod_push_keepalive, resume_timeout).	18✔
15
16	-spec wake_on_start(gen_mod:opts() \| global \| binary()) -> boolean().
17	wake_on_start(Opts) when is_map(Opts) ->
18	gen_mod:get_opt(wake_on_start, Opts);	×
19	wake_on_start(Host) ->
UNCOV 20	gen_mod:get_module_opt(Host, mod_push_keepalive, wake_on_start).	9✔
21
22	-spec wake_on_timeout(gen_mod:opts() \| global \| binary()) -> boolean().
23	wake_on_timeout(Opts) when is_map(Opts) ->
24	gen_mod:get_opt(wake_on_timeout, Opts);	×
25	wake_on_timeout(Host) ->
UNCOV 26	gen_mod:get_module_opt(Host, mod_push_keepalive, wake_on_timeout).	18✔
27

processone / ejabberd / 1212

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous