19462251046

Committed 18 Nov 2025 10:11AM UTC coverage: 68.846% (-0.09%) from 68.94%

Build # 19462251046

Build Type

push

github

Committed by

web-flow

Commit Message

#1584: improve commandlet error handling and bash array syntax warning (#1589)

Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>

Run Details

3528 of 5623 branches covered (62.74%)

Branch coverage included in aggregate %.

9214 of 12885 relevant lines covered (71.51%)

3.14 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

82.88

cli/src/main/java/com/devonfw/tools/ide/tool/repository/CustomToolsJsonMapper.java

package com.devonfw.tools.ide.tool.repository;

import java.io.BufferedReader;
import java.io.BufferedWriter;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.ArrayList;
import java.util.List;

import com.devonfw.tools.ide.context.IdeContext;
import com.devonfw.tools.ide.environment.VariableLine;
import com.devonfw.tools.ide.json.JsonMapping;
import com.devonfw.tools.ide.os.OperatingSystem;
import com.devonfw.tools.ide.os.SystemArchitecture;
import com.devonfw.tools.ide.os.SystemInfo;
import com.fasterxml.jackson.databind.ObjectMapper;

/**
 * Mapper of {@link CustomToolsJson} from/to JSON.
 */
public class CustomToolsJsonMapper {

  private static final ObjectMapper MAPPER = JsonMapping.create();

  /**
   * @param customTools the {@link CustomToolsJson} to save.
   * @param path the {@link Path} of the file where to save as JSON.
   */
  public static void saveJson(CustomToolsJson customTools, Path path) {

    try (BufferedWriter writer = Files.newBufferedWriter(path)) {
      MAPPER.writerWithDefaultPrettyPrinter().writeValue(writer, customTools);
    } catch (Exception e) {
      throw new IllegalStateException("Failed to save file " + path, e);
    }
  }

  /**
   * @param path the {@link Path} of the JSON file to load.
   * @return the parsed {@link CustomToolsJson} or {@code null} if the {@link Path} is not an existing file.
   */
  public static CustomToolsJson loadJson(Path path) {
    CustomToolsJson customToolsJson = null;
    if (Files.isRegularFile(path)) {
      try (BufferedReader reader = Files.newBufferedReader(path)) {
        customToolsJson = MAPPER.readValue(reader, CustomToolsJson.class);
      } catch (Exception e) {
        throw new IllegalStateException("Failed to load " + path, e);
      }
    }
    return customToolsJson;
  }

  /**
   * @param customTools the {@link CustomToolsJson} to convert.
   * @param context the {@link IdeContext}.
   * @return the converted {@link List} of {@link CustomToolMetadata}.
   */
  public static List<CustomToolMetadata> convert(CustomToolsJson customTools, IdeContext context) {

    String repositoryUrl = customTools.url();
    List<CustomToolJson> tools = customTools.tools();
    List<CustomToolMetadata> result = new ArrayList<>(tools.size());
    for (CustomToolJson customTool : tools) {
      result.add(convert(customTool, repositoryUrl, context));
    }
    return result;
  }

  private static CustomToolMetadata convert(CustomToolJson customTool, String repositoryUrl, IdeContext context) {

    String tool = customTool.name();
    String version = customTool.version();
    SystemInfo systemInfo = context.getSystemInfo();
    String repoUrl = customTool.url();
    if ((repoUrl == null) || repoUrl.isEmpty()) {
      repoUrl = repositoryUrl;
    }
    int capacity = repoUrl.length() + 2 * tool.length() + 2 * version.length() + 7;
    OperatingSystem os;
    if (customTool.osAgnostic()) {
      os = null;
    } else {
      os = systemInfo.getOs();
      capacity += os.toString().length() + 1;
    }
    SystemArchitecture arch;
    if (customTool.archAgnostic()) {
      arch = null;
    } else {
      arch = systemInfo.getArchitecture();
      capacity += arch.toString().length() + 1;
    }
    StringBuilder sb = new StringBuilder(capacity);
    sb.append(repoUrl);
    char last = repoUrl.charAt(repoUrl.length() - 1);
    if ((last != '/') && (last != '\\')) {
      sb.append('/');
    }
    sb.append(tool);
    sb.append('/');
    sb.append(version);
    sb.append('/');
    sb.append(tool);
    sb.append('-');
    sb.append(version);
    if (os != null) {
      sb.append('-');
      sb.append(os);
    }
    if (arch != null) {
      sb.append('-');
      sb.append(arch);
    }
    sb.append(".tgz");
    String url = sb.toString();
    return new CustomToolMetadata(tool, version, os, arch, url, null, repoUrl);
  }

  /**
   * Retrieves custom tools from a devonfw-ide legacy config.
   *
   * @param customToolsContent String of custom tools
   * @param context the {@link IdeContext}.
   * @return {@link CustomToolsJson}.
   */
  public static CustomToolsJson parseCustomToolsFromLegacyConfig(String customToolsContent, IdeContext context) {
    List<String> customToolEntries = VariableLine.parseArray(customToolsContent);
    if (customToolEntries.isEmpty()) {
      return null;
    }
    List<CustomToolJson> customTools = new ArrayList<>(customToolEntries.size());
    String defaultUrl = null;
    for (String customToolConfig : customToolEntries) {
      CustomToolJson customToolJson = parseCustomToolFromLegacyConfig(customToolConfig);
      if (customToolJson == null) {
        context.warning("Invalid custom tool entry: {}", customToolConfig);
      } else {
        String url = customToolJson.url();
        if (defaultUrl == null) {
          if ((url == null) || url.isEmpty()) {
            context.warning("First custom tool entry has no URL specified: {}", customToolConfig);
          } else {
            defaultUrl = url;
            customToolJson = customToolJson.withoutUrl();
          }
        } else if (defaultUrl.equals(url)) {
          customToolJson = customToolJson.withoutUrl();
        }
        customTools.add(customToolJson);
      }
    }
    if (customTools.isEmpty() || (defaultUrl == null)) {
      return null;
    }
    return new CustomToolsJson(defaultUrl, customTools);
  }

  private static CustomToolJson parseCustomToolFromLegacyConfig(String customToolConfig) {
    int firstColon = customToolConfig.indexOf(":");
    if (firstColon < 0) {
      return null;
    }
    String toolName = customToolConfig.substring(0, firstColon);
    int secondColon = customToolConfig.indexOf(":", firstColon + 1);
    if (secondColon < 0) {
      return null;
    }
    String version = customToolConfig.substring(firstColon + 1, secondColon);
    int thirdColon = customToolConfig.indexOf(":", secondColon + 1);
    boolean osAgnostic = false;
    boolean archAgnostic = false;
    String url = null;
    if (thirdColon > 0) {
      if (customToolConfig.substring(secondColon + 1, thirdColon).equals("all")) {
        osAgnostic = true;
        archAgnostic = true;
        url = customToolConfig.substring(thirdColon + 1);
      } else {
        url = customToolConfig.substring(secondColon + 1);
      }
    }
    return new CustomToolJson(toolName, version, osAgnostic, archAgnostic, url);
  }

}

1	package com.devonfw.tools.ide.tool.repository;
2
3	import java.io.BufferedReader;
4	import java.io.BufferedWriter;
5	import java.nio.file.Files;
6	import java.nio.file.Path;
7	import java.util.ArrayList;
8	import java.util.List;
9
10	import com.devonfw.tools.ide.context.IdeContext;
11	import com.devonfw.tools.ide.environment.VariableLine;
12	import com.devonfw.tools.ide.json.JsonMapping;
13	import com.devonfw.tools.ide.os.OperatingSystem;
14	import com.devonfw.tools.ide.os.SystemArchitecture;
15	import com.devonfw.tools.ide.os.SystemInfo;
16	import com.fasterxml.jackson.databind.ObjectMapper;
17
18	/**
19	* Mapper of {@link CustomToolsJson} from/to JSON.
20	*/
21	public class CustomToolsJsonMapper {	×
22
23	private static final ObjectMapper MAPPER = JsonMapping.create();	3✔
24
25	/**
26	* @param customTools the {@link CustomToolsJson} to save.
27	* @param path the {@link Path} of the file where to save as JSON.
28	*/
29	public static void saveJson(CustomToolsJson customTools, Path path) {
30
31	try (BufferedWriter writer = Files.newBufferedWriter(path)) {	5✔
32	MAPPER.writerWithDefaultPrettyPrinter().writeValue(writer, customTools);	5✔
33	} catch (Exception e) {	×
34	throw new IllegalStateException("Failed to save file " + path, e);	×
35	}	1✔
36	}	1✔
37
38	/**
39	* @param path the {@link Path} of the JSON file to load.
40	* @return the parsed {@link CustomToolsJson} or {@code null} if the {@link Path} is not an existing file.
41	*/
42	public static CustomToolsJson loadJson(Path path) {
43	CustomToolsJson customToolsJson = null;	2✔
44	if (Files.isRegularFile(path)) {	5!
45	try (BufferedReader reader = Files.newBufferedReader(path)) {	3✔
46	customToolsJson = MAPPER.readValue(reader, CustomToolsJson.class);	6✔
47	} catch (Exception e) {	×
48	throw new IllegalStateException("Failed to load " + path, e);	×
49	}	1✔
50	}
51	return customToolsJson;	2✔
52	}
53
54	/**
55	* @param customTools the {@link CustomToolsJson} to convert.
56	* @param context the {@link IdeContext}.
57	* @return the converted {@link List} of {@link CustomToolMetadata}.
58	*/
59	public static List<CustomToolMetadata> convert(CustomToolsJson customTools, IdeContext context) {
60
61	String repositoryUrl = customTools.url();	3✔
62	List<CustomToolJson> tools = customTools.tools();	3✔
63	List<CustomToolMetadata> result = new ArrayList<>(tools.size());	6✔
64	for (CustomToolJson customTool : tools) {	10✔
65	result.add(convert(customTool, repositoryUrl, context));	7✔
66	}	1✔
67	return result;	2✔
68	}
69
70	private static CustomToolMetadata convert(CustomToolJson customTool, String repositoryUrl, IdeContext context) {
71
72	String tool = customTool.name();	3✔
73	String version = customTool.version();	3✔
74	SystemInfo systemInfo = context.getSystemInfo();	3✔
75	String repoUrl = customTool.url();	3✔
76	if ((repoUrl == null) \|\| repoUrl.isEmpty()) {	5!
77	repoUrl = repositoryUrl;	×
78	}
79	int capacity = repoUrl.length() + 2 * tool.length() + 2 * version.length() + 7;	15✔
80	OperatingSystem os;
81	if (customTool.osAgnostic()) {	3✔
82	os = null;	3✔
83	} else {
84	os = systemInfo.getOs();	3✔
85	capacity += os.toString().length() + 1;	8✔
86	}
87	SystemArchitecture arch;
88	if (customTool.archAgnostic()) {	3✔
89	arch = null;	3✔
90	} else {
91	arch = systemInfo.getArchitecture();	3✔
92	capacity += arch.toString().length() + 1;	8✔
93	}
94	StringBuilder sb = new StringBuilder(capacity);	5✔
95	sb.append(repoUrl);	4✔
96	char last = repoUrl.charAt(repoUrl.length() - 1);	7✔
97	if ((last != '/') && (last != '\\')) {	3!
98	sb.append('/');	×
99	}
100	sb.append(tool);	4✔
101	sb.append('/');	4✔
102	sb.append(version);	4✔
103	sb.append('/');	4✔
104	sb.append(tool);	4✔
105	sb.append('-');	4✔
106	sb.append(version);	4✔
107	if (os != null) {	2✔
108	sb.append('-');	4✔
109	sb.append(os);	4✔
110	}
111	if (arch != null) {	2✔
112	sb.append('-');	4✔
113	sb.append(arch);	4✔
114	}
115	sb.append(".tgz");	4✔
116	String url = sb.toString();	3✔
117	return new CustomToolMetadata(tool, version, os, arch, url, null, repoUrl);	11✔
118	}
119
120	/**
121	* Retrieves custom tools from a devonfw-ide legacy config.
122	*
123	* @param customToolsContent String of custom tools
124	* @param context the {@link IdeContext}.
125	* @return {@link CustomToolsJson}.
126	*/
127	public static CustomToolsJson parseCustomToolsFromLegacyConfig(String customToolsContent, IdeContext context) {
128	List<String> customToolEntries = VariableLine.parseArray(customToolsContent);	3✔
129	if (customToolEntries.isEmpty()) {	3✔
130	return null;	2✔
131	}
132	List<CustomToolJson> customTools = new ArrayList<>(customToolEntries.size());	6✔
133	String defaultUrl = null;	2✔
134	for (String customToolConfig : customToolEntries) {	10✔
135	CustomToolJson customToolJson = parseCustomToolFromLegacyConfig(customToolConfig);	3✔
136	if (customToolJson == null) {	2!
137	context.warning("Invalid custom tool entry: {}", customToolConfig);	×
138	} else {
139	String url = customToolJson.url();	3✔
140	if (defaultUrl == null) {	2✔
141	if ((url == null) \|\| url.isEmpty()) {	5!
142	context.warning("First custom tool entry has no URL specified: {}", customToolConfig);	10✔
143	} else {
144	defaultUrl = url;	2✔
145	customToolJson = customToolJson.withoutUrl();	4✔
146	}
147	} else if (defaultUrl.equals(url)) {	4!
148	customToolJson = customToolJson.withoutUrl();	×
149	}
150	customTools.add(customToolJson);	4✔
151	}
152	}	1✔
153	if (customTools.isEmpty() \|\| (defaultUrl == null)) {	5!
154	return null;	2✔
155	}
156	return new CustomToolsJson(defaultUrl, customTools);	6✔
157	}
158
159	private static CustomToolJson parseCustomToolFromLegacyConfig(String customToolConfig) {
160	int firstColon = customToolConfig.indexOf(":");	4✔
161	if (firstColon < 0) {	2!
162	return null;	×
163	}
164	String toolName = customToolConfig.substring(0, firstColon);	5✔
165	int secondColon = customToolConfig.indexOf(":", firstColon + 1);	7✔
166	if (secondColon < 0) {	2!
167	return null;	×
168	}
169	String version = customToolConfig.substring(firstColon + 1, secondColon);	7✔
170	int thirdColon = customToolConfig.indexOf(":", secondColon + 1);	7✔
171	boolean osAgnostic = false;	2✔
172	boolean archAgnostic = false;	2✔
173	String url = null;	2✔
174	if (thirdColon > 0) {	2✔
175	if (customToolConfig.substring(secondColon + 1, thirdColon).equals("all")) {	9!
176	osAgnostic = true;	2✔
177	archAgnostic = true;	2✔
178	url = customToolConfig.substring(thirdColon + 1);	7✔
179	} else {
180	url = customToolConfig.substring(secondColon + 1);	×
181	}
182	}
183	return new CustomToolJson(toolName, version, osAgnostic, archAgnostic, url);	9✔
184	}
185
186	}

devonfw / IDEasy / 19462251046

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous