• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

MinaProtocol / mina / 799

04 Nov 2025 01:59PM UTC coverage: 32.34% (-4.6%) from 36.902%
799

push

buildkite

web-flow
Merge pull request #18063 from MinaProtocol/lyh/compat-into-dev-nov4-2025

Merge compatible into develop Nov. 4th 2025

87 of 228 new or added lines in 10 files covered. (38.16%)

3337 existing lines in 136 files now uncovered.

23547 of 72811 relevant lines covered (32.34%)

23810.18 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

1.96
/src/lib/sync_handler/sync_handler.ml
1
open Core_kernel
112✔
2
open Async
3
open Mina_base
4
module Ledger = Mina_ledger.Ledger
5
module Root_ledger = Mina_ledger.Root
6
module Sync_ledger = Mina_ledger.Sync_ledger
7
open Frontier_base
8
open Network_peer
9

10
module type CONTEXT = sig
11
  val logger : Logger.t
12

13
  val precomputed_values : Precomputed_values.t
14

15
  val constraint_constants : Genesis_constants.Constraint_constants.t
16

17
  val consensus_constants : Consensus.Constants.t
18

19
  val ledger_sync_config : Syncable_ledger.daemon_config
20

21
  val proof_cache_db : Proof_cache_tag.cache_db
22

23
  val signature_kind : Mina_signature_kind.t
24
end
25

26
module type Inputs_intf = sig
27
  module Transition_frontier : module type of Transition_frontier
28

29
  module Best_tip_prover :
30
    Mina_intf.Best_tip_prover_intf
31
      with type transition_frontier := Transition_frontier.t
32
end
33

34
module Make (Inputs : Inputs_intf) :
35
  Mina_intf.Sync_handler_intf
36
    with type transition_frontier := Inputs.Transition_frontier.t = struct
37
  open Inputs
38

39
  let find_in_root_history frontier state_hash =
40
    let open Transition_frontier.Extensions in
×
41
    let root_history =
42
      get_extension (Transition_frontier.extensions frontier) Root_history
×
43
    in
44
    Root_history.lookup root_history state_hash
×
45

46
  let protocol_states_in_root_history frontier state_hash =
47
    let open Transition_frontier.Extensions in
×
48
    let root_history =
49
      get_extension (Transition_frontier.extensions frontier) Root_history
×
50
    in
51
    Root_history.protocol_states_for_scan_state root_history state_hash
×
52

53
  let get_ledger_by_hash ~frontier ledger_hash =
UNCOV
54
    let root_ledger =
×
55
      Root_ledger.as_unmasked
UNCOV
56
      @@ Transition_frontier.root_snarked_ledger frontier
×
57
    in
UNCOV
58
    let staking_epoch_ledger =
×
UNCOV
59
      Transition_frontier.consensus_local_state frontier
×
60
      |> Consensus.Data.Local_state.staking_epoch_ledger
61
    in
UNCOV
62
    let next_epoch_ledger =
×
UNCOV
63
      Transition_frontier.consensus_local_state frontier
×
64
      |> Consensus.Data.Local_state.next_epoch_ledger
65
    in
UNCOV
66
    if
×
67
      Ledger_hash.equal ledger_hash
UNCOV
68
        (Ledger.Any_ledger.M.merkle_root root_ledger)
×
69
    then Some root_ledger
×
UNCOV
70
    else if
×
71
      Ledger_hash.equal ledger_hash
UNCOV
72
        (Consensus.Data.Local_state.Snapshot.Ledger_snapshot.merkle_root
×
73
           staking_epoch_ledger )
74
    then
UNCOV
75
      match staking_epoch_ledger with
×
UNCOV
76
      | Consensus.Data.Local_state.Snapshot.Ledger_snapshot.Genesis_epoch_ledger
×
77
          _ ->
78
          None
UNCOV
79
      | Ledger_root ledger ->
×
UNCOV
80
          Some (Root_ledger.as_unmasked ledger)
×
UNCOV
81
    else if
×
82
      Ledger_hash.equal ledger_hash
UNCOV
83
        (Consensus.Data.Local_state.Snapshot.Ledger_snapshot.merkle_root
×
84
           next_epoch_ledger )
85
    then
UNCOV
86
      match next_epoch_ledger with
×
87
      | Consensus.Data.Local_state.Snapshot.Ledger_snapshot.Genesis_epoch_ledger
×
88
          _ ->
89
          None
UNCOV
90
      | Ledger_root ledger ->
×
UNCOV
91
          Some (Root_ledger.as_unmasked ledger)
×
92
    else None
×
93

94
  let answer_query :
95
         frontier:Inputs.Transition_frontier.t
96
      -> Ledger_hash.t
97
      -> Sync_ledger.Query.t Envelope.Incoming.t
98
      -> context:(module CONTEXT)
99
      -> trust_system:Trust_system.t
100
      -> Sync_ledger.Answer.t Or_error.t Deferred.t =
101
   fun ~frontier hash query ~context:(module Context) ~trust_system ->
UNCOV
102
    match get_ledger_by_hash ~frontier hash with
×
UNCOV
103
    | None ->
×
104
        return
UNCOV
105
          (Or_error.error_string
×
UNCOV
106
             (sprintf
×
UNCOV
107
                !"Failed to find ledger for hash %{sexp:Ledger_hash.t}"
×
108
                hash ) )
UNCOV
109
    | Some ledger ->
×
110
        let responder =
111
          Sync_ledger.Any_ledger.Responder.create ledger ignore
112
            ~context:(module Context)
113
            ~trust_system
114
        in
UNCOV
115
        Sync_ledger.Any_ledger.Responder.answer_query responder query
×
116

117
  let get_staged_ledger_aux_and_pending_coinbases_at_hash ~logger ~frontier
118
      state_hash =
119
    let open Option.Let_syntax in
×
120
    let protocol_states scan_state =
121
      Staged_ledger.Scan_state.required_state_hashes scan_state
×
122
      |> State_hash.Set.to_list
×
123
      |> List.fold_until ~init:(Some [])
124
           ~f:(fun acc hash ->
125
             match
×
126
               Option.map2
127
                 (Transition_frontier.find_protocol_state frontier hash)
×
128
                 acc ~f:List.cons
129
             with
130
             | None ->
×
131
                 Stop None
132
             | Some acc' ->
×
133
                 Continue (Some acc') )
134
           ~finish:Fn.id
135
    in
136
    match
137
      let%bind breadcrumb = Transition_frontier.find frontier state_hash in
×
138
      let staged_ledger =
×
139
        Transition_frontier.Breadcrumb.staged_ledger breadcrumb
140
      in
141
      let scan_state = Staged_ledger.scan_state staged_ledger in
×
142
      let staged_ledger_hash = Breadcrumb.staged_ledger_hash breadcrumb in
×
143
      let merkle_root = Staged_ledger_hash.ledger_hash staged_ledger_hash in
×
144
      let%map scan_state_protocol_states = protocol_states scan_state in
×
145
      let pending_coinbase =
×
146
        Staged_ledger.pending_coinbase_collection staged_ledger
147
      in
148
      [%log debug]
×
149
        ~metadata:
150
          [ ( "staged_ledger_hash"
151
            , Staged_ledger_hash.to_yojson staged_ledger_hash )
×
152
          ]
153
        "sending scan state and pending coinbase" ;
154
      (scan_state, merkle_root, pending_coinbase, scan_state_protocol_states)
×
155
    with
156
    | Some res ->
×
157
        Some res
158
    | None ->
×
159
        let open Root_data.Historical in
160
        let%bind root = find_in_root_history frontier state_hash in
×
161
        let%map scan_state_protocol_states =
162
          protocol_states_in_root_history frontier state_hash
×
163
        in
164
        ( scan_state root
×
165
        , staged_ledger_target_ledger_hash root
×
166
        , pending_coinbase root
×
167
        , scan_state_protocol_states )
168

169
  let get_transition_chain ~frontier hashes =
170
    let open Option.Let_syntax in
×
171
    let%bind () =
172
      let requested = List.length hashes in
173
      if requested <= Transition_frontier.max_catchup_chunk_length then Some ()
×
174
      else (
×
175
        [%log' trace (Logger.create ())]
×
176
          ~metadata:[ ("n", `Int requested) ]
177
          "get_transition_chain requested $n > %d hashes"
178
          Transition_frontier.max_catchup_chunk_length ;
179
        None )
×
180
    in
181
    let get hash =
×
182
      let%map validated_transition =
183
        Option.merge
×
184
          Transition_frontier.(
185
            find frontier hash >>| Breadcrumb.validated_transition)
×
186
          ( find_in_root_history frontier hash
×
187
          >>| Root_data.Historical.transition )
×
188
          ~f:Fn.const
189
      in
190
      With_hash.data @@ Mina_block.Validated.forget validated_transition
×
191
    in
192
    match Transition_frontier.catchup_state frontier with
193
    | Full _ ->
×
194
        (* Super catchup *)
195
        Option.return @@ List.filter_map hashes ~f:get
×
196

197
  let best_tip_path ~frontier =
198
    let rec go acc b =
×
199
      let acc = Breadcrumb.state_hash b :: acc in
×
200
      match Transition_frontier.find frontier (Breadcrumb.parent_hash b) with
×
201
      | None ->
×
202
          acc
203
      | Some b' ->
×
204
          go acc b'
205
    in
206
    go [] (Transition_frontier.best_tip frontier)
×
207

208
  module Root = struct
209
    let prove ~context:(module Context : CONTEXT) ~frontier seen_consensus_state
210
        =
211
      let module Context = struct
×
212
        include Context
213

214
        let logger =
215
          Logger.extend logger [ ("selection_context", `String "Root.prove") ]
×
216
      end in
217
      let open Option.Let_syntax in
218
      let%bind best_tip_with_witness =
219
        Best_tip_prover.prove ~context:(module Context) frontier
×
220
      in
221
      let is_tip_better =
×
222
        Consensus.Hooks.equal_select_status
223
          (Consensus.Hooks.select
224
             ~context:(module Context)
225
             ~existing:
226
               (With_hash.map ~f:Mina_block.consensus_state
×
227
                  best_tip_with_witness.data )
228
             ~candidate:seen_consensus_state )
229
          `Keep
230
      in
231
      let%map () = Option.some_if is_tip_better () in
×
232
      { best_tip_with_witness with
×
233
        data = With_hash.data best_tip_with_witness.data
×
234
      }
235

236
    let verify ~context:(module Context : CONTEXT) ~verifier observed_state
237
        peer_root =
238
      let module Context = struct
×
239
        include Context
240

241
        let logger =
242
          Logger.extend logger [ ("selection_context", `String "Root.verify") ]
×
243
      end in
244
      let open Context in
245
      let open Deferred.Result.Let_syntax in
246
      (*TODO: use precomputed_values.genesis_constants that's already passed*)
247
      let%bind ( (`Root _, `Best_tip (best_tip_transition, _)) as
248
               verified_witness ) =
249
        Best_tip_prover.verify ~verifier
×
250
          ~genesis_constants:precomputed_values.genesis_constants
251
          ~precomputed_values peer_root
252
      in
253
      let is_before_best_tip candidate =
×
254
        Consensus.Hooks.equal_select_status
×
255
          (Consensus.Hooks.select
256
             ~context:(module Context)
257
             ~existing:
258
               (With_hash.map
×
259
                  ~f:
260
                    (Fn.compose Mina_state.Protocol_state.consensus_state
×
261
                       Mina_block.Header.protocol_state )
262
                  best_tip_transition )
263
             ~candidate )
264
          `Keep
265
      in
266
      let%map () =
267
        Deferred.return
×
268
          (Result.ok_if_true
×
269
             (is_before_best_tip observed_state)
×
270
             ~error:
271
               (Error.createf
×
272
                  !"Peer lied about it's best tip %{sexp:State_hash.t}"
×
273
                  (State_hash.With_state_hashes.state_hash best_tip_transition) ) )
×
274
      in
275
      verified_witness
×
276
  end
277
end
278

279
include Make (struct
280
  module Transition_frontier = Transition_frontier
281
  module Best_tip_prover = Best_tip_prover
282
end)
224✔
283

284
(* TODO: port these tests *)
285
(*
286
let%test_module "Sync_handler" =
287
  ( module struct
288
    let logger = Logger.null ()
289

290
    let hb_logger = Logger.create ()
291

292
    let pids = Child_processes.Termination.create_pid_table ()
293

294
    let trust_system = Trust_system.null ()
295

296
    let f_with_verifier ~f ~logger ~pids =
297
      let%map verifier = Verifier.create ~logger ~pids in
298
      f ~logger ~verifier
299

300
    let%test "sync with ledgers from another peer via glue_sync_ledger" =
301
      Backtrace.elide := false ;
302
      Printexc.record_backtrace true ;
303
      heartbeat_flag := true ;
304
      Ledger.with_ephemeral_ledger ~f:(fun dest_ledger ->
305
          Thread_safe.block_on_async_exn (fun () ->
306
              print_heartbeat hb_logger |> don't_wait_for ;
307
              let%bind frontier =
308
                create_root_frontier ~logger ~pids Test_genesis_ledger.accounts
309
              in
310
              let source_ledger =
311
                Transition_frontier.For_tests.root_snarked_ledger frontier
312
                |> Ledger.of_database
313
              in
314
              let desired_root = Ledger.merkle_root source_ledger in
315
              let sync_ledger =
316
                Sync_ledger.Mask.create dest_ledger ~logger ~trust_system
317
              in
318
              let query_reader = Sync_ledger.Mask.query_reader sync_ledger in
319
              let answer_writer = Sync_ledger.Mask.answer_writer sync_ledger in
320
              let peer =
321
                Network_peer.Peer.create Unix.Inet_addr.localhost
322
                  ~discovery_port:0 ~communication_port:1
323
              in
324
              let network =
325
                Network.create_stub ~logger
326
                  ~ip_table:
327
                    (Hashtbl.of_alist_exn
328
                       (module Unix.Inet_addr)
329
                       [(peer.host, frontier)])
330
                  ~peers:(Hash_set.of_list (module Network_peer.Peer) [peer])
331
              in
332
              Network.glue_sync_ledger network query_reader answer_writer ;
333
              match%map
334
                Sync_ledger.Mask.fetch sync_ledger desired_root ~data:()
335
                  ~equal:(fun () () -> true)
336
              with
337
              | `Ok synced_ledger ->
338
                  heartbeat_flag := false ;
339
                  Ledger_hash.equal
340
                    (Ledger.merkle_root dest_ledger)
341
                    (Ledger.merkle_root source_ledger)
342
                  && Ledger_hash.equal
343
                       (Ledger.merkle_root synced_ledger)
344
                       (Ledger.merkle_root source_ledger)
345
              | `Target_changed _ ->
346
                  heartbeat_flag := false ;
347
                  failwith "target of sync_ledger should not change" ) )
348

349
    let to_external_transition breadcrumb =
350
      Transition_frontier.Breadcrumb.validated_transition breadcrumb
351
      |> Mina_block.Validated.forget
352

353
    let%test "a node should be able to give a valid proof of their root" =
354
      heartbeat_flag := true ;
355
      let max_length = 4 in
356
      (* Generating this many breadcrumbs will ernsure the transition_frontier to be full  *)
357
      let num_breadcrumbs = max_length + 2 in
358
      Thread_safe.block_on_async_exn (fun () ->
359
          print_heartbeat hb_logger |> don't_wait_for ;
360
          let%bind frontier =
361
            create_root_frontier ~logger ~pids Test_genesis_ledger.accounts
362
          in
363
          let%bind () =
364
            build_frontier_randomly frontier
365
              ~gen_root_breadcrumb_builder:
366
                (gen_linear_breadcrumbs ~logger ~pids ~trust_system
367
                   ~size:num_breadcrumbs
368
                   ~accounts_with_secret_keys:Test_genesis_ledger.accounts)
369
          in
370
          let seen_transition =
371
            Transition_frontier.(
372
              all_breadcrumbs frontier |> List.permute |> List.hd_exn
373
              |> Breadcrumb.validated_transition)
374
          in
375
          let observed_state =
376
            Mina_block.Validated.protocol_state seen_transition
377
            |> Protocol_state.consensus_state
378
          in
379
          let root_with_proof =
380
            Option.value_exn ~message:"Could not produce an ancestor proof"
381
              (Sync_handler.Root.prove ~logger ~frontier observed_state)
382
          in
383
          let%bind verify =
384
            f_with_verifier ~f:Sync_handler.Root.verify ~logger ~pids
385
          in
386
          let%map `Root (root_transition, _), `Best_tip (best_tip_transition, _)
387
              =
388
            verify observed_state root_with_proof |> Deferred.Or_error.ok_exn
389
          in
390
          heartbeat_flag := false ;
391
          Mina_block.(
392
            equal
393
              (With_hash.data root_transition)
394
              (to_external_transition (Transition_frontier.root frontier))
395
            && equal
396
                 (With_hash.data best_tip_transition)
397
                 (to_external_transition
398
                    (Transition_frontier.best_tip frontier))) )
399
  end )
400
*)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc