19377040467

Committed 14 Nov 2025 08:40PM UTC coverage: 72.495% (+0.5%) from 71.955%

Build # 19377040467

Build Type

push

github

Committed by

heathcliff26

Commit Message

upgrade-controller: Add more verbose logging

Enable more verbose logging by allowing configuration of log levels via
environment variable.
Fix e2e test overwriting kubeconfig.

Signed-off-by: Heathcliff <heathcliff@heathcliff.eu>

Run Details

42 of 47 new or added lines in 4 files covered. (89.36%)

1049 of 1447 relevant lines covered (72.49%)

11.44 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

91.67

/pkg/upgrade-controller/controller/log.go

package controller

import (
        "flag"
        "os"
        "strconv"
        "strings"

        "k8s.io/klog/v2"
        ctrl "sigs.k8s.io/controller-runtime"
)

const logLevelEnv = "LOG_LEVEL"

const (
        logLevelDebug = 4
        logLevelInfo  = 0
        logLevelWarn  = -4
)

func init() {
        var fs flag.FlagSet
        klog.InitFlags(&fs)
        err := fs.Set("v", strconv.Itoa(getLogLevel()))
        if err != nil {
                klog.Fatalf("Failed to set klog verbosity: %v", err)
        }
        logger := klog.NewKlogr()
        ctrl.SetLogger(logger)
        logger.WithValues(logLevelEnv, os.Getenv(logLevelEnv), "level", getLogLevel()).Info("Logger initialized")
}

func getLogLevel() int {
        levelStr := os.Getenv(logLevelEnv)
        switch strings.ToLower(levelStr) {
        case "debug":
                return logLevelDebug
        case "info":
                return logLevelInfo
        case "warn":
                return logLevelWarn
        case "":
                return logLevelInfo
        default:
                klog.Warningf("Unknown log level '%s', defaulting to 'info'", levelStr)
                return logLevelInfo
        }
}

1	package controller
2
3	import (
4	"flag"
5	"os"
6	"strconv"
7	"strings"
8
9	"k8s.io/klog/v2"
10	ctrl "sigs.k8s.io/controller-runtime"
11	)
12
13	const logLevelEnv = "LOG_LEVEL"
14
15	const (
16	logLevelDebug = 4
17	logLevelInfo = 0
18	logLevelWarn = -4
19	)
20
21	func init() {	2✔
22	var fs flag.FlagSet	2✔
23	klog.InitFlags(&fs)	2✔
24	err := fs.Set("v", strconv.Itoa(getLogLevel()))	2✔
25	if err != nil {	2✔
NEW 26	klog.Fatalf("Failed to set klog verbosity: %v", err)	×
NEW 27	}	×
28	logger := klog.NewKlogr()	2✔
29	ctrl.SetLogger(logger)	2✔
30	logger.WithValues(logLevelEnv, os.Getenv(logLevelEnv), "level", getLogLevel()).Info("Logger initialized")	2✔
31	}
32
33	func getLogLevel() int {	11✔
34	levelStr := os.Getenv(logLevelEnv)	11✔
35	switch strings.ToLower(levelStr) {	11✔
36	case "debug":	2✔
37	return logLevelDebug	2✔
38	case "info":	1✔
39	return logLevelInfo	1✔
40	case "warn":	2✔
41	return logLevelWarn	2✔
42	case "":	5✔
43	return logLevelInfo	5✔
44	default:	1✔
45	klog.Warningf("Unknown log level '%s', defaulting to 'info'", levelStr)	1✔
46	return logLevelInfo	1✔
47	}
48	}

heathcliff26 / kube-upgrade / 19377040467

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous