gcivil-nyu-org / team4-wed-fall25 / 48

Committed 01 Nov 2025 10:12PM UTC coverage: 60.699% (-2.5%) from 63.213%

Build # 48

Build Type

push

travis-pro

Committed by

web-flow

Commit Message

Merge pull request #71 from gcivil-nyu-org/fix/uploader_bugs

fixed uploader bugs

Run Details

17 of 55 new or added lines in 4 files covered. (30.91%)

1 existing line in 1 file now uncovered.

434 of 715 relevant lines covered (60.7%)

0.61 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

33.33

/note2webapp/forms.py

from django import forms
from .models import ModelUpload, ModelVersion


# -------------------------
# Upload Form (for new upload)
# -------------------------
class UploadForm(forms.ModelForm):
    class Meta:
        model = ModelUpload
        fields = ["name"]


# -------------------------
# Version Form (for new version)
# -------------------------
class VersionForm(forms.ModelForm):
    class Meta:
        model = ModelVersion
        fields = ["model_file", "predict_file", "schema_file", "tag", "category"]
        widgets = {
            "model_file": forms.FileInput(attrs={"required": False}),
            "predict_file": forms.FileInput(attrs={"required": False}),
            "schema_file": forms.FileInput(attrs={"required": False}),
        }

    def __init__(self, *args, **kwargs):
        super().__init__(*args, **kwargs)
        # Don't set required in __init__ - let JavaScript handle validation
        self.fields["model_file"].required = False
        self.fields["predict_file"].required = False
        self.fields["schema_file"].required = False
        # Add help text
        self.fields["model_file"].help_text = "Required: Upload your .pt model file"
        self.fields["predict_file"].help_text = (
            "Required: Upload your .py prediction script"
        )
        self.fields["schema_file"].help_text = "Required: Upload your .json schema file"

    def clean(self):
        cleaned_data = super().clean()
        model_file = cleaned_data.get("model_file")
        predict_file = cleaned_data.get("predict_file")
        schema_file = cleaned_data.get("schema_file")
        # Backend validation - this runs after JavaScript
        if not model_file:
            raise forms.ValidationError("Model file (.pt) is required")
        if not predict_file:
            raise forms.ValidationError("Predict file (.py) is required")
        if not schema_file:
            raise forms.ValidationError("Schema file (.json) is required")
        return cleaned_data

    def clean_model_file(self):
        file = self.cleaned_data.get("model_file")
        if file and not file.name.endswith(".pt"):
            raise forms.ValidationError("Only .pt files are allowed for Model File")
        return file

    def clean_predict_file(self):
        file = self.cleaned_data.get("predict_file")
        if file and not file.name.endswith(".py"):
            raise forms.ValidationError("Only .py files are allowed for Predict File")
        return file

    def clean_schema_file(self):
        file = self.cleaned_data.get("schema_file")
        if file and not file.name.endswith(".json"):
            raise forms.ValidationError("Only .json files allowed for schema")
        return file

    def clean_tag(self):
        tag = self.cleaned_data.get("tag")
        if not tag:
            raise forms.ValidationError("Tag is required")
        return tag

1	from django import forms	1✔
2	from .models import ModelUpload, ModelVersion	1✔
3
4
5	# -------------------------
6	# Upload Form (for new upload)
7	# -------------------------
8	class UploadForm(forms.ModelForm):	1✔
9	class Meta:	1✔
10	model = ModelUpload	1✔
11	fields = ["name"]	1✔
12
13
14	# -------------------------
15	# Version Form (for new version)
16	# -------------------------
17	class VersionForm(forms.ModelForm):	1✔
18	class Meta:	1✔
19	model = ModelVersion	1✔
20	fields = ["model_file", "predict_file", "schema_file", "tag", "category"]	1✔
21	widgets = {	1✔
22	"model_file": forms.FileInput(attrs={"required": False}),
23	"predict_file": forms.FileInput(attrs={"required": False}),
24	"schema_file": forms.FileInput(attrs={"required": False}),
25	}
26
27	def __init__(self, args, *kwargs):	1✔
NEW 28	super().__init__(args, *kwargs)	×
29	# Don't set required in __init__ - let JavaScript handle validation
NEW 30	self.fields["model_file"].required = False	×
NEW 31	self.fields["predict_file"].required = False	×
NEW 32	self.fields["schema_file"].required = False	×
33	# Add help text
NEW 34	self.fields["model_file"].help_text = "Required: Upload your .pt model file"	×
NEW 35	self.fields["predict_file"].help_text = (	×
36	"Required: Upload your .py prediction script"
37	)
NEW 38	self.fields["schema_file"].help_text = "Required: Upload your .json schema file"	×
39
40	def clean(self):	1✔
NEW 41	cleaned_data = super().clean()	×
NEW 42	model_file = cleaned_data.get("model_file")	×
NEW 43	predict_file = cleaned_data.get("predict_file")	×
NEW 44	schema_file = cleaned_data.get("schema_file")	×
45	# Backend validation - this runs after JavaScript
NEW 46	if not model_file:	×
NEW 47	raise forms.ValidationError("Model file (.pt) is required")	×
NEW 48	if not predict_file:	×
NEW 49	raise forms.ValidationError("Predict file (.py) is required")	×
NEW 50	if not schema_file:	×
NEW 51	raise forms.ValidationError("Schema file (.json) is required")	×
NEW 52	return cleaned_data	×
53
54	def clean_model_file(self):	1✔
55	file = self.cleaned_data.get("model_file")	×
56	if file and not file.name.endswith(".pt"):	×
57	raise forms.ValidationError("Only .pt files are allowed for Model File")	×
58	return file	×
59
60	def clean_predict_file(self):	1✔
61	file = self.cleaned_data.get("predict_file")	×
62	if file and not file.name.endswith(".py"):	×
63	raise forms.ValidationError("Only .py files are allowed for Predict File")	×
64	return file	×
65
66	def clean_schema_file(self):	1✔
67	file = self.cleaned_data.get("schema_file")	×
68	if file and not file.name.endswith(".json"):	×
69	raise forms.ValidationError("Only .json files allowed for schema")	×
70	return file	×
71
72	def clean_tag(self):	1✔
73	tag = self.cleaned_data.get("tag")	×
74	if not tag:	×
75	raise forms.ValidationError("Tag is required")	×
76	return tag	×

gcivil-nyu-org / team4-wed-fall25 / 48

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous