18918018923

Committed 29 Oct 2025 06:18PM UTC coverage: 83.709%. Remained the same

Build # 18918018923

Build Type

push

github

Committed by

web-flow

Commit Message

Improve type checking and accept linting changes (PP-3166) (#73)

## Description

- Removes type checking exemptions in almost all cases.
- In the couple cases that remain, they have been narrowed
substantially.
- Fixes a bunch of types and associated type errors.
- Re-enables `prettier` linting and accepts associated `eslint` fixes.
- Reduces some unneeded complexity.

## Motivation and Context

We were doing a lot of project- and module-level suppressing of type and
linting errors. This meant that it was easy to introduce new errors into
the code.

[Jira PP-3166]

## How Has This Been Tested?

- Manually testing locally.
- Lint checks and tests pass, no tsc error output, and builds succeed
locally.
- [CI
checks](https://github.com/ThePalaceProject/web-patron/actions/runs/18895160040)
pass.

## Checklist:

- [x] I have updated the documentation accordingly.
- [x] All new and existing tests passed.

Coverage Stats

832 of 1086 branches covered (76.61%)

Branch coverage included in aggregate %.

34 of 40 new or added lines in 11 files covered. (85.0%)

35 existing lines in 12 files now uncovered.

1434 of 1621 relevant lines covered (88.46%)

28.77 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.62

/src/auth/BasicTokenAuthHandler.tsx

Build SHA Not Found

The commit SHA "5012d63a2d2413fee9d6787f79be118602528533" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

ThePalaceProject / web-patron / 18918018923

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous