• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4822

27 Oct 2025 05:42AM UTC coverage: 59.732% (+1.0%) from 58.728%
#4822

push

travis-ci

web-flow
Merge pull request #33377 from taosdata/fix/main/rename-udf-path

fix: update UDF example links to correct file paths

121214 of 258518 branches covered (46.89%)

Branch coverage included in aggregate %.

193636 of 268583 relevant lines covered (72.1%)

4002399.5 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

55.51
/source/dnode/vnode/src/meta/metaTable2.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "meta.h"
17

18
extern int32_t metaHandleEntry2(SMeta *pMeta, const SMetaEntry *pEntry);
19
extern int32_t metaUpdateMetaRsp(tb_uid_t uid, char *tbName, SSchemaWrapper *pSchema, STableMetaRsp *pMetaRsp);
20
extern int32_t metaUpdateVtbMetaRsp(SMetaEntry *pEntry, char *tbName, SSchemaWrapper *pSchema, SColRefWrapper *pRef,
21
                                    STableMetaRsp *pMetaRsp, int8_t tableType);
22
extern int32_t metaFetchEntryByUid(SMeta *pMeta, int64_t uid, SMetaEntry **ppEntry);
23
extern int32_t metaFetchEntryByName(SMeta *pMeta, const char *name, SMetaEntry **ppEntry);
24
extern void    metaFetchEntryFree(SMetaEntry **ppEntry);
25
extern int32_t updataTableColCmpr(SColCmprWrapper *pWp, SSchema *pSchema, int8_t add, uint32_t compress);
26
extern int32_t addTableExtSchema(SMetaEntry *pEntry, const SSchema *pColumn, int32_t newColNum, SExtSchema *pExtSchema);
27
extern int32_t dropTableExtSchema(SMetaEntry *pEntry, int32_t dropColId, int32_t newColNum);
28

29
static int32_t metaCheckCreateSuperTableReq(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
21,399✔
30
  int32_t   vgId = TD_VID(pMeta->pVnode);
21,399✔
31
  void     *value = NULL;
21,399✔
32
  int32_t   valueSize = 0;
21,399✔
33
  SMetaInfo info;
34

35
  // check name
36
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
21,399!
37
    metaError("vgId:%d, %s failed at %s:%d since invalid name:%s, version:%" PRId64, vgId, __func__, __FILE__, __LINE__,
×
38
              pReq->name, version);
39
    return TSDB_CODE_INVALID_MSG;
×
40
  }
41

42
  int32_t r = tdbTbGet(pMeta->pNameIdx, pReq->name, strlen(pReq->name) + 1, &value, &valueSize);
21,402✔
43
  if (r == 0) {  // name exists, check uid and type
21,387✔
44
    int64_t uid = *(tb_uid_t *)value;
3✔
45
    tdbFree(value);
3✔
46

47
    if (pReq->suid != uid) {
3!
48
      metaError("vgId:%d, %s failed at %s:%d since table %s uid:%" PRId64 " already exists, request uid:%" PRId64
3!
49
                " version:%" PRId64,
50
                vgId, __func__, __FILE__, __LINE__, pReq->name, uid, pReq->suid, version);
51
      return TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
3✔
52
    }
53

54
    if (metaGetInfo(pMeta, uid, &info, NULL) == TSDB_CODE_NOT_FOUND) {
×
55
      metaError("vgId:%d, %s failed at %s:%d since table %s uid:%" PRId64
×
56
                " not found, this is an internal error in meta, version:%" PRId64,
57
                vgId, __func__, __FILE__, __LINE__, pReq->name, uid, version);
58
      return TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
59
    }
60

61
    if (info.uid == info.suid) {
×
62
      return TSDB_CODE_TDB_STB_ALREADY_EXIST;
×
63
    } else {
64
      metaError("vgId:%d, %s failed at %s:%d since table %s uid:%" PRId64
×
65
                " already exists but not a super table, version:%" PRId64,
66
                vgId, __func__, __FILE__, __LINE__, pReq->name, uid, version);
67
      return TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
×
68
    }
69
  }
70

71
  // check suid
72
  if (metaGetInfo(pMeta, pReq->suid, &info, NULL) != TSDB_CODE_NOT_FOUND) {
21,384!
73
    metaError("vgId:%d, %s failed at %s:%d since table with uid:%" PRId64 " already exist, name:%s version:%" PRId64,
×
74
              vgId, __func__, __FILE__, __LINE__, pReq->suid, pReq->name, version);
75
    return TSDB_CODE_INVALID_MSG;
×
76
  }
77

78
  return TSDB_CODE_SUCCESS;
21,376✔
79
}
80

81
static int32_t metaCheckDropTableReq(SMeta *pMeta, int64_t version, SVDropTbReq *pReq) {
15,913✔
82
  int32_t   code = TSDB_CODE_SUCCESS;
15,913✔
83
  void     *value = NULL;
15,913✔
84
  int32_t   valueSize = 0;
15,913✔
85
  SMetaInfo info;
86

87
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
15,913!
88
    metaError("vgId:%d, %s failed at %s:%d since invalid name:%s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
89
              __FILE__, __LINE__, pReq->name, version);
90
    return TSDB_CODE_INVALID_MSG;
×
91
  }
92

93
  code = tdbTbGet(pMeta->pNameIdx, pReq->name, strlen(pReq->name) + 1, &value, &valueSize);
15,913✔
94
  if (TSDB_CODE_SUCCESS != code) {
15,913!
95
    if (pReq->igNotExists) {
×
96
      metaTrace("vgId:%d, %s success since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
97
                pReq->name, version);
98
    } else {
99
      metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode),
×
100
                __func__, __FILE__, __LINE__, pReq->name, version);
101
    }
102
    return TSDB_CODE_TDB_TABLE_NOT_EXIST;
×
103
  }
104
  pReq->uid = *(tb_uid_t *)value;
15,913✔
105
  tdbFreeClear(value);
15,913✔
106

107
  code = metaGetInfo(pMeta, pReq->uid, &info, NULL);
15,913✔
108
  if (TSDB_CODE_SUCCESS != code) {
15,913!
109
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64
×
110
              " not found, this is an internal error, version:%" PRId64,
111
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pReq->uid, version);
112
    code = TSDB_CODE_INTERNAL_ERROR;
×
113
    return code;
×
114
  }
115
  pReq->suid = info.suid;
15,913✔
116

117
  return code;
15,913✔
118
}
119

120
static int32_t metaCheckDropSuperTableReq(SMeta *pMeta, int64_t version, SVDropStbReq *pReq) {
1,886✔
121
  int32_t   code = TSDB_CODE_SUCCESS;
1,886✔
122
  void     *value = NULL;
1,886✔
123
  int32_t   valueSize = 0;
1,886✔
124
  SMetaInfo info;
125

126
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
1,886!
127
    metaError("vgId:%d, %s failed at %s:%d since invalid name:%s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
128
              __FILE__, __LINE__, pReq->name, version);
129
    return TSDB_CODE_INVALID_MSG;
×
130
  }
131

132
  code = tdbTbGet(pMeta->pNameIdx, pReq->name, strlen(pReq->name) + 1, &value, &valueSize);
1,886✔
133
  if (code) {
1,885✔
134
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
1!
135
              __FILE__, __LINE__, pReq->name, version);
136
    return TSDB_CODE_TDB_STB_NOT_EXIST;
1✔
137
  } else {
138
    int64_t uid = *(int64_t *)value;
1,884✔
139
    tdbFreeClear(value);
1,884✔
140

141
    if (uid != pReq->suid) {
1,885✔
142
      metaError("vgId:%d, %s failed at %s:%d since table %s uid:%" PRId64 " not match, version:%" PRId64,
1!
143
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pReq->suid, version);
144
      return TSDB_CODE_TDB_STB_NOT_EXIST;
1✔
145
    }
146
  }
147

148
  code = metaGetInfo(pMeta, pReq->suid, &info, NULL);
1,884✔
149
  if (code) {
1,883!
150
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64
×
151
              " not found, this is an internal error, version:%" PRId64,
152
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pReq->suid, version);
153
    return TSDB_CODE_INTERNAL_ERROR;
×
154
  }
155
  if (info.suid != info.uid) {
1,883!
156
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64 " is not a super table, version:%" PRId64,
×
157
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pReq->suid, version);
158
    return TSDB_CODE_INVALID_MSG;
×
159
  }
160
  return code;
1,883✔
161
}
162

163
// Create Super Table
164
int32_t metaCreateSuperTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
21,314✔
165
  int32_t code = TSDB_CODE_SUCCESS;
21,314✔
166

167
  // check request
168
  code = metaCheckCreateSuperTableReq(pMeta, version, pReq);
21,314✔
169
  if (code != TSDB_CODE_SUCCESS) {
21,377✔
170
    if (code == TSDB_CODE_TDB_STB_ALREADY_EXIST) {
3!
171
      metaWarn("vgId:%d, super table %s uid:%" PRId64 " already exists, version:%" PRId64, TD_VID(pMeta->pVnode),
×
172
               pReq->name, pReq->suid, version);
173
      TAOS_RETURN(TSDB_CODE_SUCCESS);
×
174
    } else {
175
      TAOS_RETURN(code);
3✔
176
    }
177
  }
178

179
  // handle entry
180
  SMetaEntry entry = {
21,374✔
181
      .version = version,
182
      .type = TSDB_SUPER_TABLE,
183
      .uid = pReq->suid,
21,374✔
184
      .name = pReq->name,
21,374✔
185
      .stbEntry.schemaRow = pReq->schemaRow,
186
      .stbEntry.schemaTag = pReq->schemaTag,
187
      .stbEntry.keep = pReq->keep,
21,374✔
188
  };
189
  if (pReq->rollup) {
21,374!
190
    TABLE_SET_ROLLUP(entry.flags);
×
191
    entry.stbEntry.rsmaParam = pReq->rsmaParam;
×
192
  }
193
  if (pReq->colCmpred) {
21,374!
194
    TABLE_SET_COL_COMPRESSED(entry.flags);
21,375✔
195
    entry.colCmpr = pReq->colCmpr;
21,375✔
196
  }
197

198
  entry.pExtSchemas = pReq->pExtSchemas;
21,374✔
199

200
  if (pReq->virtualStb) {
21,374✔
201
    TABLE_SET_VIRTUAL(entry.flags);
107✔
202
  }
203

204
  code = metaHandleEntry2(pMeta, &entry);
21,374✔
205
  if (TSDB_CODE_SUCCESS == code) {
21,404!
206
    metaInfo("vgId:%d, super table %s suid:%" PRId64 " is created, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->name,
21,404!
207
             pReq->suid, version);
208
  } else {
209
    metaError("vgId:%d, failed to create stb:%s uid:%" PRId64 " since %s", TD_VID(pMeta->pVnode), pReq->name,
×
210
              pReq->suid, tstrerror(code));
211
  }
212
  TAOS_RETURN(code);
21,404✔
213
}
214

215
// Drop Super Table
216
int32_t metaDropSuperTable(SMeta *pMeta, int64_t verison, SVDropStbReq *pReq) {
1,886✔
217
  int32_t code = TSDB_CODE_SUCCESS;
1,886✔
218

219
  // check request
220
  code = metaCheckDropSuperTableReq(pMeta, verison, pReq);
1,886✔
221
  if (code) {
1,885✔
222
    TAOS_RETURN(code);
2✔
223
  }
224

225
  // handle entry
226
  SMetaEntry entry = {
1,883✔
227
      .version = verison,
228
      .type = -TSDB_SUPER_TABLE,
229
      .uid = pReq->suid,
1,883✔
230
  };
231
  code = metaHandleEntry2(pMeta, &entry);
1,883✔
232
  if (code) {
1,884!
233
    metaError("vgId:%d, failed to drop stb:%s uid:%" PRId64 " since %s", TD_VID(pMeta->pVnode), pReq->name, pReq->suid,
×
234
              tstrerror(code));
235
  } else {
236
    metaInfo("vgId:%d, super table %s uid:%" PRId64 " is dropped, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->name,
1,884!
237
             pReq->suid, verison);
238
  }
239
  TAOS_RETURN(code);
1,884✔
240
}
241

242
// Alter Super Table
243

244
// Create Child Table
245
static int32_t metaCheckCreateChildTableReq(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq) {
107,741✔
246
  int32_t   code = TSDB_CODE_SUCCESS;
107,741✔
247
  void     *value = NULL;
107,741✔
248
  int32_t   valueSize = 0;
107,741✔
249
  SMetaInfo info;
250

251
  if (NULL == pReq->name || strlen(pReq->name) == 0 || NULL == pReq->ctb.stbName || strlen(pReq->ctb.stbName) == 0 ||
107,741!
252
      pReq->ctb.suid == 0) {
107,741!
253
    metaError("vgId:%d, %s failed at %s:%d since invalid name:%s stb name:%s, version:%" PRId64, TD_VID(pMeta->pVnode),
×
254
              __func__, __FILE__, __LINE__, pReq->name, pReq->ctb.stbName, version);
255
    return TSDB_CODE_INVALID_MSG;
×
256
  }
257

258
  // check table existence
259
  if (tdbTbGet(pMeta->pNameIdx, pReq->name, strlen(pReq->name) + 1, &value, &valueSize) == 0) {
107,742✔
260
    pReq->uid = *(int64_t *)value;
2,867✔
261
    tdbFreeClear(value);
2,867✔
262

263
    if (metaGetInfo(pMeta, pReq->uid, &info, NULL) != 0) {
2,866!
264
      metaError("vgId:%d, %s failed at %s:%d since cannot find table with uid %" PRId64
×
265
                ", which is an internal error, version:%" PRId64,
266
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->uid, version);
267
      return TSDB_CODE_INTERNAL_ERROR;
×
268
    }
269

270
    // check table type
271
    if (info.suid == info.uid || info.suid == 0) {
2,862!
272
      metaError("vgId:%d, %s failed at %s:%d since table with uid %" PRId64 " is not a super table, version:%" PRId64,
3!
273
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->uid, version);
274
      return TSDB_CODE_TDB_TABLE_IN_OTHER_STABLE;
3✔
275
    }
276

277
    // check suid
278
    if (info.suid != pReq->ctb.suid) {
2,859!
279
      metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64 " exists in another stable with uid %" PRId64
×
280
                " instead of stable with uid %" PRId64 " version:%" PRId64,
281
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pReq->uid, info.suid, pReq->ctb.suid,
282
                version);
283
      return TSDB_CODE_TDB_TABLE_IN_OTHER_STABLE;
×
284
    }
285

286
    return TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
2,859✔
287
  }
288

289
  // check super table existence
290
  SMetaEntry *pStbEntry = NULL;
104,868✔
291
  code = metaFetchEntryByName(pMeta, pReq->ctb.stbName, &pStbEntry);
104,868✔
292
  if (code) {
104,849✔
293
    metaError("vgId:%d, %s failed at %s:%d since super table %s does not exist, version:%" PRId64,
3!
294
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->ctb.stbName, version);
295
    return TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
296
  }
297

298
  if (pStbEntry->type != TSDB_SUPER_TABLE) {
104,846!
299
    metaError("vgId:%d, %s failed at %s:%d since table %s is not a super table, version:%" PRId64,
×
300
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->ctb.stbName, version);
301
    metaFetchEntryFree(&pStbEntry);
×
302
    return TSDB_CODE_INVALID_MSG;
×
303
  }
304

305
  if (pStbEntry->uid != pReq->ctb.suid) {
104,846!
306
    metaError("vgId:%d, %s failed at %s:%d since super table %s uid %" PRId64 " does not match request uid %" PRId64
×
307
              ", version:%" PRId64,
308
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->ctb.stbName, pStbEntry->uid, pReq->ctb.suid,
309
              version);
310
    metaFetchEntryFree(&pStbEntry);
×
311
    return TSDB_CODE_PAR_TABLE_NOT_EXIST;
×
312
  }
313

314
  // Check tag value
315
  SSchemaWrapper *pTagSchema = &pStbEntry->stbEntry.schemaTag;
104,846✔
316
  const STag     *pTag = (const STag *)pReq->ctb.pTag;
104,846✔
317
  if (pTagSchema->nCols != 1 || pTagSchema->pSchema[0].type != TSDB_DATA_TYPE_JSON) {
104,846✔
318
    for (int32_t i = 0; i < pTagSchema->nCols; ++i) {
549,585✔
319
      STagVal tagVal = {
445,435✔
320
          .cid = pTagSchema->pSchema[i].colId,
445,435✔
321
      };
322

323
      if (tTagGet(pTag, &tagVal)) {
445,435✔
324
        if (pTagSchema->pSchema[i].type != tagVal.type) {
362,817!
325
          metaError("vgId:%d, %s failed at %s:%d since child table %s tag type does not match the expected type, version:%" PRId64,
×
326
                    TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, version);
327
          metaFetchEntryFree(&pStbEntry);
×
328
          return TSDB_CODE_INVALID_MSG;
×
329
        }
330
      }
331
    }
332
  }
333

334
  metaFetchEntryFree(&pStbEntry);
104,830✔
335

336
  // check grant
337
  if (!metaTbInFilterCache(pMeta, pReq->ctb.stbName, 1)) {
104,869!
338
    code = grantCheck(TSDB_GRANT_TIMESERIES);
104,867✔
339
    if (TSDB_CODE_SUCCESS != code) {
104,840!
340
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
341
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
342
    }
343
  }
344
  return code;
104,836✔
345
}
346

347
static int32_t metaBuildCreateChildTableRsp(SMeta *pMeta, const SMetaEntry *pEntry, STableMetaRsp **ppRsp) {
104,472✔
348
  int32_t code = TSDB_CODE_SUCCESS;
104,472✔
349

350
  if (NULL == ppRsp) {
104,472!
351
    return code;
×
352
  }
353

354
  *ppRsp = taosMemoryCalloc(1, sizeof(STableMetaRsp));
104,472!
355
  if (NULL == ppRsp) {
104,490!
356
    return terrno;
×
357
  }
358

359
  (*ppRsp)->tableType = TSDB_CHILD_TABLE;
104,490✔
360
  (*ppRsp)->tuid = pEntry->uid;
104,490✔
361
  (*ppRsp)->suid = pEntry->ctbEntry.suid;
104,490✔
362
  tstrncpy((*ppRsp)->tbName, pEntry->name, TSDB_TABLE_NAME_LEN);
104,490✔
363

364
  return code;
104,490✔
365
}
366

367
static int32_t metaCreateChildTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq, STableMetaRsp **ppRsp) {
107,373✔
368
  int32_t code = TSDB_CODE_SUCCESS;
107,373✔
369

370
  // check request
371
  code = metaCheckCreateChildTableReq(pMeta, version, pReq);
107,373✔
372
  if (code) {
107,330✔
373
    if (TSDB_CODE_TDB_TABLE_ALREADY_EXIST != code) {
2,862✔
374
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
3!
375
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
376
    }
377
    return code;
2,861✔
378
  }
379

380
  SMetaEntry entry = {
104,468✔
381
      .version = version,
382
      .type = TSDB_CHILD_TABLE,
383
      .uid = pReq->uid,
104,468✔
384
      .name = pReq->name,
104,468✔
385
      .ctbEntry.btime = pReq->btime,
104,468✔
386
      .ctbEntry.ttlDays = pReq->ttl,
104,468✔
387
      .ctbEntry.commentLen = pReq->commentLen,
104,468✔
388
      .ctbEntry.comment = pReq->comment,
104,468✔
389
      .ctbEntry.suid = pReq->ctb.suid,
104,468✔
390
      .ctbEntry.pTags = pReq->ctb.pTag,
104,468✔
391
  };
392

393
  // build response
394
  code = metaBuildCreateChildTableRsp(pMeta, &entry, ppRsp);
104,468✔
395
  if (code) {
104,497!
396
    metaError("vgId:%d, %s failed at %s:%d since %s", TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__,
×
397
              tstrerror(code));
398
  }
399

400
  // handle entry
401
  code = metaHandleEntry2(pMeta, &entry);
104,497✔
402
  if (TSDB_CODE_SUCCESS == code) {
104,470!
403
    metaInfo("vgId:%d, index:%" PRId64 ", child table is created, tb:%s uid:%" PRId64 " suid:%" PRId64,
104,471!
404
             TD_VID(pMeta->pVnode), version, pReq->name, pReq->uid, pReq->ctb.suid);
405
  } else {
406
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s suid:%" PRId64 " version:%" PRId64,
×
407
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name,
408
              pReq->ctb.suid, version);
409
  }
410
  return code;
104,513✔
411
}
412

413
// Drop Child Table
414

415
// Alter Child Table
416

417
// Create Normal Table
418
static int32_t metaCheckCreateNormalTableReq(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq) {
10,973✔
419
  int32_t code = 0;
10,973✔
420
  void   *value = NULL;
10,973✔
421
  int32_t valueSize = 0;
10,973✔
422

423
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
10,973!
424
    metaError("vgId:%d, %s failed at %s:%d since invalid name:%s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
425
              __FILE__, __LINE__, pReq->name, version);
426
    return TSDB_CODE_INVALID_MSG;
×
427
  }
428

429
  // check name
430
  if (tdbTbGet(pMeta->pNameIdx, pReq->name, strlen(pReq->name) + 1, &value, &valueSize) == 0) {
10,973✔
431
    // for auto create table, we return the uid of the existing table
432
    pReq->uid = *(tb_uid_t *)value;
159✔
433
    tdbFree(value);
159✔
434
    return TSDB_CODE_TDB_TABLE_ALREADY_EXIST;
159✔
435
  }
436

437
  // grant check
438
  code = grantCheck(TSDB_GRANT_TIMESERIES);
10,814✔
439
  if (code) {
10,814!
440
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
441
              __FILE__, __LINE__, tstrerror(code), version, pReq->name);
442
  }
443
  return code;
10,814✔
444
}
445

446
static int32_t metaBuildCreateNormalTableRsp(SMeta *pMeta, SMetaEntry *pEntry, STableMetaRsp **ppRsp) {
10,635✔
447
  int32_t code = TSDB_CODE_SUCCESS;
10,635✔
448

449
  if (NULL == ppRsp) {
10,635!
450
    return code;
×
451
  }
452

453
  *ppRsp = taosMemoryCalloc(1, sizeof(STableMetaRsp));
10,635!
454
  if (NULL == *ppRsp) {
10,635!
455
    return terrno;
×
456
  }
457

458
  code = metaUpdateMetaRsp(pEntry->uid, pEntry->name, &pEntry->ntbEntry.schemaRow, *ppRsp);
10,635✔
459
  if (code) {
10,635!
460
    taosMemoryFreeClear(*ppRsp);
×
461
    return code;
×
462
  }
463

464
  for (int32_t i = 0; i < pEntry->colCmpr.nCols; i++) {
122,252✔
465
    SColCmpr *p = &pEntry->colCmpr.pColCmpr[i];
111,617✔
466
    (*ppRsp)->pSchemaExt[i].colId = p->id;
111,617✔
467
    (*ppRsp)->pSchemaExt[i].compress = p->alg;
111,617✔
468
    if (pEntry->pExtSchemas) {
111,617✔
469
      (*ppRsp)->pSchemaExt[i].typeMod = pEntry->pExtSchemas[i].typeMod;
1,955✔
470
    }
471
  }
472

473
  return code;
10,635✔
474
}
475

476
static int32_t metaCreateNormalTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq, STableMetaRsp **ppRsp) {
10,794✔
477
  int32_t code = TSDB_CODE_SUCCESS;
10,794✔
478

479
  // check request
480
  code = metaCheckCreateNormalTableReq(pMeta, version, pReq);
10,794✔
481
  if (code) {
10,794✔
482
    if (TSDB_CODE_TDB_TABLE_ALREADY_EXIST != code) {
159!
483
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
484
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
485
    }
486
    TAOS_RETURN(code);
159✔
487
  }
488

489
  SMetaEntry entry = {
10,635✔
490
      .version = version,
491
      .type = TSDB_NORMAL_TABLE,
492
      .uid = pReq->uid,
10,635✔
493
      .name = pReq->name,
10,635✔
494
      .ntbEntry.btime = pReq->btime,
10,635✔
495
      .ntbEntry.ttlDays = pReq->ttl,
10,635✔
496
      .ntbEntry.commentLen = pReq->commentLen,
10,635✔
497
      .ntbEntry.comment = pReq->comment,
10,635✔
498
      .ntbEntry.schemaRow = pReq->ntb.schemaRow,
499
      .ntbEntry.ncid = pReq->ntb.schemaRow.pSchema[pReq->ntb.schemaRow.nCols - 1].colId + 1,
10,635✔
500
      .colCmpr = pReq->colCmpr,
501
      .pExtSchemas = pReq->pExtSchemas,
10,635✔
502
  };
503
  TABLE_SET_COL_COMPRESSED(entry.flags);
10,635✔
504

505
  // build response
506
  code = metaBuildCreateNormalTableRsp(pMeta, &entry, ppRsp);
10,635✔
507
  if (code) {
10,635!
508
    metaError("vgId:%d, %s failed at %s:%d since %s", TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__,
×
509
              tstrerror(code));
510
  }
511

512
  // handle entry
513
  code = metaHandleEntry2(pMeta, &entry);
10,635✔
514
  if (TSDB_CODE_SUCCESS == code) {
10,635!
515
    metaInfo("vgId:%d, index:%" PRId64 ", normal table is created, tb:%s uid:%" PRId64, TD_VID(pMeta->pVnode), version,
10,635!
516
             pReq->name, pReq->uid);
517
  } else {
518
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
519
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name, version);
520
  }
521
  TAOS_RETURN(code);
10,635✔
522
}
523

524
static int32_t metaBuildCreateVirtualNormalTableRsp(SMeta *pMeta, SMetaEntry *pEntry, STableMetaRsp **ppRsp) {
179✔
525
  int32_t code = TSDB_CODE_SUCCESS;
179✔
526

527
  if (NULL == ppRsp) {
179!
528
    return code;
×
529
  }
530

531
  *ppRsp = taosMemoryCalloc(1, sizeof(STableMetaRsp));
179!
532
  if (NULL == *ppRsp) {
179!
533
    return terrno;
×
534
  }
535

536
  code = metaUpdateVtbMetaRsp(pEntry, pEntry->name, &pEntry->ntbEntry.schemaRow, &pEntry->colRef, *ppRsp,
179✔
537
                              TSDB_VIRTUAL_NORMAL_TABLE);
538
  if (code) {
179!
539
    taosMemoryFreeClear(*ppRsp);
×
540
    return code;
×
541
  }
542

543
  return code;
179✔
544
}
545

546
static int32_t metaCreateVirtualNormalTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq, STableMetaRsp **ppRsp) {
179✔
547
  // check request
548
  int32_t code = metaCheckCreateNormalTableReq(pMeta, version, pReq);
179✔
549
  if (code) {
179!
550
    if (TSDB_CODE_TDB_TABLE_ALREADY_EXIST != code) {
×
551
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
552
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
553
    }
554
    TAOS_RETURN(code);
×
555
  }
556

557
  SMetaEntry entry = {.version = version,
179✔
558
                      .type = TSDB_VIRTUAL_NORMAL_TABLE,
559
                      .uid = pReq->uid,
179✔
560
                      .name = pReq->name,
179✔
561
                      .ntbEntry.btime = pReq->btime,
179✔
562
                      .ntbEntry.ttlDays = pReq->ttl,
179✔
563
                      .ntbEntry.commentLen = pReq->commentLen,
179✔
564
                      .ntbEntry.comment = pReq->comment,
179✔
565
                      .ntbEntry.schemaRow = pReq->ntb.schemaRow,
566
                      .ntbEntry.ncid = pReq->ntb.schemaRow.pSchema[pReq->ntb.schemaRow.nCols - 1].colId + 1,
179✔
567
                      .colRef = pReq->colRef};
568

569
  code = metaBuildCreateVirtualNormalTableRsp(pMeta, &entry, ppRsp);
179✔
570
  if (code) {
179!
571
    metaError("vgId:%d, %s failed at %s:%d since %s", TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__,
×
572
              tstrerror(code));
573
  }
574

575
  // handle entry
576
  code = metaHandleEntry2(pMeta, &entry);
179✔
577
  if (TSDB_CODE_SUCCESS == code) {
179!
578
    metaInfo("vgId:%d, index:%" PRId64 ", virtual normal table is created, tb:%s uid:%" PRId64, TD_VID(pMeta->pVnode),
179!
579
             version, pReq->name, pReq->uid);
580
  } else {
581
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
582
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name, version);
583
  }
584
  TAOS_RETURN(code);
179✔
585
#if 0
586
  metaTimeSeriesNotifyCheck(pMeta);
587
#endif
588
}
589

590
static int32_t metaBuildCreateVirtualChildTableRsp(SMeta *pMeta, SMetaEntry *pEntry, STableMetaRsp **ppRsp) {
368✔
591
  int32_t code = TSDB_CODE_SUCCESS;
368✔
592

593
  if (NULL == ppRsp) {
368!
594
    return code;
×
595
  }
596

597
  *ppRsp = taosMemoryCalloc(1, sizeof(STableMetaRsp));
368!
598
  if (NULL == *ppRsp) {
368!
599
    return terrno;
×
600
  }
601

602
  code = metaUpdateVtbMetaRsp(pEntry, pEntry->name, NULL, &pEntry->colRef, *ppRsp, TSDB_VIRTUAL_CHILD_TABLE);
368✔
603
  if (code) {
368!
604
    taosMemoryFreeClear(*ppRsp);
×
605
    return code;
×
606
  }
607
  (*ppRsp)->suid = pEntry->ctbEntry.suid;
368✔
608

609
  return code;
368✔
610
}
611

612
static int32_t metaCreateVirtualChildTable(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq, STableMetaRsp **ppRsp) {
368✔
613
  // check request
614
  int32_t code = metaCheckCreateChildTableReq(pMeta, version, pReq);
368✔
615
  if (code) {
368!
616
    if (TSDB_CODE_TDB_TABLE_ALREADY_EXIST != code) {
×
617
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
618
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
619
    }
620
    TAOS_RETURN(code);
×
621
  }
622

623
  SMetaEntry entry = {.version = version,
368✔
624
                      .type = TSDB_VIRTUAL_CHILD_TABLE,
625
                      .uid = pReq->uid,
368✔
626
                      .name = pReq->name,
368✔
627
                      .ctbEntry.btime = pReq->btime,
368✔
628
                      .ctbEntry.ttlDays = pReq->ttl,
368✔
629
                      .ctbEntry.commentLen = pReq->commentLen,
368✔
630
                      .ctbEntry.comment = pReq->comment,
368✔
631
                      .ctbEntry.suid = pReq->ctb.suid,
368✔
632
                      .ctbEntry.pTags = pReq->ctb.pTag,
368✔
633
                      .colRef = pReq->colRef};
634

635
  code = metaBuildCreateVirtualChildTableRsp(pMeta, &entry, ppRsp);
368✔
636
  if (code) {
368!
637
    metaError("vgId:%d, %s failed at %s:%d since %s", TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__,
×
638
              tstrerror(code));
639
  }
640

641
  // handle entry
642
  code = metaHandleEntry2(pMeta, &entry);
368✔
643
  if (TSDB_CODE_SUCCESS == code) {
368!
644
    metaInfo("vgId:%d, index:%" PRId64 ", virtual child table is created, tb:%s uid:%" PRId64, TD_VID(pMeta->pVnode),
368!
645
             version, pReq->name, pReq->uid);
646
  } else {
647
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
648
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name, version);
649
  }
650
  TAOS_RETURN(code);
368✔
651
#if 0
652
  metaTimeSeriesNotifyCheck(pMeta);
653
#endif
654
}
655

656
// Drop Normal Table
657

658
// Alter Normal Table
659

660
int32_t metaCreateTable2(SMeta *pMeta, int64_t version, SVCreateTbReq *pReq, STableMetaRsp **ppRsp) {
118,705✔
661
  int32_t code = TSDB_CODE_SUCCESS;
118,705✔
662
  if (TSDB_CHILD_TABLE == pReq->type) {
118,705✔
663
    code = metaCreateChildTable(pMeta, version, pReq, ppRsp);
107,375✔
664
  } else if (TSDB_NORMAL_TABLE == pReq->type) {
11,330✔
665
    code = metaCreateNormalTable(pMeta, version, pReq, ppRsp);
10,794✔
666
  } else if (TSDB_VIRTUAL_NORMAL_TABLE == pReq->type) {
536✔
667
    code = metaCreateVirtualNormalTable(pMeta, version, pReq, ppRsp);
179✔
668
  } else if (TSDB_VIRTUAL_CHILD_TABLE == pReq->type) {
357!
669
    code = metaCreateVirtualChildTable(pMeta, version, pReq, ppRsp);
368✔
670
  } else {
671
    code = TSDB_CODE_INVALID_MSG;
×
672
  }
673
  TAOS_RETURN(code);
118,704✔
674
}
675

676
int32_t metaDropTable2(SMeta *pMeta, int64_t version, SVDropTbReq *pReq) {
15,913✔
677
  int32_t code = TSDB_CODE_SUCCESS;
15,913✔
678

679
  // check request
680
  code = metaCheckDropTableReq(pMeta, version, pReq);
15,913✔
681
  if (code) {
15,913!
682
    if (TSDB_CODE_TDB_TABLE_NOT_EXIST != code) {
×
683
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
684
                __FILE__, __LINE__, tstrerror(code), version, pReq->name);
685
    }
686
    TAOS_RETURN(code);
×
687
  }
688

689
  if (pReq->suid == pReq->uid) {
15,913!
690
    code = TSDB_CODE_INVALID_PARA;
×
691
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
692
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name, version);
693
    TAOS_RETURN(code);
×
694
  }
695

696
  SMetaEntry entry = {
15,913✔
697
      .version = version,
698
      .uid = pReq->uid,
15,913✔
699
  };
700

701
  if (pReq->isVirtual) {
15,913✔
702
    if (pReq->suid == 0) {
88✔
703
      entry.type = -TSDB_VIRTUAL_NORMAL_TABLE;
44✔
704
    } else {
705
      entry.type = -TSDB_VIRTUAL_CHILD_TABLE;
44✔
706
    }
707
  } else {
708
    if (pReq->suid == 0) {
15,825✔
709
      entry.type = -TSDB_NORMAL_TABLE;
2,408✔
710
    } else {
711
      entry.type = -TSDB_CHILD_TABLE;
13,417✔
712
    }
713
  }
714
  code = metaHandleEntry2(pMeta, &entry);
15,913✔
715
  if (code) {
15,913!
716
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
717
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->uid, pReq->name, version);
718
  } else {
719
    metaInfo("vgId:%d, table %s uid %" PRId64 " is dropped, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->name,
15,913!
720
             pReq->uid, version);
721
  }
722
  TAOS_RETURN(code);
15,913✔
723
}
724

725
static int32_t metaCheckAlterTableColumnReq(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
6,556✔
726
  int32_t code = 0;
6,556✔
727

728
  if (NULL == pReq->colName || strlen(pReq->colName) == 0) {
6,556!
729
    metaError("vgId:%d, %s failed at %s:%d since invalid column name:%s, version:%" PRId64, TD_VID(pMeta->pVnode),
×
730
              __func__, __FILE__, __LINE__, pReq->colName, version);
731
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
732
  }
733

734
  // check name
735
  void   *value = NULL;
6,556✔
736
  int32_t valueSize = 0;
6,556✔
737
  code = tdbTbGet(pMeta->pNameIdx, pReq->tbName, strlen(pReq->tbName) + 1, &value, &valueSize);
6,556✔
738
  if (code) {
6,556!
739
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
740
              __FILE__, __LINE__, pReq->tbName, version);
741
    code = TSDB_CODE_TDB_TABLE_NOT_EXIST;
×
742
    TAOS_RETURN(code);
×
743
  }
744
  int64_t uid = *(int64_t *)value;
6,556✔
745
  tdbFreeClear(value);
6,556✔
746

747
  // check table type
748
  SMetaInfo info;
749
  if (metaGetInfo(pMeta, uid, &info, NULL) != 0) {
6,556!
750
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64
×
751
              " not found, this is an internal error in meta, version:%" PRId64,
752
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, uid, version);
753
    code = TSDB_CODE_INTERNAL_ERROR;
×
754
    TAOS_RETURN(code);
×
755
  }
756
  if (info.suid != 0 && pReq->action != TSDB_ALTER_TABLE_ALTER_COLUMN_REF &&
6,556✔
757
      pReq->action != TSDB_ALTER_TABLE_REMOVE_COLUMN_REF) {
46!
758
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64 " is not a normal table, version:%" PRId64,
×
759
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, uid, version);
760
    code = TSDB_CODE_VND_INVALID_TABLE_ACTION;
×
761
    TAOS_RETURN(code);
×
762
  }
763

764
  // check grant
765
  code = grantCheck(TSDB_GRANT_TIMESERIES);
6,556✔
766
  if (code) {
6,556!
767
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64 " name:%s", TD_VID(pMeta->pVnode), __func__,
×
768
              __FILE__, __LINE__, tstrerror(code), version, pReq->tbName);
769
    TAOS_RETURN(code);
×
770
  }
771
  TAOS_RETURN(code);
6,556✔
772
}
773

774
int32_t metaAddTableColumn(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
5,297✔
775
  int32_t code = TSDB_CODE_SUCCESS;
5,297✔
776

777
  // check request
778
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
5,297✔
779
  if (code) {
5,297!
780
    TAOS_RETURN(code);
×
781
  }
782

783
  // fetch old entry
784
  SMetaEntry *pEntry = NULL;
5,297✔
785
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
5,297✔
786
  if (code) {
5,297!
787
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
788
              __FILE__, __LINE__, pReq->tbName, version);
789
    TAOS_RETURN(code);
×
790
  }
791
  if (pEntry->version >= version) {
5,297!
792
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
793
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
794
    metaFetchEntryFree(&pEntry);
×
795
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
796
  }
797

798
  // do add column
799
  int32_t         rowSize = 0;
5,297✔
800
  SSchemaWrapper *pSchema = &pEntry->ntbEntry.schemaRow;
5,297✔
801
  SSchema        *pColumn;
802
  SExtSchema      extSchema = {0};
5,297✔
803
  pEntry->version = version;
5,297✔
804
  for (int32_t i = 0; i < pSchema->nCols; i++) {
8,448,644✔
805
    pColumn = &pSchema->pSchema[i];
8,443,846✔
806
    if (strncmp(pColumn->name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
8,443,846✔
807
      metaError("vgId:%d, %s failed at %s:%d since column %s already exists in table %s, version:%" PRId64,
499!
808
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colName, pReq->tbName, version);
809
      metaFetchEntryFree(&pEntry);
499✔
810
      TAOS_RETURN(TSDB_CODE_VND_COL_ALREADY_EXISTS);
499✔
811
    }
812
    rowSize += pColumn->bytes;
8,443,347✔
813
  }
814

815
  if (rowSize + pReq->bytes > TSDB_MAX_BYTES_PER_ROW) {
4,798✔
816
    metaError("vgId:%d, %s failed at %s:%d since row size %d + %d > %d, version:%" PRId64, TD_VID(pMeta->pVnode),
10!
817
              __func__, __FILE__, __LINE__, rowSize, pReq->bytes, TSDB_MAX_BYTES_PER_ROW, version);
818
    metaFetchEntryFree(&pEntry);
10✔
819
    TAOS_RETURN(TSDB_CODE_PAR_INVALID_ROW_LENGTH);
10✔
820
  }
821

822
  if (pSchema->nCols + 1 > TSDB_MAX_COLUMNS) {
4,788!
823
    metaError("vgId:%d, %s failed at %s:%d since column count %d + 1 > %d, version:%" PRId64, TD_VID(pMeta->pVnode),
×
824
              __func__, __FILE__, __LINE__, pSchema->nCols, TSDB_MAX_COLUMNS, version);
825
    metaFetchEntryFree(&pEntry);
×
826
    TAOS_RETURN(TSDB_CODE_PAR_TOO_MANY_COLUMNS);
×
827
  }
828

829
  SSchema *pNewSchema = taosMemoryRealloc(pSchema->pSchema, sizeof(SSchema) * (pSchema->nCols + 1));
4,788!
830
  if (NULL == pNewSchema) {
4,788!
831
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
832
              __LINE__, tstrerror(terrno), version);
833
    metaFetchEntryFree(&pEntry);
×
834
    TAOS_RETURN(terrno);
×
835
  }
836
  pSchema->pSchema = pNewSchema;
4,788✔
837
  pSchema->version++;
4,788✔
838
  pSchema->nCols++;
4,788✔
839
  pColumn = &pSchema->pSchema[pSchema->nCols - 1];
4,788✔
840
  pColumn->bytes = pReq->bytes;
4,788✔
841
  pColumn->type = pReq->type;
4,788✔
842
  pColumn->flags = pReq->flags;
4,788✔
843
  pColumn->colId = pEntry->ntbEntry.ncid++;
4,788✔
844
  extSchema.typeMod = pReq->typeMod;
4,788✔
845
  tstrncpy(pColumn->name, pReq->colName, TSDB_COL_NAME_LEN);
4,788✔
846
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
4,788✔
847
    SColRef tmpRef;
848
    if (TSDB_ALTER_TABLE_ADD_COLUMN == pReq->action) {
81✔
849
      tmpRef.hasRef = false;
48✔
850
      tmpRef.id = pColumn->colId;
48✔
851
    } else {
852
      tmpRef.hasRef = true;
33✔
853
      tmpRef.id = pColumn->colId;
33✔
854
      tstrncpy(tmpRef.refDbName, pReq->refDbName, TSDB_DB_NAME_LEN);
33✔
855
      tstrncpy(tmpRef.refTableName, pReq->refTbName, TSDB_TABLE_NAME_LEN);
33✔
856
      tstrncpy(tmpRef.refColName, pReq->refColName, TSDB_COL_NAME_LEN);
33✔
857
    }
858
    code = updataTableColRef(&pEntry->colRef, pColumn, 1, &tmpRef);
81✔
859
    if (code) {
81!
860
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
861
                __LINE__, tstrerror(code), version);
862
      metaFetchEntryFree(&pEntry);
×
863
      TAOS_RETURN(code);
×
864
    }
865
  } else {
866
    uint32_t compress;
867
    if (TSDB_ALTER_TABLE_ADD_COLUMN == pReq->action) {
4,707✔
868
      compress = createDefaultColCmprByType(pColumn->type);
4,697✔
869
    } else {
870
      compress = pReq->compress;
10✔
871
    }
872
    code = updataTableColCmpr(&pEntry->colCmpr, pColumn, 1, compress);
4,707✔
873
    if (code) {
4,707!
874
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
875
                __LINE__, tstrerror(code), version);
876
      metaFetchEntryFree(&pEntry);
×
877
      TAOS_RETURN(code);
×
878
    }
879
  }
880
  code = addTableExtSchema(pEntry, pColumn, pSchema->nCols, &extSchema);
4,788✔
881
  if (code) {
4,788!
882
    metaError("vgId:%d, %s failed to add ext schema at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode),
×
883
              __func__, __FILE__, __LINE__, tstrerror(code), version);
884
    metaFetchEntryFree(&pEntry);
×
885
    TAOS_RETURN(code);
×
886
  }
887

888
  // do handle entry
889
  code = metaHandleEntry2(pMeta, pEntry);
4,788✔
890
  if (code) {
4,788!
891
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
892
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
893
    metaFetchEntryFree(&pEntry);
×
894
    TAOS_RETURN(code);
×
895
  } else {
896
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
4,788!
897
             pEntry->uid, version);
898
  }
899

900
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
4,788✔
901
    if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
81!
902
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
903
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
904
    } else {
905
      for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
620✔
906
        SColRef *p = &pEntry->colRef.pColRef[i];
539✔
907
        pRsp->pColRefs[i].hasRef = p->hasRef;
539✔
908
        pRsp->pColRefs[i].id = p->id;
539✔
909
        if (p->hasRef) {
539✔
910
          tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
265✔
911
          tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
265✔
912
          tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
265✔
913
        }
914
      }
915
    }
916
  } else {
917
    if (metaUpdateMetaRsp(pEntry->uid, pReq->tbName, pSchema, pRsp) < 0) {
4,707!
918
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
919
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
920
    } else {
921
      for (int32_t i = 0; i < pEntry->colCmpr.nCols; i++) {
8,438,535✔
922
        SColCmpr *p = &pEntry->colCmpr.pColCmpr[i];
8,433,828✔
923
        pRsp->pSchemaExt[i].colId = p->id;
8,433,828✔
924
        pRsp->pSchemaExt[i].compress = p->alg;
8,433,828✔
925
      }
926
    }
927
  }
928

929
  metaFetchEntryFree(&pEntry);
4,788✔
930
  TAOS_RETURN(code);
4,788✔
931
}
932

933
int32_t metaDropTableColumn(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
151✔
934
  int32_t code = TSDB_CODE_SUCCESS;
151✔
935

936
  // check request
937
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
151✔
938
  if (code) {
151!
939
    TAOS_RETURN(code);
×
940
  }
941

942
  // fetch old entry
943
  SMetaEntry *pEntry = NULL;
151✔
944
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
151✔
945
  if (code) {
151!
946
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
947
              __FILE__, __LINE__, pReq->tbName, version);
948
    TAOS_RETURN(code);
×
949
  }
950

951
  if (pEntry->version >= version) {
151!
952
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
953
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
954
    metaFetchEntryFree(&pEntry);
×
955
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
956
  }
957

958
  // search the column to drop
959
  SSchemaWrapper *pSchema = &pEntry->ntbEntry.schemaRow;
151✔
960
  SSchema        *pColumn = NULL;
151✔
961
  SSchema         tColumn;
962
  int32_t         iColumn = 0;
151✔
963
  for (; iColumn < pSchema->nCols; iColumn++) {
21,244!
964
    pColumn = &pSchema->pSchema[iColumn];
21,244✔
965
    if (strncmp(pColumn->name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
21,244✔
966
      break;
151✔
967
    }
968
  }
969

970
  if (iColumn == pSchema->nCols) {
151!
971
    metaError("vgId:%d, %s failed at %s:%d since column %s not found in table %s, version:%" PRId64,
×
972
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colName, pReq->tbName, version);
973
    metaFetchEntryFree(&pEntry);
×
974
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
975
  }
976

977
  if (pColumn->colId == 0 || pColumn->flags & COL_IS_KEY) {
151!
978
    metaError("vgId:%d, %s failed at %s:%d since column %s is primary key, version:%" PRId64, TD_VID(pMeta->pVnode),
×
979
              __func__, __FILE__, __LINE__, pReq->colName, version);
980
    metaFetchEntryFree(&pEntry);
×
981
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
982
  }
983

984
  if (tqCheckColModifiable(pMeta->pVnode->pTq, pEntry->uid, pColumn->colId) != 0) {
151✔
985
    metaError("vgId:%d, %s failed at %s:%d since column %s is not modifiable, version:%" PRId64, TD_VID(pMeta->pVnode),
11!
986
              __func__, __FILE__, __LINE__, pReq->colName, version);
987
    metaFetchEntryFree(&pEntry);
11✔
988
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
11✔
989
  }
990
  tColumn = *pColumn;
140✔
991

992
  // do drop column
993
  pEntry->version = version;
140✔
994
  if (pSchema->nCols - iColumn - 1 > 0) {
140✔
995
    memmove(pColumn, pColumn + 1, (pSchema->nCols - iColumn - 1) * sizeof(SSchema));
106✔
996
  }
997
  pSchema->nCols--;
140✔
998
  pSchema->version++;
140✔
999
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
140✔
1000
    code = updataTableColRef(&pEntry->colRef, &tColumn, 0, NULL);
46✔
1001
    if (code) {
46!
1002
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1003
                __LINE__, tstrerror(code), version);
1004
      metaFetchEntryFree(&pEntry);
×
1005
      TAOS_RETURN(code);
×
1006
    }
1007
    if (pEntry->colRef.nCols != pSchema->nCols) {
46!
1008
      metaError("vgId:%d, %s failed at %s:%d since column count mismatch, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1009
                __func__, __FILE__, __LINE__, version);
1010
      metaFetchEntryFree(&pEntry);
×
1011
      TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1012
    }
1013
  } else {
1014
    code = updataTableColCmpr(&pEntry->colCmpr, &tColumn, 0, 0);
94✔
1015
    if (code) {
94!
1016
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1017
                __LINE__, tstrerror(code), version);
1018
      metaFetchEntryFree(&pEntry);
×
1019
      TAOS_RETURN(code);
×
1020
    }
1021
    if (pEntry->colCmpr.nCols != pSchema->nCols) {
94!
1022
      metaError("vgId:%d, %s failed at %s:%d since column count mismatch, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1023
                __func__, __FILE__, __LINE__, version);
1024
      metaFetchEntryFree(&pEntry);
×
1025
      TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1026
    }
1027
  }
1028

1029
  // update column extschema
1030
  code = dropTableExtSchema(pEntry, iColumn, pSchema->nCols);
140✔
1031
  if (code) {
140!
1032
    metaError("vgId:%d, %s failed to remove extschema at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1033
              __func__, __FILE__, __LINE__, tstrerror(code), version);
1034
    metaFetchEntryFree(&pEntry);
×
1035
    TAOS_RETURN(code);
×
1036
  }
1037

1038
  // do handle entry
1039
  code = metaHandleEntry2(pMeta, pEntry);
140✔
1040
  if (code) {
140!
1041
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1042
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1043
    metaFetchEntryFree(&pEntry);
×
1044
  } else {
1045
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
140!
1046
             pEntry->uid, version);
1047
  }
1048

1049
  // build response
1050
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
140✔
1051
    if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
46!
1052
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1053
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1054
    } else {
1055
      for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
311✔
1056
        SColRef *p = &pEntry->colRef.pColRef[i];
265✔
1057
        pRsp->pColRefs[i].hasRef = p->hasRef;
265✔
1058
        pRsp->pColRefs[i].id = p->id;
265✔
1059
        if (p->hasRef) {
265✔
1060
          tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
148✔
1061
          tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
148✔
1062
          tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
148✔
1063
        }
1064
      }
1065
    }
1066
  } else {
1067
    if (metaUpdateMetaRsp(pEntry->uid, pReq->tbName, pSchema, pRsp) < 0) {
94!
1068
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1069
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1070
    } else {
1071
      for (int32_t i = 0; i < pEntry->colCmpr.nCols; i++) {
29,299✔
1072
        SColCmpr *p = &pEntry->colCmpr.pColCmpr[i];
29,205✔
1073
        pRsp->pSchemaExt[i].colId = p->id;
29,205✔
1074
        pRsp->pSchemaExt[i].compress = p->alg;
29,205✔
1075
      }
1076
    }
1077
  }
1078

1079
  metaFetchEntryFree(&pEntry);
140✔
1080
  TAOS_RETURN(code);
140✔
1081
}
1082

1083
int32_t metaAlterTableColumnName(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
104✔
1084
  int32_t code = TSDB_CODE_SUCCESS;
104✔
1085

1086
  // check request
1087
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
104✔
1088
  if (code) {
104!
1089
    TAOS_RETURN(code);
×
1090
  }
1091

1092
  if (NULL == pReq->colNewName) {
104!
1093
    metaError("vgId:%d, %s failed at %s:%d since invalid new column name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1094
              __func__, __FILE__, __LINE__, version);
1095
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1096
  }
1097

1098
  // fetch old entry
1099
  SMetaEntry *pEntry = NULL;
104✔
1100
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
104✔
1101
  if (code) {
104!
1102
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1103
              __FILE__, __LINE__, pReq->tbName, version);
1104
    TAOS_RETURN(code);
×
1105
  }
1106

1107
  if (pEntry->version >= version) {
104!
1108
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
1109
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
1110
    metaFetchEntryFree(&pEntry);
×
1111
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
1112
  }
1113

1114
  // search the column to update
1115
  SSchemaWrapper *pSchema = &pEntry->ntbEntry.schemaRow;
104✔
1116
  SSchema        *pColumn = NULL;
104✔
1117
  int32_t         iColumn = 0;
104✔
1118
  for (int32_t i = 0; i < pSchema->nCols; i++) {
444!
1119
    if (strncmp(pSchema->pSchema[i].name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
444✔
1120
      pColumn = &pSchema->pSchema[i];
104✔
1121
      iColumn = i;
104✔
1122
      break;
104✔
1123
    }
1124
  }
1125

1126
  if (NULL == pColumn) {
104!
1127
    metaError("vgId:%d, %s failed at %s:%d since column id %d not found in table %s, version:%" PRId64,
×
1128
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colId, pReq->tbName, version);
1129
    metaFetchEntryFree(&pEntry);
×
1130
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1131
  }
1132

1133
  if (tqCheckColModifiable(pMeta->pVnode->pTq, pEntry->uid, pColumn->colId) != 0) {
104✔
1134
    metaError("vgId:%d, %s failed at %s:%d since column %s is not modifiable, version:%" PRId64, TD_VID(pMeta->pVnode),
11!
1135
              __func__, __FILE__, __LINE__, pColumn->name, version);
1136
    metaFetchEntryFree(&pEntry);
11✔
1137
    TAOS_RETURN(TSDB_CODE_VND_COL_SUBSCRIBED);
11✔
1138
  }
1139

1140
  // do update column name
1141
  pEntry->version = version;
93✔
1142
  tstrncpy(pColumn->name, pReq->colNewName, TSDB_COL_NAME_LEN);
93✔
1143
  pSchema->version++;
93✔
1144

1145
  // do handle entry
1146
  code = metaHandleEntry2(pMeta, pEntry);
93✔
1147
  if (code) {
93!
1148
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1149
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1150
    metaFetchEntryFree(&pEntry);
×
1151
    TAOS_RETURN(code);
×
1152
  } else {
1153
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
93!
1154
             pEntry->uid, version);
1155
  }
1156

1157
  // build response
1158
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
93✔
1159
    if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
47!
1160
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1161
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1162
    } else {
1163
      for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
324✔
1164
        SColRef *p = &pEntry->colRef.pColRef[i];
277✔
1165
        pRsp->pColRefs[i].hasRef = p->hasRef;
277✔
1166
        pRsp->pColRefs[i].id = p->id;
277✔
1167
        if (p->hasRef) {
277✔
1168
          tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
173✔
1169
          tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
173✔
1170
          tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
173✔
1171
        }
1172
      }
1173
    }
1174
  } else {
1175
    if (metaUpdateMetaRsp(pEntry->uid, pReq->tbName, pSchema, pRsp) < 0) {
46!
1176
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1177
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1178
    } else {
1179
      for (int32_t i = 0; i < pEntry->colCmpr.nCols; i++) {
386✔
1180
        SColCmpr *p = &pEntry->colCmpr.pColCmpr[i];
340✔
1181
        pRsp->pSchemaExt[i].colId = p->id;
340✔
1182
        pRsp->pSchemaExt[i].compress = p->alg;
340✔
1183
      }
1184
    }
1185
  }
1186

1187
  metaFetchEntryFree(&pEntry);
93✔
1188
  TAOS_RETURN(code);
93✔
1189
}
1190

1191
int32_t metaAlterTableColumnBytes(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
787✔
1192
  int32_t code = TSDB_CODE_SUCCESS;
787✔
1193

1194
  // check request
1195
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
787✔
1196
  if (code) {
787!
1197
    TAOS_RETURN(code);
×
1198
  }
1199

1200
  // fetch old entry
1201
  SMetaEntry *pEntry = NULL;
787✔
1202
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
787✔
1203
  if (code) {
787!
1204
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1205
              __FILE__, __LINE__, pReq->tbName, version);
1206
    TAOS_RETURN(code);
×
1207
  }
1208

1209
  if (pEntry->version >= version) {
787!
1210
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
1211
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
1212
    metaFetchEntryFree(&pEntry);
×
1213
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
1214
  }
1215

1216
  // search the column to update
1217
  SSchemaWrapper *pSchema = &pEntry->ntbEntry.schemaRow;
787✔
1218
  SSchema        *pColumn = NULL;
787✔
1219
  int32_t         iColumn = 0;
787✔
1220
  int32_t         rowSize = 0;
787✔
1221
  for (int32_t i = 0; i < pSchema->nCols; i++) {
30,201✔
1222
    if (strncmp(pSchema->pSchema[i].name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
29,414✔
1223
      pColumn = &pSchema->pSchema[i];
787✔
1224
      iColumn = i;
787✔
1225
    }
1226
    rowSize += pSchema->pSchema[i].bytes;
29,414✔
1227
  }
1228

1229
  if (NULL == pColumn) {
787!
1230
    metaError("vgId:%d, %s failed at %s:%d since column %s not found in table %s, version:%" PRId64,
×
1231
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colName, pReq->tbName, version);
1232
    metaFetchEntryFree(&pEntry);
×
1233
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1234
  }
1235

1236
  if (!IS_VAR_DATA_TYPE(pColumn->type) || pColumn->bytes >= pReq->colModBytes) {
787!
1237
    metaError("vgId:%d, %s failed at %s:%d since column %s is not var data type or bytes %d >= %d, version:%" PRId64,
307!
1238
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colName, pColumn->bytes, pReq->colModBytes,
1239
              version);
1240
    metaFetchEntryFree(&pEntry);
307✔
1241
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
307✔
1242
  }
1243

1244
  if (tqCheckColModifiable(pMeta->pVnode->pTq, pEntry->uid, pColumn->colId) != 0) {
480✔
1245
    metaError("vgId:%d, %s failed at %s:%d since column %s is not modifiable, version:%" PRId64, TD_VID(pMeta->pVnode),
13!
1246
              __func__, __FILE__, __LINE__, pReq->colName, version);
1247
    metaFetchEntryFree(&pEntry);
13✔
1248
    TAOS_RETURN(TSDB_CODE_VND_COL_SUBSCRIBED);
13✔
1249
  }
1250

1251
  if (rowSize + pReq->colModBytes - pColumn->bytes > TSDB_MAX_BYTES_PER_ROW) {
467✔
1252
    metaError("vgId:%d, %s failed at %s:%d since row size %d + %d - %d > %d, version:%" PRId64, TD_VID(pMeta->pVnode),
70!
1253
              __func__, __FILE__, __LINE__, rowSize, pReq->colModBytes, pColumn->bytes, TSDB_MAX_BYTES_PER_ROW,
1254
              version);
1255
    metaFetchEntryFree(&pEntry);
70✔
1256
    TAOS_RETURN(TSDB_CODE_PAR_INVALID_ROW_LENGTH);
70✔
1257
  }
1258

1259
  // do change the column bytes
1260
  pEntry->version = version;
397✔
1261
  pSchema->version++;
397✔
1262
  pColumn->bytes = pReq->colModBytes;
397✔
1263

1264
  // do handle entry
1265
  code = metaHandleEntry2(pMeta, pEntry);
397✔
1266
  if (code) {
397!
1267
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1268
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1269
    metaFetchEntryFree(&pEntry);
×
1270
    TAOS_RETURN(code);
×
1271
  } else {
1272
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
397!
1273
             pEntry->uid, version);
1274
  }
1275

1276
  // build response
1277
  if (pEntry->type == TSDB_VIRTUAL_NORMAL_TABLE) {
397✔
1278
    if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
41!
1279
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1280
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1281
    } else {
1282
      for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
294✔
1283
        SColRef *p = &pEntry->colRef.pColRef[i];
253✔
1284
        pRsp->pColRefs[i].hasRef = p->hasRef;
253✔
1285
        pRsp->pColRefs[i].id = p->id;
253✔
1286
        if (p->hasRef) {
253✔
1287
          tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
122✔
1288
          tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
122✔
1289
          tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
122✔
1290
        }
1291
      }
1292
    }
1293
  } else {
1294
    if (metaUpdateMetaRsp(pEntry->uid, pReq->tbName, pSchema, pRsp) < 0) {
356!
1295
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1296
                __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1297
    } else {
1298
      for (int32_t i = 0; i < pEntry->colCmpr.nCols; i++) {
14,010✔
1299
        SColCmpr *p = &pEntry->colCmpr.pColCmpr[i];
13,654✔
1300
        pRsp->pSchemaExt[i].colId = p->id;
13,654✔
1301
        pRsp->pSchemaExt[i].compress = p->alg;
13,654✔
1302
      }
1303
    }
1304
  }
1305

1306
  metaFetchEntryFree(&pEntry);
397✔
1307
  TAOS_RETURN(code);
397✔
1308
}
1309

1310
static int32_t metaCheckUpdateTableTagValReq(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
13,191✔
1311
  int32_t code = 0;
13,191✔
1312

1313
  // check tag name
1314
  if (NULL == pReq->tagName || strlen(pReq->tagName) == 0) {
13,191!
1315
    metaError("vgId:%d, %s failed at %s:%d since invalid tag name:%s, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1316
              __func__, __FILE__, __LINE__, pReq->tagName, version);
1317
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1318
  }
1319

1320
  // check name
1321
  void   *value = NULL;
13,191✔
1322
  int32_t valueSize = 0;
13,191✔
1323
  code = tdbTbGet(pMeta->pNameIdx, pReq->tbName, strlen(pReq->tbName) + 1, &value, &valueSize);
13,191✔
1324
  if (code) {
13,191✔
1325
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
1!
1326
              __FILE__, __LINE__, pReq->tbName, version);
1327
    code = TSDB_CODE_TDB_TABLE_NOT_EXIST;
1✔
1328
    TAOS_RETURN(code);
1✔
1329
  }
1330
  tdbFreeClear(value);
13,190✔
1331

1332
  TAOS_RETURN(code);
13,190✔
1333
}
1334

1335
int32_t metaUpdateTableTagValue(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
13,191✔
1336
  int32_t code = TSDB_CODE_SUCCESS;
13,191✔
1337

1338
  // check request
1339
  code = metaCheckUpdateTableTagValReq(pMeta, version, pReq);
13,191✔
1340
  if (code) {
13,191✔
1341
    TAOS_RETURN(code);
1✔
1342
  }
1343

1344
  // fetch child entry
1345
  SMetaEntry *pChild = NULL;
13,190✔
1346
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pChild);
13,190✔
1347
  if (code) {
13,190!
1348
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1349
              __FILE__, __LINE__, pReq->tbName, version);
1350
    TAOS_RETURN(code);
×
1351
  }
1352

1353
  if (pChild->type != TSDB_CHILD_TABLE && pChild->type != TSDB_VIRTUAL_CHILD_TABLE) {
13,190!
1354
    metaError("vgId:%d, %s failed at %s:%d since table %s is not a child table, version:%" PRId64,
×
1355
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, version);
1356
    metaFetchEntryFree(&pChild);
×
1357
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1358
  }
1359

1360
  // fetch super entry
1361
  SMetaEntry *pSuper = NULL;
13,190✔
1362
  code = metaFetchEntryByUid(pMeta, pChild->ctbEntry.suid, &pSuper);
13,190✔
1363
  if (code) {
13,190!
1364
    metaError("vgId:%d, %s failed at %s:%d since super table uid %" PRId64 " not found, version:%" PRId64,
×
1365
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pChild->ctbEntry.suid, version);
1366
    metaFetchEntryFree(&pChild);
×
1367
    TAOS_RETURN(TSDB_CODE_INTERNAL_ERROR);
×
1368
  }
1369

1370
  // search the tag to update
1371
  SSchemaWrapper *pTagSchema = &pSuper->stbEntry.schemaTag;
13,190✔
1372
  SSchema        *pColumn = NULL;
13,190✔
1373
  int32_t         iColumn = 0;
13,190✔
1374
  for (int32_t i = 0; i < pTagSchema->nCols; i++) {
15,360!
1375
    if (strncmp(pTagSchema->pSchema[i].name, pReq->tagName, TSDB_COL_NAME_LEN) == 0) {
15,360✔
1376
      pColumn = &pTagSchema->pSchema[i];
13,190✔
1377
      iColumn = i;
13,190✔
1378
      break;
13,190✔
1379
    }
1380
  }
1381

1382
  if (NULL == pColumn) {
13,190!
1383
    metaError("vgId:%d, %s failed at %s:%d since tag %s not found in table %s, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1384
              __func__, __FILE__, __LINE__, pReq->tagName, pReq->tbName, version);
1385
    metaFetchEntryFree(&pChild);
×
1386
    metaFetchEntryFree(&pSuper);
×
1387
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1388
  }
1389

1390
  // do change tag value
1391
  pChild->version = version;
13,190✔
1392
  if (pTagSchema->nCols == 1 && pTagSchema->pSchema[0].type == TSDB_DATA_TYPE_JSON) {
13,190✔
1393
    void *pNewTag = taosMemoryRealloc(pChild->ctbEntry.pTags, pReq->nTagVal);
199!
1394
    if (NULL == pNewTag) {
199!
1395
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1396
                __LINE__, tstrerror(terrno), version);
1397
      metaFetchEntryFree(&pChild);
×
1398
      metaFetchEntryFree(&pSuper);
×
1399
      TAOS_RETURN(terrno);
×
1400
    }
1401
    pChild->ctbEntry.pTags = pNewTag;
199✔
1402
    memcpy(pChild->ctbEntry.pTags, pReq->pTagVal, pReq->nTagVal);
199✔
1403
  } else {
1404
    STag *pOldTag = (STag *)pChild->ctbEntry.pTags;
12,991✔
1405

1406
    SArray *pTagArray = taosArrayInit(pTagSchema->nCols, sizeof(STagVal));
12,991✔
1407
    if (NULL == pTagArray) {
12,991!
1408
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1409
                __LINE__, tstrerror(terrno), version);
1410
      metaFetchEntryFree(&pChild);
×
1411
      metaFetchEntryFree(&pSuper);
×
1412
      TAOS_RETURN(terrno);
×
1413
    }
1414

1415
    for (int32_t i = 0; i < pTagSchema->nCols; i++) {
29,976✔
1416
      STagVal value = {
16,985✔
1417
          .type = pTagSchema->pSchema[i].type,
16,985✔
1418
          .cid = pTagSchema->pSchema[i].colId,
16,985✔
1419
      };
1420

1421
      if (iColumn == i) {
16,985✔
1422
        if (pReq->isNull) {
12,991✔
1423
          continue;
936✔
1424
        }
1425
        if (IS_VAR_DATA_TYPE(value.type)) {
12,735!
1426
          value.pData = pReq->pTagVal;
1,166✔
1427
          value.nData = pReq->nTagVal;
1,166✔
1428
        } else {
1429
          memcpy(&value.i64, pReq->pTagVal, pReq->nTagVal);
11,569✔
1430
        }
1431
      } else if (!tTagGet(pOldTag, &value)) {
3,994✔
1432
        continue;
680✔
1433
      }
1434

1435
      if (NULL == taosArrayPush(pTagArray, &value)) {
16,049!
1436
        metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1437
                  __LINE__, tstrerror(terrno), version);
1438
        taosArrayDestroy(pTagArray);
×
1439
        metaFetchEntryFree(&pChild);
×
1440
        metaFetchEntryFree(&pSuper);
×
1441
        TAOS_RETURN(terrno);
×
1442
      }
1443
    }
1444

1445
    STag *pNewTag = NULL;
12,991✔
1446
    code = tTagNew(pTagArray, pTagSchema->version, false, &pNewTag);
12,991✔
1447
    if (code) {
12,991!
1448
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1449
                __LINE__, tstrerror(code), version);
1450
      taosArrayDestroy(pTagArray);
×
1451
      metaFetchEntryFree(&pChild);
×
1452
      metaFetchEntryFree(&pSuper);
×
1453
      TAOS_RETURN(code);
×
1454
    }
1455
    taosArrayDestroy(pTagArray);
12,991✔
1456
    taosMemoryFree(pChild->ctbEntry.pTags);
12,991!
1457
    pChild->ctbEntry.pTags = (uint8_t *)pNewTag;
12,991✔
1458
  }
1459

1460
  // do handle entry
1461
  code = metaHandleEntry2(pMeta, pChild);
13,190✔
1462
  if (code) {
13,190!
1463
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1464
              __func__, __FILE__, __LINE__, tstrerror(code), pChild->uid, pReq->tbName, version);
1465
    metaFetchEntryFree(&pChild);
×
1466
    metaFetchEntryFree(&pSuper);
×
1467
    TAOS_RETURN(code);
×
1468
  } else {
1469
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
13,190!
1470
             pChild->uid, version);
1471
  }
1472

1473
  // free resource and return
1474
  metaFetchEntryFree(&pChild);
13,190✔
1475
  metaFetchEntryFree(&pSuper);
13,190✔
1476
  TAOS_RETURN(code);
13,190✔
1477
}
1478

1479
static int32_t metaCheckUpdateTableMultiTagValueReq(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
5✔
1480
  int32_t code = 0;
5✔
1481

1482
  // check tag name
1483
  if (NULL == pReq->pMultiTag || taosArrayGetSize(pReq->pMultiTag) == 0) {
5!
1484
    metaError("vgId:%d, %s failed at %s:%d since invalid tag name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1485
              __FILE__, __LINE__, version);
1486
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1487
  }
1488

1489
  // check name
1490
  void   *value = NULL;
5✔
1491
  int32_t valueSize = 0;
5✔
1492
  code = tdbTbGet(pMeta->pNameIdx, pReq->tbName, strlen(pReq->tbName) + 1, &value, &valueSize);
5✔
1493
  if (code) {
5!
1494
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1495
              __FILE__, __LINE__, pReq->tbName, version);
1496
    code = TSDB_CODE_TDB_TABLE_NOT_EXIST;
×
1497
    TAOS_RETURN(code);
×
1498
  }
1499
  tdbFreeClear(value);
5✔
1500

1501
  if (taosArrayGetSize(pReq->pMultiTag) == 0) {
5!
1502
    metaError("vgId:%d, %s failed at %s:%d since invalid tag name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1503
              __FILE__, __LINE__, version);
1504
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1505
  }
1506

1507
  TAOS_RETURN(code);
5✔
1508
}
1509

1510
int32_t metaUpdateTableMultiTagValue(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
5✔
1511
  int32_t code = TSDB_CODE_SUCCESS;
5✔
1512

1513
  code = metaCheckUpdateTableMultiTagValueReq(pMeta, version, pReq);
5✔
1514
  if (code) {
5!
1515
    TAOS_RETURN(code);
×
1516
  }
1517

1518
  // fetch child entry
1519
  SMetaEntry *pChild = NULL;
5✔
1520
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pChild);
5✔
1521
  if (code) {
5!
1522
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1523
              __FILE__, __LINE__, pReq->tbName, version);
1524
    TAOS_RETURN(code);
×
1525
  }
1526

1527
  if (pChild->type != TSDB_CHILD_TABLE) {
5!
1528
    metaError("vgId:%d, %s failed at %s:%d since table %s is not a child table, version:%" PRId64,
×
1529
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, version);
1530
    metaFetchEntryFree(&pChild);
×
1531
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1532
  }
1533

1534
  // fetch super entry
1535
  SMetaEntry *pSuper = NULL;
5✔
1536
  code = metaFetchEntryByUid(pMeta, pChild->ctbEntry.suid, &pSuper);
5✔
1537
  if (code) {
5!
1538
    metaError("vgId:%d, %s failed at %s:%d since super table uid %" PRId64 " not found, version:%" PRId64,
×
1539
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pChild->ctbEntry.suid, version);
1540
    metaFetchEntryFree(&pChild);
×
1541
    TAOS_RETURN(TSDB_CODE_INTERNAL_ERROR);
×
1542
  }
1543

1544
  // search the tags to update
1545
  SSchemaWrapper *pTagSchema = &pSuper->stbEntry.schemaTag;
5✔
1546

1547
  if (pTagSchema->nCols == 1 && pTagSchema->pSchema[0].type == TSDB_DATA_TYPE_JSON) {
5!
1548
    metaError("vgId:%d, %s failed at %s:%d since table %s has no tag, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1549
              __func__, __FILE__, __LINE__, pReq->tbName, version);
1550
    metaFetchEntryFree(&pChild);
×
1551
    metaFetchEntryFree(&pSuper);
×
1552
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1553
  }
1554

1555
  // do check if tag name exists
1556
  SHashObj *pTagTable =
1557
      taosHashInit(pTagSchema->nCols, taosGetDefaultHashFunction(TSDB_DATA_TYPE_BINARY), true, HASH_NO_LOCK);
5✔
1558
  if (pTagTable == NULL) {
5!
1559
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1560
              __LINE__, tstrerror(terrno), version);
1561
    metaFetchEntryFree(&pChild);
×
1562
    metaFetchEntryFree(&pSuper);
×
1563
    TAOS_RETURN(terrno);
×
1564
  }
1565

1566
  for (int32_t i = 0; i < taosArrayGetSize(pReq->pMultiTag); i++) {
35✔
1567
    SMultiTagUpateVal *pTagVal = taosArrayGet(pReq->pMultiTag, i);
30✔
1568
    if (taosHashPut(pTagTable, pTagVal->tagName, strlen(pTagVal->tagName), pTagVal, sizeof(*pTagVal)) != 0) {
30!
1569
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1570
                __LINE__, tstrerror(terrno), version);
1571
      taosHashCleanup(pTagTable);
×
1572
      metaFetchEntryFree(&pChild);
×
1573
      metaFetchEntryFree(&pSuper);
×
1574
      TAOS_RETURN(terrno);
×
1575
    }
1576
  }
1577

1578
  int32_t numOfChangedTags = 0;
5✔
1579
  for (int32_t i = 0; i < pTagSchema->nCols; i++) {
40✔
1580
    taosHashGet(pTagTable, pTagSchema->pSchema[i].name, strlen(pTagSchema->pSchema[i].name)) != NULL
35✔
1581
        ? numOfChangedTags++
30✔
1582
        : 0;
35✔
1583
  }
1584
  if (numOfChangedTags < taosHashGetSize(pTagTable)) {
5!
1585
    metaError("vgId:%d, %s failed at %s:%d since tag count mismatch, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1586
              __FILE__, __LINE__, version);
1587
    taosHashCleanup(pTagTable);
×
1588
    metaFetchEntryFree(&pChild);
×
1589
    metaFetchEntryFree(&pSuper);
×
1590
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1591
  }
1592

1593
  // do change tag value
1594
  pChild->version = version;
5✔
1595
  const STag *pOldTag = (const STag *)pChild->ctbEntry.pTags;
5✔
1596
  SArray     *pTagArray = taosArrayInit(pTagSchema->nCols, sizeof(STagVal));
5✔
1597
  if (NULL == pTagArray) {
5!
1598
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1599
              __LINE__, tstrerror(terrno), version);
1600
    taosHashCleanup(pTagTable);
×
1601
    metaFetchEntryFree(&pChild);
×
1602
    metaFetchEntryFree(&pSuper);
×
1603
    TAOS_RETURN(terrno);
×
1604
  }
1605

1606
  for (int32_t i = 0; i < pTagSchema->nCols; i++) {
40✔
1607
    SSchema *pCol = &pTagSchema->pSchema[i];
35✔
1608
    STagVal  value = {
35✔
1609
         .cid = pCol->colId,
35✔
1610
    };
1611

1612
    SMultiTagUpateVal *pTagVal = taosHashGet(pTagTable, pCol->name, strlen(pCol->name));
35✔
1613
    if (pTagVal == NULL) {
35✔
1614
      if (!tTagGet(pOldTag, &value)) {
5!
1615
        continue;
6✔
1616
      }
1617
    } else {
1618
      value.type = pCol->type;
30✔
1619
      if (pTagVal->isNull) {
30✔
1620
        continue;
6✔
1621
      }
1622

1623
      if (IS_VAR_DATA_TYPE(pCol->type)) {
24!
1624
        value.pData = pTagVal->pTagVal;
4✔
1625
        value.nData = pTagVal->nTagVal;
4✔
1626
      } else {
1627
        memcpy(&value.i64, pTagVal->pTagVal, pTagVal->nTagVal);
20✔
1628
      }
1629
    }
1630

1631
    if (taosArrayPush(pTagArray, &value) == NULL) {
29!
1632
      metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1633
                __LINE__, tstrerror(terrno), version);
1634
      taosHashCleanup(pTagTable);
×
1635
      taosArrayDestroy(pTagArray);
×
1636
      metaFetchEntryFree(&pChild);
×
1637
      metaFetchEntryFree(&pSuper);
×
1638
      TAOS_RETURN(terrno);
×
1639
    }
1640
  }
1641

1642
  STag *pNewTag = NULL;
5✔
1643
  code = tTagNew(pTagArray, pTagSchema->version, false, &pNewTag);
5✔
1644
  if (code) {
5!
1645
    metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1646
              __LINE__, tstrerror(code), version);
1647
    taosHashCleanup(pTagTable);
×
1648
    taosArrayDestroy(pTagArray);
×
1649
    metaFetchEntryFree(&pChild);
×
1650
    metaFetchEntryFree(&pSuper);
×
1651
    TAOS_RETURN(code);
×
1652
  }
1653
  taosArrayDestroy(pTagArray);
5✔
1654
  taosMemoryFree(pChild->ctbEntry.pTags);
5!
1655
  pChild->ctbEntry.pTags = (uint8_t *)pNewTag;
5✔
1656

1657
  // do handle entry
1658
  code = metaHandleEntry2(pMeta, pChild);
5✔
1659
  if (code) {
5!
1660
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1661
              __func__, __FILE__, __LINE__, tstrerror(code), pChild->uid, pReq->tbName, version);
1662
    taosHashCleanup(pTagTable);
×
1663
    metaFetchEntryFree(&pChild);
×
1664
    metaFetchEntryFree(&pSuper);
×
1665
    TAOS_RETURN(code);
×
1666
  } else {
1667
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
5!
1668
             pChild->uid, version);
1669
  }
1670

1671
  taosHashCleanup(pTagTable);
5✔
1672
  metaFetchEntryFree(&pChild);
5✔
1673
  metaFetchEntryFree(&pSuper);
5✔
1674
  TAOS_RETURN(code);
5✔
1675
}
1676

1677
static int32_t metaCheckUpdateTableOptionsReq(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
46✔
1678
  int32_t code = TSDB_CODE_SUCCESS;
46✔
1679

1680
  if (pReq->tbName == NULL || strlen(pReq->tbName) == 0) {
46!
1681
    metaError("vgId:%d, %s failed at %s:%d since invalid table name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1682
              __FILE__, __LINE__, version);
1683
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1684
  }
1685

1686
  return code;
46✔
1687
}
1688

1689
int32_t metaUpdateTableOptions2(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
46✔
1690
  int32_t code = 0;
46✔
1691

1692
  code = metaCheckUpdateTableOptionsReq(pMeta, version, pReq);
46✔
1693
  if (code) {
46!
1694
    TAOS_RETURN(code);
×
1695
  }
1696

1697
  // fetch entry
1698
  SMetaEntry *pEntry = NULL;
46✔
1699
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
46✔
1700
  if (code) {
46!
1701
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1702
              __FILE__, __LINE__, pReq->tbName, version);
1703
    TAOS_RETURN(code);
×
1704
  }
1705

1706
  // do change the entry
1707
  pEntry->version = version;
46✔
1708
  if (pEntry->type == TSDB_CHILD_TABLE) {
46✔
1709
    if (pReq->updateTTL) {
18✔
1710
      pEntry->ctbEntry.ttlDays = pReq->newTTL;
7✔
1711
    }
1712
    if (pReq->newCommentLen >= 0) {
18✔
1713
      char *pNewComment = NULL;
11✔
1714
      if (pReq->newCommentLen) {
11✔
1715
        pNewComment = taosMemoryRealloc(pEntry->ctbEntry.comment, pReq->newCommentLen + 1);
7!
1716
        if (NULL == pNewComment) {
7!
1717
          metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1718
                    __LINE__, tstrerror(terrno), version);
1719
          metaFetchEntryFree(&pEntry);
×
1720
          TAOS_RETURN(terrno);
×
1721
        }
1722
        memcpy(pNewComment, pReq->newComment, pReq->newCommentLen + 1);
7✔
1723
      } else {
1724
        taosMemoryFreeClear(pEntry->ctbEntry.comment);
4!
1725
      }
1726
      pEntry->ctbEntry.comment = pNewComment;
11✔
1727
      pEntry->ctbEntry.commentLen = pReq->newCommentLen;
11✔
1728
    }
1729
  } else if (pEntry->type == TSDB_NORMAL_TABLE) {
28!
1730
    if (pReq->updateTTL) {
28✔
1731
      pEntry->ntbEntry.ttlDays = pReq->newTTL;
9✔
1732
    }
1733
    if (pReq->newCommentLen >= 0) {
28✔
1734
      char *pNewComment = NULL;
19✔
1735
      if (pReq->newCommentLen > 0) {
19✔
1736
        pNewComment = taosMemoryRealloc(pEntry->ntbEntry.comment, pReq->newCommentLen + 1);
15!
1737
        if (NULL == pNewComment) {
15!
1738
          metaError("vgId:%d, %s failed at %s:%d since %s, version:%" PRId64, TD_VID(pMeta->pVnode), __func__, __FILE__,
×
1739
                    __LINE__, tstrerror(terrno), version);
1740
          metaFetchEntryFree(&pEntry);
×
1741
          TAOS_RETURN(terrno);
×
1742
        }
1743
        memcpy(pNewComment, pReq->newComment, pReq->newCommentLen + 1);
15✔
1744
      } else {
1745
        taosMemoryFreeClear(pEntry->ntbEntry.comment);
4!
1746
      }
1747
      pEntry->ntbEntry.comment = pNewComment;
19✔
1748
      pEntry->ntbEntry.commentLen = pReq->newCommentLen;
19✔
1749
    }
1750
  } else {
1751
    metaError("vgId:%d, %s failed at %s:%d since table %s type %d is invalid, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1752
              __func__, __FILE__, __LINE__, pReq->tbName, pEntry->type, version);
1753
    metaFetchEntryFree(&pEntry);
×
1754
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1755
  }
1756

1757
  // do handle entry
1758
  code = metaHandleEntry2(pMeta, pEntry);
46✔
1759
  if (code) {
46!
1760
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1761
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1762
    metaFetchEntryFree(&pEntry);
×
1763
    TAOS_RETURN(code);
×
1764
  } else {
1765
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
46!
1766
             pEntry->uid, version);
1767
  }
1768

1769
  metaFetchEntryFree(&pEntry);
46✔
1770
  TAOS_RETURN(code);
46✔
1771
}
1772

1773
int32_t metaUpdateTableColCompress2(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq) {
11✔
1774
  int32_t code = TSDB_CODE_SUCCESS;
11✔
1775

1776
  if (NULL == pReq->tbName || strlen(pReq->tbName) == 0) {
11!
1777
    metaError("vgId:%d, %s failed at %s:%d since invalid table name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1778
              __FILE__, __LINE__, version);
1779
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1780
  }
1781

1782
  SMetaEntry *pEntry = NULL;
11✔
1783
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
11✔
1784
  if (code) {
11!
1785
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1786
              __FILE__, __LINE__, pReq->tbName, version);
1787
    TAOS_RETURN(code);
×
1788
  }
1789

1790
  if (pEntry->version >= version) {
11!
1791
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
1792
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
1793
    metaFetchEntryFree(&pEntry);
×
1794
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
1795
  }
1796

1797
  if (pEntry->type != TSDB_NORMAL_TABLE && pEntry->type != TSDB_SUPER_TABLE) {
11!
1798
    metaError("vgId:%d, %s failed at %s:%d since table %s type %d is invalid, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1799
              __func__, __FILE__, __LINE__, pReq->tbName, pEntry->type, version);
1800
    metaFetchEntryFree(&pEntry);
×
1801
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
1802
  }
1803

1804
  // do change the entry
1805
  int8_t           updated = 0;
11✔
1806
  SColCmprWrapper *wp = &pEntry->colCmpr;
11✔
1807
  for (int32_t i = 0; i < wp->nCols; i++) {
88✔
1808
    SColCmpr *p = &wp->pColCmpr[i];
77✔
1809
    if (p->id == pReq->colId) {
77✔
1810
      uint32_t dst = 0;
11✔
1811
      updated = tUpdateCompress(p->alg, pReq->compress, TSDB_COLVAL_COMPRESS_DISABLED, TSDB_COLVAL_LEVEL_DISABLED,
11✔
1812
                                TSDB_COLVAL_LEVEL_MEDIUM, &dst);
1813
      if (updated > 0) {
11!
1814
        p->alg = dst;
11✔
1815
      }
1816
    }
1817
  }
1818

1819
  if (updated == 0) {
11!
1820
    code = TSDB_CODE_VND_COLUMN_COMPRESS_ALREADY_EXIST;
×
1821
    metaError("vgId:%d, %s failed at %s:%d since column %d compress level is not changed, version:%" PRId64,
×
1822
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colId, version);
1823
    metaFetchEntryFree(&pEntry);
×
1824
    TAOS_RETURN(code);
×
1825
  } else if (updated < 0) {
11!
1826
    code = TSDB_CODE_TSC_COMPRESS_LEVEL_ERROR;
×
1827
    metaError("vgId:%d, %s failed at %s:%d since column %d compress level is invalid, version:%" PRId64,
×
1828
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colId, version);
1829
    metaFetchEntryFree(&pEntry);
×
1830
    TAOS_RETURN(code);
×
1831
  }
1832

1833
  pEntry->version = version;
11✔
1834

1835
  // do handle entry
1836
  code = metaHandleEntry2(pMeta, pEntry);
11✔
1837
  if (code) {
11!
1838
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1839
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1840
    metaFetchEntryFree(&pEntry);
×
1841
    TAOS_RETURN(code);
×
1842
  } else {
1843
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
11!
1844
             pEntry->uid, version);
1845
  }
1846

1847
  metaFetchEntryFree(&pEntry);
11✔
1848
  TAOS_RETURN(code);
11✔
1849
}
1850

1851
int32_t metaAlterTableColumnRef(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
127✔
1852
  int32_t code = TSDB_CODE_SUCCESS;
127✔
1853

1854
  // check request
1855
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
127✔
1856
  if (code) {
127!
1857
    TAOS_RETURN(code);
×
1858
  }
1859

1860
  if (NULL == pReq->refDbName) {
127!
1861
    metaError("vgId:%d, %s failed at %s:%d since invalid ref db name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1862
              __func__, __FILE__, __LINE__, version);
1863
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1864
  }
1865

1866
  if (NULL == pReq->refTbName) {
127!
1867
    metaError("vgId:%d, %s failed at %s:%d since invalid ref table name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1868
              __func__, __FILE__, __LINE__, version);
1869
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1870
  }
1871

1872
  if (NULL == pReq->refColName) {
127!
1873
    metaError("vgId:%d, %s failed at %s:%d since invalid ref Col name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
1874
              __func__, __FILE__, __LINE__, version);
1875
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
1876
  }
1877

1878
  // fetch old entry
1879
  SMetaEntry *pEntry = NULL;
127✔
1880
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
127✔
1881
  if (code) {
127!
1882
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1883
              __FILE__, __LINE__, pReq->tbName, version);
1884
    TAOS_RETURN(code);
×
1885
  }
1886

1887
  if (pEntry->version >= version) {
127!
1888
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
1889
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
1890
    metaFetchEntryFree(&pEntry);
×
1891
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
1892
  }
1893

1894
  // fetch super entry
1895
  SMetaEntry *pSuper = NULL;
127✔
1896
  if (pEntry->type == TSDB_VIRTUAL_CHILD_TABLE) {
127✔
1897
    code = metaFetchEntryByUid(pMeta, pEntry->ctbEntry.suid, &pSuper);
49✔
1898
    if (code) {
49!
1899
      metaError("vgId:%d, %s failed at %s:%d since super table uid %" PRId64 " not found, version:%" PRId64,
×
1900
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pEntry->ctbEntry.suid, version);
1901
      metaFetchEntryFree(&pEntry);
×
1902
      TAOS_RETURN(TSDB_CODE_INTERNAL_ERROR);
×
1903
    }
1904
  }
1905

1906
  // search the column to update
1907
  SSchemaWrapper *pSchema =
127✔
1908
      pEntry->type == TSDB_VIRTUAL_CHILD_TABLE ? &pSuper->stbEntry.schemaRow : &pEntry->ntbEntry.schemaRow;
127✔
1909
  SColRef *pColRef = NULL;
127✔
1910
  int32_t  iColumn = 0;
127✔
1911
  for (int32_t i = 0; i < pSchema->nCols; i++) {
622!
1912
    if (strncmp(pSchema->pSchema[i].name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
622✔
1913
      pColRef = &pEntry->colRef.pColRef[i];
127✔
1914
      iColumn = i;
127✔
1915
      break;
127✔
1916
    }
1917
  }
1918

1919
  if (NULL == pColRef) {
127!
1920
    metaError("vgId:%d, %s failed at %s:%d since column id %d not found in table %s, version:%" PRId64,
×
1921
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->colId, pReq->tbName, version);
1922
    metaFetchEntryFree(&pEntry);
×
1923
    metaFetchEntryFree(&pSuper);
×
1924
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
1925
  }
1926

1927
  // do update column name
1928
  pEntry->version = version;
127✔
1929
  pColRef->hasRef = true;
127✔
1930
  pColRef->id = pSchema->pSchema[iColumn].colId;
127✔
1931
  tstrncpy(pColRef->refDbName, pReq->refDbName, TSDB_DB_NAME_LEN);
127✔
1932
  tstrncpy(pColRef->refTableName, pReq->refTbName, TSDB_TABLE_NAME_LEN);
127✔
1933
  tstrncpy(pColRef->refColName, pReq->refColName, TSDB_COL_NAME_LEN);
127✔
1934
  pSchema->version++;
127✔
1935
  pEntry->colRef.version++;
127✔
1936

1937
  // do handle entry
1938
  code = metaHandleEntry2(pMeta, pEntry);
127✔
1939
  if (code) {
127!
1940
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1941
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1942
    metaFetchEntryFree(&pEntry);
×
1943
    metaFetchEntryFree(&pSuper);
×
1944
    TAOS_RETURN(code);
×
1945
  } else {
1946
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
127!
1947
             pEntry->uid, version);
1948
  }
1949

1950
  // build response
1951
  if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
127!
1952
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
1953
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
1954
  } else {
1955
    for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
929✔
1956
      SColRef *p = &pEntry->colRef.pColRef[i];
802✔
1957
      pRsp->pColRefs[i].hasRef = p->hasRef;
802✔
1958
      pRsp->pColRefs[i].id = p->id;
802✔
1959
      if (p->hasRef) {
802✔
1960
        tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
552✔
1961
        tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
552✔
1962
        tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
552✔
1963
      }
1964
    }
1965
  }
1966

1967
  metaFetchEntryFree(&pEntry);
127✔
1968
  metaFetchEntryFree(&pSuper);
127✔
1969
  TAOS_RETURN(code);
127✔
1970
}
1971

1972
int32_t metaRemoveTableColumnRef(SMeta *pMeta, int64_t version, SVAlterTbReq *pReq, STableMetaRsp *pRsp) {
90✔
1973
  int32_t code = TSDB_CODE_SUCCESS;
90✔
1974

1975
  // check request
1976
  code = metaCheckAlterTableColumnReq(pMeta, version, pReq);
90✔
1977
  if (code) {
90!
1978
    TAOS_RETURN(code);
×
1979
  }
1980

1981
  // fetch old entry
1982
  SMetaEntry *pEntry = NULL;
90✔
1983
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
90✔
1984
  if (code) {
90!
1985
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
1986
              __FILE__, __LINE__, pReq->tbName, version);
1987
    TAOS_RETURN(code);
×
1988
  }
1989

1990
  if (pEntry->version >= version) {
90!
1991
    metaError("vgId:%d, %s failed at %s:%d since table %s version %" PRId64 " is not less than %" PRId64,
×
1992
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->tbName, pEntry->version, version);
1993
    metaFetchEntryFree(&pEntry);
×
1994
    TAOS_RETURN(TSDB_CODE_INVALID_PARA);
×
1995
  }
1996

1997
  // fetch super entry
1998
  SMetaEntry *pSuper = NULL;
90✔
1999
  if (pEntry->type == TSDB_VIRTUAL_CHILD_TABLE) {
90✔
2000
    code = metaFetchEntryByUid(pMeta, pEntry->ctbEntry.suid, &pSuper);
46✔
2001
    if (code) {
46!
2002
      metaError("vgId:%d, %s failed at %s:%d since super table uid %" PRId64 " not found, version:%" PRId64,
×
2003
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pEntry->ctbEntry.suid, version);
2004
      metaFetchEntryFree(&pEntry);
×
2005
      TAOS_RETURN(TSDB_CODE_INTERNAL_ERROR);
×
2006
    }
2007
  }
2008

2009
  // search the column to update
2010
  SSchemaWrapper *pSchema =
90✔
2011
      pEntry->type == TSDB_VIRTUAL_CHILD_TABLE ? &pSuper->stbEntry.schemaRow : &pEntry->ntbEntry.schemaRow;
90✔
2012
  SColRef *pColRef = NULL;
90✔
2013
  int32_t  iColumn = 0;
90✔
2014
  for (int32_t i = 0; i < pSchema->nCols; i++) {
364!
2015
    if (strncmp(pSchema->pSchema[i].name, pReq->colName, TSDB_COL_NAME_LEN) == 0) {
364✔
2016
      pColRef = &pEntry->colRef.pColRef[i];
90✔
2017
      iColumn = i;
90✔
2018
      break;
90✔
2019
    }
2020
  }
2021

2022
  if (NULL == pColRef) {
90!
2023
    metaError("vgId:%d, %s failed at %s:%d since column id %d not found in table %s, version:%" PRId64,
×
2024
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, iColumn + 1, pReq->tbName, version);
2025
    metaFetchEntryFree(&pEntry);
×
2026
    metaFetchEntryFree(&pSuper);
×
2027
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
2028
  }
2029

2030
  // do update column name
2031
  pEntry->version = version;
90✔
2032
  pColRef->hasRef = false;
90✔
2033
  pColRef->id = pSchema->pSchema[iColumn].colId;
90✔
2034
  pSchema->version++;
90✔
2035
  pEntry->colRef.version++;
90✔
2036

2037
  // do handle entry
2038
  code = metaHandleEntry2(pMeta, pEntry);
90✔
2039
  if (code) {
90!
2040
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
2041
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
2042
    metaFetchEntryFree(&pEntry);
×
2043
    metaFetchEntryFree(&pSuper);
×
2044
    TAOS_RETURN(code);
×
2045
  } else {
2046
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->tbName,
90!
2047
             pEntry->uid, version);
2048
  }
2049

2050
  // build response
2051
  if (metaUpdateVtbMetaRsp(pEntry, pReq->tbName, pSchema, &pEntry->colRef, pRsp, pEntry->type) < 0) {
90!
2052
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
2053
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->tbName, version);
2054
  } else {
2055
    for (int32_t i = 0; i < pEntry->colRef.nCols; i++) {
548✔
2056
      SColRef *p = &pEntry->colRef.pColRef[i];
458✔
2057
      pRsp->pColRefs[i].hasRef = p->hasRef;
458✔
2058
      pRsp->pColRefs[i].id = p->id;
458✔
2059
      if (p->hasRef) {
458✔
2060
        tstrncpy(pRsp->pColRefs[i].refDbName, p->refDbName, TSDB_DB_NAME_LEN);
225✔
2061
        tstrncpy(pRsp->pColRefs[i].refTableName, p->refTableName, TSDB_TABLE_NAME_LEN);
225✔
2062
        tstrncpy(pRsp->pColRefs[i].refColName, p->refColName, TSDB_COL_NAME_LEN);
225✔
2063
      }
2064
    }
2065
  }
2066

2067
  metaFetchEntryFree(&pEntry);
90✔
2068
  metaFetchEntryFree(&pSuper);
90✔
2069
  TAOS_RETURN(code);
90✔
2070
}
2071

2072
int32_t metaAddIndexToSuperTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
19✔
2073
  int32_t code = TSDB_CODE_SUCCESS;
19✔
2074

2075
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
19!
2076
    metaError("vgId:%d, %s failed at %s:%d since invalid table name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2077
              __FILE__, __LINE__, version);
2078
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2079
  }
2080

2081
  SMetaEntry *pEntry = NULL;
19✔
2082
  code = metaFetchEntryByName(pMeta, pReq->name, &pEntry);
19✔
2083
  if (code) {
19!
2084
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2085
              __FILE__, __LINE__, pReq->name, version);
2086
    TAOS_RETURN(code);
×
2087
  }
2088

2089
  if (pEntry->type != TSDB_SUPER_TABLE) {
19!
2090
    metaError("vgId:%d, %s failed at %s:%d since table %s type %d is invalid, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2091
              __func__, __FILE__, __LINE__, pReq->name, pEntry->type, version);
2092
    metaFetchEntryFree(&pEntry);
×
2093
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2094
  }
2095

2096
  if (pEntry->uid != pReq->suid) {
19!
2097
    metaError("vgId:%d, %s failed at %s:%d since table %s uid %" PRId64 " is not equal to %" PRId64
×
2098
              ", version:%" PRId64,
2099
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pEntry->uid, pReq->suid, version);
2100
    metaFetchEntryFree(&pEntry);
×
2101
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2102
  }
2103

2104
  // if (pEntry->stbEntry.schemaTag.version >= pReq->schemaTag.version) {
2105
  //   metaError("vgId:%d, %s failed at %s:%d since table %s tag schema version %d is not less than %d, version:%"
2106
  //   PRId64,
2107
  //             TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pEntry->stbEntry.schemaTag.version,
2108
  //             pReq->schemaTag.version, version);
2109
  //   metaFetchEntryFree(&pEntry);
2110
  //   TAOS_RETURN(TSDB_CODE_INVALID_MSG);
2111
  // }
2112

2113
  // do change the entry
2114
  SSchemaWrapper *pOldTagSchema = &pEntry->stbEntry.schemaTag;
19✔
2115
  SSchemaWrapper *pNewTagSchema = &pReq->schemaTag;
19✔
2116
  if (pOldTagSchema->nCols == 1 && pOldTagSchema->pSchema[0].type == TSDB_DATA_TYPE_JSON) {
19!
2117
    metaError("vgId:%d, %s failed at %s:%d since table %s has no tag, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2118
              __func__, __FILE__, __LINE__, pReq->name, version);
2119
    metaFetchEntryFree(&pEntry);
×
2120
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
2121
  }
2122

2123
  if (pOldTagSchema->nCols != pNewTagSchema->nCols) {
19!
2124
    metaError(
×
2125
        "vgId:%d, %s failed at %s:%d since table %s tag schema column count %d is not equal to %d, version:%" PRId64,
2126
        TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pOldTagSchema->nCols, pNewTagSchema->nCols,
2127
        version);
2128
    metaFetchEntryFree(&pEntry);
×
2129
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2130
  }
2131

2132
  // if (pOldTagSchema->version >= pNewTagSchema->version) {
2133
  //   metaError("vgId:%d, %s failed at %s:%d since table %s tag schema version %d is not less than %d, version:%"
2134
  //   PRId64,
2135
  //             TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, pOldTagSchema->version,
2136
  //             pNewTagSchema->version, version);
2137
  //   metaFetchEntryFree(&pEntry);
2138
  //   TAOS_RETURN(TSDB_CODE_INVALID_MSG);
2139
  // }
2140

2141
  int32_t numOfChangedTags = 0;
19✔
2142
  for (int32_t i = 0; i < pOldTagSchema->nCols; i++) {
88✔
2143
    SSchema *pOldColumn = pOldTagSchema->pSchema + i;
69✔
2144
    SSchema *pNewColumn = pNewTagSchema->pSchema + i;
69✔
2145

2146
    if (pOldColumn->type != pNewColumn->type || pOldColumn->colId != pNewColumn->colId ||
69!
2147
        strncmp(pOldColumn->name, pNewColumn->name, sizeof(pNewColumn->name))) {
69!
2148
      metaError("vgId:%d, %s failed at %s:%d since table %s tag schema column %d is not equal, version:%" PRId64,
×
2149
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, i, version);
2150
      metaFetchEntryFree(&pEntry);
×
2151
      TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2152
    }
2153

2154
    if (IS_IDX_ON(pNewColumn) && !IS_IDX_ON(pOldColumn)) {
69✔
2155
      numOfChangedTags++;
19✔
2156
      SSCHMEA_SET_IDX_ON(pOldColumn);
19✔
2157
    } else if (!IS_IDX_ON(pNewColumn) && IS_IDX_ON(pOldColumn)) {
50!
2158
      metaError("vgId:%d, %s failed at %s:%d since table %s tag schema column %d is not equal, version:%" PRId64,
×
2159
                TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, i, version);
2160
      metaFetchEntryFree(&pEntry);
×
2161
      TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2162
    }
2163
  }
2164

2165
  if (numOfChangedTags != 1) {
19!
2166
    metaError(
×
2167
        "vgId:%d, %s failed at %s:%d since table %s tag schema column count %d is not equal to 1, version:%" PRId64,
2168
        TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->name, numOfChangedTags, version);
2169
    metaFetchEntryFree(&pEntry);
×
2170
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2171
  }
2172

2173
  pEntry->version = version;
19✔
2174
  pEntry->stbEntry.schemaTag.version = pNewTagSchema->version;
19✔
2175

2176
  // do handle the entry
2177
  code = metaHandleEntry2(pMeta, pEntry);
19✔
2178
  if (code) {
19!
2179
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
2180
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->name, version);
2181
    metaFetchEntryFree(&pEntry);
×
2182
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2183
  } else {
2184
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->name,
19!
2185
             pEntry->uid, version);
2186
  }
2187

2188
  metaFetchEntryFree(&pEntry);
19✔
2189
  TAOS_RETURN(code);
19✔
2190
}
2191

2192
int32_t metaDropIndexFromSuperTable(SMeta *pMeta, int64_t version, SDropIndexReq *pReq) {
10✔
2193
  int32_t code = TSDB_CODE_SUCCESS;
10✔
2194

2195
  if (strlen(pReq->colName) == 0 || strlen(pReq->stb) == 0) {
10!
2196
    metaError("vgId:%d, %s failed at %s:%d since invalid table name or column name, version:%" PRId64,
×
2197
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, version);
2198
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2199
  }
2200

2201
  SMetaEntry *pEntry = NULL;
10✔
2202
  code = metaFetchEntryByUid(pMeta, pReq->stbUid, &pEntry);
10✔
2203
  if (code) {
10!
2204
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2205
              __FILE__, __LINE__, pReq->stb, version);
2206
    TAOS_RETURN(code);
×
2207
  }
2208

2209
  if (TSDB_SUPER_TABLE != pEntry->type) {
10!
2210
    metaError("vgId:%d, %s failed at %s:%d since table %s type %d is invalid, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2211
              __func__, __FILE__, __LINE__, pReq->stb, pEntry->type, version);
2212
    metaFetchEntryFree(&pEntry);
×
2213
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2214
  }
2215

2216
  SSchemaWrapper *pTagSchema = &pEntry->stbEntry.schemaTag;
10✔
2217
  if (pTagSchema->nCols == 1 && pTagSchema->pSchema[0].type == TSDB_DATA_TYPE_JSON) {
10!
2218
    metaError("vgId:%d, %s failed at %s:%d since table %s has no tag, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2219
              __func__, __FILE__, __LINE__, pReq->stb, version);
2220
    metaFetchEntryFree(&pEntry);
×
2221
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2222
  }
2223

2224
  // search and set the tag index off
2225
  int32_t numOfChangedTags = 0;
10✔
2226
  for (int32_t i = 0; i < pTagSchema->nCols; i++) {
24!
2227
    SSchema *pCol = pTagSchema->pSchema + i;
24✔
2228
    if (0 == strncmp(pCol->name, pReq->colName, sizeof(pReq->colName))) {
24✔
2229
      if (!IS_IDX_ON(pCol)) {
10!
2230
        metaError("vgId:%d, %s failed at %s:%d since table %s column %s is not indexed, version:%" PRId64,
×
2231
                  TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->stb, pReq->colName, version);
2232
        metaFetchEntryFree(&pEntry);
×
2233
        TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2234
      }
2235
      numOfChangedTags++;
10✔
2236
      SSCHMEA_SET_IDX_OFF(pCol);
10✔
2237
      break;
10✔
2238
    }
2239
  }
2240

2241
  if (numOfChangedTags != 1) {
10!
2242
    metaError("vgId:%d, %s failed at %s:%d since table %s column %s is not found, version:%" PRId64,
×
2243
              TD_VID(pMeta->pVnode), __func__, __FILE__, __LINE__, pReq->stb, pReq->colName, version);
2244
    metaFetchEntryFree(&pEntry);
×
2245
    TAOS_RETURN(TSDB_CODE_VND_COL_NOT_EXISTS);
×
2246
  }
2247

2248
  // do handle the entry
2249
  pEntry->version = version;
10✔
2250
  pTagSchema->version++;
10✔
2251
  code = metaHandleEntry2(pMeta, pEntry);
10✔
2252
  if (code) {
10!
2253
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
2254
              __func__, __FILE__, __LINE__, tstrerror(code), pEntry->uid, pReq->stb, version);
2255
    metaFetchEntryFree(&pEntry);
×
2256
    TAOS_RETURN(code);
×
2257
  } else {
2258
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->stb,
10!
2259
             pEntry->uid, version);
2260
  }
2261

2262
  metaFetchEntryFree(&pEntry);
10✔
2263
  TAOS_RETURN(code);
10✔
2264
}
2265

2266
int32_t metaAlterSuperTable(SMeta *pMeta, int64_t version, SVCreateStbReq *pReq) {
16,041✔
2267
  int32_t code = TSDB_CODE_SUCCESS;
16,041✔
2268

2269
  if (NULL == pReq->name || strlen(pReq->name) == 0) {
16,041!
2270
    metaError("vgId:%d, %s failed at %s:%d since invalid table name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2271
              __FILE__, __LINE__, version);
2272
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2273
  }
2274

2275
  SMetaEntry *pEntry = NULL;
16,041✔
2276
  code = metaFetchEntryByName(pMeta, pReq->name, &pEntry);
16,041✔
2277
  if (code) {
16,040✔
2278
    metaError("vgId:%d, %s failed at %s:%d since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
1!
2279
              __FILE__, __LINE__, pReq->name, version);
2280
    TAOS_RETURN(TSDB_CODE_TDB_STB_NOT_EXIST);
1✔
2281
  }
2282

2283
  if (pEntry->type != TSDB_SUPER_TABLE) {
16,039!
2284
    metaError("vgId:%d, %s failed at %s:%d since table %s type %d is invalid, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2285
              __func__, __FILE__, __LINE__, pReq->name, pEntry->type, version);
2286
    metaFetchEntryFree(&pEntry);
×
2287
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2288
  }
2289

2290
  SMetaEntry entry = {
16,039✔
2291
      .version = version,
2292
      .type = TSDB_SUPER_TABLE,
2293
      .uid = pReq->suid,
16,039✔
2294
      .name = pReq->name,
16,039✔
2295
      .stbEntry.schemaRow = pReq->schemaRow,
2296
      .stbEntry.schemaTag = pReq->schemaTag,
2297
      .stbEntry.keep = pReq->keep,
16,039✔
2298
      .colCmpr = pReq->colCmpr,
2299
      .pExtSchemas = pReq->pExtSchemas,
16,039✔
2300
  };
2301
  TABLE_SET_COL_COMPRESSED(entry.flags);
16,039✔
2302
  if (pReq->virtualStb) {
16,039✔
2303
    TABLE_SET_VIRTUAL(entry.flags);
26✔
2304
  }
2305
  if(TABLE_IS_ROLLUP(pEntry->flags)) {
16,039✔
2306
    TABLE_SET_ROLLUP(entry.flags);
6✔
2307
    entry.stbEntry.rsmaParam = pEntry->stbEntry.rsmaParam;
6✔
2308
  }
2309

2310
  // do handle the entry
2311
  code = metaHandleEntry2(pMeta, &entry);
16,039✔
2312
  if (code) {
16,039!
2313
    metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " name:%s version:%" PRId64, TD_VID(pMeta->pVnode),
×
2314
              __func__, __FILE__, __LINE__, tstrerror(code), pReq->suid, pReq->name, version);
2315
    metaFetchEntryFree(&pEntry);
×
2316
    TAOS_RETURN(code);
×
2317
  } else {
2318
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated, version:%" PRId64, TD_VID(pMeta->pVnode), pReq->name,
16,039✔
2319
             pReq->suid, version);
2320
  }
2321

2322
  metaFetchEntryFree(&pEntry);
16,044✔
2323
  TAOS_RETURN(code);
16,043✔
2324
}
2325

2326
int32_t metaDropMultipleTables(SMeta *pMeta, int64_t version, SArray *uidArray) {
×
2327
  int32_t code = 0;
×
2328

2329
  if (taosArrayGetSize(uidArray) == 0) {
×
2330
    return TSDB_CODE_SUCCESS;
×
2331
  }
2332

2333
  for (int32_t i = 0; i < taosArrayGetSize(uidArray); i++) {
×
2334
    tb_uid_t  uid = *(tb_uid_t *)taosArrayGet(uidArray, i);
×
2335
    SMetaInfo info;
2336
    code = metaGetInfo(pMeta, uid, &info, NULL);
×
2337
    if (code) {
×
2338
      metaError("vgId:%d, %s failed at %s:%d since table uid %" PRId64 " not found, code:%d", TD_VID(pMeta->pVnode),
×
2339
                __func__, __FILE__, __LINE__, uid, code);
2340
      return code;
×
2341
    }
2342

2343
    SMetaEntry entry = {
×
2344
        .version = version,
2345
        .uid = uid,
2346
    };
2347

2348
    if (info.suid == 0) {
×
2349
      entry.type = -TSDB_NORMAL_TABLE;
×
2350
    } else if (info.suid == uid) {
×
2351
      entry.type = -TSDB_SUPER_TABLE;
×
2352
    } else {
2353
      entry.type = -TSDB_CHILD_TABLE;
×
2354
    }
2355
    code = metaHandleEntry2(pMeta, &entry);
×
2356
    if (code) {
×
2357
      metaError("vgId:%d, %s failed at %s:%d since %s, uid:%" PRId64 " version:%" PRId64, TD_VID(pMeta->pVnode),
×
2358
                __func__, __FILE__, __LINE__, tstrerror(code), uid, version);
2359
      return code;
×
2360
    }
2361
  }
2362
  return code;
×
2363
}
2364

2365
int metaCreateRsma(SMeta *pMeta, int64_t version, SVCreateRsmaReq *pReq) {
28✔
2366
  int32_t code = TSDB_CODE_SUCCESS;
28✔
2367

2368
  if (NULL == pReq->name || pReq->name[0] == 0) {
28!
2369
    metaError("vgId:%d, failed at %d to create rsma since invalid rsma name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2370
              __LINE__, version);
2371
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2372
  }
2373

2374
  SMetaEntry *pEntry = NULL;
28✔
2375
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
28✔
2376
  if (code) {
28!
2377
    metaError("vgId:%d, failed at %d to create rsma %s since table %s not found, version:%" PRId64,
×
2378
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, version);
2379
    TAOS_RETURN(TSDB_CODE_TDB_STB_NOT_EXIST);
×
2380
  }
2381

2382
  if (pEntry->type != TSDB_SUPER_TABLE) {
28!
2383
    metaError("vgId:%d, failed at %d to create rsma %s since table %s type %d is invalid, version:%" PRId64,
×
2384
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, pEntry->type, version);
2385
    metaFetchEntryFree(&pEntry);
×
2386
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2387
  }
2388

2389
  if (pEntry->uid != pReq->tbUid) {
28!
2390
    metaError("vgId:%d, failed at %d to create rsma %s since table %s uid %" PRId64 " is not equal to %" PRId64
×
2391
              ", version:%" PRId64,
2392
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, pEntry->uid, pReq->tbUid, version);
2393
    metaFetchEntryFree(&pEntry);
×
2394
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2395
  }
2396

2397
  if (TABLE_IS_ROLLUP(pEntry->flags)) {
28!
2398
    // overwrite the old rsma definition if exists
2399
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcColIds);
×
2400
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcIds);
×
2401
  } else {
2402
    TABLE_SET_ROLLUP(pEntry->flags);
28✔
2403
  }
2404

2405
  SMetaEntry entry = *pEntry;
28✔
2406
  entry.version = version;
28✔
2407
  entry.stbEntry.rsmaParam.name = pReq->name;
28✔
2408
  entry.stbEntry.rsmaParam.uid = pReq->uid;
28✔
2409
  entry.stbEntry.rsmaParam.interval[0] = pReq->interval[0];
28✔
2410
  entry.stbEntry.rsmaParam.interval[1] = pReq->interval[1];
28✔
2411
  entry.stbEntry.rsmaParam.intervalUnit = pReq->intervalUnit;
28✔
2412
  entry.stbEntry.rsmaParam.nFuncs = pReq->nFuncs;
28✔
2413
  entry.stbEntry.rsmaParam.funcColIds = pReq->funcColIds;
28✔
2414
  entry.stbEntry.rsmaParam.funcIds = pReq->funcIds;
28✔
2415

2416
  // do handle the entry
2417
  code = metaHandleEntry2(pMeta, &entry);
28✔
2418
  if (code) {
28!
2419
    metaError("vgId:%d, failed at %d to create rsma %s since %s, uid:%" PRId64 ", version:%" PRId64,
×
2420
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, tstrerror(code), pReq->tbUid, version);
2421
    metaFetchEntryFree(&pEntry);
×
2422
    TAOS_RETURN(code);
×
2423
  } else {
2424
    pMeta->pVnode->config.vndStats.numOfRSMAs++;
28✔
2425
    pMeta->pVnode->config.isRsma = 1;
28✔
2426
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated since rsma created %s:%" PRIi64 ", version:%" PRId64,
28!
2427
             TD_VID(pMeta->pVnode), pReq->tbName, pReq->tbUid, pReq->name, pReq->uid, version);
2428
  }
2429

2430
  metaFetchEntryFree(&pEntry);
28✔
2431
  TAOS_RETURN(code);
28✔
2432
}
2433

2434
int metaDropRsma(SMeta *pMeta, int64_t version, SVDropRsmaReq *pReq) {
6✔
2435
  int32_t code = TSDB_CODE_SUCCESS;
6✔
2436

2437
  if (NULL == pReq->name || pReq->name[0] == 0) {
6!
2438
    metaError("vgId:%d, %s failed at %d since invalid rsma name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2439
              __LINE__, version);
2440
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2441
  }
2442

2443
  if (NULL == pReq->tbName || pReq->tbName[0] == 0) {
6!
2444
    metaError("vgId:%d, %s failed at %d since invalid table name, version:%" PRId64, TD_VID(pMeta->pVnode), __func__,
×
2445
              __LINE__, version);
2446
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2447
  }
2448

2449
  SMetaEntry *pEntry = NULL;
6✔
2450
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
6✔
2451
  if (code) {
6!
2452
    metaWarn("vgId:%d, %s no need at %d to drop %s since table %s not found, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2453
             __func__, __LINE__, pReq->name, pReq->tbName, version);
2454
    TAOS_RETURN(TSDB_CODE_RSMA_NOT_EXIST);
×
2455
  }
2456

2457
  if (pEntry->type != pReq->tbType) {
6!
2458
    metaError("vgId:%d, %s failed at %d to drop %s since table %s type %d is invalid, version:%" PRId64,
×
2459
              TD_VID(pMeta->pVnode), __func__, __LINE__, pReq->name, pReq->tbName, pEntry->type, version);
2460
    metaFetchEntryFree(&pEntry);
×
2461
    TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2462
  }
2463

2464
  if (pEntry->uid != pReq->tbUid) {
6!
2465
    metaError("vgId:%d, %s failed at %d %s since table %s uid %" PRId64 " is not equal to %" PRId64
×
2466
              ", version:%" PRId64,
2467
              TD_VID(pMeta->pVnode), __func__, __LINE__, pReq->name, pReq->tbName, pEntry->uid, pReq->tbUid, version);
2468
    metaFetchEntryFree(&pEntry);
×
2469
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2470
  }
2471

2472
  if (TABLE_IS_ROLLUP(pEntry->flags)) {
6!
2473
    if (pEntry->stbEntry.rsmaParam.uid != pReq->uid ||
6!
2474
        strncmp(pEntry->stbEntry.rsmaParam.name, pReq->name, TSDB_TABLE_NAME_LEN) != 0) {
6!
2475
      metaError(
×
2476
          "vgId:%d, %s failed at line %d to drop %s since table %s is rollup table with different rsma name %s or "
2477
          "uid:%" PRIi64 ", version:%" PRId64,
2478
          TD_VID(pMeta->pVnode), __func__, __LINE__, pReq->name, pReq->tbName, pEntry->stbEntry.rsmaParam.name,
2479
          pReq->uid, version);
2480
      metaFetchEntryFree(&pEntry);
×
2481
      TAOS_RETURN(TSDB_CODE_VND_INVALID_TABLE_ACTION);
×
2482
    }
2483
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcColIds);
6!
2484
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcIds);
6!
2485
  } else {
2486
    metaWarn("vgId:%d, %s no need at %d to drop %s since table %s is not rollup table, version:%" PRId64,
×
2487
             TD_VID(pMeta->pVnode), __func__, __LINE__, pReq->name, pReq->tbName, version);
2488
    metaFetchEntryFree(&pEntry);
×
2489
    TAOS_RETURN(TSDB_CODE_RSMA_NOT_EXIST);
×
2490
  }
2491

2492
  SMetaEntry entry = *pEntry;
6✔
2493
  entry.version = version;
6✔
2494
  TABLE_RESET_ROLLUP(entry.flags);
6✔
2495
  entry.stbEntry.rsmaParam.uid = 0;
6✔
2496
  entry.stbEntry.rsmaParam.name = NULL;
6✔
2497
  entry.stbEntry.rsmaParam.nFuncs = 0;
6✔
2498
  entry.stbEntry.rsmaParam.funcColIds = NULL;
6✔
2499
  entry.stbEntry.rsmaParam.funcIds = NULL;
6✔
2500

2501
  // do handle the entry
2502
  code = metaHandleEntry2(pMeta, &entry);
6✔
2503
  if (code) {
6!
2504
    metaError("vgId:%d, %s failed at %d to drop %s since %s, uid:%" PRId64 ", version:%" PRId64, TD_VID(pMeta->pVnode),
×
2505
              __func__, __LINE__, pReq->name, tstrerror(code), pReq->uid, version);
2506
    metaFetchEntryFree(&pEntry);
×
2507
    TAOS_RETURN(code);
×
2508
  } else {
2509
    if (--pMeta->pVnode->config.vndStats.numOfRSMAs <= 0) {
6!
2510
      pMeta->pVnode->config.isRsma = 0;
×
2511
    }
2512
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated since rsma created %s:%" PRIi64 ", version:%" PRId64,
6!
2513
             TD_VID(pMeta->pVnode), pReq->tbName, pReq->tbUid, pReq->name, pReq->uid, version);
2514
  }
2515

2516
  metaFetchEntryFree(&pEntry);
6✔
2517
  TAOS_RETURN(code);
6✔
2518
}
2519

2520
int metaAlterRsma(SMeta *pMeta, int64_t version, SVAlterRsmaReq *pReq) {
14✔
2521
  int32_t code = TSDB_CODE_SUCCESS;
14✔
2522

2523
  if (NULL == pReq->name || pReq->name[0] == 0) {
14!
2524
    metaError("vgId:%d, failed at %d to alter rsma since invalid rsma name, version:%" PRId64, TD_VID(pMeta->pVnode),
×
2525
              __LINE__, version);
2526
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2527
  }
2528

2529
  SMetaEntry *pEntry = NULL;
14✔
2530
  code = metaFetchEntryByName(pMeta, pReq->tbName, &pEntry);
14✔
2531
  if (code) {
14!
2532
    metaError("vgId:%d, failed at %d to alter rsma %s since table %s not found, version:%" PRId64,
×
2533
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, version);
2534
    TAOS_RETURN(TSDB_CODE_TDB_STB_NOT_EXIST);
×
2535
  }
2536

2537
  if (pEntry->uid != pReq->tbUid) {
14!
2538
    metaError("vgId:%d, failed at %d to alter rsma %s since table %s uid %" PRId64 " is not equal to %" PRId64
×
2539
              ", version:%" PRId64,
2540
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, pEntry->uid, pReq->tbUid, version);
2541
    metaFetchEntryFree(&pEntry);
×
2542
    TAOS_RETURN(TSDB_CODE_INVALID_MSG);
×
2543
  }
2544

2545
  if (TABLE_IS_ROLLUP(pEntry->flags)) {
14!
2546
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcColIds);
14!
2547
    taosMemoryFreeClear(pEntry->stbEntry.rsmaParam.funcIds);
14!
2548
  } else {
2549
    metaError("vgId:%d, failed at %d to alter rsma %s since table %s is not rollup table, version:%" PRId64,
×
2550
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, pReq->tbName, version);
2551
    metaFetchEntryFree(&pEntry);
×
2552
    TAOS_RETURN(TSDB_CODE_RSMA_NOT_EXIST);
×
2553
  }
2554

2555
  SMetaEntry entry = *pEntry;
14✔
2556
  entry.version = version;
14✔
2557
  if (pReq->alterType == TSDB_ALTER_RSMA_FUNCTION) {
14!
2558
    entry.stbEntry.rsmaParam.nFuncs = pReq->nFuncs;
14✔
2559
    entry.stbEntry.rsmaParam.funcColIds = pReq->funcColIds;
14✔
2560
    entry.stbEntry.rsmaParam.funcIds = pReq->funcIds;
14✔
2561
  }
2562
  // do handle the entry
2563
  code = metaHandleEntry2(pMeta, &entry);
14✔
2564
  if (code) {
14!
2565
    metaError("vgId:%d, failed at %d to alter rsma %s since %s, uid:%" PRId64 ", version:%" PRId64,
×
2566
              TD_VID(pMeta->pVnode), __LINE__, pReq->name, tstrerror(code), pReq->tbUid, version);
2567
    metaFetchEntryFree(&pEntry);
×
2568
    TAOS_RETURN(code);
×
2569
  } else {
2570
    metaInfo("vgId:%d, table %s uid %" PRId64 " is updated since rsma altered %s:%" PRIi64 ", version:%" PRId64,
14!
2571
             TD_VID(pMeta->pVnode), pReq->tbName, pReq->tbUid, pReq->name, pReq->uid, version);
2572
  }
2573

2574
  metaFetchEntryFree(&pEntry);
14✔
2575
  TAOS_RETURN(code);
14✔
2576
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc