#4815

Committed 17 Oct 2025 06:47AM UTC coverage: 61.177% (-0.03%) from 61.206%

Build # #4815

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #33289 from taosdata/3.0

enh: Code Optimization (#33283)

Run Details

155629 of 324369 branches covered (47.98%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

555 existing lines in 123 files now uncovered.

207706 of 269535 relevant lines covered (77.06%)

127615938.53 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

72.59

/source/dnode/mgmt/node_mgmt/src/dmNodes.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "dmMgmt.h"
#include "dmUtil.h"
#include "monitor.h"
#include "audit.h"

int32_t dmOpenNode(SMgmtWrapper *pWrapper) {
  int32_t code = 0;
  SDnode *pDnode = pWrapper->pDnode;

  if (taosMkDir(pWrapper->path) != 0) {
    code = terrno;
    dError("node:%s, failed to create dir:%s since %s", pWrapper->name, pWrapper->path, tstrerror(code));
    return code;
  }

  SMgmtOutputOpt output = {0};
  SMgmtInputOpt  input = dmBuildMgmtInputOpt(pWrapper);

  dInfo("node:%s, start to open", pWrapper->name);
  tmsgSetDefault(&input.msgCb);
  if ((code = (*pWrapper->func.openFp)(&input, &output)) != 0) {
    dError("node:%s, failed to open since %s", pWrapper->name, tstrerror(code));
    return code;
  }
  dInfo("node:%s, has been opened", pWrapper->name);
  pWrapper->deployed = true;

  if (output.pMgmt != NULL) {
    pWrapper->pMgmt = output.pMgmt;
  }

  dmReportStartup(pWrapper->name, "opened");
  return 0;
}

int32_t dmStartNode(SMgmtWrapper *pWrapper) {
  int32_t code = 0;
  if (pWrapper->func.startFp != NULL) {
    dDebug("node:%s, start to start", pWrapper->name);
    if ((code = (*pWrapper->func.startFp)(pWrapper->pMgmt)) != 0) {
      dError("node:%s, failed to start since %s", pWrapper->name, tstrerror(code));
      return code;
    }
    dDebug("node:%s, has been started", pWrapper->name);
  }

  dmReportStartup(pWrapper->name, "started");
  return 0;
}

void dmStopNode(SMgmtWrapper *pWrapper) {
  if (pWrapper->func.stopFp != NULL && pWrapper->pMgmt != NULL) {
    dDebug("node:%s, start to stop", pWrapper->name);
    (*pWrapper->func.stopFp)(pWrapper->pMgmt);
    dDebug("node:%s, has been stopped", pWrapper->name);
  }
}

void dmCloseNode(SMgmtWrapper *pWrapper) {
  dInfo("node:%s, start to close", pWrapper->name);
  pWrapper->deployed = false;

  while (pWrapper->refCount > 0) {
    taosMsleep(10);
  }

  (void)taosThreadRwlockWrlock(&pWrapper->lock);
  if (pWrapper->pMgmt != NULL) {
    (*pWrapper->func.closeFp)(pWrapper->pMgmt);
    pWrapper->pMgmt = NULL;
  }
  (void)taosThreadRwlockUnlock(&pWrapper->lock);

  dInfo("node:%s, has been closed", pWrapper->name);
}

static int32_t dmOpenNodes(SDnode *pDnode) {
  int32_t code = 0;
  for (EDndNodeType ntype = DNODE; ntype < NODE_END; ++ntype) {
    SMgmtWrapper *pWrapper = &pDnode->wrappers[ntype];
    if (!pWrapper->required) continue;
    if ((code = dmOpenNode(pWrapper)) != 0) {
      dError("node:%s, failed to open since %s", pWrapper->name, tstrerror(code));
      return code;
    }
  }

  auditSetDnodeId(dmGetDnodeId(&pDnode->data));
  monSetDnodeId(dmGetDnodeId(&pDnode->data));

  dmSetStatus(pDnode, DND_STAT_RUNNING);
  return 0;
}

static int32_t dmStartNodes(SDnode *pDnode) {
  int32_t code = 0;
  for (EDndNodeType ntype = DNODE; ntype < NODE_END; ++ntype) {
    SMgmtWrapper *pWrapper = &pDnode->wrappers[ntype];
    if (!pWrapper->required) continue;
    if ((code = dmStartNode(pWrapper)) != 0) {
      dError("node:%s, failed to start since %s", pWrapper->name, tstrerror(code));
      return code;
    }
  }

  dInfo("The daemon initialized successfully");
  dmReportStartup("The daemon", "initialized successfully");
  return 0;
}

static void dmStopNodes(SDnode *pDnode) {
  for (EDndNodeType n = DNODE; n < NODE_END; ++n) {
    SMgmtWrapper *pWrapper = &pDnode->wrappers[n];
    dmStopNode(pWrapper);
  }
}

static void dmCloseNodes(SDnode *pDnode) {
  for (EDndNodeType n = DNODE; n < NODE_END; ++n) {
    SMgmtWrapper *pWrapper = &pDnode->wrappers[n];
    dmCloseNode(pWrapper);
  }
}

int32_t dmRunDnode(SDnode *pDnode) {
  int32_t code = 0;
  int32_t count = 0;

  tsDndStartOsUptime = taosGetOsUptime();

  if ((code = dmOpenNodes(pDnode)) != 0) {
    dError("failed to open nodes since %s", tstrerror(code));
    dmCloseNodes(pDnode);
    return code;
  }

  if ((code = dmStartNodes(pDnode)) != 0) {
    dError("failed to start nodes since %s", tstrerror(code));
    dmSetStatus(pDnode, DND_STAT_STOPPED);
    dmStopNodes(pDnode);
    dmCloseNodes(pDnode);
    return code;
  }
  tsDndStart = taosGetTimestampMs();  // also used to wait for dnode to start
  if (tsDndStart == 0) ++tsDndStart;  // avoid 0

  while (1) {
    if (pDnode->stop) {
      dInfo("The daemon is about to stop");
      dmSetStatus(pDnode, DND_STAT_STOPPED);
      dmStopNodes(pDnode);
      dmCloseNodes(pDnode);
      return 0;
    }

    if (count == 10) {
      if(osUpdate() != 0) {
        dError("failed to update os info");
      }
      count = 0;
    } else {
      count++;
    }

    taosMsleep(100);
  }
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "dmMgmt.h"
18	#include "dmUtil.h"
19	#include "monitor.h"
20	#include "audit.h"
21
22	int32_t dmOpenNode(SMgmtWrapper *pWrapper) {	2,225,366✔
23	int32_t code = 0;	2,225,366✔
24	SDnode *pDnode = pWrapper->pDnode;	2,225,366✔
25
26	if (taosMkDir(pWrapper->path) != 0) {	2,225,366!
27	code = terrno;	×
28	dError("node:%s, failed to create dir:%s since %s", pWrapper->name, pWrapper->path, tstrerror(code));	×
29	return code;	×
30	}
31
32	SMgmtOutputOpt output = {0};	2,225,366✔
33	SMgmtInputOpt input = dmBuildMgmtInputOpt(pWrapper);	2,225,366✔
34
35	dInfo("node:%s, start to open", pWrapper->name);	2,225,366!
36	tmsgSetDefault(&input.msgCb);	2,225,366✔
37	if ((code = (*pWrapper->func.openFp)(&input, &output)) != 0) {	2,225,366!
38	dError("node:%s, failed to open since %s", pWrapper->name, tstrerror(code));	×
39	return code;	×
40	}
41	dInfo("node:%s, has been opened", pWrapper->name);	2,225,366!
42	pWrapper->deployed = true;	2,225,366✔
43
44	if (output.pMgmt != NULL) {	2,225,366!
45	pWrapper->pMgmt = output.pMgmt;	2,225,366✔
46	}
47
48	dmReportStartup(pWrapper->name, "opened");	2,225,366✔
49	return 0;	2,225,366✔
50	}
51
52	int32_t dmStartNode(SMgmtWrapper *pWrapper) {	2,225,366✔
53	int32_t code = 0;	2,225,366✔
54	if (pWrapper->func.startFp != NULL) {	2,225,366✔
55	dDebug("node:%s, start to start", pWrapper->name);	2,165,359✔
56	if ((code = (*pWrapper->func.startFp)(pWrapper->pMgmt)) != 0) {	2,165,359!
57	dError("node:%s, failed to start since %s", pWrapper->name, tstrerror(code));	×
58	return code;	×
59	}
60	dDebug("node:%s, has been started", pWrapper->name);	2,165,359✔
61	}
62
63	dmReportStartup(pWrapper->name, "started");	2,225,366✔
64	return 0;	2,225,366✔
65	}
66
67	void dmStopNode(SMgmtWrapper *pWrapper) {	4,620,141✔
68	if (pWrapper->func.stopFp != NULL && pWrapper->pMgmt != NULL) {	4,620,141✔
69	dDebug("node:%s, start to stop", pWrapper->name);	2,031,294✔
70	(*pWrapper->func.stopFp)(pWrapper->pMgmt);	2,031,294✔
71	dDebug("node:%s, has been stopped", pWrapper->name);	2,031,294✔
72	}
73	}	4,620,141✔
74
75	void dmCloseNode(SMgmtWrapper *pWrapper) {	4,620,141✔
76	dInfo("node:%s, start to close", pWrapper->name);	4,620,141!
77	pWrapper->deployed = false;	4,620,141✔
78
79	while (pWrapper->refCount > 0) {	4,620,141!
UNCOV 80	taosMsleep(10);	×
81	}
82
83	(void)taosThreadRwlockWrlock(&pWrapper->lock);	4,620,141✔
84	if (pWrapper->pMgmt != NULL) {	4,620,141✔
85	(*pWrapper->func.closeFp)(pWrapper->pMgmt);	2,225,366✔
86	pWrapper->pMgmt = NULL;	2,225,366✔
87	}
88	(void)taosThreadRwlockUnlock(&pWrapper->lock);	4,620,141✔
89
90	dInfo("node:%s, has been closed", pWrapper->name);	4,620,141!
91	}	4,620,141✔
92
93	static int32_t dmOpenNodes(SDnode *pDnode) {	743,181✔
94	int32_t code = 0;	743,181✔
95	for (EDndNodeType ntype = DNODE; ntype < NODE_END; ++ntype) {	5,202,267✔
96	SMgmtWrapper *pWrapper = &pDnode->wrappers[ntype];	4,459,086✔
97	if (!pWrapper->required) continue;	4,459,086✔
98	if ((code = dmOpenNode(pWrapper)) != 0) {	1,997,018!
99	dError("node:%s, failed to open since %s", pWrapper->name, tstrerror(code));	×
100	return code;	×
101	}
102	}
103
104	auditSetDnodeId(dmGetDnodeId(&pDnode->data));	743,181✔
105	monSetDnodeId(dmGetDnodeId(&pDnode->data));	743,181✔
106
107	dmSetStatus(pDnode, DND_STAT_RUNNING);	743,181✔
108	return 0;	743,181✔
109	}
110
111	static int32_t dmStartNodes(SDnode *pDnode) {	743,181✔
112	int32_t code = 0;	743,181✔
113	for (EDndNodeType ntype = DNODE; ntype < NODE_END; ++ntype) {	5,202,267✔
114	SMgmtWrapper *pWrapper = &pDnode->wrappers[ntype];	4,459,086✔
115	if (!pWrapper->required) continue;	4,459,086✔
116	if ((code = dmStartNode(pWrapper)) != 0) {	1,997,018!
117	dError("node:%s, failed to start since %s", pWrapper->name, tstrerror(code));	×
118	return code;	×
119	}
120	}
121
122	dInfo("The daemon initialized successfully");	743,181!
123	dmReportStartup("The daemon", "initialized successfully");	743,181✔
124	return 0;	743,181✔
125	}
126
127	static void dmStopNodes(SDnode *pDnode) {	743,181✔
128	for (EDndNodeType n = DNODE; n < NODE_END; ++n) {	5,202,267✔
129	SMgmtWrapper *pWrapper = &pDnode->wrappers[n];	4,459,086✔
130	dmStopNode(pWrapper);	4,459,086✔
131	}
132	}	743,181✔
133
134	static void dmCloseNodes(SDnode *pDnode) {	743,181✔
135	for (EDndNodeType n = DNODE; n < NODE_END; ++n) {	5,202,267✔
136	SMgmtWrapper *pWrapper = &pDnode->wrappers[n];	4,459,086✔
137	dmCloseNode(pWrapper);	4,459,086✔
138	}
139	}	743,181✔
140
141	int32_t dmRunDnode(SDnode *pDnode) {	743,181✔
142	int32_t code = 0;	743,181✔
143	int32_t count = 0;	743,181✔
144
145	tsDndStartOsUptime = taosGetOsUptime();	743,181✔
146
147	if ((code = dmOpenNodes(pDnode)) != 0) {	743,181!
148	dError("failed to open nodes since %s", tstrerror(code));	×
149	dmCloseNodes(pDnode);	×
150	return code;	×
151	}
152
153	if ((code = dmStartNodes(pDnode)) != 0) {	743,181!
154	dError("failed to start nodes since %s", tstrerror(code));	×
155	dmSetStatus(pDnode, DND_STAT_STOPPED);	×
156	dmStopNodes(pDnode);	×
157	dmCloseNodes(pDnode);	×
158	return code;	×
159	}
160	tsDndStart = taosGetTimestampMs(); // also used to wait for dnode to start	743,181✔
161	if (tsDndStart == 0) ++tsDndStart; // avoid 0	743,181!
162
163	while (1) {
164	if (pDnode->stop) {	392,052,451✔
165	dInfo("The daemon is about to stop");	743,181!
166	dmSetStatus(pDnode, DND_STAT_STOPPED);	743,181✔
167	dmStopNodes(pDnode);	743,181✔
168	dmCloseNodes(pDnode);	743,181✔
169	return 0;	743,181✔
170	}
171
172	if (count == 10) {	391,309,270✔
173	if(osUpdate() != 0) {	35,240,109!
174	dError("failed to update os info");	×
175	}
176	count = 0;	35,240,109✔
177	} else {
178	count++;	356,069,161✔
179	}
180
181	taosMsleep(100);	391,309,270✔
182	}
183	}

taosdata / TDengine / #4815

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous