• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4810

17 Oct 2025 06:47AM UTC coverage: 61.206% (+0.09%) from 61.121%
#4810

push

travis-ci

web-flow
Merge pull request #33289 from taosdata/3.0

enh: Code Optimization (#33283)

155673 of 324369 branches covered (47.99%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

387 existing lines in 93 files now uncovered.

207832 of 269535 relevant lines covered (77.11%)

126508882.03 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.66
/source/libs/parser/src/parAuthenticator.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "catalog.h"
17
#include "cmdnodes.h"
18
#include "parInt.h"
19

20
typedef struct SAuthCxt {
21
  SParseContext*   pParseCxt;
22
  SParseMetaCache* pMetaCache;
23
  int32_t          errCode;
24
} SAuthCxt;
25

26
typedef struct SSelectAuthCxt {
27
  SAuthCxt*    pAuthCxt;
28
  SSelectStmt* pSelect;
29
} SSelectAuthCxt;
30

31
typedef struct SAuthRewriteCxt {
32
  STableNode* pTarget;
33
} SAuthRewriteCxt;
34

35
static int32_t authQuery(SAuthCxt* pCxt, SNode* pStmt);
36

37
static int32_t setUserAuthInfo(SParseContext* pCxt, const char* pDbName, const char* pTabName, AUTH_TYPE type,
1,254,375✔
38
                               bool isView, bool effective, SUserAuthInfo* pAuth) {
39
  if (effective) {
1,254,375✔
40
    snprintf(pAuth->user, sizeof(pAuth->user), "%s", pCxt->pEffectiveUser ? pCxt->pEffectiveUser : "");
39,829!
41
  } else {
42
    snprintf(pAuth->user, sizeof(pAuth->user), "%s", pCxt->pUser);
1,214,546✔
43
  }
44

45
  if (NULL == pTabName) {
1,254,375✔
46
    int32_t code = tNameSetDbName(&pAuth->tbName, pCxt->acctId, pDbName, strlen(pDbName));
121,522!
47
    if (TSDB_CODE_SUCCESS != code) return code;
121,522!
48
  } else {
49
    toName(pCxt->acctId, pDbName, pTabName, &pAuth->tbName);
1,132,853✔
50
  }
51
  pAuth->type = type;
1,254,375✔
52
  pAuth->isView = isView;
1,254,375✔
53
  return TSDB_CODE_SUCCESS;
1,254,375✔
54
}
55

56
static int32_t checkAuthImpl(SAuthCxt* pCxt, const char* pDbName, const char* pTabName, AUTH_TYPE type, SNode** pCond,
196,260,876✔
57
                             bool isView, bool effective) {
58
  SParseContext* pParseCxt = pCxt->pParseCxt;
196,260,876✔
59
  if (pParseCxt->isSuperUser) {
196,261,902✔
60
    return TSDB_CODE_SUCCESS;
195,013,414✔
61
  }
62

63
  AUTH_RES_TYPE auth_res_type = isView ? AUTH_RES_VIEW : AUTH_RES_BASIC;
1,254,183✔
64
  SUserAuthInfo authInfo = {0};
1,254,183✔
65
  int32_t       code = setUserAuthInfo(pCxt->pParseCxt, pDbName, pTabName, type, isView, effective, &authInfo);
1,254,183✔
66
  if (TSDB_CODE_SUCCESS != code) return code;
1,254,375!
67
  SUserAuthRes authRes = {0};
1,254,375✔
68
  if (NULL != pCxt->pMetaCache) {
1,254,375✔
69
    code = getUserAuthFromCache(pCxt->pMetaCache, &authInfo, &authRes);
1,247,073✔
70
#ifdef TD_ENTERPRISE
71
    if (isView && TSDB_CODE_PAR_INTERNAL_ERROR == code) {
1,247,073✔
72
      authInfo.isView = false;
59,647✔
73
      code = getUserAuthFromCache(pCxt->pMetaCache, &authInfo, &authRes);
59,647✔
74
    }
75
#endif
76
  } else {
77
    SRequestConnInfo conn = {.pTrans = pParseCxt->pTransporter,
7,302✔
78
                             .requestId = pParseCxt->requestId,
7,302✔
79
                             .requestObjRefId = pParseCxt->requestRid,
7,302✔
80
                             .mgmtEps = pParseCxt->mgmtEpSet};
81
    code = catalogChkAuth(pParseCxt->pCatalog, &conn, &authInfo, &authRes);
7,302✔
82
  }
83
  if (TSDB_CODE_SUCCESS == code && NULL != pCond) {
1,254,375!
84
    *pCond = authRes.pCond[auth_res_type];
349,002✔
85
  }
86
  return TSDB_CODE_SUCCESS == code ? (authRes.pass[auth_res_type] ? TSDB_CODE_SUCCESS : TSDB_CODE_PAR_PERMISSION_DENIED)
1,254,375!
87
                                   : code;
2,494,652!
88
}
89

90
static int32_t checkAuth(SAuthCxt* pCxt, const char* pDbName, const char* pTabName, AUTH_TYPE type, SNode** pCond) {
195,804,379✔
91
  return checkAuthImpl(pCxt, pDbName, pTabName, type, pCond, false, false);
195,804,379✔
92
}
93

94
static int32_t checkEffectiveAuth(SAuthCxt* pCxt, const char* pDbName, const char* pTabName, AUTH_TYPE type,
25,645✔
95
                                  SNode** pCond) {
96
  return checkAuthImpl(pCxt, pDbName, pTabName, type, NULL, false, true);
25,645✔
97
}
98

99
static int32_t checkViewAuth(SAuthCxt* pCxt, const char* pDbName, const char* pTabName, AUTH_TYPE type, SNode** pCond) {
429,838✔
100
  return checkAuthImpl(pCxt, pDbName, pTabName, type, NULL, true, false);
429,838✔
101
}
102

103
static int32_t checkViewEffectiveAuth(SAuthCxt* pCxt, const char* pDbName, const char* pTabName, AUTH_TYPE type,
14,184✔
104
                                      SNode** pCond) {
105
  return checkAuthImpl(pCxt, pDbName, pTabName, type, NULL, true, true);
14,184✔
106
}
107

108
static EDealRes authSubquery(SAuthCxt* pCxt, SNode* pStmt) {
13,892,134✔
109
  return TSDB_CODE_SUCCESS == authQuery(pCxt, pStmt) ? DEAL_RES_CONTINUE : DEAL_RES_ERROR;
13,892,134!
110
}
111

112
static int32_t mergeStableTagCond(SNode** pWhere, SNode* pTagCond) {
156✔
113
  SLogicConditionNode* pLogicCond = NULL;
156✔
114
  int32_t              code = nodesMakeNode(QUERY_NODE_LOGIC_CONDITION, (SNode**)&pLogicCond);
156✔
115
  if (NULL == pLogicCond) {
156!
116
    return code;
×
117
  }
118
  pLogicCond->node.resType.type = TSDB_DATA_TYPE_BOOL;
156✔
119
  pLogicCond->node.resType.bytes = tDataTypes[TSDB_DATA_TYPE_BOOL].bytes;
156✔
120
  pLogicCond->condType = LOGIC_COND_TYPE_AND;
156✔
121
  code = nodesListMakeStrictAppend(&pLogicCond->pParameterList, pTagCond);
156✔
122
  if (TSDB_CODE_SUCCESS == code) {
156!
123
    code = nodesListMakeAppend(&pLogicCond->pParameterList, *pWhere);
156✔
124
  }
125
  if (TSDB_CODE_SUCCESS == code) {
156!
126
    *pWhere = (SNode*)pLogicCond;
156✔
127
  } else {
128
    nodesDestroyNode((SNode*)pLogicCond);
×
129
  }
130
  return code;
156✔
131
}
132

133
EDealRes rewriteAuthTable(SNode* pNode, void* pContext) {
54,114✔
134
  if (QUERY_NODE_COLUMN == nodeType(pNode)) {
54,114✔
135
    SColumnNode*     pCol = (SColumnNode*)pNode;
17,886✔
136
    SAuthRewriteCxt* pCxt = (SAuthRewriteCxt*)pContext;
17,886✔
137
    tstrncpy(pCol->tableName, pCxt->pTarget->tableName, TSDB_TABLE_NAME_LEN);
17,886!
138
    tstrncpy(pCol->tableAlias, pCxt->pTarget->tableAlias, TSDB_TABLE_NAME_LEN);
17,886!
139
  }
140

141
  return DEAL_RES_CONTINUE;
54,114✔
142
}
143

144
static int32_t rewriteAppendStableTagCond(SNode** pWhere, SNode* pTagCond, STableNode* pTable) {
17,430✔
145
  SNode*  pTagCondCopy = NULL;
17,430✔
146
  int32_t code = nodesCloneNode(pTagCond, &pTagCondCopy);
17,430✔
147
  if (NULL == pTagCondCopy) {
17,430!
148
    return code;
×
149
  }
150

151
  SAuthRewriteCxt cxt = {.pTarget = pTable};
17,430✔
152
  nodesWalkExpr(pTagCondCopy, rewriteAuthTable, &cxt);
17,430✔
153

154
  if (NULL == *pWhere) {
17,430✔
155
    *pWhere = pTagCondCopy;
17,274✔
156
    return TSDB_CODE_SUCCESS;
17,274✔
157
  }
158

159
  if (QUERY_NODE_LOGIC_CONDITION == nodeType(*pWhere) &&
156!
160
      LOGIC_COND_TYPE_AND == ((SLogicConditionNode*)*pWhere)->condType) {
×
161
    return nodesListStrictAppend(((SLogicConditionNode*)*pWhere)->pParameterList, pTagCondCopy);
×
162
  }
163

164
  return mergeStableTagCond(pWhere, pTagCondCopy);
156✔
165
}
166

167
static EDealRes authSelectImpl(SNode* pNode, void* pContext) {
1,503,092,821✔
168
  SSelectAuthCxt* pCxt = pContext;
1,503,092,821✔
169
  SAuthCxt*       pAuthCxt = pCxt->pAuthCxt;
1,503,092,821✔
170
  bool            isView = false;
1,503,095,955✔
171
  if (QUERY_NODE_REAL_TABLE == nodeType(pNode)) {
1,503,095,955✔
172
    SNode*      pTagCond = NULL;
124,610,246✔
173
    STableNode* pTable = (STableNode*)pNode;
124,608,648✔
174
#ifdef TD_ENTERPRISE
175
    SName name = {0};
124,608,648✔
176
    toName(pAuthCxt->pParseCxt->acctId, pTable->dbName, pTable->tableName, &name);
124,609,960✔
177
    STableMeta* pTableMeta = NULL;
124,610,354✔
178
    toName(pAuthCxt->pParseCxt->acctId, pTable->dbName, pTable->tableName, &name);
124,610,958✔
179
    int32_t code = getTargetMetaImpl(pAuthCxt->pParseCxt, pAuthCxt->pMetaCache, &name, &pTableMeta, true);
124,611,278✔
180
    if (TSDB_CODE_SUCCESS == code && TSDB_VIEW_TABLE == pTableMeta->tableType) {
124,604,624✔
181
      isView = true;
293,348✔
182
    }
183
    taosMemoryFree(pTableMeta);
124,606,538!
184
#endif
185
    if (!isView) {
124,604,539✔
186
      pAuthCxt->errCode = checkAuth(pAuthCxt, pTable->dbName, pTable->tableName, AUTH_TYPE_READ, &pTagCond);
124,311,191✔
187
      if (TSDB_CODE_SUCCESS != pAuthCxt->errCode && NULL != pAuthCxt->pParseCxt->pEffectiveUser) {
124,316,471✔
188
        pAuthCxt->errCode = checkEffectiveAuth(pAuthCxt, pTable->dbName, pTable->tableName, AUTH_TYPE_READ, NULL);
25,645✔
189
      }
190
      if (TSDB_CODE_SUCCESS == pAuthCxt->errCode && NULL != pTagCond) {
124,315,605✔
191
        pAuthCxt->errCode = rewriteAppendStableTagCond(&pCxt->pSelect->pWhere, pTagCond, pTable);
17,430✔
192
      }
193
    } else {
194
      pAuthCxt->errCode = checkViewAuth(pAuthCxt, pTable->dbName, pTable->tableName, AUTH_TYPE_READ, NULL);
293,348✔
195
      if (TSDB_CODE_SUCCESS != pAuthCxt->errCode && NULL != pAuthCxt->pParseCxt->pEffectiveUser) {
293,348✔
196
        pAuthCxt->errCode = checkViewEffectiveAuth(pAuthCxt, pTable->dbName, pTable->tableName, AUTH_TYPE_READ, NULL);
14,184✔
197
      }
198
    }
199
    return TSDB_CODE_SUCCESS == pAuthCxt->errCode ? DEAL_RES_CONTINUE : DEAL_RES_ERROR;
124,609,215✔
200
  } else if (QUERY_NODE_TEMP_TABLE == nodeType(pNode)) {
1,378,490,094✔
201
    return authSubquery(pAuthCxt, ((STempTableNode*)pNode)->pSubquery);
13,895,048✔
202
  }
203
  return DEAL_RES_CONTINUE;
1,364,595,108✔
204
}
205

206
static int32_t authSelect(SAuthCxt* pCxt, SSelectStmt* pSelect) {
131,462,914✔
207
  SSelectAuthCxt cxt = {.pAuthCxt = pCxt, .pSelect = pSelect};
131,462,914✔
208
  nodesWalkSelectStmt(pSelect, SQL_CLAUSE_FROM, authSelectImpl, &cxt);
131,463,862✔
209
  return pCxt->errCode;
131,463,459✔
210
}
211

212
static int32_t authSetOperator(SAuthCxt* pCxt, SSetOperator* pSetOper) {
4,234,460✔
213
  int32_t code = authQuery(pCxt, pSetOper->pLeft);
4,234,460✔
214
  if (TSDB_CODE_SUCCESS == code) {
4,234,460!
215
    code = authQuery(pCxt, pSetOper->pRight);
4,234,460✔
216
  }
217
  return code;
4,234,460✔
218
}
219

220
static int32_t authDropUser(SAuthCxt* pCxt, SDropUserStmt* pStmt) {
28,987✔
221
  if (!pCxt->pParseCxt->isSuperUser || 0 == strcmp(pStmt->userName, TSDB_DEFAULT_USER)) {
28,987!
222
    return TSDB_CODE_PAR_PERMISSION_DENIED;
956✔
223
  }
224
  return TSDB_CODE_SUCCESS;
28,031✔
225
}
226

227
static int32_t authDelete(SAuthCxt* pCxt, SDeleteStmt* pDelete) {
3,203,450✔
228
  SNode*      pTagCond = NULL;
3,203,450✔
229
  STableNode* pTable = (STableNode*)pDelete->pFromTable;
3,203,450✔
230
  int32_t     code = checkAuth(pCxt, pTable->dbName, pTable->tableName, AUTH_TYPE_WRITE, &pTagCond);
3,203,450✔
231
  if (TSDB_CODE_SUCCESS == code && NULL != pTagCond) {
3,203,450!
232
    code = rewriteAppendStableTagCond(&pDelete->pWhere, pTagCond, pTable);
×
233
  }
234
  return code;
3,203,450✔
235
}
236

237
static int32_t authInsert(SAuthCxt* pCxt, SInsertStmt* pInsert) {
87,405✔
238
  SNode*      pTagCond = NULL;
87,405✔
239
  STableNode* pTable = (STableNode*)pInsert->pTable;
87,405✔
240
  // todo check tag condition for subtable
241
  int32_t code = checkAuth(pCxt, pTable->dbName, pTable->tableName, AUTH_TYPE_WRITE, &pTagCond);
87,405✔
242
  if (TSDB_CODE_SUCCESS == code) {
87,405!
243
    code = authQuery(pCxt, pInsert->pQuery);
87,405✔
244
  }
245
  return code;
87,405✔
246
}
247

248
static int32_t authShowTables(SAuthCxt* pCxt, SShowStmt* pStmt) {
672,030✔
249
  return checkAuth(pCxt, ((SValueNode*)pStmt->pDbName)->literal, NULL, AUTH_TYPE_READ_OR_WRITE, NULL);
672,030✔
250
}
251

252
static int32_t authShowVtables(SAuthCxt* pCxt, SShowStmt* pStmt) { return authShowTables(pCxt, pStmt); }
70,948✔
253

254
static int32_t authShowUsage(SAuthCxt* pCxt, SShowStmt* pStmt) {
×
255
  return checkAuth(pCxt, ((SValueNode*)pStmt->pDbName)->literal, NULL, AUTH_TYPE_READ_OR_WRITE, NULL);
×
256
}
257

258
static int32_t authShowCreateTable(SAuthCxt* pCxt, SShowCreateTableStmt* pStmt) {
121,652✔
259
  SNode* pTagCond = NULL;
121,652✔
260
  // todo check tag condition for subtable
261
  return checkAuth(pCxt, pStmt->dbName, pStmt->tableName, AUTH_TYPE_READ, &pTagCond);
121,652✔
262
}
263

264
static int32_t authShowCreateView(SAuthCxt* pCxt, SShowCreateViewStmt* pStmt) {
×
265
#ifndef TD_ENTERPRISE
266
  return TSDB_CODE_OPS_NOT_SUPPORT;
267
#endif
268

269
  return TSDB_CODE_SUCCESS;
×
270
}
271

272
static int32_t authCreateTable(SAuthCxt* pCxt, SCreateTableStmt* pStmt) {
4,524,683✔
273
  SNode* pTagCond = NULL;
4,524,683✔
274
  // todo check tag condition for subtable
275
  return checkAuth(pCxt, pStmt->dbName, NULL, AUTH_TYPE_WRITE, &pTagCond);
4,524,683✔
276
}
277

278
static int32_t authCreateVTable(SAuthCxt* pCxt, SCreateVTableStmt* pStmt) {
157,985✔
279
  PAR_ERR_RET(checkAuth(pCxt, pStmt->dbName, NULL, AUTH_TYPE_WRITE, NULL));
157,985✔
280
  SNode* pCol = NULL;
145,617✔
281
  FOREACH(pCol, pStmt->pCols) {
1,706,170!
282
    SColumnDefNode* pColDef = (SColumnDefNode*)pCol;
1,569,829✔
283
    if (NULL == pColDef) {
1,569,829!
284
      PAR_ERR_RET(TSDB_CODE_PAR_INVALID_COLUMN);
×
285
    }
286
    SColumnOptions* pOptions = (SColumnOptions*)pColDef->pOptions;
1,569,829✔
287
    if (pOptions && pOptions->hasRef) {
1,569,829!
288
      PAR_ERR_RET(checkAuth(pCxt, pOptions->refDb, pOptions->refTable, AUTH_TYPE_READ, NULL));
855,019✔
289
    }
290
  }
291
  return TSDB_CODE_SUCCESS;
136,341✔
292
}
293

294
static int32_t authCreateVSubTable(SAuthCxt* pCxt, SCreateVSubTableStmt* pStmt) {
315,684✔
295
  int32_t    code = TSDB_CODE_SUCCESS;
315,684✔
296
  SNode*     pNode = NULL;
315,684✔
297
  SNodeList* pTmpList = pStmt->pSpecificColRefs ? pStmt->pSpecificColRefs : pStmt->pColRefs;
315,684✔
298
  PAR_ERR_RET(checkAuth(pCxt, pStmt->dbName, NULL, AUTH_TYPE_WRITE, NULL));
315,684✔
299
  if (NULL == pTmpList) {
303,316✔
300
    // no column reference
301
    return TSDB_CODE_SUCCESS;
4,513✔
302
  }
303

304
  FOREACH(pNode, pTmpList) {
2,144,000!
305
    SColumnRefNode* pColRef = (SColumnRefNode*)pNode;
1,854,473✔
306
    if (NULL == pColRef) {
1,854,473!
307
      PAR_ERR_RET(TSDB_CODE_PAR_INVALID_COLUMN);
×
308
    }
309
    PAR_ERR_RET(checkAuth(pCxt, pColRef->refDbName, pColRef->refTableName, AUTH_TYPE_READ, NULL));
1,854,473✔
310
  }
311
  return code;
289,527✔
312
}
313

314
static int32_t authCreateStream(SAuthCxt* pCxt, SCreateStreamStmt* pStmt) {
480,487✔
315
  int32_t   code = TSDB_CODE_SUCCESS;
480,487✔
316

317
  if (IS_SYS_DBNAME(pStmt->streamDbName)) {
480,487!
318
    return TSDB_CODE_PAR_PERMISSION_DENIED;
×
319
  }
320
  if (IS_SYS_DBNAME(pStmt->targetDbName)) {
480,487!
321
    return TSDB_CODE_PAR_PERMISSION_DENIED;
116✔
322
  }
323
  if (pStmt->pTrigger) {
480,371!
324
    SStreamTriggerNode *pTrigger = (SStreamTriggerNode*)pStmt->pTrigger;
480,371✔
325
    STableNode* pTriggerTable = (STableNode*)pTrigger->pTrigerTable;
480,371✔
326
    if (pTriggerTable && IS_SYS_DBNAME(pTriggerTable->dbName)) {
480,371!
327
      return TSDB_CODE_PAR_PERMISSION_DENIED;
116✔
328
    }
329
  }
330
  return code;
480,255✔
331
}
332

333
static int32_t authCreateMultiTable(SAuthCxt* pCxt, SCreateMultiTablesStmt* pStmt) {
30,106,204✔
334
  int32_t code = TSDB_CODE_SUCCESS;
30,106,204✔
335
  SNode*  pNode = NULL;
30,106,204✔
336
  FOREACH(pNode, pStmt->pSubTables) {
63,859,372!
337
    if (pNode->type == QUERY_NODE_CREATE_SUBTABLE_CLAUSE) {
33,754,349!
338
      SCreateSubTableClause* pClause = (SCreateSubTableClause*)pNode;
33,756,044✔
339
      code = checkAuth(pCxt, pClause->dbName, NULL, AUTH_TYPE_WRITE, NULL);
33,756,044✔
340
      if (TSDB_CODE_SUCCESS != code) {
33,754,313✔
341
        break;
512✔
342
      }
343
    } else {
344
      SCreateSubTableFromFileClause* pClause = (SCreateSubTableFromFileClause*)pNode;
×
345
      code = checkAuth(pCxt, pClause->useDbName, NULL, AUTH_TYPE_WRITE, NULL);
×
UNCOV
346
      if (TSDB_CODE_SUCCESS != code) {
×
347
        break;
×
348
      }
349
    }
350
  }
351
  return code;
30,107,661✔
352
}
353

354
static int32_t authDropTable(SAuthCxt* pCxt, SDropTableStmt* pStmt) {
9,691,624✔
355
  int32_t code = TSDB_CODE_SUCCESS;
9,691,624✔
356
  if (pStmt->withOpt && !pCxt->pParseCxt->isSuperUser) {
9,691,624!
357
    return TSDB_CODE_PAR_PERMISSION_DENIED;
918✔
358
  }
359
  SNode* pNode = NULL;
9,690,706✔
360
  FOREACH(pNode, pStmt->pTables) {
19,773,274!
361
    SDropTableClause* pClause = (SDropTableClause*)pNode;
10,082,724✔
362
    code = checkAuth(pCxt, pClause->dbName, pClause->tableName, AUTH_TYPE_WRITE, NULL);
10,082,724✔
363
    if (TSDB_CODE_SUCCESS != code) {
10,082,724✔
364
      break;
156✔
365
    }
366
  }
367
  return code;
9,690,706✔
368
}
369

370
static int32_t authDropStable(SAuthCxt* pCxt, SDropSuperTableStmt* pStmt) {
259,095✔
371
  if (pStmt->withOpt && !pCxt->pParseCxt->isSuperUser) {
259,095!
372
    return TSDB_CODE_PAR_PERMISSION_DENIED;
459✔
373
  }
374
  return checkAuth(pCxt, pStmt->dbName, pStmt->tableName, AUTH_TYPE_WRITE, NULL);
258,636✔
375
}
376

377
static int32_t authDropVtable(SAuthCxt* pCxt, SDropVirtualTableStmt* pStmt) {
87,925✔
378
  if (pStmt->withOpt && !pCxt->pParseCxt->isSuperUser) {
87,925!
379
    return TSDB_CODE_PAR_PERMISSION_DENIED;
×
380
  }
381
  return checkAuth(pCxt, pStmt->dbName, pStmt->tableName, AUTH_TYPE_WRITE, NULL);
87,925✔
382
}
383

384
static int32_t authAlterTable(SAuthCxt* pCxt, SAlterTableStmt* pStmt) {
14,678,040✔
385
  SNode* pTagCond = NULL;
14,678,040✔
386
  // todo check tag condition for subtable
387
  return checkAuth(pCxt, pStmt->dbName, pStmt->tableName, AUTH_TYPE_WRITE, NULL);
14,678,040✔
388
}
389

390
static int32_t authAlterVTable(SAuthCxt* pCxt, SAlterTableStmt* pStmt) {
467,039✔
391
  PAR_ERR_RET(checkAuth(pCxt, pStmt->dbName, pStmt->tableName, AUTH_TYPE_WRITE, NULL));
467,039✔
392
  if (pStmt->alterType == TSDB_ALTER_TABLE_ADD_COLUMN_WITH_COLUMN_REF ||
398,927✔
393
      pStmt->alterType == TSDB_ALTER_TABLE_ALTER_COLUMN_REF) {
364,097✔
394
    PAR_ERR_RET(checkAuth(pCxt, pStmt->dbName, pStmt->refTableName, AUTH_TYPE_READ, NULL));
155,363✔
395
  }
396
  PAR_RET(TSDB_CODE_SUCCESS);
374,159!
397
}
398

399
static int32_t authCreateView(SAuthCxt* pCxt, SCreateViewStmt* pStmt) {
216,066✔
400
#ifndef TD_ENTERPRISE
401
  return TSDB_CODE_OPS_NOT_SUPPORT;
402
#endif
403
  return checkAuth(pCxt, pStmt->dbName, NULL, AUTH_TYPE_WRITE, NULL);
216,066✔
404
}
405

406
static int32_t authDropView(SAuthCxt* pCxt, SDropViewStmt* pStmt) {
136,490✔
407
#ifndef TD_ENTERPRISE
408
  return TSDB_CODE_OPS_NOT_SUPPORT;
409
#endif
410
  return checkViewAuth(pCxt, pStmt->dbName, pStmt->viewName, AUTH_TYPE_ALTER, NULL);
136,490✔
411
}
412

413
static int32_t authCreateRsma(SAuthCxt* pCxt, SCreateRsmaStmt* pStmt) {
75,776✔
414
  return TSDB_CODE_SUCCESS;
75,776✔
415
}
416

417
static int32_t authDropRsma(SAuthCxt* pCxt, SDropRsmaStmt* pStmt) {
1,536✔
418
  return TSDB_CODE_SUCCESS;
1,536✔
419
}
420

421
static int32_t authQuery(SAuthCxt* pCxt, SNode* pStmt) {
225,591,722✔
422
  switch (nodeType(pStmt)) {
225,591,722✔
423
    case QUERY_NODE_SET_OPERATOR:
4,234,460✔
424
      return authSetOperator(pCxt, (SSetOperator*)pStmt);
4,234,460✔
425
    case QUERY_NODE_SELECT_STMT:
131,461,456✔
426
      return authSelect(pCxt, (SSelectStmt*)pStmt);
131,461,456✔
427
    case QUERY_NODE_DROP_USER_STMT:
28,987✔
428
      return authDropUser(pCxt, (SDropUserStmt*)pStmt);
28,987✔
429
    case QUERY_NODE_DELETE_STMT:
3,203,450✔
430
      return authDelete(pCxt, (SDeleteStmt*)pStmt);
3,203,450✔
431
    case QUERY_NODE_INSERT_STMT:
87,405✔
432
      return authInsert(pCxt, (SInsertStmt*)pStmt);
87,405✔
433
    case QUERY_NODE_CREATE_TABLE_STMT:
4,524,683✔
434
      return authCreateTable(pCxt, (SCreateTableStmt*)pStmt);
4,524,683✔
435
    case QUERY_NODE_CREATE_VIRTUAL_TABLE_STMT:
157,985✔
436
      return authCreateVTable(pCxt, (SCreateVTableStmt*)pStmt);
157,985✔
437
    case QUERY_NODE_CREATE_VIRTUAL_SUBTABLE_STMT:
315,684✔
438
      return authCreateVSubTable(pCxt, (SCreateVSubTableStmt*)pStmt);
315,684✔
439
    case QUERY_NODE_CREATE_MULTI_TABLES_STMT:
30,106,159✔
440
      return authCreateMultiTable(pCxt, (SCreateMultiTablesStmt*)pStmt);
30,106,159✔
441
    case QUERY_NODE_CREATE_STREAM_STMT:
480,487✔
442
      return authCreateStream(pCxt, (SCreateStreamStmt*)pStmt);
480,487✔
443
    case QUERY_NODE_DROP_TABLE_STMT:
9,691,624✔
444
      return authDropTable(pCxt, (SDropTableStmt*)pStmt);
9,691,624✔
445
    case QUERY_NODE_DROP_SUPER_TABLE_STMT:
259,095✔
446
      return authDropStable(pCxt, (SDropSuperTableStmt*)pStmt);
259,095✔
447
    case QUERY_NODE_DROP_VIRTUAL_TABLE_STMT:
87,925✔
448
      return authDropVtable(pCxt, (SDropVirtualTableStmt*)pStmt);
87,925✔
449
    case QUERY_NODE_ALTER_TABLE_STMT:
14,678,040✔
450
    case QUERY_NODE_ALTER_SUPER_TABLE_STMT:
451
      return authAlterTable(pCxt, (SAlterTableStmt*)pStmt);
14,678,040✔
452
    case QUERY_NODE_ALTER_VIRTUAL_TABLE_STMT:
467,039✔
453
      return authAlterVTable(pCxt, (SAlterTableStmt*)pStmt);
467,039✔
454
    case QUERY_NODE_SHOW_DNODES_STMT:
1,565,090✔
455
    case QUERY_NODE_SHOW_MNODES_STMT:
456
    case QUERY_NODE_SHOW_MODULES_STMT:
457
    case QUERY_NODE_SHOW_QNODES_STMT:
458
    case QUERY_NODE_SHOW_SNODES_STMT:
459
    case QUERY_NODE_SHOW_BACKUP_NODES_STMT:
460
    case QUERY_NODE_SHOW_CLUSTER_STMT:
461
    case QUERY_NODE_SHOW_LICENCES_STMT:
462
    case QUERY_NODE_SHOW_VGROUPS_STMT:
463
    case QUERY_NODE_SHOW_DB_ALIVE_STMT:
464
    case QUERY_NODE_SHOW_CLUSTER_ALIVE_STMT:
465
    case QUERY_NODE_SHOW_CREATE_DATABASE_STMT:
466
    case QUERY_NODE_SHOW_TABLE_DISTRIBUTED_STMT:
467
    case QUERY_NODE_SHOW_DNODE_VARIABLES_STMT:
468
    case QUERY_NODE_SHOW_VNODES_STMT:
469
    case QUERY_NODE_SHOW_SCORES_STMT:
470
    case QUERY_NODE_SHOW_USERS_STMT:
471
    case QUERY_NODE_SHOW_USERS_FULL_STMT:
472
    case QUERY_NODE_SHOW_USER_PRIVILEGES_STMT:
473
    case QUERY_NODE_SHOW_GRANTS_FULL_STMT:
474
    case QUERY_NODE_SHOW_GRANTS_LOGS_STMT:
475
    case QUERY_NODE_SHOW_CLUSTER_MACHINES_STMT:
476
    case QUERY_NODE_SHOW_ARBGROUPS_STMT:
477
    case QUERY_NODE_SHOW_ENCRYPTIONS_STMT:
478
    case QUERY_NODE_SHOW_MOUNTS_STMT:
479
      return !pCxt->pParseCxt->enableSysInfo ? TSDB_CODE_PAR_PERMISSION_DENIED : TSDB_CODE_SUCCESS;
1,565,090✔
480
    case QUERY_NODE_SHOW_USAGE_STMT:
1,833✔
481
    case QUERY_NODE_SHOW_ANODES_STMT:
482
    case QUERY_NODE_SHOW_ANODES_FULL_STMT:
483
      return TSDB_CODE_SUCCESS;
1,833✔
484
    case QUERY_NODE_SHOW_TABLES_STMT:
601,082✔
485
    case QUERY_NODE_SHOW_STABLES_STMT:
486
      return authShowTables(pCxt, (SShowStmt*)pStmt);
601,082✔
487
    case QUERY_NODE_SHOW_VTABLES_STMT:
70,948✔
488
      return authShowVtables(pCxt, (SShowStmt*)pStmt);
70,948✔
489
    case QUERY_NODE_SHOW_CREATE_TABLE_STMT:
121,652✔
490
    case QUERY_NODE_SHOW_CREATE_VTABLE_STMT:
491
    case QUERY_NODE_SHOW_CREATE_STABLE_STMT:
492
      return authShowCreateTable(pCxt, (SShowCreateTableStmt*)pStmt);
121,652✔
493
      //    case QUERY_NODE_SHOW_CREATE_VIEW_STMT:
494
      //      return authShowCreateView(pCxt, (SShowCreateViewStmt*)pStmt);
495
    case QUERY_NODE_CREATE_VIEW_STMT:
216,066✔
496
      return authCreateView(pCxt, (SCreateViewStmt*)pStmt);
216,066✔
497
    case QUERY_NODE_DROP_VIEW_STMT:
136,490✔
498
      return authDropView(pCxt, (SDropViewStmt*)pStmt);
136,490✔
499
    case QUERY_NODE_CREATE_RSMA_STMT:
75,776✔
500
      return authCreateRsma(pCxt, (SCreateRsmaStmt*)pStmt);
75,776✔
501
    case QUERY_NODE_DROP_RSMA_STMT:
8,240✔
502
      return authDropRsma(pCxt, (SDropRsmaStmt*)pStmt);
8,240✔
503
    default:
23,011,408✔
504
      break;
23,011,408✔
505
  }
506

507
  return TSDB_CODE_SUCCESS;
23,011,408✔
508
}
509

510
int32_t authenticate(SParseContext* pParseCxt, SQuery* pQuery, SParseMetaCache* pMetaCache) {
203,139,789✔
511
  SAuthCxt cxt = {.pParseCxt = pParseCxt, .pMetaCache = pMetaCache, .errCode = TSDB_CODE_SUCCESS};
203,139,789✔
512
  return authQuery(&cxt, pQuery->pRoot);
203,144,669✔
513
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc