• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4810

17 Oct 2025 06:47AM UTC coverage: 61.206% (+0.09%) from 61.121%
#4810

push

travis-ci

web-flow
Merge pull request #33289 from taosdata/3.0

enh: Code Optimization (#33283)

155673 of 324369 branches covered (47.99%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

387 existing lines in 93 files now uncovered.

207832 of 269535 relevant lines covered (77.11%)

126508882.03 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

65.96
/source/dnode/vnode/src/vnd/vnodeBufPool.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "vnd.h"
17

18
/* ------------------------ STRUCTURES ------------------------ */
19
static int32_t vnodeBufPoolCreate(SVnode *pVnode, int32_t id, int64_t size, SVBufPool **ppPool) {
12,164,079✔
20
  SVBufPool *pPool;
21

22
  pPool = taosMemoryCalloc(1, sizeof(SVBufPool));
12,164,079!
23
  if (pPool == NULL) {
12,160,779!
24
    vError("vgId:%d, failed to allocate buffer pool", TD_VID(pVnode));
×
25
    return terrno;
×
26
  }
27
  pPool->node.data = taosMemoryMalloc(size);
12,160,779!
28
  if (NULL == pPool->node.data) {
12,165,067!
29
    vError("vgId:%d, failed to allocate buffer pool data, size:%" PRId64, TD_VID(pVnode), size);
×
30
    taosMemoryFree(pPool);
×
31
    return terrno;
×
32
  }
33

34
  // query handle list
35
  (void)taosThreadMutexInit(&pPool->mutex, NULL);
12,164,776✔
36
  pPool->nQuery = 0;
12,163,813✔
37
  pPool->qList.pNext = &pPool->qList;
12,163,986✔
38
  pPool->qList.ppNext = &pPool->qList.pNext;
12,164,121✔
39

40
  pPool->pVnode = pVnode;
12,164,911✔
41
  pPool->id = id;
12,163,790✔
42
  pPool->ptr = pPool->node.data;
12,163,455✔
43
  pPool->pTail = &pPool->node;
12,164,887✔
44
  pPool->node.prev = NULL;
12,164,714✔
45
  pPool->node.pnext = &pPool->pTail;
12,164,523✔
46
  pPool->node.size = size;
12,164,446✔
47

48
  *ppPool = pPool;
12,164,155✔
49
  return 0;
12,161,877✔
50
}
51

52
static void vnodeBufPoolDestroy(SVBufPool *pPool) {
12,165,240✔
53
  vnodeBufPoolReset(pPool);
12,165,240✔
54
  (void)taosThreadMutexDestroy(&pPool->mutex);
12,165,240✔
55
  taosMemoryFree(pPool->node.data);
12,165,240!
56
  taosMemoryFree(pPool);
12,165,240!
57
}
12,165,240✔
58

59
int vnodeOpenBufPool(SVnode *pVnode) {
4,049,831✔
60
  int64_t size = pVnode->config.szBuf / VNODE_BUFPOOL_SEGMENTS;
4,049,831✔
61

62
  for (int i = 0; i < VNODE_BUFPOOL_SEGMENTS; i++) {
16,216,965✔
63
    // create pool
64
    int32_t code;
65
    if ((code = vnodeBufPoolCreate(pVnode, i, size, &pVnode->aBufPool[i]))) {
12,163,005!
66
      vError("vgId:%d, failed to open vnode buffer pool since %s", TD_VID(pVnode), tstrerror(terrno));
×
67
      vnodeCloseBufPool(pVnode);
×
68
      return code;
×
69
    }
70

71
    // add to free list
72
    pVnode->aBufPool[i]->freeNext = pVnode->freeList;
12,162,709✔
73
    pVnode->freeList = pVnode->aBufPool[i];
12,163,341✔
74
  }
75

76
  vDebug("vgId:%d, vnode buffer pool is opened, size:%" PRId64, TD_VID(pVnode), size);
4,053,960✔
77
  return 0;
4,055,080✔
78
}
79

80
void vnodeCloseBufPool(SVnode *pVnode) {
4,055,080✔
81
  for (int32_t i = 0; i < VNODE_BUFPOOL_SEGMENTS; i++) {
16,220,320✔
82
    if (pVnode->aBufPool[i]) {
12,165,240!
83
      vnodeBufPoolDestroy(pVnode->aBufPool[i]);
12,165,240✔
84
      pVnode->aBufPool[i] = NULL;
12,165,240✔
85
    }
86
  }
87

88
  vDebug("vgId:%d, vnode buffer pool is closed", TD_VID(pVnode));
4,055,080✔
89
}
4,055,080✔
90

91
void vnodeBufPoolReset(SVBufPool *pPool) {
18,498,020✔
92
  if (pPool->nQuery != 0) {
18,498,020!
93
    vError("vgId:%d, buffer pool %p of id %d has %d queries, reset it may cause problem", TD_VID(pPool->pVnode), pPool,
×
94
           pPool->id, pPool->nQuery);
95
  }
96

97
  for (SVBufPoolNode *pNode = pPool->pTail; pNode->prev; pNode = pPool->pTail) {
664,916,348✔
98
    pNode->prev->pnext = &pPool->pTail;
646,418,328✔
99
    pPool->pTail = pNode->prev;
646,418,328✔
100
    pPool->size = pPool->size - sizeof(*pNode) - pNode->size;
646,418,328✔
101
    taosMemoryFree(pNode);
646,418,328!
102
  }
103

104
  pPool->size = 0;
18,498,020✔
105
  pPool->ptr = pPool->node.data;
18,498,020✔
106
}
18,498,020✔
107

108
void *vnodeBufPoolMallocAligned(SVBufPool *pPool, int size) {
2,147,483,647✔
109
  SVBufPoolNode *pNode;
110
  void          *p = NULL;
2,147,483,647✔
111
  uint8_t       *ptr = NULL;
2,147,483,647✔
112
  int            paddingLen = 0;
2,147,483,647✔
113

114
  if (pPool == NULL) {
2,147,483,647!
115
    terrno = TSDB_CODE_INVALID_PARA;
×
116
    return NULL;
×
117
  }
118

119
  ptr = pPool->ptr;
2,147,483,647✔
120
  paddingLen = (((long)ptr + 7) & ~7) - (long)ptr;
2,147,483,647✔
121

122
  if (pPool->node.size >= pPool->ptr - pPool->node.data + size + paddingLen) {
2,147,483,647✔
123
    // allocate from the anchor node
124
    p = pPool->ptr + paddingLen;
2,147,483,647✔
125
    size += paddingLen;
2,147,483,647✔
126
    pPool->ptr = pPool->ptr + size;
2,147,483,647✔
127
    pPool->size += size;
2,147,483,647✔
128
  } else {
129
    // allocate a new node
130
    pNode = taosMemoryMalloc(sizeof(*pNode) + size);
646,418,328!
131
    if (pNode == NULL) {
646,418,328!
132
      return NULL;
×
133
    }
134
    pNode->data = (uint8_t *)&pNode[1];
646,418,328✔
135

136
    p = pNode->data;
646,418,328✔
137
    pNode->size = size;
646,418,328✔
138
    pNode->prev = pPool->pTail;
646,418,328✔
139
    pNode->pnext = &pPool->pTail;
646,418,328✔
140
    pPool->pTail->pnext = &pNode->prev;
646,418,328✔
141
    pPool->pTail = pNode;
646,418,328✔
142

143
    pPool->size = pPool->size + sizeof(*pNode) + size;
646,418,328✔
144
  }
145
  return p;
2,147,483,647✔
146
}
147

148
void *vnodeBufPoolMalloc(SVBufPool *pPool, int size) {
9,537,914✔
149
  SVBufPoolNode *pNode;
150
  void          *p = NULL;
9,537,914✔
151

152
  if (pPool == NULL) {
9,537,914!
153
    terrno = TSDB_CODE_INVALID_PARA;
×
154
    return NULL;
×
155
  }
156

157
  if (pPool->node.size >= pPool->ptr - pPool->node.data + size) {
9,537,914!
158
    // allocate from the anchor node
159
    p = pPool->ptr;
9,537,838✔
160
    pPool->ptr = pPool->ptr + size;
9,537,838✔
161
    pPool->size += size;
9,537,876✔
162
  } else {
163
    // allocate a new node
164
    pNode = taosMemoryMalloc(sizeof(*pNode) + size);
×
165
    if (pNode == NULL) {
×
166
      return NULL;
×
167
    }
168
    pNode->data = (uint8_t *)&pNode[1];
×
169

170
    p = pNode->data;
×
171
    pNode->size = size;
×
172
    pNode->prev = pPool->pTail;
×
173
    pNode->pnext = &pPool->pTail;
×
174
    pPool->pTail->pnext = &pNode->prev;
×
175
    pPool->pTail = pNode;
×
176

177
    pPool->size = pPool->size + sizeof(*pNode) + size;
×
178
  }
179
  return p;
9,537,838✔
180
}
181

182
void vnodeBufPoolFree(SVBufPool *pPool, void *p) {
112,943,948✔
183
  // uint8_t       *ptr = (uint8_t *)p;
184
  // SVBufPoolNode *pNode;
185

186
  // if (ptr < pPool->node.data || ptr >= pPool->node.data + pPool->node.size) {
187
  //   pNode = &((SVBufPoolNode *)p)[-1];
188
  //   *pNode->pnext = pNode->prev;
189
  //   pNode->prev->pnext = pNode->pnext;
190

191
  //   pPool->size = pPool->size - sizeof(*pNode) - pNode->size;
192
  //   taosMemoryFree(pNode);
193
  // }
194
}
112,943,948✔
195

196
void vnodeBufPoolRef(SVBufPool *pPool) {
10,386,411✔
197
  int32_t nRef = atomic_fetch_add_32(&pPool->nRef, 1);
10,386,411✔
198
  if (nRef <= 0) {
10,384,760!
199
    vError("vgId:%d, buffer pool %p of id %d is referenced by %d", TD_VID(pPool->pVnode), pPool, pPool->id, nRef);
×
200
  }
201
}
10,384,760✔
202

203
static void vnodeBufPoolResize(SVBufPool *pPool, int64_t size) {
×
204
  if (pPool == NULL) return;
×
205

206
  uint8_t *pDataNew = taosMemoryMalloc(size);
×
207
  if (pDataNew == NULL) {
×
208
    vError("vgId:%d, %s failed at %s:%d since %s", TD_VID(pPool->pVnode), __func__, __FILE__, __LINE__,
×
209
           tstrerror(terrno));
210
    return;
×
211
  }
212

213
  // Apply change
214
  int64_t oldSize = pPool->node.size;
×
215
  taosMemoryFree(pPool->node.data);
×
216
  pPool->node.data = pDataNew;
×
217
  pPool->node.size = size;
×
218

219
  vInfo("vgId:%d, buffer pool %d resized from %" PRId64 " to %" PRId64, TD_VID(pPool->pVnode), pPool->id, oldSize,
×
220
        size);
221
  return;
×
222
}
223

224
void vnodeBufPoolAddToFreeList(SVBufPool *pPool) {
6,332,780✔
225
  SVnode *pVnode = pPool->pVnode;
6,332,780✔
226

227
  int64_t size = pVnode->config.szBuf / VNODE_BUFPOOL_SEGMENTS;
6,332,780✔
228
  if (pPool->node.size != size) {
6,332,780!
229
    vnodeBufPoolResize(pPool, size);
×
230
  }
231

232
  // add to free list
233
  vDebug("vgId:%d, buffer pool %p of id %d is added to free list", TD_VID(pVnode), pPool, pPool->id);
6,332,780✔
234
  vnodeBufPoolReset(pPool);
6,332,780✔
235
  pPool->freeNext = pVnode->freeList;
6,332,780✔
236
  pVnode->freeList = pPool;
6,332,780✔
237
  (void)taosThreadCondSignal(&pVnode->poolNotEmpty);
6,332,780✔
238
}
6,332,780✔
239

240
void vnodeBufPoolUnRef(SVBufPool *pPool, bool proactive) {
10,383,906✔
241
  if (pPool == NULL) return;
10,383,906!
242

243
  SVnode *pVnode = pPool->pVnode;
10,383,906✔
244

245
  if (proactive) {
10,387,857✔
246
    (void)taosThreadMutexLock(&pVnode->mutex);
10,386,786✔
247
  }
248

249
  if (atomic_sub_fetch_32(&pPool->nRef, 1) > 0) goto _exit;
10,387,379✔
250

251
  // remove from recycle queue or on-recycle position
252
  if (pVnode->onRecycle == pPool) {
47,700✔
253
    pVnode->onRecycle = NULL;
698✔
254
  } else {
255
    if (pPool->recyclePrev) {
47,002✔
256
      pPool->recyclePrev->recycleNext = pPool->recycleNext;
349✔
257
    } else {
258
      pVnode->recycleHead = pPool->recycleNext;
46,653✔
259
    }
260

261
    if (pPool->recycleNext) {
47,002!
UNCOV
262
      pPool->recycleNext->recyclePrev = pPool->recyclePrev;
×
263
    } else {
264
      pVnode->recycleTail = pPool->recyclePrev;
47,002✔
265
    }
266
    pPool->recyclePrev = pPool->recycleNext = NULL;
47,002✔
267
  }
268

269
  vnodeBufPoolAddToFreeList(pPool);
47,700✔
270

271
_exit:
10,387,528✔
272
  if (proactive) {
10,387,528✔
273
    (void)taosThreadMutexUnlock(&pVnode->mutex);
10,386,192✔
274
  }
275
  return;
10,387,860✔
276
}
277

278
void vnodeBufPoolRegisterQuery(SVBufPool *pPool, SQueryNode *pQNode) {
148,105,523✔
279
  (void)taosThreadMutexLock(&pPool->mutex);
148,105,523✔
280

281
  pQNode->pNext = pPool->qList.pNext;
148,146,896✔
282
  pQNode->ppNext = &pPool->qList.pNext;
148,151,989✔
283
  pPool->qList.pNext->ppNext = &pQNode->pNext;
148,139,968✔
284
  pPool->qList.pNext = pQNode;
148,137,101✔
285
  pPool->nQuery++;
148,070,241✔
286

287
  (void)taosThreadMutexUnlock(&pPool->mutex);
148,127,349✔
288
}
148,094,739✔
289

290
void vnodeBufPoolDeregisterQuery(SVBufPool *pPool, SQueryNode *pQNode, bool proactive) {
148,140,643✔
291
  int32_t code = 0;
148,140,643✔
292

293
  if (proactive) {
148,140,643!
294
    (void)taosThreadMutexLock(&pPool->mutex);
148,147,124✔
295
  }
296

297
  pQNode->pNext->ppNext = pQNode->ppNext;
148,147,882✔
298
  *pQNode->ppNext = pQNode->pNext;
148,153,498✔
299
  pPool->nQuery--;
148,145,613✔
300

301
  if (proactive) {
148,153,237✔
302
    (void)taosThreadMutexUnlock(&pPool->mutex);
148,154,058✔
303
  }
304
}
148,141,013✔
305

306
int32_t vnodeBufPoolRecycle(SVBufPool *pPool) {
698✔
307
  int32_t code = 0;
698✔
308

309
  SVnode *pVnode = pPool->pVnode;
698✔
310

311
  vDebug("vgId:%d, recycle buffer pool %p of id %d", TD_VID(pVnode), pPool, pPool->id);
698!
312

313
  (void)taosThreadMutexLock(&pPool->mutex);
698✔
314

315
  SQueryNode *pNode = pPool->qList.pNext;
698✔
316
  while (pNode != &pPool->qList) {
1,396✔
317
    SQueryNode *pTNode = pNode->pNext;
698✔
318

319
    int32_t rc = pNode->reseek(pNode->pQHandle);
698✔
320
    if (rc == 0 || rc == TSDB_CODE_VND_QUERY_BUSY) {
698!
321
      pNode = pTNode;
698✔
322
    } else {
323
      code = rc;
×
324
      goto _exit;
×
325
    }
326
  }
327

328
_exit:
698✔
329
  (void)taosThreadMutexUnlock(&pPool->mutex);
698✔
330
  return code;
698✔
331
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc