• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4808

16 Oct 2025 11:40AM UTC coverage: 57.938% (-0.6%) from 58.524%
#4808

push

travis-ci

web-flow
fix(tref): increase TSDB_REF_OBJECTS from 100 to 2000 for improved reference handling (#33281)

137662 of 303532 branches covered (45.35%)

Branch coverage included in aggregate %.

209234 of 295200 relevant lines covered (70.88%)

4035326.15 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

48.38
/source/libs/executor/src/filloperator.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "filter.h"
17
#include "os.h"
18
#include "query.h"
19
#include "taosdef.h"
20
#include "taoserror.h"
21
#include "tmsg.h"
22
#include "ttypes.h"
23

24
#include "executorInt.h"
25
#include "tcommon.h"
26
#include "thash.h"
27
#include "ttime.h"
28

29
#include "function.h"
30
#include "operator.h"
31
#include "querynodes.h"
32
#include "querytask.h"
33
#include "tdatablock.h"
34
#include "tfill.h"
35

36
typedef struct STimeRange {
37
  TSKEY    skey;
38
  TSKEY    ekey;
39
  uint64_t groupId;
40
} STimeRange;
41

42
typedef struct SFillOperatorInfo {
43
  struct SFillInfo* pFillInfo;
44
  SSDataBlock*      pRes;
45
  SSDataBlock*      pFinalRes;
46
  int64_t           totalInputRows;
47
  void**            p;
48
  SSDataBlock*      existNewGroupBlock;
49
  STimeWindow       win;
50
  SColMatchInfo     matchInfo;
51
  int32_t           primaryTsCol;
52
  int32_t           primarySrcSlotId;
53
  uint64_t          curGroupId;  // current handled group id
54
  SExprInfo*        pExprInfo;
55
  int32_t           numOfExpr;
56
  SExprSupp         noFillExprSupp;
57
  SExprSupp         fillNullExprSupp;
58
  SList*            pFillSavedBlockList;
59
  SNode*            pTimeRange;  // STimeRangeNode for stream fill
60
} SFillOperatorInfo;
61

62
static void destroyFillOperatorInfo(void* param);
63
static void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag);
64
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo);
65
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order);
66

67
static void doHandleRemainBlockForNewGroupImpl(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
864✔
68
                                               SResultInfo* pResultInfo, int32_t order) {
69
  pInfo->totalInputRows = pInfo->existNewGroupBlock->info.rows;
864✔
70
  SSDataBlock*   pResBlock = pInfo->pFinalRes;
864✔
71
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
864✔
72

73
  //  int32_t order = TSDB_ORDER_ASC;
74
  int32_t scanFlag = MAIN_SCAN;
864✔
75
  //  getTableScanInfo(pOperator, &order, &scanFlag, false);
76
  taosResetFillInfo(pInfo->pFillInfo, getFillInfoStart(pInfo->pFillInfo));
864✔
77

78
  blockDataCleanup(pInfo->pRes);
864✔
79
  doApplyScalarCalculation(pOperator, pInfo->existNewGroupBlock, order, scanFlag);
864✔
80

81
  reviseFillStartAndEndKey(pOperator->info, order);
864✔
82

83
  int64_t ts = (order == TSDB_ORDER_ASC) ? pInfo->existNewGroupBlock->info.window.ekey
1,728✔
84
                                         : pInfo->existNewGroupBlock->info.window.skey;
864!
85
  taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
864✔
86

87
  taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
864✔
88
  if (pInfo->pFillInfo->type == TSDB_FILL_PREV || pInfo->pFillInfo->type == TSDB_FILL_LINEAR) {
864✔
89
    int32_t code = fillResetPrevForNewGroup(pInfo->pFillInfo);
219✔
90
    if (code != TSDB_CODE_SUCCESS) {
219!
91
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
92
      T_LONG_JMP(pTaskInfo->env, code);
×
93
    }
94
  }
95

96
  int32_t numOfResultRows = pResultInfo->capacity - pResBlock->info.rows;
864✔
97
  int32_t code = taosFillResultDataBlock2(pInfo->pFillInfo, pResBlock, numOfResultRows, NULL);
864✔
98
  if (code != TSDB_CODE_SUCCESS) {
864!
99
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
100
    T_LONG_JMP(pTaskInfo->env, code);
×
101
  }
102

103
  pInfo->curGroupId = pInfo->existNewGroupBlock->info.id.groupId;
864✔
104
  pInfo->existNewGroupBlock = NULL;
864✔
105
}
864✔
106

107
static void doHandleRemainBlockFromNewGroup(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
3,837✔
108
                                            SResultInfo* pResultInfo, int32_t order) {
109
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
3,837✔
110
  if (taosFillHasMoreResults(pInfo->pFillInfo)) {
3,837✔
111
    int32_t numOfResultRows = pResultInfo->capacity - pInfo->pFinalRes->info.rows;
1,429✔
112
    int32_t code = taosFillResultDataBlock2(pInfo->pFillInfo, pInfo->pFinalRes, numOfResultRows, NULL);
1,429✔
113
    if (code != TSDB_CODE_SUCCESS) {
1,429!
114
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
115
      T_LONG_JMP(pTaskInfo->env, code);
×
116
    }
117
    pInfo->pRes->info.id.groupId = pInfo->curGroupId;
1,429✔
118
    return;
1,429✔
119
  }
120

121
  // handle the cached new group data block
122
  if (pInfo->existNewGroupBlock) {
2,408✔
123
    doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
864✔
124
  }
125
}
126

127
void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag) {
3,354✔
128
  int32_t            code = TSDB_CODE_SUCCESS;
3,354✔
129
  int32_t            lino = 0;
3,354✔
130
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
3,354✔
131
  SFillOperatorInfo* pInfo = pOperator->info;
3,354✔
132
  SExprSupp*         pSup = &pOperator->exprSupp;
3,354✔
133
  code = setInputDataBlock(pSup, pBlock, order, scanFlag, false);
3,354✔
134
  QUERY_CHECK_CODE(code, lino, _end);
3,354!
135
  code = projectApplyFunctions(pSup->pExprInfo, pInfo->pRes, pBlock, pSup->pCtx, pSup->numOfExprs, NULL, GET_STM_RTINFO(pOperator->pTaskInfo));
3,354!
136
  QUERY_CHECK_CODE(code, lino, _end);
3,354!
137

138
  // reset the row value before applying the no-fill functions to the input data block, which is "pBlock" in this case.
139
  pInfo->pRes->info.rows = 0;
3,354✔
140
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
3,354✔
141
  code = setInputDataBlock(pNoFillSupp, pBlock, order, scanFlag, false);
3,354✔
142
  QUERY_CHECK_CODE(code, lino, _end);
3,354!
143

144
  code = projectApplyFunctions(pNoFillSupp->pExprInfo, pInfo->pRes, pBlock, pNoFillSupp->pCtx, pNoFillSupp->numOfExprs,
3,354✔
145
                               NULL, GET_STM_RTINFO(pOperator->pTaskInfo));
3,354!
146
  QUERY_CHECK_CODE(code, lino, _end);
3,354!
147

148
  if (pInfo->fillNullExprSupp.pExprInfo) {
3,354✔
149
    pInfo->pRes->info.rows = 0;
1✔
150
    code = setInputDataBlock(&pInfo->fillNullExprSupp, pBlock, order, scanFlag, false);
1✔
151
    QUERY_CHECK_CODE(code, lino, _end);
1!
152
    code = projectApplyFunctions(pInfo->fillNullExprSupp.pExprInfo, pInfo->pRes, pBlock, pInfo->fillNullExprSupp.pCtx,
1✔
153
        pInfo->fillNullExprSupp.numOfExprs, NULL, GET_STM_RTINFO(pOperator->pTaskInfo));
1!
154
  }
155

156
  pInfo->pRes->info.id.groupId = pBlock->info.id.groupId;
3,354✔
157

158
_end:
3,354✔
159
  if (code != TSDB_CODE_SUCCESS) {
3,354!
160
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
161
    T_LONG_JMP(pTaskInfo->env, code);
×
162
  }
163
}
3,354✔
164

165
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo) {
219✔
166
  int32_t code = TSDB_CODE_SUCCESS;
219✔
167
  int32_t lino = 0;
219✔
168
  for (int32_t colIdx = 0; colIdx < pFillInfo->numOfCols; ++colIdx) {
1,835✔
169
    if (!pFillInfo->pFillCol[colIdx].notFillCol) {
1,616✔
170
      SGroupKeys* key = taosArrayGet(pFillInfo->prev.pRowVal, colIdx);
1,245✔
171
      QUERY_CHECK_NULL(key, code, lino, _end, terrno);
1,245!
172
      key->isNull = true;
1,245✔
173
    }
174
  }
175

176
_end:
219✔
177
  if (code != TSDB_CODE_SUCCESS) {
219!
178
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
179
  }
180
  return code;
219✔
181
}
182

183
static SSDataBlock* doFillImpl2(SOperatorInfo* pOperator) {
3,837✔
184
  int32_t            code = TSDB_CODE_SUCCESS;
3,837✔
185
  int32_t            lino = 0;
3,837✔
186
  SFillOperatorInfo* pInfo = pOperator->info;
3,837✔
187
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
3,837✔
188
  if (pInfo == NULL || pTaskInfo == NULL) {
3,837!
189
    qError("%s failed at line %d since pInfo or pTaskInfo is NULL.", __func__, __LINE__);
×
190
    return NULL;
×
191
  }
192

193
  SResultInfo* pResultInfo = &pOperator->resultInfo;
3,837✔
194
  SSDataBlock* pResBlock = pInfo->pFinalRes;
3,837✔
195
  if (pResBlock == NULL) {
3,837!
196
    qError("%s failed at line %d since pResBlock is NULL.", __func__, __LINE__);
×
197
    return NULL;
×
198
  }
199
  blockDataCleanup(pResBlock);
3,837✔
200
  int32_t        order = pInfo->pFillInfo->order;
3,837✔
201
  SOperatorInfo* pDownstream = pOperator->pDownstream[0];
3,837✔
202

203
  doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
3,837✔
204
  if (pResBlock->info.rows > 0) {
3,837✔
205
    pResBlock->info.id.groupId = pInfo->curGroupId;
1,161✔
206
    return pResBlock;
1,161✔
207
  }
208

209
  while (1) {
1,335✔
210
    SSDataBlock* pBlock = getNextBlockFromDownstream(pOperator, 0);
4,011✔
211
    if (pBlock == NULL) {
4,011✔
212
      if (pInfo->totalInputRows == 0 &&
1,521✔
213
          (pInfo->pFillInfo->type != TSDB_FILL_NULL_F && pInfo->pFillInfo->type != TSDB_FILL_SET_VALUE_F)) {
407✔
214
        setOperatorCompleted(pOperator);
295✔
215
        return NULL;
2,676✔
216
      } else if (pInfo->totalInputRows == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
1,226✔
217
        reviseFillStartAndEndKey(pInfo, order);
56✔
218
      }
219

220
      taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
1,226✔
221
    } else {
222
      pResBlock->info.scanFlag = pBlock->info.scanFlag;
2,490✔
223
      pBlock->info.dataLoad = 1;
2,490✔
224
      code = blockDataUpdateTsWindow(pBlock, pInfo->primarySrcSlotId);
2,490✔
225
      QUERY_CHECK_CODE(code, lino, _end);
2,490!
226

227
      blockDataCleanup(pInfo->pRes);
2,490✔
228
      code = blockDataEnsureCapacity(pInfo->pRes, pBlock->info.rows);
2,490✔
229
      QUERY_CHECK_CODE(code, lino, _end);
2,490!
230
      code = blockDataEnsureCapacity(pInfo->pFinalRes, pBlock->info.rows);
2,490✔
231
      QUERY_CHECK_CODE(code, lino, _end);
2,490!
232
      doApplyScalarCalculation(pOperator, pBlock, order, pBlock->info.scanFlag);
2,490✔
233

234
      if (pInfo->curGroupId == 0 || (pInfo->curGroupId == pInfo->pRes->info.id.groupId)) {
4,116✔
235
        if (pInfo->curGroupId == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
1,626✔
236
          reviseFillStartAndEndKey(pInfo, order);
585✔
237
        }
238

239
        pInfo->curGroupId = pInfo->pRes->info.id.groupId;  // the first data block
1,626✔
240
        pInfo->totalInputRows += pInfo->pRes->info.rows;
1,626✔
241

242
        int64_t ts = (order == TSDB_ORDER_ASC) ? pBlock->info.window.ekey : pBlock->info.window.skey;
1,626✔
243
        taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
1,626✔
244
        taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
1,626✔
245
      } else if (pInfo->curGroupId != pBlock->info.id.groupId) {  // the new group data block
864!
246
        pInfo->existNewGroupBlock = pBlock;
864✔
247

248
        // Fill the previous group data block, before handle the data block of new group.
249
        // Close the fill operation for previous group data block
250
        taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
864✔
251
        pInfo->pFillInfo->prev.key = 0;
864✔
252
      }
253
    }
254

255
    int32_t numOfResultRows = pOperator->resultInfo.capacity - pResBlock->info.rows;
3,716✔
256
    bool wantMoreBlock = false;
3,716✔
257
    code = taosFillResultDataBlock2(pInfo->pFillInfo, pResBlock, numOfResultRows, &wantMoreBlock);
3,716✔
258
    QUERY_CHECK_CODE(code, lino, _end);
3,716!
259

260
    // current group has no more result to return
261
    if (pResBlock->info.rows > 0) {
3,716✔
262
      // 1. The result in current group not reach the threshold of output result, continue
263
      // 2. If multiple group results existing in one SSDataBlock is not allowed, return immediately
264
      if (pResBlock->info.rows > pResultInfo->threshold || pBlock == NULL || pInfo->existNewGroupBlock != NULL) {
1,773!
265
        pResBlock->info.id.groupId = pInfo->curGroupId;
1,773✔
266
        return pResBlock;
1,773✔
267
      }
268

269
      doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
×
270
      if (pResBlock->info.rows >= pOperator->resultInfo.threshold || pBlock == NULL) {
×
271
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
272
        return pResBlock;
×
273
      }
274
    } else if (pInfo->existNewGroupBlock) {  // try next group
1,943!
275
      blockDataCleanup(pResBlock);
×
276

277
      doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
×
278
      if (pResBlock->info.rows > pResultInfo->threshold) {
×
279
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
280
        return pResBlock;
×
281
      }
282
    } else {
283
      if (wantMoreBlock) continue;
1,943✔
284
      return NULL;
608✔
285
    }
286
  }
287

288
_end:
×
289
  if (code != TSDB_CODE_SUCCESS) {
×
290
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
291
    T_LONG_JMP(pTaskInfo->env, code);
×
292
  }
293
  return NULL;
×
294
}
295

296
static SSDataBlock* doFillImpl(SOperatorInfo* pOperator) {
×
297
  int32_t            code = TSDB_CODE_SUCCESS;
×
298
  int32_t            lino = 0;
×
299
  SFillOperatorInfo* pInfo = pOperator->info;
×
300
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
×
301
  if (pInfo == NULL || pTaskInfo == NULL) {
×
302
    qError("%s failed at line %d since pInfo or pTaskInfo is NULL.", __func__, __LINE__);
×
303
    return NULL;
×
304
  }
305

306
  SResultInfo* pResultInfo = &pOperator->resultInfo;
×
307
  SSDataBlock* pResBlock = pInfo->pFinalRes;
×
308
  if (pResBlock == NULL) {
×
309
    qError("%s failed at line %d since pResBlock is NULL.", __func__, __LINE__);
×
310
    return NULL;
×
311
  }
312

313
  blockDataCleanup(pResBlock);
×
314

315
  int32_t order = pInfo->pFillInfo->order;
×
316

317
  SOperatorInfo* pDownstream = pOperator->pDownstream[0];
×
318
#if 0
319
  // the scan order may be different from the output result order for agg interval operator.
320
  if (pDownstream->operatorType == QUERY_NODE_PHYSICAL_PLAN_HASH_INTERVAL) {
321
    order = ((SIntervalAggOperatorInfo*) pDownstream->info)->resultTsOrder;
322
  } else {
323
    order = pInfo->pFillInfo->order;
324
  }
325
#endif
326

327
  doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
×
328
  if (pResBlock->info.rows > 0) {
×
329
    pResBlock->info.id.groupId = pInfo->curGroupId;
×
330
    return pResBlock;
×
331
  }
332

333
  while (1) {
×
334
    SSDataBlock* pBlock = getNextBlockFromDownstream(pOperator, 0);
×
335
    if (pBlock == NULL) {
×
336
      if (pInfo->totalInputRows == 0 &&
×
337
          (pInfo->pFillInfo->type != TSDB_FILL_NULL_F && pInfo->pFillInfo->type != TSDB_FILL_SET_VALUE_F)) {
×
338
        setOperatorCompleted(pOperator);
×
339
        return NULL;
×
340
      } else if (pInfo->totalInputRows == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
×
341
        reviseFillStartAndEndKey(pInfo, order);
×
342
      }
343

344
      taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
×
345
    } else {
346
      pResBlock->info.scanFlag = pBlock->info.scanFlag;
×
347
      pBlock->info.dataLoad = 1;
×
348
      code = blockDataUpdateTsWindow(pBlock, pInfo->primarySrcSlotId);
×
349
      QUERY_CHECK_CODE(code, lino, _end);
×
350

351
      blockDataCleanup(pInfo->pRes);
×
352
      code = blockDataEnsureCapacity(pInfo->pRes, pBlock->info.rows);
×
353
      QUERY_CHECK_CODE(code, lino, _end);
×
354
      code = blockDataEnsureCapacity(pInfo->pFinalRes, pBlock->info.rows);
×
355
      QUERY_CHECK_CODE(code, lino, _end);
×
356
      doApplyScalarCalculation(pOperator, pBlock, order, pBlock->info.scanFlag);
×
357

358
      if (pInfo->curGroupId == 0 || (pInfo->curGroupId == pInfo->pRes->info.id.groupId)) {
×
359
        if (pInfo->curGroupId == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
×
360
          reviseFillStartAndEndKey(pInfo, order);
×
361
        }
362

363
        pInfo->curGroupId = pInfo->pRes->info.id.groupId;  // the first data block
×
364
        pInfo->totalInputRows += pInfo->pRes->info.rows;
×
365

366
        int64_t ts = (order == TSDB_ORDER_ASC) ? pBlock->info.window.ekey : pBlock->info.window.skey;
×
367
        taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
×
368
        taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
×
369
      } else if (pInfo->curGroupId != pBlock->info.id.groupId) {  // the new group data block
×
370
        pInfo->existNewGroupBlock = pBlock;
×
371

372
        // Fill the previous group data block, before handle the data block of new group.
373
        // Close the fill operation for previous group data block
374
        taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
×
375
        pInfo->pFillInfo->prev.key = 0;
×
376
      }
377
    }
378

379
    int32_t numOfResultRows = pOperator->resultInfo.capacity - pResBlock->info.rows;
×
380
    code = taosFillResultDataBlock(pInfo->pFillInfo, pResBlock, numOfResultRows);
×
381
    QUERY_CHECK_CODE(code, lino, _end);
×
382

383
    // current group has no more result to return
384
    if (pResBlock->info.rows > 0) {
×
385
      // 1. The result in current group not reach the threshold of output result, continue
386
      // 2. If multiple group results existing in one SSDataBlock is not allowed, return immediately
387
      if (pResBlock->info.rows > pResultInfo->threshold || pBlock == NULL || pInfo->existNewGroupBlock != NULL) {
×
388
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
389
        return pResBlock;
×
390
      }
391

392
      doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
×
393
      if (pResBlock->info.rows >= pOperator->resultInfo.threshold || pBlock == NULL) {
×
394
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
395
        return pResBlock;
×
396
      }
397
    } else if (pInfo->existNewGroupBlock) {  // try next group
×
398
      blockDataCleanup(pResBlock);
×
399

400
      doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
×
401
      if (pResBlock->info.rows > pResultInfo->threshold) {
×
402
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
403
        return pResBlock;
×
404
      }
405
    } else {
406
      return NULL;
×
407
    }
408
  }
409

410
_end:
×
411
  if (code != TSDB_CODE_SUCCESS) {
×
412
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
413
    T_LONG_JMP(pTaskInfo->env, code);
×
414
  }
415
  return NULL;
×
416
}
417

418
static int32_t doFillNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
3,837✔
419
  int32_t            code = TSDB_CODE_SUCCESS;
3,837✔
420
  SFillOperatorInfo* pInfo = pOperator->info;
3,837✔
421
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
3,837✔
422

423
  if (pInfo->pTimeRange != NULL) {
3,837!
424
    STimeWindow pWinRange = {0};
×
425
    bool        isWinRangeValid = false;
×
426
    code = streamCalcCurrWinTimeRange((STimeRangeNode*)pInfo->pTimeRange, &pTaskInfo->pStreamRuntimeInfo->funcInfo, &pWinRange,
×
427
                  &isWinRangeValid, 3);
428
    if (code != TSDB_CODE_SUCCESS) {
×
429
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
430
      pTaskInfo->code = code;
×
431
      T_LONG_JMP(pTaskInfo->env, code);
×
432
    }
433
    
434
    if (isWinRangeValid) {
×
435
      pInfo->win.skey = pWinRange.skey;
×
436
      pInfo->win.ekey = pWinRange.ekey;
×
437
      if (pTaskInfo->pStreamRuntimeInfo->funcInfo.triggerType == STREAM_TRIGGER_SLIDING) {
×
438
        pInfo->win.ekey--;
×
439
      }
440
    }
441
  }
442

443
  if (pOperator->status == OP_EXEC_DONE) {
3,837!
444
    (*ppRes) = NULL;
×
445
    return code;
×
446
  }
447

448
  SSDataBlock* fillResult = NULL;
3,837✔
449
  while (true) {
450
    fillResult = doFillImpl2(pOperator);
3,837✔
451
    if (fillResult == NULL) {
3,837✔
452
      setOperatorCompleted(pOperator);
903✔
453
      break;
903✔
454
    }
455

456
    code = doFilter(fillResult, pOperator->exprSupp.pFilterInfo, &pInfo->matchInfo, NULL);
2,934✔
457
    if (code != TSDB_CODE_SUCCESS) {
2,934!
458
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
459
      pTaskInfo->code = code;
×
460
      T_LONG_JMP(pTaskInfo->env, code);
×
461
    }
462
    if (fillResult->info.rows > 0) {
2,934!
463
      break;
2,934✔
464
    }
465
  }
466

467
  if (fillResult != NULL) {
3,837✔
468
    pOperator->resultInfo.totalRows += fillResult->info.rows;
2,934✔
469
  }
470

471
  (*ppRes) = fillResult;
3,837✔
472
  return code;
3,837✔
473
}
474

475
void destroyFillOperatorInfo(void* param) {
936✔
476
  SFillOperatorInfo* pInfo = (SFillOperatorInfo*)param;
936✔
477
  pInfo->pFillInfo = taosDestroyFillInfo(pInfo->pFillInfo);
936✔
478
  blockDataDestroy(pInfo->pRes);
936✔
479
  pInfo->pRes = NULL;
936✔
480
  blockDataDestroy(pInfo->pFinalRes);
936✔
481
  pInfo->pFinalRes = NULL;
936✔
482

483
  cleanupExprSupp(&pInfo->noFillExprSupp);
936✔
484
  cleanupExprSupp(&pInfo->fillNullExprSupp);
936✔
485

486
  taosMemoryFreeClear(pInfo->p);
936!
487
  taosArrayDestroy(pInfo->matchInfo.pList);
936✔
488
  taosMemoryFreeClear(param);
936!
489
}
936✔
490

491
static int32_t initFillInfo(SFillOperatorInfo* pInfo, SExprInfo* pExpr, int32_t numOfCols, SExprInfo* pNotFillExpr,
936✔
492
                            int32_t numOfNotFillCols, SExprInfo* pFillNullExpr, int32_t numOfFillNullExprs,
493
                            SNodeListNode* pValNode, STimeWindow win, int32_t capacity, const char* id,
494
                            SInterval* pInterval, int32_t fillType, int32_t order, SExecTaskInfo* pTaskInfo) {
495
  SFillColInfo* pColInfo =
496
      createFillColInfo(pExpr, numOfCols, pNotFillExpr, numOfNotFillCols, pFillNullExpr, numOfFillNullExprs, pValNode);
936✔
497
  if (!pColInfo) {
936!
498
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno));
×
499
    return terrno;
×
500
  }
501

502
  int64_t startKey = (order == TSDB_ORDER_ASC) ? win.skey : win.ekey;
936✔
503

504
  //  STimeWindow w = {0};
505
  //  getInitialStartTimeWindow(pInterval, startKey, &w, order == TSDB_ORDER_ASC);
506
  pInfo->pFillInfo = NULL;
936✔
507
  int32_t code = taosCreateFillInfo(startKey, numOfCols, numOfNotFillCols, numOfFillNullExprs, capacity, pInterval,
936✔
508
                                    fillType, pColInfo, pInfo->primaryTsCol, order, id, pTaskInfo, &pInfo->pFillInfo);
936✔
509
  if (code != TSDB_CODE_SUCCESS) {
936!
510
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
511
    return code;
×
512
  }
513

514
  if (order == TSDB_ORDER_ASC) {
936✔
515
    pInfo->win.skey = win.skey;
775✔
516
    pInfo->win.ekey = win.ekey;
775✔
517
  } else {
518
    pInfo->win.skey = win.ekey;
161✔
519
    pInfo->win.ekey = win.skey;
161✔
520
  }
521
  pInfo->p = taosMemoryCalloc(numOfCols, POINTER_BYTES);
936!
522
  if (!pInfo->p) {
936!
523
    return terrno;
×
524
  }
525

526
  if (pInfo->pFillInfo == NULL) {
936!
527
    taosMemoryFree(pInfo->pFillInfo);
×
528
    taosMemoryFree(pInfo->p);
×
529
    return TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
×
530
  } else {
531
    return TSDB_CODE_SUCCESS;
936✔
532
  }
533
}
534

535
static bool isWstartColumnExist(SFillOperatorInfo* pInfo) {
936✔
536
  if (pInfo->noFillExprSupp.numOfExprs == 0) {
936✔
537
    return false;
156✔
538
  }
539

540
  for (int32_t i = 0; i < pInfo->noFillExprSupp.numOfExprs; ++i) {
1,172✔
541
    SExprInfo* exprInfo = pInfo->noFillExprSupp.pExprInfo + i;
1,115✔
542
    if (exprInfo->pExpr->nodeType == QUERY_NODE_COLUMN && exprInfo->base.numOfParams == 1 &&
1,115!
543
        exprInfo->base.pParam[0].pCol->colType == COLUMN_TYPE_WINDOW_START) {
1,114✔
544
      return true;
723✔
545
    }
546
  }
547
  return false;
57✔
548
}
549

550
static int32_t createPrimaryTsExprIfNeeded(SFillOperatorInfo* pInfo, SFillPhysiNode* pPhyFillNode, SExprSupp* pExprSupp,
936✔
551
                                           const char* idStr) {
552
  bool wstartExist = isWstartColumnExist(pInfo);
936✔
553

554
  if (wstartExist == false) {
936✔
555
    if (pPhyFillNode->pWStartTs->type != QUERY_NODE_TARGET) {
213!
556
      qError("pWStartTs of fill physical node is not a target node, %s", idStr);
×
557
      return TSDB_CODE_QRY_SYS_ERROR;
×
558
    }
559

560
    SExprInfo* pExpr = taosMemoryRealloc(pExprSupp->pExprInfo, (pExprSupp->numOfExprs + 1) * sizeof(SExprInfo));
213!
561
    if (pExpr == NULL) {
213!
562
      return terrno;
×
563
    }
564

565
    int32_t code = createExprFromTargetNode(&pExpr[pExprSupp->numOfExprs], (STargetNode*)pPhyFillNode->pWStartTs);
213✔
566
    if (code != TSDB_CODE_SUCCESS) {
213!
567
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
568
      pExprSupp->numOfExprs += 1;
×
569
      pExprSupp->pExprInfo = pExpr;
×
570
      return code;
×
571
    }
572

573
    pExprSupp->numOfExprs += 1;
213✔
574
    pExprSupp->pExprInfo = pExpr;
213✔
575
  }
576

577
  return TSDB_CODE_SUCCESS;
936✔
578
}
579

580
static int32_t resetFillOperState(SOperatorInfo* pOper) {
×
581
  SFillOperatorInfo* pFill = pOper->info;
×
582
  SExecTaskInfo*           pTaskInfo = pOper->pTaskInfo;
×
583
  pOper->status = OP_NOT_OPENED;
×
584
  SFillPhysiNode* pPhyNode = (SFillPhysiNode*)pOper->pPhyNode;
×
585

586
  pFill->curGroupId = 0;
×
587
  pFill->totalInputRows = 0;
×
588
  blockDataCleanup(pFill->pRes);
×
589
  blockDataCleanup(pFill->pFinalRes);
×
590

591
  int64_t startKey = (pFill->pFillInfo->order == TSDB_ORDER_ASC) ? pPhyNode->timeRange.skey : pPhyNode->timeRange.ekey;
×
592
  pFill->pFillInfo->start = startKey;
×
593
  pFill->pFillInfo->currentKey = startKey;
×
594
  pFill->pFillInfo->end = startKey;
×
595

596
  pFill->pFillInfo->numOfRows = 0;
×
597
  pFill->pFillInfo->index = -1;
×
598
  pFill->pFillInfo->numOfTotal = 0;
×
599
  pFill->pFillInfo->numOfCurrent = 0;
×
600
  pFill->pFillInfo->isFilled = false;
×
601
  pFill->pFillInfo->prev.key = 0;
×
602
  pFill->pFillInfo->next.key = 0;
×
603
  int32_t size = taosArrayGetSize(pFill->pFillInfo->prev.pRowVal);
×
604
  for (int32_t i = 0; i < size; ++i) {
×
605
    SGroupKeys* pKey = taosArrayGet(pFill->pFillInfo->prev.pRowVal, i);
×
606
    pKey->isNull = true;
×
607
  }
608
  size = taosArrayGetSize(pFill->pFillInfo->next.pRowVal);
×
609
  for (int32_t i = 0; i < size; ++i) {
×
610
    SGroupKeys* pKey = taosArrayGet(pFill->pFillInfo->next.pRowVal, i);
×
611
    pKey->isNull = true;
×
612
  }
613

614
  taosMemoryFreeClear(pFill->pFillInfo->pTags);
×
615
  taosArrayDestroy(pFill->pFillInfo->pColFillProgress);
×
616
  pFill->pFillInfo->pColFillProgress = NULL;
×
617

618
  tdListFreeP(pFill->pFillInfo->pFillSavedBlockList, destroyFillBlock);
×
619
  pFill->pFillInfo->pFillSavedBlockList = NULL;
×
620

621
  int32_t order = (pPhyNode->node.inputTsOrder == ORDER_ASC) ? TSDB_ORDER_ASC : TSDB_ORDER_DESC;
×
622
  if (order == TSDB_ORDER_ASC) {
×
623
    pFill->win.skey = pPhyNode->timeRange.skey;
×
624
    pFill->win.ekey = pPhyNode->timeRange.ekey;
×
625
  } else {
626
    pFill->win.skey = pPhyNode->timeRange.ekey;
×
627
    pFill->win.ekey = pPhyNode->timeRange.skey;
×
628
  }
629

630
  return TSDB_CODE_SUCCESS;
×
631
}
632

633
int32_t createFillOperatorInfo(SOperatorInfo* downstream, SFillPhysiNode* pPhyFillNode,
933✔
634
                                      SExecTaskInfo* pTaskInfo, SOperatorInfo** pOptrInfo) {
635
  QRY_PARAM_CHECK(pOptrInfo);
933!
636
  int32_t code = 0;
933✔
637
  int32_t lino = 0;
933✔
638

639
  SFillOperatorInfo* pInfo = taosMemoryCalloc(1, sizeof(SFillOperatorInfo));
933!
640
  SOperatorInfo*     pOperator = taosMemoryCalloc(1, sizeof(SOperatorInfo));
935!
641
  if (pInfo == NULL || pOperator == NULL) {
935!
642
    code = terrno;
×
643
    goto _error;
×
644
  }
645

646
  pOperator->pPhyNode = pPhyFillNode;
935✔
647
  pInfo->pRes = createDataBlockFromDescNode(pPhyFillNode->node.pOutputDataBlockDesc);
935✔
648
  QUERY_CHECK_NULL(pInfo->pRes, code, lino, _error, terrno);
936!
649
  SExprInfo* pExprInfo = NULL;
936✔
650

651
  code = createExprInfo(pPhyFillNode->pFillExprs, NULL, &pExprInfo, &pInfo->numOfExpr);
936✔
652
  QUERY_CHECK_CODE(code, lino, _error);
936!
653

654
  pOperator->exprSupp.pExprInfo = pExprInfo;
936✔
655
  pOperator->exprSupp.numOfExprs = pInfo->numOfExpr;
936✔
656

657
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
936✔
658
  code = createExprInfo(pPhyFillNode->pNotFillExprs, NULL, &pNoFillSupp->pExprInfo, &pNoFillSupp->numOfExprs);
936✔
659
  QUERY_CHECK_CODE(code, lino, _error);
936!
660

661
  code = createPrimaryTsExprIfNeeded(pInfo, pPhyFillNode, pNoFillSupp, pTaskInfo->id.str);
936✔
662
  QUERY_CHECK_CODE(code, lino, _error);
936!
663

664
  code =
665
      initExprSupp(pNoFillSupp, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs, &pTaskInfo->storageAPI.functionStore);
936✔
666
  QUERY_CHECK_CODE(code, lino, _error);
936!
667

668
  code = createExprInfo(pPhyFillNode->pFillNullExprs, NULL, &pInfo->fillNullExprSupp.pExprInfo,
936✔
669
                        &pInfo->fillNullExprSupp.numOfExprs);
670
  QUERY_CHECK_CODE(code, lino, _error);
936!
671
  code = initExprSupp(&pInfo->fillNullExprSupp, pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
936✔
672
                      &pTaskInfo->storageAPI.functionStore);
673
  QUERY_CHECK_CODE(code, lino, _error);
936!
674

675
  SInterval* pInterval =
936✔
676
      QUERY_NODE_PHYSICAL_PLAN_MERGE_ALIGNED_INTERVAL == downstream->operatorType
936✔
677
          ? &((SMergeAlignedIntervalAggOperatorInfo*)downstream->info)->intervalAggOperatorInfo->interval
279✔
678
          : &((SIntervalAggOperatorInfo*)downstream->info)->interval;
936✔
679

680
  int32_t order = (pPhyFillNode->node.inputTsOrder == ORDER_ASC) ? TSDB_ORDER_ASC : TSDB_ORDER_DESC;
936✔
681
  int32_t type = convertFillType(pPhyFillNode->mode);
936✔
682

683
  SResultInfo* pResultInfo = &pOperator->resultInfo;
935✔
684

685
  initResultSizeInfo(&pOperator->resultInfo, 4096);
935✔
686
  code = blockDataEnsureCapacity(pInfo->pRes, pOperator->resultInfo.capacity);
935✔
687
  if (code != TSDB_CODE_SUCCESS) {
936!
688
    goto _error;
×
689
  }
690
  code = initExprSupp(&pOperator->exprSupp, pExprInfo, pInfo->numOfExpr, &pTaskInfo->storageAPI.functionStore);
936✔
691
  if (code != TSDB_CODE_SUCCESS) {
936!
692
    goto _error;
×
693
  }
694

695
  pInfo->primaryTsCol = ((STargetNode*)pPhyFillNode->pWStartTs)->slotId;
936✔
696
  pInfo->primarySrcSlotId = ((SColumnNode*)((STargetNode*)pPhyFillNode->pWStartTs)->pExpr)->slotId;
936✔
697

698
  int32_t numOfOutputCols = 0;
936✔
699
  code = extractColMatchInfo(pPhyFillNode->pFillExprs, pPhyFillNode->node.pOutputDataBlockDesc, &numOfOutputCols,
936✔
700
                             COL_MATCH_FROM_SLOT_ID, &pInfo->matchInfo);
701

702
  QUERY_CHECK_CODE(code, lino, _error);
936!
703
  code = initFillInfo(pInfo, pExprInfo, pInfo->numOfExpr, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs,
936✔
704
                      pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
705
                      (SNodeListNode*)pPhyFillNode->pValues, pPhyFillNode->timeRange, pResultInfo->capacity,
936✔
706
                      pTaskInfo->id.str, pInterval, type, order, pTaskInfo);
936✔
707
  if (code != TSDB_CODE_SUCCESS) {
936!
708
    goto _error;
×
709
  }
710
  TSWAP(pInfo->pTimeRange, pPhyFillNode->pTimeRange);
936✔
711
  pInfo->pFinalRes = NULL;
936✔
712

713
  code = createOneDataBlock(pInfo->pRes, false, &pInfo->pFinalRes);
936✔
714
  if (code) {
935!
715
    goto _error;
×
716
  }
717

718
  code = blockDataEnsureCapacity(pInfo->pFinalRes, pOperator->resultInfo.capacity);
935✔
719
  if (code != TSDB_CODE_SUCCESS) {
936!
720
    goto _error;
×
721
  }
722

723
  code = filterInitFromNode((SNode*)pPhyFillNode->node.pConditions, &pOperator->exprSupp.pFilterInfo, 0,
936✔
724
                            pTaskInfo->pStreamRuntimeInfo);
936✔
725
  if (code != TSDB_CODE_SUCCESS) {
936!
726
    goto _error;
×
727
  }
728

729
  setOperatorInfo(pOperator, "FillOperator", QUERY_NODE_PHYSICAL_PLAN_FILL, false, OP_NOT_OPENED, pInfo, pTaskInfo);
936✔
730
  pOperator->fpSet = createOperatorFpSet(optrDummyOpenFn, doFillNext, NULL, destroyFillOperatorInfo, optrDefaultBufFn, NULL,
936✔
731
                                         optrDefaultGetNextExtFn, NULL);
732
  setOperatorResetStateFn(pOperator, resetFillOperState);
936✔
733

734
  code = appendDownstream(pOperator, &downstream, 1);
936✔
735
  if (code != TSDB_CODE_SUCCESS) {
936!
736
    goto _error;
×
737
  }
738

739
  *pOptrInfo = pOperator;
936✔
740
  return TSDB_CODE_SUCCESS;
936✔
741

742
_error:
×
743
  qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
744

745
  if (pInfo != NULL) {
×
746
    destroyFillOperatorInfo(pInfo);
×
747
  }
748
  destroyOperatorAndDownstreams(pOperator, &downstream, 1);
×
749
  pTaskInfo->code = code;
×
750
  return code;
×
751
}
752

753
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order) {
1,505✔
754
  int64_t skey, ekey, next;
755
  if (order == TSDB_ORDER_ASC) {
1,505✔
756
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
1,404✔
757
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
1,404✔
758

759
    ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
1,404✔
760
    next = ekey;
1,404✔
761
    while (next < pInfo->win.ekey) {
1,735✔
762
      next = taosTimeAdd(ekey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
331✔
763
                         pInfo->pFillInfo->interval.precision, NULL);
331✔
764
      if (next == ekey) break;
331!
765
      ekey = next > pInfo->win.ekey ? ekey : next;
331✔
766
    }
767
    pInfo->win.ekey = ekey;
1,404✔
768
  } else {
769
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
101✔
770
    next = skey;
101✔
771
    while (next < pInfo->win.skey) {
209✔
772
      next = taosTimeAdd(skey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
108✔
773
                         pInfo->pFillInfo->interval.precision, NULL);
108✔
774
      if (next == skey) break;
108!
775
      skey = next > pInfo->win.skey ? skey : next;
108✔
776
    }
777
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
101✔
778
    pInfo->win.ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
101✔
779
  }
780
}
1,505✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc