#4665

Committed 18 Oct 2025 06:57AM UTC coverage: 36.302% (-0.02%) from 36.322%

Build # #4665

Build Type

push

github

Committed by

topframe

Commit Message

Fix(jetty): Prevent Logback context shutdown on restart

When running in the Aspectran Shell, restarting the service via the `restart` command would cause all Logback logging to cease.

This was caused by Jetty's `WebAppContext` automatically discovering and running Logback's `LogbackServletContainerInitializer`. This initializer registers a `LogbackServletContextListener` that, upon the web application's context destruction during the restart, would shut down the entire shared, JVM-wide `LoggerContext`.

This commit fixes the issue by preventing the `LogbackServletContainerInitializer` from running. It achieves this by programmatically setting the standard Logback context parameter `logbackDisableServletContainerInitializer` to `true` for every `JettyWebAppContext` instance.

The implementation is:
- Located in `JettyServer.handleDeferredInitialize()` to ensure it covers all web applications managed by the server.
- Defensive: It uses reflection to confirm that Logback is the active SLF4J implementation before applying the fix, thus avoiding a hard dependency.

Coverage Stats

10 of 11 new or added lines in 1 file covered. (90.91%)

562 existing lines in 19 files now uncovered.

15038 of 41425 relevant lines covered (36.3%)

0.36 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.15

/core/src/main/java/com/aspectran/core/context/DefaultActivityContext.java

Build SHA Not Found

The commit SHA "e38824d2dc6fee012027d50e3c0a09d396b73e9c" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

aspectran / aspectran / #4665

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous