18595223322

Committed 17 Oct 2025 02:07PM UTC coverage: 53.038% (+0.01%) from 53.024%

Build # 18595223322

Build Type

push

github

Committed by

rubensworks

Commit Message

Fix broken block-update-based aspect invalidation

Was caused by 9bdd91138

Run Details

2875 of 8772 branches covered (32.77%)

Branch coverage included in aggregate %.

17335 of 29333 relevant lines covered (59.1%)

3.07 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

10.71

/src/main/java/org/cyclops/integrateddynamics/part/PartTypePanelLightStatic.java

package org.cyclops.integrateddynamics.part;

import net.minecraft.core.Direction;
import net.minecraft.world.level.BlockGetter;
import net.minecraft.world.level.block.Block;
import net.minecraft.world.level.block.state.BlockBehaviour;
import org.cyclops.cyclopscore.config.extendedconfig.BlockConfigCommon;
import org.cyclops.integrateddynamics.GeneralConfig;
import org.cyclops.integrateddynamics.api.network.INetwork;
import org.cyclops.integrateddynamics.api.network.IPartNetwork;
import org.cyclops.integrateddynamics.api.part.PartTarget;
import org.cyclops.integrateddynamics.core.block.IgnoredBlock;
import org.cyclops.integrateddynamics.core.part.PartStateEmpty;
import org.cyclops.integrateddynamics.core.part.panel.PartTypePanel;

import javax.annotation.Nullable;

/**
 * A panel part that simply emits light.
 * @author rubensworks
 */
public class PartTypePanelLightStatic extends PartTypePanel<PartTypePanelLightStatic, PartStateEmpty<PartTypePanelLightStatic>> {

    public static final int LIGHT_LEVEL = 15;

    public PartTypePanelLightStatic(String name) {
        super(name);
    }

    @Override
    public boolean supportsOffsets() {
        return false;
    }

    @Override
    protected Block createBlock(BlockConfigCommon<?> blockConfig, BlockBehaviour.Properties properties) {
        return new IgnoredBlock(properties);
    }

    @Override
    public PartStateEmpty<PartTypePanelLightStatic> constructDefaultState() {
        return new PartStateEmpty<PartTypePanelLightStatic>();
    }

    @Override
    public int getConsumptionRate(PartStateEmpty<PartTypePanelLightStatic> state) {
        return GeneralConfig.panelLightStaticBaseConsumption;
    }

    @Override
    public void onNetworkAddition(INetwork network, IPartNetwork partNetwork, PartTarget target, PartStateEmpty<PartTypePanelLightStatic> state) {
        super.onNetworkAddition(network, partNetwork, target, state);
        PartTypePanelLightDynamic.setLightLevel(target, LIGHT_LEVEL);
    }

    @Override
    public void onBlockNeighborChange(INetwork network, IPartNetwork partNetwork, PartTarget target,
                                      PartStateEmpty<PartTypePanelLightStatic> state, BlockGetter world, @Nullable Direction side) {
        super.onBlockNeighborChange(network, partNetwork, target, state, world, side);
        PartTypePanelLightDynamic.setLightLevel(target, LIGHT_LEVEL);
    }

    @Override
    public void onNetworkRemoval(INetwork network, IPartNetwork partNetwork, PartTarget target, PartStateEmpty<PartTypePanelLightStatic> state) {
        super.onNetworkRemoval(network, partNetwork, target, state);
        PartTypePanelLightDynamic.setLightLevel(target, 0);
    }

    @Override
    public void onPostRemoved(INetwork network, IPartNetwork partNetwork, PartTarget target, PartStateEmpty<PartTypePanelLightStatic> state) {
        super.onPostRemoved(network, partNetwork, target, state);
        PartTypePanelLightDynamic.setLightLevel(target, 0);
    }

    @Override
    public void postUpdate(INetwork network, IPartNetwork partNetwork, PartTarget target, PartStateEmpty<PartTypePanelLightStatic> state, boolean updated) {
        boolean wasEnabled = isEnabled(state);
        super.postUpdate(network, partNetwork, target, state, updated);
        boolean isEnabled = isEnabled(state);
        if(wasEnabled != isEnabled) {
            PartTypePanelLightDynamic.setLightLevel(target, isEnabled ? LIGHT_LEVEL : 0);
        }
    }
}

1	package org.cyclops.integrateddynamics.part;
2
3	import net.minecraft.core.Direction;
4	import net.minecraft.world.level.BlockGetter;
5	import net.minecraft.world.level.block.Block;
6	import net.minecraft.world.level.block.state.BlockBehaviour;
7	import org.cyclops.cyclopscore.config.extendedconfig.BlockConfigCommon;
8	import org.cyclops.integrateddynamics.GeneralConfig;
9	import org.cyclops.integrateddynamics.api.network.INetwork;
10	import org.cyclops.integrateddynamics.api.network.IPartNetwork;
11	import org.cyclops.integrateddynamics.api.part.PartTarget;
12	import org.cyclops.integrateddynamics.core.block.IgnoredBlock;
13	import org.cyclops.integrateddynamics.core.part.PartStateEmpty;
14	import org.cyclops.integrateddynamics.core.part.panel.PartTypePanel;
15
16	import javax.annotation.Nullable;
17
18	/**
19	* A panel part that simply emits light.
20	* @author rubensworks
21	*/
22	public class PartTypePanelLightStatic extends PartTypePanel<PartTypePanelLightStatic, PartStateEmpty<PartTypePanelLightStatic>> {
23
24	public static final int LIGHT_LEVEL = 15;
25
26	public PartTypePanelLightStatic(String name) {
27	super(name);	3✔
28	}	1✔
29
30	@Override
31	public boolean supportsOffsets() {
32	return false;	×
33	}
34
35	@Override
36	protected Block createBlock(BlockConfigCommon<?> blockConfig, BlockBehaviour.Properties properties) {
37	return new IgnoredBlock(properties);	5✔
38	}
39
40	@Override
41	public PartStateEmpty<PartTypePanelLightStatic> constructDefaultState() {
42	return new PartStateEmpty<PartTypePanelLightStatic>();	×
43	}
44
45	@Override
46	public int getConsumptionRate(PartStateEmpty<PartTypePanelLightStatic> state) {
47	return GeneralConfig.panelLightStaticBaseConsumption;	×
48	}
49
50	@Override
51	public void onNetworkAddition(INetwork network, IPartNetwork partNetwork, PartTarget target, PartStateEmpty<PartTypePanelLightStatic> state) {
52	super.onNetworkAddition(network, partNetwork, target, state);	×
53	PartTypePanelLightDynamic.setLightLevel(target, LIGHT_LEVEL);	×
54	}	×
55
56	@Override
57	public void onBlockNeighborChange(INetwork network, IPartNetwork partNetwork, PartTarget target,
58	PartStateEmpty<PartTypePanelLightStatic> state, BlockGetter world, @Nullable Direction side) {
59	super.onBlockNeighborChange(network, partNetwork, target, state, world, side);	×
60	PartTypePanelLightDynamic.setLightLevel(target, LIGHT_LEVEL);	×
61	}	×
62
63	@Override
64	public void onNetworkRemoval(INetwork network, IPartNetwork partNetwork, PartTarget target, PartStateEmpty<PartTypePanelLightStatic> state) {
65	super.onNetworkRemoval(network, partNetwork, target, state);	×
66	PartTypePanelLightDynamic.setLightLevel(target, 0);	×
67	}	×
68
69	@Override
70	public void onPostRemoved(INetwork network, IPartNetwork partNetwork, PartTarget target, PartStateEmpty<PartTypePanelLightStatic> state) {
71	super.onPostRemoved(network, partNetwork, target, state);	×
72	PartTypePanelLightDynamic.setLightLevel(target, 0);	×
73	}	×
74
75	@Override
76	public void postUpdate(INetwork network, IPartNetwork partNetwork, PartTarget target, PartStateEmpty<PartTypePanelLightStatic> state, boolean updated) {
77	boolean wasEnabled = isEnabled(state);	×
78	super.postUpdate(network, partNetwork, target, state, updated);	×
79	boolean isEnabled = isEnabled(state);	×
80	if(wasEnabled != isEnabled) {	×
81	PartTypePanelLightDynamic.setLightLevel(target, isEnabled ? LIGHT_LEVEL : 0);	×
82	}
83	}	×
84	}

CyclopsMC / IntegratedDynamics / 18595223322

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous